Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9994 - Fix draw sequence on menu exit

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Monday, 09 March 2009, 10:04 GMT+2
Last edited by Steve Bavin (pondlife) - Tuesday, 10 March 2009, 08:34 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As spotted by Bryan Vandyke on  FS#8894 :

"In file menu.c in the do_menu() function about line 623 the function do_setting_from_menu is called. When this function returns true, the original parent menu is redrawn. (The function returns true when the variable in question changes.) Lower in do_menu function, the menucallback with ACTION_EXIT_MENUITEM is called. (which is where the splash screen is displayed) And finally the parent menu is redrawn again.

so what happens is

change setting menu
CHANGE
redraw
callback with splash.

change setting menu
NO CHANGE
callback with splash
redraw"

The attached patch removes the code responsible for this inconsistency. I can't find any problems resulting, but I suspect there was a reason for having 2 code paths, so please enlighten me!
   menu_draw_fix.patch (1.8 KiB) 
 apps/menu.h |    2 +-
 apps/menu.c |   17 ++---------------
 2 files changed, 3 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 10 March 2009, 08:34 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks to Bryan again!
Comment by Thomas Martitz (kugel.) - Monday, 09 March 2009, 16:20 GMT+2
Good catch. I only spot one possible problem. The parent probably needs to be reinititialized if the setting in question changes the vp, like toggling the statusbar. I'll look into it.
Comment by Jonathan Gordon (jdgordon) - Tuesday, 10 March 2009, 04:54 GMT+2
from a quick first glance it looks ok... if kugel is happy to double check im happy with that... dont really have much stamina for rockbox atm :/
Comment by Thomas Martitz (kugel.) - Tuesday, 10 March 2009, 05:44 GMT+2
Should be fine, from my tests. This init_menu_lists *should* be deprecated anyway.

Loading...