release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Wiki > Main > TargetTree (compare)

Difference: TargetTree (r2 vs. r1)

The Target Tree structure

General

Rockbox builds on many different targets. We need a way to separate the target specific code to keep the common/generic code as clean as possible. The traditional solution in Rockbox so far has been to use #ifdef to conditionally compile target specific stuff.

void my_hw_init(void) {
#ifdef IRIVER_H100_SERIES
    or_l(0x00020000, &GPIO1_ENABLE);
#elif defined(IRIVER_H300_SERIES)
    or_l(0x00040000, &GPIO1_ENABLE);
#endif
}

When we have many targets, these #ifdef statements will clutter the code. The solution is to move the target specific code to separate files. The idea is that each target defines its own my_hw_init() function in a separate file, and the firmware/SOURCES file decides what files to compile depending on the target.

The directory structure

The target tree is divided into subdirectories, where each directory is an abstraction level.

   firmware/target/<cpu>/<manufacturer>/<model>/

The idea is to have CPU-specific code in the <cpu> directory, manufacturer specific stuff in <manufacturer> etc. For example, a Coldfire optimized memcpy() would be put in firmware/target/coldfire/memcpy.S firmware/target/coldfire/memcpy-coldfire.S , and the firmware/SOURCES file would contain something like this:

#ifndef SIMULATOR
#ifdef CPU_COLDFIREtarget/coldfire/memcpy.S target/coldfire/memcpy-coldfire.S # endif
#endif

Backlight example

The backlight code is a perfect example of the benefit of the target tree structure. Here we have a generic functionality that turns off the backlight after a user-defined timeout. However, controlling the actual backlight is done differently in virtually all targets. The backlight code calls two functions, __backlight_on() and __backlight_off() to turn on and off the backlight, and these two have to be defined in a target specific file. Let's take the iAudio X5 as an example. The backlight code is in the X5 target directory:

firmware/target/coldfire/iaudio/x5/backlight-x5.c

The file is called backlight-x5.c to make it easier to distinguish from the generic one when doing a file search. We recommend you to do the same when you port to a new target. This file defines the __backlight_xxx() functions:

void __backlight_on(void)
{
    int level = set_irq_level(HIGHEST_IRQ_LEVEL);
    pcf50606_write(0x38, 0x30); /* Backlight ON */
    set_irq_level(level);
}

void __backlight_off(void)
{
    int level = set_irq_level(HIGHEST_IRQ_LEVEL);
    pcf50606_write(0x38, 0x70); /* Backlight OFF */
    set_irq_level(level);
}

What about targets not yet ported to the target tree?

The tools/configure script adds a preprocessor macro, TARGET_TREE for targets that use the target tree. For older targets, the old #ifdef hell is still there. Here's how it typically looks in the generic source file:

#ifndef TARGET_TREE
void my_hw_init(void) {
#ifdef IRIVER_H100_SERIES
bla bla
#elif defined(IRIVER_H300_SERIES)
bla bla
#endif
}
#endif

The function is defined in the generic file unless the TARGET_TREE macro is defined. The goal is to remove all target specific code to the target tree, but we're not there yet.

What about include files?

The target tree is supposed to use the firmware/SOURCES file to select the source files to compile for each target. However, there are occasions where you want to have target specific information in an include file, like setting up preprocessor macros to be used by the generic driver file. The solution is to have a *_target.h file which is included by the generic driver file. The include search path for target-tree enabled targets is as follows:

firmware/target/<cpu>/<manufacturer>/<model>
firmware/target/<cpu>/<manufacturer>/
firmware/target/<cpu>/

For example, the firmware/drivers/m5636.h file does this:

#include "m5636-target.h"

The m5636-target.h is in the target specific directory, for example firmware/target/coldfire/iaudio/x5/m5636-target.h, along with firmware/target/coldfire/iaudio/x5/m5636-x5.c.

r3 - 24 Sep 2008 - 14:02:10 - MarcGuay

Revision r2 - 25 Jul 2006 - 10:53 - LinusNielsenFeltzing
Revision r1 - 25 Jul 2006 - 09:25 - LinusNielsenFeltzing
Copyright by the contributing authors.