Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2012-07-31

00:01:05TheDarkPirateSaint: and I want to know is there is a way to have podcasts in my "rockbox ipod" and that they don't mix with the regular music
00:01:17kugelmy fixes break checkwps :\
00:01:43 Join perrikwp_ [0] (
00:01:54freqmodis there a way to make rockbox mark the (podcast) files which have been listened to?
00:02:43[Saint]TheDarkPirate: Rockbox doesn't care how the files get on your player, or (with the exception of the /.rockbox directory) where they are placed.
00:03:05[Saint]As for your second question, I'm not sure I understand what you mean.
00:03:06freqmodi would think that programs runing on the host computer (which downloads podcasts) is out of scope for rockbox
00:03:31[Saint]freqmod: It is offtopic, yes, you're quite correct.
00:03:46 Join perrikwp__ [0] (
00:03:57TheDarkPirateSaint: Mmm, ok. I'm new in all of this, sorry if my question was so basic
00:04:40[Saint]TheDarkPirate: You can use any application you like to sync your music, you can also just "drag & drop" and arrange your music/files manually.
00:04:52 Quit perrikwp (Ping timeout: 264 seconds)
00:04:56 Quit perrikwp_ (Read error: Operation timed out)
00:05:30TheDarkPirateSaint: Yes, that's what I've seen, I just thought that it might be some special program to do it better, or something
00:06:24[Saint]And as for "is a way to have podcasts in my "rockbox ipod" and that they don't mix with the regular music?", the only answer I can think of is to simply not include the directory the podcast(s) are in when making a playlist.
00:08:29 Quit perrikwp__ (Read error: Connection reset by peer)
00:08:33[Saint]kugel is working on something that will allow you to easily decide which folders are scanned by the database, and which aren't, but if you went down that road you would need to always play your podcasts from the file browser.
00:09:22TheDarkPirateSaint: That sounds nice! How can I use it?
00:09:45 Join perrikwp [0] (
00:09:54[Saint]At the moment, you would need to compile your own build with the patch included.
00:10:04[Saint]You can dis-include directories from being scanned by the database already, by using a "database.ignore" file also.
00:10:31 Quit TheSphinX_ (Ping timeout: 245 seconds)
00:10:39[Saint]The patch I am talking about just simplifies this process with a nice menu.
00:11:24TheDarkPirateis that info in the manual?
00:11:40 Quit Wardo (Read error: Connection reset by peer)
00:11:41[Saint]I believe so.
00:11:47[Saint]If you don't want a particular directory to be scanned by the database, create a blank text file and save it as "database.ignore" and place it in the directory you don't want scanned.
00:12:06TheDarkPiratethanks a lot! that's so helpful!!! :D
00:12:41[Saint]It is recursive, so all directories within a directory that includes a database.ignore file won't be scanned unless they contain a database.unigore file.
00:12:42kugel[Saint]: it's in master since a few hours
00:13:11[Saint]TheDarkPirate: Oh! Apparently the patch I am talking about was just committed.
00:13:28[Saint]So, if you update to a current build, it will be a lot easier to manage.
00:13:29 Quit perrikwp (Read error: Connection reset by peer)
00:14:11gevaerts[Saint]: a current dev build!
00:14:29[Saint]kugel: thanks for that...apparently I'm not getting commit tyweets. :-S
00:14:29TheDarkPirateHow can I update? I'm using an iPod Classic 120G, it's working with emCORE, and I made the installation from that site
00:14:42 Join perrikwp [0] (
00:15:55kugelman, we really need our own bootloader for the classic
00:16:16kugel(or declare emcore the official one, i dont care)
00:16:28[Saint]TheDarkPirate: If you are still using the release build for the Classic, you will see a LOT of improvements.
00:16:31TheDarkPirateyes, that would be useful!
00:16:41TheDarkPirateSaint: Ok
00:16:50TheDarkPiratepeople, I've got to go, see ya!
00:17:02TheDarkPiratethanks a lot for everything!
00:17:03[Saint]kugel: emCORE really isn't suited for installation by RbUtil
00:17:30[Saint]and, its way too powerful for an average user.
00:17:48 Quit TheDarkPirate (Quit: Leaving.)
00:18:21[Saint]A very. very, very stripped down emCORE would be nice, perhaps.
00:18:35[Saint]As it is now, I wouldn't recommend it.
00:18:53kugelisnt emcore already a stripped down rockbox? last time i looked it included lots of our code
00:19:00[Saint]Its just a case of having to use it, as there's no other way to boot Rockbox. ;)
00:19:11[Saint]kugel: not really, no.
00:19:40[Saint]Rockbox probably uses more emCORE code now than emCORE uses Rockbox code.
00:21:51[Saint]In the event that a stripped down emCORE is fashioned into a bootloader, it would be nice to use it for Nano2G also.
00:21:53 Join perrikwp_ [0] (
00:23:34kugelI will look further into fixing the dbtool later (hint: it's also functionally broken). feel free to revert my stuff in the meantime if it's not acceptable. I'm really tired now.
00:24:19 Quit perrikwp (Ping timeout: 248 seconds)
00:24:38 Join perrikwp [0] (
00:26:39 Quit perrikwp_ (Ping timeout: 255 seconds)
00:31:42 Quit pamaury (Remote host closed the connection)
00:54:39 Quit ender` (Quit: error compiling committee.c: too many arguments to function)
00:56:04JdGordon+4K for nothing but a fancy GUI?! :/
00:56:20JdGordon</sarcasm> :)
00:58:52 Quit mgottschlag (Ping timeout: 264 seconds)
01:03:15 Quit bertrik (Ping timeout: 248 seconds)
01:08:17 Quit GeekShadow (Ping timeout: 240 seconds)
01:13:36 Join GeekShadow [0] (
01:40:19***Saving seen data "./dancer.seen"
01:48:02 Quit Thra11 (Read error: Operation timed out)
01:58:48 Join Transformer [0] (
02:01:06 Quit Transformer (Excess Flood)
02:02:31 Quit Miche (Quit: Verlassend)
02:09:11 Quit MethoS- (Ping timeout: 272 seconds)
02:20:17 Quit [Saint] (Remote host closed the connection)
02:32:09 Quit Totalled (Read error: Operation timed out)
02:39:32 Quit Rower85 (Quit: Hmmm...)
02:42:31 Quit TheLemonMan (Quit: WeeChat 0.3.8)
02:49:05 Quit ukleinek (Ping timeout: 272 seconds)
02:49:44 Join ukleinek [0] (~ukl@2001:6f8:1178:2:21e:67ff:fe11:9c5c)
02:52:23 Join sinthetek [0] (
02:52:23 Quit sinthetek (Changing host)
02:52:23 Join sinthetek [0] (~sinthetek@unaffiliated/sinthetek)
02:52:44 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
03:07:31 Join Totalled [0] (
03:08:42 Quit [Saint] (Read error: Connection reset by peer)
03:10:35 Join amayer [0] (
03:15:48 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
03:15:58 Quit [Saint] (Client Quit)
03:16:33 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
03:20:00 Join saratoga [0] (98032909@gateway/web/freenode/ip.
03:20:02saratogajhMikeS: ping
03:20:57 Quit Totalled (Ping timeout: 240 seconds)
03:26:32 Join Totalled [0] (
03:40:20***Saving seen data "./dancer.seen"
03:53:46 Quit Unhelpful (Read error: Connection reset by peer)
03:54:00 Join Unhelpful [0] (~quassel@rockbox/developer/Unhelpful)
04:09:41 Quit Unhelpful (Ping timeout: 264 seconds)
04:14:07 Quit TheSeven (Disconnected by services)
04:14:17 Join [7] [0] (~quassel@rockbox/developer/TheSeven)
04:21:51 Quit [Saint] (Quit: Quit)
04:23:29 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
04:24:23 Quit [Saint] (Client Quit)
04:25:12 Part amayer
04:27:29 Join yuriks_ [0] (~yuriks@
04:27:44 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
04:30:18 Quit yuriks (Ping timeout: 240 seconds)
04:32:06 Quit pixelma (Disconnected by services)
04:32:07 Join pixelma_ [0] (pixelma@rockbox/staff/pixelma)
04:32:09 Nick pixelma_ is now known as pixelma (pixelma@rockbox/staff/pixelma)
04:32:23 Quit amiconn (Disconnected by services)
04:32:24 Join amiconn_ [0] (quassel@rockbox/developer/amiconn)
04:32:29 Nick amiconn_ is now known as amiconn (quassel@rockbox/developer/amiconn)
04:39:11 Quit [Saint] (Read error: Connection reset by peer)
04:39:16 Join [Saint_] [0] (~Saint]@unaffiliated/saint/x-8516940)
04:47:19saratogajhMikeS: i don't understand the DSP_PROC_DB_ENTRY macros, can you explain what those actually do?
04:52:30 Quit GeekShadow (Remote host closed the connection)
04:52:44 Join GeekShadow [0] (
04:53:45 Quit saratoga (Ping timeout: 245 seconds)
04:58:32 Join saratoga [0] (98032909@gateway/web/freenode/ip.
05:33:40 Quit Kumul (Quit: gone)
05:35:33 Quit Jack87 (Quit: Jack has left the building.)
05:37:42 Join Jack87 [0] (Jack87@nasadmin/admin/jack87)
05:40:24***Saving seen data "./dancer.seen"
05:46:32 Quit scorche` (Quit: blah)
06:05:21 Quit XavierGr ()
06:35:20 Join kevku [0] (
07:03:11 Join zz_TheSphinX^ [0] (~briehl@
07:28:13 Quit Scromple (Read error: Connection reset by peer)
07:40:25***Saving seen data "./dancer.seen"
08:08:32 Quit [Saint_] (Ping timeout: 255 seconds)
08:10:00 Join [Saint] [0] (~Saint]@unaffiliated/saint/x-8516940)
08:15:51 Quit advcomp2019 (Read error: Connection reset by peer)
08:16:23 Join advcomp2019 [0] (
08:16:24 Quit advcomp2019 (Changing host)
08:16:24 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
08:17:41 Join scorche [0] (~scorche@rockbox/administrator/scorche)
08:21:31 Quit yuriks_ (Changing host)
08:21:31 Join yuriks_ [0] (~yuriks@opentyrian/developer/yuriks)
08:30:32 Join ender` [0] (
08:37:37 Quit perrikwp (Read error: Connection reset by peer)
08:38:50 Join perrikwp [0] (
08:43:29 Join Zagor [0] (
08:43:30 Quit Zagor (Changing host)
08:43:30 Join Zagor [242] (~bjst@rockbox/developer/Zagor)
08:43:36Zagoryay, manuals
08:57:19 Join mgottschlag [0] (~quassel@reactos/tester/phoenix64)
09:11:38 Quit [Saint] (Ping timeout: 260 seconds)
09:12:28 Join einhirn [0] (
09:19:49 Join TheLemonMan [0] (
09:19:49 Quit TheLemonMan (Changing host)
09:19:49 Join TheLemonMan [0] (~LemonBoy@unaffiliated/thelemonman)
09:33:24 Quit Topy (Quit: Leaving)
09:40:29***Saving seen data "./dancer.seen"
09:53:55kugelhm, cabbiev2 fails to parse cabbiev2
09:54:10kugeland there's 0 debug output
10:03:26 Join pamaury [0] (
10:03:26 Quit pamaury (Changing host)
10:03:26 Join pamaury [0] (~quassel@rockbox/developer/pamaury)
10:06:23CIA-5Commit b358bcf in rockbox by Thomas Martitz: checkwps: Simplify expression.
10:09:31CIA-5b358bcf build result: 6 errors, 0 warnings (Thomas Martitz committed)
10:20:17 Quit Bagder (Ping timeout: 240 seconds)
10:28:59 Join Bagder [241] (~daniel@rockbox/developer/bagder)
10:37:54CIA-5Commit efe73e1 in rockbox by Thomas Martitz: Fix database tool.
10:40:57CIA-5efe73e1 build result: All green
10:42:26kugelwhy does the delta table show n/a for the ipod classic?
10:43:05kugelah wait, it appears twice there and only one column shows n/a
10:43:38gevaertsThat's weird. Zagor?
10:44:48gevaertskugel: I'm not entirely sure about b358bcf, actually. I think you should also check if ext!=0
10:45:55 Join MethoS- [0] (~clemens@
10:45:58gevaertsZagor: I renamed that build a while ago, so this might be related to that
10:46:51kugelgevaerts: right
10:49:58kugelno extension should be invalid
10:52:27 Join Keripo [0] (
10:53:15Zagorgevaerts: looks like I'm missing some cleanup. we've got delta logs sinze jan 19 :-)
10:57:39CIA-5Commit 1e7f606 in rockbox by Thomas Martitz: checkwps: harden filename extension checking.
11:00:31CIA-51e7f606 build result: All green
11:04:30kugelso, who's gonna do the manual bits of the new database bits/folder selector?
11:08:07kugelAlexP: ? :)
11:08:36 Quit scorche (Ping timeout: 255 seconds)
11:11:33 Quit Torne (Quit: moving back to real server, bbiab)
11:12:35 Quit fs-bluebot (Ping timeout: 272 seconds)
11:12:38 Quit bluebrother (Ping timeout: 246 seconds)
11:12:52 Join joe_ [0] (
11:14:06 Join fs-bluebot [0] (
11:15:03 Join bluebrother [0] (~dom@rockbox/developer/bluebrother)
11:21:29 Join Torne [0] (~torne@rockbox/developer/Torne)
11:29:27 Quit mgottschlag (Read error: Operation timed out)
11:40:30***Saving seen data "./dancer.seen"
11:47:17 Join bertrik [0] (
11:54:36 Join mgottschlag [0] (~quassel@2a00:1398:9:fb00:85ea:7ed6:b514:9b1d)
11:54:37 Quit mgottschlag (Changing host)
11:54:37 Join mgottschlag [0] (~quassel@reactos/tester/phoenix64)
11:58:46 Part POX
12:08:20CIA-5Commit e666ded in www by Björn Stenberg: Include <hash>.sizes when removing old files.
12:12:12 Join Ward [0] (
12:12:36 Nick Ward is now known as Guest99117 (
12:41:27 Quit Keripo (Quit: Leaving.)
13:06:49 Quit einhirn (Quit: Miranda IM! Smaller, Faster, Easier.
13:10:49 Join Thra11 [0] (~thrall@
13:14:48 Join benedikt93 [0] (~benedikt9@unaffiliated/benedikt93)
13:36:41 Quit Guest99117 (Quit: Blarglarg)
13:37:03 Quit mgottschlag (Ping timeout: 246 seconds)
13:40:31***Saving seen data "./dancer.seen"
13:46:25 Join Rower85 [0] (
13:55:10 Join mgottschlag [0] (~quassel@2a00:1398:9:fb00:108:5239:6c7c:fd29)
13:55:11 Quit mgottschlag (Changing host)
13:55:11 Join mgottschlag [0] (~quassel@reactos/tester/phoenix64)
13:58:04 Quit factor (Quit: Leaving)
14:18:14 Join mortalis [0] (~mortalis@
14:20:33 Join einhirn [0] (
14:39:25freqmodfreqmod/rockbox-opus/commit/26fe838724a1ec8c750b30f820f912878287f321"> - patch for making opus continue from last position when rebooting etc
14:39:30freqmodbertrik: ^
14:39:48freqmodi don't want to mess upp gerrit so I just leave it at github
14:40:29funmanfreqmod: btw what did you change in your last patchset?
14:40:49freqmodonly opus.c
14:41:10freqmod(i copied the seek functions from speex, and replaced the if test for seeking)
14:42:36freqmodother changes may have slipped in, but i tried not to comit changes to any other files
14:44:12freqmodi tried to distangle all the patches in the change as separate patches
14:44:24freqmodbut I am not good enough in git to manage it :/
14:59:00 Quit einhirn (Quit: Miranda IM! Smaller, Faster, Easier.
15:09:31 Join mgottschlag2 [0] (~quassel@2a00:1398:200:200:108:5239:6c7c:fd29)
15:10:09 Quit mgottschlag (Ping timeout: 246 seconds)
15:10:32 Join perrikwp_ [0] (
15:13:16 Quit perrikwp (Ping timeout: 240 seconds)
15:14:39 Join einhirn [0] (
15:40:33***Saving seen data "./dancer.seen"
16:11:12 Quit Zagor (Quit: Clint excited)
16:14:16 Join amayer [0] (
16:19:20 Join Thra11_ [0] (~thrall@
16:21:16 Quit Thra11 (Ping timeout: 240 seconds)
16:25:50 Join XavierGr [0] (~xavier@rockbox/staff/XavierGr)
16:45:57 Join Newformz [0] (
16:46:32NewformzIs anyone available for support please?
16:47:48 Quit Newformz (Client Quit)
16:49:43 Join Zagor [0] (
16:49:43 Quit Zagor (Changing host)
16:49:43 Join Zagor [242] (~bjst@rockbox/developer/Zagor)
16:53:39 Join pretty_function [0] (~sigBART@
17:08:23 Join y4n [0] (~y4n@unaffiliated/y4ndexx)
17:18:35 Quit einhirn (Quit: Miranda IM! Smaller, Faster, Easier.
17:22:03 Join scorche [0] (~scorche@rockbox/administrator/scorche)
17:29:02 Quit TheLemonMan (Quit: WeeChat 0.3.8)
17:30:53bertrikfreqmod (or anyone else with github knowledge), I'd prefer to do all development on some branch with individual commits, do you know how this works with github?
17:31:28kugelbertrik: push the branch
17:31:40kugelgit push <branch> <remote> iirc
17:32:31freqmodbertrik: github supports many forms for collaboration
17:32:38bertrikso anyone can commit to any project?
17:32:45freqmodso if you have a username i can add you as an admin to my project
17:33:16freqmodbertrik: no, they have a system on the web for managing access
17:33:39Tornebertrik: the expectation usually is that you fork the repo and send pull requests
17:33:43Tornerather than having a branch in their repo
17:33:45freqmodbut everybody can for the projects and then submit pull requests
17:34:03freqmodit depends on how often and integrated the development is
17:34:24kugelTorne: but github also supports working together on the same repo
17:34:49bertrikfork, re-fork and ask for a pull sounds like a rather indirect way of cooperation
17:35:12freqmodi have added the "bertrik" user as a colaborator on freqmod/rockbox-opus">
17:35:21freqmodso now you should be able to push
17:35:28Tornekugel: you can, but it does nothing to help that be sensible
17:35:44Torneit's all-or-nothing
17:35:52Tornee.g. now bertrik can delete the whole thing :p
17:36:06freqmodbut i have a local copy :S
17:36:14Tornenot suggesting he would, but it's just not the workflow github encourages in general
17:36:32Torneif you're going to work on a different branch to freqmod anyway there is literally no difference at all
17:36:48Torneforking it on github and working in your own fork is exactly the same as working on a different branch in someone else's repo
17:36:49freqmodi would like to think that the colaborators are the same as giving "commit access" in svn
17:37:04Torneyou only actually need to work in the same fork if you are moving the same branch head
17:37:45*freqmod don't really care how it is done as long as we don't squash all small changes in to a huge patch agains the rockbox-trunk
17:38:11Tornehow are you intending to submit when it's done?
17:38:42Tornebecause if the answer isn't "squash all small changes into a huge patch against the rockbox master branch" you should probably be preparing for it already :p
17:38:49freqmodthe best thing would be to merge the branches :/
17:39:00Tornein my experience that is virtually never the best thing
17:39:15freqmodbut i am not good enough with git to split it up
17:39:29freqmodTorne: isn't it how the linux kernel is developed?
17:40:23Tornethe linux kernel is developed by people posting neat patch serieses to mailing lists/people, which are applied as neat serieses by various maintainers with am
17:40:35***Saving seen data "./dancer.seen"
17:40:43Tornebecause linux is such a large project, ther eare some merges going on at a higher level between subssytem maintainers/linus/etc
17:40:58bertrikthe current way of development can't be much worse: huge patch + small -> new huge patch, so I prefer a separate git repo where people push small changes
17:41:12Tornebut that's just to aggregate sets of neat changes together :)
17:42:08Tornebertrik: i'm not making any specific suggestion about what you do now while you're working on it; that's up to you guys who are working on it
17:42:23Tornei am just saying, that i would very much prefer if, when it's done and it's time to land it, it's neither a merge nor a squashed patch
17:42:27Tornebut rather a tidy series :)
17:43:16 Quit pretty_function (Read error: Connection reset by peer)
17:43:35 Join pretty_function [0] (~sigBART@
17:43:48Tornei don't think you have to be particularly good with git to do this
17:44:09Torneit's "just" a matter of fidning the interesting intermediate states and recording them
17:45:11Torneyes. we are generally not using a model like that at present
17:45:44Tornei have encouraged people toward a model more like the projects i work on that don't drive me crazy
17:45:53Tornerather than the ones that make me want to stab people :p
17:46:15Tornethis is entirely open for discussion, dno't get me wrong
17:46:53bertrikit's a bit too late for small successive changes for the stuff that's already done
17:46:56Tornei'm stating what i'd prefer personally, and it happens to also be what everyone has done up until now (largely beause developers are familiar with svn, or are willing to follow my suggestion, rather than necessarily because they have sat and considered it)
17:47:16Tornebertrik: i don't think that's actually the case, but i haven't looked
17:47:18freqmodI have no problem in squashing all the patches together when it is done TM (and going to be committed to the main tree)
17:47:45freqmodbut it is a real hassle to work, merge and review the huge patches when a feature is under development
17:47:55Tornefreqmod: yes, that's why you don't work like that
17:47:57Torneyou work on a patch series
17:48:16freqmodbut gerrit wouldn't accept my patch series :(
17:48:19Torneif you never have a huge patch to start with, you never have to deal with merging/reviewing a huge patch
17:48:34Tornewhat do you mean?
17:48:45Torneif you had a problem with gerrit the thing to do is to ask someone, surely :)
17:48:51*freqmod tries not to consider creating a patch series of the whole opus project
17:48:55kugelTorne: he did :)
17:49:06Tornewaht was the problem?
17:49:12kugelfor a codec a single large patch is fine IMO
17:49:22Tornekugel: probably, yes, for the codec itself
17:49:31Torneit might be nice to have the unmodified upstream files as a step
17:49:36Tornei.e. a patch that introduces the original files
17:49:48Tornethen a second one that moves it to the final state as a working codec
17:50:04Torneas a base to use to merge upstream changes if we ever need to
17:50:07freqmodwe nearly have that in gerrit
17:50:24freqmodbut all the patches have to be against the upstream trunk
17:50:30freqmodand not based upon eachother
17:50:41freqmodotherwise it won't be accepted by the gerrit system
17:50:45Torneno, you are wrong
17:50:52Tornegerrit absolutely can and does accept patch serieses
17:50:55freqmodok, problably
17:50:59Torneif it wouldn't take your upload you are doing it wrong
17:51:01freqmodbut i was not able to fix it
17:51:07Tornewell, then you should've asked
17:51:08freqmodand asked here for help
17:51:16kugelTorne: he *did*
17:51:18freqmodand was told to squash it
17:51:22Tornethen whoever said that is wrong
17:51:40Torneanyway. you have the files still, no?
17:51:48Torneit should take all of five seconds to reconstruct what i just suggested
17:51:55freqmodwell all are squashed together
17:51:57kugelgerrit asked to squash
17:52:11kugelI assume since 300 already existed when the second commit was added
17:52:23Tornekugel: that doesn't sound like a thing it does
17:52:42Torneit's perfectly possible to upload changes that depend on other unmerged changes
17:52:48Torneat the same time, or later
17:52:52Tornemakes no difference
17:53:12Torneeach commit in your branch becomes a change on gerrit, with the dependencies recorded between them
17:53:24freqmod - from the irc channek
17:53:51Tornefreqmod: that doesn't include what you actually tried to do, or the message, so it's not very useful
17:54:00Torneuploading "to 300" is not a thing
17:54:01freqmodTorne: :(
17:54:04Torneyou don't upload to a particular change
17:54:07Torneyou upload to refs/for/master
17:54:15 Join Kumul [0] (
17:54:24Torneso i'm not sure what you were doing, but it doesn't sound like it was right :)
17:54:25freqmodi wanted everything to be in the same changeset for it to be easy to track
17:54:32Tornethat's not how it works
17:54:35Tornea change is a patch
17:54:38Tornea patch series is a change series
17:54:41Tornei.e. more than one change
17:54:57Torneit's trivial to track: they are linked by dependencies, and you can give the series a name to be able to list them all as well
17:55:06Torneby pushing to refs/for/master/sometopic
17:55:18Tornewhich will set the "topic" field on the change, which youc an click on to see the whole series
17:55:31Torneif you were trying to upload multiple commits to one change, that's why it didn't work
17:55:48Torneyou don't ever need to push to a specific change; you just push to somewhere under the magic refs/for and it figures it out for you based on change-id
17:56:16freqmodi did that at last, by copying the change id
17:56:34Torneyou shouldn't have to copy the change id either; you should be amending your previous commits, which will keep the change id the same
17:56:35freqmodbut clearly we have misunderstood how gerrit should be used
17:56:55Tornethe point of the change id is it gets created per new commit
17:57:02Torneand you rewrite old commits to produce new versions
17:57:10freqmodbut amending the previous commits results in one big patch?
17:57:31Torneno, you have one commit for each thing that will be in your final patch series
17:57:43Tornewhen you change something, you amend the *appropriate* commit to include the change
17:57:58bertrikfreqmod, how up-to-date is your fork on github now? compared to the patch on gerrit?
17:58:24Tornefreqmod: the idea is that throughout development you have one commit per patch-that-you-will-ultimately-submit
17:58:56freqmodbertrik: it should be the same as patch 8
17:58:57Torneif your change is small then that probably will be just one, but if it's something bigger, then more than one. but the commits should be split up based on logical incremental steps, in the right order
17:59:09Tornenot be the individual things you did during development in the order you did them
17:59:15freqmod+ my initial offset fix
17:59:34Tornebecause nobody wants to see, say, a commit that introduces some new code that has a bug, then a fix for that bug, merged in one go; the intermediate state is useless
18:00:02kugelthat's why i said gerrit is for code review, not collaboration
18:00:42Torneit's perfectly possible to collaborate using this approach
18:00:44Tornei do it all the time
18:00:54Torneit's no more work than any other way
18:01:21freqmodprobably not
18:01:23Torneyou can modify other people's changes, you realise
18:01:32Torneyou don't have to be the original author to push a new version of a change
18:01:33freqmodbut i couldn't find a proper guide for doing it
18:01:44Tornefreqmod: that's because we don't have one
18:01:50Tornebecause nobody has taken the time to write one
18:01:51freqmod(on the gerrit pages)
18:01:53Tornefeel free to do so :)
18:02:12freqmoda blind man leading the blind :P
18:02:49Tornei have been asking for a while for people to ask questions so we can add more stuff to the docs to cover common workflows
18:02:53Torneand people largely haven't asked :)
18:03:10Tornemeeting, bbiab.
18:05:54bertrikI think we can have a workable workflow by doing the development and bugfixing on github then push it as a single commit to rockbox
18:08:44bertrikfurther performance tuning can be done in the rockbox repo IMO
18:09:00 Quit mgottschlag2 (Ping timeout: 246 seconds)
18:12:38 Join lebellium [0] (
18:14:44 Quit hype (Quit: ["Textual IRC Client:"])
18:29:44 Join n1s [0] (
18:29:44 Quit n1s (Changing host)
18:29:44 Join n1s [0] (~n1s@rockbox/developer/n1s)
18:31:08 Join prof_wolfff [0] (
18:39:21 Join perrikwp [0] (
18:40:52 Quit perrikwp_ (Ping timeout: 264 seconds)
18:42:46 Join perrikwp_ [0] (
18:44:05 Quit perrikwp (Read error: Operation timed out)
18:46:52 Quit bertrik (Ping timeout: 246 seconds)
18:49:10 Join Strife89 [0] (~Strife89@
18:53:16 Join perrikwp [0] (
18:53:45 Quit perrikwp_ (Ping timeout: 252 seconds)
19:00:24 Quit n1s (Read error: Connection timed out)
19:01:59Tornefreqmod: i had a look at the change, and i'd suggest that wants to be probably two or three commits: one adding the original version of the libopus files (without your changes), one modifying anything that needs modifying, and one modifying the stuff in core (filetypes/etc) to actually get the codec to be used
19:02:10 Part Kumul ("gone")
19:02:24Tornefreqmod: that should be quite easy to do without any special git knowledge
19:02:31 Quit dys (Ping timeout: 272 seconds)
19:02:42Tornei do think it's important to commit the unmodified files for reference
19:03:48 Join dys [0] (~user@2a01:1e8:e100:8296:21a:4dff:fe4e:273a)
19:04:22 Quit advcomp2019 (Read error: Connection reset by peer)
19:04:49 Join advcomp2019 [0] (
19:04:50 Quit advcomp2019 (Changing host)
19:04:50 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
19:06:25 Join mgottschlag [0] (
19:06:25 Quit mgottschlag (Changing host)
19:06:25 Join mgottschlag [0] (~quassel@reactos/tester/phoenix64)
19:07:58 Quit pretty_function (Remote host closed the connection)
19:12:36 Join bertrik [0] (
19:35:43 Join pretty_function [0] (~sigBART@
19:38:11 Quit KiwiCam (Ping timeout: 244 seconds)
19:40:39***Saving seen data "./dancer.seen"
19:50:02 Join saratoga_ [0] (98034408@gateway/web/freenode/ip.
19:50:13 Join KiwiCam [0] (~KiwiCAM@
19:51:24 Part saratoga_
19:51:32 Join saratoga_ [0] (98034408@gateway/web/freenode/ip.
19:51:41 Quit saratoga_ (Client Quit)
19:52:09 Join saratoga_ [0] (98034408@gateway/web/freenode/ip.
19:56:14 Quit saratoga_ (Ping timeout: 245 seconds)
19:59:43 Quit advcomp2019 (Ping timeout: 260 seconds)
20:04:58 Part amayer
20:07:05 Quit linuxstb (Quit: This computer has gone to sleep)
20:09:25 Join amayer [0] (
20:30:17 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
20:49:07 Join perrikwp_ [0] (
20:52:13 Quit perrikwp (Ping timeout: 260 seconds)
21:01:09 Join n1s [0] (~n1s@rockbox/developer/n1s)
21:01:32 Join petur [0] (~petur@rockbox/developer/petur)
21:09:46 Quit perrikwp_ (Read error: Connection reset by peer)
21:11:14 Join perrikwp [0] (
21:16:24 Quit prof_wolfff (Quit: Saliendo)
21:17:40 Join linuxstb [0] (
21:23:11 Quit y4n (Quit: only amiga makes it possible)
21:38:49 Join perrikwp_ [0] (
21:40:16 Quit perrikwp (Ping timeout: 240 seconds)
21:40:43***Saving seen data "./dancer.seen"
21:41:51 Quit linuxstb (Ping timeout: 246 seconds)
21:42:53 Quit Strife89 (Quit: Heading out)
21:46:56 Quit ser (Remote host closed the connection)
21:48:33 Quit perrikwp_ (Read error: Connection reset by peer)
21:49:02 Quit pretty_function (Read error: Operation timed out)
21:49:51 Join perrikwp [0] (
21:55:47 Quit mgottschlag (Ping timeout: 260 seconds)
22:18:25 Join Kiwi_Cam [0] (~KiwiCAM@
22:19:24 Join anewuser [0] (~anewuser@
22:19:24 Quit anewuser (Changing host)
22:19:24 Join anewuser [0] (~anewuser@unaffiliated/anewuser)
22:23:07 Join ser [0] (
22:24:04 Quit petur (Remote host closed the connection)
22:24:31 Quit mortalis (Quit: KVIrc 4.1.3 Equilibrium
22:25:36 Quit perrikwp (Read error: Connection reset by peer)
22:26:44 Quit ser (Client Quit)
22:27:04 Join ser [0] (
22:29:02 Join perrikwp [0] (
22:29:08 Quit Kiwi_Cam (Quit: Going, going...Gone.)
22:29:34 Quit bertrik (Remote host closed the connection)
22:29:45 Quit KiwiCam (Quit: Going, going...Gone.)
22:31:26 Join mgottschlag [0] (
22:31:26 Quit mgottschlag (Changing host)
22:31:26 Join mgottschlag [0] (~quassel@reactos/tester/phoenix64)
22:32:34 Quit n1s (Quit: Ex-Chat)
22:35:37 Quit hillshum (Quit: Ex-Chat)
22:44:44 Quit Zagor (Quit: Clint excited)
22:44:55 Join user485763 [0] (~aoeu@
22:59:56 Join KiwiCam [0] (~KiwiCAM@
23:12:57 Part amayer
23:13:55 Join linuxstb [0] (
23:14:30 Quit linuxstb (Client Quit)
23:23:45 Quit jordan` (Ping timeout: 245 seconds)
23:24:05 Join jordan` [0] (~gromit@2001:660:3302:2826:225:90ff:fe20:d9a8)
23:29:12 Quit benedikt93 (Quit: Bye ;))
23:29:35 Quit jordan` (Ping timeout: 245 seconds)
23:31:01 Join jordan` [0] (~gromit@2001:660:3302:2826:225:90ff:fe20:d9a8)
23:31:34 Join perrikwp_ [0] (
23:32:43 Join linuxstb [0] (
23:33:09 Join linuxstb_ [0] (
23:33:27 Quit linuxstb (Disconnected by services)
23:33:30 Nick linuxstb_ is now known as linuxstb (
23:34:14 Quit perrikwp (Ping timeout: 252 seconds)
23:39:50 Join perrikwp [0] (
23:40:28 Quit perrikwp_ (Ping timeout: 252 seconds)
23:40:47***Saving seen data "./dancer.seen"
23:43:54 Quit KiwiCam (Quit: Going, going...Gone.)
23:49:14 Join KiwiCam [0] (~KiwiCAM@
23:51:00 Quit ser (Remote host closed the connection)
23:51:43 Join ser [0] (
23:52:20 Join factor [0] (
23:55:44 Quit mgottschlag (Read error: Operation timed out)
23:58:50 Quit guymann (Remote host closed the connection)

Previous day | Next day