00:00:02 | | Quit kevku (Ping timeout: 260 seconds) |
00:02:58 | Buschel | need to take some sleep, see you tomorrow |
00:03:01 | | Quit Buschel (Quit: ChatZilla 0.9.88.2 [Firefox 15.0.1/20120905151427]) |
00:05:38 | | Join Horscht [0] (~Horscht@p5DD57CCE.dip.t-dialin.net) |
00:05:38 | | Quit Horscht (Changing host) |
00:05:38 | | Join Horscht [0] (~Horscht@xbmc/user/horscht) |
00:09:45 | | Quit Horscht (Client Quit) |
00:10:27 | | Quit lebellium (Quit: ChatZilla 0.9.89 [Firefox 16.0/20121002073616]) |
00:12:42 | | Join factor [0] (~factor@r74-195-183-112.msk1cmtc01.mskgok.ok.dh.suddenlink.net) |
00:19:34 | | Quit Rower85 (Quit: Hmmm...) |
00:19:56 | | Quit ender` (Quit: 99% of lawyers give the rest a bad name.) |
00:21:34 | | Join killbillkill [0] (~bill@adsl-148.79.107.27.tellas.gr) |
00:23:22 | | Part killbillkill |
00:38:54 | | Quit sakax (Quit: Leaving) |
00:55:33 | | Quit bertrik (Remote host closed the connection) |
01:00 |
01:29:17 | | Quit mgottschlag (Ping timeout: 245 seconds) |
01:54:55 | *** | Saving seen data "./dancer.seen" |
02:00 |
02:07:10 | | Quit saratoga (Quit: Page closed) |
02:09:35 | | Quit Poodlemastah (Ping timeout: 245 seconds) |
02:29:33 | | Quit factor (Read error: Connection reset by peer) |
02:37:49 | | Part LittleCreature ("WeeChat 0.3.8") |
02:47:15 | | Join factor [0] (~factor@r74-195-183-112.msk1cmtc01.mskgok.ok.dh.suddenlink.net) |
02:50:52 | | Join Prodicus_ [0] (~chatzilla@69.169.144.239.provo.static.broadweavenetworks.net) |
02:50:56 | | Quit Prodicus (Ping timeout: 256 seconds) |
02:51:09 | | Nick Prodicus_ is now known as Prodicus (~chatzilla@69.169.144.239.provo.static.broadweavenetworks.net) |
02:54:30 | | Quit Thra11 (Ping timeout: 246 seconds) |
03:00 |
03:43:00 | | Join JdGord [0] (~AndChat80@49.176.34.75) |
03:44:33 | | Join JdG [0] (~AndChat80@49.176.3.112) |
03:46:52 | | Quit JdG (Read error: Connection reset by peer) |
03:47:28 | | Quit JdGord (Ping timeout: 264 seconds) |
03:51:07 | | Join JdGord [0] (~AndChat80@49.176.3.112) |
03:52:25 | | Join JdG [0] (~AndChat80@49.176.4.98) |
03:53:50 | | Join Raptors [0] (~Raptors@dsl-69-172-87-123.acanac.net) |
03:54:23 | Raptors | Anyone know how fuze + rockbox port is going (wiki seems to be the same as I saw it a couple months ago) |
03:54:25 | Raptors | ? |
03:54:51 | | Quit dfkt (Quit: -= SysReset 2.55=- Sic gorgiamus allos subjectatos nunc.) |
03:54:56 | *** | Saving seen data "./dancer.seen" |
03:55:00 | Raptors | I bought it today (missed out on the original fuze because my bro didn't give me his CC and forgot his password for paypal :() |
03:55:31 | | Quit JdGord (Ping timeout: 245 seconds) |
03:57:06 | Raptors | Going into this very very low expectations (from what I saw) |
03:58:19 | Raptors | Can someone please tell me that the Fuze + is not total garbage? |
03:59:57 | Raptors | I already know I'm going to be disappointed coming off of the amazing exp I had with fuze v2 for the past 3-4 years |
04:00 |
04:05:27 | | Quit JdG (Ping timeout: 244 seconds) |
04:11:09 | | Quit amiconn (Disconnected by services) |
04:11:09 | | Join amiconn_ [0] (amiconn@rockbox/developer/amiconn) |
04:11:14 | | Nick amiconn_ is now known as amiconn (amiconn@rockbox/developer/amiconn) |
04:11:39 | Raptors | amiconn, you there>? |
04:12:09 | | Join pixelma [0] (pixelma@rockbox/staff/pixelma) |
04:13:36 | | Quit pixelma_ (Ping timeout: 246 seconds) |
04:20:58 | | Join amayer [0] (~alex@h62.26.25.72.ip.windstream.net) |
04:26:19 | amayer | when you select a font in settings > theme settings > font. |
04:26:21 | amayer | if you have more then one font loaded in your current theme(ie mine has 3) which font(s) will be over writen with the new font you selected from settings? |
04:29:24 | amayer | the manual give no hints |
04:35:04 | amayer | hello *hears echo* |
04:38:04 | | Join TheSphinX_ [0] (~briehl@p579CC2DE.dip.t-dialin.net) |
04:41:23 | | Quit TheSphinX^ (Ping timeout: 248 seconds) |
04:44:44 | | Join mikroflops [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
04:47:49 | | Quit mikroflops_ (Ping timeout: 244 seconds) |
05:00 |
05:00:04 | | Quit Epicanis (*.net *.split) |
05:00:04 | | Quit zchs (*.net *.split) |
05:00:05 | | Quit Elfish (*.net *.split) |
05:00:05 | | Quit sc_ (*.net *.split) |
05:00:05 | | Quit gevaerts (*.net *.split) |
05:00:05 | | Quit desowin (*.net *.split) |
05:00:05 | | Quit knittl (*.net *.split) |
05:00:33 | | Quit fyrestorm (Read error: Connection reset by peer) |
05:00:54 | | Join fyrestorm [0] (~nnscript@cpe-67-244-91-182.nyc.res.rr.com) |
05:01:47 | | Join Rower85 [0] (husvagn@82.196.99.90) |
05:05:30 | | Join gevaerts [0] (~fg@rockbox/developer/gevaerts) |
05:05:30 | | Join desowin [0] (~desowin@pandora.barbara.ds.polsl.pl) |
05:05:30 | | Join knittl [0] (~knittl@unaffiliated/knittl) |
05:06:19 | | Join zchs [0] (~zchs@ool-ad02eb3f.dyn.optonline.net) |
05:17:37 | | Quit [7] (Disconnected by services) |
05:17:46 | | Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) |
05:23:03 | | Quit advcomp2019__ (Ping timeout: 246 seconds) |
05:23:23 | | Quit soap (Quit: soap) |
05:30:16 | | Join advcomp2019 [0] (~advcomp20@97-114-245-53.sxcy.qwest.net) |
05:30:17 | | Quit advcomp2019 (Changing host) |
05:30:17 | | Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019) |
05:34:52 | | Join soap [0] (~soap@cpe-174-102-110-153.woh.res.rr.com) |
05:34:53 | | Quit soap (Changing host) |
05:34:53 | | Join soap [0] (~soap@rockbox/staff/soap) |
05:55:00 | *** | Saving seen data "./dancer.seen" |
06:00 |
06:14:34 | | Join mikroflops_ [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
06:17:27 | | Quit mikroflops (Ping timeout: 240 seconds) |
06:46:14 | | Join pedro_angelo [0] (~pedro_ang@186-241-153-164.user.veloxzone.com.br) |
06:46:43 | | Part amayer |
06:47:14 | | Join advcomp2019_ [0] (~advcomp20@97-114-245-162.sxcy.qwest.net) |
06:47:14 | | Quit advcomp2019_ (Changing host) |
06:47:14 | | Join advcomp2019_ [0] (~advcomp20@unaffiliated/advcomp2019) |
06:48:18 | | Quit advcomp2019 (Ping timeout: 260 seconds) |
06:50:42 | | Quit ranmachan (Ping timeout: 260 seconds) |
06:52:59 | | Join ranmachan [0] (ranma@2a01:4f8:130:9321::2) |
06:56:43 | | Join mikroflops [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
06:57:12 | | Join kevku [0] (x@indeed.tastes.like.everything.mm.am) |
06:59:33 | | Quit mikroflops_ (Ping timeout: 240 seconds) |
07:00 |
07:05:53 | | Quit pedro_angelo (Remote host closed the connection) |
07:06:24 | | Quit Totalled (Quit: PETTAN PETTAN, TSURUPETTAN!) |
07:13:59 | | Join Totalled [0] (~Totalled@c-98-245-9-211.hsd1.co.comcast.net) |
07:19:12 | | Quit XavierGr (Ping timeout: 244 seconds) |
07:47:43 | | Quit Prodicus (Ping timeout: 255 seconds) |
07:55:03 | *** | Saving seen data "./dancer.seen" |
07:59:44 | | Join mikroflops_ [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
08:00 |
08:03:33 | | Quit mikroflops (Ping timeout: 260 seconds) |
08:22:30 | | Join mortalis [0] (~mortalis@195.34.194.126.kalibroao.ru) |
08:27:00 | | Join Zagor [0] (~bjst@sestofw01.enea.se) |
08:27:01 | | Quit Zagor (Changing host) |
08:27:01 | | Join Zagor [242] (~bjst@rockbox/developer/Zagor) |
08:45:26 | | Join ender` [0] (krneki@foo.eternallybored.org) |
08:56:09 | | Join lebellium [0] (~chatzilla@e179078080.adsl.alicedsl.de) |
09:00 |
09:00:26 | | Quit zoktar (Ping timeout: 260 seconds) |
09:05:08 | | Join einhirn [0] (~Miranda@p4FC74794.dip0.t-ipconnect.de) |
09:12:14 | | Join pamaury [0] (~quassel@vit94-1-82-67-248-70.fbx.proxad.net) |
09:12:14 | | Quit pamaury (Changing host) |
09:12:14 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
09:15:53 | | Join mgottschlag [0] (~quassel@reactos/tester/phoenix64) |
09:17:24 | | Join Buschel [0] (~chatzilla@p57905630.dip.t-dialin.net) |
09:26:29 | | Quit [Saint] (Remote host closed the connection) |
09:27:57 | | Join [Saint] [0] (~saint@rockbox/user/saint) |
09:47:37 | | Quit pamaury (Ping timeout: 245 seconds) |
09:55:04 | *** | Saving seen data "./dancer.seen" |
10:00 |
10:00:28 | | Join LinusN [0] (~linus@giant.haxx.se) |
10:03:43 | | Quit mgottschlag (Ping timeout: 260 seconds) |
10:23:52 | | Quit einhirn (Ping timeout: 255 seconds) |
10:29:10 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
10:33:54 | | Quit Provel (Quit: Leaving) |
10:34:48 | | Join petur [0] (~petur@rockbox/developer/petur) |
10:36:07 | | Join mgottschlag [0] (~quassel@reactos/tester/phoenix64) |
10:40:43 | | Join wodz [0] (~wodz@iwl138.internetdsl.tpnet.pl) |
11:00 |
11:04:10 | | Quit mortalis (Ping timeout: 260 seconds) |
11:17:39 | | Quit derf (Ping timeout: 248 seconds) |
11:24:40 | | Join mortalis [0] (~mortalis@195.34.194.126.kalibroao.ru) |
11:39:04 | | Quit mc2739 (Ping timeout: 244 seconds) |
11:41:14 | | Join mc2739 [0] (~mc2739@rockbox/developer/mc2739) |
11:42:58 | | Join mikroflops [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
11:46:40 | | Quit mikroflops_ (Ping timeout: 255 seconds) |
11:46:50 | | Quit Keripo (Quit: Leaving.) |
11:47:34 | | Quit bluebrother (Disconnected by services) |
11:47:40 | | Join bluebrother^ [0] (~dom@rockbox/developer/bluebrother) |
11:50:28 | | Quit fs-bluebot (Ping timeout: 260 seconds) |
11:51:53 | | Join fs-bluebot [0] (~fs-bluebo@g231121200.adsl.alicedsl.de) |
11:55:05 | *** | Saving seen data "./dancer.seen" |
12:00 |
12:09:58 | | Quit sciopath (Read error: Connection reset by peer) |
12:10:31 | | Join sciopath [0] (~sciopath@yer91-2-82-237-54-159.fbx.proxad.net) |
12:17:56 | | Join XavierGr [0] (XavierGr@rockbox/staff/XavierGr) |
12:19:02 | | Quit wodz (Quit: Leaving) |
12:23:48 | | Quit [Saint] (Read error: Connection reset by peer) |
12:24:11 | | Join [Saint] [0] (~saint@rockbox/user/saint) |
12:26:04 | | Quit petur (Quit: *plop*) |
12:32:03 | | Quit [Saint] (Ping timeout: 252 seconds) |
12:40:08 | | Join Topy [0] (~Topy44@f048107178.adsl.alicedsl.de) |
12:43:42 | | Quit T44 (Ping timeout: 246 seconds) |
12:48:05 | Buschel | n1s: i have updated the patch in the suggested way. comb_filter() can not overflow now, the performance loss is relatively low (~0.6 MHz on pp). another change now uses a local variable "coef0" within deemphasis. this is faster on pp, maybe also for cf. the patch does also contain changes in mdct and ifft to support more detailed profiling. you should not care about that for now, biut maybe... |
12:48:06 | Buschel | ...it is of help for you as well. -> http://pastie.org/4914121 |
12:50:03 | | Quit hype (Quit: ["Textual IRC Client: www.textualapp.com"]) |
13:00 |
13:04:07 | | Join zoktar [0] (~zoktar@78-70-241-206-no186.tbcn.telia.com) |
13:09:35 | | Quit zoktar (Ping timeout: 268 seconds) |
13:11:37 | | Join zoktar [0] (~zoktar@78-70-241-206-no186.tbcn.telia.com) |
13:13:03 | | Join Prodicus [0] (~chatzilla@69.169.144.239.provo.static.broadweavenetworks.net) |
13:19:35 | | Quit zoktar (Ping timeout: 252 seconds) |
13:20:37 | | Join zoktar_ [0] (~zoktar@78-70-241-206-no186.tbcn.telia.com) |
13:23:52 | | Quit pamaury (Ping timeout: 255 seconds) |
13:27:49 | | Join hype [0] (~hype@82.199.174.16) |
13:28:03 | | Join dys [0] (~user@2a01:1e8:e100:8296:21a:4dff:fe4e:273a) |
13:34:31 | | Join lorenzo92 [0] (~chatzilla@host69-110-dynamic.17-79-r.retail.telecomitalia.it) |
13:35:23 | lorenzo92 | kugel: okay I'm here to complete RDS |
13:35:32 | lorenzo92 | I need to redownload everythinh |
13:35:34 | lorenzo92 | g |
13:39:17 | | Join pamaury [0] (~quassel@sphinx.lix.polytechnique.fr) |
13:39:17 | | Quit pamaury (Changing host) |
13:39:17 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
13:39:29 | kugel | lorenzo92: what? why that? |
13:42:30 | lorenzo92 | kugel: no I mean, I need to fix the thing about gpio.c file cleanup |
13:42:37 | lorenzo92 | need help to setup git |
13:42:45 | | Quit Buschel (Ping timeout: 255 seconds) |
13:43:13 | lorenzo92 | once I fetched the patch and done the modifications, what to do to send the modification to gerrit again? |
13:43:24 | lorenzo92 | into the same patch of course |
13:45:44 | mortalis | git push origin HEAD:refs/for/master |
13:46:00 | mortalis | change id line should be the same as on gerrit |
13:55:09 | *** | Saving seen data "./dancer.seen" |
13:55:43 | lorenzo92 | mortalis: so now that I applied the patch with the link on gerrit, I need to do git push origin ...bla... without the need of doing something else? |
13:57:24 | mortalis | apply patch, make some changes, commit them (git add <changed files> & git commit −−amend) then push |
13:57:31 | gevaerts | lorenzo92: have you read through http://www.rockbox.org/wiki/UsingGit ? |
13:57:48 | lorenzo92 | yes but I'm unsure :D |
13:58:20 | lorenzo92 | mortalis: I applied with this git fetch git://git.rockbox.org/rockbox refs/changes/20/320/2 && git checkout FETCH_HEAD |
13:59:13 | lorenzo92 | perhaps need to experiment also with the sandbox :) |
14:00 |
14:00:48 | kugel | lorenzo92: most important is that you keep the change id line, then gerrit will not open a new task |
14:05:16 | lorenzo92 | kugel: okay, I did git commit −−amend, now I have the same change-id: Change-Id: I1d3cc995ea3350ec7b101438b8f2027130d4a4c9 |
14:05:45 | lorenzo92 | after committing, do I need to type the same: git push origin HEAD:refs/for/master |
14:05:59 | lorenzo92 | this because last time I don't remember the garbage I did :) |
14:06:05 | lorenzo92 | this time wanna be sure hehe |
14:09:23 | Torne | yes, it's always the same push commant; the change-id line is what matches it up to the previous one |
14:12:04 | lorenzo92 | Torne: okay, thanks, hope to do things correctly now :) to summarize, I fetch the current repository, then I apply the patch from gerrit, then I make some changes, add the new or modified files,then I do git commit −−amend, and finally push! |
14:12:35 | Torne | yep |
14:12:47 | Torne | the command you used above doesn't "apply" the patch though |
14:13:07 | Torne | it entirely replaces your local directory with whatever was current when the previous patch was written |
14:13:33 | Torne | i.e. it checks out the old version that the patch was based on |
14:13:39 | Torne | not the current version of rockbox you just downloaded |
14:13:56 | Torne | you probably want to click on "cherry pick" in gerrit |
14:14:13 | Torne | to get the version of the command that cherrypicks. this will put the patch on top of whatever you currently have, i.e. the latest, if you just updated |
14:16:26 | lorenzo92 | ahhh now it's clear, so in fact it is the same repository at the time when I wrote the first patch! now's clear it's not just a patch apply |
14:16:43 | lorenzo92 | and no I don't have to cherry pick, at least, don't know :) |
14:16:52 | Torne | yeah. checkout gives you the exact history that corresponds to the commit SHA you provide |
14:17:05 | Torne | whereas cherrypick just copies the single patch you gave it onto your current history |
14:17:34 | lorenzo92 | ok many thanks...now I try to do it :D |
14:27:27 | lorenzo92 | Torne: uhm I have some problems after applying, git add ... and commit I got 2 files changed while the change was only for one file...before committing I checked with git diff HEAD and the changes were correctly reported |
14:28:27 | lorenzo92 | is it better to check with git show? |
14:28:44 | | Join amayer_ [0] (~alex@mail.weberadvertising.com) |
14:29:04 | Torne | git diff HEAD is comparing to what's already committed |
14:29:09 | Torne | i.e. the previous version of the patch |
14:29:19 | Torne | whereas git commit −−amend is showing you everything that will be changed by the new version of the patch |
14:29:26 | Torne | including things in the old version of the patch that you have not changed since then |
14:30:47 | lorenzo92 | ok...perhaps I know what I did wrong, since I have simply copied (restored) an old file, perhaps I need to resave it, I'm checking that atm |
14:32:25 | lorenzo92 | ah by the way |
14:33:29 | lorenzo92 | is it normal that in the commit comment I see also old changes (i.e. last patch against current code)? |
14:34:56 | Torne | When you commit −−amend you are looking at what will become the new commit |
14:35:02 | Torne | i.e. everything in the old commit plus everything you have added |
14:35:15 | lorenzo92 | okay |
14:35:16 | Torne | if you want to undo something from the old commit you have to actually undo it, and add that as a change |
14:35:56 | lorenzo92 | yes this is clear indeed, was wondering if I should see also old changes, and yes that's logical :) |
14:36:07 | lorenzo92 | but I prefer to ask to avoid doing a mess hehe |
14:36:14 | lorenzo92 | as I previously did ^^ |
14:37:30 | amayer_ | is someone available to make a change to the manual? |
14:39:29 | | Join Buschel [0] (~chatzilla@p57905630.dip.t-dialin.net) |
14:39:59 | kugel | lorenzo92: did you clone the rockbox repo again? |
14:41:46 | lorenzo92 | kugel: at the moment I simply used the same repo I had on my hdd (the original one) and fetched the gerrit patch |
14:41:53 | lorenzo92 | and also edited the gpio file |
14:42:03 | lorenzo92 | now need to do git add or simply git commit? |
14:42:16 | lorenzo92 | a little confused now :) |
14:42:22 | kugel | okay, that's fine. it sounded like you did that because you said "i need to download everything again" |
14:42:33 | lorenzo92 | ah nono |
14:42:34 | kugel | you always need git add |
14:42:37 | lorenzo92 | ok |
14:42:44 | kugel | but git commit -a can do that for you |
14:42:59 | lorenzo92 | okay now I git commit −−amend? |
14:43:44 | kugel | yes |
14:44:25 | lorenzo92 | pff I don't see the gpio file :( |
14:44:33 | lorenzo92 | # Changes to be committed:# (use "git reset HEAD^1 <file>..." to unstage)## modified: firmware/export/config/samsungypr0.h# modified: firmware/target/hosted/ypr0/radio-ypr0.c |
14:45:03 | kugel | well, the gpio changes should be in a separate commit |
14:45:10 | kugel | so it's kinda good it's not there |
14:45:14 | lorenzo92 | ah yes indeed |
14:45:26 | lorenzo92 | oh right my god xD |
14:45:36 | lorenzo92 | so I can try to push? :) |
14:46:43 | kugel | yes |
14:47:50 | lorenzo92 | kugel: fatal: remote error: access denied or repository not exported: /rockbox |
14:47:52 | lorenzo92 | :O |
14:48:11 | kugel | what did you type? |
14:48:31 | lorenzo92 | git push origin HEAD:refs/for/master |
14:50:18 | kugel | hm |
14:50:40 | kugel | paste your .git/config file please |
14:50:59 | | Join bertrik [0] (~quassel@rockbox/developer/bertrik) |
14:51:43 | bootlfdhfrsa | Quick Question :: Why isn't this image format [ http://en.wikipedia.org/wiki/WebP ] available in rockbox ?? |
14:51:58 | lorenzo92 | kugel: http://pastie.org/4914612 |
14:52:41 | lorenzo92 | bootlfdhfrsa: I guess because none has implemented it :) |
14:53:05 | kugel | don't know :( ( Torne^ ?) |
14:53:55 | lorenzo92 | kugel: I can eventually try with a new rockbox fetch |
14:54:05 | lorenzo92 | maybe some fresh air works ^^ |
14:54:13 | kugel | no, no need for that |
14:54:23 | lorenzo92 | ok |
14:54:23 | kugel | perhaps try again |
14:55:03 | Torne | you haven't set the push URL |
14:55:09 | Torne | the git:// URL can only be used for pulling |
14:55:22 | Torne | (it's read only because there's no authentication in the git protocol) |
14:55:23 | lorenzo92 | uh right can be |
14:55:39 | Torne | git remote set-url −−push origin ssh://yourusername@gerrit.rockbox.org:29418/rockbox |
14:55:46 | Torne | it's in the instructions :) |
14:55:50 | kugel | oh |
14:55:52 | kugel | right |
14:56:11 | kugel | but how did you manage to push the first patches? |
14:56:28 | lorenzo92 | Torne: yes it is, in fact, strange, perhaps I did something I don't even remeber :D |
14:57:06 | Torne | kugel: good question, but it's definitely missing in the config :) |
14:57:37 | lorenzo92 | kugel, Torne: perfect guys! Thanks, I was on the right way but after all better to be sure instead of end up messing gerrit hihi |
14:57:45 | lorenzo92 | kugel: ready to check and approve |
14:57:49 | Torne | you would have to try quite hard to mess up gerrit :) |
14:58:21 | Torne | even with committer permissions there is very little you can do wrong that isn't trivial to fix |
14:58:36 | Torne | (our gerrit is configured not to allow dangerous things, mostly) |
14:58:54 | kugel | lorenzo92: now you need to make another commit for g#321 |
14:58:56 | fs-bluebot | Gerrit review #321 at http://gerrit.rockbox.org/r/321 : This patch adds RDS capability to Samsung YP-R0 target. by Lorenzo Miori (changes/21/321/1) |
14:59:24 | lorenzo92 | kugel: that is? couldn't you simply remove it from gerrit? |
14:59:31 | | Quit factor (Quit: Leaving) |
14:59:46 | kugel | lorenzo92: the gpio fixes are needed right? |
15:00 |
15:00:07 | kugel | so you need to provide the commit :) |
15:00:16 | lorenzo92 | ah well I'd prefer doing them in a separate commit something called like "YP-R0 cleanup" |
15:00:23 | lorenzo92 | kugel: they're not needed for RDS |
15:00:38 | Torne | you can still upload it over the top of 321 |
15:00:46 | Torne | you can just rewrite the commit message when you amend |
15:00:55 | Torne | it will replace the title/decription of the change when you upload it. |
15:01:03 | lorenzo92 | Torne: yes indeed, will do that :) |
15:01:29 | kugel | i know they're not needed for RDS, hence I asked to separate them out :p |
15:01:51 | Torne | (also, if you upload them from a different branch that doesn't also include the other change, it won't list them as dependent on each other) |
15:02:03 | lorenzo92 | kugel: :D |
15:02:18 | lorenzo92 | Torne: ah so I don't need to do anything special, ie. no rebase etc? |
15:02:47 | Torne | if you make a new branch from origin/master and cherrypick the GPIO change onto it, then push that branch, it will upload it as a compeltely separate change that doesn't depend on the other one |
15:02:58 | Torne | then they can be reviewed/committed independantly |
15:03:18 | Torne | if you don't know how to work with multiple branches in git then this may or may not be a good time to learn :p |
15:03:50 | lorenzo92 | okay, another question: can I eventually use gerrit to store for example versions for a patch also if the "feature" isn't working yet? |
15:04:00 | Torne | Sure. |
15:04:04 | Torne | Just upload it and don't ask anyone to review it |
15:04:11 | Torne | Maybe put a note that it's not finished in the commit message |
15:04:15 | lorenzo92 | okay, good ! |
15:04:19 | Torne | or as a review comment you put on your own change] |
15:09:20 | | Join wodz [0] (~wodz@89-76-32-53.dynamic.chello.pl) |
15:28:40 | lorenzo92 | speaking about lcd optimizations that I need to do on ypr0, what's the difference between HAVE_LCD_ENABLE and HAVE_LCD_SLEEP? In 2 words I have the possibility to shutdown the lcd and I want that rockbox goes sleeping i.e. doesn't update the graphics in the meanwhile (lcd is turned off already but I'm missing this optimization) |
15:30:46 | mortalis | lorenzo92: http://www.rockbox.org/irc/log-20120107#17:32:55 |
15:43:16 | lorenzo92 | mortalis: oh! seems I would better search in the past too :D |
15:43:20 | lorenzo92 | thanks |
15:43:28 | kugel | lorenzo92: need more help with git? (you didnt upload a new gpio patch yet) |
15:44:41 | lorenzo92 | well at the moment I was doing something different, anyways...I need to git fetch git://git.rockbox.org/rockbox refs/changes/21/321/1 && git checkout FETCH_HEAD, then make changes to my gpio.c file file and again add and commit. after that the push |
15:44:44 | lorenzo92 | got it? |
15:45:09 | | Quit mortalis (Quit: Leaving) |
15:45:46 | kugel | lorenzo92: i think you better redo the changes. the patch that you uploaded actually reverts them |
15:45:54 | | Quit Zagor (Quit: Clint excited) |
15:46:36 | kugel | dont you still the changes locally? |
15:47:19 | | Join WalkGood [0] (~4@unaffiliated/walkgood) |
15:47:49 | lorenzo92 | the only changes I have is the last patch I sumbmitted before |
15:48:20 | kugel | so gpio-ypr0.c is the same state as git master? |
15:50:08 | lorenzo92 | wait...git master is the current code right (repo)? Then yes for the patch I submitted, but no against the actual repo |
15:50:19 | lorenzo92 | don't know if it's clear ^^ |
15:51:53 | lorenzo92 | mortalis: in case of LCD_SLEEP, graphics behind won't be continuosly updated right? |
15:55:11 | *** | Saving seen data "./dancer.seen" |
15:56:32 | kugel | lorenzo92: I don't understand |
15:56:40 | | Part LinusN |
15:56:46 | kugel | right now there is no patch that has your gpio fixes |
15:57:26 | amayer_ | on http://download.rockbox.org/daily/manual/rockbox-ipodvideo/rockbox-buildch13.html about half way down there is a line that says: |
15:57:29 | lorenzo92 | kugel: okay. so the point is. what if I fetch the latest repo, adding the gpio changes and then committing the patch again to gerrit (using the same ID)? |
15:57:29 | amayer_ | %?mp<Stop|%Play|Pause|Ffwd|Rew> |
15:57:31 | amayer_ | im pretty sure it should say: |
15:57:33 | amayer_ | %?mp<Stop|Play|Pause|Ffwd|Rew>(take out the % next to play) |
15:58:08 | kugel | lorenzo92: yes, that sounds like the right way to do it |
15:58:42 | lorenzo92 | kugel: perfect, last doubt, to add the same ID I must only add it into the commit comment right? nothing else apart updating the remote url? |
15:59:29 | kugel | right, the last line should be e.g. "Change-Id: I6db2a2cc0ec640db24e4f462ae14f15bcfa025cb" |
15:59:48 | lorenzo92 | good now I'm understanding git much more hehe |
16:00 |
16:00:00 | Torne | It needs to be in a separate paragraph |
16:00:06 | Torne | i.e. blank line before it |
16:01:25 | lorenzo92 | Torne: yes I use the same "style" as for the others.... |
16:03:55 | wodz | Does SH have iram? If so it is used for plugins? |
16:04:06 | wodz | s/it is/is it/ |
16:05:45 | wodz | ok SH do have iram, now I need to figure out if it is available to plugins |
16:08:22 | kugel | wodz: it's all in config.h |
16:08:47 | | Quit lorenzo92 (Quit: ChatZilla 0.9.89 [Firefox 15.0.1/20120907231657]) |
16:08:57 | wodz | not all, a lot is in plugins.lds :-) |
16:09:47 | Torne | right, but i meant, it's not a stylistic choice, it's how git tools parse commit messages |
16:09:56 | Torne | metadata is in email style headers in the last paragraph; anywhere else it's ignored |
16:09:59 | Torne | oh he's gone |
16:14:07 | wodz | gevaerts: ping |
16:15:16 | wodz | or other make gurus, I need to run appropriate strip −−strip-unneeded −−strip-debug on plugins elf. I can't manage to do that. Any help welcome |
16:16:40 | | Part amayer_ |
16:22:04 | | Join Elfish [0] (amba@2a01:4f8:100:90a1:abc:abc:abc:abc) |
16:22:23 | kugel | wodz: you found the place where to do it. what's your question? |
16:25:54 | wodz | the syntax :P $(shell arm-elf-eabi-strip −−strip-unneeded −−strip-debug $(BUILDDIR)/$*.rock) doesn't work |
16:26:52 | wodz | despite the fact that it should be smart enough to take strip appropriate for the target architecture |
16:29:57 | kugel | try $(wildcard $(BUILDDIR)/*.rock) |
16:30:25 | kugel | no wait, it should work on a single file at a time right? |
16:30:42 | wodz | yes |
16:31:29 | kugel | what do you mean by doesnt work? |
16:31:47 | kugel | also a tip: it's helpful to run make V=1 to see what command make runs |
16:32:15 | wodz | I know. The error message is like arm-elf-eabi-strip: '/home/wodz/rockbox/build/apps/plugins/lua/lua.rock': No such file |
16:32:33 | wodz | but the file /home/wodz/rockbox/build/apps/plugins/lua/lua.rock do exists |
16:33:50 | kugel | where did you insert it? |
16:34:10 | kugel | I expect $*.rock to produce something like lua.elf.rock or lua.rock.rocj |
16:34:16 | kugel | s/rocj/rock/ |
16:35:39 | | Join amayer_ [0] (~alex@mail.weberadvertising.com) |
16:37:36 | wodz | http://pastie.org/4915010 |
16:37:49 | wodz | both versions return the same error |
16:40:18 | kugel | wodz: no idea, sorry |
16:43:55 | wodz | this drives me crazy :/ |
17:00 |
17:09:07 | | Join eckoit [0] (~ryan@70.75.173.39) |
17:11:07 | wodz | how to see DEBUGF() output? I compiled the build with debug support and now what? |
17:12:37 | kugel | I dont think you can see DEBUGF() on-target |
17:13:09 | wodz | so... how to see the output? |
17:14:44 | kugel | not at all? |
17:15:27 | kugel | unless DEBUGF() goes into a file since saratoga's logging patch? |
17:16:19 | wodz | ekhm |
17:16:40 | | Join saratoga [0] (123e0cca@gateway/web/freenode/ip.18.62.12.202) |
17:16:54 | saratoga | wodz: DEBUGF doesn't work on target, although you can use the new disk logging system via ERRORF |
17:17:30 | wodz | saratoga: ok - is that somewhere documented how to use new system? |
17:17:45 | saratoga | i sent an email to the mailing list over the summer explaining it |
17:17:59 | saratoga | but basically you call that function like DEBUGF and it ends up in a log file in the root of your player |
17:18:17 | saratoga | (provided you don't crash before the next disk spin up on HD targets) |
17:18:25 | wodz | it had some additional params, no? |
17:18:39 | saratoga | eventually DEBUGF will be folded into that system but i have had no time lately |
17:19:07 | saratoga | no just like debugf |
17:19:24 | saratoga | ERRORF maps to something like disklog(WARNINGLEVEL, ....) |
17:19:35 | wodz | ok, lets try |
17:21:50 | wodz | saratoga: Do I still need debug build to take this into effect? |
17:22:14 | amayer_ | can someone review g#324 |
17:22:16 | fs-bluebot | Gerrit review #324 at http://gerrit.rockbox.org/r/324 : Corrected typo '%Play' with 'Play' on line 407 by Alex Mayer (changes/24/324/1) |
17:22:26 | saratoga | wodz: no its in all builds |
17:22:30 | saratoga | even the releases |
17:22:43 | saratoga | so any ERRORF code you commit will log for everyone's builds |
17:22:44 | wodz | ok |
17:22:54 | saratoga | although by default WARNF and NOTEF are ignored in normal builds |
17:23:42 | saratoga | the idea is that if you have some condition that should never happen, you use ERRORF so that if it happens users can report it |
17:23:56 | saratoga | for example a malloc that fails, a null pointer, etc |
17:24:10 | AlexP | amayer_: i submitted that, thanks |
17:24:37 | saratoga | long term i was hoping to get the codecs, database, buffering code well logged so that we can actually debug random errors |
17:24:42 | AlexP | amayer_: Just personal preference, but I tend to start all manual commit messages with "manual: do blah" |
17:24:58 | | Join bootinfdsds [0] (~Prmhfhfx@92.39.204.151) |
17:25:08 | | Nick AlexP is now known as AlexP_ (~alex@rockbox/staff/AlexP) |
17:25:26 | amayer_ | AlexP_: makes sense. ill have to remember that |
17:25:45 | AlexP_ | Just so people can safely ignore it :) |
17:28:00 | | Quit bootlfdhfrsa (Ping timeout: 240 seconds) |
17:29:21 | | Quit eckoit (Read error: Connection reset by peer) |
17:29:50 | | Join eckoit [0] (~ryan@70.75.173.39) |
17:30:34 | wodz | ok if I use ERRORF() and want to see output I need to compile debug build, right? |
17:30:53 | saratoga | no any build will work |
17:31:05 | wodz | something is not working then |
17:31:27 | saratoga | where are you putting the ERRORF call? |
17:31:43 | saratoga | maybe its a header problem |
17:33:10 | wodz | maybe it bombs out earlier not reaching my logging part |
17:35:35 | | Quit eckoit (Read error: No route to host) |
17:37:19 | | Join eckoit [0] (~ryan@70.75.173.39) |
17:41:42 | | Join fling [0] (~fling@fsf/member/fling) |
17:42:04 | amayer_ | if i want to add "show icons: on" to WPSLIST |
17:42:05 | | Quit Topy (Read error: Connection reset by peer) |
17:42:06 | amayer_ | do i need to make a new variable in wpsbuild.pl? |
17:42:16 | fling | Hello! Will Rockbox work on iRiver T30? |
17:44:23 | wodz | saratoga: The file should be saved on clean shutdown, right? |
17:44:29 | wodz | fling: no |
17:45:02 | | Join prof_wolfff [0] (~prof_wolf@213.37.219.103.dyn.user.ono.com) |
17:48:02 | fling | wodz: is not it planned/possible in future? |
17:50:38 | wodz | fling: nobody did the job, so I can't tell if this is possible or not |
17:51:33 | | Quit hype (Quit: ["Textual IRC Client: www.textualapp.com"]) |
17:52:51 | pamaury | amayer_: +1 for prefixing commits if possible, so you can quickly know where it belongs :) |
17:53:21 | amayer_ | pamaury: should i prefix every commit? |
17:53:35 | wodz | saratoga: I can't make ERRORF() to work :/ |
17:54:03 | amayer_ | pamaury: you mean like AlexP said? putting "manual: " at the begining? |
17:54:57 | pamaury | yes, but more generally you'll notice many people put "x:" at the beginning where x can be manual or just anything! |
17:55:14 | *** | Saving seen data "./dancer.seen" |
17:55:25 | pamaury | there is no rule though |
17:56:22 | AlexP_ | amayer_: There isn't a rule, and for things like the manual it is obvious what to use - in other places it isn't possible or appropriate, but if something seems to fit it can help others |
17:57:51 | amayer_ | AlexP_ what about something like wpsbuild.pl? would i put "wpsbuild: fixed ...". something like that? |
17:58:03 | AlexP_ | yeah, that would be good |
17:58:28 | AlexP_ | It is up to you, but if you can think of a quick prefi that might help people then that would be good :) |
17:58:57 | pamaury | another example: many people who work on targets put the name of the target (rk27xx, imx233, as3525, ...) |
17:59:24 | pamaury | same thing for codecs |
17:59:51 | AlexP_ | yeah, "mp3: fix seeking in xxx" "clip+: fix snake" etc |
18:00 |
18:00:07 | AlexP_ | or whatever :) |
18:00:47 | AlexP_ | Don't worry about trying to force one in if it doesn't fit though |
18:01:19 | amayer_ | ok will do |
18:03:40 | saratoga | wodz: you can verify that its enabled for your target by putting a call to it right here: http://git.rockbox.org/?p=rockbox.git;a=blob;f=apps/main.c;h=6b6566c7ca1b9241ebfff6f477d73784707e8a1c;hb=HEAD#l493 |
18:03:59 | saratoga | ERRORF("test\n"); |
18:04:12 | saratoga | and yes it worked for me on clean shutdown, at least on the sandisk players |
18:08:56 | saratoga | i don't have a player here to test with though |
18:12:33 | | Quit pamaury (Ping timeout: 246 seconds) |
18:12:33 | | Quit mgottschlag (Ping timeout: 246 seconds) |
18:22:27 | | Quit wodz (Read error: Connection reset by peer) |
18:23:30 | fling | ok |
18:26:45 | saratoga | what is ifdef (CODEC) actually checkign for? |
18:26:49 | saratoga | its impossible to grep that |
18:28:04 | amayer_ | can someone look at g#325 and tell me if i got all that right? |
18:28:05 | fs-bluebot | Gerrit review #325 at http://gerrit.rockbox.org/r/325 : wpsbuild: added 'show icons' setting to build by Alex Mayer (changes/25/325/1) |
18:42:39 | | Join Horscht [0] (~Horscht@p5490C8E0.dip.t-dialin.net) |
18:42:40 | | Quit Horscht (Changing host) |
18:42:40 | | Join Horscht [0] (~Horscht@xbmc/user/horscht) |
18:49:11 | | Join wodz [0] (~wodz@89-76-32-53.dynamic.chello.pl) |
18:49:33 | * | wodz is proud to announce first relocatable elf plugin running on PP |
18:52:21 | | Join pretty_function [0] (~sigBART@123.252.213.213) |
18:57:02 | amayer_ | does anyone have a screen with a remote display? |
19:00 |
19:00:23 | wodz | amayer_: what you mean? |
19:05:33 | amayer_ | well there are settings for remote displays. im wondering if there is a "remote show icons:" setting |
19:06:02 | wodz | dunno, but you can use sim for targets with remotes to test. |
19:06:31 | wodz | iriver h100 for example |
19:06:35 | amayer_ | i dont have any build stuff here. |
19:06:37 | amayer_ | do you need build stuff for sim? |
19:06:49 | amayer_ | im on linux ubuntu(at work) |
19:07:10 | lebellium | I have a H320 with LCD remote |
19:07:57 | lebellium | there is no "remote show icons" setting |
19:08:18 | amayer_ | did you read that im manual? or test on device? |
19:08:43 | lebellium | the H320 is in my hand |
19:09:17 | amayer_ | does the remote screen have icons? |
19:10:46 | lebellium | wait I check |
19:11:31 | lebellium | yes |
19:11:40 | lebellium | the setting applies for both |
19:11:42 | lebellium | no choice |
19:11:52 | lebellium | both the main unit and remote* |
19:12:14 | amayer_ | lebellium: thank you for checking |
19:12:24 | amayer_ | *going to lunch* bbs |
19:23:16 | | Quit WalkGood () |
19:45:09 | | Quit Rower85 (Quit: Hmmm...) |
19:45:33 | Raptors | Does anyone know how the Fuze+ port is going? |
19:45:56 | Raptors | has the trackpad been improved or is it still a dpad? |
19:46:49 | Raptors | Asking because (as I said yesterday) I bought a Fuze+ because the Fuze orignal got sold out due to my bro not fixing his paypal. Reluctantly got the Fuze+ in hopes rockbox would fix the UI |
19:46:59 | Raptors | and since it was cheap |
19:47:27 | | Quit Prodicus (Quit: ChatZilla 0.9.88.2 [Firefox 15.0.1/20120905151427]) |
19:48:49 | | Join mikroflops_ [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
19:50:42 | wodz | Raptors: ask pamaury |
19:51:27 | Raptors | wodz, where is he? |
19:51:31 | Raptors | offline? |
19:51:53 | | Quit mikroflops (Ping timeout: 256 seconds) |
19:52:57 | wodz | Raptors: apparently but he is often active |
19:55:15 | *** | Saving seen data "./dancer.seen" |
20:00 |
20:03:32 | | Join Provel [0] (~Provel@75-132-15-43.dhcp.stls.mo.charter.com) |
20:12:56 | | Quit amayer_ (Quit: going ~/) |
20:18:12 | | Nick AlexP_ is now known as AlexP (~alex@rockbox/staff/AlexP) |
20:44:43 | | Join amayer_ [0] (~alex@mail.weberadvertising.com) |
20:58:18 | amayer_ | question: i dont want to seem rude but am i allowed to add myself to the credits? |
20:59:57 | wodz | you mean in gerrit ticket? |
21:00 |
21:00:37 | amayer_ | *shrugs* |
21:00:39 | amayer_ | /docs/credits |
21:00:50 | amayer_ | wodz: ^ |
21:00:57 | wodz | if you have commit access you can |
21:01:00 | gevaerts | We should recheck CREDITS. I'm not sure if people have maintained it properly since the git switch |
21:01:01 | | Quit ender` (Read error: Connection reset by peer) |
21:01:33 | | Join ender` [0] (krneki@foo.eternallybored.org) |
21:01:54 | wodz | gevaerts: could you help with plugins.make? I want to run appropriate strip command on resulting elf |
21:01:56 | amayer_ | i dont have commit access. |
21:01:58 | amayer_ | isnt it just a list of everyone that has helped out with the project? |
21:02:27 | wodz | amayer_: by help we consider code or major art work |
21:03:01 | AlexP | amayer_: It isn't really the contributor who does that |
21:03:15 | AlexP | If the person submitting considers it enough to get in, they should ad it |
21:03:28 | gevaerts | There's been a discussion a while ago about who should be in CREDITS. I can't remember if it was here or on the ML |
21:03:41 | AlexP | It is a bit bebulous |
21:03:43 | gevaerts | wodz: do you have a full patch somewhere? |
21:03:46 | AlexP | er, nebulous |
21:04:02 | wodz | g#326 |
21:04:04 | fs-bluebot | Gerrit review #326 at http://gerrit.rockbox.org/r/326 : ELF loader for plugins by Marcin Bukat (changes/26/326/1) |
21:04:26 | amayer_ | wodz: AlexP: ok well ill wait until i have some more commits under my belt before i do that |
21:04:53 | AlexP | amayer_: It is a very blurry line |
21:05:15 | AlexP | amayer_: e.g. the typo fix I committed earlier wouldn't be enough |
21:05:25 | AlexP | But it is hard to say what would be |
21:06:01 | amayer_ | AlexP: i get that |
21:06:03 | amayer_ | most of the stuff i do is small things here and there. i havent done anything note worth (YET) |
21:06:09 | AlexP | :) |
21:07:29 | amayer_ | well speaking of commits, anyone that knows perl: g#325 |
21:07:30 | fs-bluebot | Gerrit review #325 at http://gerrit.rockbox.org/r/325 : wpsbuild: added 'show icons' setting to build by Alex Mayer (changes/25/325/1) |
21:08:33 | AlexP | Another question is whether that setting should be part of a theme |
21:08:47 | AlexP | And if so, does cabbie set it when selected? |
21:10:43 | gevaerts | wodz: I assume the main issue is that plugins.make still needs the bits you pasted earlier today? |
21:11:29 | amayer_ | AlexP: cabbie doesnt set it. thats why i added it. |
21:11:31 | amayer_ | on original boot cabbie has icons enabled(default rockbox setting) |
21:11:33 | amayer_ | but if you load a theme that doesnt use icons then reload cabbie the icons are still disabled |
21:12:01 | AlexP | I didn't look at the patch, and the commit message didn't give me that :) |
21:12:25 | amayer_ | im working on the message thing |
21:12:51 | AlexP | I thought (just from your message) that it added the setting to one that is written out hen you select write theme cfg or whatever it is |
21:12:55 | amayer_ | i dont want my messages to be too long, but i can never think of a short way to explain it |
21:13:02 | AlexP | long is fine |
21:13:19 | AlexP | Just have a short summary, then a blank line, then a longer explanation |
21:13:22 | wodz | gevaerts: It is needed to run $strip −−strip-unneeded −−strip-debug on all rocks. And this $strip is something like arm-elf-eabi-strip |
21:13:29 | AlexP | Keeping to 80 chars long per line would be handy too |
21:14:03 | AlexP | and the message could be "Make Cabbie enable icons when selected" or something like that |
21:14:06 | amayer_ | AlexP: how do you do that in command line? |
21:14:08 | amayer_ | i type: |
21:14:10 | amayer_ | git commit -am "this is the comment" |
21:14:21 | AlexP | dont' do -m "whatever" |
21:14:28 | amayer_ | ??? |
21:14:31 | AlexP | and it'll open your default editor |
21:14:39 | AlexP | For you to type whatever you want in |
21:14:44 | amayer_ | is that what the gerrit hook thing was? |
21:14:47 | AlexP | no |
21:14:51 | wodz | gevaerts: currntly I run find . -name '*.rock' -exec arm-elf-eabi −−strip-unneeded −−strip-debug {} \; by hand after building |
21:14:58 | amayer_ | totally confused |
21:15:02 | AlexP | -m lets you specifiy the message on the command line |
21:15:07 | gevaerts | wodz: ok. Looking at it now |
21:15:17 | AlexP | if you don't use -m then it'll open your editor for you to type the message in |
21:15:31 | amayer_ | ohhhhhhhh |
21:15:45 | amayer_ | is that built into git? |
21:15:49 | AlexP | yes |
21:15:54 | AlexP | and svn and ... |
21:16:09 | amayer_ | sweet. i thought if i didnt put a -m it would just be blank |
21:16:27 | AlexP | you will want to set $EDITOR |
21:16:31 | AlexP | unless you like vi |
21:16:50 | amayer_ | core.editor ?? |
21:16:52 | wodz | AlexP: ubuntu set it to nano by default :-) |
21:17:01 | amayer_ | im on ubuntu |
21:17:02 | AlexP | wodz: heh, did they? :) |
21:17:07 | amayer_ | i like nano better |
21:17:10 | AlexP | amayer_: then it will use nano apparently |
21:17:17 | AlexP | $EDITOR is an environment variable |
21:17:23 | AlexP | like $PATH |
21:17:28 | amayer_ | oh ok |
21:18:10 | wodz | hmm, EDITOR is empty but on ubuntu git uses nano by default |
21:18:46 | AlexP | oh, "The editor used to edit the commit log message will be chosen from the GIT_EDITOR environment variable, the core.editor configuration variable, the VISUAL environment variable, or the EDITOR environment variable (in that order)." |
21:19:26 | AlexP | amayer_: So yes, core.editor if you want :) |
21:20:42 | | Join mikroflops [0] (~yogurt@h-34-239.a238.priv.bahnhof.se) |
21:23:12 | amayer_ | that makes more sense |
21:23:45 | | Quit mikroflops_ (Ping timeout: 240 seconds) |
21:23:49 | amayer_ | is there a way i can change my commit message and update gerrit? or is that going to be complicated |
21:23:58 | AlexP | there is a way :) |
21:24:03 | AlexP | I don't know what it is |
21:24:16 | AlexP | I would guess you amend the commit then push it again |
21:24:27 | AlexP | but best wait for a git/gerrit ninja |
21:25:25 | amayer_ | name: Alex Mayer |
21:25:27 | amayer_ | level: 1 |
21:25:29 | amayer_ | skills: super basic git(nothing fancy) |
21:25:44 | amayer_ | idk what amend does |
21:25:46 | amayer_ | ill look it up on lynda.com |
21:25:53 | AlexP | amend means change |
21:27:42 | | Join mgottschlag [0] (~quassel@reactos/tester/phoenix64) |
21:29:56 | amayer_ | AlexP: i get that im not sure how to use it |
21:30:18 | amayer_ | git is slowly coming to me. but i still struggle with the concept |
21:30:24 | AlexP | me too |
21:30:36 | AlexP | but to amend a commit just means to change a commit |
21:30:45 | AlexP | I can't remember exactly how though :) |
21:31:38 | | Quit Staphylo (Read error: Operation timed out) |
21:34:14 | amayer_ | is the Download code on gerrit what i would need to "git fetch" to make the ammend? |
21:34:29 | AlexP | You do it on your repo |
21:34:40 | AlexP | if it is the last commit you made |
21:35:12 | amayer_ | ok. so i dont have to be on that specific branch(the gerrit: refs/changes/25/325/1) |
21:35:21 | amayer_ | is that what i would push too? |
21:35:38 | AlexP | I'm going to stop answering as I'm not sure, and I don't want to get it wrong |
21:35:40 | amayer_ | git push origin HEAD:ref/changes/25/325/1 |
21:35:42 | amayer_ | ? |
21:35:57 | amayer_ | s/ref/refs/ |
21:36:12 | amayer_ | AlexP: ok |
21:38:34 | wodz | amayer_: no. follow strictly UsingGit it says git push origin HEAD:refs/for/master |
21:39:18 | wodz | if you have proper Change-Id line in commit message gerrit will manage to put it where it should be |
21:40:18 | amayer_ | you mean if the SHA is the same? |
21:40:28 | | Quit pretty_function (Ping timeout: 244 seconds) |
21:40:29 | amayer_ | the git SHA id thing |
21:40:51 | gevaerts | The Change-Id line, not the commit hash |
21:42:28 | amayer_ | oh i see. git attaches that at the end of a commit message? |
21:42:38 | amayer_ | i guess thats what the gerrit hook does |
21:42:43 | gevaerts | amayer_: the gerrit hook does that, strictly speaking |
21:42:57 | amayer_ | its all becoming more clear |
21:43:14 | gevaerts | wodz: I think http://paste.debian.net/196697/ on top of g#326 might do it. |
21:43:16 | fs-bluebot | Gerrit review #326 at http://gerrit.rockbox.org/r/326 : ELF loader for plugins by Marcin Bukat (changes/26/326/1) |
21:43:28 | * | wodz looks |
21:44:25 | gevaerts | The change to the LD line probably isn't needed, but I get annoyed when $@ isn't used :) |
21:46:20 | gevaerts | Note that that entire $(call...) in e.g. the LD line is only to suppress regular output and handle the V=1 thing, but doesn't actually enclose the $(CC) command itself |
21:47:04 | wodz | shouldn't there also be line in configure like STRIP=`findtool ${STRIP} −−lit` ? |
21:48:01 | gevaerts | Hm, yes. I missed that part |
21:49:27 | amayer_ | gevaerts: so if i amended the commit i should repush it? |
21:49:27 | | Join einhirn [0] (Miranda@bsod.vpn.tu-clausthal.de) |
21:49:35 | gevaerts | amayer_: yes |
21:49:42 | amayer_ | just put to refs/for/master |
21:49:47 | gevaerts | Well, only if you like the new version :) |
21:49:49 | amayer_ | the line on UsingGit |
21:49:57 | amayer_ | ok thank you |
21:50:13 | gevaerts | Yes. The push line for new gerrit patches or modified patches is exactly the same |
21:51:26 | * | gevaerts has 'gerrit = push origin HEAD:refs/for/master' as a git alias |
21:51:58 | wodz | gevaerts: seems to work |
21:52:49 | amayer_ | AlexP: would this be a better message? |
21:52:51 | amayer_ | Make Cabbiev2 enable icons when selected |
21:52:53 | amayer_ | |
21:52:55 | amayer_ | adds 'show icons: on' to cabbiev2.cfg file. |
21:52:57 | amayer_ | when you switch theme away from cabbiev2 to a theme |
21:52:59 | amayer_ | with 'show icons: off' then switch back to cabbiev2 |
21:53:01 | amayer_ | the icons are still off which doesnt mimic the default |
21:53:03 | amayer_ | settings presented by rockbox. |
21:53:05 | amayer_ | gevaerts: how do i do that? |
21:53:15 | AlexP | amayer_: pastebins are a good concept :) |
21:53:28 | amayer_ | AlexP: sorry |
21:53:34 | AlexP | It's fine :) |
21:54:03 | AlexP | But yeah, looks fine to me. I'd leave a blank line after the first line |
21:54:08 | gevaerts | amayer_: add an [alias] section to .git/config with that line |
21:54:47 | amayer_ | so then the command "git gerrit" will push to origin? |
21:54:59 | wodz | gevaerts: thanks for help |
21:55:06 | | Quit wodz (Quit: Leaving) |
21:55:16 | *** | Saving seen data "./dancer.seen" |
21:55:24 | gevaerts | amayer_: I don't know the proper way to describe what it does, apart from "the right thing, in this case" :) |
21:55:46 | amayer_ | is that what you type tho "git gerrit" ? |
21:55:52 | gevaerts | Yes |
21:56:11 | gevaerts | I *believe* the origin and HEAD bits make sure only stuff on your currently active branch gets pushes |
21:59:08 | gevaerts | amayer_: of course, feel free to use another name than gerrit for it |
21:59:44 | amayer_ | gevaerts: that is soo awesome! |
21:59:46 | amayer_ | i think im going to use 'torockbox' or something |
22:00 |
22:00:16 | gevaerts | You can do all sorts of fancy stuff with aliases. I'm sure the web has many examples |
22:01:00 | amayer_ | is that something we should put in the wiki? |
22:01:03 | amayer_ | it would be very helpful |
22:01:31 | gevaerts | It wouldn't hurt, I guess |
22:02:08 | amayer_ | im on it |
22:04:20 | | Quit Buschel (Quit: ChatZilla 0.9.88.2 [Firefox 15.0.1/20120905151427]) |
22:13:56 | | Quit saratoga (Ping timeout: 240 seconds) |
22:16:59 | | Quit efyx (Ping timeout: 246 seconds) |
22:29:39 | | Join speckmade [0] (~fnerd@port-92-193-42-221.dynamic.qsc.de) |
22:31:02 | | Join efyx [0] (~efyx@91.179.67.190) |
22:33:14 | | Quit zoktar_ (Quit: ZNC - http://znc.in) |
22:33:49 | speckmade | I got a Sansa Clip+ today and I'm so happy about the greatness of Rockbox and how easily it installs. |
22:37:15 | speckmade | I just installed the IT-MAY-EXPLODE daily build version and now enjoy listening to files in the brand-new incredible Opus format. |
22:37:23 | speckmade | That's impressive! |
22:38:10 | gevaerts | speckmade: glad to hear you're enjoying it :) |
22:38:15 | speckmade | I'd like to thank everyone involved in making this great thing happen! |
22:38:22 | | Join pedro_angelo [0] (~pedro_ang@186-241-153-164.user.veloxzone.com.br) |
22:41:12 | * | the-kyle is also impressed with the stuff going on in git. I patched opus into my build a day before it went live in git, and I was impressed with the sound then, and am impressed with the stuff that has hit my git build since then as well. |
22:41:46 | * | the-kyle never dreamed such small files could sound so good. |
22:46:01 | | Join zoktar [0] (~zoktar@78-70-241-206-no186.tbcn.telia.com) |
22:46:08 | | Part amayer_ |
22:47:05 | | Quit kevku (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/) |
22:57:59 | | Quit ender` (Quit: The human eye is a wonderful device. With a little effort, it can fail to see even the most glaring injustice.) |
23:00 |
23:12:14 | | Quit scorche|sh (Changing host) |
23:12:14 | | Join scorche|sh [0] (~scorche@rockbox/administrator/scorche) |
23:13:32 | | Quit Horscht (Quit: Verlassend) |
23:14:56 | | Quit the-kyle (Quit: Leaving.) |
23:22:16 | | Quit einhirn (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) |
23:51:53 | | Quit eckoit (Quit: eckoit) |
23:55:19 | *** | Saving seen data "./dancer.seen" |