00:01:12 | | Join ender1 [0] (krneki@foo.eternallybored.org) |
00:05:59 | | Join factor [0] (~factor@r74-195-184-118.msk1cmtc01.mskgok.ok.dh.suddenlink.net) |
00:09:42 | | Join webguest93 [0] (~d88d9302@www.haxx.se) |
00:10:37 | | Quit webguest93 (Client Quit) |
00:22:35 | | Quit Joakim (Quit: Joakim) |
00:22:47 | | Quit guymann (Quit: brbbrbrb) |
00:25:48 | | Join guymann [0] (~c@unaffiliated/guymann) |
00:26:50 | | Quit Wardo (Read error: Connection reset by peer) |
00:27:52 | | Quit lebellium (Quit: ChatZilla 0.9.89 [Firefox 17.0/20121023124120]) |
00:32:50 | | Quit mirak_ (Quit: Ex-Chat) |
00:36:06 | tjb0607 | so I'm having some issues with ID3 tags/vorbis comments to include album art with easytag |
00:36:31 | tjb0607 | basically, I do everything right and everything shows up right, but when I try it on Rockbox it doesn't show up |
00:39:02 | tjb0607 | all the other albums I download from Amazon have ID3 artwork working perfectly |
00:40:48 | amayer | bluebrother^: do you know php? |
00:43:08 | amayer | scorche`: could you approve this since you already tested it on your server? |
00:43:10 | amayer | http://gerrit.rockbox.org/r/#/c/341/ |
00:43:37 | amayer | or "review" it. not sure what the appropriate term is |
00:51:09 | | Quit ender1 (Quit: The best way to accelerate a Macintosh is at 9.8m/sec²) |
00:54:00 | | Quit KiwiCAM_ (Remote host closed the connection) |
00:57:41 | | Quit Totalled (Quit: PETTAN PETTAN, TSURUPETTAN!) |
00:58:53 | | Join KiwiCam [0] (~quassel@101.98.171.48) |
01:00 |
01:00:48 | KiwiCam | tjb0607: Have you tried Puddletag? |
01:00:54 | tjb0607 | no |
01:06:07 | tjb0607 | everything shows up right in there too |
01:07:19 | *** | Saving seen data "./dancer.seen" |
01:12:39 | | Join Gallomimia [0] (~Gallo@d50-98-213-185.bchsia.telus.net) |
01:30:44 | | Join Totalled [0] (~Totalled@c-98-245-9-211.hsd1.co.comcast.net) |
01:45:07 | amayer | bluebrother^: ping |
01:57:11 | | Quit Totalled (Ping timeout: 252 seconds) |
02:00 |
02:00:59 | | Join Totalled [0] (~Totalled@c-98-245-9-211.hsd1.co.comcast.net) |
02:11:38 | amayer | AlexP: do you know php to approve something for the themesite? |
02:12:32 | amayer | Torne: ping |
02:44:28 | | Quit guymann (Ping timeout: 264 seconds) |
02:45:17 | | Join guymann [0] (~c@unaffiliated/guymann) |
02:53:37 | | Join XavierGr [0] (~xavier@rockbox/staff/XavierGr) |
03:00 |
03:07:22 | *** | Saving seen data "./dancer.seen" |
03:28:32 | | Quit dfkt (Quit: -= SysReset 2.55=- Sic gorgiamus allos subjectatos nunc.) |
03:41:19 | | Quit Gallomimia (Quit: Gallomimia) |
03:48:22 | | Join Scr0mple [0] (~Simon@161.43.73.67) |
03:52:25 | | Quit Scromple (Ping timeout: 272 seconds) |
04:00 |
04:02:45 | | Quit PathosesNorms (Ping timeout: 244 seconds) |
04:25:39 | | Join TheSphinX^ [0] (~briehl@p579CCC7F.dip.t-dialin.net) |
04:25:55 | | Join [Saint] [0] (~quassel@rockbox/user/saint) |
04:27:00 | | Quit TheSphinX_ (Read error: Operation timed out) |
04:37:56 | | Nick [Saint] is now known as [Saint_] (~quassel@rockbox/user/saint) |
04:38:02 | | Nick [Saint_] is now known as [Saint__] (~quassel@rockbox/user/saint) |
04:38:10 | | Nick [Saint__] is now known as [Saint___] (~quassel@rockbox/user/saint) |
04:38:17 | | Nick [Saint___] is now known as [Sinner] (~quassel@rockbox/user/saint) |
04:38:17 | DBUG | Enqueued KICK [Sinner] |
04:38:21 | | Nick [Sinner] is now known as [Sinner_] (~quassel@rockbox/user/saint) |
04:38:21 | DBUG | Enqueued KICK [Sinner_] |
04:38:57 | | Nick [Sinner_] is now known as [Sinner__] (~quassel@rockbox/user/saint) |
04:38:57 | DBUG | Enqueued KICK [Sinner__] |
04:38:57 | *** | Alert Mode level 1 |
04:39:16 | | Nick [Sinner__] is now known as [Sinner___] (~quassel@rockbox/user/saint) |
04:39:16 | DBUG | Enqueued KICK [Sinner___] |
04:39:16 | *** | Alert Mode level 2 |
04:39:23 | | Nick [Sinner___] is now known as sinner (~quassel@rockbox/user/saint) |
04:39:23 | DBUG | Enqueued KICK sinner |
04:39:23 | *** | Alert Mode level 3 |
04:39:33 | | Nick sinner is now known as [Saint] (~quassel@rockbox/user/saint) |
04:39:33 | DBUG | Enqueued KICK [Saint] |
04:39:33 | *** | Alert Mode level 4 |
04:48:50 | | Quit amiconn (Disconnected by services) |
04:48:50 | | Join amiconn_ [0] (amiconn@rockbox/developer/amiconn) |
04:48:51 | | Quit pixelma (Disconnected by services) |
04:48:51 | | Join pixelma_ [0] (pixelma@rockbox/staff/pixelma) |
04:48:53 | | Nick amiconn_ is now known as amiconn (amiconn@rockbox/developer/amiconn) |
04:48:53 | | Nick pixelma_ is now known as pixelma (pixelma@rockbox/staff/pixelma) |
04:49:34 | *** | Alert Mode OFF |
04:58:05 | amayer | [Saint]: i forget if i asked you. do you know php(enough to review it)? |
04:59:19 | JdGordon | amayer: what are your plans for the theme site? if you just want to do fixups then i think we should go about getting you commit access |
04:59:43 | JdGordon | if its more then you really should just fork it, put up your finished site and them switch |
04:59:48 | amayer | JdGordon: im game for that |
05:00 |
05:00:07 | amayer | i am confused about the forking tho |
05:00:16 | amayer | for now its just minor things here and there |
05:00:34 | amayer | im not like rebuilding the way it works just making it more efficent |
05:00:58 | amayer | im guessing a fork is just making a new branch in git? |
05:01:16 | | Join Rower85 [0] (husvagn@v-413-alfarv-90.bitnet.nu) |
05:01:31 | JdGordon | exactly what you've done for the gerrit review... thats a fork |
05:01:53 | JdGordon | but i mean setting it up on a server you own and then taking it as far as you want and seeing what it looks like before merging it back |
05:01:53 | amayer | *totaly confused* |
05:01:55 | amayer | that is all in the master branch |
05:02:36 | amayer | JdGordon: i already do that. not a public server but i have a dedicated box(ok its a laptop) just for the theme site |
05:03:29 | amayer | so how do i go about getting commit access? |
05:03:59 | JdGordon | I've sent an email to the secret brotherhood of faceless men |
05:04:50 | amayer | ahhh... do i get to wear a cloak after i get commit access? |
05:04:52 | amayer | and program in the dark with toruches burning in the background |
05:06:27 | JdGordon | you dont *have* to... but its recommended |
05:06:30 | JdGordon | OBVIOUSLY |
05:07:07 | amayer | *arm pump* YES!!!! |
05:07:26 | *** | Saving seen data "./dancer.seen" |
05:10:25 | Ctcp | Ignored 6 channel CTCP requests in 1 minute and 16 seconds at the last flood |
05:10:25 | * | scorche` hands out the cloaks |
05:13:16 | | Quit sentriz (Quit: Leaving) |
05:15:06 | | Join Galois [0] (djao@efnet-math.org) |
05:15:46 | | Nick scorche` is now known as scorche (~scorche@rockbox/administrator/scorche) |
05:28:40 | | Quit guymann (Quit: brb irssi bork again) |
05:29:43 | | Join guymann [0] (~c@unaffiliated/guymann) |
05:32:08 | | Quit [7] (Disconnected by services) |
05:32:16 | | Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) |
06:00 |
06:07:41 | | Part amayer |
06:15:46 | | Join mortalis [0] (~mortalis@195.34.194.126.kalibroao.ru) |
06:33:08 | | Join sentriz [0] (~Senan@78.143.151.93) |
06:35:26 | | Quit Totalled (Quit: PETTAN PETTAN, TSURUPETTAN!) |
06:35:41 | | Join Totalled [0] (~Totalled@c-98-245-9-211.hsd1.co.comcast.net) |
06:40:14 | | Quit alexbobp (Ping timeout: 240 seconds) |
06:41:11 | | Join alexbobp [0] (~alex@capitalthree.pwnz.org) |
07:00 |
07:03:59 | | Quit sentriz (Ping timeout: 252 seconds) |
07:07:27 | *** | Saving seen data "./dancer.seen" |
07:23:07 | | Join stoffel [0] (~quassel@pD9E41AA3.dip.t-dialin.net) |
07:26:11 | | Join bertrik [0] (~quassel@rockbox/developer/bertrik) |
07:29:12 | | Quit scorche (Disconnected by services) |
07:29:16 | | Join scorche` [0] (~scorche@rockbox/administrator/scorche) |
07:32:10 | | Join xvat [0] (~xvat@c-24-99-203-156.hsd1.ga.comcast.net) |
07:32:23 | | Join akaWolf [0] (~akaWolf@unaffiliated/akawolf) |
07:33:46 | xvat | For the Sansa Clip+ chipset, what is the highest capacity microsd card it can handle? |
07:35:12 | * | [Saint] wonders what the chipset has to do with this |
07:35:35 | [Saint] | 64GB, anyway (works with Rockbox, ...no idea about the OF, never used it) |
07:35:46 | | Join derk0pf [0] (~k@p5DDC0E6B.dip.t-dialin.net) |
07:43:47 | | Join Keripo [0] (~Keripo@c-76-22-63-234.hsd1.wa.comcast.net) |
07:54:14 | | Quit Keripo (Ping timeout: 240 seconds) |
07:58:27 | | Quit advcomp2019__ (Read error: Connection reset by peer) |
07:58:50 | | Join advcomp2019__ [0] (~advcomp20@97-114-245-162.sxcy.qwest.net) |
07:58:50 | | Quit advcomp2019__ (Changing host) |
07:58:50 | | Join advcomp2019__ [0] (~advcomp20@unaffiliated/advcomp2019) |
07:59:00 | amiconn | [Saint]: Technically nothing, but due to the weirdness in the SD standard that specifies the filesystem to use, SDXC won't work out of the box (due to being ExFAT formatted) |
07:59:22 | | Join Keripo [0] (~Keripo@c-76-22-63-234.hsd1.wa.comcast.net) |
08:00 |
08:06:05 | | Quit bertrik (Ping timeout: 264 seconds) |
08:06:27 | | Quit Keripo (Read error: Connection reset by peer) |
08:11:20 | | Join Zagor [0] (~bjst@sestofw01.enea.se) |
08:11:20 | | Quit Zagor (Changing host) |
08:11:20 | | Join Zagor [242] (~bjst@rockbox/developer/Zagor) |
08:19:24 | | Join Keripo [0] (~Keripo@c-76-22-63-234.hsd1.wa.comcast.net) |
08:20:21 | | Quit [Saint] (Quit: Quit) |
08:30:42 | | Join LinusN [0] (~linus@giant.haxx.se) |
08:32:08 | | Join Joakim [0] (~Joakim@h-92-96.a193.priv.bahnhof.se) |
08:33:00 | | Join ender1 [0] (krneki@foo.eternallybored.org) |
08:35:44 | | Join [Saint] [0] (~quassel@rockbox/user/saint) |
08:47:09 | | Quit Joakim (Quit: Joakim) |
08:49:43 | | Quit ender` (Ping timeout: 246 seconds) |
08:50:10 | | Join ender` [0] (~ender1@2a01:260:4094:1:42:42:42:42) |
09:00 |
09:07:28 | *** | Saving seen data "./dancer.seen" |
09:18:10 | | Join petur [0] (~petur@rockbox/developer/petur) |
09:25:34 | | Part LinusN |
09:30:14 | | Join pamaury [0] (~quassel@vit94-1-82-67-248-70.fbx.proxad.net) |
09:30:14 | | Quit pamaury (Changing host) |
09:30:14 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
09:37:59 | | Quit pamaury (Ping timeout: 260 seconds) |
10:00 |
10:00:14 | | Quit derk0pf (Ping timeout: 240 seconds) |
10:01:07 | | Join derk0pf [0] (~k@p5DDC0AAF.dip.t-dialin.net) |
10:14:06 | | Join pamaury [0] (~quassel@sphinx.lix.polytechnique.fr) |
10:14:07 | | Quit pamaury (Changing host) |
10:14:07 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
10:26:38 | | Join Joakim [0] (~Joakim@h-92-96.a193.priv.bahnhof.se) |
10:31:22 | | Quit tchan (Ping timeout: 255 seconds) |
10:41:41 | * | [Saint] wonders what to do with the metadata in cabbie for targets that can display 6-7-8+ lines of text (+2-3-4 lines of text in the "no album art" case) |
10:43:08 | [Saint] | In the changes I have in my tree at the moment, I've fixed up the whole 'always expect there to be a next track' thing, and that leaves a whole lot of room for additional data (if it's wanted) on some targets. |
10:51:06 | | Quit tjb0607 (Ping timeout: 265 seconds) |
10:55:19 | [Saint] | JdGordon: you around? |
10:56:53 | | Join einhirn [0] (~Miranda@2001:638:605:4:1c8e:15bb:86b0:8d30) |
10:59:30 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
11:00 |
11:02:37 | | Join PathosesNorms [0] (~PathosesN@c193-14-28-112.cust.tele2.se) |
11:02:38 | | Join LinusN [0] (~linus@giant.haxx.se) |
11:07:29 | *** | Saving seen data "./dancer.seen" |
11:13:55 | JdGordon | [Saint]: ? |
11:16:52 | JdGordon | get me tomorrow |
11:34:18 | | Quit einhirn (Ping timeout: 260 seconds) |
11:34:54 | | Quit Provel_ (Read error: Connection reset by peer) |
11:35:19 | | Join Provel_ [0] (~Provel@75-132-15-43.dhcp.stls.mo.charter.com) |
11:43:26 | kugel | [Saint]: I wouldnt put too much information |
11:43:54 | kugel | also don't change too much in one go, incremental changes are better |
11:44:23 | [Saint] | most of it is purely cosmetic code changes |
11:44:48 | [Saint] | and the rest is just making the various cabbies more similar with each other |
11:45:24 | [Saint] | there's some weird, completely unnecessary, differentiation between some of the cabbie ports that I'm ironing out. |
11:46:55 | | Quit bootinfdsds (Read error: Connection reset by peer) |
11:47:15 | [Saint] | ahhhhhhhh, bum. |
11:47:19 | [Saint] | I missed Jd. |
11:54:13 | [Saint] | Anyway, yeah. I haven't actually changed the layout of any of the cabbies at all. I've just unified the metadata between the ports, and made the different ports code as similar to each other as possible. |
11:54:40 | [Saint] | and updated old syntax to new syntax in a few places. |
11:55:32 | [Saint] | But, yeah...it's pretty much all "behind the scenes" cosmetic stuff that I hope will make cabbie a better teaching tool. |
12:00 |
12:02:13 | | Join wodz [0] (~wodz@iwl138.internetdsl.tpnet.pl) |
12:02:50 | pixelma | I always wanted to have the c200 version use a 10 pixel font instead of 11 so that on the WPS there could be one more row and hence having space for the playing time info line all the other ports have. Since using my own WPS on the c200 though, motivation wasn't very high |
12:03:29 | wodz | amiconn: ping |
12:06:54 | [Saint] | pixelma: does a suitable 10px font exist? |
12:07:34 | [Saint] | I have made a set of anti-aliased fonts from GNU Unifont that I was considering useng. |
12:07:38 | pixelma | it's currently using 11-Sazanami-Mincho and we also have a 10-pix version of that |
12:08:23 | [Saint] | although the aa fonts are large (and GNU Unifont is ugly) I think that the default theme that Rockbox ships with should "just work" for any language. |
12:08:42 | [Saint] | I haven't made the change yet, but I was going to bring it up on the ml |
12:08:44 | | Quit bluebrother^ (Read error: Operation timed out) |
12:09:04 | | Quit fs-bluebot (Ping timeout: 260 seconds) |
12:09:04 | xvat | [Saint]: the OF? I was asking what the Sansa Clip+ supported in capacity for sd memory, but inserted chipset to also alert the answerer that I am interested if there are theoretical limits in the hardware that are different to that of the rockbox firmware |
12:09:07 | pixelma | hard to make it work for the smaller screens though |
12:09:09 | xvat | 64gb soudns good |
12:09:24 | | Quit factor (Read error: Connection reset by peer) |
12:09:47 | [Saint] | well, there's no limit to the Rockbox firmware. |
12:10:08 | [Saint] | it is entirely limited by the hardware. |
12:10:28 | | Join fs-bluebot [0] (~fs-bluebo@g231120080.adsl.alicedsl.de) |
12:10:45 | Torne | the limit for SD cards is 2TB |
12:10:49 | [Saint] | I have no idea if the OF can support a 64GB card or not, so dual-boot might get interesting...but I know that Rockbox can. |
12:11:21 | Torne | if you somehow get hold of a 2TB card and it doesnt' work in rockbox that's a bug and if you let us know we can probably fix it :p |
12:11:21 | xvat | OF = original firmware |
12:11:38 | xvat | I haven't thought of using more than one firmware, i was set on using only rockbox |
12:11:40 | [Saint] | Torne: Bwahahaha ;) |
12:11:43 | xvat | i don't see why one would do otherwise |
12:12:22 | | Join bluebrother [0] (~dom@rockbox/developer/bluebrother) |
12:12:50 | Torne | there isn't really a hardware limit, the controller does whatever we tell it to. |
12:13:02 | [Saint] | Subscription/paid content, is one that I can think of. |
12:13:12 | Torne | until someone actually makes a kind of SD card that isn't physically/electrically backward compatible it will work if we implement the code right :) |
12:13:15 | [Saint] | (wrt: reasons to use the OF) |
12:14:08 | [Saint] | Torne: well, sorry...I wasn't very clear, but by "hardware" I was also including the card itself. |
12:14:34 | | Join T44 [0] (Topy44@f048233088.adsl.alicedsl.de) |
12:14:39 | [Saint] | that was non-obvious to third parties though, apologies. |
12:14:51 | xvat | [Saint]: ah, afaik Sansa Clip+ has none of that |
12:14:53 | Torne | that doesn't make sense, though |
12:15:29 | Torne | there's no actual reason why you couldn't make an SD card that was a trillion terabytes, or whatever, and still have it be compatible with existing reader hardware :p |
12:15:38 | Torne | you'd need to invent a pretty entertaining variant on the SD interface spec.. |
12:15:42 | Torne | and write some funky drivers :p |
12:15:53 | Torne | and you might not be very happy with the performance. |
12:17:03 | wodz | who cares about performance when handing trillion terabytes SD :-) |
12:18:02 | xvat | why not develop an open source digital audio player with built-in asic/fpga codecs for lame/vorbis/etc? |
12:18:24 | | Quit Topy (Ping timeout: 260 seconds) |
12:18:35 | Torne | xvat: largely pointless |
12:18:41 | wodz | xvat: because its silly? |
12:18:49 | Torne | most current codecs are very easy to decode on modern CPU arches |
12:18:58 | wodz | why not use off the shelf modern SoC? |
12:19:04 | Torne | using dedicated decoder hardware is very oldfashioned and way more expensive |
12:19:13 | Torne | and much less flexible when new codecs show up |
12:19:57 | xvat | alright |
12:20:35 | xvat | Torne: the rockbox developers do not feel limited by what hardware manufacturers put on the market? |
12:20:39 | [Saint] | see also the various open source music player projects that have dies a slow and expensive death in our wiki |
12:20:47 | xvat | aha |
12:20:59 | [Saint] | *died |
12:21:18 | Torne | xvat: not raelly, no |
12:21:31 | Torne | what's limiting about them? |
12:21:53 | Torne | something made in huge volume by a consumer manufacturer is going to be cheaper and better-built than anything we can arrange to ahve made |
12:22:19 | Torne | there isn't really anything rockbox can do that current players have a problem with |
12:22:23 | Torne | so, what's the point? :) |
12:22:29 | xvat | alright |
12:22:32 | [Saint] | It's just way cheaper to work with existing hardware, and most of the time these players have more than enough "guts" to play damn near anything (even foolish audiophile quality audio). |
12:22:34 | wodz | for open hardware DAP project there are two limiting factors 1) cost 2) mounting technology will most users can't handle |
12:23:13 | [Saint] | s/play damn near anything/play damn near anything in real time/ |
12:23:14 | wodz | *which |
12:23:18 | [Saint] | (missed an important bit) |
12:23:22 | Torne | audio processing doesn't really cost any more processing power now than it did a long time ago, but CPUs are way, way more powerful and efficient |
12:23:32 | * | [Saint] nods |
12:24:48 | | Quit stoffel (Ping timeout: 252 seconds) |
12:26:04 | xvat | awesome |
12:26:18 | xvat | http://www.newegg.com/Product/Product.aspx?Item=N82E16855125130 |
12:26:24 | xvat | for US people |
12:26:43 | wodz | As a side note - In front of me there is R4600 CPU ripped off INDY SGI workstation. It has about the same fixed-point performance as ATJ213x SoC. |
12:26:46 | Torne | the whole Clip family is super awesome. :) |
12:26:54 | Torne | *so* tiny and cheap |
12:27:26 | | Join factor [0] (~factor@r74-195-184-118.msk1cmtc01.mskgok.ok.dh.suddenlink.net) |
12:27:28 | copper | I bought a refurbished Clip+ recently - its screen went very dim a few days after delivery |
12:28:07 | xvat | but it seems they break Torne |
12:28:13 | xvat | should i buy a soldering kit just for this |
12:28:23 | Torne | none of mine are broken |
12:28:33 | Torne | never had a problem |
12:28:35 | xvat | how do you take care of them |
12:28:41 | Torne | not at all |
12:28:46 | Torne | throw them in the bottom of my bag or wahtever. |
12:28:54 | Torne | they're solid lumps of plastic |
12:29:02 | Torne | it's about as indestructible as anything else i own |
12:29:13 | xvat | the earphone jack seems to be a weakspot |
12:29:15 | xvat | and FM tuning |
12:29:24 | xvat | "I purchased a silicone skin protector and put on a screen film to protect against scratching and thought I was good to go for a long time." |
12:29:36 | Torne | not sure what FM tuning has to do with anything.. |
12:29:43 | Torne | the jack is fine in mine |
12:29:56 | Torne | i don't leave the headphones plugged in when i throw it in somewhere |
12:30:07 | Torne | so, there's rarely any forces applied to the socket. |
12:30:13 | Torne | i can see that breaking it maybe? |
12:30:47 | Torne | when i'm using it nothing is likely to happen that pushes on the headphone plug enough to do any damage |
12:30:56 | Torne | and when i'm not using it nothing is plugged in, so the socket can't really get broken |
12:31:47 | xvat | Torne: So what is your favored of the Sansa Clip family |
12:32:00 | * | funman pushes people to #rockbox-community |
12:32:06 | wodz | usually headphone socket gets broken on insertion of the jack |
12:34:14 | wodz | mortalis: ping |
12:34:22 | mortalis | wodz: pong |
12:34:23 | | Quit Keripo (Quit: Leaving.) |
12:35:31 | wodz | mortalis: I was thinking about cache problem and I see one race condition in previous code. If interrupt fires during cache invalidation it may go nuts |
12:35:46 | wodz | maybe thats the reason of the problems |
12:36:52 | | Join Nux|Vomica [0] (~Nux@ppp-188-174-61-212.dynamic.mnet-online.de) |
12:37:54 | Torne | there's a way for interrupts to happen during our cache invalidation? |
12:37:57 | Torne | that would be bad, yes :) |
12:38:49 | mortalis | wodz: I have the same thought after I saw g339 |
12:38:51 | fs-bluebot | Gerrit review #339 at http://gerrit.rockbox.org/r/339 : Fix FS #12391 : Memory corruption on PP502x after commit_discard_idcache() by Boris Gjenero (changes/39/339/1) |
12:38:57 | wodz | Torne: in rk27xx cache controller is peripheral like anything else. |
12:39:12 | wodz | mortalis: heh, exactly the same here |
12:40:04 | Torne | wodz: right, then you need to disable interrupts while you wait for it, or else prove that no interrupt handler can ever touch the cachelines you care about :p |
12:40:43 | wodz | or disable caching |
12:41:09 | Torne | depends on the semantics of disabling the cache |
12:41:27 | wodz | I mean disable cache; invalidate; enable cache |
12:41:46 | Torne | right, but that doesn't actually work on all cache implementations :) |
12:42:08 | Torne | it's possible you still read from cache while it's disabled |
12:42:14 | Torne | just, no linefill operations take place |
12:42:19 | Torne | or other weird semantics :/ |
12:42:39 | Torne | most arches are not designed to ever have their cache turned off again for anything other than preparation for a reset/chainload of different binary/etc |
12:42:46 | Torne | so sometimes the behaviour is weird |
12:43:09 | wodz | So you mean that it is actually safer to disable interrupts in wait loop of invalidate? |
12:43:23 | Torne | yes, that's what i'd suggest |
12:43:40 | Torne | also, even if disabling the cache works for an invalidate, it doesn't for a clean |
12:44:24 | wodz | rk27xx cache doesn't distinguish this two - it has one commit and invalidate opcode AFAIK |
12:44:37 | Torne | then you absolutely can't disable the cache to do it |
12:44:44 | Nux|Vomica | Hi, i have a question about the compatibility of Rockbox with external media players over usb; In detail, its my Denon AV-Receiver, that has an USB Port where music can be played from USB Devices. It runs well with standard thumb drives, but for some reason cannot detect my IPod Mini 2g with Rockbox on it. Is there any way I could enable this? (The Denon also has a direct ipod control feature, but since I dont use the IPod defa |
12:44:44 | Nux|Vomica | ult firmware, this feature is useless anyway.) |
12:44:47 | Torne | because anything that touches a dirty cacheline while it was disabled may read the stale data from ram |
12:44:51 | Torne | instead of the current data from teh cache :) |
12:44:54 | Torne | so, yeah, disable interrupts. |
12:45:12 | wodz | Torne: ok, thanks for clarification |
12:45:24 | wodz | mortalis: could you test this on hifiman? |
12:45:39 | Torne | Nux|Vomica: this usually happens because it recognises that it's an ipod by the USB vendor/product ID and then tries to communicate with it using the ipod accessory protocol, or to read the itunes database, or something else we don't undertand |
12:45:40 | Nux|Vomica | I read a bit about it, this might come from the "unformatted" 39.22MB part at the beginning of my IPods drive; or it might be that the denon is just not able to detect partitions other than the first one. |
12:45:50 | Torne | Nux|Vomica: that;s unlikely. |
12:46:10 | Torne | you will probably find if you patch rockbox to claim a different USB vendor/product that's not an ipod it will just work |
12:46:18 | Torne | because it'll treat it like any old usb device |
12:46:24 | mortalis | wodz: sure |
12:46:45 | Torne | we've had this come up a bunch of times before; someone should really work out a nice way to solve this with an option :/ |
12:47:04 | Torne | but we don't have a usb id of our own to use. |
12:47:47 | wodz | has anyone get in touch with openmoko to get vids:pids for our own? |
12:47:49 | Torne | wodz: hah, in fact yes, this means you can never disable the cache without having first disabled interrupts and cleaned the whole thing anyway :) |
12:47:58 | Torne | wodz: so yeah. |
12:48:19 | Torne | i don't think anyone has, no |
12:48:33 | wodz | I guess this would be the first step |
12:48:42 | wodz | setting bit is easy |
12:50:51 | | Quit zoktar (Ping timeout: 245 seconds) |
12:51:11 | | Quit wodz (Quit: Leaving) |
12:52:14 | | Quit Nux|Vomica (Ping timeout: 260 seconds) |
12:59:52 | | Quit petur (Quit: *plop*) |
13:00 |
13:01:12 | | Join Nux|Vomica [0] (~Nux@ppp-188-174-61-212.dynamic.mnet-online.de) |
13:06:18 | | Join wodz [0] (~wodz@iwl138.internetdsl.tpnet.pl) |
13:07:32 | *** | Saving seen data "./dancer.seen" |
13:07:43 | mortalis | wodz: works on 801 |
13:08:50 | | Quit Nux|Vomica (Ping timeout: 256 seconds) |
13:09:27 | wodz | mortalis: I believe Torne in this area so we should probably commit this |
13:10:26 | Torne | i assume you're invalidating the entire cache, here, btw? |
13:10:37 | mortalis | yes |
13:10:43 | Torne | ok, just checking |
13:11:04 | | Join Nux|Vomica [0] (~Nux@ppp-188-174-61-212.dynamic.mnet-online.de) |
13:11:11 | wodz | Don't we need to disable interrupts for invalidate_range also? |
13:11:32 | Torne | it depends how that's implemented |
13:11:43 | Torne | is the underlying cache op "invalidate by address"? |
13:11:52 | wodz | yes |
13:11:54 | Torne | and you just call it once for each cache line in the range |
13:11:59 | wodz | yes |
13:12:25 | Torne | if you can prove that interrupt handlers will never touch any of the cache lines you are invalidating, then it's fine |
13:12:34 | Torne | otherwise, you need to turn off interrupts there too |
13:12:51 | wodz | http://git.rockbox.org/?p=rockbox.git;a=blob;f=firmware/target/arm/rk27xx/system-rk27xx.c;h=8e6773f8169c51df342f41dacb6b911a4a594497;hb=HEAD |
13:13:26 | Torne | will look later, need to go |
13:17:02 | | Quit Nux|Vomica (Ping timeout: 276 seconds) |
13:22:07 | | Join dfkt [0] (dfkt@unaffiliated/dfkt) |
13:22:48 | | Join zoktar [0] (~zoktar@unaffiliated/zoktar) |
13:30:29 | | Join stoffel [0] (~quassel@pD9E41AA3.dip.t-dialin.net) |
13:35:49 | | Quit derk0pf () |
13:37:26 | | Join michaelr [0] (~ccb83072@www.haxx.se) |
13:39:08 | michaelr | Okay, so I did what you guys told me to do, changed the english.lang file, changed "Database" to "Library" and when I tested it on the simulator, it still said "Database" on the root menu. |
13:42:02 | wodz | did you rebuilt simulator or just changed the file? |
13:42:49 | michaelr | I downloaded a new one. I also did "../tools/configure" and then make and then make zip and used that zip |
13:44:35 | wodz | just checking: 1) cloned repo 2) changed lang file 3) ../tools/configure && make && make zip ? |
13:45:17 | michaelr | one sec |
13:46:47 | michaelr | What's cloning the repo? And I ran ../tools/configure, make, and make zip all as separate commands, right after one another. |
13:47:20 | wodz | thats basically the same as && it |
13:47:47 | wodz | so how did you get the source other then trough cloning our repo? |
13:48:57 | michaelr | I gib, I believe but that was a day ago, I didn't download a new one, should I? |
13:50:45 | wodz | "michaelr> I downloaded a new one." <- Please first describe your problem consistently then we can (probably) help you |
13:50:47 | | Join amayer [0] (~amayer@mail.weberadvertising.com) |
13:51:04 | | Quit Joakim (Ping timeout: 244 seconds) |
13:52:21 | michaelr | Sorry, are we talking about the source code? I used git clone to get the source a few days ago, now I'm editing it. I changed english.lang to change "Database" to "Library" on the root menu, but it didn't change. |
13:54:28 | wodz | describe the steps you did *in actual order*, then pastebin your change |
13:55:39 | michaelr | I edited language file, compiled the source with "make", then used "make zip" to create ~/rockbox/build/rockbox.zip, when I used ".rockbox" on the simulator the changed to the language file did nothing. |
13:56:35 | wodz | show your change |
13:57:52 | michaelr | what I changed in the language file? |
13:58:27 | wodz | yes |
13:59:55 | | Join yxo [0] (59a984ae@gateway/web/freenode/ip.89.169.132.174) |
14:00 |
14:00:29 | wodz | I just checked - it works - edit apps/lang/*.lang and rebuild |
14:00:40 | michaelr | <phrase> id: LANG_TAGCACHE desc: in the main menu and the settings menu user: core <soruce> *: "Library" </source> <dest> *: "Library" </dest> <voice> *: "Library"</voice> </phrase> |
14:00:48 | michaelr | Then I must have done something wrong... |
14:00:54 | wodz | aaa, you changed source entry |
14:00:58 | wodz | you can't do that |
14:01:07 | wodz | change dest and voice |
14:01:18 | yxo | hi. could anyone helpme to unbrick my clip plus? i do all like in a manual, but player doesn't start. |
14:01:23 | michaelr | Oh. The guy yesterday told me changing all of them won't hurt. |
14:01:34 | * | wodz checking |
14:01:52 | michaelr | Yesterday around this time. |
14:02:24 | wodz | that also works |
14:04:16 | michaelr | So it wasn't my editing, I just did something silly wrong? |
14:05:48 | wodz | probably |
14:09:06 | michaelr | Ah. Okay, thanks. I'll try it here in a sec. |
14:09:50 | | Join derk0pf [0] (~k@p5DDC0AAF.dip.t-dialin.net) |
14:13:09 | | Quit derk0pf (Read error: Operation timed out) |
14:18:46 | | Join tchan [0] (~tchan@c-69-243-144-187.hsd1.il.comcast.net) |
14:18:47 | | Quit tchan (Changing host) |
14:18:47 | | Join tchan [0] (~tchan@lunar-linux/developer/tchan) |
14:22:48 | | Quit wodz (Quit: Leaving) |
14:28:53 | Torne | amayer: i can take a look at your php? |
14:30:32 | michaelr | I don't understand, it's not changing it in the simulator... |
14:31:30 | amayer | Torne: i looked at the first php change i submitted and noticed you were one of the people that approved it and i was wondering if you could review these: |
14:31:33 | amayer | http://gerrit.rockbox.org/r/#/c/341/ |
14:31:35 | amayer | http://gerrit.rockbox.org/r/#/c/337/ |
14:31:44 | Torne | amayer: yeah, i will have a look now. |
14:31:53 | Torne | i am not a php guru and i don't know a lot about the themesite# |
14:31:59 | Torne | but i can probably help |
14:32:44 | michaelr | What do you need in PHP? |
14:32:52 | amayer | the database class was already tested on the live themesite(as the description says) |
14:33:20 | amayer | michaelr: i just need people to review and approve my code so we can commit it to the themesite |
14:34:55 | michaelr | I'll check it out. |
14:35:59 | amayer | michaelr: see links ^ |
14:37:18 | michaelr | The code viewer skips a bunch of lines... |
14:38:02 | amayer | michaelr: it only shows you diff(aka the lines i change/added) |
14:38:11 | Torne | it shows you whatever you tell it to show you :) |
14:38:20 | Torne | preferences -> context |
14:39:17 | amayer | Torne: what is the criteria for reviewing? |
14:39:19 | amayer | do you just have to have an account or is that a privliage that has to be granted by the powers-that-be |
14:39:28 | Torne | anyone can review changes |
14:39:42 | Torne | but only committers can give a score of +2 or -2, which allows/blocks the commit |
14:39:42 | amayer | ok. ive never tried reviewing anyones code |
14:39:45 | Torne | everyone else's scores are advisory only |
14:40:04 | amayer | oh ok |
14:40:52 | Torne | anywya i'm looking now but may not respond soon, rsi flaring up |
14:41:14 | amayer | rsi? |
14:43:40 | michaelr | why not use empty instead of == "" |
14:43:53 | | Part xvat |
14:45:49 | amayer | michaelr: which file what line? |
14:47:25 | michaelr | db.class.php line 208 |
14:47:51 | michaelr | And 216 |
14:48:25 | | Quit mortalis (Quit: Leaving) |
14:50:38 | | Quit stoffel (Ping timeout: 260 seconds) |
14:51:19 | amayer | *confused* |
14:51:21 | amayer | i dont fully understand the question. and i didnt make changes to those lines anyway. |
14:51:23 | amayer | (i assume you are talking about the right side(new file) |
14:52:23 | michaelr | Yeah, okay, nevermind then. It just does the same thing. |
14:53:31 | amayer | Torne: did you leave a message with your review? |
14:53:34 | amayer | i cant find any an am confused why you gave it a -1 |
14:54:09 | amayer | nvm. i think i found the comments |
14:54:51 | Torne | the code is pretty bad in general already; bad db usage :/ |
14:55:40 | amayer | i was talking about the theme class. but i found your comments. |
14:55:50 | Torne | so probably you arent really making it worse from that pov |
14:56:26 | Torne | if you actually want to work on the therme site you may want to look at fixing the db stuff though. |
14:56:40 | amayer | as far as the db class goes i was just updating it so it would work on my server... i dont think i want to rewrite the whole thing right now(maybe in the near future) |
14:57:01 | Torne | not the db class |
14:57:14 | Torne | the entire approach to queries |
14:57:20 | Torne | sprintf is a terrible way to do it |
14:58:17 | amayer | i was just using the same stuff that was already being used(trying to follow the same style) |
14:58:20 | amayer | i kinda get what it does but ive never used that sprintf function before |
14:58:43 | Torne | the specific function isn't important |
14:58:49 | Torne | using string manupulation to build queries is just wrong |
14:59:02 | Torne | regardless of how you manipulate strings |
15:00 |
15:01:43 | Torne | michaelr: thanks for looking, but "works on target" is something you would only set if you have actually tested the code in question |
15:03:23 | Torne | "target" refers to a rockbox target, which is not entirely appropraite as a review category for the themesite :) |
15:03:30 | Torne | just for reference |
15:04:44 | amayer | Torne: i will make the changes that you commented inline and resubmit over my lunch break(about 2 hours from now) |
15:04:52 | Torne | sure |
15:05:14 | Torne | but seriously, if you actually want to work on the themesite code in general that would be great |
15:05:31 | Torne | but you need to approach it from the perspective that what we have now is kinda actively bad and probably has all kinds of sql injection holes in it |
15:05:36 | Torne | and understand how to avoid this :) |
15:06:37 | amayer | i would like to work on the rockbox code. i have alot of ideas i would like to try and implement. ive never worked on something like this and it seems like alot of code to read before jumping in. |
15:07:18 | amayer | i dont mind working on the theme site and updating it to be more secure. |
15:07:36 | *** | Saving seen data "./dancer.seen" |
15:08:05 | Torne | sure |
15:08:08 | Torne | i'm not trying to discourage you |
15:08:26 | Torne | i also realise it's difficult because few people in the project know enough or care enough about php or the themesite to comment on your changes |
15:08:31 | Torne | i don't really know much about how the themesite code works |
15:08:51 | Torne | and i avoid php wher epossible, so can't exactly tell you the most current best practises for how to do this stuff |
15:09:07 | Torne | but i know what things are very bad :p |
15:16:19 | | Quit ender1 (Ping timeout: 244 seconds) |
15:17:49 | amayer | Torne: well im glad you took the time to review my code(even if it was a bad review) i helps me alot. |
15:17:52 | amayer | and i believe i will continue to work on the theme site. |
15:18:10 | Torne | sure, the -1 is largely directed at things like spelling |
15:18:22 | Torne | i'm not expecting you to actually replace all teh db code with parameterised queries |
15:18:29 | Torne | just, do the best you reasonably can :) |
15:18:48 | Torne | but if you want a *next* project then replacing all the db code with parameterised queries would be pretty rad |
15:18:52 | Torne | :p |
15:19:15 | Torne | btw, "rsi" == "RSI" == my hands hurt and i can't type much :p |
15:19:38 | amayer | i noticed... apperently i have a mental block when it comes to spelling "newest" |
15:20:11 | amayer | in my defence if you look at the time i posted it and apply it to EST it was like 1 in the morning on a work night that i commited them |
15:20:57 | Torne | you don't have to defend yourself |
15:21:11 | Torne | review comments are constructive criticism :) |
15:24:03 | amayer | Torne: can you give me an example of a parameterised query? |
15:26:31 | amayer | do you just mean escape all user input that goes into the query? |
15:26:34 | amayer | i googled "parameterised query php" and i didnt find much |
15:28:23 | | Quit michaelr (Quit: CGI:IRC (EOF)) |
15:28:36 | | Join wodz [0] (~wodz@89-76-32-53.dynamic.chello.pl) |
15:29:22 | | Join ender1 [0] (krneki@foo.eternallybored.org) |
15:30:14 | wodz | amayer: He probably means use user input to build up thoroughly checked parameter list to pass to the function instead of including parts of user input in query |
15:30:33 | wodz | pretty basic approach wrt to sql injection prevention |
15:31:22 | amayer | are you talking about Prepared statments? |
15:32:23 | wodz | I didn't look at the code of quetions - I am talking in general |
15:33:23 | wodz | also I can't remember if I coded something over 10 lines of code in php |
15:34:25 | amayer | I know what an sql injection is. i just never heard of parameterised query. |
15:34:28 | amayer | ive seen prepared statments. and heard that doing it that way is more secure. |
15:36:28 | | Join lebellium [0] (~chatzilla@g231204221.adsl.alicedsl.de) |
15:38:08 | wodz | amayer: thats strange since 'sql parameter query' returns example on the first place in google |
15:39:33 | amayer | wodz: peoples google results arent always the same |
15:39:51 | amayer | i googled parameter query php and didnt get much |
15:39:54 | amayer | when i google sql parameter query |
15:40:01 | amayer | it gives a little better results |
15:40:16 | Torne | prepared statements are usually parameterised, but you don't necessarily have to actually prepare statements to parameterise queries. |
15:40:19 | Torne | :) |
15:40:29 | | Join iPodMan5 [0] (~ccb83072@www.haxx.se) |
15:40:30 | Torne | depend son the db api |
15:40:52 | wodz | anyway my understanding of the term paramterised was correct :-) |
15:40:56 | Torne | escaping user input is also just more string manipulation |
15:41:00 | Torne | don't bother with that either |
15:41:04 | iPodMan5 | Which would save more battery: sleep mode or shutting RockBox down? |
15:41:05 | Torne | i mean, escaping is better than not escaping |
15:41:13 | Torne | iPodMan5: we don't have a sleep mode |
15:41:18 | Torne | so, shutting rockbox down :) |
15:41:32 | amayer | i think i could update db class to use prepared statments pretty easy |
15:41:41 | Torne | great :) |
15:42:01 | amayer | probably not today. but as Torne said "*next* project" |
15:42:04 | iPodMan5 | So locking my iPod when no music is playing and having the screen go off isn't sleep mode? |
15:42:12 | Torne | no, that's just the screen being off |
15:42:17 | Torne | everything else is still running exactly the same |
15:42:38 | Torne | the power consumption of an ipod that's not playing audio and has the screen off is pretty low |
15:42:47 | Torne | but, when it's off it's off, so yaknow |
15:43:03 | Torne | off always consumes less :) |
15:44:59 | | Join Topy [0] (~Topy44@78.48.233.88) |
15:45:03 | | Join lebellium_ [0] (~chatzilla@g231204221.adsl.alicedsl.de) |
15:45:13 | Torne | amayer: i would also suggest that you read up on things like sql injection prevention/etc in general :) |
15:45:29 | Torne | since if you aren't already familiar with this stuff there are probably other things you should be aware of before web pgoramming too |
15:45:33 | Torne | thuogh, er |
15:45:40 | Torne | a lot of material on this topic is really bad and wrong |
15:45:46 | Torne | especially material associated with php :) |
15:45:53 | | Quit Clear_runway (Ping timeout: 276 seconds) |
15:45:55 | Torne | not entirely sure what i would recommend specifically :p |
15:46:03 | | Quit lebellium (Ping timeout: 260 seconds) |
15:46:12 | | Nick lebellium_ is now known as lebellium (~chatzilla@g231204221.adsl.alicedsl.de) |
15:46:28 | amayer | ive found some things. and i understand the concept behind sql injection. so im confident i can filter out the good stuff |
15:46:42 | | Quit T44 (Read error: Connection reset by peer) |
15:47:43 | wodz | filtering user input has the drawback that you don't know how exactly query will be build. It is easy to miss some corner case |
15:48:09 | wodz | with parametrization you gain full control over queries |
15:48:11 | Torne | yeah. you should not need to filter user input, generally |
15:48:30 | amayer | i ment filter the articles i read(nothing to do with the code) |
15:48:36 | Torne | the only escaping/quoting you actually need to do in a webapp is escaping any user data you *output* as part of a page |
15:48:45 | Torne | and html escaping is easy to do and very predictable |
15:49:00 | Torne | since it's largely just "replace < with <" |
15:50:53 | | Quit AlexP (Ping timeout: 240 seconds) |
15:52:03 | | Quit tjb0607 (Ping timeout: 248 seconds) |
15:53:51 | copper | In System -> Rockbox Info, there's a "buffer" value, is that the size of the buffer that gets filled at the start of playback? |
15:54:08 | Torne | it's the amunt of memory available to buffer playback data in general |
15:54:22 | Torne | we don't wait until it's full before playback starts |
15:54:33 | Torne | but we buffer as much as will fit (if there's enough in the playlist) |
15:56:07 | | Join LambdaCalculus37 [0] (~LambdaCal@rockbox/staff/LambdaCalculus37) |
15:57:03 | | Quit iPodMan5 (Quit: CGI:IRC) |
16:00 |
16:09:23 | | Join AlexP [0] (~alex@rockbox/staff/AlexP) |
16:09:44 | | Part LinusN |
16:11:31 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
16:16:15 | | Join AlexP_ [0] (~alex@rockbox/staff/AlexP) |
16:16:58 | | Quit AlexP (Ping timeout: 256 seconds) |
16:17:34 | | Join sentriz [0] (~Senan@78.143.151.93) |
16:23:38 | | Quit wodz (Ping timeout: 260 seconds) |
16:33:46 | | Quit LambdaCalculus37 (Quit: LambdaCalculus37) |
16:35:41 | | Quit pamaury (Quit: No Ping reply in 180 seconds.) |
16:36:05 | | Join pamaury [0] (~quassel@sphinx.lix.polytechnique.fr) |
16:36:06 | | Quit pamaury (Changing host) |
16:36:06 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
16:42:53 | | Join LambdaCalculus37 [0] (~LambdaCal@rockbox/staff/LambdaCalculus37) |
16:44:43 | | Quit amayer (Remote host closed the connection) |
16:46:15 | | Quit pamaury (Ping timeout: 246 seconds) |
16:46:24 | | Join pamaury [0] (~quassel@sphinx.lix.polytechnique.fr) |
16:46:24 | | Quit pamaury (Changing host) |
16:46:24 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
16:47:15 | | Quit soap (Quit: soap) |
16:47:59 | | Join wodz [0] (~wodz@89-76-32-53.dynamic.chello.pl) |
16:48:36 | | Join amayer [0] (~amayer@mail.weberadvertising.com) |
16:51:56 | | Join stoffel [0] (~quassel@pD9E41AA3.dip.t-dialin.net) |
16:54:16 | | Join mortalis [0] (~mortalis@77.108.98.177) |
16:55:01 | | Join y4n [0] (~y4n@unaffiliated/y4ndexx) |
16:55:49 | | Quit Zagor (Quit: Clint excited) |
17:00 |
17:07:40 | *** | Saving seen data "./dancer.seen" |
17:09:20 | | Quit sentriz (Ping timeout: 252 seconds) |
17:15:08 | | Quit LambdaCalculus37 (Quit: LambdaCalculus37) |
17:19:21 | | Join LambdaCalculus37 [0] (~LambdaCal@rockbox/staff/LambdaCalculus37) |
17:22:08 | | Quit LambdaCalculus37 (Client Quit) |
17:25:19 | | Join soap [0] (~soap@cpe-174-102-96-10.woh.res.rr.com) |
17:25:19 | | Quit soap (Changing host) |
17:25:19 | | Join soap [0] (~soap@rockbox/staff/soap) |
17:40:00 | | Quit pamaury (Ping timeout: 265 seconds) |
17:41:16 | soap | I haven't done a careful study of how many spam account are "repeat customers". I'm guessing most are single-use hit-and-run accounts. But... |
17:41:38 | soap | We need to do something about the fact Rockbox Experts have the power to delete spam messages, but not ban the spammer. |
17:42:36 | soap | I'm not a big fan of the fact that "Removed Posts" is populated heavily with obvious spam accounts which have had their post removed, but not their posting privileges. |
17:54:51 | | Join bertrik [0] (~quassel@rockbox/developer/bertrik) |
17:55:31 | | Quit stoffel (Ping timeout: 255 seconds) |
18:00 |
18:13:21 | | Join kevku [0] (x@indeed.tastes.like.everything.mm.am) |
18:31:48 | mortalis | Torne, wodz: Speaking about invalidating cache range. I guess there is no guarantee that interrupt handlers doesn't touch cache lines we are invalidating, right? |
18:46:19 | | Join derk0pf [0] (~k@p5DDC1CE1.dip.t-dialin.net) |
18:50:23 | Torne | in general, no |
18:50:26 | Torne | it depends what you are invalidating |
18:50:30 | Torne | and why. |
18:50:52 | Torne | For a lot of cases in an OS it's possible to know that a given cacheline cannot be touched by any code right now |
18:51:09 | Torne | because, say, you know that the only references to that range of memory are in your local callstack where you are doing the invalidation |
18:51:21 | Torne | and this can help you do cache operations without blocking other things from running |
18:51:27 | Torne | but in the general case, you can't always prove it |
18:51:48 | yxo | pls help to unbrick clip plus. i write OF in recovery mode. i read dump. but clip don't start when i try to turn it on |
18:52:32 | | Join saratoga [0] (123e0cfc@gateway/web/freenode/ip.18.62.12.252) |
18:52:37 | saratoga | what did you do to brick it? |
18:52:55 | yxo | water=) |
18:53:10 | yxo | it was rockboxed |
18:53:24 | yxo | i turn it off. dry |
18:53:44 | yxo | then i try to turn it on and OF don't start |
18:53:47 | Torne | the "unbrick" process is to recover from the firmware being corrupted |
18:53:56 | Torne | physical damage is basically never going to do anything to the firmware |
18:54:01 | Torne | so, i expect your hardare is just broken |
18:54:10 | Torne | sorry |
18:54:15 | yxo | rockbox startted but i get meaasge that loading rockbox.sansa bad checksum |
18:54:57 | bertrik | have you tried starting it with the left/previous button pressed (should boot into the OF) |
18:55:19 | yxo | no i go to recovery mode, i can write firmware i can read firmware from play it identical. but player do not start |
18:55:55 | yxo | i think that hardware is oko |
18:56:27 | yxo | i think that it's a logical only trouble |
18:56:44 | Torne | if it doesn't boot after writing a new firmware image to it in recovery mode and you're sure you did it correctly then no, the hardware isn't ok :) |
18:56:51 | Torne | pretty much by definition |
18:56:58 | saratoga | wasn't there some trick where you could zero a few bytes when you write the firmware to get it to boot? |
18:57:34 | yxo | but when i go next time to recovery mode and read dump - dump is ok. |
18:57:46 | | Join bertrik_ [0] (~quassel@rockbox/developer/bertrik) |
18:57:47 | | Quit bertrik (Read error: Connection reset by peer) |
18:58:02 | | Quit tjb0607 (Ping timeout: 256 seconds) |
18:58:17 | | Quit wodz (Ping timeout: 276 seconds) |
18:59:15 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
19:00 |
19:00:14 | yxo | saratoga i don't understand your mesage. pls write simply. i not very wel understand english |
19:01:04 | yxo | i think that partition o player corrupted and player can't reinstal uploaded firmware |
19:01:35 | yxo | but i don't know how to repair corrupted partition |
19:01:45 | | Join LambdaCalculus37 [0] (~LambdaCal@rockbox/staff/LambdaCalculus37) |
19:01:45 | yxo | in recovery mode |
19:02:18 | saratoga | i think sometimes just flashing the .bin file wasn't enough |
19:02:32 | yxo | i think it to now =) |
19:02:37 | saratoga | sometimes parts of the device's memory needed to be set to zero too |
19:03:17 | yxo | may be i need dong "dd if=/dev/zero of=/dev/clip"? |
19:03:55 | yxo | and than "dd if=/clppa.bin of=/dev/clip"? |
19:05:54 | bertrik_ | "recovery mode" on the AMS players is not very well known |
19:06:51 | | Join pamaury [0] (~quassel@vit94-1-82-67-248-70.fbx.proxad.net) |
19:06:52 | | Quit pamaury (Changing host) |
19:06:52 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
19:07:09 | yxo | if i write to raw disk any data - may it occure to unbrickable state? |
19:07:41 | *** | Saving seen data "./dancer.seen" |
19:07:46 | yxo | or can i experimenting and write anything that i want? |
19:08:21 | | Join mystica555 [0] (~Mike@71-218-27-170.hlrn.qwest.net) |
19:10:05 | | Nick bertrik_ is now known as bertrik (~quassel@rockbox/developer/bertrik) |
19:11:35 | saratoga | yxo: in that mode i think you can't break the player more |
19:11:40 | | Join |akaWolf| [0] (~akaWolf@188.134.9.161) |
19:12:04 | saratoga | i remember posts on the forums about this, but searching i can't find anything |
19:14:06 | yxo | i read that for unbricking fuze require more that simply write OF firmware |
19:14:26 | yxo | was needed additional info |
19:14:26 | | Quit akaWolf (Ping timeout: 260 seconds) |
19:15:20 | yxo | where i can read how to rockbox booting step by step |
19:16:31 | yxo | may be need place clppa.bin to first byte on memaory... or something else |
19:16:36 | | Quit |akaWolf| (Ping timeout: 256 seconds) |
19:16:43 | yxo | for proper start booting process |
19:17:30 | funman | yeah clppa.bin |
19:18:23 | | Join wodz [0] (~wodz@89-76-32-53.dynamic.chello.pl) |
19:18:25 | mortalis | Torne: Even if you know that the only references to that range of memory are in the local callstack, how could you know that some other variable or code used during invalidation are not mapped to the same cache line? |
19:18:28 | yxo | if i write dd command it start write byte by byte from 0 byte memory? |
19:29:40 | | Join Horscht [0] (~Horscht@p549460E8.dip.t-dialin.net) |
19:29:41 | | Quit Horscht (Changing host) |
19:29:41 | | Join Horscht [0] (~Horscht@xbmc/user/horscht) |
19:31:13 | | Join yxo1 [0] (~59a984ae@www.haxx.se) |
19:36:17 | | Join yxoo [0] (59a984ae@gateway/web/freenode/ip.89.169.132.174) |
19:36:27 | | Quit yxo1 (Quit: CGI:IRC) |
19:36:42 | amayer | Torne: i hate to do this to you but can you re-review my commit. i totally messed up my local repo then pushed it. and after pushing it realized it was jacked. |
19:36:45 | amayer | http://gerrit.rockbox.org/342 |
19:37:13 | | Quit yxo (Quit: Page closed) |
19:37:28 | | Nick yxoo is now known as yxo (59a984ae@gateway/web/freenode/ip.89.169.132.174) |
19:39:00 | | Quit LambdaCalculus37 (Quit: LambdaCalculus37) |
19:55:47 | amayer | can i push a branch besides master to gerrit? |
19:55:50 | amayer | and would the mess up merging after the patch is accepted? |
19:57:48 | | Join Gallomimia [0] (~Gallo@d50-98-213-185.bchsia.telus.net) |
19:58:14 | | Join prof_wolfff [0] (~prof_wolf@213.37.219.103.dyn.user.ono.com) |
20:00 |
20:03:51 | | Join liar [0] (~liar@clnet-p09-185.ikbnet.co.at) |
20:04:16 | | Quit tjb0607 (Ping timeout: 244 seconds) |
20:07:18 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
20:07:52 | amayer | im looking for a more efficent way to work on the theme site. ive never worked on more then one patch at a time before |
20:09:08 | | Quit Topy (Quit: Leaving) |
20:13:27 | bluebrother | amayer: you can setup a repository somewhere else (like github) and push there. |
20:13:59 | amayer | i dont think im explaining this right |
20:14:27 | bluebrother | ok, then you might want to rephrase your question ;-) |
20:15:10 | amayer | lets say i want to work on file1 and make changes |
20:15:13 | amayer | at the same time i want to work on file 2 and make changes |
20:15:14 | amayer | they are for seperate commits. |
20:15:16 | amayer | if i commit file1 and then commit file2 i can no longer make ammends to file1 |
20:15:19 | amayer | how do you handle work like this? |
20:15:36 | bluebrother | do you really need to amend the commit to file1? |
20:16:06 | Bagder | you ammend commits, not files... |
20:16:48 | Bagder | with rebase -i you can ammend earlier commits too, or you can cherry-pick etc into a new branch |
20:18:12 | bluebrother | what I don't understand is why you (seem to) need to amend commits often. Amending is something you should need rarely. |
20:18:28 | bluebrother | the only exception are gerrit reviews. |
20:18:43 | amayer | im talking about gerrit reviews |
20:18:57 | bluebrother | you can also use different branches for this |
20:19:09 | amayer | ...thats what i asked in the first question |
20:19:27 | bluebrother | not exactly :) |
20:19:43 | bluebrother | you asked about pushing to different branches. You want branches. I.e. local ones |
20:19:53 | | Quit Gallomimia (Quit: Gallomimia) |
20:20:02 | bluebrother | all of those branches push to refs/for/master, so they end up as gerrit review |
20:22:59 | amayer | ok. so i can have multiple local branches and gerrit will move them to the correct spot to be merged with the master of what ever project i am working on? |
20:23:58 | bluebrother | gerrit recognizes existing reviews using the Commit-Id line. Otherwise pushing an amended commit wouldn't work. |
20:24:26 | bluebrother | it doesn't know about your local branches −− you're just pushing some commit(s). |
20:25:04 | bluebrother | and since a commit on a local branch b has a different Commit-Id than a commit on branch a (unless you cherry-picked from b) it will create a new review. |
20:25:23 | bluebrother | or update a different review if it's already existing |
20:25:58 | bluebrother | however, if you're working on multiple things it might be easier to simply create a repository on github or similar and push to that. |
20:27:07 | bluebrother | and then nag people to look at your patch series. Gerrit makes a review out of each commit which might not be the best thing in such a situation. |
20:27:37 | bluebrother | (and if you say made 7 commits you can still push the patch series to gerrit, which will then create 7 reviews) |
20:30:30 | amiconn | wodz: pong (probably timed out by now ;) ) |
20:32:47 | | Quit y4n (Quit: PANTS OFF!) |
20:33:04 | Torne | bluebrother: please don't encourage people who are doing a perfectly reasonable thing to push stuff to github instead |
20:33:13 | | Join Strife89 [0] (~Strife89@207.144.201.128) |
20:33:18 | soap | are the forums (in particular the admin panel) very slow for anyone else or just me? |
20:33:33 | amayer | bluebrother: thanks that helps. i still dont fully get it but if i can push different branches and get them reviewed thats all i need |
20:33:39 | | Join Topy44 [0] (~Topy44@f048233088.adsl.alicedsl.de) |
20:34:19 | amayer | Torne: did you see my message ^ |
20:34:26 | Torne | yes |
20:34:28 | AlexP_ | soap: Yes, the admin bits are very slow |
20:34:32 | AlexP_ | e.g. banning people |
20:34:34 | Torne | it's much better not to make new changes, though |
20:34:44 | Torne | you could've just uploaded a new patch to the old one |
20:34:57 | Torne | making new ones and abandoning the old ones means nobody who was watching the old one knows about the new one |
20:35:09 | amayer | i overwrote it with different files |
20:35:19 | Torne | that doesn't matter |
20:35:22 | amayer | thats why i was asking about branches |
20:35:23 | Torne | upload a third patch that makes it right again |
20:35:53 | bluebrother | Torne: hmm? Pushing stuff to github doesn't make it more problematic to create gerrit reviews. And given the slow reaction on gerrit reviews I had the impression it slowed amayer down. |
20:35:55 | Torne | also, your db class change patch was fine and you could've just committed it |
20:36:12 | amayer | let me explain the context |
20:36:14 | Torne | bluebrother: nobody was interested in looking at ameyer's changes at all |
20:36:21 | Torne | it's nothting to do with it being on gerrit |
20:36:31 | Torne | it's weird php hacking in the ugly themesite code |
20:36:35 | Torne | which most people are not interested in :) |
20:36:45 | amayer | i made changes to themesite.class.php |
20:36:47 | amayer | commited them to branch master |
20:36:59 | Torne | bluebrother: github encourages you to learn a workflow that's completely different from the one we use |
20:37:01 | amayer | then i made the changes to db.class.php and commited it to branch master |
20:37:21 | Torne | so, telling someone who isn't very confident in what they are doing in git to go use that instead is unhelpful |
20:37:24 | bluebrother | it does? I've never seen github as doing so |
20:37:37 | wodz | amiconn: pong |
20:37:46 | Torne | amayer: what i mean is, i approved your other change |
20:37:51 | Torne | so you could've just pressed "submit" on gerrit for it |
20:37:53 | Torne | it was approved |
20:38:02 | bluebrother | rather as "a place where I can push things (and allow people to look at it)" |
20:38:25 | soap | AlexP_, for what it's worth those last two were from the same IP address, and the same IP address as earlier ugg boot spam this morning. |
20:38:30 | amayer | i didnt know i had to do anything. i dont have commit access. |
20:38:45 | amayer | (at least not to my knowledge) |
20:38:48 | AlexP_ | amayer: No, but a committer had approved it |
20:38:56 | AlexP_ | soap: Did you ban the ip? |
20:39:27 | amayer | oh. i didnt have to do anything to my last patch. i think someone did that for me and didnt tell me i had to do it |
20:39:38 | Torne | oh, actually it's not set up to let people commit their own changes |
20:39:40 | Torne | nevermind :) |
20:39:44 | Torne | sorry. maybe it should be. |
20:39:50 | AlexP_ | yes, the committer can also submit changes |
20:39:50 | amayer | *unconfused* |
20:39:51 | AlexP_ | Oh |
20:39:58 | amayer | *reconfused* |
20:40:01 | AlexP_ | Only a committer can submit them then :) |
20:40:11 | soap | AlexP_, 6 days |
20:40:17 | AlexP_ | soap: cool |
20:40:58 | amayer | well Torne can you reaccept the new one and i will look for a submit button |
20:41:00 | Torne | amayer: anyway. no matter what mistake you have made, you can always just undo it |
20:41:08 | scorche` | hrm - forums do seem to be a bit slow... |
20:41:08 | Torne | there is never any need to start from scratch |
20:41:11 | wodz | Ok, what to do with elfloader stuff? ML thread didn't attract much attention. |
20:41:12 | Torne | it's just less convenient for everyone :) |
20:41:44 | Torne | amayer: also, in general if you want someone to review your change, add them as a reviewer :) |
20:41:44 | AlexP_ | scorche`: They are OK in general for me, it is just banning anyone (or similar admin) that is really slow |
20:41:50 | amayer | Torne: im watching a tutorial on Git from lynda.com |
20:42:19 | amayer | so i should learn alot more. i know the theory now. but i need to know how to execute what i want to do |
20:42:33 | amayer | all i know how to do now is commit, ammend, and push |
20:42:36 | | Join Gallomimia [0] (~Gallo@d50-98-213-185.bchsia.telus.net) |
20:42:52 | Torne | that's sufficient :) |
20:43:29 | amayer | well i would like to learn branches |
20:43:34 | amiconn | wodz: Regarding the paste links you mailed - yes it looks like gcc used word sized jumptable entries there, hence the bug doesn't hit. Did you use -Os, and what gcc version was that? |
20:44:01 | amayer | that way i could have worked on the db class and themesite class at the same time and had sepperate reviews that i could make changes too |
20:44:15 | Torne | amayer: i wouldn't've bothered making those separate changes in the first place |
20:44:28 | Torne | the db cleanup is so tiny it's not really necessary to make it a separate patch :) |
20:44:40 | wodz | amiconn: both 4.0.3 and 4.6.3 with -Os. I did get byte jumbtable with -O2 but the code is a bit weird as it reshuffles the order of cases also. |
20:45:15 | amiconn | hmm. |
20:45:41 | amayer | i thought for the sake of the log i would put it in there so people could see that is where the database class was last edited |
20:45:42 | amayer | (hears echos in the themesite cave he is standing in) |
20:45:44 | amayer | ...or just for my own sake |
20:46:28 | amayer | Torne: you merged the patch? |
20:46:52 | amiconn | It may reshuffle the order of cases to shorten the maximum offset |
20:46:59 | Torne | yes |
20:47:02 | amayer | thanks |
20:47:34 | amiconn | It probably won't do that if the (numerically) last case does have the biggest block of code |
20:47:57 | amayer | should i keep putting "themesite:" at the begining of commit messages? |
20:48:06 | AlexP_ | please |
20:48:07 | * | amiconn wonders what's different between this test case and the sound setup function which has been crashing due to that bug back then |
20:49:04 | amayer | Torne: so now i do a rebase and commit my next change? |
20:49:32 | Torne | the themesite is a completley separete repo, so i don't see the need to repeat it in the commit message |
20:49:40 | AlexP_ | ah, forgot that |
20:49:51 | Torne | including it just makes the oneline summary longer :) |
20:50:07 | amayer | Torne: thats what i was thinking |
20:54:30 | amayer | Torne: when i add you as a reviewer does it send you an email or something? |
20:56:06 | wodz | amiconn: http://pastie.org/5139178 gcc-4.6.3 with -O2 |
20:59:09 | amiconn | Is this patched or unpatched? |
20:59:48 | Torne | yes |
21:00 |
21:00:46 | amiconn | wodz: In this example, the largest offset is 0xc4, hence the bug won't hit |
21:01:46 | * | amiconn is building unpatched gcc 4.0.3 in order to put together an example that triggers the bug |
21:02:13 | wodz | amiconn: I know, but it is hard to predict the offset if gcc changes the order |
21:02:25 | wodz | 4.6.3 is vanilla |
21:04:00 | | Quit Gallomimia (Quit: Gallomimia) |
21:04:09 | scorche` | saratoga: ping |
21:07:45 | *** | Saving seen data "./dancer.seen" |
21:13:38 | | Quit liar (Remote host closed the connection) |
21:14:37 | wodz | amiconn: I am unable to find combination which increases the offset near problematic boundary - if I increase size of one case it is reshuffled, if I increase sizes of more cases it switches to word offsets. This is all with -O2, -Os always use word jump entries with gcc-4.6.3. |
21:15:09 | wodz | at least thats what I get |
21:16:02 | | Join pretty_function [0] (~sigBART@123.252.214.43) |
21:17:50 | | Join Horschti [0] (~Horscht@xbmc/user/horscht) |
21:20:34 | | Quit pretty_function (Ping timeout: 244 seconds) |
21:21:13 | | Quit Horscht (Ping timeout: 240 seconds) |
21:22:08 | | Quit mortalis (Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/) |
21:29:58 | | Quit kevku (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/) |
21:31:19 | | Quit wodz (Quit: Leaving) |
21:38:19 | | Quit ender1 (Quit: Punch a psychic today: ask them if they saw it coming.) |
21:41:39 | | Quit pamaury (Read error: Operation timed out) |
21:43:33 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
21:44:59 | amiconn | hrrm, he's gone |
21:48:32 | saratoga | scorche`: pong |
21:50:02 | | Quit XavierGr () |
21:52:13 | | Quit tjb0607 (Ping timeout: 255 seconds) |
21:53:31 | | Join XavierGr [0] (~xavier@rockbox/staff/XavierGr) |
22:00 |
22:13:17 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
22:20:37 | | Quit amayer (Remote host closed the connection) |
22:34:09 | | Quit n17ikh (Ping timeout: 260 seconds) |
22:34:56 | | Join n17ikh [0] (~n17ikh@128.204.195.239) |
22:34:57 | | Quit n17ikh (Changing host) |
22:34:57 | | Join n17ikh [0] (~n17ikh@unaffiliated/n17ikh) |
22:37:52 | | Quit Strife89 (Quit: Heading out.) |
22:52:19 | | Quit tjb0607 (Ping timeout: 248 seconds) |
23:00 |
23:03:16 | | Join JdGord [0] (~AndChat80@49.176.66.171) |
23:05:53 | | Quit JdGord (Read error: Connection reset by peer) |
23:07:35 | | Join Gallomimia [0] (~Gallo@d50-98-213-185.bchsia.telus.net) |
23:07:48 | *** | Saving seen data "./dancer.seen" |
23:09:44 | | Join JdGord [0] (~AndChat80@49.176.66.171) |
23:10:37 | | Quit Rower85 (Quit: Hmmm...) |
23:10:43 | | Join JdG [0] (~AndChat80@CPE-58-166-121-189.lnse5.cht.bigpond.net.au) |
23:13:55 | | Quit JdGord (Read error: Connection reset by peer) |
23:18:55 | | Join tjb0607 [0] (~tjb0607@208.100.172.134) |
23:19:59 | | Quit yxo (Quit: Page closed) |
23:20:44 | | Join amayer [0] (~alex@72.25.43.213) |
23:26:48 | | Part PathosesNorms |
23:28:18 | | Join ender1 [0] (krneki@foo.eternallybored.org) |
23:29:50 | | Quit XavierGr (Ping timeout: 245 seconds) |
23:31:13 | | Quit derk0pf () |
23:41:37 | | Nick ParkerR_ is now known as jmad2011 (ParkerR@unaffiliated/parkerr) |
23:41:53 | | Nick jmad2011 is now known as ParkerR_ (ParkerR@unaffiliated/parkerr) |
23:43:15 | | Nick ParkerR_ is now known as ParkerR (ParkerR@unaffiliated/parkerr) |
23:43:33 | | Nick ParkerR is now known as ParkerR_ (ParkerR@unaffiliated/parkerr) |
23:49:40 | | Join lebellium_ [0] (~chatzilla@e179065022.adsl.alicedsl.de) |
23:50:22 | amayer | when you select order by "Rating" "Descending" should themes be ordered by rating alphebeticaly or themes with 10 ratings of 5 stars be in front of themes with 6 ratings of 5 starts? |
23:51:13 | | Quit lebellium (Ping timeout: 240 seconds) |
23:51:20 | | Nick lebellium_ is now known as lebellium (~chatzilla@e179065022.adsl.alicedsl.de) |
23:55:01 | AlexP_ | by rating alphabetically? |
23:55:17 | AlexP_ | rating is I believe average rating |
23:55:18 | | Join JdGord [0] (~AndChat80@49.176.67.216) |
23:55:36 | amayer | im talking about the order on a page when sorted |
23:55:42 | AlexP_ | and ascending/descending is low to high and vice versa |
23:56:02 | AlexP_ | yes, but I don't know what rating alphabetically means |
23:56:08 | gevaerts | I'd say when equal, most ratings wins |
23:56:24 | amayer | Theme "A" has 5 ratings |
23:56:26 | amayer | Theme " |
23:56:28 | AlexP_ | yes, if the average is identical |
23:56:34 | amayer | B" has 6 start |
23:56:40 | gevaerts | And when still equal then, go alphabetical |
23:56:44 | amayer | hold on let me retype |
23:56:46 | AlexP_ | right |
23:57:47 | | Quit bertrik (Ping timeout: 244 seconds) |
23:58:03 | copper | (A: 10 * 5) > (A: 6 * 5) > (B: 6 * 5) |
23:58:10 | | Quit JdG (Ping timeout: 252 seconds) |
23:58:29 | AlexP_ | yup |
23:58:51 | AlexP_ | imo of course :) |