00:05:47 | | Quit GodEater (Ping timeout: 245 seconds) |
00:05:47 | | Nick GodEater_ is now known as GodEater (uid12452@rockbox/staff/GodEater) |
00:17:45 | | Join dewlap [0] (~dewlap@2001:5c0:1000:a::37) |
00:21:13 | | Join GodEater` [0] (~whoknows@97e12365.skybroadband.com) |
00:31:01 | | Quit y4n (Quit: HOLY SHIT! WE'RE ALL JUST LIVING ON A GINORMOUS FUCKING SPINNING ROCK FLOATING THROUGH SPACE CIRCLING A BIG FUCKING BALL OF FIRE!!!) |
00:54:33 | | Quit stoffel (Remote host closed the connection) |
00:55:20 | | Quit onder` (Quit: leaving) |
00:56:14 | | Join onder` [0] (~onder@24.244.89.228) |
01:00 |
01:02:06 | | Quit onder` (Ping timeout: 260 seconds) |
01:03:01 | *** | Saving seen data "./dancer.seen" |
01:15:36 | | Quit thegeek_ (Ping timeout: 246 seconds) |
01:28:21 | | Quit ender1 (Quit: Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan) |
01:36:42 | | Quit bertrik (Read error: Operation timed out) |
01:42:09 | | Quit ZincAlloy (Quit: CGI:IRC) |
02:00 |
02:07:28 | | Join onder` [0] (~onder@24.244.89.228) |
02:14:03 | | Join robin0800 [0] (~Robin0800@cpc1-brig15-2-0-cust755.3-3.cable.virginmedia.com) |
02:46:13 | | Quit robin0800 (Quit: KVIrc 4.3.1 Aria http://www.kvirc.net/) |
02:47:14 | | Join robin0800 [0] (~Robin0800@cpc1-brig15-2-0-cust755.3-3.cable.virginmedia.com) |
03:00 |
03:03:05 | *** | Saving seen data "./dancer.seen" |
04:00 |
04:04:15 | | Quit robin0800 (Quit: KVIrc 4.3.1 Aria http://www.kvirc.net/) |
04:04:36 | | Join robin0800 [0] (~Robin0800@cpc1-brig15-2-0-cust755.3-3.cable.virginmedia.com) |
04:34:36 | | Quit jlbiasini (Remote host closed the connection) |
04:35:33 | | Join jlbiasini [0] (~metaphysi@86.34.67.25) |
04:37:02 | | Quit pixelma (Disconnected by services) |
04:37:02 | | Join pixelma_ [0] (pixelma@rockbox/staff/pixelma) |
04:37:03 | | Nick pixelma_ is now known as pixelma (pixelma@rockbox/staff/pixelma) |
04:37:03 | | Quit amiconn (Disconnected by services) |
04:37:03 | | Join amiconn_ [0] (amiconn@rockbox/developer/amiconn) |
04:37:07 | | Nick amiconn_ is now known as amiconn (amiconn@rockbox/developer/amiconn) |
04:51:50 | | Quit jlbiasini (Quit: jlbiasini) |
05:00 |
05:03:09 | *** | Saving seen data "./dancer.seen" |
05:15:26 | | Join mortalis [0] (~mortalis@175.195.185.183) |
05:54:45 | | Quit robin0800 (Read error: Connection reset by peer) |
05:56:51 | | Quit [7] (Read error: Operation timed out) |
05:58:46 | | Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) |
06:00 |
06:00:53 | | Nick SuperBrainAK is now known as DormantBrain (~andy@shared02.balt01.cd.2g2u.net) |
06:14:04 | | Join TeruFSX [0] (~TeruFSX@65-128-181-81.mpls.qwest.net) |
06:14:32 | | Quit TeruFSX (Read error: Connection reset by peer) |
06:14:49 | | Join tertu [0] (~tertu@65-128-181-81.mpls.qwest.net) |
06:21:39 | | Quit mortalis (Ping timeout: 276 seconds) |
06:28:20 | dunpeal_ | copper: when you told me to analyze my file, what exactly am I looking for? |
06:28:56 | dunpeal_ | copper: (my m4a file that plays in Ubuntu's Totem but doesn't in Rockbox) |
06:38:06 | saratoga | i'd check what codec was used |
06:39:00 | saratoga | we don't support some of the weirder AAC flavors for instance, and very long or very oddly formatted M4A streams can require more memory to decode that some mp3 players have |
06:54:19 | | Quit dunpeal_ (Quit: leaving) |
06:54:46 | | Join dunpeal [0] (~dunpeal@unaffiliated/dunpeal) |
06:55:26 | dunpeal | saratoga: Why would a very long m4a be a problem? I've never noticed any issues with very long mp3's, e.g. audiobooks |
06:56:00 | saratoga | at some point you run out of memory trying to parse the table of contents in the MP4 file |
06:58:58 | dunpeal | saratoga: ah, I see. and that never happens in mp3, since they don't even support a TOC |
06:59:05 | dunpeal | Worse is better yet again! |
07:00 |
07:03:10 | *** | Saving seen data "./dancer.seen" |
07:26:10 | saratoga | newer MPEG formats do suffer badly from design by committee overengineering |
07:26:24 | | Quit tertu (Ping timeout: 248 seconds) |
07:39:50 | | Join kevku [0] (~kevku@2001:0:c38c:c38c:28c1:46bd:3d69:bebc) |
08:00 |
08:25:49 | | Join mortalis [0] (~mortalis@175.195.185.201) |
08:26:18 | dunpeal | Is there a recommended fix? I have a whole set of m4a that rockbox doesn't play. |
08:33:36 | saratoga | what codec? |
08:34:20 | | Join bluebrother [0] (~dom@rockbox/developer/bluebrother) |
08:34:41 | dunpeal | saratoga: how do I detect? |
08:35:00 | saratoga | most software that can play m4a files will tell you the codec |
08:35:04 | saratoga | i use foobar2000 |
08:35:35 | dunpeal | saratoga: Audiobook Builder 1.5.3 (www.splasm.com), QuickTime 7.7.1 |
08:35:49 | saratoga | ? |
08:36:00 | [Saint] | what the... |
08:36:34 | dunpeal | that's the "encoder" line for mplayer |
08:36:46 | | Quit mortalis (Ping timeout: 264 seconds) |
08:36:47 | dunpeal | Selected audio codec: [ffaac] afm: ffmpeg (FFmpeg AAC (MPEG-2/MPEG-4 Audio)) |
08:36:53 | | Quit bluebrother^ (Ping timeout: 240 seconds) |
08:37:03 | saratoga | so some kind of AAC |
08:37:20 | saratoga | what are you running rockbox on? |
08:37:21 | | Quit fs-bluebot (Ping timeout: 264 seconds) |
08:37:26 | dunpeal | Sansa Clip Zip |
08:37:59 | saratoga | i think that should play any type of AAC quicktime can make |
08:38:17 | saratoga | probably some issue with how the m4a file is built |
08:38:45 | dunpeal | Is there something I can do? I have avconv installed. |
08:38:48 | saratoga | if you unpack the AAC stream and repack it back into MP4 I bet it works |
08:39:07 | dunpeal | Using avconv (I'm on Ubuntu here) |
08:39:33 | saratoga | i don't know what that is, but if you're familiar with it and you think it works go for it |
08:39:43 | dunpeal | thanks, let me try. |
08:40:32 | saratoga | i think i've used mp4box for this, but i can't really remember |
08:40:40 | saratoga | but therees a ton of software for working with mp4 files |
08:43:52 | dunpeal | no go |
08:44:11 | dunpeal | saratoga: extracted AAC stream says "(ERR)" |
08:44:15 | dunpeal | on the playlist |
08:44:41 | saratoga | what did you do? |
08:45:27 | dunpeal | avconv -i foo.m4b -acodec copy output.m4b |
08:45:59 | saratoga | i thought you said these were m4a files? |
08:46:37 | dunpeal | sorry, m4b |
08:46:52 | dunpeal | (didn't realize there was any difference) |
08:47:16 | saratoga | i think theres more crap in the mp4 file if its m4b |
08:47:27 | dunpeal | should have been extracted |
08:47:51 | dunpeal | Mplayer does play it, but emits these warnings incessantly: Too many audio packets in the buffer: (4096 in 1027289 bytes). |
08:48:02 | saratoga | oh is acconv just ffmpeg? |
08:48:26 | dunpeal | don't think so, it's part of libav |
08:49:37 | saratoga | try "avconv -i foo.m4b -acodec copy -movflags faststart output.m4a" |
08:49:48 | saratoga | libav and ffmpeg are forks of the same project |
08:50:54 | dunpeal | sigh, "Option movflags not found." |
08:52:06 | saratoga | its in the libav manual so i don't know what to tell you |
08:52:08 | saratoga | anyway i'm going to bed |
08:52:12 | dunpeal | guess it's too old |
08:52:15 | | Quit saratoga (Quit: Page closed) |
08:52:16 | dunpeal | saratoga: thanks anyway :) |
08:52:20 | dunpeal | you've been very helpful |
09:00 |
09:03:12 | *** | Saving seen data "./dancer.seen" |
09:14:29 | | Join thegeek [0] (~thegeek@40.200.16.62.customer.cdi.no) |
09:29:45 | | Join y4n [0] (~y4n@unaffiliated/y4ndexx) |
09:56:38 | | Quit kevku (Ping timeout: 245 seconds) |
09:56:56 | | Join kevku [0] (~kevku@2001:0:c38c:c38c:28c1:46bd:3d69:bebc) |
10:00 |
10:04:25 | | Join ender` [0] (krneki@foo.eternallybored.org) |
10:16:44 | | Quit shamus (Read error: Connection reset by peer) |
10:16:51 | | Join shamus [0] (~shmaus@ip-206-192-195-49.marylandheights.ip.cablemo.net) |
10:21:01 | | Join fs-bluebot [0] (~fs-bluebo@g226071070.adsl.alicedsl.de) |
10:26:10 | | Join melmothX [0] (~melmoth@unaffiliated/melmothx) |
10:29:20 | | Join stoffel [0] (~quassel@pD9E40A07.dip0.t-ipconnect.de) |
10:34:13 | | Join jlbiasini [0] (~metaphysi@89.136.132.239) |
10:38:50 | | Quit GodEater (Disconnected by services) |
10:38:54 | | Nick GodEater` is now known as GodEater (~whoknows@97e12365.skybroadband.com) |
10:39:01 | | Quit GodEater (Changing host) |
10:39:01 | | Join GodEater [0] (~whoknows@rockbox/staff/GodEater) |
10:41:33 | | Join bertrik [0] (~quassel@rockbox/developer/bertrik) |
11:00 |
11:03:13 | *** | Saving seen data "./dancer.seen" |
11:36:29 | | Quit stoffel (Remote host closed the connection) |
11:37:57 | | Quit Raptors (Quit: Leaving) |
11:40:44 | | Join zaphee [0] (~user@ede67-2-82-232-36-5.fbx.proxad.net) |
11:40:49 | | Part zaphee |
11:50:07 | | Join Raptors [0] (~whoneedsa@216-58-33-203.cpe.distributel.net) |
11:57:24 | bertrik | wow, nice work jhMikeS, 308 insertions(+), 2020 deletions(-) |
12:00 |
12:08:59 | bertrik | hm, I realise that I haven't done any significant work on rockbox in the past year or so |
12:19:51 | copper | relax, there's no performance review at the end of the year! ;) |
12:21:07 | jlbiasini | yeah, it's no use: pamaury would win anyway... |
12:21:37 | jlbiasini | et copper, do you want to test something coo? |
12:21:42 | jlbiasini | *cool |
12:22:01 | jlbiasini | for the fuze+... |
12:22:22 | [Saint] | bertrik: I assure you, there's lots of people thinking the same thing... |
12:22:48 | [Saint] | We went ahead and got...y'know, lives and stuff. We should be ashamed :) |
12:23:02 | copper | jlbiasini: whassup? |
12:25:07 | jlbiasini | I have a series of patch on git with touchpad going to sleep while keylock, and also volume keys available while keys locked. Also I change the power state of the touchpad in normal use to a more economic one and it seems perfectly usuable |
12:25:53 | copper | "going to sleep"? |
12:25:58 | copper | how do you unlock? |
12:26:03 | jlbiasini | it might be because this power state is not implemented and that it actually default to normal but the rmi interface does report being inthis state |
12:26:12 | jlbiasini | with power |
12:26:16 | jlbiasini | as usual |
12:26:35 | copper | oh right |
12:26:52 | copper | I think my brain went into power saving mode |
12:27:39 | jlbiasini | At first I just setted the sensitivity to -127 to avoid lcd refresh but then I realise the touchpad has some ppower sleep option... So now I'm using that |
12:27:39 | copper | I don't want volume keys to work while locked though |
12:27:54 | * | [Saint] sincerely doubts "volume while keys clocked" will be committed. |
12:28:10 | [Saint] | keylock == keys locked. |
12:28:20 | [Saint] | anything else is highly non-obvious. |
12:28:25 | copper | [Saint]: at what frequency are they CLOCKED though? ;) |
12:28:27 | jlbiasini | yes that's why I still need to implement a setting screen for that because it a very often asked |
12:28:41 | [Saint] | even still. |
12:28:45 | [Saint] | I'd fight it. |
12:28:46 | [Saint] | sorry. |
12:29:02 | [Saint] | We don;t need any more settings, nor do we need keylocks doing non-obvious things. |
12:29:10 | jlbiasini | [Saint]: I won't goes in this discution again, touchpad is not a key |
12:29:12 | bertrik | I can see the point of excepting volume control from key lock |
12:29:48 | [Saint] | touchpad isn't a...pfffft. |
12:29:52 | [Saint] | whatever. |
12:30:39 | copper | disabling the touchpad on softlock would be nice though |
12:30:45 | jlbiasini | + the idea is to have it only the device that have touch device and to have it unactivate by default |
12:31:40 | [Saint] | I still think its ugly. |
12:32:04 | [Saint] | pure touchscreen devices are a slight exception in the Rockbox world, but, this isn;t one. |
12:32:34 | [Saint] | and even the pure touchscren devices don;t do this by default, nor offer a setting. |
12:33:38 | [Saint] | Open this door, and very soon you'll get "Can we seek as well"? |
12:33:45 | [Saint] | then "can we skip too?" |
12:34:48 | [Saint] | If you want to be able to adjust the volume easily, putting softlock on in the first place seems broken. |
12:34:56 | [Saint] | and it takes a second to disable it. |
12:35:54 | jlbiasini | [Saint]: the point remains that you cannot handle touch device the way you handle hard keys because they are not the same. |
12:36:17 | [Saint] | sure you can. |
12:36:33 | [Saint] | there's no reason it needs to be different. |
12:36:47 | [Saint] | with regard to keylock, that is. |
12:37:07 | jlbiasini | but it's not mine. I have no opinion. I don't care if I want it I can code it for myself and basta. |
12:37:28 | [Saint] | I never said you couldn't. |
12:37:30 | copper | jlbiasini: you sound french :) |
12:37:56 | [Saint] | What I *did* say was: "try get this in, and I'll be vocal about it" |
12:38:04 | [Saint] | that is NOT the same as "don't do it". |
12:38:09 | gevaerts | Indeed not |
12:38:39 | jlbiasini | for example if you don't desactivate touchpad on keys lock you end up having all the time the lcd refreshing killing the battery |
12:38:39 | gevaerts | You'll just need to convince enough people :) |
12:38:56 | copper | jlbiasini: again, I'm interested in disabling the touchpad during softlock. About the touchpad power state, does lowering it _really_ make a difference, with regards to battery life? |
12:38:57 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
12:39:09 | [Saint] | I never said it wasn't sane to deactivate it. |
12:39:21 | [Saint] | just that its insane to deactive only *some* function :) |
12:39:30 | jlbiasini | [Saint]: I didn't meas bad I just meant that if I talking about it it's because alot of people are asking for it on the fuze+ |
12:39:47 | [Saint] | Users ask for a lot of silly things. |
12:39:54 | [Saint] | We needn't oblige them :) |
12:39:57 | gevaerts | Well |
12:40:13 | gevaerts | There's been some consensus about this a few years ago IIRC |
12:40:17 | jlbiasini | copper: that were you come in to test!!! |
12:40:19 | gevaerts | Look for the D2 |
12:41:14 | copper | jlbiasini: I'm already getting 32 hours of playback with the Fuze+ |
12:41:47 | copper | I just don't think it's needed, and I'd be worried of unforeseen consequences |
12:42:10 | * | [Saint] worries about "can I have N too" |
12:42:15 | jlbiasini | pamaury and I hited 39 hours |
12:42:34 | [Saint] | ...and you're worried about battery life? cute. :) |
12:42:43 | jlbiasini | yes I know we have to see with pamaury also |
12:42:50 | ZincAlloy | that's plenty. I should definitely get one.. |
12:43:43 | jlbiasini | [Saint]: it's critical to improve it because we are missing only 8 hours to double the OF battery time :D |
12:44:02 | * | gevaerts isn't against allowing volume changes while on hold on targets that happen to support that, *if* there is a setting |
12:44:03 | ZincAlloy | that would be quite impressive :D |
12:45:00 | jlbiasini | gevearts: I plan to have a setting |
12:45:20 | [Saint] | If LCD refresh is the issue...then, can't you just sleep the LCD? |
12:45:39 | [Saint] | that would yeild far greater benefit. |
12:46:03 | copper | [Saint]: the difference between 1) the power and volume keys, and 2) the touchpad, is that the touchpad gets accidentally activated a lot easier |
12:46:37 | [Saint] | copper: I realize this, but there's no reason to treat them any differently. |
12:46:43 | jlbiasini | the idea is also to still be able to consult the screen while being locked |
12:46:44 | [Saint] | locked is locked. |
12:46:57 | gevaerts | See also http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-11/0032.shtml and before (also look at previous months!) |
12:46:59 | [Saint] | I very much dislike "keys locked, but...not this one" |
12:47:05 | copper | yeah, I'd disable everything except the power key |
12:47:22 | gevaerts | Thread starts at http://www.rockbox.org/mail/archive/rockbox-dev-archive-2009-10/0086.shtml |
12:47:54 | [Saint] | jlbiasini: shouldn't that be up to the user? |
12:48:03 | * | copper curses SanDisk for not including an actual lock switch, like everyone else |
12:48:12 | [Saint] | If the screen can sleep, would it not have the screen timeout setting for hold? |
12:48:33 | [Saint] | softlock and hold are treated virtually identically, are they not? |
12:48:55 | [Saint] | if they're not, they should be. |
12:49:09 | * | jlbiasini realize he has no idea of the difference between softlock and keylock... :( |
12:50:21 | bertrik | I understand softlock to be the equivalent of keylock, on devices that don't have a physical lock key |
12:50:50 | jlbiasini | [Saint]: the idea I see it it should only be available on target that have touchscreen and for which it present an obvious benefit. Then on the top of it there should be a setting |
12:50:57 | [Saint] | that's as I thought too. |
12:51:18 | [Saint] | meaning that devices that can dim the backlict and/or sleep the lcd should present these settings and use them for softlock too. |
12:51:27 | [Saint] | if they don't, this should be corrected. |
12:51:28 | jlbiasini | ok then all I was saying was about sorftlock sorry for the confusion... |
12:52:23 | [Saint] | I'm curious what "the obvious benefit" is... |
12:52:39 | [Saint] | All I see is counterintuitive behaviour for a keylock. |
12:54:33 | jlbiasini | well if a device touch sub device isn't that sensitive to trigger an lcd refresh all the time (for example I thing that some touchdevice react only to hand and so on) |
12:54:36 | | Nick aevin_ is now known as aevin (eivindsy@microbel.pvv.ntnu.no) |
12:54:52 | | Quit aevin (Changing host) |
12:54:52 | | Join aevin [0] (eivindsy@unaffiliated/aevin) |
12:55:36 | [Saint] | the lcd refresh should only be a problem for users that have chosen to leave the screen awake during lock. |
12:56:01 | [Saint] | I'll say again that if softlock targets don't present this setting when the screen can be slept, this is an issue. |
12:56:51 | [Saint] | targets that can sleep the screen, and can lock, should present settings that dictate how the screen behaves in this state. |
12:57:03 | copper | [Saint]: not exactly: it's currently a problem because the touchpad gets activated accidentally, and wakes up the display |
12:58:34 | [Saint] | Aha. I seem to have misunderstood. |
12:59:30 | [Saint] | so, back to my previous position, then: softlock for touchpad == good, allowing volume change in this state == bad. :) |
13:00 |
13:01:23 | [Saint] | combined with "softlock should sleep the screen (based on user settings)". |
13:02:09 | copper | I think both the touchpad and display should be completely disabled during softlock |
13:02:19 | copper | if you want to turn on the screen to see what's playing, press Power |
13:02:26 | copper | then press Power again to lock |
13:03:14 | *** | Saving seen data "./dancer.seen" |
13:03:43 | jlbiasini | those are 2 different aspect actually 1) everything or just touchpad 2) kill touchpad while locked |
13:04:30 | copper | ? |
13:05:23 | jlbiasini | copper: I you want to the change in touchpad power setting it's g#525 |
13:05:26 | fs-bluebot | Gerrit review #525 at http://gerrit.rockbox.org/r/525 : [Fuze+][Touchpad] Improve touchpad power managment by Jean-Louis Biasini (changes/25/525/4) |
13:06:33 | jlbiasini | *if you |
13:08:12 | jlbiasini | copper: the only problem with this methods is that the device doesn't report anymore to be locked because the screen won't react anymore |
13:08:57 | copper | with that patch, or what I said? |
13:09:13 | jlbiasini | what you said |
13:09:26 | copper | the DAP isn't supposed to react at all, when locked |
13:09:38 | copper | I don't _want_ it to react |
13:09:46 | copper | it's the whole point of locking the device |
13:11:02 | jlbiasini | well considering all the different point of view even amoung developpers I would say that a softlock or keylock setting menu were we can define the way it should be locked wouldn't hurt... |
13:12:10 | jlbiasini | those are all little difference and really easy to implement actually. I was surprise myself to be able to code something clean about it |
13:13:22 | copper | I don't see how one could justify the device reacting to anything while _locked_ |
13:13:35 | copper | if it reacts, the locking mechanism isn't doing its job |
13:14:07 | copper | having the device react intentionally, is a matter of pressing one button: the power button |
13:14:16 | [Saint] | There's already a setting for this wrt screen visibility isn't there? |
13:14:35 | [Saint] | something along the lines of chosing whether or not a keypress wakes the backlight or screen? |
13:14:41 | copper | [Saint]: there's no setting regarding locking on the Fuze+ |
13:14:50 | [Saint] | no, I mean in general. |
13:15:01 | [Saint] | targets that have "real" hold. |
13:15:43 | jlbiasini | copper: if you add g#523 and g#526 to the previous patch you will have touchpad sleeping while softlock |
13:15:45 | fs-bluebot | Gerrit review #523 at http://gerrit.rockbox.org/r/523 : Disable touch device on keyhold for targets that handle it by Jean-Louis Biasini (changes/23/523/3) |
13:15:47 | fs-bluebot | Gerrit review #526 at http://gerrit.rockbox.org/r/526 : [Fuze+] activate the automatic touchpad disable on keylock by Jean-Louis Biasini (changes/26/526/1) |
13:15:55 | copper | [Saint]: the Classic has "Backlight on Hold" |
13:16:07 | [Saint] | copper: right, that's it, thanks. |
13:16:12 | jlbiasini | saint: yes but it's in the screen section |
13:16:18 | [Saint] | THAT is what should be happening here. :) |
13:16:49 | [Saint] | hold and softlock shouldn't be treated much differntly at all. |
13:17:02 | [Saint] | if they are *that* is the problem. |
13:17:07 | copper | jlbiasini: on the Classic, the touchwheel doesn't do anything while on hold (lock), as it should |
13:17:13 | [Saint] | We already have settings in place that could manage this. |
13:17:22 | [Saint] | ...just, not for this case, due to oversight. |
13:17:40 | [Saint] | (oversight isnt really the owrd for it, this target didn't exist at that time :)) |
13:17:52 | [Saint] | *word |
13:18:04 | jlbiasini | what is the classic? |
13:18:08 | copper | iPod Classic |
13:18:09 | ZincAlloy | short sightedness? |
13:18:20 | copper | and the screen turns on when unlocking, as it should |
13:20:07 | jlbiasini | that's strange because I didn't saw anything in the action.c code about this which means it's in the driver itself? |
13:20:16 | gevaerts | I have to admit that I'm *totally* lost in this discussion. My understanding is that a "touch device" is an *input* device. How is it related to LCD refresh at all? And what's the point of g#526? Surely locking keys implies not listening to touch events *naturally*? |
13:20:22 | fs-bluebot | Gerrit review #526 at http://gerrit.rockbox.org/r/526 : [Fuze+] activate the automatic touchpad disable on keylock by Jean-Louis Biasini (changes/26/526/1) |
13:21:14 | copper | gevaerts: currently, softlock disables the touchpad functionalities, but doesn't disable it (it still reacts and turns on the display) |
13:21:31 | [Saint] | gevaerts: I'll admit, I got lost, too. I _think_ I'm on track again, though... |
13:21:31 | gevaerts | Oh. *why*? |
13:21:33 | copper | it turns on the display and a pop-up that says "locked" |
13:21:36 | [Saint] | I _think_. |
13:22:16 | copper | so what you get, is the Fuze+ display that often turns on and off while in your pocket |
13:22:21 | jlbiasini | gevaerts: it do listen to report that keys are locked which is only in my opinion ok as long as those keys doens't get fire all the time |
13:24:03 | copper | gonna try #523 and #526 |
13:24:24 | [Saint] | If I paraphrase the whole last hour I so, I get this: "I made some patches that do broken stuff to fix an issue of a device doing broken stuff that should probably not be that way" |
13:24:27 | gevaerts | Is there any point in ever handling this differently for different touch devices? |
13:24:47 | copper | hmmm |
13:24:50 | gevaerts | Because if not, this should *not* be inside "#ifdef HAS_TOUCH_DEVICE_DISABLED_ON_KEYLOCK" |
13:24:51 | copper | fails to build |
13:25:26 | gevaerts | So while I can see there is some debate about what a touchpad should do while locked, I do *not* like HAS_TOUCH_DEVICE_DISABLED_ON_KEYLOCK at all |
13:25:31 | copper | http://pastebin.com/raw.php?i=wxn8eyXr |
13:25:34 | jlbiasini | copper: you cannot pick only those 2 you need the 3 of them |
13:25:44 | copper | ah |
13:26:48 | * | gevaerts thinks #define proliferation is much worse than settings growth |
13:27:16 | bertrik | both are bad IMO |
13:27:23 | copper | http://pastebin.com/raw.php?i=ZwUtbx4T |
13:27:24 | jlbiasini | gevaerts: the problem is that it rely on drivers defining their own touchdev_disable and touchdev_wake_up |
13:28:14 | jlbiasini | copper: this is strange it compiles on my computer |
13:28:17 | bertrik | and I don't want a setting for everything that we couldn't agree on |
13:29:18 | jlbiasini | I thought drivers should define their own way to disable a touchdevice |
13:29:52 | [Saint] | Isn't the glaringly obvious question "why the flying f**k does this target handle the touchpad so differently"? |
13:29:56 | jlbiasini | depending on how good ours driver for a touchdevice is it can be very different |
13:30:08 | copper | I ran configure again |
13:30:12 | copper | btw |
13:30:15 | [Saint] | I mean, we have other targets with touchpads, no? And hold/softlock (there shouldn;t be a distinction here?? |
13:30:19 | copper | vanilla fuze+ from git doesn't compile either |
13:30:20 | | Join HankJW [0] (~b20c14df@www.haxx.se) |
13:30:35 | HankJW | Greetings. |
13:30:52 | copper | build error with vanilla Fuze+: http://pastebin.com/raw.php?i=7fqCz1yY |
13:31:02 | [Saint] | why isn't the touchpad just disabled on softlock? What is the point of the splash to say its locked firing from the touchpad? |
13:31:10 | copper | jlbiasini: ok, that compiled |
13:31:49 | HankJW | Guys, can anyone help with this: http://forums.rockbox.org/index.php/topic,43285.0.html |
13:31:49 | HankJW | Im really in need of my ipod. |
13:31:49 | jlbiasini | copper: woaw I was really starting to wonder what could it be... |
13:31:49 | gevaerts | jlbiasini: regardless of how this turns out, you should at least define touchdev_disable() and friends in button.h, not in any device-specific button-target.h that happens to need it |
13:32:06 | jlbiasini | ok |
13:32:17 | copper | seems like I can't just run "make clean && make" and hope it will always work |
13:32:36 | jlbiasini | I just made those patch I have also to wait for pamaury review on it anyway |
13:32:41 | bertrik | HankJW: perhaps a short-circuit somewhere, from parts pressing onto each other? |
13:32:47 | gevaerts | HankJW: is the battery OK? If it's old and starting to expand, it could push too hard on some parts |
13:32:55 | bertrik | or perhaps a crack in the PCB that makes intermittent contact |
13:33:38 | HankJW | gevaerts, yeah the battery seems fine and its not that old |
13:34:13 | HankJW | Well, the odd thing is also that sometimes even when disassembled it doesnt start |
13:34:18 | [Saint] | the "solution" seems to be as simple as "stop the touchpad from firing the silly "I'm locked" splash... |
13:34:24 | [Saint] | stop me if I'm missing something. |
13:34:48 | [Saint] | No other target does this with their touchpad when keys are locked iirc. |
13:35:31 | copper | woah |
13:35:37 | copper | what's up with the volume |
13:36:07 | jlbiasini | slow huh? it's a bug that pamaury is working on... ;) |
13:36:17 | gevaerts | HankJW: possibly some cracks somewhere then, as bertrik suggested |
13:36:46 | [Saint] | another possibility is the rear case creating a bridge. |
13:36:54 | [Saint] | line it with insulation tape. |
13:36:59 | HankJW | the pcb? Excuse my lack of knowledge, but whats a pcb |
13:37:05 | copper | jlbiasini: with your patches, the screen still turns on when touching the touchpad |
13:37:15 | gevaerts | HankJW: printed circuit board |
13:37:19 | [Saint] | "printed circuit board" |
13:37:22 | [Saint] | awww.. |
13:37:33 | jlbiasini | copper: oups still work to do then... |
13:37:37 | * | gevaerts beats [Saint] fair and square :) |
13:37:50 | jlbiasini | which patch did you installed? |
13:37:55 | HankJW | well, I disassembled it completely and all the parts seems fine |
13:38:22 | gevaerts | jlbiasini: just to keep bothering you, I'd say whether or not this splash shows up shouldn't depend on the target being able to switch off the touch device |
13:38:44 | jlbiasini | :D |
13:39:08 | gevaerts | There are of course dependencies between the two, but power management and behaviour should be treated reasonably independently |
13:39:46 | copper | "%pv" on the Fuze+ currently does NOT display values in decibels |
13:39:57 | [Saint] | this is known. |
13:39:59 | copper | ok |
13:40:22 | copper | so that answers my previous question about whether I should upgrade or wait |
13:40:23 | [Saint] | divide by 10 and it should be right. ;) |
13:40:24 | copper | (I should wait) |
13:41:13 | [Saint] | or, apply g#519 |
13:41:15 | fs-bluebot | Gerrit review #519 at http://gerrit.rockbox.org/r/519 : Fix volume handling of steps in wps, list and radio by Amaury Pouly (changes/19/519/1) |
13:41:25 | jlbiasini | gevaerts: ha then I could actually use the patch I made to keeps volume key working. But it suppose to define all hard keys manually on all target |
13:41:35 | gevaerts | HankJW: very small cracks won't be easy to see, but can still have serious effects if the board is just *slightly* bent or pushed |
13:41:50 | gevaerts | It could still be something else of course |
13:41:52 | copper | [Saint]: I don't suppose that patch would do anything about the volume keys being slow |
13:42:38 | jlbiasini | copper: g#519 is about this problem... |
13:42:40 | fs-bluebot | Gerrit review #519 at http://gerrit.rockbox.org/r/519 : Fix volume handling of steps in wps, list and radio by Amaury Pouly (changes/19/519/1) |
13:42:53 | jlbiasini | copper: which patch did you used? |
13:43:08 | copper | 523, 525 and 526 |
13:43:14 | HankJW | well, as the board was never bent or pushed I dont think thats the issue. In fact, I only disassemlbed it twice in the whole years I own the ipod. And when doing so, I was as careful as I can |
13:43:53 | [Saint] | even slight drops could cause this. |
13:44:10 | [Saint] | I'm willing to bet the damage happened at disassembly, though. |
13:44:15 | [Saint] | all signs point to this. |
13:44:18 | [Saint] | or, magic. |
13:44:29 | [Saint] | I'm not siding with magic or coincidence. |
13:44:36 | | Quit fs-bluebot (Quit: timeout?) |
13:44:48 | HankJW | well, the problems appeared maybe 2 months ago or so |
13:45:07 | HankJW | The drive wasnt workin correctly |
13:45:12 | HankJW | so I bought a new hdd cable |
13:45:17 | HankJW | now the drive works again |
13:45:25 | HankJW | I thought it was the only issue... |
13:45:30 | bertrik | does it get unusually hot? |
13:45:35 | HankJW | no. |
13:45:41 | [Saint] | that's new information. |
13:45:53 | [Saint] | the forum reads like :I took it apart, and this happened" |
13:45:54 | [Saint] | sorry. |
13:46:00 | HankJW | oh |
13:46:03 | HankJW | my mistake |
13:46:03 | | Quit y4n (Quit: MOTHER EUROPA CALLING ME!) |
13:46:22 | gevaerts | Maybe also a bad cable somewhere? Those flat cables are easy to damage... |
13:46:50 | [Saint] | the ribons don't like being bent when they're old, no. |
13:46:52 | gevaerts | If it's one of those, I'd bet on the one connecting the button assembly to the mainboard |
13:47:53 | [Saint] | copper: it won't, no, but something could be done about this. |
13:48:16 | copper | "could"? |
13:48:23 | [Saint] | iiuc, the problem is the volume (internally) is in .1db steps, so multiple steps get thrown away. |
13:48:23 | copper | Should. :-> |
13:48:35 | HankJW | gevaerts: The one connecting the click wheel? |
13:48:59 | gevaerts | Yes |
13:49:03 | copper | 1dB is more than enough |
13:49:06 | gevaerts | hmmm |
13:49:08 | copper | .1dB is silly |
13:49:33 | gevaerts | HankJW: how do you try switching it on? Button presses, or connecting to usb? |
13:49:38 | gevaerts | (or both) |
13:49:41 | HankJW | button press |
13:49:48 | HankJW | also |
13:49:55 | HankJW | when rockbox actually started |
13:50:01 | HankJW | all the buttosn work fine |
13:50:23 | bertrik | 0.1 dB is about 2.3% volume difference :) |
13:50:57 | gevaerts | Try connecting USB. If it starts then (and stays on when you disconnect again), I'd say it's that ribbon. If it doesn't start then, it's unrelated to the buttons |
13:51:27 | [Saint] | the issue was likely mine for not realizing that the eq min step and the volume step were tied. |
13:51:35 | [Saint] | ...and, any review or lack thereof. |
13:52:00 | [Saint] | so, yes, I likely broke/caused this. |
13:52:20 | [Saint] | but, I had help! :) |
13:52:35 | HankJW | gevaerts: I just connected to usb. The drive is spinning, but nothing happens, the screen shows a white apple, without backlight |
13:52:49 | HankJW | oh |
13:52:57 | HankJW | now it says to connect to itunes to restore |
13:53:15 | gevaerts | Hmmmm |
13:53:20 | HankJW | oh wait |
13:53:22 | HankJW | odd |
13:53:28 | HankJW | now its in disk mode |
13:53:52 | HankJW | alright |
13:53:56 | HankJW | Ill just leave it for a bit |
13:54:00 | gevaerts | Weirdness all round |
13:54:03 | HankJW | I have to go afk for some 10 min or so |
13:54:06 | HankJW | be right back |
13:54:11 | | Nick HankJW is now known as HankJW-AFK (~b20c14df@www.haxx.se) |
14:00 |
14:08:18 | | Nick HankJW-AFK is now known as HankJW (~b20c14df@www.haxx.se) |
14:08:48 | HankJW | lol |
14:08:59 | HankJW | I just disconnected the ipod from usb |
14:09:13 | HankJW | and it still says "do not disconnect" like it is still connected |
14:09:34 | HankJW | NOW WHAT THE FUCK IS THIS |
14:09:52 | HankJW | I just restarted it |
14:10:01 | HankJW | and it loaded rockbox like it should |
14:10:06 | | Quit jlbiasini (Quit: jlbiasini) |
14:12:11 | copper | [Saint]: you break it, you buy it. WHERE'S MAH MON-NEY |
14:12:53 | | Quit HankJW (Quit: CGI:IRC (EOF)) |
14:12:58 | | Join Hank-JW [0] (~b20c14df@www.haxx.se) |
14:13:09 | Hank-JW | whoops. |
14:14:53 | | Nick Hank-JW is now known as HankJW (~b20c14df@www.haxx.se) |
14:16:53 | HankJW | gevaerts: well, rather odd, but it works again |
14:16:56 | copper | [Saint]: also, you wanted to give 0.1dB adjustments in the EQ? why? |
14:17:09 | gevaerts | Let's hope it keeps working... |
14:17:25 | HankJW | same here |
14:17:38 | HankJW | end of next week Im going on vacation |
14:17:41 | HankJW | and I need to work it |
14:17:49 | HankJW | as there I dont have an internet connection |
14:18:24 | HankJW | nor the the tools or the possibilites to fix it |
14:18:55 | HankJW | I still dont know what is/was wrong with it... but now that it works again, i dont give a shit :D |
14:19:02 | HankJW | Thanks a lot for helping! |
14:19:38 | bertrik | Broken stuff that suddenly works without knowing why, will likely break again |
14:20:20 | HankJW | well, I know |
14:20:34 | HankJW | but if its working for the next month Im satisfied |
14:20:42 | copper | my iPod Classic survived a drop on the sidewalk |
14:20:42 | HankJW | after that Ill have enough time to figure it out |
14:20:59 | copper | it has a tiny dent now :( |
14:21:11 | copper | and a tiny scratch on the display |
14:21:45 | HankJW | aww. |
14:23:23 | copper | yes |
14:23:34 | copper | it's like a really hot chick with a scar on her face |
14:23:38 | copper | still hot though |
14:24:33 | | Join Topy44 [0] (~Topy44@93.190.93.215) |
14:24:37 | HankJW | scars can be sex as well. |
14:24:46 | HankJW | or at least badass :D |
14:25:17 | | Quit HankJW (Quit: CGI:IRC) |
14:30:07 | | Join tertu [0] (~tertu@65-128-181-81.mpls.qwest.net) |
14:39:23 | | Join jlbiasini [0] (~metaphysi@86.34.67.25) |
14:40:25 | jlbiasini | copper: are you sure you made this build correctly? I retested it, and it's working here... |
14:40:41 | copper | jlbiasini: I suspect that some of my settings interfere with your path |
14:41:14 | copper | http://pastebin.com/raw.php?i=SZyed582 |
14:42:54 | jlbiasini | no that shouldn't be the case. It is a early implementation there is no setting by now |
14:44:18 | | Join y4n [0] (~y4n@unaffiliated/y4ndexx) |
14:45:17 | [Saint] | copper: iirc the argument for that was that some DACs can do .2dB increments, so .1db increments means no one gets short changed (or feels that way). |
14:45:26 | copper | I mean, maybe your code doesn't execute when some other settings are enabled / disabled |
14:45:35 | [Saint] | .1dB works for both .2 and .5. |
14:45:45 | copper | [Saint]: what kind of golden ears idiots want 0.1 or 0.2dB adjustments? |
14:47:34 | [Saint] | no human could parse the difference I expect. but some people get very anal about levelling their equipment, you know this youself. |
14:47:57 | copper | can it be set back to having 1dB adjustments? |
14:48:03 | copper | 0.1dB would bug the hell out of me. |
14:48:12 | [Saint] | back to? |
14:48:16 | [Saint] | it never was that way. |
14:48:19 | copper | ? |
14:48:30 | [Saint] | its always been .5 |
14:48:36 | copper | oh, right |
14:48:40 | [Saint] | except for the last year or so |
14:48:49 | copper | wth, 0.5dB not enough? |
14:49:38 | [Saint] | the only reason you notice this is because volume handling changed slightly. |
14:50:22 | copper | hmm |
14:50:27 | copper | it's not that annoying actually |
14:50:44 | copper | not with the touchwheel of the iPod |
14:53:04 | copper | it IS annoying with the touchpad of the Fuze+ |
14:53:20 | copper | also, how come it's enabled on my old build on the Fuze+, but without the volume bug? |
14:53:41 | [Saint] | "its enabled"? |
14:53:41 | copper | 130712 |
14:53:50 | copper | 0.1dB increments on the EQ |
14:54:00 | [Saint] | see: volume handling changed slightly |
14:54:28 | copper | I thought your 0.1dB increment change on the EQ was causing the volume bug |
14:54:38 | [Saint] | it is, indirectly. |
14:55:50 | copper | not that it's so bad actually, since I've set the EQ to my liking, made a backup of my config file containing the EQ settings, and I'm unlikely to change it again |
14:56:28 | copper | but replacing 0.5dB increments with 0.1dB increments is catoring to audiophools, and I wasn't aware that that was a philosophy for Rockbox development |
14:56:55 | copper | using an EQ is supposed to make an audible difference |
14:57:07 | copper | 0.1dB changes are hardly audible, if at all |
14:58:23 | copper | http://www.hydrogenaudio.org/forums/index.php?showtopic=101834&st=0&p=839817&#entry839817 |
14:58:25 | [Saint] | write a patch and submit it to gerrit stating your case. |
14:58:53 | copper | uh? |
14:58:56 | | Quit jlbiasini (Ping timeout: 264 seconds) |
14:59:46 | [Saint] | Its the nice way of saying that nothing is likely to get done otherwise. |
14:59:50 | copper | 1) I don't know C |
14:59:56 | copper | 2) I don't know Rockbox internals |
15:00 |
15:00:08 | [Saint] | Neither did I, once. |
15:00:18 | [Saint] | That's the fun of learning! :) |
15:00:21 | copper | 3) you're the one who changed a perfectly reasonable functionality for a dubious reason |
15:00:35 | copper | 0.5dB was already overkill, IMO |
15:00:42 | [Saint] | that's nice. |
15:00:45 | [Saint] | write a patch and submit it to gerrit stating your case. |
15:01:18 | copper | did anyone else comment on your commit? |
15:01:40 | [Saint] | Wasn't my commit. |
15:01:48 | copper | I'm confused now. |
15:02:12 | copper | who did what? |
15:02:25 | [Saint] | I just put up a patch in 30s to match a user request. It was committed. |
15:02:49 | [Saint] | My patch, not my commit. |
15:03:08 | copper | and THAT kind of patch flies without questions, when other reasonable requests are heavily resisted?? |
15:03:17 | copper | o_O |
15:03:18 | *** | Saving seen data "./dancer.seen" |
15:03:43 | [Saint] | "without questions"? ...you seem confused. |
15:04:24 | copper | did anyone oppose the path or the commit? |
15:04:28 | copper | patch* |
15:04:56 | | Quit FOAD (Ping timeout: 264 seconds) |
15:05:21 | [Saint] | No. You can see that yourself. |
15:05:21 | | Join FOAD [0] (~foad@unaffiliated/foad) |
15:05:35 | copper | which is what I meant |
15:06:59 | [Saint] | The TL;DR version is: If people that care about this care so much, they should be reviewing it before it is committed, which is why gerrit exists in the first place. |
15:07:26 | copper | ugh, I can't monitor every single patch and commit |
15:07:31 | copper | I'm not even a rockbox dev |
15:07:35 | gevaerts | Of course you can |
15:07:46 | gevaerts | You can choose not to, of course |
15:08:00 | copper | did ANYONE think that was a sensible change? |
15:08:10 | [Saint] | the committer, perhaps? |
15:08:16 | gevaerts | But subscribing to new gerrit tasks is easy, and there aren't that many that they're hard to keep up with |
15:08:53 | [Saint] | If no one thought it was a sensible change, it wouldn;t have been included. |
15:09:12 | [Saint] | this is supposed to be the purpose of gerrit existing. :) |
15:09:33 | [Saint] | those that didn;t had an equal amount of time to voice their opinions, or, not. |
15:09:54 | gevaerts | Which gerrit task are we actually talking about? |
15:10:29 | [Saint] | the one that changes min eq step and min q to .1dB |
15:10:33 | [Saint] | *ed |
15:10:36 | gevaerts | Yes, I know *that* |
15:11:17 | [Saint] | g#414 |
15:11:35 | [Saint] | making me do work...lookin' stuff up...geez. :) |
15:11:52 | copper | http://gerrit.rockbox.org/r/#/c/414/ |
15:12:03 | [Saint] | awww...bluebot's on holiday. |
15:12:30 | gevaerts | Hmmm, that was a bit quick |
15:12:32 | copper | I would think that such change would require someone to post ABX logs proving the audibility of 0.1dB steps |
15:12:58 | copper | it makes using the graphical EQ a lot slower |
15:13:15 | copper | i.e. it improves nothing, and actually makes it less usable |
15:13:42 | [Saint] | there's supposed to be two different levels of step, but, that is apparently broken. |
15:13:52 | [Saint] | ie. there's min_step and fast_*_step |
15:14:31 | gevaerts | I'd say two and a half hours is *not* enough time for people to voice their opinion |
15:15:11 | [Saint] | Oh, I agree. But I don;t have control over the one person that does have an opinion pressing fire immediately. |
15:15:38 | [Saint] | It's true that both camps had an equal amount of time though. :) |
15:15:51 | [Saint] | Not my fault if you Euros sleep all day :P |
15:15:53 | copper | I don't think he thought it through |
15:16:25 | [Saint] | He thought it through somewhat. |
15:16:34 | copper | not to mention that a 0.1dB change won't do a damn thing on targets that don't have that kind of resolution |
15:16:40 | [Saint] | He abandoned a similar task in favor of that one. |
15:16:46 | gevaerts | [Saint]: you did say "If people that care about this care so much, they should be reviewing it before it is committed". That's not *possible* if you only give people two hours... |
15:17:21 | copper | also, does no-one's opinion count unless they back it up with a patch? |
15:17:26 | gevaerts | So while you do not have that control, you at least found it convenient to ignore that short time |
15:17:53 | [Saint] | copper: no, certainly not. But the odds of anything *happening* increase dramatically. |
15:17:59 | soap | I'll voice my oft-disagreed with opinion that EQ settings are another place where I don't see the need for a GUI to set 0.1dB steps, but make 0.0000000001dB steps legal in the .cfg if some nut wishes to do so. |
15:18:21 | gevaerts | copper: if you feel strongly about this, please bring it up on the dev ml |
15:18:30 | soap | (or whatever the granularity allowed in the code is) |
15:18:49 | copper | I'm trying to figure out how to pull the change as a patch, and modify it to revert it |
15:19:21 | [Saint] | click "patch" then the link given. |
15:19:30 | gevaerts | git show <id>|patch -R -p1 |
15:19:39 | [Saint] | there's a download section with multiple tabs, click patch, it'll give a link./ |
15:20:10 | [Saint] | this link, in fact: git fetch git://git.rockbox.org/rockbox refs/changes/07/407/1 && git format-patch -1 −−stdout FETCH_HEAD |
15:20:53 | * | [Saint] is having a words fail him day...link isn;t what he wants, but, it'll do. |
15:22:21 | [Saint] | gevaerts: fwiw, I didn't find it convenient or inconvenient, I literally couldn't care any less about this :) |
15:23:02 | [Saint] | I did, however, think it was a lot longer review period than 2 hours. |
15:23:26 | [Saint] | I have no personal attachment to this change at all. |
15:25:08 | copper | [Saint]: got a patch, do I post it as a new entry? |
15:26:14 | [Saint] | that's a good question. |
15:26:23 | [Saint] | yes, probably. |
15:26:32 | copper | wtf |
15:26:49 | copper | can't I register on gerrit without google or yahoo? |
15:27:02 | [Saint] | any openid provider. |
15:27:08 | | Quit ZincAlloy (Quit: CGI:IRC) |
15:27:10 | copper | ok, looking |
15:27:18 | [Saint] | you can even be your own openid provider iirc. |
15:27:27 | gevaerts | You can, yes |
15:29:26 | [Saint] | this started it, iirc: http://forums.rockbox.org/index.php/topic,42765.0/wap2.html |
15:34:40 | soap | right. but how did the rather reasonable request and original patch evolve into the current one? |
15:35:26 | [Saint] | a "hey, it would be great if..." conversation with the OP here, I believe. |
15:36:33 | gevaerts | There are a bit too many of those quick patches lately |
15:37:20 | gevaerts | Behaviour changes need to be discussed in some way that gives people time to respond |
15:38:42 | copper | ffs |
15:38:53 | copper | the guy even requested 0.05dB increments |
15:38:55 | copper | he's nuts |
15:39:42 | copper | and btw, saratoga questioned the utility of that change |
15:39:48 | copper | but no-one responded |
15:40:52 | copper | AFTER the commit, apparently |
15:41:32 | copper | weeks later |
15:41:34 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
15:41:46 | copper | er no |
15:41:57 | copper | weeks after the patch, and if I understand correctly, a day after the commit |
15:43:04 | copper | ok, I can post a patch on gerrit that simply reverts the change, but it doesn't include support for finer-grained values in the configuration file |
15:43:37 | copper | does everyone agree that I should post a new entry on gerrit with that patch? |
15:43:48 | copper | some might consider incomplete |
15:43:51 | copper | it* |
15:44:20 | gevaerts | Also start a discussion on the mailing list |
15:44:50 | copper | does that mean I have to subscribe to it? |
15:45:22 | gevaerts | I think so, if you don't want to depend on moderators. You don't have to receive email from it though |
15:45:32 | copper | ok |
15:45:43 | copper | what's the correct way of linking to the original change? http://gerrit.rockbox.org/r/#/c/414/ |
15:46:04 | copper | or identifying it |
15:46:13 | copper | I see several different identifiers |
15:46:45 | gevaerts | I'd go for both the full gerrit url and the actual git commit hash |
15:47:21 | copper | how do I find the commit hash? |
15:47:52 | gevaerts | e4040d93 |
15:47:57 | gevaerts | git log |
15:49:40 | copper | you mean e4040d930fa18266e3c92722bbe62cd47280c5db ? |
15:50:00 | [Saint] | first 7 is enough to be unique |
15:50:09 | gevaerts | Shortening to 7 or 8 is common |
15:50:21 | copper | [Saint]: the log says you're the author of the commit, but that's not "your commit"? |
15:50:29 | [Saint] | No. |
15:50:45 | * | copper is confused again |
15:50:56 | [Saint] | author != committer |
15:51:05 | gevaerts | copper: [Saint] is confused, not important :) |
15:51:14 | gevaerts | [Saint]: it *is* your commit |
15:51:21 | copper | also, so many different places to deal with |
15:51:30 | copper | git, gerrit, forums, IRC, mailing lists |
15:51:57 | [Saint] | gevaerts: well...technically, I guess, with the way gerrit works. |
15:52:05 | gevaerts | No, the way *git* works |
15:52:06 | [Saint] | Here's the simple way of putting it: |
15:52:13 | [Saint] | "I made it. I didn't commit it" |
15:52:21 | [Saint] | ...even if gerrit does make it look that way :) |
15:52:35 | gevaerts | You did commit it |
15:52:44 | gevaerts | Someone else merged it into master |
15:53:14 | * | [Saint] hands gevaerts a shiny gold pedant pendant |
15:53:34 | copper | how do I even create a new entry on gerrir |
15:53:36 | copper | gerrit |
15:54:07 | [Saint] | http://www.rockbox.org/wiki/UsingGit |
15:54:34 | copper | Uploading a change for review and testing |
15:54:35 | copper | ? |
15:55:27 | [Saint] | yes, but, after "setting up gerrit" |
15:55:28 | copper | oh geez |
15:55:32 | [Saint] | you've not done so yet. |
15:55:51 | copper | I can't deal with this right now |
15:56:57 | [Saint] | i'M NOT SURE HOW YOU STAND ON THE REALNAME POLICY EITHER, IF THAT'S AN ISSUE. |
15:57:02 | [Saint] | grrr. |
15:57:06 | [Saint] | silly caps. |
16:00 |
16:00:07 | copper | I don't see the link between the two |
16:00:13 | copper | I just have other stuff to do |
16:00:51 | copper | this is a silly two-liner change that we've been discussing for an hour (or more), which requires me to set up a lot of things, when a simple forum post would do. |
16:01:22 | [Saint] | "its too hard, someone else can do it" |
16:01:26 | copper | I don't mind google knowing about my Wiki changes and my Rockbox themes |
16:01:33 | copper | I said "right now" |
16:01:38 | copper | I'll do it later |
16:02:00 | copper | bbl |
16:02:09 | [Saint] | seriously, though, setup gerrit with a realname, as we need it. |
16:02:37 | [Saint] | otherwise someone else is just going to have to cherrypick and push it directly under their name. |
16:05:39 | copper | (this is like the french administration that requires me to fill up a gazilion different forms for anything to happen) |
16:12:07 | | Join jlbiasini [0] (~metaphysi@89.136.132.239) |
16:14:24 | jlbiasini | copper: so you are in for your first commit? welcome in! |
16:14:52 | [Saint] | save that for merge. :) |
16:15:06 | jlbiasini | It seems I just missed a quite funny discution... :D |
16:15:44 | copper | meh, back for a few |
16:16:05 | copper | thinking about it, I will not post the patch |
16:16:25 | copper | since apparently it indirectly broke volume handling, and people are working on that to fix it |
16:16:36 | copper | so I guess that simply reverting the commit won't do |
16:16:59 | copper | [Saint]: that commit is all the more unfortunate that it (indirectly) caused the volume handling shitstorm |
16:17:26 | copper | which makes the current git state for the Fuze+ pretty much unusable |
16:18:03 | copper | I'm also unable to implement soap's idea of allowing fine-grained values in the configuration file |
16:18:22 | copper | (which, if it didn't affect anything else, would certainly be acceptable to me) |
16:18:31 | jlbiasini | copper: i still don't understand how these patches don't work on your device. Can I send you the rockbox.sansa file to put on your device to be sure we have the very same code? It could be important because if it turns out not to work it could means that those different touchpad we have on the fuze+ don't handle power function the same way.... |
16:18:53 | copper | jlbiasini: sure, though I don't have long |
16:19:37 | copper | also, the volume handling fixes have no reason to be, to begin with |
16:20:03 | copper | the whole thing just broken what didn't need any fixing :-/ |
16:20:07 | copper | broke* |
16:20:08 | copper | damn fingers |
16:20:33 | jlbiasini | copper: did you read the post from pamaury on the mailing list, I don't remember the detail, but there were some... :D |
16:20:44 | copper | I don't even know where the ML is |
16:20:45 | | Join fs-bluebot [0] (~fs-bluebo@g226071070.adsl.alicedsl.de) |
16:21:02 | copper | and I hate mailing lists with passion |
16:21:33 | copper | my gmail would keep telling me that friends are writing me, when really it's just a lot of chatter that doesn't interest me |
16:21:52 | [Saint] | that's what filters are for. |
16:22:10 | jlbiasini | copper: http://www.rockbox.org/mail/archive//rockbox-dev-archive-2013-07/0002.shtml |
16:22:39 | bluebrother | [Saint]: lately it seems to fall off the network quite often and then fails to disconnect. Haven't found the reason for that, it's been working quite well before :/ |
16:22:55 | bluebrother | and while I did change the bot I haven't changed that part of the code. Strange thing. |
16:23:39 | copper | jlbiasini: WHY |
16:23:52 | copper | why deal with tens of decibels, for ANYTHING? |
16:23:59 | copper | tenths* |
16:24:13 | jlbiasini | you can look at the answer that were given, basicly there are different views about it, so simply reverting the first commit could be considered as valid? I have no idea, I don't really know those kind of stuff |
16:24:26 | jlbiasini | I understand your point |
16:25:12 | copper | I see only one reply, which doesn't say anything of interest |
16:25:46 | * | [Saint] needs to trace if he actually caused this or not now. |
16:26:06 | [Saint] | (when I say "caused" that would mean I had the benefit of knowing the future at the time, but, hey...) |
16:26:30 | [Saint] | I think I'm off the hook. |
16:30:31 | jlbiasini | copper: copy that file in the .rockbox folder of your device (rename the one already present before if you want to save your build first) https://dl.dropboxusercontent.com/u/43468173/rockbox.sansa |
16:31:26 | jlbiasini | then reboot your f+ and check if whan you lock keys anything happens if you touch the touchpad |
16:32:48 | copper | jlbiasini: that works, I guess I screwed up my previous build |
16:33:39 | jlbiasini | cool It would have been strange to have a non RMI standart touchpad in place of the usual one... |
16:33:42 | copper | jlbiasini: was that built against a fully up to date git source? |
16:33:56 | copper | seems not |
16:34:04 | copper | since it doesn't have the volume problem |
16:34:29 | jlbiasini | it's a patched one |
16:35:05 | jlbiasini | I didn't want to revert all the patch since you said you didn't had much time |
16:35:27 | copper | correction |
16:35:32 | jlbiasini | I think that I did revert the non locking of volume keys |
16:35:32 | copper | it does have the volume problem |
16:36:03 | jlbiasini | yeah I was surprised it didn't because I revert it also |
16:36:40 | jlbiasini | do you want a quick rebuild including the volume patch from pamaury? |
16:37:17 | copper | no thanks |
16:37:42 | jlbiasini | ok |
16:37:48 | copper | I'll just wait for the [REDACTED] to get ironed out |
16:37:53 | copper | gotta go |
16:43:56 | jlbiasini | well considering the implementation specificity it could last because the advantage of relying on a general function was that it doesn't need to recognized wether a keymaps come from hard keys or from virtuals ones |
16:44:25 | jlbiasini | it just disable the touchdevice |
16:45:52 | | Quit derf (Ping timeout: 240 seconds) |
16:45:54 | jlbiasini | gevaerts: would it still be ok to rely on such a function implemented in the driver, if the power stuff are done separatly |
16:46:08 | jlbiasini | ? |
16:50:22 | | Quit tertu (Ping timeout: 260 seconds) |
16:50:37 | | Quit kiwicam (Read error: Operation timed out) |
16:52:35 | jlbiasini | the alternative is to have a bit cache with all the button define as something like HARD_KEYS in the button_target.h file of every touch device and to compare it to the keys before reacting in action.c |
16:53:13 | jlbiasini | or the oposite VIRTUAL_KEYS |
17:00 |
17:03:12 | | Join derf [0] (~derf@fuzzyneural.net) |
17:03:21 | *** | Saving seen data "./dancer.seen" |
17:36:35 | | Quit kevku (Ping timeout: 260 seconds) |
17:42:08 | jlbiasini | Ok I just had a look to the Classic code to handle wheel and keylock. Actually that device has a real keylock so the wheel get disable at driver level which makes sense. BUT the fuze+ having only softkeys cannot test directly at driver level for it, or at least I don't thik that it is the role of a drivers to perform such action. It is rockbox using the drivers to decede what should happen and how to do it, not the other way around... any idea on th |
17:42:08 | jlbiasini | at? |
17:52:58 | | Quit jlbiasini (Ping timeout: 264 seconds) |
17:55:22 | | Quit derf (Ping timeout: 245 seconds) |
18:00 |
18:10:45 | | Quit ZincAlloy (Quit: CGI:IRC (EOF)) |
18:17:56 | | Join derf [0] (~derf@fuzzyneural.net) |
18:22:56 | | Quit derf (Ping timeout: 264 seconds) |
18:30:08 | | Quit mrtux (Ping timeout: 264 seconds) |
18:32:47 | | Nick DormantBrain is now known as SuperBrainAK (~andy@shared02.balt01.cd.2g2u.net) |
18:35:02 | | Join mrtux [0] (~colin@unaffiliated/mrtux) |
18:39:01 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
18:40:13 | ZincAlloy | station art works exactly like album art and I have to place the jpgs inside the fm preset folder, right? |
18:42:57 | ZincAlloy | I've named a preset "Radio Salzburg" and placed a file named Radio Salzburg.jpg in the folder. When I turn on the radio now Rockbox gets stuck on a "predefined instru.." screen |
18:45:24 | [Saint] | s/pre/un/? |
18:48:33 | ZincAlloy | must have been the file. tried a different file and there's no problem |
18:50:18 | ZincAlloy | oh, wait, the other file is incorrectly named |
18:51:47 | ZincAlloy | no error screen, but it does make rockbox crash |
18:53:35 | ZincAlloy | no screen updates at first. and if I keep on trying it doesn't react at all. gotta check my fms code once again, but it should be ok. I took the album art part from a working wps |
18:57:39 | ZincAlloy | sorry, it was undefined instru... indeed |
19:00 |
19:03:04 | | Quit ZincAlloy (Quit: CGI:IRC (Ping timeout)) |
19:03:24 | *** | Saving seen data "./dancer.seen" |
19:04:25 | | Quit BowieKnife (Ping timeout: 240 seconds) |
19:09:02 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
19:10:42 | ZincAlloy | sorry, crashed. The clip zip simulator also crashes when it tries to load station art |
19:15:01 | | Join derf [0] (~derf@fuzzyneural.net) |
19:21:57 | ZincAlloy | seems to be known bug: http://www.rockbox.org/tracker/task/12797?type=2 I should have looked it up first, sorry! |
19:35:29 | | Nick SuperBrainAK is now known as DormantBrain (~andy@shared02.balt01.cd.2g2u.net) |
19:36:04 | | Quit melmothX (Quit: #) |
19:46:16 | copper | I can't tell what commit broke volume control on the Fuze+. Is it one of the "keymaps" updates? |
19:46:25 | copper | (yes, I could just bisect) |
19:53:28 | copper | hmmm |
19:53:43 | copper | how do I reply to an existing message on the mailing list, without having a copy? |
19:54:05 | copper | "Re: <subject>" in the subject? |
19:55:40 | * | copper hasn't used mailing lists in over a decade |
19:56:16 | gevaerts | That's probably the best you can do if you can't add a proper reply to header |
19:57:04 | copper | in-reply-to? |
19:57:44 | gevaerts | yes, but you need the message id for that |
19:57:58 | copper | yeah, the archive doesn't seem to provide it |
19:58:39 | copper | hmm |
19:58:45 | copper | if gmail can do it, I don't know how |
20:00 |
20:02:32 | | Quit derf (Ping timeout: 264 seconds) |
20:09:54 | | Join kevku [0] (~kevku@2001:470:27:773:0:feed:c0f:fee) |
20:19:08 | copper | posted |
20:24:51 | | Join derf [0] (~derf@fuzzyneural.net) |
20:38:24 | | Quit bluebrother (*.net *.split) |
20:38:24 | | Quit amiconn (*.net *.split) |
20:38:24 | | Quit pixelma (*.net *.split) |
20:38:24 | | Quit preglow (*.net *.split) |
20:38:24 | | Quit Jack87 (*.net *.split) |
20:38:25 | | Quit Elfish (*.net *.split) |
20:38:25 | | Quit Gareth (*.net *.split) |
20:47:24 | | Join Gareth [0] (~gareth@2607:ff38:2:83::3) |
20:47:27 | | Join Elfish [0] (amba@2001:1608:12:1:13:3:3:7) |
20:47:42 | | Join preglow [0] (thomj@skrotnisse.pvv.ntnu.no) |
20:48:37 | | Join bluebrother [0] (~dom@rockbox/developer/bluebrother) |
20:49:11 | | Join Jack87 [0] (Jack87@nasadmin/admin/jack87) |
20:52:58 | | Quit akaWolf (Ping timeout: 264 seconds) |
20:53:13 | | Join pixelma [0] (pixelma@rockbox/staff/pixelma) |
20:53:14 | | Join amiconn [0] (amiconn@rockbox/developer/amiconn) |
21:00 |
21:03:27 | *** | Saving seen data "./dancer.seen" |
21:10:26 | | Join saratoga [0] (123e11e0@gateway/web/freenode/ip.18.62.17.224) |
21:10:33 | saratoga | why was the volume resolution changed anyway? |
21:13:02 | | Join linuxguy4 [0] (~timj@24-148-61-208.c3-0.lem-ubr1.chi-lem.il.cable.rcn.com) |
21:14:55 | | Join evilnick_ [0] (~evilnick@d54C370E0.access.telenet.be) |
21:16:19 | | Join B4gder [241] (~daniel@rockbox/developer/bagder) |
21:20:07 | | Quit Bagder (*.net *.split) |
21:20:07 | | Quit evilnick (*.net *.split) |
21:20:07 | | Quit linuxguy3 (*.net *.split) |
21:21:43 | saratoga | B4gder: ping |
21:23:24 | | Quit ZincAlloy (Quit: CGI:IRC (EOF)) |
21:26:22 | | Quit Galois (Ping timeout: 240 seconds) |
21:28:16 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
21:39:37 | | Join Bagder [0] (~daniel@90-229-190-134-no63.tbcn.telia.com) |
21:39:37 | | Quit Bagder (Changing host) |
21:39:37 | | Join Bagder [241] (~daniel@rockbox/developer/bagder) |
21:40:00 | | Join thegeek_ [0] (~thegeek@40.200.16.62.customer.cdi.no) |
21:40:58 | | Join amiconn_ [0] (amiconn@rockbox/developer/amiconn) |
21:40:58 | | Quit amiconn (Disconnected by services) |
21:41:02 | | Nick amiconn_ is now known as amiconn (amiconn@rockbox/developer/amiconn) |
21:42:18 | | Join pixelma_ [0] (pixelma@rockbox/staff/pixelma) |
21:42:19 | | Quit pixelma (Disconnected by services) |
21:44:23 | | Join Guest11127 [0] (Slayer@c-69-143-178-62.hsd1.va.comcast.net) |
21:45:25 | bertrik | Was volume always in dB already? I can even imagine that volume could be just "steps" with the driver being able to convert step 'X' into a dB value |
21:46:07 | | Join B4gd3r [0] (~daniel@178.174.211.166) |
21:47:06 | | Quit gevaerts (Disconnected by services) |
21:47:11 | | Join gevaerts_ [0] (~fg@rockbox/developer/gevaerts) |
21:47:43 | | Quit SrRaven (*.net *.split) |
21:47:59 | | Join uwe__ [0] (~uwe_@dslb-088-064-051-171.pools.arcor-ip.net) |
21:48:59 | | Join copper_ [0] (~copper@unaffiliated/copper) |
21:49:56 | | Quit copper (Disconnected by services) |
21:49:56 | | Nick copper_ is now known as copper (~copper@unaffiliated/copper) |
21:50:25 | copper | [Saint]: "Thank you for your fantastic theme. However I presume there is an issue. In the now playing screen, if the Artist or Album Name is long, when it starts to slide, the whole line beeps rapidly." |
21:50:37 | copper | that's what I reported the other day |
21:50:39 | saratoga | IIRC it used to be 1dB steps that the drivers converted into their native units, but i don't know what the recent changes involved |
21:51:03 | copper | when the available width is a tiny bit too small, the line blinks instead of scrolling |
21:51:13 | | Join knitt1 [0] (~knittl@unaffiliated/knittl) |
21:51:33 | | Join TBCOOL [0] (~tb@213.113.53.137) |
21:51:59 | | Join dv__ [0] (~quassel@80.108.9.40) |
21:52:48 | | Quit thegeek (Ping timeout: 264 seconds) |
21:52:55 | | Quit Guest81512 (Ping timeout: 264 seconds) |
21:53:09 | | Quit B4gder (*.net *.split) |
21:53:09 | | Quit dv_ (*.net *.split) |
21:53:10 | | Quit knittl (*.net *.split) |
21:53:10 | | Quit uwe_ (*.net *.split) |
21:53:10 | | Quit TBCOOL_ (*.net *.split) |
21:54:10 | copper | how to reproduce: download http://outpost.fr/stuff/iBox-random_access_memories.zip, set the theme to "iBox", change the "album" tag of any song to "Random Access Memories", play that song |
21:54:18 | | Quit ZincAlloy (Quit: CGI:IRC (Ping timeout)) |
21:54:35 | copper | works in the iPod Video sim |
21:54:44 | | Quit dv__ (Excess Flood) |
21:54:47 | copper | I mean, the bug shows in the iPod Video sim |
21:54:55 | copper | can be reproduced* |
21:56:37 | | Join ZincAlloy [0] (~d9eeacd9@www.haxx.se) |
21:56:47 | | Join dv_ [0] (~quassel@chello080108009040.14.11.vie.surfer.at) |
21:57:33 | | Join preglow_ [0] (thomj@skrotnisse.pvv.ntnu.no) |
21:57:44 | | Quit bluebrother (Disconnected by services) |
21:57:49 | | Join bluebrother [0] (~dom@rockbox/developer/bluebrother) |
21:57:59 | | Join gevaerts [0] (~fg@rockbox/developer/gevaerts) |
21:58:27 | | Quit FOAD (Remote host closed the connection) |
21:58:27 | | Quit dunpeal (Remote host closed the connection) |
21:59:16 | | Join guymann_ [0] (~c@unaffiliated/guymann) |
21:59:35 | | Quit preglow (Write error: Broken pipe) |
21:59:36 | | Quit Belzebub (Write error: Broken pipe) |
21:59:36 | | Quit makoto_ (Write error: Broken pipe) |
21:59:36 | | Quit gevaerts_ (Write error: Broken pipe) |
21:59:36 | | Quit fs-bluebot (Quit: timeout?) |
21:59:55 | | Quit guymann (Write error: Connection reset by peer) |
22:00 |
22:03:36 | | Join makoto [0] (~makoto@hey.dont.privmsg.me.uk) |
22:04:45 | | Join Belzebub [0] (~j4ck@gateway/shell/sundance.i-rpg.net/x-vyhbcalsttgczcce) |
22:06:44 | copper | interestingly, I can't reproduce that bug with the Fuze+ |
22:06:56 | copper | with the same font, metadata and dimensions |
22:08:11 | | Join EstebanMonge [0] (~emonge@201.191.195.250) |
22:10:44 | | Join JdGord [0] (~AndChat72@pa49-176-48-2.pa.nsw.optusnet.com.au) |
22:10:45 | | Join SrRaven [0] (srraven@fatfecker.shagged.org) |
22:11:46 | | Join dunpeal [0] (~dunpeal@unaffiliated/dunpeal) |
22:16:22 | copper | ok, I see the blinking happening on the iPod Video sim even when the available width is significantly narrower than the metadata value |
22:17:07 | | Join Strife89 [0] (~Strife89@2602:306:250e:c3c9:b58b:e8b7:3dcb:d1d1) |
22:17:27 | | Quit JdGord (Ping timeout: 245 seconds) |
22:19:22 | | Nick DormantBrain is now known as SuperBrainAK (~andy@shared02.balt01.cd.2g2u.net) |
22:19:26 | copper | hmmm |
22:19:28 | copper | very interesting |
22:20:40 | copper | the title and artist theme fields are exactly the same dimensions, but the bug doesn't happen with the track title section on my theme |
22:23:29 | | Join JdGord [0] (~AndChat72@pa49-176-48-2.pa.nsw.optusnet.com.au) |
22:23:42 | copper | wow |
22:23:50 | | Quit JdGord (Client Quit) |
22:23:58 | copper | the bug is fixed if I change the color of the field from 666666 to 000000 o_O |
22:24:26 | | Quit y4n (Quit: Do you like hurting other people?) |
22:25:14 | | Join einhirn [0] (~Miranda@p4FC77924.dip0.t-ipconnect.de) |
22:26:11 | copper | all colors except black cause the bug, apparently |
22:29:37 | | Quit Bagder (Quit: It is time to say moo) |
22:29:56 | | Quit einhirn (Ping timeout: 248 seconds) |
22:29:59 | bertrik | if it happens in the sim as well, it's much easier to debug |
22:30:58 | bertrik | copper: can you wrap everything up in a flyspray bug? |
22:33:06 | copper | about the theme bug? |
22:33:35 | copper | I don't even know what the report |
22:33:46 | copper | I don't understand what's causing it at all |
22:33:58 | copper | I'm trying a bunch of things |
22:34:36 | copper | it does seem to have something to do with colors |
22:38:20 | | Quit Belzebub (Changing host) |
22:38:20 | | Join Belzebub [0] (~j4ck@unaffiliated/blown-engine) |
22:38:20 | | Quit Belzebub (Changing host) |
22:38:20 | | Join Belzebub [0] (~j4ck@gateway/shell/sundance.i-rpg.net/x-vyhbcalsttgczcce) |
22:40:50 | | Join einhirn [0] (Miranda@bsod.vpn.tu-clausthal.de) |
22:41:24 | copper | I don't understand |
22:41:45 | copper | http://pastebin.com/rTEpyKCF |
22:41:49 | copper | this causes it to blink |
22:50:40 | | Join jlbiasini [0] (~metaphysi@86.34.67.25) |
22:54:29 | | Join FOAD [0] (~foad@unaffiliated/foad) |
22:56:33 | | Quit EstebanMonge (Ping timeout: 246 seconds) |
22:59:53 | copper | this is incomprehensible |
23:00 |
23:03:29 | *** | Saving seen data "./dancer.seen" |
23:06:12 | soap | to be clear, copper, there is widespread consensus that "in the .cfg only" settings are Not Policy |
23:06:35 | soap | and I don't cap my fist initial. ;) |
23:07:42 | copper | I'm going insane over that blinking bug |
23:08:26 | | Join EstebanMonge [0] (~emonge@201.191.195.8) |
23:16:56 | | Quit EstebanMonge (Ping timeout: 268 seconds) |
23:17:27 | | Quit kevku (Ping timeout: 245 seconds) |
23:17:43 | copper | super weird |
23:18:06 | copper | I fixed it by putting the color definition (%Vf) and the metadata (%s%ac%id) on the same line |
23:18:18 | copper | there were no trailing characters |
23:39:11 | | Quit jlbiasini (Ping timeout: 248 seconds) |
23:48:26 | pixelma_ | I've sometimes seen blank lines in viewports where non should be and the positioning of %Vf or even other thing in the code affecting it. Maybe what you see as "blinking" is a short appearance of a blank line? |
23:48:41 | | Nick pixelma_ is now known as pixelma (pixelma@rockbox/staff/pixelma) |
23:57:37 | copper | hmmm |
23:57:53 | copper | you mean a blank line that has the same height as the text? |
23:58:07 | copper | as opposed to a 1px high line |