Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2016-11-15

00:01:21[Saint]See, that's where they get you, TorC. That's what they want you to believe.
00:01:21[Saint]They walk among us.
00:01:21[Saint]Neil Young is actually a pigmy pilot whale in a photorealistic latex suit.
00:01:52[Saint]It's the only reasonable explanation as to why his bullshit marketing of HD audio makes sense.
00:02:57Galoisthe opus codec doesn't even support 44.1khz audio. People should just standardize on 48khz for the sake of not having to support two different things.
00:07:16[Saint]I will freely admit that there is absolutely a time and a place for 32/64/96/192 bit 96/192/384/... encoded audio.
00:07:27[Saint]But this is /not/ in the consumer market.
00:08:01[Saint]If you're mastering an album or a major motion picture, that headroom and resolution is absolutely very useful.
00:08:15[Saint]For Joe Everyday, is absolutely is not.
00:09:08[Saint]Joe Everyday the audiophile however will flatly refuse to believe this and will go to great lengths to attempt to disprove it.
00:09:37[Saint]But hilariously those great lengths never seem to include peer reviewed a/B/X testing though.
00:10:36[Saint]It's all just subjective "I can hear the difference, and if you can't, you're an idiot" statements and the use of frankly hilarious adjectives to describe their shit-brain insanity-riddles subjective claims.
00:13:14[Saint]"It really brings out the caramel tones of the mids, and the crunchy vanilla bran flake taste of the lows and the exciting hit of sharpness and sweetness from the highs."
00:14:05[Saint]"With five essential vitamins and iron, and added dietary fiber, HD audio is essential to a balanced breakfast and the start of a productive day!"
00:14:33[Saint]"Pick up a pack of Audiophile(TM) brand HD wheat flakes at a supermarket near you!"
00:19:49 Quit vifino (Ping timeout: 256 seconds)
00:23:02 Join vifino [0] (
00:24:33BilgusI see you've encountered a few of these guys and read their magazines
00:26:10[Saint]Such is the nature of the game in being a volunteer/staffer/moderator here for the better part of a decade.
00:40:46 Join ploco [0] (3a604baa@gateway/web/freenode/ip.
00:41:21 Quit lebellium (Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923])
00:44:42plococan someone just push this into main?
00:46:20plocoit's not perfect but the hack nothing is perfect in this project.
00:47:08plocoso this patch is just somthing somthing make RaaAoA work again.
00:48:46 Quit paulk-collins (Quit: Leaving)
00:48:59 Quit ender` (Quit: The 50-50-90 rule: Anytime you have a 50-50 chance of getting something right, there's a 90% probability you'll get it wrong. — Andy Rooney)
00:51:02plocorevert one silly patch around of framebuffer and push this, the wheel will rolls again. how complicate is this?
00:51:02[Saint]Rockbox has a Do It Right philosophy.
00:51:48[Saint]No one has any interest in hacking the fuck out of the core to make a port no one cares about function again.
00:52:08plocowhat have you done about the RaaAoA issue [SAINT]?
00:52:19plocosorry [Saint]
00:52:21***Saving seen data "./dancer.seen"
00:54:11plocoyour words are so old that become nothing at all . once again, what have you done about the ART issue? the resolution fragmentation?
00:54:16[Saint]I have done the same thing that many of us did and recognized that hacks on top of hacks to fix up what was never a good idea to begin with is not a way that this project should go.
00:55:00plocoprove it. show me the patch you have done for RaaAoA
00:55:01[Saint]The way forward for RaaA is with a central library and a native UI. Not this mess.
00:56:13plocoits too easy to said then actually do something.
00:56:39[Saint]We've known how to work around this mess for a very long time. You seem to confuse something that can be done with something that should be done.
00:56:47TorC[Saint]: On usefulness of high resolution audio: Yep. That's the same reason it's often useful to have a higher resolution camera and shoot raw - so that you have room to futz with the output.
00:57:37plocowho are we you refer? not include you i know
00:58:12[Saint]You don't know your ass from your elbow.
00:58:55TorC[Saint]: Here's the unofficial theme song of the Audiophiles. I'm sure you'll get a chuckle from it.
01:02:23plocopff, what a PM wannabe.
01:02:26 Part ploco
01:03:01[Saint]A who in the what now?
01:08:05[Saint]I honestly don't even know why ploco cares about this. They've been quite happy with their crazy Chinese Rockbox fork where they can add all the hacks they want for the longest time.
01:09:37[Saint]The person who sumitted that gerrit task /has/ direct commit access and knows damn well that just because something can be done doesn't mean it should be and that crazy abuses like this don't belong in core.
01:12:15[Saint]The way forward for Rockbox in Android is with a central library, but without anyone really being able to agree on exactly what that library should or shouldn't handle, and without anyone actually wanting to do the work on it it stagnates.
01:12:19 Quit xorly| (Ping timeout: 258 seconds)
01:18:04 Quit atsampson (Ping timeout: 258 seconds)
01:29:40 Quit girafe (Quit: Leaving)
01:30:08 Join atsampson [0] (
01:41:29 Quit Bilgus (Ping timeout: 260 seconds)
01:43:25 Join Bilgus [0] (ae6611d9@gateway/web/freenode/ip.
01:45:21 Join PurlingNayuki [0] (~Thunderbi@
01:47:17 Quit PurlingNayuki (Remote host closed the connection)
01:47:39 Join PurlingNayuki [0] (~Thunderbi@
01:51:37 Quit PurlingNayuki (Remote host closed the connection)
01:52:50 Join PurlingNayuki [0] (~Thunderbi@
01:56:53 Quit PurlingNayuki (Remote host closed the connection)
01:57:15 Join PurlingNayuki [0] (~Thunderbi@
01:59:09 Quit PurlingNayuki (Remote host closed the connection)
02:03:00 Join PurlingNayuki [0] (~Thunderbi@
02:07:04 Quit PurlingNayuki (Remote host closed the connection)
02:25:00 Quit krnlyng (Ping timeout: 260 seconds)
02:37:30 Join krnlyng [0] (
02:52:24***Saving seen data "./dancer.seen"
02:58:23__builtinhow do "overlay" plugins work?
03:20:46 Quit [Saint] (Remote host closed the connection)
03:22:08 Join [Saint] [0] (~sinner@rockbox/staff/saint)
04:11:41 Quit Bilgus (Quit: Page closed)
04:12:25 Join Bilgus [0] (ae6611d9@gateway/web/freenode/ip.
04:26:36 Quit [Saint] (Remote host closed the connection)
04:28:02 Join [Saint] [0] (~sinner@rockbox/staff/saint)
04:49:39 Quit michaelni (Ping timeout: 265 seconds)
04:52:28***Saving seen data "./dancer.seen"
05:01:59 Join michaelni [0] (
06:08:55 Quit TheSeven (Disconnected by services)
06:09:04 Join [7] [0] (~quassel@rockbox/developer/TheSeven)
06:21:11 Quit bluebrother (Disconnected by services)
06:21:16 Join bluebrother^ [0] (~dom@rockbox/developer/bluebrother)
06:21:41 Join fs-bluebot [0] (
06:23:48 Quit fs-bluebot_ (Ping timeout: 248 seconds)
06:52:30***Saving seen data "./dancer.seen"
06:53:31 Join johnb2 [0] (
07:03:01Bilgusjohnb2: latest is up on gerrit should be the final one
07:24:08 Quit amiconn (Quit: - Chat comfortably. Anywhere.)
07:24:09 Quit pixelma (Quit: .)
07:26:40 Join pixelma [0] (~pixelma@rockbox/staff/pixelma)
07:26:41 Join amiconn [0] (~amiconn@rockbox/developer/amiconn)
07:36:46 Quit johnb2 (Ping timeout: 250 seconds)
08:11:45 Quit krabador (Remote host closed the connection)
08:29:49 Join ender` [0] (
08:36:50 Join wodz [0] (
08:48:47 Join petur [0] (~petur@
08:48:47 Quit petur (Changing host)
08:48:47 Join petur [0] (~petur@rockbox/developer/petur)
08:51:45 Join pamaury [0] (~pamaury@rockbox/developer/pamaury)
08:52:31***Saving seen data "./dancer.seen"
09:02:35wodzpamaury: Have you got my mail?
09:04:43 Join paulk-collins [0] (
09:08:48pamaurywodz: yes thanks :)
09:09:25 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:69f0:c8dd:5cd0:e8e7)
09:09:41pamaurywodz: if I have time today, I will push modification to create the sony toolchain (though it will require the swedes to upload things) and maybe you will be able to try to run code on the E470
09:10:36pamaury__builtin: I am not sure but I think overlay plugin are basically plugins loaded by plugins. They need special linking because they are loaded at a different address. But to be honest I never looked into it. Do you have anything more specific to ask?
09:12:16wodzpamaury: What is best way to contribute to nwz port now?
09:12:23wodzpamaury: I mean what is needed
09:13:35wodzplugin ovelays basically load plugins into pcm buf AFAIK so target with small ram can load plugins bigger then codec buffer
09:18:17pamaurywodz: right now, wait until I push the nwz port (that has no driver for anything except display). Then we need to add for the various drivers: keys (should be easy with what I have), touchscreen (same), fmradio (there is a sony proprietary driver in lib/modules), and audio
09:19:08pamauryon audio, they use alsa so I'm going to create a toolchain that links against Sony's alsa, and there some scripts in the rootfs to tweak alsa knobs, change routing, etc... it should be possible to figure out how it works to implement audio routing
09:20:59wodzpamaury: how is usb handled? I saw kernel module related to this in rootfs
09:32:32pamauryah, it's a bit of long story
09:32:47pamauryI have to go to work, but I'll write how usb works in this channel later today
09:37:08 Quit pamaury (Ping timeout: 245 seconds)
09:42:50 Join xorly| [0] (
10:07:30 Join einhirn [0] (
10:19:34 Join pamaury [0] (~quassel@rockbox/developer/pamaury)
10:37:27wodzpamaury: I'll try to disassemble icx_si470x_radio_tuner.ko later today
10:45:43pamaurywodz: cool :) I have disassembled a number of things in those rootfs, ask me first so we don't duplicate the work
10:46:01pamauryI haven't looked at icx_si470x_radio_tuner though\
10:46:21pamaurywodz: so about usb, you need to understand the whole architecture of the system
10:46:58wodzpamaury: extracting ioctl interface from this si470x driver should be fairly easy
10:47:11pamaurywodz: also look at sony kernel headers
10:47:19pamaurythey contain the ioctl for some drivers
10:47:35wodzpamaury: where do I look for this sources?
10:48:06pamaurylinux-kernel-2.6.35.tgz is the only really interesting bit
10:49:28pamaurywodz: so the system has managed by a program called sysmgrd. This program is responsible for choosing which program is in the foreground (as well as other things). There are two mains "apps": SpiderApp (the OF interface) and Responder (the MSC/MTP responder)
10:50:09pamaurywhen usb is plugged, sysmgrd will wait under SpiderApp exists and runs Responder. If SpiderApp does not exits, sysmgrd will not kill it, so usb connection is basically not happening.
10:51:14wodzpretty weird
10:51:21pamaurywhen Responder starts, it loads g_nw_xxx (don't remember the name)
10:52:19pamaurythis one is actually a multiplexer that wait for the first usb requests to choose between MTP and MSC. It then forwards all requests to either MTP or MSC driver. The MSC driver is mostly the standard linux one, with g_nw_scsi to handle vendor scsi requests. The MTP driver g_nw_mtp forwards all requests to Responder where they are handled in userspace
10:52:34***Saving seen data "./dancer.seen"
10:53:14pamauryso in short: Rockbox should quit when USB is plugged, to let sysmgrd take care of it
10:53:33pamaurythe usb status can be monitored easily using several Sony's drivers
10:56:03pamauryalso a good thing is the rootfs is mounted read-only, so the user won't be able to modify, that's helpful
10:57:27 Quit xorly| (Ping timeout: 256 seconds)
11:28:12 Join xorly| [0] (
11:29:21 Join elensil [0] (~edhelas@2001:1c02:1903:d800:4819:1a9d:c823:5603)
11:30:12 Quit elensil (Client Quit)
11:38:14 Join elensil [0] (~edhelas@2001:1c02:1903:d800:4819:1a9d:c823:5603)
11:39:38 Quit xorly| (Ping timeout: 245 seconds)
11:48:54 Join xorly| [0] (
11:49:21 Join JanC_ [0] (~janc@lugwv/member/JanC)
11:50:36 Quit JanC (Killed ( (Nickname regained by services)))
11:50:37 Nick JanC_ is now known as JanC (~janc@lugwv/member/JanC)
11:52:26 Join lebellium [0] (
12:05:19 Quit Moarc (Ping timeout: 252 seconds)
12:07:35 Join Moarc [0] (
12:47:10 Join robertd1 [0] (~as@
12:49:24 Quit xorly| (Ping timeout: 260 seconds)
12:52:38***Saving seen data "./dancer.seen"
12:54:38 Quit toli (Ping timeout: 256 seconds)
12:59:49 Quit alucryd (Remote host closed the connection)
13:01:43 Join toli [0] (
13:07:06 Quit TorC (Ping timeout: 256 seconds)
13:10:35wodzpamaury: Did you notice DSP stuff in sony's sources?
13:11:41 Join xorly| [0] (
13:22:20 Join TorC [0] (~TorC@fsf/member/TorC)
13:27:39pamaurywodz: no, where is it? I am not that interested in the dsp stuff. Or by dsp you mean v2l4 ?
13:30:18wodzpamaury: linux-kernel/arch/arm/mach-emxx/inter_dsp.{c,h}
13:32:13 Quit paulk-collins (Remote host closed the connection)
13:33:32pamaurywodz: I am not sure what it does
13:33:47pamauryI haven't be able to find any doc on the DSP of the processor
13:34:27wodzpamaury: It looks like general interface to load something (code, data) to core with different arch. Header says Renesas btw
13:34:56pamaurythe dsp is dspk701
13:35:46wodzpamaury: icx_si470x_radio_tuner.h does not contain ioctl codes
13:36:20 Join pamaury_ [0] (~pamaury@rockbox/developer/pamaury)
13:37:05pamauryrenesas bought whatever copany produced the mp200 (can't remember it's name). The emxx is the successor of it, so most of the files are probably licenced to Renesas
13:37:28pamaury_ah yeah, the MP200 was created by NEC
13:38:49pamaury_I guess you'll have to reverse engineer the driver then
13:39:40pamaury_does the driver integrate with v4l2 or not?
13:40:42wodzWas stunned by dsp in the name. DSP integrated with core is a relict of past age :-)
13:41:49pamaury_this processor is really old, at least the design of it
13:41:59pamaury_actually I thought the emxx dropped the dsp
13:42:47pamaury_but I don't have the datasheet for the emxx so it was just a guess
13:50:41pamaury_wodz: this page does not mention a dsp, it says the emxx has a cortex A9 with neon and a "flexible A/V engine"
13:54:00 Join krabador [0] (~krabador@unaffiliated/krabador)
13:54:46wodzpamaury_: Maybe it is relict then
13:56:15 Quit pamaury_ (Ping timeout: 260 seconds)
14:04:45 Join johnb2 [0] (
14:05:52Bilgusjohnb2: how was it?
14:07:35 Join paulk-minnie [0] (~paulk@
14:21:37 Quit johnb2 (Ping timeout: 244 seconds)
14:27:00 Quit xorly| (Ping timeout: 248 seconds)
14:28:32 Join johnb2 [0] (
14:52:42***Saving seen data "./dancer.seen"
15:20:04 Join pamaury_ [0] (~pamaury@rockbox/developer/pamaury)
15:21:02lebelliumis there anything that can be done to prevent spam on the wiki?
15:39:25pamaury_I don't know, we (gevaerts?) recently made changes to reduce load on the wiki because of spammer that try to edit the wiki, but a lot of bot still defeat account creation :(
15:40:57gevaertsI have no special powers on the wiki
15:41:20 Quit wodz (Ping timeout: 258 seconds)
15:42:31pamaury_I agree though that it creates a lot of noise, it's impossible to see the recently changed pages
15:42:46pamaury_maybe we could create all new account manually?
15:43:04pamaury_since it needs manual activation to write anyway...
15:54:35lebelliumYes, I don't see the point of creating the account oneself if we need to be added to the users group by a staff member anyway
15:59:37 Quit pamaury_ (Ping timeout: 252 seconds)
16:02:40 Quit elensil (Quit: Leaving.)
16:02:53 Join elensil [0] (~edhelas@2001:1c02:1903:d800:4819:1a9d:c823:5603)
16:07:10 Join xorly| [0] (
16:14:43 Quit amayer (Remote host closed the connection)
16:18:24 Join amayer [0] (
16:28:23lebelliumpamaury: what do you want to do on A15? Is it risky? I found a guy owning one on a French forum I'm following. I may ask him if he's interested by some testing
16:42:36 Join Senji [0] (~Senji@
16:44:44 Quit Senji_ (Ping timeout: 244 seconds)
16:51:17 Join Senji_ [0] (~Senji@
16:52:43***Saving seen data "./dancer.seen"
16:53:18 Quit Senji (Ping timeout: 256 seconds)
16:56:08 Quit paulk-minnie (Ping timeout: 256 seconds)
17:15:27pamaurylebellium: initially just dump the rootfs and try to run the plattforms tools, I don't think there is any risk
17:15:37pamaury(the risk is when you start installing stuff)
17:23:54 Quit petur (Quit: Connection reset by beer)
17:24:29Bilguspamaury: with the selective backlight part of this out of the way, selective softlock was cake I have the core stuff working now just need to clean it up, test, and make menus
17:25:38 Join paulk-collins [0] (
17:28:23 Join JanC_ [0] (~janc@lugwv/member/JanC)
17:29:38 Quit JanC (Killed ( (Nickname regained by services)))
17:29:38 Nick JanC_ is now known as JanC (~janc@lugwv/member/JanC)
17:55:02 Quit johnb2 (Ping timeout: 245 seconds)
17:57:52 Join Senji [0] (~Senji@
18:00:46 Quit pamaury (Remote host closed the connection)
18:01:11 Quit Senji_ (Ping timeout: 256 seconds)
18:03:07 Quit elensil (Quit: Leaving.)
18:07:03 Quit einhirn (Quit: Miranda IM! Smaller, Faster, Easier.
18:13:53 Join girafe [0] (
18:24:41 Quit dfkt (Disconnected by services)
18:24:47 Join dfkt_ [0] (~dfkt@unaffiliated/dfkt)
18:52:47***Saving seen data "./dancer.seen"
18:57:04 Join TheLemonMan [0] (~root@unaffiliated/thelemonman)
19:01:04 Join rela [0] (~x@pdpc/supporter/active/rela)
19:09:48BilgusSelective Backlight and Selective Softlock Patches are up on Gerrit need some testers :) ;
19:11:08 Join johnb2 [0] (
19:12:00TheLemonManoh, that's an interesting feature
19:14:46Bilgusthank pamaury he set me on the path of the second one and pixelma for the selective context actions instead of buttons
19:14:55 Join johnb3 [0] (
19:15:06johnb2Bilgus: I just returned home from work.
19:15:46johnb2Should I compile with both patches (selBacklight and softlock) for testing or keep them separate?
19:16:11Bilgusthe fuzev2 has a hold button so selective softlock won't work for you but I think you will be pleased with selective backlighting
19:16:48Bilgusbut you can do w/e selective softlock just won't work
19:17:51johnb2I will start with clip+ anyway and then go for Fuze. So I will apply both patches ...
19:18:27Bilguscool I haven't tested selective softlock on my clip+ yet only the fuze+
19:19:53Bilgusyou'll have to do the 1417 then 1418 I believe since it builds from functions in it
19:20:25johnb2thanks, that's what I figured.
19:25:45johnb2Is it good enough to "make bin" only?
19:29:56Bilgusdoubt it since the lang file changed too
19:30:09johnb2ok, doing all
19:31:28Bilgushave to make fullzip but you can copy langs/ and rockbox.sansa only
19:32:43johnb2got it
19:38:25Bilgusbb in a few hours
19:59:31 Join cc___ [0] (~ac@2001:910:113f:1:6a05:caff:fe1c:1627)
20:17:55johnb2uploaded the builds here:
20:24:07johnb2Bilgus: Clip+: Well done!
20:26:35johnb2I had run also the version from last night (with the shutdown problem). This one had one addtl. problem: Seek was not selected in the menu, but still during seed the display would stay off and only turn on when seeking had been stopped.
20:28:12johnb2This is gone with this build and been reduced to the roughly 0.5s delay/lag that happens with any button that is supposed to turn on the display. I guess that due to a timeout you are using.
20:29:10johnb2I have not found any issue neither with selective backlight nor the softlock.
20:31:27johnb2bb in 1/2h
20:40:47 Join pamaury [0] (~pamaury@rockbox/developer/pamaury)
20:42:27 Join Bilgus_ph [0] (~Bilgus@
20:43:44TorCBilgus: Hmmm... mightn't it be possible to set the patch use the delay to get the code you need, and then if backlight not desired, cancel it, or if wanted, issue the order to turn it on immediately? I haven't gotten to try it yet (I have zip available to test with, and haven't worked through compiling yet), but IIRC, you introduced the delay to deal with the backlight not staying off because of a temporary keycode that got put through.
20:47:44 Quit johnb3 (Ping timeout: 260 seconds)
20:48:47 Quit Bilgus_ph (Remote host closed the connection)
20:50:29johnb2I personally pay the price of that delay in turning on the display, but surely if there are other ways to do it that would be great.
20:50:54johnb2I now moving on with the FuzeV2.
20:52:50***Saving seen data "./dancer.seen"
20:52:54johnb2^ am
21:16:08johnb2FuzeV2: the flickering of the display when using the scroll wheel that I had reported earlier is gone.
21:17:23johnb2Similar behaviour as with the Clip+, no problems so far. I will continue with some more testing tomorrow.
21:41:32 Quit alexweissman (Read error: Connection reset by peer)
21:42:05 Join alexweissman [0] (
21:44:40 Quit johnb2 (Ping timeout: 260 seconds)
21:45:20Bilgusjohnb2 & TorC the reason for the dealsy is the resolution of the backlight queue.. HZ or approx 1 second, I tried preempting that delay in the prior release but just ended up creating a race condition.. I thought about using a timer and callback to do it but I need to talk to someone who knows more about the available timers across all targets perhaps using a timer if available and falling back to the button queue if needed
21:54:05BilgusI found a function timeout_register() ill start playing with it..
22:04:00 Quit saratoga (Quit: Page closed)
22:09:30BilgusI think I can register a timeout with this but since there is no way to figure out if it was actually added or not I'll leave the other one as well to fall back on
22:21:04 Quit cc___ (Ping timeout: 260 seconds)
22:22:42 Part robertd1
22:39:53Bilguspamaury do you know anything about the timer subsystem?
22:40:51TorCBilgus: I'd be glad to test on Zip, but I haven't worked out compiling, and won't have time to delve into that for a while. Can test tonight my time. I'll check logs if I'm not around.
22:41:05pamauryBilgus: some, I know how it's implemented I think
22:42:15 Quit advcomp2019 (Ping timeout: 256 seconds)
22:43:37BilgusI'm wondering how constrained the timeout function is I see it has 8 possible slots and its used all over the code I'd hate to have a callback not occur on something important like the BL I can decrease the queue wait timeout when I enable wait on the backlight but I'm wondering what else that might impact
22:45:06pamauryI am not sure I follow the last thing you said, you want to decrease what?
22:46:11 Join advcomp2019 [0] (
22:46:11 Quit advcomp2019 (Changing host)
22:46:11 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
22:48:10Bilgusqueue_wait_w_tmo(&backlight_queue, &ev, BACKLIGHT_THREAD_TIMEOUT);
22:48:55Bilgusit is how the backlight code deques
22:48:59pamauryand why exactly do you want to change the timeout?
22:49:21pamauryI don't see the link between the timeout function and the timeout of the queue wait
22:49:31Bilguswell currently I have a timeout of 1second which is the max resolution
22:49:44BilgusI only need .5 or less
22:50:37Bilgusthere is a slightly noticable delay when selective backlight is enabled and when a keypress that does activate backlight is seen
22:50:40pamauryand why don't you want to use a timeout function if that's what you like? Using the timeout of the wait function doesn't seem like a robust solution
22:51:10pamauryor am I misunderstanding what/how you doing
22:51:46Bilguswell the wait function is very robust because if it is not canceled then the backlight turns on anyway
22:52:36pamauryI am sorry I'm not following, I think I'm missing some context here
22:52:52***Saving seen data "./dancer.seen"
22:53:37Bilgusok calls to backlight_on are scattered all over the code I added a function to allow a timeout to be added for backlight on
22:53:55Bilguswhen the timeout expires the backlight is turned on
22:54:42 Quit alexweissman (Remote host closed the connection)
22:54:55Bilgusin action.c if an action that doesn't want the backlight occurs then a call to Backlight_cancel_pending is made
22:55:15Bilgusthat sets the timeout to 0 effectively disabling the timer
22:55:26pamauryok, that sounds like a perfect instance for a actual timeout
22:56:16Bilgusyes but there are also up to 3 needed and no way to verify one was added
22:56:31Bilgusper (timeout.c)
22:57:29pamaurywhy 3 ??
22:57:59Bilgusbacklight, buttonlight, remote_backlight.. maybe not remote but for sure buttonlight
22:58:01pamauryyou mean in general or just for backlight?
22:58:21pamauryone is usually used by the sd/mmc code
22:58:54pamauryif you are afraid this is one too many timeouts, why not increase the number of timeouts?
22:59:51Bilgus^ good idea :)
23:09:13 Join alucryd [0] (~quassel@archlinux/developer/alucryd)
23:10:45 Quit TheLemonMan (Quit: "It's now safe to turn off your computer.")
23:11:42 Quit ZincAlloy (Remote host closed the connection)
23:12:13 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:69f0:c8dd:5cd0:e8e7)
23:25:01 Quit advcomp2019 (Ping timeout: 246 seconds)
23:25:48 Join advcomp2019 [0] (
23:25:48 Quit advcomp2019 (Changing host)
23:25:48 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
23:34:07TorCBilgus: Thanks. Downloaded. I'll install and run tests tonight.
23:56:36 Quit pamaury (Ping timeout: 256 seconds)

Previous day | Next day