| 00:03:00 | | Join [Saint] [0] (~sinner@rockbox/staff/saint) |
| 00:09:00 | | Quit robertd1 (Ping timeout: 264 seconds) |
| 00:09:19 | Bilgus | chrisjj per your suggestion I looked into making the menus on selective actions more inline with rockbox, Only possible thing I can do is make you have to go through a second menu to choose Yes/No I'm unsure if that is better or worse than a setting that toggles between on/off when you click it, at least that way you have a visual indication of what it is without having to go through another meni |
| 00:09:54 | chrisjj | Thing is though, the rest of Rockbox is highly inconsistent :) |
| 00:10:19 | chrisjj | Why a second menu? |
| 00:11:27 | Bilgus | already tried yes /no / settings but it kicks you out as soon as you select an item, there is no way to indicate which item is selected when you enter a menu that uses dynamic text |
| 00:11:36 | chrisjj | Ah, right. |
| 00:12:10 | Bilgus | i tried making it so the currently selected setting was at the top but it was too confusing |
| 00:12:38 | chrisjj | Yeah, it would be. |
| 00:12:42 | Bilgus | so using a second menu jives with rb and its a lot less code to boot |
| 00:13:02 | chrisjj | I think second menu is best. |
| 00:13:30 | chrisjj | At least that makes it celar what the current state is... if you look inside. |
| 00:14:30 | Bilgus | lol If you look inside is why I had the other method but tbh idc anymore a month of dev is enough for me |
| 00:15:15 | | Quit alexweissman (Remote host closed the connection) |
| 00:15:57 | | Join robertd1 [0] (~root@201.208.231.245) |
| 00:18:13 | chrisjj | You going to make that second menu a sub-menu of the first? |
| 00:22:12 | Bilgus | yep its inside the first just like system>keyclick |
| 00:23:16 | chrisjj | Great, but naming System>Keyclick>Keyclick is not great. |
| 00:24:12 | chrisjj | System>Keyclick>Enable is better IMHO |
| 00:26:49 | Bilgus | ah but then is it enabled or disabled nope following the same format |
| 00:27:39 | | Part robertd1 |
| 00:28:03 | Bilgus | it'll be Display>LCD Settings> No backlight on selected settings > no backlight on selected settings Yes/NO |
| 00:29:12 | Bilgus | if there was already a lang defined for enabled or something like that I might consider it but I've already added several KB to english.lang and don't see a point in adding more |
| 00:31:56 | *** | Saving seen data "./dancer.seen" |
| 00:33:01 | chrisjj | "ah but then is it enabled or disabled" Enabled>On or Enabled>Off. |
| 00:33:06 | chrisjj | "nope following the same format" OK! :-) |
| 00:35:43 | | Quit dfkt (Read error: Connection reset by peer) |
| 00:36:00 | | Join alexweissman [0] (~alexweiss@c-68-51-123-75.hsd1.in.comcast.net) |
| 00:37:00 | | Join dfkt [0] (~dfkt@unaffiliated/dfkt) |
| 00:42:52 | Bilgus | i'll wait and see if this ever gets committed and next maybe go through and add enabled to the lang file and fix the 5 or so places |
| 00:56:47 | chrisjj | Is there a way to set a track to be played when no other track is playing? |
| 01:00 |
| 01:11:59 | Bilgus | I don't think so |
| 01:13:09 | | Quit alexweissman (Remote host closed the connection) |
| 01:27:02 | chrisjj | OK, thanks. |
| 01:27:32 | chrisjj | Also, is the Shortcuts Plugin mentioned here https://www.rockbox.org/wiki/PluginShortcuts now gone? |
| 01:28:07 | chrisjj | It isn't listed in main menu>Plugins, and main menu>Shortcuts seems to make it redundant |
| 01:31:51 | | Join alexweissman [0] (~alexweiss@c-68-51-123-75.hsd1.in.comcast.net) |
| 01:33:23 | chrisjj | Hmm. Gone from \source\rockbox-3.13\apps\plugins\ too. |
| 01:36:37 | | Quit ZincAlloy (Quit: Leaving.) |
| 01:48:00 | | Quit Senji_ (Ping timeout: 264 seconds) |
| 02:00 |
| 02:04:38 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:c8cd:6bb2:744f:5951) |
| 02:07:31 | __builtin | chrisjj: re shortcuts: it's no longer a plugin |
| 02:07:39 | | Quit PurlingNayuki (Remote host closed the connection) |
| 02:08:13 | chrisjj | OK, I'll mark the wiki page. |
| 02:08:22 | __builtin | it's already marked I believe |
| 02:08:38 | __builtin | oh well, that was because of your edit, it seems |
| 02:08:57 | chrisjj | Oops, yes I already did it https://www.rockbox.org/wiki/PluginShortcuts. |
| 02:09:01 | | Quit skapazzo (Quit: Lost terminal) |
| 02:09:16 | chrisjj | I'll edit the list. |
| 02:09:58 | __builtin | as [Saint] said, "plugins are my jam" |
| 02:10:34 | chrisjj | Oh, I can't becasue it is machine-generated https://www.rockbox.org/wiki/PluginIndex . |
| 02:11:03 | chrisjj | So, I wonder how it can be wrong. Machines are infallible! :) |
| 02:11:16 | __builtin | I believe you can remove PluginIndex from being the parent of the article |
| 02:12:48 | chrisjj | I can remove CategoryPlugin. |
| 02:13:46 | __builtin | wait a second... |
| 02:14:00 | __builtin | a "shortcuts" plugin is still present in the current HEAD |
| 02:14:59 | chrisjj | I removed that, and the plugin is gone from the index. |
| 02:15:22 | __builtin | chrisjj: I mean that the code for the shortcuts plugin is still present in git |
| 02:15:46 | chrisjj | Oh? None seen in \rocks source. |
| 02:15:48 | __builtin | look under rockbox/apps/plugins/shortcuts |
| 02:16:04 | __builtin | it's a multi-file plugin |
| 02:16:42 | chrisjj | I see it. |
| 02:17:03 | chrisjj | But I think that's not the same plugin. |
| 02:17:12 | __builtin | it is, at least functionality-wise |
| 02:17:16 | chrisjj | I think that's two viewers. |
| 02:17:53 | chrisjj | Well, the wiki article does not accord with the Shortcuts functionality in 3.13. |
| 02:18:11 | __builtin | 3.13 is not applicable here, only git HEAD |
| 02:18:55 | chrisjj | OK, good point. |
| 02:19:14 | chrisjj | But the manual does accord with (3.13) functionality... |
| 02:19:31 | __builtin | if you're still running 3.13 you should definitely get a recent dev build |
| 02:20:02 | chrisjj | ... so surely the plugin of https://www.rockbox.org/wiki/PluginShortcuts is gone, replaced by the Shortcuts feature of https://download.rockbox.org/manual/rockbox-ipod3g/rockbox-buildch5.html#x7-970005.12 |
| 02:20:24 | __builtin | no, it's not gone, though I agree that it should be removed eventually |
| 02:20:51 | chrisjj | I checked 3.13 since that's the latest production release and so that's what the wiki and manuals should match... no? |
| 02:20:53 | __builtin | the code for the shortcuts/ directory has not been modifed since 2011 |
| 02:21:16 | chrisjj | Not gone? Can you find it on the UI? |
| 02:21:30 | __builtin | viewers are not visible to the user by default |
| 02:21:49 | chrisjj | understood, but https://www.rockbox.org/wiki/PluginShortcuts is not a viewer. |
| 02:22:49 | __builtin | in this case the wiki can be a bit confusing |
| 02:23:37 | chrisjj | In this case the wiki can be a bit confused! :-) |
| 02:23:42 | __builtin | from the source it appears that there is a single shortcuts/ subdirectory under plugins/, but the code in that directory is used to build two viewer plugins, shortcuts_append, and shortcuts_view |
| 02:24:04 | __builtin | so I guess the wiki page name is a bit inaccurate |
| 02:24:33 | chrisjj | it would be... if was referring to those two viewers. |
| 02:24:40 | chrisjj | I see nothing to suggest it is. |
| 02:25:16 | chrisjj | It appears to refer to an old now-removed plugin. |
| 02:25:17 | | Quit krnlyng (Ping timeout: 265 seconds) |
| 02:25:35 | __builtin | I assure you, it does not. |
| 02:25:40 | chrisjj | E.g. "This will create a file in the root directory of the DAP called "shortcuts.link"." Not true of the current feature. |
| 02:26:39 | __builtin | That functionality has been merged into the core shortcuts feature (i.e. Main > Shortcuts) |
| 02:28:51 | chrisjj | Partially. Certainly none of the https://www.rockbox.org/wiki/PluginShortcuts functionality still exist where that wiki article says it does. |
| 02:29:33 | __builtin | From what I can gather, this plugin relied on features in the core to function as it should |
| 02:29:44 | __builtin | (and as described on the wiki page) |
| 02:29:57 | chrisjj | Figures. Still the plugin is now gone, though. |
| 02:30:20 | __builtin | That functionality was removed from the core but the plugins (both of them) were not removed |
| 02:31:33 | chrisjj | Yet now there's no pluging meeting the description of https://www.rockbox.org/wiki/PluginShortcuts . |
| 02:31:42 | chrisjj | Grandfather's Axe, perhaps :-) |
| 02:31:58 | *** | Saving seen data "./dancer.seen" |
| 02:32:25 | __builtin | I can promise you that it still exists in HEAD |
| 02:32:44 | __builtin | (well, the two plugins that it consisted of) |
| 02:33:27 | chrisjj | No doubt some shortcuts plugin code still exists in HEAD. |
| 02:33:36 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:c8cd:6bb2:744f:5951) |
| 02:33:50 | chrisjj | But the wiki is not documenting the source. It is documenting the UI. |
| 02:34:14 | __builtin | The wiki is definitely out of date, and honestly I don't see why the plugin isn't removed completely |
| 02:34:56 | chrisjj | Should I revert my edit and leave the mess for others to sort out? |
| 02:35:24 | chrisjj | Or shall we get the edits correct for 3.13? |
| 02:35:45 | __builtin | I could in fact remove the plugin right now. |
| 02:36:22 | chrisjj | Now tell me, specifically what "plugin" do you mean? |
| 02:36:44 | __builtin | Sorry, the plugins (shortcuts_viewer.rock and shortcuts_append.rock) |
| 02:38:10 | | Join krnlyng [0] (~liar@77.117.78.23.wireless.dyn.drei.com) |
| 02:38:49 | chrisjj | Sure that wont break the 3.13 shortcuts feature? |
| 02:39:02 | __builtin | again, 3.13 is irrelevant |
| 02:40:22 | chrisjj | How so? People are using 3.13 shortcut feature and won't they expect them to survive to 3.14? |
| 02:40:33 | chrisjj | s/them/it/ |
| 02:41:16 | | Quit PurlingNayuki (Ping timeout: 245 seconds) |
| 02:41:38 | __builtin | The functionality provided by the original two plugins has been completely replaced by the shortcuts feature in the core |
| 02:42:34 | chrisjj | OK... so... |
| 02:42:55 | chrisjj | thinking... |
| 02:43:13 | __builtin | anyone still using the old plugin's features on 3.13 will have to migrate, yes |
| 02:43:31 | chrisjj | Ah, righty oh :( |
| 02:43:50 | chrisjj | That's what I feared. |
| 02:45:12 | chrisjj | So "I could in fact remove the plugin[s] right now." means breakage. |
| 02:45:36 | __builtin | The original functionality has already been severely limited by the removal of core integration |
| 02:46:21 | chrisjj | Sort of surprised it builds! :-) |
| 02:46:41 | __builtin | sorry? |
| 02:47:48 | chrisjj | I'm wondering how the plug-in even builds if it can't find the core features at compile/link time. |
| 02:48:45 | __builtin | The plugins didn't rely on the core to build, but they were meant to be called from core from what I can gather |
| 02:49:08 | __builtin | much like the credits plugin is called from the System menu |
| 02:49:15 | __builtin | *how |
| 02:49:46 | chrisjj | And are we sure they are not still being called? |
| 02:51:50 | __builtin | let me check |
| 02:51:53 | __builtin | fs-bluebot: FS #12251 |
| 02:51:53 | fs-bluebot | http://www.rockbox.org/tracker/task/12251 user shortcuts in the main menu (patches, closed) |
| 02:52:47 | chrisjj | "I forgot about the existing shortcut functionality when i started this," :) |
| 02:54:24 | __builtin | hmm, a commenter does make a good point that the original plugin made it possible to have what are essentially symlinks |
| 02:54:29 | __builtin | in the form of .link files |
| 02:55:57 | __builtin | So the original plugin ought to remain |
| 02:56:01 | chrisjj | Yeah. And the new author's "they are surpassed with this and should be removed if this goes ahead." is wrong. |
| 02:56:32 | chrisjj | That leaves us with a muddle. |
| 02:57:08 | __builtin | For now, you should probably restore the wiki page and leave things as-is |
| 02:57:17 | chrisjj | Probably is wasn't a great idea for the new Shortcuts feature to be allowed in without reconciliation with the existing. |
| 02:57:18 | __builtin | (if you haven't already) |
| 02:58:16 | chrisjj | Before I restore, can you just tell me where https://www.rockbox.org/wiki/PluginShortcuts can actually be found in the 3.13 UI? |
| 02:58:50 | __builtin | If you create a /shortcuts.link file and put a file name into it, and then open it up from the file viewer it will run the plugin |
| 02:59:23 | chrisjj | And that's the entire UI impact? |
| 03:00 |
| 03:00:49 | __builtin | also if you create a .link file anywhere and put a filename in it and run it, the file browser will automatically point to that filename |
| 03:01:59 | __builtin | I believe it is this feature that makes the old plugin worth keeping around |
| 03:03:05 | chrisjj | Me too. Coudl eb essential to anyone who is using it. |
| 03:05:45 | chrisjj | https://www.rockbox.org/wiki/PluginShortcuts restored. Thanks for catching me :-) |
| 03:06:39 | chrisjj | Now can we fix this article so it is at least less wrong? |
| 03:06:51 | __builtin | Feel free |
| 03:08:45 | chrisjj | With your help, I meant :-) |
| 03:10:54 | chrisjj | e.g. "use the context menu on either a file or directory in the file browser tree, and use the "Add to shortcuts" menu option. This will create a file in the root directory of the DAP called "shortcuts.link"." |
| 03:11:05 | chrisjj | ... seems plain wrong. |
| 03:11:09 | __builtin | well, the entry is mostly correct, just remove the sentence about that |
| 03:11:42 | chrisjj | AtS does not create that file. Maybe FS #12251 stomped on that. |
| 03:11:43 | fs-bluebot | http://www.rockbox.org/tracker/task/12251 user shortcuts in the main menu (patches, closed) |
| 03:12:35 | chrisjj | That will vape all the non-Advanced usage. |
| 03:13:00 | __builtin | well, the feature is still there, just the core integration is gone |
| 03:13:15 | __builtin | so if you want to, you can mark it as deprecated but kept for compatibility |
| 03:13:41 | chrisjj | I think the AtS feature of /this/ plugin is not still there. |
| 03:14:12 | __builtin | what is this "AtS?" |
| 03:14:50 | chrisjj | "Add to shortcuts" |
| 03:14:54 | chrisjj | (menu option) |
| 03:15:17 | __builtin | yeah, but the code to read it that was in the plugin was not removed |
| 03:15:33 | __builtin | so if you still have a shortcuts.link file it still works because of the plugin |
| 03:18:03 | chrisjj | Sure, but I'm talking about Shortcuts Plugin AtS. And that's gone from the UI. Agreed? |
| 03:19:21 | __builtin | Yes, remove the portion on "Add to shortcuts" because it has been replaced by the core feature |
| 03:19:53 | __builtin | but everything else is still valid, including the part on reading the shortcuts file |
| 03:21:37 | chrisjj | Ok, so how's this? http://i.imgur.com/omc0BPu.png |
| 03:23:09 | __builtin | The part about reading the shortcuts.link file shouldn't be removed |
| 03:23:27 | __builtin | just remove the part on how to add shortcuts, as that is broken now |
| 03:24:09 | chrisjj | That part being the sentence " Launching this file from the file browser..." ? |
| 03:24:23 | | Join Bilgus_ph [0] (4cf32773@gateway/web/freenode/ip.76.243.39.115) |
| 03:24:40 | Bilgus_ph | chrisjj: Might I suggest a sample file for the user as well |
| 03:25:00 | Bilgus_ph | and a note that it is depreciated |
| 03:25:00 | chrisjj | Sounds good... later :-) |
| 03:25:30 | | Join smoke_fumus [0] (~smoke_fum@dynamic-vpdn-93-125-65-113.telecom.by) |
| 03:28:44 | Bilgus_ph | Why don't I see the main menu reorder plugin in that list? |
| 03:30:17 | __builtin | Bilgus_ph: not every plugin has a wiki entry, though they should |
| 03:30:44 | Bilgus_ph | not that it is hard to figure out |
| 03:31:31 | __builtin | that too ;) |
| 03:32:44 | chrisjj | __builtin: How about this? http://i.imgur.com/h6wqbjr.png |
| 03:33:25 | __builtin | looks good to me |
| 03:33:42 | Bilgus_ph | chrisjj I went ahead and made the menu say enabled although it is kinda odd having enabled at the top when you go to set it so idk not too very happy with the rb menu options |
| 03:34:09 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:c8cd:6bb2:744f:5951) |
| 03:34:56 | chrisjj | __builtin: Thanks - saved. |
| 03:35:06 | Bilgus_ph | that wiki entry is still confusing af |
| 03:35:22 | chrisjj | Which wiki entry? |
| 03:36:30 | Bilgus_ph | Directory entries without a trailing slash will cause the plugin to exit in the file browser with the directory selected. If the trailing slash is included, then the file browser will be left in the directory on the first file. |
| 03:36:44 | Bilgus_ph | ^there |
| 03:37:18 | | Join JanC_ [0] (~janc@lugwv/member/JanC) |
| 03:37:21 | chrisjj | Yeah. Not clear. The manual is better https://download.rockbox.org/manual/rockbox-ipod3g/rockbox-buildch11.html#x13-15800011 |
| 03:38:31 | | Quit JanC (Killed (leguin.freenode.net (Nickname regained by services))) |
| 03:38:31 | | Nick JanC_ is now known as JanC (~janc@lugwv/member/JanC) |
| 03:39:28 | Bilgus_ph | yes. |
| 03:51:17 | chrisjj | I can't see why we have wiki & manual, but last time I questioned this I got my head bitten off. :-) |
| 03:51:48 | __builtin | wiki allows for more technical discussion that wouldn't be appropriate in the manual |
| 03:52:03 | __builtin | the manual is for end-users mainly |
| 03:52:29 | | Quit cc___ (Ping timeout: 258 seconds) |
| 03:52:57 | chrisjj | Example of extra depth in wiki? |
| 03:53:32 | Bilgus_ph | lol |
| 03:53:48 | __builtin | well, read the ones on using git and writing plugins |
| 03:54:14 | __builtin | they go into a lot more of the technical aspects which don't really belong in the manual |
| 03:54:17 | chrisjj | Oh, different topics. Yeah, sure. |
| 03:54:40 | chrisjj | But unfortunately the wiki and manual compete on the same topics... and are inconsistent. |
| 03:54:50 | Bilgus_ph | or the two three on wps themes that conflict with each other ;P |
| 03:55:12 | __builtin | they are really not the best sources for accurate information... the source code is much better |
| 03:55:20 | chrisjj | And goodness, what a farce that WPS thing was. |
| 03:55:23 | Bilgus_ph | two or three? |
| 03:56:32 | chrisjj | __builtin: Real Programmers don read the source code. They read the binary :-) |
| 03:57:23 | chrisjj | Seriously, I'm talking of user documentation. |
| 03:57:47 | Bilgus_ph | hey it eventually worked, no real programmers write accurate comments so they don't have to read the source 6x to remember what it does |
| 03:58:17 | __builtin | honestly, rockbox isn't written for the end user's convenience |
| 03:58:22 | Bilgus_ph | ^ |
| 03:58:45 | __builtin | it's made by devs, for devs |
| 03:58:50 | Bilgus_ph | if it were it'd be not free |
| 04:00 |
| 04:00:07 | Bilgus_ph | devs just change it to their liking and sometimes users get lucky that we make it work for all |
| 04:00:27 | chrisjj | "rockbox isn't written for the end user's convenience" Indeed... making user docs all the more important. |
| 04:00:58 | Bilgus_ph | true but funny thing is that programmers hate writing manuals |
| 04:01:07 | chrisjj | "it's made by devs, for devs" Got to wonder how the manual and wiki came to exist, then! :-) |
| 04:01:34 | chrisjj | "that programmers hate writing manuals" No problem. Manuals hate programmers writing them :-) |
| 04:01:39 | Bilgus_ph | as a way to stop having to answer users |
| 04:02:09 | __builtin | the wiki is really a place to put more extensive development-related documentation than can be put into source comments |
| 04:03:26 | chrisjj | That would be less of a problem if a large warning alerted users to the fact. |
| 04:04:01 | chrisjj | 'Cos otherwise they might read the wiki into and mistake the wiki for user docs! |
| 04:04:49 | chrisjj | Today's example being a good one. https://www.rockbox.org/wiki/PluginIndex |
| 04:04:54 | __builtin | the wiki is "good enough" if the reader takes it with a grain of salt |
| 04:05:44 | chrisjj | IMHO this example of user documentation could be improved by being entirely deleted. Leaving users to the manual. |
| 04:06:12 | Bilgus_ph | idk i used rockbox for several years without ever reading the manual |
| 04:06:24 | chrisjj | Good move :-) |
| 04:06:30 | __builtin | it's also mostly self-explanatory, IMO |
| 04:06:41 | __builtin | given some time to poke around |
| 04:10:16 | chrisjj | "it's also mostly self-explanatory, IMO" Docs are for the bits that aren't. |
| 04:10:54 | chrisjj | The Shortcuts Plugin .link fileformat being a good example. |
| 04:11:41 | __builtin | yes, and the wiki is mostly complete in that regard, it just takes a bit of poking around the source tree to figure out the rest |
| 04:11:54 | chrisjj | Bilgus_ph, re the On/Off, perhaps start a discussion on what solution could be used uniformly on the UI. |
| 04:12:25 | chrisjj | Leaving aside why some existing ar eOn/Off and others Yes/No... to a non-question. :-) |
| 04:13:11 | chrisjj | The Enabled point is a known UI issue, likened to lambda functions. |
| 04:13:24 | chrisjj | (UI design issue) |
| 04:13:50 | chrisjj | "the wiki is mostly complete in that regard" It's the other bits I'm talking about. |
| 04:14:46 | chrisjj | "it just takes a bit of poking around the source tree to figure out the rest" Can't be working too well, else the results would be in the manual, no? :-) |
| 04:16:11 | __builtin | usually code comes first, and documentation is sometimes an afterthought |
| 04:16:23 | Bilgus_ph | Sounds like you have a hankering for some manual writing :p |
| 04:18:26 | chrisjj | __builtin: Agreed, hence every messup I see, from WPS to Shortcuts. |
| 04:18:57 | Bilgus_ph | stuff changes part of progress I suppose |
| 04:19:41 | chrisjj | Bilgus_ph: First wiki article deleting and linking to manual! Problem is, there's no superset manual. |
| 04:20:15 | | Part Bilgus_ph |
| 04:23:46 | chrisjj | Time for bed. Bye for now. |
| 04:26:28 | __builtin | o/ |
| 04:32:01 | *** | Saving seen data "./dancer.seen" |
| 05:00 |
| 05:01:56 | | Quit fIorz (Ping timeout: 240 seconds) |
| 05:08:57 | | Join fIorz [0] (nobody@rain.florz.de) |
| 05:48:41 | | Join CrashBash-Kun [0] (~CrashBash@unaffiliated/crashbash-kun) |
| 05:56:28 | | Quit user890104 (Ping timeout: 268 seconds) |
| 05:58:05 | | Join user890104 [0] (Venci@unaffiliated/user890104) |
| 06:00 |
| 06:04:06 | | Quit CrashBash-Kun (Quit: Leaving) |
| 06:12:56 | | Quit TheSeven (Ping timeout: 240 seconds) |
| 06:13:24 | | Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) |
| 06:32:04 | *** | Saving seen data "./dancer.seen" |
| 06:53:28 | | Join johnb3 [0] (~johnb3@pD9564F4C.dip0.t-ipconnect.de) |
| 07:00 |
| 07:02:45 | | Quit johnb3 (Ping timeout: 265 seconds) |
| 07:04:46 | | Join user890104_ [0] (Venci@unaffiliated/user890104) |
| 07:05:19 | | Quit user890104 (Quit: .) |
| 07:05:19 | | Nick user890104_ is now known as user890104 (Venci@unaffiliated/user890104) |
| 07:34:07 | | Join Bray90820_ [0] (~bray90820@173-25-204-30.client.mchsi.com) |
| 07:34:27 | | Quit Bray90820 (Ping timeout: 258 seconds) |
| 08:00 |
| 08:11:40 | | Join ender` [0] (krneki@foo.eternallybored.org) |
| 08:32:06 | *** | Saving seen data "./dancer.seen" |
| 09:00 |
| 09:21:44 | | Quit nlogex (Ping timeout: 250 seconds) |
| 09:26:14 | | Quit idonob_ (Ping timeout: 250 seconds) |
| 09:32:53 | | Join robertd1 [0] (~root@201.208.231.245) |
| 09:43:54 | | Join idonob_ [0] (~Owner@S010610c37b922980.vs.shawcable.net) |
| 09:46:41 | | Join uwe_android [0] (~uwe_andro@static.173.76.9.176.clients.your-server.de) |
| 09:52:25 | | Quit sparetire (Ping timeout: 252 seconds) |
| 09:55:22 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 09:57:25 | | Join sparetire [0] (~sparetire@unaffiliated/sparetire) |
| 10:00 |
| 10:03:54 | | Join elensil [0] (~edhelas@2001:1c02:1903:d800:dce7:54db:f373:3079) |
| 10:08:44 | | Part robertd1 |
| 10:26:09 | | Quit pamaury (Ping timeout: 252 seconds) |
| 10:32:10 | *** | Saving seen data "./dancer.seen" |
| 10:43:37 | | Join skapazzo [0] (~skapazzo@151.9.205.1) |
| 10:55:49 | | Join Senji_ [0] (~Senji@85.187.103.250) |
| 10:56:04 | | Quit Senji_ (Read error: Connection reset by peer) |
| 10:56:32 | | Join Senji_ [0] (~Senji@85.187.103.250) |
| 11:00 |
| 11:19:20 | | Join robertd1 [0] (~root@201.208.231.245) |
| 11:20:43 | | Join pamaury [0] (~quassel@rockbox/developer/pamaury) |
| 11:25:49 | | Join pamaury_ [0] (~pamaury@rockbox/developer/pamaury) |
| 11:56:22 | | Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:e9db:e3e:4d05:a6bc) |
| 12:00 |
| 12:03:38 | | Quit ZincAlloy (Ping timeout: 246 seconds) |
| 12:05:02 | | Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:9874:8d4b:855e:40fc) |
| 12:08:12 | pamaury_ | gevaerts: is there a wiki page explanation how to install rockbox (not the bootloader) in general ? |
| 12:09:01 | gevaerts | Not that I know of |
| 12:09:15 | gevaerts | The manual has a bit about that of course |
| 12:13:01 | pixelma | maybe on the port pages (so per port)? |
| 12:15:42 | pamaury_ | I am currently rewriting the install instruction for the imx ports. I want to merge all install pages into one, since the instruction are the same and it's annoying to maintain all of them |
| 12:32:11 | *** | Saving seen data "./dancer.seen" |
| 13:00 |
| 13:06:11 | | Join petur [0] (~petur@rockbox/developer/petur) |
| 13:24:57 | chrisjj | "merge all install pages into one" Sounds good. |
| 13:26:00 | pamaury | I'll do the same for the ZEN ports (ZEN, XFi, Mozaic) |
| 13:34:08 | chrisjj | Anyone else finding the Major Changes RRS feed bust ? rasher.dk/rockbox/majorchanges.php">http://rasher.dk/rockbox/majorchanges.php |
| 13:42:36 | pamaury_ | yeah, although I didn't even know it existed |
| 13:43:54 | chrisjj | OK, thanks. Reported. Is rasher still active on the project? |
| 13:44:14 | pamaury_ | rasher: apparently your rasher.dk/rockbox/majorchanges.php">http://rasher.dk/rockbox/majorchanges.php page is broken |
| 13:44:30 | pamaury_ | not really |
| 13:48:49 | chrisjj | pamaury: Your https://www.rockbox.org/wiki/CreativeZENXFi3 is a mystery to me. I have never heard of a Creative Zen Style X-Fi3. |
| 13:49:08 | pamaury_ | probably a typo |
| 13:49:35 | pamaury_ | fixed |
| 13:54:27 | chrisjj | Thanks. |
| 13:54:30 | chrisjj | Orthography refined. Creative ZEN X-Fi3 :) |
| 14:00 |
| 14:05:17 | chrisjj | pamaury: Thanks again for the great work on the ZEN BSoD. |
| 14:32:13 | *** | No seen item changed, no save performed. |
| 14:33:14 | chrisjj | Almost all units tested are usable, and some are 100% BSoD-free so far. http://forums.rockbox.org/index.php/topic,13462.msg238564.html#msg238564 |
| 14:45:25 | chrisjj | And that crash on USB "Error accessing playlist control file" seems easily avoidable http://forums.rockbox.org/index.php/topic,13462.msg238565.html#msg238565 |
| 14:49:21 | | Quit smoke_fumus (Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/) |
| 15:00 |
| 15:49:57 | chrisjj | Replacement Major Changes RSS: http://feed43.com/rockboxmajorchangeswiki.xml |
| 15:51:15 | pamaury | chrisjj: is that supposed to be a feed for commits ? |
| 15:51:47 | pamaury | chrisjj: if so, why not used https://git.rockbox.org/?p=rockbox.git;a=rss ? |
| 15:52:03 | chrisjj | It's a feed for the Major Changes list here: https://www.rockbox.org/wiki/MajorChanges |
| 15:55:03 | | Quit Moarc (Ping timeout: 252 seconds) |
| 15:57:14 | | Join Moarc [0] (~chujko@a105.net128.okay.pl) |
| 16:00 |
| 16:04:40 | | Quit robertd1 (Ping timeout: 258 seconds) |
| 16:05:27 | | Join robertd1 [0] (~root@201.208.231.245) |
| 16:05:28 | chrisjj | Hmm... not much accordance seen. Compare GIT http://i.imgur.com/4iiEygs.png with wiki http://i.imgur.com/rrZqwd5.png |
| 16:07:58 | | Quit atsampson (Ping timeout: 245 seconds) |
| 16:08:48 | | Quit Kohlrabi (Ping timeout: 245 seconds) |
| 16:09:21 | | Join atsampson [0] (~ats@cartman.offog.org) |
| 16:10:00 | | Join Kohlrabi [0] (~kohlrabi@kohlio.de) |
| 16:13:09 | pamaury | chrisjj: my page is for commits,not major changes |
| 16:13:28 | pamaury | major changes are randonly updated when we remember this page exists ;) |
| 16:13:57 | pamaury | chrisjj: oh by the way, do you think the ZEN can be considered stable with the BSoD fix ? |
| 16:15:38 | | Quit petur (Remote host closed the connection) |
| 16:24:04 | | Join Senji [0] (~Senji@85.187.103.250) |
| 16:25:52 | | Quit Senji_ (Ping timeout: 260 seconds) |
| 16:32:14 | *** | Saving seen data "./dancer.seen" |
| 16:33:03 | | Quit elensil (Quit: Leaving.) |
| 16:33:58 | chrisjj | pamaury: "my page is for commits,not major changes" Indeed. That's the good reason for anyone who wants just Major Changes to use the wiki page/feed, I think/ |
| 16:34:26 | chrisjj | "major changes are randonly updated when we remember this page exists" Got it :) |
| 16:34:47 | pamaury | ok, I wasn't aware that anyone following the major changes that closely ;) |
| 16:34:53 | pamaury | *was following |
| 16:35:12 | chrisjj | "randonly updated when we remember this page exists" I think you could say likewise for just about every wiki page, no ? |
| 16:35:33 | chrisjj | "I wasn't aware that anyone following the major changes that closely" And I think you could say likewise for just about every wiki page, no ? :-) |
| 16:37:29 | chrisjj | pamaury: re ZEN status, by RB meaning of stable here: https://www.rockbox.org/ ... ZEN isn't yet stable. |
| 16:43:50 | pamaury | we don't follow those constraints closely, forget about the manual and rbutil. |
| 16:44:30 | pamaury | writing the manual is easy (but super boring). Add rockbox utility support for the ZEN is a very nontrivial task |
| 16:45:41 | chrisjj | OK, so tell me what you mean by RB stable and I'll tell you if I think ZEN is stable :-) |
| 16:45:58 | chrisjj | PS "forget about the manual and rbutil" That would be a real shame. |
| 16:46:10 | pamaury | basically does it run well? |
| 16:50:27 | pixelma | well, IIRC the Ipod 6G was never promoted to stable because there's mo means to install the bootloader with rbutil. Once you have it installed with the help of some other project for the bootloader part Rockbox is said to run well |
| 16:50:37 | pixelma | s/mo/no |
| 16:51:33 | pamaury | I could add support for the ZEN to RbUtil but that means teaching RbUtil to do MTP, which means 1) Windows specific code on Windows, 2) an extra libmtp dependency on linux 3) what the hell exists on macos |
| 16:51:36 | pixelma | that might match the "mo" in promoted... sorry for offtopic here |
| 16:56:00 | | Quit amayer (Quit: Leaving) |
| 16:58:13 | chrisjj | TMK it runs as well as some other ports that https://www.rockbox.org/ classes as 'runs well' despite being a way short of all green e.g. https://www.rockbox.org/wiki/CreativeZENXFiPort |
| 17:00 |
| 17:00:27 | | Join amayer [0] (~amayer@mail.weberadvertising.com) |
| 17:00:27 | chrisjj | pixelma: "Ipod 6G .. Once you have it installed with the help of some other project for the bootloader part Rockbox is said to run well" Perhaps update https://www.rockbox.org/ which says it is Unusable? |
| 17:00:36 | | Quit PurlingNayuki (Ping timeout: 240 seconds) |
| 17:02:47 | chrisjj | pamaury: " means teaching RbUtil to do MTP" I'd vote No. Lots of effort better spent elsewhere. |
| 17:04:08 | pamaury | I'll have a look into it. Basically the question is whether we can easily integrate the code of sendfirm in RbUtil. On Linux this is easy but on Windows I don't know, currently it relies on some ugly DLL |
| 17:11:26 | pixelma | my point was rather that in my opinion pamaury's view on this is wrong. If everyone makes up his/her own definitions, I wonder why we have them in first place. Maybe we can discuss these categories but we should try to be precise when we use them so that users can find what they are looking for |
| 17:13:21 | | Join Link8 [0] (~me@145.133.168.70) |
| 17:15:10 | chrisjj | pamaury: Just to say I have found Windows MTP to be a horror of unreliability on ZEN in every app from MediaMonkey (OK, not a great example of solid s/w) ... |
| 17:16:16 | pamaury | mtp is unreliable everywhere it seems, it's too complicated and poorly implemented on devices |
| 17:16:21 | chrisjj | ... to Beyond Compare (a great example of solid software). Regardless of whether the fault lies with MS or Creative, taking RB there may just be inviting extreme pain. |
| 17:16:41 | chrisjj | A major attraction of RM on ZEN to me is escaping MTP! |
| 17:16:45 | pamaury | well sendfirm worked for you on Windows right ? |
| 17:17:00 | chrisjj | s/RM on ZEN/RB on ZEN/ |
| 17:21:23 | chrisjj | sendfirm worked on Windows 7 for me. On XP and Vista it was trouble. |
| 17:22:08 | chrisjj | Would RUtil use MTP just for sendfirm? Or for RB player too? |
| 17:22:40 | pamaury | just to install the firmware, it cannot be avoided |
| 17:23:34 | | Join nlogex [0] (~filip@CPE30469a4d21ac-CMa84e3f5c8560.cpe.net.fido.ca) |
| 17:25:00 | chrisjj | OK, then perhaps because the amount of data is small, the chance of fail is small. I'm presuming fail could not brick the device. I.e. fail could be recovered by re-running the OF installer. |
| 17:27:34 | chrisjj | pixelma: "If everyone makes up his/her own definitions, I wonder why we have them in first place." Point taken ... except that it seems to me we don't have them in the first place, so Devs are inevitably suffering Tower of Babel. |
| 17:28:00 | chrisjj | "Maybe we can discuss these categories but we should try to be precise when we use them so that users can find what they are looking for" Agreed 100% |
| 17:29:06 | chrisjj | Perhaps first though should be compliance with one definition we do have: "Rockbox runs well on these players, has a complete manual and is supported by the installer:" |
| 17:30:40 | chrisjj | AFAICT, quite a few of those port don't have manuals. https://www.rockbox.org/tracker/task/13091?project=1&opened=5890 |
| 17:31:44 | chrisjj | How about moving them to the "is incomplete" class? (Ignoring that class's inaccurate label "Unstable ports") |
| 17:56:16 | | Quit Link8 (Ping timeout: 240 seconds) |
| 18:00 |
| 18:19:30 | | Part robertd1 |
| 18:32:17 | *** | Saving seen data "./dancer.seen" |
| 18:36:07 | | Join deadrula [0] (~quinlan@infoforcefeed/jnerula) |
| 18:42:04 | | Join cc___ [0] (~ac@2001:910:113f:1:6a05:caff:fe1c:1627) |
| 18:45:27 | cc___ | hi |
| 18:45:44 | cc___ | Sometimes I've got crashes on my sansa fuzev2 when playing music |
| 18:46:43 | cc___ | it shows either a white screen with an arror or a screwed up gui, and I have to hard reboot (hold on/off for 10 seconds) |
| 18:47:17 | cc___ | there I have a white screen, I'm going to post the error while I'm at it |
| 18:47:37 | cc___ | Data abort at 30007C04 |
| 18:47:43 | cc___ | FSR 0x8 |
| 18:47:54 | cc___ | (domain 0, fault 8) |
| 18:48:10 | cc___ | address 0xCA1A2A23 |
| 18:48:33 | cc___ | I think it's a similar message each time, only the numbers/addresses change |
| 18:48:49 | cc___ | and I'm using a nightly build |
| 18:48:54 | cc___ | let me check |
| 18:49:32 | cc___ | d492f25-161101 |
| 18:50:02 | cc___ | I think it happens more often when the battery is low |
| 18:50:10 | cc___ | but I's maybe just an impression |
| 18:50:29 | cc___ | and I'm listening audio from the mSD |
| 18:50:38 | cc___ | I didn't try with the internal flash |
| 18:50:55 | cc___ | it's hard to reproduce |
| 18:55:38 | duo8 | how do i pull a specific change from gerrit again? |
| 19:00 |
| 19:07:34 | pamaury | duo8: there is a download menu on the top right with the commands |
| 19:22:57 | | Join gty [0] (~ygj@2607:f358:1f:136:136:3055:8a73:ecbd) |
| 19:25:05 | | Quit gty () |
| 19:26:13 | | Join PurlingNayuki [0] (~Thunderbi@114.255.40.10) |
| 19:26:59 | | Quit cc___ (Quit: WeeChat 1.6) |
| 19:30:33 | | Quit PurlingNayuki (Ping timeout: 250 seconds) |
| 19:36:16 | | Join PurlingNayuki [0] (~Thunderbi@114.255.40.10) |
| 19:38:58 | | Quit PurlingNayuki (Remote host closed the connection) |
| 19:39:13 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 19:39:50 | | Join cc___ [0] (~ac@2001:910:113f:1:6a05:caff:fe1c:1627) |
| 19:44:12 | | Quit PurlingNayuki (Ping timeout: 245 seconds) |
| 19:46:57 | fs-bluebot | Build Server message: New build round started. Revision 78cb7f0, 255 builds, 16 clients. |
| 19:47:34 | bluebrother | pamaury: I just pushed a change to libtools.make |
| 19:48:05 | bluebrother | you should now be able to simply add a c++ file (with cpp file extension) to SOURCE / LIBSOURCES and it will handle that |
| 19:48:36 | bluebrother | haven't tried it on Windows / OS X yet, but I don't expect issues there. If so I have to fix them up later :) |
| 19:50:06 | bluebrother | this libucl handling is another thing that could be improved, but enough make for today. |
| 19:50:44 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 19:52:15 | pamaury | bluebrother: great, thanks |
| 19:53:59 | | Join lebellium [0] (~chatzilla@89-93-179-5.hfc.dyn.abo.bbox.fr) |
| 19:54:25 | | Quit pamaury (Remote host closed the connection) |
| 19:56:35 | fs-bluebot | Build Server message: Build round completed after 579 seconds. |
| 19:56:36 | fs-bluebot | Build Server message: Revision 78cb7f0 result: 0 errors 1 warnings |
| 19:58:30 | | Quit PurlingNayuki (Remote host closed the connection) |
| 19:58:42 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 19:59:08 | | Quit pamaury_ (Ping timeout: 260 seconds) |
| 20:00 |
| 20:01:15 | | Quit PurlingNayuki (Remote host closed the connection) |
| 20:10:12 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 20:13:57 | | Quit PurlingNayuki (Remote host closed the connection) |
| 20:14:08 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 20:17:29 | | Quit PurlingNayuki (Remote host closed the connection) |
| 20:19:48 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 20:25:55 | | Quit PurlingNayuki (Ping timeout: 240 seconds) |
| 20:31:23 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 20:32:19 | *** | Saving seen data "./dancer.seen" |
| 20:36:00 | | Quit PurlingNayuki (Ping timeout: 260 seconds) |
| 20:44:19 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 20:50:19 | | Join PurlingNayuki [0] (~Thunderbi@2001:da8:215:4ff:d964:185e:d80f:a78d) |
| 20:54:40 | | Quit PurlingNayuki (Ping timeout: 260 seconds) |
| 21:00 |
| 21:07:18 | pamaury | bluebrother: there is a typo in libtools.make |
| 21:07:23 | pamaury | you used CFLAGS for CXX |
| 21:07:52 | bluebrother | oh, right. |
| 21:08:00 | bluebrother | I forgot to separate them. |
| 21:08:03 | pamaury | I'm not sure how to fix it because CFLAGS seems nontrivial on some platforms |
| 21:08:52 | pamaury | bluebrother: how do I specify libraries to link against? Can I set LDFLAGS? |
| 21:09:11 | bluebrother | the simple solution is to rename it −− currently we use the same compiler options for c and c++ |
| 21:09:30 | pamaury | I'm not sure how it works for libraries given that it can be built both as standalone and in rbutil |
| 21:09:48 | bluebrother | use EXTRADEPS |
| 21:10:39 | bluebrother | rbutilqt/Makefile.libs doesn't pass CFLAGS, so no problem here |
| 21:11:12 | bluebrother | there's quite some stuff in libtools.make that would make sense to rework a bit. This EXTRADEPS thing is one ... |
| 21:11:55 | pamaury | can I use `pkg-config −−libs libcrypto++` and hope it will work when building for windows ? |
| 21:11:55 | bluebrother | well, EXTRALIBS assumes lib<foo>.a in the build folder |
| 21:12:11 | bluebrother | that's pretty unlikely :) |
| 21:12:35 | bluebrother | by default there's no pkg-config on Windows. Not sure if MinGW actually has pkg-config at all ... |
| 21:12:58 | bluebrother | I guess on Windows we need to build libcrypto++ ourselves and link it directly |
| 21:14:21 | pamaury | hum, so should I create a ifdef depending on the platform then ? |
| 21:14:40 | pamaury | you use mxe to cross compile for windows right ? |
| 21:14:46 | bluebrother | partly |
| 21:15:01 | bluebrother | I use mxe for development, but when creating release binaries I use MinGW on Windows. |
| 21:15:28 | bluebrother | the problem is that Qt built with mxe for some reason (haven't figured why) doesn't support accessibility properly |
| 21:15:28 | pamaury | I see |
| 21:15:45 | bluebrother | with mxe it should work. At least I expect that :) |
| 21:15:57 | gevaerts | pamaury: that's why this isn't a problem for you! |
| 21:16:54 | * | pamaury decides to ignore windows for the moment |
| 21:17:15 | bluebrother | we could also consider simply importing it and building it as part of the binary. |
| 21:17:42 | bluebrother | building crypto++ seems pretty straightforward −− just g++ *.cpp |
| 21:18:31 | | Join girafe [0] (~girafe@LFbn-1-8015-136.w90-112.abo.wanadoo.fr) |
| 21:18:34 | bluebrother | also, do we need all of crypto++? We could put it in a separate folder and simply add the required sources to SOURCES in the Makefile |
| 21:18:47 | pamaury | bluebrother: actually no, I just need DES for now |
| 21:18:56 | pamaury | and ECB mode |
| 21:19:41 | | Join PurlingNayuki [0] (~Thunderbi@114.255.40.10) |
| 21:19:45 | pamaury | actually if we are going to use crypto++ for DES, I might switch a number of things to crypto++, like MD5 and AES, since it's probably more optimize |
| 21:19:45 | pamaury | d |
| 21:19:55 | bluebrother | makes sense |
| 21:20:02 | pamaury | and maybe hmac-sha1, used for ZEN |
| 21:20:17 | pamaury | so maybe it's better to build all of crypto++ |
| 21:21:25 | pamaury | bluebrother: EXTRADEPS := -lcrypto++ doesn't work as expected, what am I supposed to write ? |
| 21:21:31 | fIorz | DES and ECB? Sounds like it's missing some MD2, maybe? |
| 21:22:02 | pamaury | fIorz: I didn't choose the cipher ;) |
| 21:22:12 | fIorz | I suspected as much ;-) |
| 21:22:25 | | Join petur [0] (~petur@rockbox/developer/petur) |
| 21:22:33 | pamaury | also it's quite irrelevant since most of Sony security relied on obscurity anyway |
| 21:22:41 | | Quit idonob_ (Ping timeout: 268 seconds) |
| 21:22:43 | bluebrother | that's not a linker flag, it expects a dependency on an archive |
| 21:22:47 | pamaury | oh |
| 21:23:21 | bluebrother | hmm. Won't work like that :/ |
| 21:23:58 | bluebrother | try adding it to CFLAGS |
| 21:24:16 | bluebrother | that's not really the proper way but afaiu the compiler should ignore it when not linking |
| 21:24:45 | bluebrother | then we need to figure if we want to link a system crypto++ at all. But that can be done later |
| 21:24:59 | bluebrother | plus we should add LDFLAGS to the linker call :) |
| 21:26:03 | | Quit PurlingNayuki (Ping timeout: 256 seconds) |
| 21:26:05 | pamaury | ah damn it, linking fails because I think it's using gcc as the linker |
| 21:26:47 | bluebrother | why is that? gcc should invoke the linker on the object just fine |
| 21:27:02 | bluebrother | or is there yet another gcc vs g++ call issue? |
| 21:27:07 | pamaury | I don't know, I get this: |
| 21:27:07 | pamaury | /usr/bin/ld: /home/pamaury/project/rockbox/myrockbox/rbutil/mknwzboot/buildposix/mg.cpp.o: référence au symbole non défini «_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3» |
| 21:27:21 | bluebrother | ok, looks like there is :/ |
| 21:27:38 | pamaury | I think g++ does some making when linking compared to gcc |
| 21:27:46 | pamaury | *magic |
| 21:28:03 | pamaury | or maybe gcc disables some ld magic for c++ |
| 21:28:07 | bluebrother | ok, I get it. It links other compiler libs |
| 21:28:37 | pamaury | yeah I replaced CC by CXX at linking stage and it works |
| 21:29:04 | pamaury | not sure if that the right solution but I don't see any other solution |
| 21:29:18 | bluebrother | when using ld it should work too −− but then it complains about -DVERSION=... |
| 21:29:26 | bluebrother | this really needs some more cleanup |
| 21:30:10 | pamaury | yeah ld would be cleaner but that needs separation betwee cflags and ldflags |
| 21:30:17 | bluebrother | right, and when using ld it doesn't link the standard library |
| 21:30:37 | bluebrother | no, I think we need to use gcc / g++ |
| 21:35:22 | bluebrother | since that ensures the stdlib stuff is linked correctly |
| 21:35:27 | * | bluebrother is working on it |
| 21:36:22 | pamaury | gevaerts: bluebrother: question for you. The mknwzboot needs to embed an sh script that will run on the device. Should I: |
| 21:36:22 | pamaury | 1) hardcode it as a string in the .c |
| 21:36:22 | pamaury | 2) put it in a .sh file and use something like bin2c ? |
| 21:36:46 | gevaerts | How big is it? |
| 21:37:02 | pamaury | 150 lines |
| 21:37:22 | bluebrother | in that case I'd use something like bin2c |
| 21:37:32 | * | pamaury notes that 60% of it is error handling |
| 21:37:34 | gevaerts | I'd say that's too much to maintain as a C string |
| 21:37:45 | pamaury | yeah I think so too |
| 21:39:16 | pamaury | should I do as in mkimxboot where the .sh -> .c is done manually and the .c is included in the repository or should it be rebuilt automatically? |
| 21:39:49 | pamaury | I don't know how to automatically tell libtools.make to build bin2c ;) |
| 21:39:57 | gevaerts | I think I'd prefer an automatic bin2c |
| 21:45:28 | bluebrother | I'd prefer an automatic bin2c for mkimxboot as well :) |
| 21:45:48 | pamaury | bluebrother: that's actually a bad idea because it requires a cross-compiler ;) |
| 21:45:50 | bluebrother | but libtools.make doesn't have support for that right now. Another thing to add :) |
| 21:45:53 | pamaury | (for mkimxbot) |
| 21:46:37 | pamaury | I am trying something along those lines: |
| 21:46:37 | pamaury | install_script.c install_script.h: install_script.sh $(BIN2C) |
| 21:46:37 | pamaury | $(BIN2C) install_script install_script.sh |
| 21:46:37 | DBUG | Enqueued KICK pamaury |
| 21:46:37 | pamaury | # explicit dependencies on install_script.{c,h} and mknwzboot.h |
| 21:46:37 | pamaury | $(OBJDIR)mknwzboot.o: install_script.h install_script.c mknwzboot.h |
| 21:46:38 | *** | Alert Mode level 1 |
| 21:46:38 | pamaury | $(OBJDIR)main.o: install_script.h install_script.c main.c mknwzboot.h |
| 21:46:40 | bluebrother | in that case we could have the object in git instead. I usually prefer to have all generators run automatically that make sense to do so |
| 21:47:44 | pamaury | sure I can do that |
| 21:48:18 | pamaury | hum, I can't seem to make make happy with my automatic bin2c |
| 21:48:58 | | Quit [Saint] (Remote host closed the connection) |
| 21:50:19 | pamaury | a finally I made it to work |
| 21:51:30 | | Join [Saint] [0] (~sinner@rockbox/staff/saint) |
| 21:51:39 | pamaury | bin2c is actually built in libtools.make so it was almost too easy ;) |
| 21:52:53 | bluebrother | I'm about to push some more changes to fix that linking thing |
| 21:54:19 | pamaury | great |
| 21:54:22 | fs-bluebot | Build Server message: New build round started. Revision 3ee7972, 255 builds, 17 clients. |
| 21:54:33 | bluebrother | and done. Now you can set LDFLAGS. |
| 21:56:39 | *** | Alert Mode OFF |
| 21:58:41 | | Quit michaelni (Read error: Connection reset by peer) |
| 21:59:34 | | Join robertd1 [0] (~root@201.208.231.245) |
| 22:00 |
| 22:03:37 | fs-bluebot | Build Server message: Build round completed after 555 seconds. |
| 22:03:38 | fs-bluebot | Build Server message: Revision 3ee7972 result: All green |
| 22:03:47 | chrisjj | Rockbox Info > Battery is looking odd on ZEN. "87% 225h 30m". Then after a minute on USB "91% 7h42m". Then after a minute off USB "82% 6h56m" |
| 22:04:43 | chrisjj | I'm guessing XXh YYm is the estimated time to empty. So varies widely on current and hence projected draw. |
| 22:07:40 | pamaury | we can't measure current draw on the ZEN, estimate is solely based on voltage, which apparently is not reliable. Might be a problem with the calibration curve, I'm not even sure I calibrated it at all |
| 22:09:07 | chrisjj | OK, so X% is measured_voltage/expected_maximum_voltage ? |
| 22:10:48 | pamaury | no, the curve is not linear, we interpolate between 11 known points |
| 22:11:04 | pamaury | you can look at firmware/target/arm/imx233/creative-zen/powermgmt-zen.c |
| 22:12:39 | pamaury | if you want to help calibrate, what you can do is: |
| 22:12:39 | pamaury | 1) charge your device to 100% |
| 22:12:39 | pamaury | 2) start the battery_bench plugin |
| 22:12:39 | pamaury | 3) start a very long playlist in repeat all mode |
| 22:12:39 | pamaury | 4) put a reasonable volume with headphone |
| 22:12:40 | *** | Alert Mode level 1 |
| 22:12:40 | pamaury | 5) let it discharge until it powers down |
| 22:12:42 | pamaury | 6) send me the battery_bench.txt file |
| 22:14:30 | pamaury | ideally you also want to do the same when charging: |
| 22:14:30 | pamaury | 7) [right after power down] start battery_bench again |
| 22:14:30 | pamaury | 8) plug usb by holding a key (so that usb mode is not triggered) |
| 22:14:30 | *** | Alert Mode level 2 |
| 22:14:30 | pamaury | 9) let it charge to 100% percent |
| 22:14:30 | *** | Alert Mode level 3 |
| 22:14:30 | pamaury | 10) send me the battery_bench.txt file |
| 22:14:36 | chrisjj | "if you want to help calibrate" Yup! |
| 22:15:22 | chrisjj | "what you can do is: 1) charge your device to 100%" It never reaches Rockbox 100%. |
| 22:15:24 | | Join michaelni [0] (~michael@213-47-41-20.cable.dynamic.surfer.at) |
| 22:15:48 | pamaury | chrisjj: it doesn't matter, by 100% I mean not charging anymore physically. |
| 22:16:54 | pamaury | you can go to System > Debug > View battery, it indicates charging status and voltage. If you want to be safe, let it charge 1 hour after it reaches the maximum you usually see |
| 22:19:04 | __builtin | hey Bilgus |
| 22:19:47 | bluebrother | battery calibration. The most important thing in a new port. |
| 22:19:50 | Ctcp | Ignored 1 channel CTCP requests in 0 seconds at the last flood |
| 22:19:50 | * | bluebrother hides |
| 22:21:04 | | Quit Marex (Ping timeout: 265 seconds) |
| 22:21:37 | * | pamaury finds bluebrother and recalibrates its battery |
| 22:21:59 | bluebrother | bzzzzt! |
| 22:24:31 | *** | Alert Mode OFF |
| 22:24:46 | chrisjj | "you can look at firmware/target/arm/imx233/creative-zen/powermgmt-zen.c" OK... |
| 22:25:02 | chrisjj | For ZEN: " /* Sansa Fuze+ Li Ion 600mAH figured from discharge curve */" :-) |
| 22:27:14 | | Join Marex [0] (~Marex@195.140.253.167) |
| 22:30:28 | | Join idonob_ [0] (~Owner@S010610c37b922980.vs.shawcable.net) |
| 22:30:38 | Bilgus | __builtin: ? |
| 22:30:49 | __builtin | what is it you were wanting committed? |
| 22:31:11 | __builtin | the backlight patch? |
| 22:31:40 | | Quit WakiMiko_ (Max SendQ exceeded) |
| 22:32:18 | | Join WakiMiko_ [0] (~WakiMiko@unaffiliated/wakimiko) |
| 22:32:21 | *** | Saving seen data "./dancer.seen" |
| 22:32:40 | Bilgus | yes but ideally after it gets tested on more targets |
| 22:33:29 | Bilgus | its been tested on around 5 or 6 of 73 |
| 22:33:43 | __builtin | how low level is it? |
| 22:33:46 | chrisjj | "by 100% I mean not charging anymore physically." Understood, but FAOD there's no way to actually determine this TMK. On those units I've inspected, the OF's Charge Complete doesn't appear even after 6hrs on the charger. |
| 22:34:16 | chrisjj | "If you want to be safe, let it charge 1 hour after it reaches the maximum you usually see" OK. |
| 22:34:26 | Bilgus | define low level |
| 22:35:01 | __builtin | does it rely on driver-level or device-specific code? |
| 22:36:12 | pamaury | chrisjj: if you really want to know, go to System > Debug > HW Info > Power, and it shows the charging state: charging, topoff, disabled, discharging |
| 22:37:37 | Bilgus | Nope it sits in action.c lowest it goes is backlight.c |
| 22:40:27 | chrisjj | pamaury: That says "charging: 1 batadj: 1" |
| 22:40:55 | chrisjj | I assume "topoff" means full, so should I want for that? |
| 22:41:01 | gevaerts | That's the score, I think |
| 22:41:47 | pamaury | ah sorry it must be powermgmt where it show charging/topoff/... wait for topoff. Otherwise in powait, wait for charging: 0 |
| 22:44:23 | chrisjj | powermgmt says state: charging\ncharging tmo: 1436679\ntopoff tmo: 0 |
| 22:44:33 | pamaury | ok, so wait until you see topoff |
| 22:44:47 | chrisjj | OK. What's "tmo"? |
| 22:45:11 | pamaury | timeout |
| 22:45:21 | Bilgus | __builtin: afaik its ready I just upped the last commit |
| 22:46:04 | __builtin | let me test it first |
| 22:46:50 | chrisjj | "timeout" Interesting. I've got 3.88 hours to go! |
| 22:47:16 | Bilgus | Please do. |
| 22:47:39 | __builtin | it doesn't interfere with the default operation, either, right? |
| 22:48:12 | pamaury | chrisjj: this is just the maximum time. It's a safety measure, we disable charging after this time. |
| 22:48:47 | Bilgus | nope |
| 22:48:49 | chrisjj | Ah, how very green! :-) |
| 22:49:47 | Bilgus | if turned off it works just like normal |
| 22:50:21 | __builtin | Bilgus: one last thing −− are you in CREDITS yet? |
| 22:51:04 | Bilgus | nope |
| 22:52:27 | __builtin | ok, then add yourself |
| 22:56:17 | __builtin | it appears that the patch breaks "Backlight on Hold" |
| 22:56:24 | __builtin | is that supposed to happen? |
| 22:58:33 | Bilgus | What is it doing and with what settings? |
| 22:58:38 | [Saint] | I should hope not. |
| 23:00 |
| 23:00:35 | __builtin | ok, I have enabled "No Backlight on Selected Actions" and selected some actions to not affect backlight (play and volume), and then when I turn on the hold switch the backlight remains on, even though "Backlight on Hold" is "Off" |
| 23:02:02 | Bilgus | ah ok let me have a look into how bl on hold works |
| 23:04:12 | Bilgus | hmm thats odd it really shouldn't affect it |
| 23:04:29 | chrisjj | pamaury: I recorded your procedure here https://archive.is/gydhO#selection-1217.1-1283.184 . |
| 23:06:55 | chrisjj | Bilgus: ISTM "No Backlight on Selected Actions" isn't quite accurate to design. Perhaps there's a better way of saying "Disable selected actions' restoration of backlight". |
| 23:07:58 | Bilgus | chrisjj: what do you suggest? |
| 23:08:12 | pamaury | chrisjj: I am not sure this is necessary, this is the standard calibration procedure, which I should have done during the port |
| 23:09:40 | chrisjj | I'm not sure it is necessary :-) But do you really only need it on one unit? |
| 23:11:07 | pamaury | we can only have one calibration curve, and it will never be a perfect match anyway because batteries loose capacity over time |
| 23:11:19 | pamaury | it's just an indication |
| 23:12:20 | chrisjj | So you don't take an average of different units' ? |
| 23:12:46 | __builtin | hey, how do I do LCD_RGBPACK on a 24-bit color depth device? |
| 23:13:06 | chrisjj | Perhaps there's insufficient variation. Or too much! |
| 23:13:21 | __builtin | oh duh |
| 23:14:38 | pamaury | chrisjj: usually manufacturers only one type of battery. And if they don't it's hopeless because it doesn't make sense to "average" discharge curve |
| 23:14:41 | __builtin | never mind, stupid question... :/ |
| 23:15:28 | Bilgus | __builtin: what device are you testing on? |
| 23:15:53 | __builtin | ipod6g |
| 23:15:54 | chrisjj | OK. I guess the ideal would be for each device to be able to make it's own curve. |
| 23:16:04 | __builtin | chrisjj: yes, but that's highly impractical |
| 23:16:57 | chrisjj | Another day I'll ask why :-) |
| 23:17:19 | __builtin | it would require a self-calibrating battery meter, which I /guess/ would possible if every user was willing to calibrate the battery (e.g. full charge/discharge), and even then the battery would change over time |
| 23:19:13 | __builtin | chrisjj: by the way, I have zen build of puzzles available for you to test: https://www.fwei.tk/rockbox-zen.zip |
| 23:19:24 | chrisjj | Brill! |
| 23:20:11 | chrisjj | Can I duplicate the content of teh current playlist in place? |
| 23:20:52 | __builtin | tell me when you have it downloaded so I can delete the file |
| 23:25:48 | chrisjj | Downloaded, installed and running (Plugins>Games>puzzles) |
| 23:26:21 | __builtin | ok, do the colors look odd at all? |
| 23:27:17 | Bilgus | __builtin: are you testing this on the SIM? |
| 23:27:26 | __builtin | no, hardware |
| 23:27:46 | chrisjj | __builtin: Data abort. Do you want reporting in the forum? |
| 23:28:00 | __builtin | under what conditions? |
| 23:28:09 | Bilgus | can you check your backlight timeout when you get a chance? |
| 23:28:16 | chrisjj | Game menu. Not sure what press. |
| 23:28:41 | __builtin | restart your device and see if you can reproduce it |
| 23:28:56 | __builtin | Bilgus: 15s |
| 23:28:57 | chrisjj | Are the Data Abort details any use to you? |
| 23:29:05 | __builtin | the PC, if there is any |
| 23:29:41 | Bilgus | hmm if you turn the setting off does it work properly then? |
| 23:29:57 | Bilgus | (selective backlight) |
| 23:29:59 | __builtin | yes |
| 23:30:31 | | Quit Bray90820_ () |
| 23:31:06 | chrisjj | pc:688507AC |
| 23:31:22 | __builtin | under what conditions, again? |
| 23:31:25 | Bilgus | as far as i can tell bl on hold is implemented directly in backlight.c and the only thing i'v changed there is adding a bool to allow ignoring turn on nothing with the off state |
| 23:32:06 | __builtin | chrisjj: also, what game are you selecting? |
| 23:32:32 | Bilgus | ah i see it give me a moment |
| 23:32:34 | chrisjj | None, but had last selected Untangled. |
| 23:33:06 | __builtin | so you didn't do anything but go up and down in the menu? |
| 23:35:04 | | Quit petur (Quit: Leaving) |
| 23:35:16 | | Quit scorche|sh (Ping timeout: 248 seconds) |
| 23:42:18 | | Join Bray90820 [0] (~bray90820@173-25-204-30.client.mchsi.com) |
| 23:54:23 | | Quit Bray90820 () |
| 23:54:34 | | Quit lebellium (Quit: ChatZilla 0.9.93 [Firefox 50.1.0/20161208153507]) |
| 23:54:47 | | Join Bray90820 [0] (~bray90820@173-25-204-30.client.mchsi.com) |
icon identifies that the person is a core developer (has commit access).