Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2019-06-16

00:02:38 Join dys [0] (~dys@tmo-105-121.customers.d1-online.com)
00:16:18 Join MrZeus [0] (~MrZeus@2a02:c7f:70d4:cd00:44d:8383:66f1:3722)
00:25:37***No seen item changed, no save performed.
00:31:51 Quit Ruhan (Quit: Connection closed for inactivity)
01:00
01:05:49 Quit lebellium (Quit: Leaving)
01:54:15 Quit ZincAlloy (Quit: Leaving.)
02:00
02:25:41***Saving seen data "./dancer.seen"
02:39:06 Join cetnik [0] (63f6249d@gateway/web/freenode/ip.99.246.36.157)
02:47:49 Quit MrZeus (Ping timeout: 258 seconds)
02:55:20 Quit cetnik (Quit: Page closed)
02:57:12 Quit cc___ (Ping timeout: 250 seconds)
03:00
03:03:24dopplerhmm, why did Lofenyy say their question was dumb
03:15:39IncognitoManany idea what would cause this on a sdlapp build of rockbox? https://cdn.discordapp.com/attachments/574151612000632832/589621225496510465/20190615_205539.jpg
03:55:43 Quit beencubed (Ping timeout: 248 seconds)
03:56:12__builtinIncognitoMan: what is that running on?
04:00
04:11:13 Join beencubed [0] (~beencubed@209.131.238.248)
04:12:20 Quit beencubed (Max SendQ exceeded)
04:12:56 Join beencubed [0] (~beencubed@209.131.238.248)
04:25:44***Saving seen data "./dancer.seen"
04:48:35__builtinhmm, what's the target status of the xDuoo X3?
04:48:41__builtinI don't see it on the front page
05:00
05:41:13 Quit TheSeven (Ping timeout: 252 seconds)
05:41:34 Join TheSeven [0] (~quassel@rockbox/developer/TheSeven)
06:00
06:25:46***Saving seen data "./dancer.seen"
06:43:22 Quit michaelni (Ping timeout: 245 seconds)
06:55:58 Join michaelni [0] (~michael@213-47-41-20.cable.dynamic.surfer.at)
07:00
07:22:53 Quit dys (Remote host closed the connection)
07:26:56 Join dys [0] (~dys@tmo-105-121.customers.d1-online.com)
08:00
08:09:39 Quit dys (Ping timeout: 268 seconds)
08:11:07 Join dys [0] (~dys@tmo-108-49.customers.d1-online.com)
08:25:49***Saving seen data "./dancer.seen"
08:34:34 Quit TheSeven (Ping timeout: 248 seconds)
08:36:51 Join TheSeven [0] (~quassel@rockbox/developer/TheSeven)
10:00
10:25:50***Saving seen data "./dancer.seen"
10:29:14 Quit Huntereb (Ping timeout: 248 seconds)
10:53:50 Join Huntereb [0] (~Huntereb@69.161.102.241)
11:00
11:04:53 Join lebellium [0] (~lebellium@89-92-69-110.hfc.dyn.abo.bbox.fr)
11:41:34 Join cc___ [0] (~ac@2001:910:1033:1:6a05:caff:fe1c:1627)
12:00
12:25:52***Saving seen data "./dancer.seen"
12:37:52 Quit cc___ (Ping timeout: 250 seconds)
12:52:56 Quit igitoor (Remote host closed the connection)
13:00
13:01:17 Join igitoor [0] (igitur@2a00:d880:3:1::c1ca:a648)
13:15:46 Quit igitoor (Changing host)
13:15:46 Join igitoor [0] (igitur@unaffiliated/contempt)
13:37:58 Join ZincAlloy [0] (~Adium@2a02:8108:9440:dfc:b51c:da0e:c1f7:14af)
14:00
14:25:55***Saving seen data "./dancer.seen"
14:46:10 Quit dys (Remote host closed the connection)
15:00
15:24:00 Join dys [0] (~dys@tmo-108-49.customers.d1-online.com)
16:00
16:08:15Bilgus__builtin, any luck on that bisect?
16:20:05 Join vmx [0] (~vmx@ip5f5bfdec.dynamic.kabel-deutschland.de)
16:25:57***Saving seen data "./dancer.seen"
17:00
17:04:05 Quit benedikt93 (Ping timeout: 272 seconds)
17:12:15 Quit Moarc (Quit: i znowu NADMUCHAŁ BALONA)
17:14:49 Join Moarc [0] (~chujko@a105.net128.okay.pl)
17:19:50 Join MrZeus [0] (~MrZeus@2a02:c7f:70d4:cd00:b475:1d3c:466f:12b2)
17:23:23 Join benedikt93 [0] (~quassel@unaffiliated/benedikt93)
17:33:14 Quit noobineer (Ping timeout: 248 seconds)
17:55:43mendelmunkisAnyone have any comments on #2086 ?
18:00
18:04:24foolshmendelmunkis: I can't test it, my fuze+ battery went out. How does it feel in use? and a more descriptive commit message would be helpful for future reference, tell them exactly what keys are doing what etc.
18:05:42mendelmunkisfoolsh: thanks for the advice. I cant describe the feel because I've been using it for years.
18:08:04 Join krabador [0] (~krabador@unaffiliated/krabador)
18:26:00***Saving seen data "./dancer.seen"
18:28:52 Quit krabador (Remote host closed the connection)
18:30:23mendelmunkisThe rockbox sim just gives a blank window without even the background. Any obvious reasons for that to happen?
18:42:57__builtinBilgus: haven't had time yet, unfortunately
18:43:17__builtinI'm pretty sure it's a rockbox bug, though
18:45:19__builtinAnd mendelmunkis, a more descriptive commit message would be good
18:47:38mendelmunkisHow do i update a patch set?
18:57:11foolshmendelmunkis: For the sim try "make clean" and you're using ccache "ccache -c" then comile again, sometimes cruft gets left over and messes up a compile
18:58:48 Quit funman (Changing host)
18:58:48 Join funman [0] (~fun@rockbox/developer/funman)
19:00
19:01:46foolshmendelmunkis: It's been awhile for me, but to update a commit message just "git commit −−amend" then push as usual, is this right anyone?
19:28:46foolshmendelmunkis: Also, for #2086 there is additions to the manual to be added
19:47:41dopplerhey, awesome. I was able to rewrite the apple firmware to the device manually and now I'm rockboxin.
19:56:12 Join Ruhan [0] (uid76353@gateway/web/irccloud.com/x-twjgitfctjiwzjdn)
20:00
20:07:43__builtinfoolsh, mendelmunkis: the trick is to make sure your new commit message has the same Change-Id as the previous patch
20:08:22__builtinThe way I do it is "git rebase -i HEAD^^^"
20:08:25 Quit dys (Ping timeout: 248 seconds)
20:09:00__builtinThen mark your most recent commit as a "fixup", and optionally "reword" the original commit
20:09:48__builtinIf you don't have a commit to squash (as in this case) you can just "reword" the original
20:23:33 Join dys [0] (~dys@tmo-103-114.customers.d1-online.com)
20:26:01***Saving seen data "./dancer.seen"
20:44:34__builtinagh, I forgot how Gerrit is still screwed up... developers still have duplicate accounts without commit privileges :(
20:59:27foolshIt would be nice to have github hooked into the build farm, so we can just migrate over there
21:00
21:08:54__builtinwe're really integrated with our own infrastructure, though
21:17:08__builtinBilgus: looks like the bad commit is 2876859
21:17:17__builtin"Fix lcd not waking up when backlight is always off"
21:29:54Bilguslooks like there are several commits with that
21:30:31__builtinhmm?
21:31:12Bilgustransflective LCDs: fix "first buttonpress enables backlight only"
21:31:44Bilgus g#1354\
21:33:09BilgusI'm guessing the second is to fix the first one perhaps
21:35:41__builtinBilgus: https://git.rockbox.org/?p=rockbox.git;a=commit;h=053c4d0593ea1dc5974bf0cc4c08ffc3db65c30e
21:36:03 Join ulmutul [0] (~ulmutul@rockbox/developer/ulmutul)
21:36:34__builtinBilgus: never mind, I mean https://git.rockbox.org/?p=rockbox.git;a=commit;h=287685932e53849192020092bce7d7a21d9e2a71
21:36:52__builtinulmutul: good that you're here :)
21:37:08ulmutulI just read the logs.
21:37:24ulmutulI guess it's my fault hten. What exactly is the problem?
21:37:53__builtinon ipod6g, activating HOLD causes a white flash on the screen
21:38:27__builtinI've tracked it down to firmware/backlight.c:backlight_update_state()
21:38:36__builtincalling lcd_awake() there seems to cause the issue
21:39:25BilgusI wonder if the 6g's lcd_awke and backlight_off conflict in their 'syscalls'
21:42:04ulmutulHm, I will have a look...
21:51:34__builtinulmutul: what was that patch originally intended to fix?
21:52:23 Quit vmx (Remote host closed the connection)
21:54:13mendelmunkis__builtin: it helps to actually add the commit hook when you set up a new computer.
21:55:01mendelmunkisfoolsh: I'm pretty sure I included that in the commit.
21:55:33mendelmunkisAlso the first thing i usually try is building in a clean directory.
21:58:45ulmutulUsually if the sleep timer runs out, the backlight shuts off and the LCD is deactivated. As soon as you press a button the LCD is activated again and the backlight turns on. However if you set the backlight to "always off" the LCD is not reactivated if you press a button.
22:00
22:01:01__builtinulmutul: I see
22:01:04ulmutulIf you have a device with a transflective LCD you probably want to see something on it, even if the backlight is turned off. The patch reactivates the LCD when a button is pressed even if the backlight setting is set to "always off" (but only for transflective targets!)
22:02:42__builtinis it supposed to be running that code when the hold button is toggled?
22:07:12ulmutulIt should work exacly as the described backlight functionality on non-transflective targets (think of "LCD readable" and "LCD black" for backlight on/off). I don't think I've tested the various backlight-on-hold settings :)
22:09:38 Join vmx [0] (~vmx@ip5f5bfdec.dynamic.kabel-deutschland.de)
22:14:45ulmutul__builtin: Can you test the following: Set LCD Settings>Sleep (after Backlight Off) to (1) Always and (2) Never and test if the flashes appear in both cases?
22:16:54ulmutulI found that Always and Never seem to be interchanged; is it the same for you? I.e. "Never" shuts off the LCD immediately with the backlight and "Always" keeps the LCD running.
22:24:56__builtinulmutul: sure
22:25:33__builtinit looks to me like both Always and Never both keep the LCD on
22:25:37__builtinno difference between the two
22:26:04***Saving seen data "./dancer.seen"
22:29:25ulmutulHm, strange, one the two settings should disable the LCD.
22:30:02__builtinthat's a bug in and of itself :(
22:36:28ulmutulDoes anybody know if the bug only affects IPod 6g, or does it affect 5g (Video) as well? (Or other IPods with transflective screen)
22:37:40*__builtin can't answer that
23:00
23:13:34mendelmunkishow do i change a file in uisimulator/common for one target?
23:16:02__builtinmendelmunkis: what are you trying to accomplish, exactly?
23:19:16mendelmunkisI'm back to work on landscape mode and trying to test something in the sim. I am having two issues
23:19:54mendelmunkisone is that i redefined one of the functions used there for specific players which means i need to redefine the sim version too.
23:20:24mendelmunkisthe other is that the compiled sim (from my branch) wont run.
23:20:45mendelmunkiss/run/display anything/
23:23:29ulmutulYou can enclose the function with #ifdef TARGET_NAME (or #ifndef) if you mean that.
23:27:04ulmutul__builtin: Can you test if the following version still flashes?
23:27:07ulmutulhttps://www.dropbox.com/s/bagytgx6349g3yy/rockbox.ipod?dl=0
23:27:27__builtinyeah, I can
23:29:22__builtinulmutul: that seems to have partially fixed the flashes, especially on HOLD
23:29:28 Join cc___ [0] (~ac@2001:910:1033:1:6a05:caff:fe1c:1627)
23:29:31__builtinthere's still one scenario where it still flashes
23:29:37 Quit lebellium (Quit: Leaving)
23:30:19__builtinwell, there's two issues
23:30:38__builtinthe main thing is that your change seems to have reversed Sleep on Backlight/Always-Never
23:31:03__builtinso now Always keeps the LCD on all the time
23:31:14__builtinand Never actually turns it off
23:31:32__builtinthe flash occurs when Sleep on Backlight=Never
23:32:19__builtinwhen that is true, the flash happens both on HOLD switch toggle, and when the backlight timer expires
23:36:34mendelmunkisis config/targetname.h preprocessed on a simulator build?
23:39:25ulmutulI noticed another issue: if you switch your player to HOLD, the LCD will always stay enabled, except if you switch to HOLD when the LCD is already off.
23:40:06__builtinulmutul: yes, that's correct
23:40:14ulmutulI'll investigate further tomorrow, it's getting late here.
23:40:19__builtinalright, good night
23:40:29ulmutulGood night!
23:48:33 Quit vmx (Remote host closed the connection)
23:49:15 Quit ulmutul (Quit: Leaving)
23:50:07 Quit ZincAlloy (Quit: Leaving.)

Previous day | Next day