Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2019-10-10

00:26:14 Quit petur (Quit: Leaving)
00:28:44 Join ats_ [0] (~ats@cartman.offog.org)
00:30:20 Quit atsampson (Ping timeout: 250 seconds)
00:34:22 Quit ats_ (Ping timeout: 246 seconds)
00:39:11 Join MrZeus [0] (~MrZeus@88-145-72-11.host.pobb.as13285.net)
00:42:20Bilgus g#2267
00:42:22fs-bluebotGerrit review #2267 at http://gerrit.rockbox.org/r/2267 : Fix timer Agptek Rocker (other hosted players) by William Wilgus
00:54:29Bilgushmm the other thing I noted is tat lower priority timers block could block the higher ones and none of the plugins check so they are probably unregistering other timers...
00:57:02Bilgusif that makes sense
01:00
01:15:17 Quit krabador (Remote host closed the connection)
01:22:35 Join tchan [0] (~tchan@c-98-206-136-82.hsd1.il.comcast.net)
01:22:35 Quit tchan (Changing host)
01:22:35 Join tchan [0] (~tchan@lunar-linux/developer/tchan)
01:27:36 Join atsampson [0] (~ats@cartman.offog.org)
01:28:40***Saving seen data "./dancer.seen"
01:36:44w1d3m0d3seen some stuff about an android port, what's that about?
02:00
02:01:20 Quit MrZeus (Ping timeout: 250 seconds)
02:57:44 Join TheSeven [0] (~quassel@rockbox/developer/TheSeven)
03:00
03:28:44***Saving seen data "./dancer.seen"
03:54:17 Join MrZeus [0] (~MrZeus@88-145-72-11.host.pobb.as13285.net)
04:00
04:07:15 Quit advcomp2019__ (Ping timeout: 264 seconds)
05:00
05:07:44 Join advcomp2019 [0] (~advcomp20@65-131-144-92.sxct.qwest.net)
05:07:44 Quit advcomp2019 (Changing host)
05:07:44 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
05:13:14 Quit MrZeus (Read error: Connection reset by peer)
05:14:11 Quit Strife89 (Ping timeout: 250 seconds)
05:14:49 Join Strife89 [0] (~quassel@adsl-74-250-153-47.ags.bellsouth.net)
05:22:08 Join MrZeus [0] (~MrZeus@88-145-72-11.host.pobb.as13285.net)
05:28:48***Saving seen data "./dancer.seen"
06:00
06:00:35 Quit Strife89 (Quit: No Ping reply in 180 seconds.)
06:02:06 Join Strife89 [0] (~quassel@adsl-74-250-153-47.ags.bellsouth.net)
06:04:26 Quit foolsh_ (Ping timeout: 240 seconds)
06:05:49 Join foolsh [0] (~quassel@192.121.245.97)
06:21:04 Join advcomp2019_ [0] (~advcomp20@unaffiliated/advcomp2019)
06:22:50 Join advcomp2019__ [0] (~advcomp20@unaffiliated/advcomp2019)
06:24:24 Quit advcomp2019 (Ping timeout: 268 seconds)
06:26:15 Quit advcomp2019_ (Ping timeout: 268 seconds)
07:00
07:24:02 Quit MrZeus (Ping timeout: 240 seconds)
07:28:52***Saving seen data "./dancer.seen"
07:57:17 Join Rower [0] (~husvagn@m83-185-80-216.cust.tele2.se)
07:57:48 Join deevious [0] (~Thunderbi@193.226.142.214)
08:00
08:54:57 Join jdarnley [0] (~J_Darnley@d51A44418.access.telenet.be)
08:56:02 Quit J_Darnley (Ping timeout: 250 seconds)
09:00
09:03:04 Join petur [0] (~petur@mx1.dekimo.be)
09:03:04 Quit petur (Changing host)
09:03:04 Join petur [0] (~petur@rockbox/developer/petur)
09:28:55***Saving seen data "./dancer.seen"
10:00
10:10:50 Quit foolsh (Ping timeout: 240 seconds)
10:37:38 Quit dys (Ping timeout: 240 seconds)
10:45:32pixelmaw1d3m0d3: there once was a "Rockbox as an Application" project which was working for older android versions using dalvik (IIRC how that was called). It broke with ART and the wish was to fix it *properly* but that needs a lot of rework and that never happened
11:00
11:21:02 Join TheSphinX_ [0] (~briehl@srv001.nosupamu.de)
11:22:22 Quit TheSphinX^ (Ping timeout: 245 seconds)
11:22:22 Nick TheSphinX_ is now known as TheSphinX^ (~briehl@srv001.nosupamu.de)
11:28:56***Saving seen data "./dancer.seen"
13:00
13:14:02 Quit atsampson (Ping timeout: 245 seconds)
13:28:58***Saving seen data "./dancer.seen"
13:48:29 Join krabador [0] (~krabador@unaffiliated/krabador)
14:00
14:30:38 Join massiveH [0] (~massiveH@ool-18e4eaeb.dyn.optonline.net)
14:31:04Bilgus__builtin that fixed it but never got a splash from multiple timers running :/ maybe the timer is screwy and doesn't actually stop when timer_delete() is called ??
14:46:47 Quit deevious (Quit: deevious)
15:00
15:11:31Bilgus'The treatment of any pending signal generated by the
15:11:32Bilgus deleted timer is unspecified.' so might just be a case of not removing the callbacks as well
15:29:01***Saving seen data "./dancer.seen"
15:41:23 Join smoke_fumus [0] (~smoke_fum@188.35.176.90)
15:49:04 Join Piece_Maker [0] (~eddie@cpc97736-bolt17-2-0-cust152.10-3.cable.virginm.net)
15:51:52 Quit Acou_Bass (Ping timeout: 265 seconds)
15:51:52 Nick Piece_Maker is now known as Acou_Bass (~eddie@cpc97736-bolt17-2-0-cust152.10-3.cable.virginm.net)
15:58:45 Quit massiveH (Quit: Leaving)
16:00
16:20:21 Join dys [0] (~dys@tmo-111-105.customers.d1-online.com)
16:25:25 Quit krabador (Remote host closed the connection)
16:50:04 Join Rower- [0] (~husvagn@m83-185-87-216.cust.tele2.se)
16:52:25 Quit Rower (Ping timeout: 240 seconds)
17:00
17:03:58Bilgus g#2267 fixes the callback after free issue on the rocker anyone care to look it over before I push it?
17:03:59fs-bluebotGerrit review #2267 at http://gerrit.rockbox.org/r/2267 : Fix timer Agptek Rocker (other hosted players) by William Wilgus
17:11:22 Join pamaury [0] (~pamaury@maths.r-prg.net.univ-paris7.fr)
17:11:23 Quit pamaury (Changing host)
17:11:23 Join pamaury [0] (~pamaury@rockbox/developer/pamaury)
17:14:11__builtinBilgus: one thing
17:15:24__builtinIf there's a unregister callback given, why is timer_unregister not called?
17:16:22BilgusI was matching it to the existing implementation
17:16:52Bilgusif there is a unregister callback the core uses it to call timer_unregister
17:18:07Bilgushttps://github.com/Rockbox/rockbox/blob/master/firmware/backlight.c#L336
17:18:32__builtinI see, that makes sense.
17:20:58Bilgusbut really timer_unregister() is not needed there just timer_delete(tID) since presumably everything else gets overwritten
17:25:28 Quit petur (Quit: Connection reset by beer)
17:26:04Bilgusthere that should be exactly the same ;)
17:29:02***Saving seen data "./dancer.seen"
17:29:28Bilgusoh I do notice somewhere I might have screwed up though
17:29:33Bilgushttp://man7.org/linux/man-pages/man7/sigevent.7.html
17:29:50Bilgusunion sigval sigev_value; /* Data passed with
17:29:50Bilgus notification */
17:29:50Bilgus void (*sigev_notify_function) (union sigval);
17:29:50DBUGEnqueued KICK Bilgus
17:29:50Bilgus /* Function used for thread
17:29:50Bilgus notification (SIGEV_THREAD) */
17:30:22BilgusI read that as there are two sigval unions in that struct CORRECT?
17:46:20BilgusI'm pretty sure I read that correctly, I also added some notes to timer.c and timer.h, I had the same questions when I first looked at the code as well so its probably a good idea to note that in the comments
17:49:22 Join J_Darnley [0] (~J_Darnley@d51A44418.access.telenet.be)
17:50:55 Quit jdarnley (Ping timeout: 240 seconds)
17:52:44 Join jdarnley [0] (~J_Darnley@d51A44418.access.telenet.be)
17:54:26 Quit J_Darnley (Ping timeout: 268 seconds)
18:00
18:15:29Bilgusoh duh its saying its passed to the function :/
18:15:53Bilgusdon't mind me lol
18:29:59 Quit Bilgus (Quit: Leaving)
18:33:28 Quit pamaury (Quit: Konversation terminated!)
18:48:09 Join advcomp2019 [0] (~advcomp20@65-131-149-211.sxct.qwest.net)
18:48:09 Quit advcomp2019 (Changing host)
18:48:09 Join advcomp2019 [0] (~advcomp20@unaffiliated/advcomp2019)
18:48:12 Quit advcomp2019__ (Read error: Connection reset by peer)
18:52:08 Quit tchan (Quit: WeeChat 2.4)
18:55:39 Join atsampson [0] (~ats@cartman.offog.org)
19:00
19:07:29 Join MrZeus [0] (~MrZeus@88-145-72-11.host.pobb.as13285.net)
19:23:10 Join Bilgus [0] (~Bilgus@unaffiliated/bilgus)
19:29:04***Saving seen data "./dancer.seen"
19:53:01w1d3m0d3pixelma: aw, unfortunate
19:53:07w1d3m0d3didn't android retain backwards compat tho?
20:00
20:01:57 Quit mendelmunkis (Ping timeout: 245 seconds)
20:09:31 Join mendelmunkis [0] (~mendelmun@97-116-102-68.mpls.qwest.net)
21:00
21:00:57 Quit mendelmunkis (Read error: Connection reset by peer)
21:01:20 Join mendelmunkis [0] (~mendelmun@97-116-102-68.mpls.qwest.net)
21:16:10 Quit mendelmunkis (Ping timeout: 250 seconds)
21:29:07***Saving seen data "./dancer.seen"
21:40:16 Quit Moarc (Quit: i znowu NADMUCHAŁ BALONA)
21:43:04 Join mendelmunkis [0] (~mendelmun@97-116-114-179.mpls.qwest.net)
21:54:44 Quit jdarnley (Ping timeout: 250 seconds)
21:54:45 Join J_Darnley [0] (~J_Darnley@d51A44418.access.telenet.be)
21:55:58 Join Moarc [0] (~chujko@a105.net128.okay.pl)
23:00
23:17:10 Quit xcin (Excess Flood)
23:20:09 Join xcin [0] (~x@159.203.132.140)
23:20:10 Quit xcin (Excess Flood)
23:22:40 Join xcin [0] (~x@159.203.132.140)
23:22:40 Quit xcin (Excess Flood)
23:23:40 Join xcin [0] (~x@159.203.132.140)
23:23:40 Quit xcin (Excess Flood)
23:26:39 Join xcin [0] (~x@159.203.132.140)
23:26:39 Quit xcin (Excess Flood)
23:28:41 Join xcin [0] (~x@159.203.132.140)
23:28:41 Quit xcin (Excess Flood)
23:29:08***Saving seen data "./dancer.seen"
23:29:42 Join xcin [0] (~x@159.203.132.140)
23:45:24 Join krabador [0] (~krabador@unaffiliated/krabador)

Previous day | Next day