| 00:00:08 | | Join t0mato [0] (t0mato@gateway/vpn/mullvad/t0mato) |
| 00:08:25 | *** | Saving seen data "./dancer.seen" |
| 00:13:09 | | Join mutax [0] (~mutax@ip5f590aa6.dynamic.kabel-deutschland.de) |
| 00:30:11 | | Quit livvy (Remote host closed the connection) |
| 00:30:21 | | Join livvy [0] (~livvy@gateway/tor-sasl/livvy) |
| 01:00 |
| 01:07:49 | | Join Rower [0] (~Rower@78-73-72-39-no2340.tbcn.telia.com) |
| 01:35:23 | | Quit kakaka (Ping timeout: 240 seconds) |
| 01:45:02 | | Quit bluebrother^ (Ping timeout: 260 seconds) |
| 01:46:32 | | Join bluebrother [0] (~dom@rockbox/developer/bluebrother) |
| 01:50:08 | | Join kakaka [0] (~koniu@gateway/tor-sasl/koniu) |
| 02:00 |
| 02:08:27 | *** | Saving seen data "./dancer.seen" |
| 03:00 |
| 03:00:04 | | Quit ufdm (Ping timeout: 256 seconds) |
| 03:02:28 | | Join Stanley00 [0] (~stanley00@unaffiliated/stanley00) |
| 03:13:33 | | Join petur [0] (~petur@rockbox/developer/petur) |
| 03:15:32 | | Join ufdm [0] (~ufdm@c-73-164-63-214.hsd1.mn.comcast.net) |
| 03:39:30 | | Quit t0mato (Quit: Ping timeout (120 seconds)) |
| 03:41:50 | | Quit ufdm (Ping timeout: 256 seconds) |
| 03:44:49 | | Join t0mato [0] (t0mato@gateway/vpn/mullvad/t0mato) |
| 04:00 |
| 04:08:29 | *** | Saving seen data "./dancer.seen" |
| 04:33:41 | | Join ufdm [0] (~ufdm@c-73-164-63-214.hsd1.mn.comcast.net) |
| 05:00 |
| 05:06:32 | | Join prof_wolfff [0] (~prof_wolf@148.red-83-49-157.dynamicip.rima-tde.net) |
| 05:56:53 | braewoods | i'm still waiting for a review of my iriver_flash update |
| 05:58:47 | | Quit S|h|a|w|n (Read error: Connection reset by peer) |
| 06:00 |
| 06:08:30 | *** | Saving seen data "./dancer.seen" |
| 06:10:46 | | Quit prof_wolfff (Ping timeout: 272 seconds) |
| 06:23:06 | | Join pamaury [0] (~pamaury@maths.r-prg.net.univ-paris7.fr) |
| 06:23:06 | | Quit pamaury (Changing host) |
| 06:23:06 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 06:28:28 | | Quit pamaury (Quit: Konversation terminated!) |
| 06:45:34 | | Join p3tur [0] (~petur@rockbox/developer/petur) |
| 06:46:48 | | Join petur2 [0] (~petur@77.77.179.66) |
| 06:49:24 | | Quit petur (Ping timeout: 272 seconds) |
| 06:50:42 | | Quit p3tur (Ping timeout: 260 seconds) |
| 06:54:41 | | Join _bilgus [0] (~bilgus@65.186.35.190) |
| 06:57:21 | fs-bluebot_ | Build Server message: New build round started. Revision c79ddb6, 293 builds, 9 clients. |
| 07:00 |
| 07:01:38 | braewoods | _bilgus: so how can i get my bootloader builds distributed to the official resource? speachy seemed to approve. |
| 07:06:47 | _bilgus | the bootloaders (the generated .iriver not the completed scrambled bootloader) get added to the server and then the final link/scramble is done on the users computer |
| 07:07:30 | _bilgus | so they just need to b euploaded and hopefully the existing infra just runs with it |
| 07:08:42 | speachy | tellme where to get 'em and I can put them in place. All I need are the bootloader-h???.bin files |
| 07:08:51 | speachy | is there an updated fwpatcher binary too? |
| 07:10:09 | _bilgus | I think they are hxxx.iriver you can't supply the .bin directly |
| 07:10:28 | _bilgus | well you can but we don't :p |
| 07:10:51 | speachy | what's on the server: http://download.rockbox.org/bootloader/iriver |
| 07:11:20 | speachy | bootloader-h???.bin and H10_???.mi4 |
| 07:11:33 | _bilgus | sure enough |
| 07:14:36 | braewoods | speachy: basically, i put the... |
| 07:14:48 | braewoods | https://www.rockbox.org/wiki/IriverBoot |
| 07:14:49 | braewoods | them here |
| 07:14:56 | braewoods | as zip files, contains the iriver one and the bin one |
| 07:15:10 | braewoods | they are identical, except one has a header and the otherdoesn't |
| 07:15:13 | braewoods | the payload is the same |
| 07:15:33 | braewoods | i believe the website wants the raw .bin |
| 07:15:53 | braewoods | let me check it to make sure |
| 07:16:19 | braewoods | i think you can delete the fwpatcher? i think rbutil does that now |
| 07:16:31 | fs-bluebot_ | Build Server message: Build round completed after 1151 seconds. |
| 07:16:33 | fs-bluebot_ | Build Server message: Revision c79ddb6 result: All green |
| 07:18:17 | braewoods | yep looks right |
| 07:18:22 | braewoods | the reset vector looks good |
| 07:18:31 | braewoods | 00 1f 17 40 |
| 07:18:40 | braewoods | the entry point of the first executed code |
| 07:19:14 | braewoods | speachy: do we really need an updated fwpatcher? those aren't useable on Linux. |
| 07:20:14 | braewoods | none of the other bootloader directories have it |
| 07:20:38 | braewoods | hm |
| 07:21:20 | braewoods | ok. i'll prepare a zip file of the renamed bootloaders. |
| 07:22:10 | speachy | I don't know if we need an updated fwpatcher, that's why I asked −− the one there is from 2006 |
| 07:22:25 | braewoods | yea |
| 07:22:39 | braewoods | i'm pretty sure we can dump it... i don't see what use it would have nowadays. |
| 07:22:46 | braewoods | rbutil is the one that does the patching now |
| 07:22:49 | braewoods | i'm pretty sure of that |
| 07:22:59 | braewoods | let me look |
| 07:24:49 | _bilgus | I'd find it odd if it were only available thru rbutil there is typicaLLY THE MANULA WAY AND THEN RBUTIL FOR END-USER |
| 07:24:55 | _bilgus | bah sorry |
| 07:26:17 | braewoods | fwpatcher... seems to be for people doing the patching manually |
| 07:26:21 | braewoods | but it's windows only |
| 07:26:23 | braewoods | so |
| 07:26:38 | braewoods | and there's instructions for how to do the patching from some tools |
| 07:27:07 | speachy | we only provide windows binaries as we presume *nix users can compile it themselves |
| 07:27:07 | braewoods | https://www.rockbox.org/wiki/IriverBoot#Patching_the_iriver_firmware |
| 07:27:16 | braewoods | it should still work |
| 07:27:19 | braewoods | just the same |
| 07:27:26 | braewoods | so i don't see why we'd want to recompile |
| 07:27:43 | braewoods | main thing is we'd probably need to update rbutil with the new checksums |
| 07:27:55 | braewoods | since the BL is changing |
| 07:28:01 | _bilgus | and therefore probably fw-patcher |
| 07:28:10 | | Quit Stanley00 (Remote host closed the connection) |
| 07:28:32 | braewoods | ok good point |
| 07:28:33 | speachy | ok, so google is now insisting that we "update the home page" to include a few things. problem is that gerrit doesn't let us modify that stuff. |
| 07:28:47 | _bilgus | lol |
| 07:29:05 | braewoods | let me double check that i renamed the bootloaders correctly |
| 07:29:21 | | Join prof_wolfff [0] (~prof_wolf@148.red-83-49-157.dynamicip.rima-tde.net) |
| 07:29:41 | speachy | and the whole reason behind this crap is that the "home page" and the "authentication redirection page" aren't the same. |
| 07:29:46 | _bilgus | maybe the latest gerrit would otherwise how can anyone use it now? |
| 07:30:42 | speachy | we've been coasting on autopilot on this stuff for the past... oh, 8 years? so their policies are undoubedly much tighter now. |
| 07:32:16 | _bilgus | yeah a lot has changed since then |
| 07:32:34 | speachy | speaking of, did anyone do a sanity-check on the bare-bones privacy policy I pulled out of my posterior? |
| 07:32:46 | braewoods | braewoods.net/iriver-bootloaders.zip">https://braewoods.net/iriver-bootloaders.zip |
| 07:32:46 | mendel_munkis | yes. seems pretty good overall |
| 07:33:01 | braewoods | there we go. |
| 07:33:04 | braewoods | renamed and all |
| 07:33:05 | braewoods | and checked |
| 07:33:14 | braewoods | now we need to update checksum |
| 07:33:18 | mendel_munkis | mostly just common sense and stuff that's in other locations on the site :) |
| 07:33:21 | braewoods | i'll take a look at that |
| 07:34:39 | braewoods | oh joy |
| 07:34:45 | braewoods | need to make a new set of checksums |
| 07:34:50 | * | braewoods mumbles |
| 07:35:09 | braewoods | it's compiled into git |
| 07:35:12 | braewoods | so |
| 07:35:21 | braewoods | ok here we go... need to grab the original firmwares |
| 07:35:23 | braewoods | for all these |
| 07:36:06 | _bilgus | where is this policy located? |
| 07:36:13 | speachy | https://www.rockbox.org/wiki/PrivacyPolicy |
| 07:36:35 | speachy | (I'm still adding links to the various site templates) |
| 07:37:02 | mendel_munkis | the original xrick porter gave the go ahead to get the assets from his github repo. he just warned that it may put us in violation of githubs TOS. |
| 07:37:28 | speachy | us, or him? |
| 07:37:38 | speachy | I mean, there's nothing to stop anyone from hotlinking anything... |
| 07:37:52 | mendel_munkis | he said us. BUt I think it would be a bigger problem for him. |
| 07:37:56 | speachy | yeah |
| 07:42:51 | braewoods | gimme a bit i'll need time to setup this mess |
| 07:42:57 | braewoods | i need a copy of every supported FW first |
| 07:43:10 | braewoods | didn't realize how it worked before |
| 07:43:19 | _bilgus | mendel I assume the game assets come from an original version of the game is that still available? |
| 07:43:35 | | Join MrZeus [0] (MrZeus@gateway/vpn/mullvad/mrzeus) |
| 07:44:19 | _bilgus | or more widespread I guess would be the better criterion |
| 07:44:27 | speachy | _bilgus: IIUC they're modified/extracted from the original |
| 07:44:53 | _bilgus | speaking of that I saw someone had binaries on GH for DOOM |
| 07:45:12 | _bilgus | with embedded assets |
| 07:45:52 | _bilgus | if the original is available for end users to find we could give them a extraction script instead |
| 07:46:21 | _bilgus | same as we do with the fw basically |
| 07:49:44 | _bilgus | https://github.com/nneonneo/universal-doom |
| 07:51:20 | | Quit MrZeus (Ping timeout: 256 seconds) |
| 07:54:20 | speachy | added two more things to the policy; a note about jurisdiction, and the fact that data about financial contributions is collected and retained. |
| 07:54:48 | _bilgus | speachy Re: privacy policy do we need a cookie definition use blurb? I know we use them for the forum or do login cookies fall under a different category? |
| 07:55:03 | speachy | hmm. |
| 07:57:04 | speachy | we only use them for login purposes. |
| 08:00 |
| 08:01:20 | _bilgus | Links To Other Web Sites |
| 08:01:20 | _bilgus | rockbox.org may contain links to other web sites. The publishing of such links does not signify endorsement of such web sites or location or its contents. We have no control over, do not review and are not responsible for the privacy policies of or content displayed on such other web sites. Please be aware that the terms of this Privacy Policy do not apply to any 3rd party web sites. |
| 08:04:28 | speachy | that's not really a privacy policy thing though. |
| 08:06:36 | _bilgus | that our privacy policy doesn't cover links on or around? |
| 08:06:49 | speachy | privacy only covers data we collect. |
| 08:06:53 | speachy | collect/use |
| 08:07:25 | speachy | "We disclaim all responsibility for user-supplied content" is a differnt sort of legalese. |
| 08:08:13 | mendel_munkis | _bilgus: I cant find an original easily. (it was a zx spectrum/c64 game) |
| 08:08:31 | *** | Saving seen data "./dancer.seen" |
| 08:08:59 | speachy | mendel_munkis: it was ported to everything under teh sun |
| 08:09:11 | speachy | I remember playing it on DOS back in the day |
| 08:09:16 | _bilgus | well if its not easily available then that pretty much forces the issue |
| 08:09:49 | mendel_munkis | yeah there was a dos port. but the devs implied that it didn't sell very well |
| 08:09:59 | mendel_munkis | (across alltheports) |
| 08:11:25 | | Join _bilgus_ [0] (~bilgus@2605:a000:1301:89f6:a80a:7f8:d34a:b6cd) |
| 08:13:50 | | Quit _bilgus (Ping timeout: 256 seconds) |
| 08:17:06 | speachy | okay, another update. |
| 08:19:31 | _bilgus_ | looks good wonder if we have any lawyers around |
| 08:20:07 | braewoods | only the armchair kind :} |
| 08:29:25 | speachy | aha! gerrit has minimal templating but it's good enough. |
| 08:35:56 | _bilgus_ | awesome! |
| 08:39:16 | speachy | ...but doesn't seem to be working. |
| 08:42:13 | mendel_munkis | _bilgus_: why did you get rid of rb->lcd_framebuffer again? |
| 08:43:27 | _bilgus_ | for days of extra headaches? |
| 08:48:24 | speachy | ... okay, the templating only seems to work in the old ui. WTF. |
| 08:48:29 | _bilgus_ | I have several different goals with all this first is to allow any framebuffer + stride to be used with the inbuilt graphics functions |
| 08:49:48 | _bilgus_ | upon getting into the FB stuff I realized this would require a way to specify and store the FB for a particular viewport |
| 08:50:35 | mendel_munkis | I do get it. I am just frustrated from trying to use a framebuffer in multiple files. |
| 08:50:46 | mendel_munkis | *framebuffer pointer |
| 08:50:57 | _bilgus_ | unfortunately the old way of a common framebuffer pretty much makes this impossible since everyone and their brother access the framebuffer stick their fingers in it and typically don't clean up their mess |
| 08:51:24 | _bilgus_ | so now we have an API and it'll get more strict as time goes by |
| 08:51:40 | mendel_munkis | which reminds me. I should probably switch to a smaller framebuffer eventually |
| 08:52:17 | _bilgus_ | mendel the viewport_test file should show a decent way of doing that |
| 08:53:21 | _bilgus_ | basically you create a viewport with a static buffer in one file and just pass the VP around or set it in the defining file and copy it once you get to the other ones |
| 08:54:04 | mendel_munkis | Yeah I figured out how to eventually. I just had a bunch of segfaults first :) |
| 08:55:32 | _bilgus_ | I almost put in some stuff for checking the validity of the buffer do you think I should when debug is active? |
| 08:56:07 | _bilgus_ | the seg faults are actually a feature believe it or not |
| 08:56:12 | mendel_munkis | well the problem was mostly me not remembering how C memory works. |
| 08:56:43 | mendel_munkis | so the segfaulting was enough to tell me I screwed up some memory somewhere. |
| 08:57:02 | _bilgus_ | fail early |
| 08:57:36 | mendel_munkis | I failed so early the DEBUGF in plugin_start didn't trigger |
| 08:57:38 | _bilgus_ | I suspect there are a few more bugs that will pop out due to a number of recent changes |
| 08:58:23 | _bilgus_ | so maybe some extra checks when debug is enabled? |
| 08:58:56 | _bilgus_ | figure it'll still be a panic but it might help highligh issues |
| 08:59:18 | mendel_munkis | I've got no issues with more debugging information. |
| 08:59:55 | _bilgus_ | k so we can do a NULL pointer check and maybe a sanity check based on the location of the buffer |
| 09:00 |
| 09:00:35 | _bilgus_ | like is it beyond the bounds of known user memory |
| 09:02:22 | speachy | okay! polygerrit template fixed. |
| 09:06:03 | braewoods | _bilgus_: can you quickly review g#3025? it fixes some bugs in fwpatcher. |
| 09:06:05 | fs-bluebot_ | Gerrit review #3025 at https://gerrit.rockbox.org/r/c/rockbox/+/3025 : fwpatcher: fix a few issues with the mksums.pl script by James Buren |
| 09:06:19 | braewoods | now back to work |
| 09:07:21 | _bilgus_ | commit message is longer than the commit :P |
| 09:07:33 | braewoods | lol |
| 09:07:38 | fs-bluebot_ | Build Server message: New build round started. Revision 5252523, 293 builds, 9 clients. |
| 09:09:09 | speachy | gerrit now has our logo and a link to the privacy policy in the footer. looks crappy under the old UI, but the new UI looks decent |
| 09:11:24 | speachy | bOOM! browser crash. |
| 09:12:48 | mendel_munkis | oh oh |
| 09:12:49 | _bilgus_ | the privacy policy link only goes to the main wiki frontpage |
| 09:13:03 | | Quit kakaka (Ping timeout: 240 seconds) |
| 09:14:48 | _bilgus_ | huh but only broken in the new UI |
| 09:15:16 | braewoods | ok good... i confirmed the generator script is returning the same output as in the git copies now |
| 09:15:21 | speachy | whoops. |
| 09:15:27 | braewoods | now i can finally generate the new checksums |
| 09:15:30 | speachy | fixed. |
| 09:16:12 | speachy | still haven't figured out WTF the wiki is getting its menubar template from |
| 09:18:52 | speachy | mendel_munkis: BTW, you're going to need to add keymaps for players added since the original xrick patchset was created. lest we end up with a pile of red once it's committed |
| 09:19:10 | mendel_munkis | true I also need to fix a few other issues. |
| 09:20:09 | | Join massiveH [0] (~massiveH@ool-18e4e82f.dyn.optonline.net) |
| 09:20:24 | fs-bluebot_ | Build Server message: Build round completed after 766 seconds. |
| 09:20:26 | fs-bluebot_ | Build Server message: Revision 5252523 result: All green |
| 09:23:36 | mendel_munkis | I cant find the original xrick port information anywhere on rockbox. since I pulled it out of my tree there is a decent chance I've rebased in a fix or two in the past. is that a problem? |
| 09:25:00 | speachy | nope, as long as the history is in gerrit somewhere |
| 09:26:00 | mendel_munkis | I cant find it in gerrit. I don't know if it ever made it there. |
| 09:26:01 | speachy | it's more important from a legal/attribution perspective; my attitude towards patches is that only the final one merged matters; I don't care about the previous 83 revisions it took to get into a mergeable state.. |
| 09:26:33 | speachy | you mean it predates g#1005? |
| 09:26:35 | fs-bluebot_ | Gerrit review #1005 at https://gerrit.rockbox.org/r/c/rockbox/+/1005 : added xrick game by Sebastian Leonhardt |
| 09:26:59 | mendel_munkis | take a look at the date and tim on that. |
| 09:27:42 | speachy | are you referring to the 4yr gap between v6 and v7 (that you uploaded?) |
| 09:28:03 | mendel_munkis | oh wait. I got confused because of the new layout and didn't see the previous patchsets. |
| 09:28:12 | mendel_munkis | never mind all that |
| 09:28:51 | | Join Stanley00 [0] (~stanley00@unaffiliated/stanley00) |
| 09:31:38 | | Quit kugel (*.net *.split) |
| 09:31:46 | | Join kugel [0] (~kugel@ip5b40cea7.dynamic.kabel-deutschland.de) |
| 09:31:46 | | Quit kugel (Changing host) |
| 09:31:46 | | Join kugel [0] (~kugel@rockbox/developer/kugel) |
| 09:32:40 | speachy | fixed the rb logo on the gerrit site to point at the main www page. I _hate_ javascript/DOM. |
| 09:33:26 | | Quit Stanley00 (Ping timeout: 272 seconds) |
| 09:35:10 | speachy | so. at the risk of this being a hand grenade, should we have a Code of Conduct too? |
| 09:35:19 | | Join kakaka [0] (~koniu@gateway/tor-sasl/koniu) |
| 09:35:49 | speachy | even if it's as simple as the "When in doubt, don't be an asshole" clause I used to insert into my tenants' leases. |
| 09:35:53 | | Quit kakaka (Remote host closed the connection) |
| 09:36:15 | gevaerts | "When not in doubt, feel free"? :) |
| 09:36:41 | | Join kakaka [0] (~koniu@gateway/tor-sasl/koniu) |
| 09:38:08 | _bilgus_ | do we even want to open that door |
| 09:39:04 | speachy | given that we're not a legal enitity, OH HELL NO |
| 09:40:07 | braewoods | hm |
| 09:40:46 | braewoods | speachy: i found a problem. |
| 09:40:56 | braewoods | with the mkboot code perhaps? |
| 09:41:08 | braewoods | or maybe it's the validation of scramble at fault |
| 09:41:10 | braewoods | but |
| 09:41:22 | braewoods | if i try to embed a BL above around 55k or so |
| 09:41:38 | braewoods | it fails validation. the check that fails is the one about maximum rom size |
| 09:41:54 | braewoods | i know these work, so what's going on? |
| 09:41:56 | mendel_munkis | To me CoC means only be a jerk in ways we haven't thought of |
| 09:43:01 | braewoods | hm. |
| 09:43:09 | braewoods | i need to investigate the documentation of this. |
| 09:43:22 | speachy | mendel_munkis: Aye. |
| 09:43:24 | braewoods | it's possible the validation is off. |
| 09:43:27 | _bilgus_ | braewoods, what datatype is the size held in overflow at 64 k? |
| 09:43:51 | braewoods | _bilgus_: you mean.. the actual numbers? |
| 09:43:57 | _bilgus_ | yes |
| 09:45:04 | _bilgus_ | uint16t overflows at 64k |
| 09:45:06 | braewoods | _bilgus_: https://dpaste.com/5ER4ADB4J |
| 09:45:13 | braewoods | it happens even below that |
| 09:45:27 | braewoods | the original failing BL is 57k |
| 09:45:42 | braewoods | but i noticed it seems to be for any above a certain size |
| 09:45:57 | braewoods | i'm not sure the exact amount but it'd be whatever puts it over the raw flash_size |
| 09:46:06 | braewoods | i think the math in the validation is wrong since the |
| 09:46:09 | braewoods | size is |
| 09:46:23 | gevaerts | We do have various sets of rules, such as https://www.rockbox.org/wiki/IrcGuidelines. Making sure we know which ones are there already would be a good start I think :) And then possibly making sure rules are consistent between the various channels (irc, mail, forums, ...) |
| 09:46:24 | braewoods | equal to the total file size |
| 09:46:46 | braewoods | and the check is for the raw flash size |
| 09:46:59 | speachy | gevaerts: I don't think we have anything formally written down other than the IRC stuff |
| 09:47:48 | gevaerts | And yes, a CoC that *just* lists specific points is useless. "Don't be an asshole" or "Demonstrate common courtesy to people" (as the irc guidelines phrase it) should close most loopholes though |
| 09:48:19 | speachy | of course now I'm reminded of the SpaceBalls "Major Asshole" bit |
| 09:50:10 | gevaerts | As usual my position here is "I'm not active, so don't listen to me", but in my opinion a CoC that doesn't try to be too specific but clarifies general attitude and intent is a good idea |
| 09:50:59 | _bilgus_ | braewoods, I think in iriver.c ln 324 that should probably be expanded to tell which check failed |
| 09:51:14 | braewoods | _bilgus_: probably. but one thing at a time. |
| 09:51:32 | braewoods | there's an error in these programs somewhere |
| 09:51:35 | braewoods | not sure who is at fault |
| 09:52:01 | braewoods | it's either mkboot or scramble or both |
| 09:52:11 | braewoods | i'm going to look at mkboot first |
| 09:52:24 | braewoods | see why it fails closer to max but works fine at smaller amounts |
| 09:53:34 | braewoods | ... well that's no good |
| 09:53:50 | braewoods | hm |
| 09:56:17 | braewoods | kinda funny |
| 09:56:23 | braewoods | hm |
| 09:57:46 | | Join edhelas [0] (9d94237298@2a01:7c8:aab8:6b9:5054:ff:fec9:fd84) |
| 10:00 |
| 10:08:33 | *** | Saving seen data "./dancer.seen" |
| 10:13:32 | speachy | more policy updates, referring to advertising/marketing/tracking and specific use of 3rd party authentication data. |
| 10:13:39 | speachy | trying to cover the bases in what google is looking for |
| 10:31:56 | speachy | Ok! Google logins are working again! |
| 10:42:37 | | Quit massiveH (Quit: Leaving) |
| 10:50:24 | braewoods | _bilgus_: i found the problem. |
| 10:50:41 | braewoods | _bilgus_: there's nothing wrong that i can tell with mkboot... but iriver.c validates it wrong. |
| 10:50:47 | braewoods | though i did find one issue with mkboot |
| 10:50:57 | _bilgus_ | left handed math? |
| 10:51:24 | braewoods | the first 3 32 bit integers of the header... |
| 10:51:33 | braewoods | the first is the total binary file size.. everything included |
| 10:51:43 | braewoods | this includes the raw image, the headers, the checksum blocks, etc |
| 10:51:51 | braewoods | so of course a file near max flash size will fail it |
| 10:52:03 | braewoods | this is the one that mkboot uses |
| 10:52:05 | braewoods | for that check |
| 10:52:19 | braewoods | the second is the total binary length with some header |
| 10:52:22 | _bilgus_ | ah even though it just uses portions |
| 10:52:25 | braewoods | it's the best candidate to use as it is the closest |
| 10:52:46 | braewoods | it's the actual rom image length + a 32 byte header |
| 10:52:51 | braewoods | rounded up to the next 512 byte |
| 10:52:53 | braewoods | boundary |
| 10:53:01 | braewoods | so |
| 10:53:06 | braewoods | the max file size is actually |
| 10:53:09 | _bilgus_ | ah ok yeah the rounded up part fixes my concern |
| 10:53:10 | braewoods | 0x400200 |
| 10:53:19 | braewoods | for the payload |
| 10:53:24 | braewoods | or 0x200200 |
| 10:54:10 | braewoods | there is one issue with |
| 10:54:12 | _bilgus_ | well assumin the flash is in 512b blocks or less |
| 10:54:13 | braewoods | mkboot though |
| 10:54:29 | braewoods | _bilgus_: that's how it was setup all this time so i assume it is still true |
| 10:54:49 | braewoods | only one way to find out though |
| 10:54:49 | _bilgus_ | it seems a moderately safe assumption |
| 10:55:10 | braewoods | the other issue is the mkboot didn't reserve enough space to handle this situation |
| 10:55:14 | braewoods | i found it is about 500 bytes short |
| 10:55:24 | braewoods | but that's the only flaw i found |
| 10:55:28 | braewoods | i'll correct both |
| 10:55:49 | braewoods | sec |
| 10:55:49 | _bilgus_ | well being that they never tested that situation its little wonder |
| 10:56:16 | braewoods | well i wanted to be sure it can handle the maximum bootloader that should fit at the end of the flash |
| 10:56:31 | braewoods | i ran into this with a 57k bootloader |
| 10:56:53 | braewoods | ok let me do something else |
| 11:00 |
| 11:11:07 | __builtin | mendel_munkis: you may need https://www.rockbox.org/wiki/HowToAutomatePluginScreenshots |
| 11:15:46 | braewoods | _bilgus_: ready, g#3027 |
| 11:15:48 | fs-bluebot_ | Gerrit review #3027 at https://gerrit.rockbox.org/r/c/rockbox/+/3027 : tools: fix counting mistakes in iriver firmware code by James Buren |
| 11:17:13 | braewoods | hm on second thought |
| 11:17:39 | braewoods | let me check if i can check the actual length directly for better accuracy |
| 11:19:11 | _bilgus_ | so is iriver.c the same in tools and in fwpatcher? |
| 11:19:28 | braewoods | _bilgus_: no idea. at one point they probably were but the other one is definitely much older |
| 11:19:40 | braewoods | the one in fwpatcehr |
| 11:23:00 | braewoods | hm |
| 11:28:42 | | Quit Misanthropos (Ping timeout: 272 seconds) |
| 11:29:52 | braewoods | got an idea. let me try it. |
| 11:43:58 | | Quit petur2 (Quit: Connection reset by beer) |
| 11:47:00 | braewoods | hm |
| 12:00 |
| 12:05:13 | | Join Misanthropos [0] (~Misanthro@91.240.64.151) |
| 12:08:34 | *** | Saving seen data "./dancer.seen" |
| 12:09:42 | braewoods | git diff |
| 12:09:44 | braewoods | err |
| 12:10:01 | _bilgus_ | ok so is 3027 ready or a WIP then? |
| 12:10:24 | braewoods | wip. |
| 12:10:33 | braewoods | i've got an idea. |
| 12:10:40 | braewoods | the actual length is recorded |
| 12:10:51 | braewoods | in a header in the raw data |
| 12:10:53 | braewoods | so |
| 12:10:58 | braewoods | that's what i should check for max accuracy |
| 12:11:05 | braewoods | trouble is it's in the encrypted or decrypted stream |
| 12:11:17 | braewoods | so i need to inject myself into the stream |
| 12:11:18 | braewoods | to check it |
| 12:11:41 | fs-bluebot_ | Build Server message: New build round started. Revision 9c68c69, 293 builds, 9 clients. |
| 12:14:55 | | Quit JanC (Remote host closed the connection) |
| 12:15:18 | | Join JanC [0] (~janc@lugwv/member/JanC) |
| 12:23:18 | braewoods | there. it works... though a bit crude. |
| 12:30:21 | fs-bluebot_ | Build Server message: Build round completed after 1120 seconds. |
| 12:30:22 | fs-bluebot_ | Build Server message: Revision 9c68c69 result: 252 errors 0 warnings |
| 12:32:42 | braewoods | ? |
| 12:32:44 | braewoods | uh, what? |
| 12:33:05 | speachy | you mean the errors? that's my doing. |
| 12:33:12 | braewoods | yea |
| 12:33:16 | braewoods | _bilgus_: it's ready for review again |
| 12:35:13 | braewoods | basically i decided to hook into the read/write loops and just copy the length when it came across the chunk that had it |
| 12:35:16 | _bilgus_ | those magic numbers can you place notes or make them defines in mkboot.c please? |
| 12:36:15 | fs-bluebot_ | Build Server message: New build round started. Revision 3e32521, 293 builds, 9 clients. |
| 12:36:22 | braewoods | ok |
| 12:42:37 | | Join wodz [0] (~wodz@89-64-78-138.dynamic.chello.pl) |
| 12:43:03 | _bilgus_ | braewoods, where is firmware_minsize getting defined? |
| 12:43:14 | braewoods | _bilgus_: top of the file |
| 12:43:30 | braewoods | line 36 and 38 |
| 12:43:39 | braewoods | and i found an issue already. |
| 12:43:59 | braewoods | i don't know where the length is during the decode pass |
| 12:44:02 | braewoods | only during encode so far |
| 12:44:45 | braewoods | ugh. |
| 12:44:56 | braewoods | ya know, i'll come back to this issue and just focus on the mkboot one for the moment |
| 12:44:59 | wodz | re coldfire targets: I have MPIO HD200 in semiworking condition (usb bridge doesn't work) and MPIO HD300 which used to work but last time I tried it refused to boot. Anyway debugging bootloaders is pretty easy - you just need BDM pod. gevaerts has mine AFAIK. |
| 12:45:33 | braewoods | wodz: eh? kinda late. we've already past that point. |
| 12:45:45 | _bilgus_ | ok I gtg now but I will be back in 6 ish hrs |
| 12:46:42 | braewoods | i just keep finding crap that needs patching before i can even update the firmware... thank you whoever wrote this. :> |
| 12:47:49 | speachy | braewoods: don't worry, the next person to dig into this code will grumble about your work. And the circle remains unbroken... |
| 12:50:55 | fs-bluebot_ | Build Server message: Build round completed after 880 seconds. |
| 12:50:57 | fs-bluebot_ | Build Server message: Revision 3e32521 result: 251 errors 149 warnings |
| 12:52:07 | braewoods | i may end up rebuilding these bootloaders since i've run into so many delays |
| 12:55:20 | * | speachy sighs. |
| 12:55:55 | fs-bluebot_ | Build Server message: New build round started. Revision 63691ad, 293 builds, 9 clients. |
| 12:56:10 | braewoods | speachy: ? |
| 12:56:15 | braewoods | speachy: lol |
| 12:56:26 | braewoods | i didn't expect to need to patch so much |
| 12:56:36 | speachy | -1 error, +149 warnings. |
| 13:00 |
| 13:00:36 | | Quit wodz (Quit: Leaving) |
| 13:08:24 | fs-bluebot_ | Build Server message: Build round completed after 750 seconds. |
| 13:08:36 | fs-bluebot_ | Build Server message: Revision 63691ad result: All green |
| 13:20:32 | | Join lebellium [0] (~lebellium@89-92-69-66.hfc.dyn.abo.bbox.fr) |
| 13:25:35 | braewoods | speachy: could you review g#3030? |
| 13:25:37 | fs-bluebot_ | Gerrit review #3030 at https://gerrit.rockbox.org/r/c/rockbox/+/3030 : mkboot: fix the buffer size used for constructing the final firmware image by James Buren |
| 13:29:10 | speachy | looks good |
| 13:29:28 | braewoods | i confirmed it equals the actual final size produced by mkboot under worst case |
| 13:30:34 | | Quit edhelas (Remote host closed the connection) |
| 13:31:38 | fs-bluebot_ | Build Server message: New build round started. Revision 64ea644, 293 builds, 9 clients. |
| 13:33:27 | lebellium | braewoods: thanks for the new iRiver bootloader, I'll try it out to see if my startup issue with the remote is fixed |
| 13:34:13 | lebellium | and regarding the 1.31K firmware, it was my request to support it a few years ago because I really wanted the latest OF version with games aside Rockbox, but I don't remember who did it and how |
| 13:34:44 | braewoods | lebellium: don't mind it, i'm just patching up loose ends |
| 13:34:50 | braewoods | i still can't release it just yet |
| 13:35:09 | braewoods | the tools used for installation still got a few bugs to fix |
| 13:37:36 | braewoods | lebellium: what was the issue you were having? |
| 13:38:06 | lebellium | When starting the device with the remote the bootloader said the hold switch was ON while it wasn'y |
| 13:38:47 | braewoods | oh |
| 13:38:52 | braewoods | that was fixed ages ago |
| 13:38:59 | braewoods | according to the notes |
| 13:39:38 | lebellium | yes but I used the bootloader v5 from 2006 I guess |
| 13:47:08 | mendel_munkis | _bilgus_: btw building the manual gives me a vague warning on the wps context plugin file |
| 13:52:43 | fs-bluebot_ | Build Server message: Build round completed after 1264 seconds. |
| 13:52:44 | fs-bluebot_ | Build Server message: Revision 64ea644 result: All green |
| 14:00 |
| 14:08:38 | *** | Saving seen data "./dancer.seen" |
| 14:52:42 | braewoods | ok... g#3031 should fix that problem. |
| 14:52:44 | fs-bluebot_ | Gerrit review #3031 at https://gerrit.rockbox.org/r/c/rockbox/+/3031 : rockbox: fix iriver firmware validation for larger bootloaders by James Buren |
| 15:00 |
| 15:01:04 | | Quit dys (Ping timeout: 240 seconds) |
| 15:02:34 | | Join dys [0] (~dys@aurora.ydns.eu) |
| 15:29:12 | | Join petur [0] (~petur@rockbox/developer/petur) |
| 15:37:29 | mendel_munkis | what is the difference between \opt and \optv in the manual? |
| 15:38:06 | | Quit pixelma (Quit: .) |
| 15:38:06 | | Quit amiconn (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) |
| 15:40:44 | | Join amiconn [0] (jens@rockbox/developer/amiconn) |
| 15:40:44 | | Join pixelma [0] (marianne@rockbox/staff/pixelma) |
| 15:47:06 | speachy | braewoods: looks sane to me. |
| 15:47:27 | braewoods | speachy: yea. i'll need to test fwpatcher later when i can figure out how to build it. |
| 15:49:57 | speachy | mendel_munkis: it's defined in optional.sty, and it looks like there's only one user. |
| 15:52:33 | speachy | I _think_ the point is to allow for verbatim text that is not processed further. |
| 15:53:06 | braewoods | ok. rbutil/fwpatcher checksums updated in git |
| 15:53:10 | braewoods | just needs to be approved |
| 15:53:21 | braewoods | now we need to test these |
| 15:57:33 | braewoods | installing mingw on my build box |
| 15:57:40 | braewoods | thank you debian |
| 16:00 |
| 16:02:25 | speachy | hmm. |
| 16:05:29 | braewoods | ok. it compiles. |
| 16:05:34 | braewoods | needed to patch it some. |
| 16:07:02 | braewoods | pushed some fixes to gerrit |
| 16:07:31 | braewoods | next up |
| 16:07:37 | braewoods | i need to test this on a windows VM |
| 16:07:40 | * | braewoods mumblbes |
| 16:08:41 | *** | Saving seen data "./dancer.seen" |
| 16:09:34 | braewoods | unless wine would suffice |
| 16:11:03 | | Quit pixelma (Quit: .) |
| 16:11:03 | | Quit amiconn (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) |
| 16:12:54 | braewoods | ok it seems to work |
| 16:13:13 | braewoods | let's test h300 for good measure |
| 16:13:44 | | Join amiconn [0] (jens@rockbox/developer/amiconn) |
| 16:13:44 | | Join pixelma [0] (marianne@rockbox/staff/pixelma) |
| 16:16:10 | braewoods | i'll test this before i hand it out |
| 16:22:48 | speachy | from a code review perspective, the three patches look good, as long as they actually work. :D |
| 16:24:24 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 16:25:22 | braewoods | currently testing the resulting image on my h120 |
| 16:25:24 | braewoods | from OF |
| 16:25:44 | braewoods | should work |
| 16:25:51 | braewoods | and it boots into V8 BL |
| 16:26:23 | braewoods | pass |
| 16:26:30 | braewoods | now to test H300 |
| 16:26:36 | braewoods | first to reflash OF |
| 16:29:25 | braewoods | speachy: they seem to work. |
| 16:29:30 | braewoods | fwpatcher so far is god |
| 16:29:32 | braewoods | good |
| 16:29:58 | braewoods | ok now to load it up with the modded firmware |
| 16:30:19 | speachy | I think rbutil integrates fwpatcher too, need to make sure that still builds properly |
| 16:30:47 | braewoods | it integrates something else |
| 16:30:55 | braewoods | i think |
| 16:30:58 | braewoods | anyway |
| 16:31:03 | braewoods | we'll check it out soon |
| 16:31:48 | speachy | because we both know that 2.5ms after we post it someone will complain on reddit that it doesn't work on whatever use case we didn't think to test. |
| 16:33:37 | braewoods | ok flashing V8. |
| 16:33:39 | braewoods | via OF |
| 16:33:42 | braewoods | let's see if it works |
| 16:34:25 | braewoods | and it does |
| 16:34:41 | braewoods | ok |
| 16:34:48 | braewoods | go ahead and approve those |
| 16:34:55 | braewoods | i'll look at rbutil... somehow? |
| 16:35:02 | braewoods | hm |
| 16:35:18 | braewoods | anyway |
| 16:35:22 | braewoods | time to bundle it up |
| 16:37:05 | braewoods | ok. my bootloader set now includes updated builds of fwpatcher |
| 16:39:56 | braewoods | speachy: where's the instructions on how to build rbutil? |
| 16:40:51 | fs-bluebot_ | Build Server message: New build round started. Revision 4fd1e43, 293 builds, 9 clients. |
| 16:41:03 | speachy | all three submitted. |
| 16:41:11 | braewoods | ok. |
| 16:41:20 | braewoods | i'm trying to verify rbutil still builds. |
| 16:41:33 | braewoods | but i know the algorithms from both engines are working correctly |
| 16:41:43 | braewoods | i tested it once to generate the new checksums |
| 16:41:49 | braewoods | and again when i tested fwpatcher |
| 16:42:03 | speachy | I'm doing an rbutil build on my end |
| 16:42:06 | braewoods | ok. |
| 16:42:24 | braewoods | maybe it's about time to cut a new rbutil release |
| 16:42:36 | braewoods | a minor one if nothing else |
| 16:42:58 | speachy | bluebrother is working through his rbutil todo, he has his own release criteria |
| 16:44:08 | lebellium | "because we both know that 2.5ms after we post it someone will complain on reddit that it doesn't work on whatever use case we didn't think to test." Is rockbox still that popular? :) |
| 16:44:58 | braewoods | ok |
| 16:45:51 | braewoods | speachy: braewoods.net/iriver-bootloaders.zip">https://braewoods.net/iriver-bootloaders.zip |
| 16:46:04 | braewoods | whenever you're ready that has all the files |
| 16:46:16 | braewoods | maybe archive the old V5 and V6 though |
| 16:46:32 | braewoods | hm |
| 16:46:36 | braewoods | while we're at it though |
| 16:46:42 | braewoods | sec |
| 16:48:11 | braewoods | updated. it has both types of bootloaders. |
| 16:48:19 | braewoods | some people may want to upgrade through iriver_flash |
| 16:48:30 | braewoods | the raw bin is for rbutil and fwpatcher though |
| 16:49:06 | speachy | built cleanly on linux. |
| 16:49:16 | speachy | so yay. |
| 16:49:20 | braewoods | probably enough for such a simple change |
| 16:50:42 | | Quit lebellium (Quit: Leaving) |
| 17:00 |
| 17:03:34 | fs-bluebot_ | Build Server message: Build round completed after 1364 seconds. |
| 17:03:36 | fs-bluebot_ | Build Server message: Revision 4fd1e43 result: All green |
| 17:15:30 | | Quit Rower (Ping timeout: 256 seconds) |
| 17:38:25 | | Quit funman (Ping timeout: 240 seconds) |
| 17:39:04 | | Join funman [0] (~fun@chui-pas.net) |
| 18:00 |
| 18:08:44 | *** | Saving seen data "./dancer.seen" |
| 18:09:03 | mendel_munkis | hat are the download stats? |
| 18:09:11 | mendel_munkis | s/hat/what |
| 18:10:56 | braewoods | ? |
| 18:10:59 | braewoods | for...? |
| 18:33:49 | _bilgus_ | mendel_munkis, Thanks |
| 18:34:20 | fs-bluebot_ | Build Server message: New build round started. Revision ad665a0, 293 builds, 9 clients. |
| 18:35:26 | mendel_munkis | rockbox. |
| 18:36:00 | mendel_munkis | ie how many people want to install some version of rockbox in a given week? |
| 18:37:09 | mendel_munkis | bilgus. the same issue exists in a few other places. thanks for showing me what the fix looks like. |
| 18:44:04 | _bilgus_ | pretty sure it didn't used to require an item tag |
| 18:44:44 | _bilgus_ | but who knows Latex is a mess |
| 18:48:38 | speachy | mendel_munkis: I did some log analyzing a few months ago to try and figure that out but I don't remember the details, beyond most traffic being due to bots. |
| 18:49:36 | fs-bluebot_ | Build Server message: Build round completed after 916 seconds. |
| 18:49:38 | fs-bluebot_ | Build Server message: Revision ad665a0 result: All green |
| 18:49:51 | | Join Misanthr- [0] (~Misanthro@91.240.64.139) |
| 18:51:50 | | Quit Misanthropos (Ping timeout: 256 seconds) |
| 18:51:52 | | Nick Misanthr- is now known as Misanthropos (~Misanthro@91.240.64.139) |
| 18:59:42 | | Quit ac_laptop (Quit: WeeChat 2.9) |
| 19:00 |
| 19:00:02 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 19:00:39 | | Quit ac_laptop (Client Quit) |
| 19:01:28 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 19:28:55 | | Quit petur (Remote host closed the connection) |
| 19:55:45 | | Quit bluebrother (Disconnected by services) |
| 19:55:50 | | Join bluebrother^ [0] (~dom@rockbox/developer/bluebrother) |
| 19:56:54 | | Join fs-bluebot [0] (~fs-bluebo@55d4a8db.access.ecotel.net) |
| 19:59:22 | | Quit fs-bluebot_ (Ping timeout: 260 seconds) |
| 20:00 |
| 20:06:02 | | Quit [7] (Ping timeout: 264 seconds) |
| 20:08:47 | *** | Saving seen data "./dancer.seen" |
| 20:52:38 | | Join S|h|a|w|n [0] (~shawn156@unaffiliated/shawn156) |
| 21:00 |
| 21:36:48 | | Join Stanley00 [0] (~stanley00@unaffiliated/stanley00) |
| 22:00 |
| 22:08:49 | *** | No seen item changed, no save performed. |
| 22:44:44 | | Quit livvy (Remote host closed the connection) |
| 23:00 |
| 23:23:01 | | Quit prof_wolfff (Ping timeout: 265 seconds) |
icon identifies that the person is a core developer (has commit access).