| 00:30:32 | | Join saratoga [0] (620acd42@cpe-98-10-205-66.rochester.res.rr.com) |
| 00:36:18 | | Quit ecs (Ping timeout: 260 seconds) |
| 00:40:11 | saratoga | do we want to set a maximum album art size for performance reasons? |
| 00:40:13 | | Join ecs [0] (esawady@d2evs.net) |
| 00:40:25 | saratoga | decoding seems mostly dependent on file size not resolution |
| 00:41:08 | saratoga | a 12000x6000 1.7MB image took 9 seconds to load and resize on the Clip Zip |
| 00:41:32 | saratoga | the same image at 1/4th the pixels but 4x the file size took 18 seconds |
| 00:42:12 | saratoga | for performance reasons I'm tempted to say that files over 1MB or so should be rejected |
| 00:42:34 | saratoga | although that probably depends a lot on the device performance |
| 00:43:11 | saratoga | normally i wouldn't care, but playback is paused while the images decode, so if you have an enormous image on a slow player it can look like its frozen |
| 00:44:02 | | Join alexbobp [0] (~alex@meowface.org) |
| 00:44:24 | | Nick alexbobp is now known as Guest69432 (~alex@meowface.org) |
| 00:44:57 | saratoga | g#3074 is seems to work on both device and sim, haven't managed to get a crash on either using lots of large album art |
| 00:44:59 | fs-bluebot_ | Gerrit review #3074 at https://gerrit.rockbox.org/r/c/rockbox/+/3074 : Fix deadlocks when trying to buffer large album art. by Michael Giacomelli |
| 00:48:08 | | Quit saratoga (Remote host closed the connection) |
| 01:00 |
| 01:02:39 | braewoods | another idea, make the loading cancelable if it takes too much time to finish |
| 01:48:41 | *** | Saving seen data "./dancer.seen" |
| 01:53:00 | _bilgus__ | saratoga I'd probably do Nx the player resolution or something |
| 01:53:38 | _bilgus__ | like 128896 max is 1280x960 |
| 01:53:47 | _bilgus__ | 128x96 |
| 01:55:17 | _bilgus__ | speaking of do the results of the resize get saved or is this an every play cost? |
| 02:00 |
| 02:19:32 | | Quit MrZeus (Ping timeout: 272 seconds) |
| 03:00 |
| 03:10:26 | | Join prof_wolfff [0] (~prof_wolf@148.red-83-49-157.dynamicip.rima-tde.net) |
| 03:17:37 | | Quit prof_wolfff (Ping timeout: 258 seconds) |
| 03:48:43 | *** | Saving seen data "./dancer.seen" |
| 04:00 |
| 04:18:17 | | Quit olspookishmagus (Quit: All for nothing) |
| 04:51:25 | | Quit Stanley00 (Quit: Nice weekend) |
| 05:00 |
| 05:01:30 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 05:07:07 | | Join blokdian [0] (abe0b209@171.224.178.9) |
| 05:07:18 | blokdian | hello |
| 05:07:25 | blokdian | uh |
| 05:08:37 | blokdian | so I was using the internet casually and then I was checking out a new FreshOS theme and I saw that I was banned |
| 05:08:44 | blokdian | I am using a guest account |
| 05:09:05 | blokdian | any help would be appreciated |
| 05:11:34 | blokdian | I am not banned from the website but just the forum, thought that would add some info |
| 05:34:40 | | Quit blokdian (Ping timeout: 245 seconds) |
| 05:36:08 | | Join livvy [0] (~livvy@gateway/tor-sasl/livvy) |
| 05:48:45 | *** | Saving seen data "./dancer.seen" |
| 06:00 |
| 06:03:40 | | Join blokdian [0] (abe0b209@171.224.178.9) |
| 06:06:11 | | Quit blokdian (Remote host closed the connection) |
| 06:11:10 | | Quit livvy (Remote host closed the connection) |
| 06:23:25 | | Join livvy [0] (~livvy@gateway/tor-sasl/livvy) |
| 06:41:42 | speachy | blokdian: bans tend to only heppen when there are spammy links in the forum post. |
| 06:41:58 | speachy | unless you got caught up in an unrelated IP address ban. |
| 07:00 |
| 07:00:06 | speachy | what was the username you used? |
| 07:20:42 | braewoods | speachy: erm. they're already gone. |
| 07:21:14 | | Quit t0mato (Quit: Ping timeout (120 seconds)) |
| 07:21:19 | speachy | yeah. but I did it for the lols. logs. |
| 07:21:27 | | Join t0mato [0] (t0mato@gateway/vpn/mullvad/t0mato) |
| 07:38:22 | | Quit akaWolf (Ping timeout: 260 seconds) |
| 07:48:47 | *** | Saving seen data "./dancer.seen" |
| 07:53:19 | | Join olspookishmagus [0] (~pookie@snf-137798.vm.okeanos.grnet.gr) |
| 07:57:57 | | Join massiveH [0] (~massiveH@ool-18e4e82f.dyn.optonline.net) |
| 07:58:01 | | Join MrZeus [0] (MrZeus@gateway/vpn/mullvad/mrzeus) |
| 08:00 |
| 08:48:21 | | Quit speachy (Quit: WeeChat 2.9) |
| 09:00 |
| 09:05:13 | | Quit massiveH (Quit: Leaving) |
| 09:48:51 | *** | Saving seen data "./dancer.seen" |
| 09:49:14 | | Quit Strife89 (Quit: No Ping reply in 180 seconds.) |
| 09:50:39 | | Join Strife89 [0] (~quassel@adsl-74-250-153-250.ags.bellsouth.net) |
| 10:00 |
| 10:19:25 | | Quit beencubed (Quit: Leaving) |
| 10:21:32 | | Join beencubed [0] (~beencubed@209.131.238.248) |
| 10:21:57 | | Join saratoga [0] (620acd42@cpe-98-10-205-66.rochester.res.rr.com) |
| 10:22:55 | saratoga | _bilgus__: images are resized on every load, but normally it is so fast it doesn't really matter |
| 10:24:53 | saratoga | resolution is tricky to use since the ipods are the slowest players and they have reasonably large screens |
| 10:25:35 | _bilgus__ | sure but that makes it that more important to limit to something reasonable |
| 10:26:47 | saratoga | maybe just an arbitrary 2 or 4MB limit |
| 10:26:59 | saratoga | thats small enough that the user will realize that the big file loads, but it takes a while |
| 10:27:11 | saratoga | then hopefully reconsider using such big files |
| 10:27:25 | _bilgus__ | maybe it can display a 'error' album cover |
| 10:28:27 | _bilgus__ | big red X |
| 10:41:18 | saratoga | that might be a little annoying though, since the wps gets reformatted to show less info for a problem the user might not care about |
| 11:00 |
| 11:11:08 | | Join J_Darnley [0] (~J_Darnley@d51A44418.access.telenet.be) |
| 11:11:25 | | Quit jdarnley (Ping timeout: 258 seconds) |
| 11:15:10 | | Join speachy [0] (~speachy@209.2.65.77) |
| 11:16:01 | | Quit Rower (Ping timeout: 246 seconds) |
| 11:21:48 | | Nick mendelmunkis is now known as mendel_munkis (~mendelmun@ool-435680b7.dyn.optonline.net) |
| 11:31:43 | | Quit livvy (Ping timeout: 240 seconds) |
| 11:48:55 | *** | Saving seen data "./dancer.seen" |
| 12:00 |
| 12:07:58 | | Join captainkewl [0] (60f13416@pool-96-241-52-22.washdc.fios.verizon.net) |
| 12:31:42 | | Join TheLemonMan [0] (~lemonboy@irssi/staff/TheLemonMan) |
| 12:39:04 | | Quit mendel_munkis (Ping timeout: 240 seconds) |
| 12:44:26 | | Join mendelmunkis [0] (~mendelmun@ool-435680b7.dyn.optonline.net) |
| 12:51:04 | | Join lebellium [0] (~lebellium@89-92-69-66.hfc.dyn.abo.bbox.fr) |
| 13:00 |
| 13:11:27 | | Join akaWolf [0] (~akaWolf@akawolf.org) |
| 13:48:59 | *** | Saving seen data "./dancer.seen" |
| 14:00 |
| 14:00:51 | | Join Rower [0] (~Rower@78-73-72-39-no2340.tbcn.telia.com) |
| 14:48:24 | | Quit captainkewl (Remote host closed the connection) |
| 15:00 |
| 15:00:30 | | Quit TheLemonMan (Quit: "It's now safe to turn off your computer.") |
| 15:14:41 | speachy | blbro[m]: hey, I have another request for the voice generation in rbutil. |
| 15:15:48 | speachy | blbro[m]: it looks like voice-corrections.txt is compiled into the binary; could we add a URL to (optionally?) retrieve a more updated version? |
| 15:17:45 | bluebrother^ | speachy: yes. I was also thinking about adding support for an updated rbutil.ini, i.e. use the internal one, and also try to download an updated version. Could use an url in build-info that points directly to cgit. |
| 15:18:23 | bluebrother^ | though right now I was considering to finish the few minor issues left and then push 1.5.0. |
| 15:18:32 | speachy | (hmm, or maybe include in the zip file..) |
| 15:18:54 | speachy | (... though it looks like it's not used by anythin gother than rbutil...) |
| 15:18:58 | bluebrother^ | then address things like that afterwards. As well as the ipodpatcher / sansapatcher elevation thing |
| 15:19:56 | speachy | _bilgus__: and it looks like the "invalid talk" thing isn't being generated properly in the zip files. |
| 15:19:57 | bluebrother^ | which is something I'd like to get done in the not-too-distant-future. |
| 15:20:43 | bluebrother^ | but given the updated bootloaders, player support and other internal changes a 1.5.0 before sounds like a good idea to me. |
| 15:22:42 | bluebrother^ | so we don't delay it too much longer. And the patcher thing might take a bit. |
| 15:22:50 | bluebrother^ | since we need to package things a bit differently then. |
| 15:22:54 | speachy | bluebrother^: should the contents of voicestrings.zip be under apps/lang/* ? |
| 15:23:58 | bluebrother^ | Yes. See voicefile.cpp:68 |
| 15:24:06 | bluebrother^ | well, not the contents, the zip file :) |
| 15:24:45 | speachy | the contents are in that directory too |
| 15:25:03 | speachy | so it would have to be extracted from the top-level .rockbox directory for the .vstrings to end up in apps/lang |
| 15:27:52 | bluebrother^ | looking at the code it ignores the structure of the zip, and only tries to match files <language>.* |
| 15:28:54 | bluebrother^ | ah. There's an additional talk file packaged, InvalidVoice_english.talk |
| 15:29:33 | speachy | that isn't supposed to be in there. I'm fixing that now |
| 15:29:41 | bluebrother^ | but that's in the zip file, not in the folder |
| 15:29:45 | bluebrother^ | ah, that explains things :) |
| 15:36:51 | fs-bluebot_ | Build Server message: New build round started. Revision e4b514917e, 293 builds, 9 clients. |
| 15:37:23 | speachy | I'm not terribly happy with this fix but it's good enough until we end up with multiple InvalidVoice files. |
| 15:37:57 | speachy | but the fact that voice-corrections.txt isn't actually used by anything other than rbutil concerns me. |
| 15:38:51 | speachy | oh wait, there it is, in voice.pl got lost in the noise |
| 15:49:02 | *** | Saving seen data "./dancer.seen" |
| 15:49:56 | fs-bluebot_ | Build Server message: Build round completed after 785 seconds. |
| 15:49:59 | fs-bluebot_ | Build Server message: Revision e4b514917e result: All green |
| 15:50:04 | fs-bluebot_ | Build Server message: New build round started. Revision 60139cf9f1, 293 builds, 9 clients. |
| 16:00 |
| 16:01:25 | speachy | bluebrother^: so as far as voice-corrections.txt is concerned, I can put it into the voicestrings.zip file easily enough; I think that makes more sense than hardcoding it into the rbutil binary |
| 16:02:18 | fs-bluebot_ | Build Server message: Build round completed after 734 seconds. |
| 16:02:20 | fs-bluebot_ | Build Server message: Revision 60139cf9f1 result: All green |
| 16:03:15 | bluebrother^ | hmm. Good point. Though I'm wondering if it would make more sense to download it, so we can have a more up-to-date version when creating the voice file. Though we could do both. |
| 16:03:35 | bluebrother^ | but then otoh we could use that for creating talk files too. Not sure if we already do that. |
| 16:03:52 | bluebrother^ | nope, we don't. |
| 16:04:25 | bluebrother^ | but since this is for correcting words to the tts gets them pronounced properly we might want something like that for talk files too |
| 16:04:52 | speachy | if it's fetched, I don't think there's any point in not getting it directly via cgit or whatever |
| 16:05:46 | speachy | You did say that you wanted voice generation to work without an internet connection |
| 16:06:02 | speachy | so that lends towards putting it into voicestrings.zip |
| 16:07:28 | bluebrother^ | ah, right. |
| 16:07:56 | bluebrother^ | well, we could have it in voicestrings.zip, and when we do have a working internet connection we can download an updated version via cgit. |
| 16:08:07 | bluebrother^ | and do the same thing for rbutil.ini |
| 16:08:35 | bluebrother^ | so we could add 2 more entries to build-info and simply have them urls point to cgit. |
| 16:13:22 | speachy | ok, I'll add those. under [general] or [rbutil] or something else? |
| 16:13:52 | speachy | general.rbutilini_url and general.voicecorrections_url ? |
| 16:14:26 | speachy | or other.* instead? |
| 16:18:17 | speachy | bluebrother^: It's in https://download.rockbox.org/build-info.extras now, let me know if you want it changed. |
| 16:18:58 | speachy | (will get pulled into top-level build-info on the next build) |
| 16:19:24 | fs-bluebot_ | Build Server message: New build round started. Revision 227ac2b715, 293 builds, 9 clients. |
| 16:19:25 | bluebrother^ | looks good :) |
| 16:19:40 | speachy | (and this build has voice-corrections plopped into voicestrings.zip) |
| 16:19:58 | bluebrother^ | I'll work on updating deploy.py first though. Really want to get things into a state where we can get rbutil 1.5.0 done |
| 16:21:00 | speachy | Once that's out we should seriously consder a hwcodec-less 4.0 release |
| 16:22:00 | speachy | bluebrother^: hmm, sapi_voice.vbs is also compiled in. |
| 16:22:16 | bluebrother^ | yes, but that basically never changes. |
| 16:22:38 | bluebrother^ | and its kinda part of the SAPI implementation. |
| 16:22:39 | speachy | not since 2012, anyway. :) |
| 16:23:18 | bluebrother^ | it's simpler to call a vbs to call the SAPI stuff instead of reimplementing things ourselves. iirc that would need to use COM ... |
| 16:23:58 | speachy | quite true! |
| 16:24:23 | fs-bluebot_ | Build Server message: Build round completed after 299 seconds. |
| 16:24:26 | fs-bluebot_ | Build Server message: Revision 227ac2b715 result: 387 errors 0 warnings |
| 16:24:43 | * | speachy raises an eyebrow. |
| 16:25:28 | speachy | should have done a clean build, d'oh. |
| 16:27:05 | fs-bluebot_ | Build Server message: New build round started. Revision b339400531, 293 builds, 9 clients. |
| 16:38:45 | fs-bluebot_ | Build Server message: Build round completed after 700 seconds. |
| 16:38:49 | fs-bluebot_ | Build Server message: Revision b339400531 result: All green |
| 16:53:22 | | Quit lebellium (Quit: Leaving) |
| 17:00 |
| 17:36:56 | | Quit pamaury (Ping timeout: 240 seconds) |
| 17:49:06 | *** | Saving seen data "./dancer.seen" |
| 18:00 |
| 18:08:52 | _bilgus__ | SPEACHY [RETTY SURE i JUST MADE THE FILE AND UPLOADED IT? |
| 18:09:27 | _bilgus__ | sorry caps lock :P |
| 18:10:17 | _bilgus__ | re invalid voice sorry gues sthat was a while ago |
| 18:48:27 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 19:00 |
| 19:28:50 | speachy | _bilgus__: yeah, it's clear neither of us tested it on a pristine player. :) |
| 19:37:32 | | Join cockroach [0] (~blattodea@pdpc/supporter/active/cockroach) |
| 19:49:08 | *** | No seen item changed, no save performed. |
| 20:00 |
| 20:07:44 | _bilgus__ | see I |
| 20:08:25 | _bilgus__ | 'm pretty sure I tried that (what your patch has) originally) |
| 20:11:11 | _bilgus__ | but maybe that was just because I screwed something up like that path |
| 20:13:10 | speachy | it was ending up in voicestrings.zip, with the full /path/to/build/directory/apps/lang in the zip file |
| 20:13:14 | | Quit ufdm (Remote host closed the connection) |
| 20:13:48 | | Join ufdm [0] (~ufdm@c-73-164-63-214.hsd1.mn.comcast.net) |
| 20:16:50 | _bilgus__ | well good thinmg you were on the case sorry you had to fix my bug. |
| 20:17:06 | speachy | ran into it while trying to check something else |
| 20:17:14 | speachy | one of those d'oh moments |
| 20:33:23 | _bilgus__ | just saw 3037 I think from this point forward we should just get rid of all this depreciated stuff and the versioning all together |
| 20:35:30 | _bilgus__ | maybe not the versioning persay but the strict ordering is no longer needed it should just be alphabetical at all times |
| 20:35:36 | speachy | I'd be okay with that, but I have been able to re-use un-deprecated strings in translations. |
| 20:36:03 | speachy | the language scripts sort everything alphabetically now |
| 20:36:23 | _bilgus__ | yeah the whole rock translation thing is the major breaking point |
| 20:37:07 | speachy | (or do they just mirror the english language ordering? I've already forgotten, despite rewriting the damn thing twice..) |
| 20:37:08 | | Join massiveH [0] (~massiveH@ool-18e4e82f.dyn.optonline.net) |
| 20:39:00 | _bilgus__ | I'm just saying we have (the now working) invalid voice thing and build voices with every build the rules kinda are no longer so rigid |
| 20:39:34 | _bilgus__ | ease of reading should be the only other concern now :p |
| 20:40:19 | speachy | ok, it uses the english ordering. (well, it can techinally use any language; english is un-hardcoded now) |
| 20:42:03 | speachy | that reminds me, I still need to make the voice generation scripts parallelizable |
| 20:42:09 | _bilgus__ | like adding new string at the end but I don't think some chunks for general versus plugins or other category (ies) is a bad idea either |
| 20:42:51 | speachy | I do like being able to logically group stuff together |
| 20:43:00 | _bilgus__ | that and the user: field I'm not sure that was ever even used anywhere |
| 20:43:06 | speachy | yeah, it's not. |
| 20:43:53 | _bilgus__ | do any of those voice engines use hints? |
| 20:44:14 | speachy | hihts? |
| 20:44:25 | _bilgus__ | like phonetic hints |
| 20:44:51 | speachy | well, there's the voice-corrections.txt stuff which I suppose fills that role |
| 20:45:02 | _bilgus__ | yeah after a failure |
| 20:45:40 | speachy | failure? it's just a pre-filter before passing the text to the TTS engine |
| 20:45:57 | speachy | or you mean falure requiring human correction |
| 20:45:58 | _bilgus__ | ahh so you tweak them till they sound right? |
| 20:46:09 | speachy | in theory |
| 20:46:15 | _bilgus__ | yeah the human part.. |
| 20:46:39 | speachy | except for the japanese stuff I cut'n'pasted in just now, I think it's only actually used to expand some common acronyms |
| 20:46:51 | _bilgus__ | that would be the only other field I might want to see in the list ratheer than user: |
| 20:47:26 | speachy | there's a bitrotten patch I saw that's intended to make CamelCase read out better |
| 20:50:28 | speachy | huh, g#3079 is interesting |
| 20:50:31 | fs-bluebot_ | Gerrit review #3079 at https://gerrit.rockbox.org/r/c/rockbox/+/3079 : list: reset viewport to avoid corrupting the text in the first line by Georg Gadinger |
| 20:51:33 | _bilgus__ | that sounds like a bug on my part |
| 20:54:03 | _bilgus__ | hmm no its set up right |
| 20:54:21 | _bilgus__ | I'm gonna have to dig into this one |
| 21:00 |
| 21:00:46 | _bilgus__ | yeah I'm missing how this is fixing the issue unless something like the scroll engine jumps in mid stroke |
| 21:07:27 | speachy | I saw somethign wonky today on my X3 −− I plugged in the player, it turned on, pulled up the USB action prompt |
| 21:07:55 | speachy | so far so good. except the prompt went away a moment later, and the prompt started scrolling |
| 21:08:11 | speachy | because the underlying line was one that needed to scroll |
| 21:08:44 | speachy | the scroll thread stuff definitely has some wonkiness going on |
| 21:15:46 | | Quit MrZeus (Ping timeout: 256 seconds) |
| 21:33:07 | _bilgus__ | thats gotta be it |
| 21:33:42 | _bilgus__ | though I'm not sure why we would be yielding to it without a sleep... |
| 21:46:42 | _bilgus__ | OHHH |
| 21:47:30 | _bilgus__ | struct viewport vp = *list_text_vp; |
| 21:49:03 | _bilgus__ | I wonder what the actual copy does with that assignment |
| 21:49:10 | *** | Saving seen data "./dancer.seen" |
| 22:00 |
| 22:01:38 | | Quit cockroach (Quit: leaving) |
| 22:06:33 | | Quit ac_laptop (Quit: WeeChat 3.0) |
| 22:06:52 | | Quit ecs (Remote host closed the connection) |
| 22:06:53 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 22:06:59 | | Join ecs [0] (esawady@d2evs.net) |
| 22:30:45 | _bilgus__ | hmm still no closer to figuring that out the assignment works properly I figured maybe it was a pointer issue but no the only other thing I see that flipping the viewport would be marking the previous vp as dirty |
| 22:31:28 | _bilgus__ | thus forcing a redraw but I'd expect that to happen as a matter of course anyway.. |
| 22:32:02 | _bilgus__ | guess I need to set up a situation where I can reproduce\ |
| 22:39:04 | | Quit ac_laptop (Ping timeout: 256 seconds) |
| 22:47:01 | | Quit Topy44 (Ping timeout: 264 seconds) |
| 22:53:08 | | Join Topy44 [0] (2X7a8Fkhq6@bellatrix.uberspace.de) |
| 23:00 |
| 23:30:37 | | Quit ungali (Quit: ungali) |
| 23:31:00 | | Join ungali [0] (~ungali@d198-53-36-180.abhsia.telus.net) |
| 23:31:00 | | Quit ungali (Changing host) |
| 23:31:00 | | Join ungali [0] (~ungali@unaffiliated/ungali) |
| 23:40:59 | | Nick Guest69432 is now known as alexbobp (~alex@meowface.org) |
| 23:47:25 | | Quit TheSeven (Disconnected by services) |
| 23:47:34 | | Join [7] [0] (~quassel@rockbox/developer/TheSeven) |
| 23:49:14 | *** | Saving seen data "./dancer.seen" |
icon identifies that the person is a core developer (has commit access).