Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2021-03-23

00:23:18chris_sThank you, Aidan, for the detailed report.
00:23:19chris_sThere is still a slight inconsistency now which also existed before 46085c897854. That is, you'll still get a warning when replacing a modified finished playlist, but *only* if you haven't restarted the player afterwards. I haven't done so for now, but it may make sense to get rid of this warning for a finished playlist completely?
00:26:24***Saving seen data "./dancer.seen"
00:47:48chris_sUnrelated to any of my changes:
00:47:48chris_sAnother inconsistency I'd kind of like to fix is with the different handling of files from the file browser and DB browser.
00:47:49chris_sA playlist will count as modified when selecting any item from the *DB* browser (because it automatically inserts each item), but only after you've resumed the playlist by stopping and restarting playback. The same is not true for a track selected in the file browser where it simply plays the folder but doesn't insert the individual tracks.
00:47:49DBUGEnqueued KICK chris_s
00:47:49chris_sAs a consequence, getting a modified-playlist-warning is actually a bit unpredictable. Also, after selecting an item to play from the file browser, "Insert" will add the next item after the currently playing track, whereas after selecting an item from the DB browser, "Insert" will add the next item after the last track.
00:56:04 Quit chris_s (Quit: Connection closed)
01:16:18 Quit daswf852 (Ping timeout: 245 seconds)
01:44:13 Quit ac_laptop (Ping timeout: 245 seconds)
02:14:20 Quit emacsomancer (Ping timeout: 265 seconds)
02:21:17 Join lebellium [0] (
02:26:12 Quit Moarc (Quit: i znowu NADMUCHAŁ BALONA)
02:26:27***Saving seen data "./dancer.seen"
02:27:07 Join Moarc [0] (
02:36:51 Join emacsomancer [0] (
03:00:17 Quit lebellium (Quit: Leaving)
03:19:24 Quit koniu (Ping timeout: 268 seconds)
04:00:19 Quit toruvinn (Ping timeout: 276 seconds)
04:08:45 Join petur [0] (~petur@rockbox/developer/petur)
04:26:30***Saving seen data "./dancer.seen"
04:41:45 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
04:52:23 Join toruvinn [0] (
05:44:42 Quit koniu (Remote host closed the connection)
05:45:27 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
06:06:31 Quit koniu (Ping timeout: 268 seconds)
06:08:44 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
06:17:14 Quit Stanley00 (Remote host closed the connection)
06:20:33 Join Stanley00 [0] (~stanley00@unaffiliated/stanley00)
06:21:19 Quit koniu (Ping timeout: 268 seconds)
06:23:06 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
06:26:33***Saving seen data "./dancer.seen"
06:55:34 Quit Stanley00 (Remote host closed the connection)
08:17:01speachychis_s: personally I think the "reset index to 0" after the playlist ends would make more sense.
08:17:42speachyI do wonder if the warning actually serves any useful purpose.
08:19:12speachy(because the playlist can only be modified by rockbox itself, from explicit user action..)
08:23:31 Join Stanley00 [0] (~stanley00@unaffiliated/stanley00)
08:26:36***Saving seen data "./dancer.seen"
08:28:50 Quit Stanley00 (Ping timeout: 264 seconds)
08:58:17fs-bluebot_Build Server message: New build round started. Revision e862816773, 293 builds, 10 clients.
09:03:15 Join Saijin_Naib [0] (
09:10:16fs-bluebot_Build Server message: Build round completed after 719 seconds.
09:10:18fs-bluebot_Build Server message: Revision e862816773 result: All green
09:10:34fs-bluebot_Build Server message: New build round started. Revision eedc8934a9, 293 builds, 10 clients.
09:21:01fs-bluebot_Build Server message: Build round completed after 627 seconds.
09:21:03fs-bluebot_Build Server message: Revision eedc8934a9 result: All green
09:28:01 Quit koniu (Remote host closed the connection)
09:28:32 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
09:44:12 Join daswf852 [0] (~daswf852@unaffiliated/dwf)
09:46:06 Join ac_laptop [0] (~ac_laptop@
09:57:39 Quit Saijin_Naib (Disconnected by services)
09:57:43 Join Saijin-Naib [0] (
10:03:19 Quit koniu (Ping timeout: 268 seconds)
10:09:26 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
10:26:38***Saving seen data "./dancer.seen"
10:26:57 Quit Saijin-Naib (Ping timeout: 260 seconds)
10:29:21 Join Stanley00 [0] (~stanley00@unaffiliated/stanley00)
10:33:23 Quit Stanley00 (Ping timeout: 245 seconds)
10:41:39 Join Stanley00 [0] (~stanley00@unaffiliated/stanley00)
10:45:56 Quit Stanley00 (Ping timeout: 240 seconds)
11:03:31 Join amachronic [0] (5284bbcf@
11:11:31amachronicchris_s: you're welcome. Over the past couple days I've had a couple problems and I think they may be related to the playlist changes you made recently.
11:12:05speachyamachronic: I committed his fix, if that's enough to consider the problem solved let's close out the bug
11:12:32amachronicspeachy: there's a few other issues I noticed
11:12:48amachronicI think commits 3b9a803a5b4f, 2d8e0f7c907e, and 576b56b35a2b might be the possible causes (for similar reasons)
11:13:08amachronicbut I can't be sure because it's maybe my own flaky M3K code.
11:14:10amachronicfor example I sometimes had an issue where the song would get loaded but not play, stuck at 0:00
11:14:43amachronicre-loading another album and then going back to the first album would fix that −− the original stuck song played fine.
11:15:21amachronicit's just intermittent though, I haven't yet tracked down a minimal test case.
11:22:05speachythat is most likely an audio issue
11:22:40speachyafter the initial audio buffers are filled the time counter doesn't move until the audio callbacks fire.
11:23:00speachywhich in turn is most likely an audio dma complete event getting lost (or never firing to begin with)
11:23:13amachronicsorry I meant the counter which shows the total time of the song.
11:23:27speachyah, nm then
11:23:32amachronicso instead of 3:23 or whatever it shows 0:00
11:24:06speachybtw I started on the review of the latest patch set. still have a lot of catgching up to after my ISP dropped for 4 days
11:25:09amachronicthanks, I'm looking forward to getting this merged
11:26:00speachythe I2C stuff should be sepearete IMO. and the fuelgauge stuff −− is that meant for the bootloader? (haven't got to that portion of the code yet)
11:26:07amachronicFYI, I am thinking the battery related stuff in fuelgauge.c etc. should probably be dropped for now and I'll just use the voltage ADC directly.
11:26:48speachyprobably for the best.
11:26:50amachronicI went into using the coulomb counters without understanding the problems with them, and after doing some research I think it will need more work.
11:28:55amachronicI'll definitely get the I2C factored out and push a separate change for it
11:35:34 Quit tomato (Ping timeout: 245 seconds)
11:35:47 Quit mud (Ping timeout: 246 seconds)
11:35:57 Quit aevin_ (Ping timeout: 264 seconds)
11:36:28 Quit fauweh (Ping timeout: 265 seconds)
11:37:10 Quit ccf-100 (Ping timeout: 244 seconds)
11:37:13 Quit danielp3344 (Ping timeout: 258 seconds)
11:37:41 Quit M-iam-some0nee[m (Ping timeout: 244 seconds)
11:37:41 Quit kadoban (Ping timeout: 244 seconds)
11:37:42 Join aevin [0] (eivindsy@unaffiliated/aevin)
11:37:56 Quit blbro[m] (Ping timeout: 240 seconds)
11:38:11 Quit skrzyp (Ping timeout: 265 seconds)
11:38:15 Quit xcin (Ping timeout: 246 seconds)
11:38:45 Quit kadobanana (Ping timeout: 268 seconds)
11:38:47 Join fauweh [0] (
11:38:59 Join skrzyp [0] (
11:39:42 Join chris_s [0] (
11:47:15 Join xcin [0] (~x@
11:48:30 Quit xcin (Read error: Connection timed out)
11:48:57 Join tomato [0] (t0mato@gateway/vpn/mullvad/tomato)
11:49:23 Quit Huntereb (Ping timeout: 272 seconds)
11:50:28 Join mud [0] (kadobanmat@gateway/shell/
11:52:16 Join xcin [0] (~x@
11:58:42chris_samachronic: It's possible that inserting into a stopped playlist would have
11:58:42chris_sproduced such an effect for some reason, since other parts of the code may not have
11:58:43chris_sexpected that to happen.
11:58:43DBUGEnqueued KICK chris_s
11:58:43chris_sThat was basically the major functional change and is the only thing I could think
11:58:44chris_sof right now.
11:58:44***Alert Mode level 1
11:58:44chris_sSince that user option has now been removed (on Mar 16), the issue may have
11:58:44***Alert Mode level 2
11:58:44chris_sdisappeared as well (if it had anything to do with it).
11:58:45***Alert Mode level 3
11:58:45chris_sThe remaining changes seem unlikely to have such an effect.
11:58:45***Alert Mode level 4
11:58:45chris_sI haven't run into an issue personally, using Rockbox quite a bit recently.
11:58:46***Alert Mode level 5
11:58:46chris_sI'll be sure to take another look at my changes with your recent report in mind.
11:58:47***Alert Mode level 6
11:58:47chris_sPlease let me know if you continue to encounter the problem you described!
12:04:44 Join ccf-100 [0] (ccf-100mat@gateway/shell/
12:06:46 Join danielp3344 [0] (danielp334@gateway/shell/
12:08:48***Alert Mode OFF
12:12:57 Join M-iam-some0nee[m [0] (m-iam-some@gateway/shell/
12:14:46 Join kadoban [0] (kadobanemp@gateway/shell/
12:22:49 Join blbro[m] [0] (blbrostrat@gateway/shell/
12:25:09 Join kadobanana [0] (kadoban9he@gateway/shell/
12:26:42***Saving seen data "./dancer.seen"
12:38:03amachronicchris_s: if I manage to find the cause of this, I'll be sure to let you know. The reason I think those specific commits might be an issue is maybe minor changes around how/when playlist_resume() gets called. didn't check carefully though, so maybe it's something flaky I did.
12:38:40 Join Huntereb [0] (
12:39:55 Quit Huntereb (Read error: Connection reset by peer)
12:41:19 Join Saijin_Naib [0] (
12:42:55 Join Huntereb [0] (
12:44:46 Quit petur (Read error: Connection reset by peer)
13:00:39 Quit chris_s (Quit: Connection closed)
13:04:59 Quit St3ak (Quit: Free ZNC ~ Powered by LunarBNC:
13:11:38 Join St3ak [0] (
13:14:28 Quit koniu (Remote host closed the connection)
13:15:10 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
13:16:10 Quit amachronic (Quit: Connection closed)
13:22:59 Quit koniu (Remote host closed the connection)
13:23:29 Join koniu [0] (~koniu@gateway/tor-sasl/koniu)
14:24:44 Join lebellium [0] (
14:26:44***Saving seen data "./dancer.seen"
14:59:13 Quit J_Darnley (Ping timeout: 245 seconds)
15:05:16 Join J_Darnley [0] (
15:27:56 Join PimpiN8 [0] (~PimpiN8@
15:34:32 Join f1refly [0] (
16:26:46***Saving seen data "./dancer.seen"
16:48:15 Quit ac_laptop (Ping timeout: 240 seconds)
17:09:38 Quit Huntereb (Ping timeout: 264 seconds)
17:10:46 Join Huntereb [0] (
17:30:09 Join dweeber [0] (
17:48:49 Quit PimpiN8 (Quit: My MacBook has gone to sleep. ZZZzzz…)
17:57:38 Quit lebellium (Quit: Leaving)
18:09:43 Join ac_laptop [0] (~ac_laptop@
18:26:48***Saving seen data "./dancer.seen"
18:48:53 Quit berber (Quit: The Lounge -
18:49:21 Join berber [0] (
19:18:38 Quit Saijin_Naib (Ping timeout: 264 seconds)
19:49:50 Join Saijin_Naib [0] (
20:26:51***Saving seen data "./dancer.seen"
20:33:45 Join ufdm_ [0] (
20:34:13 Quit ufdm (Ping timeout: 245 seconds)
20:37:09 Quit ufdm_ (Client Quit)
20:37:14 Quit ats (Ping timeout: 264 seconds)
20:59:30fs-bluebot_Build Server message: New build round started. Revision 94b40ed314, 293 builds, 10 clients.
21:10:08fs-bluebot_Build Server message: Build round completed after 637 seconds.
21:10:11fs-bluebot_Build Server message: Revision 94b40ed314 result: All green
21:38:25 Quit Saijin_Naib (Disconnected by services)
21:38:29 Join Saijin-Naib [0] (
22:09:52 Quit Saijin-Naib (Ping timeout: 260 seconds)
22:26:53***Saving seen data "./dancer.seen"
22:59:41 Join ufdm [0] (
23:08:32 Join ats [0] (
23:16:29 Join f1reflyylmao [0] (
23:19:05 Quit f1refly (Ping timeout: 272 seconds)
23:19:05 Nick f1reflyylmao is now known as f1refly (

Previous day | Next day