| 00:05:44 | *** | Saving seen data "./dancer.seen" |
| 00:57:02 | _bilgus | amachronic |
| 00:57:26 | _bilgus | O gotta ask what am I missing for running the sim in valgrind |
| 00:58:22 | _bilgus | make_context(): Operation not permitted |
| 00:58:22 | _bilgus | Thread creation failed. Retryingm |
| 01:00 |
| 01:00:54 | braewoods | _bilgus: which version of rockbox can be compiled for regular PCs? sdl? |
| 01:00:58 | braewoods | variant* |
| 01:01:25 | braewoods | i'm working on creating linux packaging for SDL and rbutil |
| 01:06:40 | _bilgus | yeah pretty sure the sim is aswell |
| 01:07:37 | braewoods | though if i'm being honest the only part that makes sense to build is rbutil |
| 01:07:48 | braewoods | SDL, we don't normally provide builds for |
| 01:44:04 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:acbc:75df:5b9f:d3eb) |
| 01:45:16 | | Nick mikroflops_ is now known as mikroflops (~yogurt@c188-150-217-176.bredband.comhem.se) |
| 02:00 |
| 02:00:06 | | Quit ac_laptop (Quit: WeeChat 3.0) |
| 02:05:48 | *** | Saving seen data "./dancer.seen" |
| 03:00 |
| 03:07:41 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 03:12:02 | | Quit dconrad (Ping timeout: 246 seconds) |
| 04:00 |
| 04:05:51 | *** | Saving seen data "./dancer.seen" |
| 04:50:29 | | Quit fauweh (Ping timeout: 248 seconds) |
| 04:50:59 | | Quit hook54321 (Ping timeout: 248 seconds) |
| 04:52:04 | | Quit kadobanana (Ping timeout: 248 seconds) |
| 04:52:55 | | Join hook54321 [0] (sid149355@gateway/web/irccloud.com/x-yowuzbrikpmmzknf) |
| 05:00 |
| 05:02:59 | | Join fauweh [0] (~root@ithaqua.unzane.com) |
| 05:30:52 | | Join kadobanana [0] (kadoban9he@gateway/shell/matrix.org/x-wrfgidxkulkzvtcl) |
| 05:31:00 | | Quit ufdm (Read error: Connection reset by peer) |
| 05:38:06 | | Join ufdm [0] (~ufdm@c-73-164-63-214.hsd1.mn.comcast.net) |
| 05:52:41 | | Quit Barlow (Ping timeout: 246 seconds) |
| 05:54:38 | | Join Barlow [0] (~barlow@17-215-201-31.ftth.glasoperator.nl) |
| 05:54:38 | | Quit Barlow (Changing host) |
| 05:54:38 | | Join Barlow [0] (~barlow@unaffiliated/barlow) |
| 06:00 |
| 06:05:53 | *** | Saving seen data "./dancer.seen" |
| 06:06:42 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 06:09:06 | | Quit nast (Ping timeout: 240 seconds) |
| 06:40:14 | speachy | _bilgus: apps/gui/bitmap/list.c L198 |
| 06:40:24 | speachy | and L206 |
| 06:45:09 | speachy | we set the viewport to one allocated on the stack, but we access it out-of-scope later when we set_viewport() to something else on L219 |
| 06:47:22 | speachy | because we end up setting VP_FLAG_DIRTY in last_viewport->flags |
| 06:49:27 | speachy | in this context the problem is most likely benign but this pattern could easily be an real issue elsewhere |
| 07:00 |
| 07:02:14 | fs-bluebot | Build Server message: New build round started. Revision 8b56476a2c, 298 builds, 10 clients. |
| 07:02:38 | speachy | that's fixed in this ^^ build but I'm trying to find other stuff that fits the pattern |
| 07:08:19 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 07:13:11 | | Quit dconrad (Ping timeout: 260 seconds) |
| 07:15:11 | fs-bluebot | Build Server message: Build round completed after 776 seconds. |
| 07:15:13 | fs-bluebot | Build Server message: Revision 8b56476a2c result: All green |
| 07:20:25 | speachy | I think rectrigger() and alarm_screen() are similarly afflicted; along with chunks of recording_screen() and gui_syncpitchscreen_run() |
| 07:20:59 | speachy | and some stuff in plugins/ that I didn't dig into yet |
| 07:56:38 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 08:00 |
| 08:05:57 | *** | Saving seen data "./dancer.seen" |
| 08:07:49 | | Join chris_s [0] (5fdf48b5@ip-95-223-72-181.hsi16.unitymediagroup.de) |
| 08:12:04 | chris_s | speachy: By the way,re FS #13281, the problem with calling playlist_resume() within ft_enter() before playing a track from a directory , if another directory had been playing before shutting down, was due to the fact that resume_directory() calls ft_build_playlist() which modifies the same tree context that ft_enter() is called with to cache the |
| 08:12:04 | chris_s | tracks from the previously played directory. |
| 08:12:05 | fs-bluebot | https://www.rockbox.org/tracker/task/13281 Problems playing the first song after player turned on (bugs, closed) |
| 08:12:05 | chris_s | So, after the previous playlist is resumed, ft_build_playlist() is called with a tree_context whose contents have changed completely. |
| 08:12:05 | DBUG | Enqueued KICK chris_s |
| 08:12:05 | chris_s | Seems a bit strange/unexpected to me that resume_directory() would have that side effect of changing the tree context, but it's likely I don't understand the code well enough yet. |
| 08:20:39 | | Join MrZeus_ [0] (~MrZeus@2a02:c7f:a0aa:4400:88be:ae23:ad19:afe2) |
| 08:38:37 | | Quit dconrad (Remote host closed the connection) |
| 08:40:08 | | Quit chris_s (Quit: Connection closed) |
| 08:44:55 | | Join massiveH [0] (~massiveH@ool-18e4e82f.dyn.optonline.net) |
| 08:49:09 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 08:58:25 | | Quit dconrad (Remote host closed the connection) |
| 09:00 |
| 09:10:02 | _bilgus | speachy nice catch! |
| 09:50:02 | _bilgus | speachy I don't like that side effect at all |
| 09:52:25 | _bilgus | maybe a better way would be to hold a dirty_vp list and just check for the address |
| 10:00 |
| 10:05:58 | *** | Saving seen data "./dancer.seen" |
| 10:08:46 | | Join amachronic [0] (5284ba3e@82.132.186.62) |
| 10:09:15 | amachronic | _bilgus: Valgrind doesn't like the sigaltstack gymnastics, you need to pass −−sdl-threads to configure |
| 10:18:28 | speachy | honestly we're better off ditching sigalstacks for all sdl-based builds |
| 10:19:02 | speachy | (and hosted builds too IMO) |
| 10:20:53 | speachy | chris_s: at this point, you know a lot more about how that convoluted code works than I do |
| 10:20:57 | amachronic | It seems really odd to me, if Rockbox can run with normal threads then why do exotic tricks? |
| 10:21:48 | speachy | the short version is that... it doesn't. |
| 10:22:09 | speachy | the uisim/hosted code emulates what the native code does |
| 10:22:49 | amachronic | ie. to emulate the cooperative threading model? |
| 10:22:59 | speachy | IIRC even the SDL threading code doesn't actually use "native" SDL threads |
| 10:23:04 | speachy | yeah |
| 10:23:22 | speachy | which I think in turn was an offshoot of the limitations of the original archos targets |
| 10:24:43 | speachy | heh, I wonder how much of a PITA it would be to replace our "kernel" with FreeRTOS. |
| 10:26:02 | amachronic | I took a peek at freeRTOS lately, but switching would probably involve rewriting a lot of the firmware/application interface. Not sure there's any real gains to be had. |
| 10:27:04 | speachy | I don't think it would come to that; for the most part the applications run in "primary thread" context. |
| 10:27:31 | speachy | but it would require rejiggering the low-level startup/irq code on nearly every port |
| 10:28:01 | speachy | and I'd bet we could easily wrap the native FreeRTOS API with a compatibility shim. |
| 10:28:06 | amachronic | yeah in addition to porting all the target-specific code to fit FreeRTOS framework. |
| 10:28:23 | speachy | (It's been a few years now, but I did extensively use FreeRTOS in the 2011-2015 timeframe) |
| 10:29:27 | amachronic | does it have stuff like dynamic libraries? (which we'd need for plugins, codecs, etc) |
| 10:30:10 | speachy | no, but that doesn't matter |
| 10:30:55 | | Quit massiveH (Quit: Leaving) |
| 10:31:24 | speachy | we don't use dynamic/relocatable stuff either. codecs/plugins get linked assuming a fixed memory address. |
| 10:37:45 | amachronic | Odd, looks like that fix you pushed has got rid of the pictureflow segfault. |
| 10:38:24 | speachy | well, awesome. that wasn't waht I was looking to solve but it does make sense |
| 10:38:34 | amachronic | gotta test now on the real device and see if that's causing the hang. |
| 10:40:05 | speachy | pretty sure there are more issues along the same lines, but fixing them is more involved. |
| 10:42:40 | fs-bluebot | Build Server message: New build round started. Revision da542020c4, 298 builds, 10 clients. |
| 10:48:05 | _bilgus | what if we had a viewport generator then converted the code to work on a principal you ask for your viewport you get a handle you release your handle it gets returned to the pool |
| 10:48:51 | _bilgus | you forget to release your handle its in a list and gets an error |
| 10:49:47 | speachy | _bilgus: g#3299 is my naive fix for two of the remaining issues |
| 10:49:50 | fs-bluebot | Gerrit review #3299 at https://gerrit.rockbox.org/r/c/rockbox/+/3299 : RFC: Fix a couple more dangling stack-allocated viewports by Solomon Peachy |
| 10:50:53 | speachy | braewoods: did you actually test the changes you made in g#3296 ? |
| 10:50:55 | fs-bluebot | Gerrit review #3296 at https://gerrit.rockbox.org/r/c/rockbox/+/3296 : ipodpatcher: fix warning for apple stop sign constant by James Buren |
| 10:51:18 | speachy | (ie make sure it successfully patches a random ipod firmware file or two) |
| 10:52:25 | speachy | In the immortal words of Donald Knuth, "Beware of bugs in the above code; I have only proved it correct, not tried it." |
| 10:54:43 | speachy | also any further comments on g#3229 would be appreciated.. |
| 10:54:44 | fs-bluebot | Gerrit review #3229 at https://gerrit.rockbox.org/r/c/rockbox/+/3229 : Allow Softlock to happen in most contexts by Dana Conrad |
| 10:54:48 | fs-bluebot | Build Server message: Build round completed after 727 seconds. |
| 10:54:50 | fs-bluebot | Build Server message: Revision da542020c4 result: All green |
| 10:54:55 | speachy | (and preferably, testing..) |
| 10:55:29 | _bilgus | there is probably at least one more in the skin engine −− though I did focus on that area pretty heavily |
| 10:56:57 | amachronic | I might've spoke too soon. I still get a hang on native M3K, but it seems to be a soft hang of the main thread only. |
| 10:57:29 | _bilgus | the only reason I limnited the scope in the first place was to match the code it was replacing, originally the concern was the extra processing in other contexts would drain battery for something most people didn't use |
| 10:57:31 | amachronic | Simulator is OK when I tried with 3 albums, but when I loaded up my whole collection I managed to get valgrind to complain after a bit, but it's different this time |
| 10:58:24 | _bilgus | re 3229 |
| 11:00 |
| 11:01:24 | _bilgus | amachronic, ha I've been trying to get that to work since like a year ago |
| 11:01:31 | _bilgus | valgrind on the sim |
| 11:02:19 | speachy | gcc/clang's AddressSanitizer is also quite useful, and a lot lighter weight than valgrind |
| 11:02:46 | speachy | it's what found that viewport problem in the list scrollbar code |
| 11:03:45 | amachronic | posted details in my comment on #FS13283. |
| 11:04:30 | speachy | it too has issues with the sigal threads |
| 11:10:45 | _bilgus | any reason it couldn't be enabled in all sim builds? |
| 11:11:16 | speachy | you mean force SDL threads on and also addresssanitizer? |
| 11:11:24 | _bilgus | yep |
| 11:11:52 | _bilgus | make the sim a much more useful dev item |
| 11:11:53 | speachy | it requires GCC 4.8+ |
| 11:12:04 | speachy | but we already use 4.9+ for the targets so.. |
| 11:12:16 | speachy | I guess I can force it on and see what the fallout is like. |
| 11:12:22 | _bilgus | maybe even catch that damn theme bug |
| 11:14:51 | _bilgus | ha I was looking for it and there we go FS #12639 |
| 11:15:08 | _bilgus | with the −−sdl-threads and valgrind lol |
| 11:26:18 | _bilgus | I went ahead and made a forum post for when I forget again |
| 11:31:38 | _bilgus | amachronic, that looks like someone blew the allocation table |
| 11:32:15 | _bilgus | buflib stores data about blocks within the allocations I bet thats a stackovfl in pf |
| 11:55:05 | | Part edhelas |
| 11:55:35 | | Join edhelas [0] (9d94237298@2a03:4000:51:f44:4e1:2ff:fe00:4257) |
| 12:00 |
| 12:05:59 | *** | Saving seen data "./dancer.seen" |
| 12:17:46 | _bilgus | g#3300 pretty sure thats a long standing bug |
| 12:17:47 | fs-bluebot | Gerrit review #3300 at https://gerrit.rockbox.org/r/c/rockbox/+/3300 : menu.c submenu items should be limited to MAX_MENU_SUBITEMS by William Wilgus |
| 12:19:51 | _bilgus | 64 menu items should be enough for anyone but I just ran into it yesterday trying to load the list of actions in a menu |
| 12:22:11 | fs-bluebot | Build Server message: New build round started. Revision c5cf15ed02, 298 builds, 10 clients. |
| 12:22:19 | speachy | seens sane. |
| 12:32:44 | fs-bluebot | Build Server message: Build round completed after 633 seconds. |
| 12:32:46 | fs-bluebot | Build Server message: Revision c5cf15ed02 result: All green |
| 12:48:28 | | Quit akaWolf (Ping timeout: 268 seconds) |
| 13:00 |
| 13:11:33 | | Join lebellium [0] (~lebellium@89-92-69-66.hfc.dyn.abo.bbox.fr) |
| 13:20:42 | | Quit amachronic (Quit: Connection closed) |
| 13:42:35 | | Join akaWolf [0] (~akaWolf@unaffiliated/akawolf) |
| 14:00 |
| 14:06:02 | *** | Saving seen data "./dancer.seen" |
| 14:39:52 | fs-bluebot | Build Server message: New build round started. Revision 213d372c92, 298 builds, 10 clients. |
| 14:47:07 | | Join amachronic [0] (5284b987@82.132.185.135) |
| 14:50:30 | fs-bluebot | Build Server message: Build round completed after 639 seconds. |
| 14:50:33 | fs-bluebot | Build Server message: Revision 213d372c92 result: All green |
| 15:00 |
| 15:28:04 | | Quit pamaury (Quit: No Ping reply in 180 seconds.) |
| 15:31:19 | | Join pamaury [0] (~pamaury@rockbox/developer/pamaury) |
| 15:54:47 | | Quit amachronic (Quit: Connection closed) |
| 15:55:29 | | Join Saijin_Naib [0] (~Saijin_Na@2603-7081-1d05-7230-286d-6961-1df9-2252.res6.spectrum.com) |
| 16:00 |
| 16:06:06 | *** | Saving seen data "./dancer.seen" |
| 16:23:48 | fs-bluebot | Build Server message: New build round started. Revision 4b26372591, 298 builds, 10 clients. |
| 16:25:15 | braewoods | speachy: how could I? I don't own an ipod unit |
| 16:26:55 | braewoods | huh. why is it marked tested? |
| 16:33:36 | | Quit Barlow (Quit: leaving) |
| 16:34:39 | fs-bluebot | Build Server message: Build round completed after 653 seconds. |
| 16:34:41 | fs-bluebot | Build Server message: Revision 4b26372591 result: All green |
| 16:37:15 | | Join Barlow [0] (~barlow@unaffiliated/barlow) |
| 16:43:06 | | Quit prg3 (Ping timeout: 260 seconds) |
| 17:00 |
| 17:01:12 | | Quit Saijin_Naib (Remote host closed the connection) |
| 17:04:27 | fs-bluebot | Build Server message: New build round started. Revision 1b82ebc6e4, 298 builds, 10 clients. |
| 17:15:10 | fs-bluebot | Build Server message: Build round completed after 643 seconds. |
| 17:15:12 | fs-bluebot | Build Server message: Revision 1b82ebc6e4 result: All green |
| 17:18:37 | | Quit Acou_Bass (Quit: ZNC 1.8.2 - https://znc.in) |
| 17:19:18 | | Join PimpiN8 [0] (~PimpiN8@178.239.173.176) |
| 17:20:56 | | Join Acou_Bass [0] (~Acou_Bass@cpc96070-bolt17-2-0-cust175.10-3.cable.virginm.net) |
| 17:29:17 | | Join MrZeus__ [0] (~MrZeus@185.206.227.137) |
| 17:32:35 | | Quit MrZeus_ (Ping timeout: 260 seconds) |
| 17:36:07 | | Quit lebellium (Quit: Leaving) |
| 18:00 |
| 18:05:12 | | Join Saijin_Naib [0] (~Saijin_Na@2603-7081-1d05-7230-bc4d-e601-df82-64fd.res6.spectrum.com) |
| 18:05:14 | | Quit Saijin_Naib (Read error: Connection reset by peer) |
| 18:05:22 | | Join Saijin_Naib [0] (~Saijin_Na@2603-7081-1d05-7230-bc4d-e601-df82-64fd.res6.spectrum.com) |
| 18:06:07 | *** | Saving seen data "./dancer.seen" |
| 18:07:05 | | Join ac_laptop [0] (~ac_laptop@186.2.247.129) |
| 18:16:27 | | Join cockroach [0] (~blattodea@pdpc/supporter/active/cockroach) |
| 18:21:09 | | Quit ZincAlloy (Quit: Leaving.) |
| 18:32:35 | | Quit Saijin_Naib (Ping timeout: 250 seconds) |
| 18:42:03 | | Quit PimpiN8 (Quit: Textual IRC Client: www.textualapp.com) |
| 19:00 |
| 19:00:45 | | Quit kakaka (Ping timeout: 240 seconds) |
| 19:02:13 | | Join kakaka [0] (~koniu@gateway/tor-sasl/koniu) |
| 19:19:16 | | Join Saijin_Naib [0] (~Saijin_Na@2603-7081-1d05-7230-2c90-1042-2fbd-9b65.res6.spectrum.com) |
| 19:53:33 | | Quit pamaury (Ping timeout: 260 seconds) |
| 19:54:12 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 20:00 |
| 20:01:39 | | Join MrZeus_ [0] (~MrZeus@2a02:c7f:a0aa:4400:88be:ae23:ad19:afe2) |
| 20:05:31 | | Quit MrZeus__ (Ping timeout: 260 seconds) |
| 20:06:09 | *** | Saving seen data "./dancer.seen" |
| 20:17:55 | | Quit MrZeus_ (Ping timeout: 248 seconds) |
| 20:24:45 | | Quit kakaka (Ping timeout: 240 seconds) |
| 21:00 |
| 21:13:11 | | Quit ac_laptop (Ping timeout: 240 seconds) |
| 21:39:08 | | Quit Saijin_Naib (Ping timeout: 258 seconds) |
| 21:44:20 | | Quit cockroach (Quit: leaving) |
| 21:49:54 | fs-bluebot | Build Server message: New build round started. Revision d2f694696f, 298 builds, 10 clients. |
| 22:00 |
| 22:01:19 | fs-bluebot | Build Server message: Build round completed after 686 seconds. |
| 22:01:21 | fs-bluebot | Build Server message: Revision d2f694696f result: All green |
| 22:01:24 | fs-bluebot | Build Server message: New build round started. Revision f8ce18c286, 298 builds, 10 clients. |
| 22:06:10 | *** | Saving seen data "./dancer.seen" |
| 22:12:58 | fs-bluebot | Build Server message: Build round completed after 694 seconds. |
| 22:13:00 | fs-bluebot | Build Server message: Revision f8ce18c286 result: All green |
| 22:37:10 | | Join f1reflyylmao [0] (~f1refly@2a01:c23:8833:af00:fc00:8fd4:3b6a:9a06) |
| 22:39:39 | | Quit f1refly (Ping timeout: 260 seconds) |
| 22:39:39 | | Nick f1reflyylmao is now known as f1refly (~f1refly@2a01:c23:8833:af00:fc00:8fd4:3b6a:9a06) |
| 23:00 |
| 23:00:01 | | Join prg3 [0] (~prg@deadcodersociety/prg318) |
| 23:04:06 | | Quit atsampson (Ping timeout: 246 seconds) |
| 23:26:45 | | Quit dconrad (Remote host closed the connection) |
| 23:31:13 | | Join dconrad [0] (~dconrad@208.38.228.17) |
icon identifies that the person is a core developer (has commit access).