| 01:00 |
| 01:00:16 | DEBUG | EOF from server (Success) (snapshot: netstuff.c line 545) |
| 01:00:16 | *** | Cleanup |
| 01:00:16 | *** | Cleanup |
| 01:00:16 | *** | No seen item changed, no save performed. |
| 01:00:16 | *** | Exit |
| 01:00:16 | *** | Started Dancer V4.16 |
| 01:00:16 | *** | Connected to irc.libera.chat on port 6667 |
| 01:00:16 | *** | Logfile for #rockbox started |
| 01:00:18 | Mode | "rb-logbot :+i" by rb-logbot |
| 01:00:24 | *** | Server message 501: 'rb-logbot :Unknown MODE flag' |
| 01:00:24 | | Join rb-logbot [0] (~rockbox@stuffed.shaftnet.org) |
| 01:00:24 | | Join funman_ [0] (~fun@chui-pas.net) |
| 01:00:24 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 01:00:24 | | Join akaWolf [0] (~akaWolf@akawolf.org) |
| 01:00:24 | | Join Romster [0] (~romster@user/romster) |
| 01:00:24 | | Join advcomp2019 [0] (~advcomp20@user/advcomp2019) |
| 01:00:24 | | Join tchan [0] (~tchan@c-98-206-141-238.hsd1.il.comcast.net) |
| 01:00:24 | | Join Maxdamantus [0] (~Maxdamant@user/maxdamantus) |
| 01:00:24 | | Join Retr0id [0] (~Retr0id@user/retr0id) |
| 01:00:24 | | Join Airwave [0] (~Airwave@ti0006a400-1599.bb.online.no) |
| 01:00:24 | | Join Galois [0] (djao@efnet.math.uwaterloo.ca) |
| 01:00:24 | | Join bertrik [0] (~bertrik@revspace/participant/bertrik) |
| 01:00:24 | | Join bluebrother [0] (~dom@55d4dc16.access.ecotel.net) |
| 01:00:24 | | Join amiconn [0] (jens@p2e55b6bb.dip0.t-ipconnect.de) |
| 01:00:24 | | Join aquijoule__ [0] (~richbridg@213-225-7-126.nat.highway.a1.net) |
| 01:00:24 | | Join JanC [0] (~janc@user/janc) |
| 01:00:24 | | Join pablocastellanos [0] (~pidgin@user/pablocastellanos) |
| 01:00:24 | | Join j-r [0] (~j-r@p5df2ecee.dip0.t-ipconnect.de) |
| 01:00:24 | | Join ufdm [0] (~ufdm@c-73-164-63-214.hsd1.mn.comcast.net) |
| 01:00:24 | | Join yosafbridge [0] (~yosafbrid@static.38.6.217.95.clients.your-server.de) |
| 01:00:24 | | Join desowin [0] (~linux@rockbox/developer/desowin) |
| 01:00:24 | | Join pixelma [0] (marianne@p2e55b6bb.dip0.t-ipconnect.de) |
| 01:00:24 | | Join F3l1x_10m [0] (~Al3x_10m@user/f3l1x-10m/x-3393542) |
| 01:00:24 | | Join spork [0] (topic@31-151-2-135.dynamic.upc.nl) |
| 01:00:24 | | Join dbohdan [0] (~dbohdan@user/dbohdan) |
| 01:00:24 | | Join SammysHP [0] (~SammysHP@faol.sammyshp.de) |
| 01:00:24 | | Join CasBot [0] (~matrixbot@connolly.tech) |
| 01:00:24 | | Join ats [0] (~ats@cartman.offog.org) |
| 01:00:24 | | Join Topy44 [0] (kdqScR72dZ@bellatrix.uberspace.de) |
| 01:00:24 | | Join +speachy [0] (~speachy@rockbox/developer/speachy) |
| 01:00:24 | | Join reductum [0] (~reductum@cpe-72-134-86-174.natsow.res.rr.com) |
| 01:00:24 | | Join emacsomancer [0] (~emacsoman@c-174-52-88-123.hsd1.ut.comcast.net) |
| 01:00:24 | | Join kadoban [0] (~kadoban@user/kadoban) |
| 01:00:24 | | Join Natch [0] (~natch@c-e070e255.014-297-73746f25.bbcust.telenor.se) |
| 01:00:24 | | Join olspookishmagus [0] (~pookie@snf-137798.vm.okeanos.grnet.gr) |
| 01:00:24 | | Join braewoods [0] (~braewoods@user/braewoods) |
| 01:00:24 | | Join gsora [0] (~gsora@140.238.174.213) |
| 01:00:24 | | Join ddevault [0] (znc@sourcehut/staff/ddevault) |
| 01:00:24 | | Join XDjackieXD [0] (~jackie@banana-new.kilobyte22.de) |
| 01:00:24 | | Join Guest9931 [0] (~leachim6@neptune.cosmicforge.org) |
| 01:00:24 | | Join Guest5135 [0] (~scorche@184-98-25-134.phnx.qwest.net) |
| 01:00:24 | | Join TorC [0] (~Tor@fsf/member/TorC) |
| 01:00:24 | | Join gevaerts [0] (~fg@user/gevaerts) |
| 01:00:24 | | Join user890104 [0] (~Venci@freemyipod/user890104) |
| 01:00:24 | | Join Arsen [0] (~arsen@managarm/dev/Arsen) |
| 01:00:24 | | Join Rondom [0] (~rondom@user/rondom) |
| 01:00:24 | | Join rudi_s [0] (~simon@user/rudi-s/x-7673890) |
| 01:00:24 | | Join aevin [0] (eivindsy@microbel.pvv.ntnu.no) |
| 01:00:24 | | Join jbgg_ [0] (~jbgg@95.179.159.229) |
| 01:00:24 | | Join Xeha [0] (~Xeha@dynamic-82-220-88-142.ftth.solnet.ch) |
| 01:00:24 | | Join vup [0] (~~~~@46.101.193.235) |
| 01:00:24 | | Join hook54321 [0] (sid149355@user/hook54321) |
| 01:00:24 | | Join wisperwind [0] (~quassel@user/wisperwind) |
| 01:00:24 | | Join _bilgus [0] (~bilgus@162.154.213.134) |
| 01:00:24 | | Join benjaoming [0] (~benjaomin@37.139.19.237) |
| 01:00:24 | | Join toruvinn [0] (~toruvinn@77-255-90-179.adsl.inetia.pl) |
| 01:00:24 | | Join rasher [0] (~rasher@user/rasher) |
| 01:00:24 | | Join markun [0] (~markun@178-84-100-63.dynamic.upc.nl) |
| 01:00:24 | | Join rogeliodh [0] (~rogeliodh@rogeliodh.dev) |
| 01:00:24 | | Join __builtin [0] (~quassel@rockbox/developer/builtin) |
| 01:00:24 | | Join michaelni [0] (~michael@213-47-68-29.cable.dynamic.surfer.at) |
| 01:00:24 | | Join Bobathan [0] (~admin@cpe-65-29-248-157.wi.res.rr.com) |
| 01:00:24 | | Join dys [0] (~dys@user/dys) |
| 01:00:24 | | Join f1refly [0] (~f1refly@pd954c410.dip0.t-ipconnect.de) |
| 01:00:24 | | Join asaba [0] (~asabas@103.113.159.184) |
| 01:00:24 | | Join rb-bluebot [0] (~rb-bluebo@rockbox/bot/utility) |
| 01:00:24 | | Join blbro[m] [0] (~blbrostra@2001:470:69fc:105::8f7) |
| 01:00:24 | | Join tomato [0] (~tomato@user/tomato) |
| 01:00:24 | | Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) |
| 01:00:24 | | Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) |
| 01:00:24 | | Join danwellby [0] (~danwellby@88.97.8.245) |
| 01:00:24 | | Join Ckat [0] (~Ckat@xn--z7x.xn--6frz82g) |
| 01:00:26 | | Join ParkerR [0] (~ParkerR@znc.withg.org) |
| 01:00:34 | | Join kirvesAxe [0] (kirvesaxe@user/kirvesaxe) |
| 01:17:07 | braewoods | g#3567 |
| 01:17:09 | rb-bluebot | Gerrit review #3567 at https://gerrit.rockbox.org/r/c/rockbox/+/3567 : zip: implement zip extraction support by James Buren |
| 01:17:46 | braewoods | it tests ok so far. i think it will cause some problems for ports where modtime isn't yet available but that should be easily remedied. |
| 02:00 |
| 02:35:23 | | Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de) |
| 02:52:51 | | Quit munkis (Remote host closed the connection) |
| 02:53:15 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 03:00 |
| 03:00:18 | *** | Saving seen data "./dancer.seen" |
| 03:16:13 | | Quit ZincAlloy (Quit: Leaving.) |
| 03:19:43 | | Join lebellium [0] (~lebellium@2a01:cb10:2e:2000:a5f1:9e7:7890:b2d2) |
| 04:00 |
| 04:25:44 | | Quit blbro[m] (Quit: Bridge terminating on SIGTERM) |
| 04:25:47 | | Quit kadoban (Quit: Bridge terminating on SIGTERM) |
| 04:28:19 | | Join kadoban [0] (~kadoban@user/kadoban) |
| 04:34:37 | | Join blbro[m] [0] (~blbrostra@2001:470:69fc:105::8f7) |
| 04:45:43 | | Join mendel_munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 04:45:58 | | Quit munkis (Killed (lithium.libera.chat (Nickname regained by services))) |
| 04:45:58 | | Nick mendel_munkis is now known as munkis (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 05:00 |
| 05:00:22 | *** | Saving seen data "./dancer.seen" |
| 05:47:03 | | Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de) |
| 05:47:23 | | Quit ZincAlloy (Client Quit) |
| 05:47:32 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:f18b:877:3b86:12d7) |
| 07:00 |
| 07:00:23 | *** | Saving seen data "./dancer.seen" |
| 07:15:06 | | Join amachronic [0] (~amachroni@user/amachronic) |
| 07:30:00 | _bilgus | braewoods you ready to push that? |
| 07:54:16 | | Quit f1refly (Quit: see ya in hell) |
| 07:56:37 | | Join f1refly [0] (~f1refly@pd954c410.dip0.t-ipconnect.de) |
| 08:00 |
| 08:01:09 | braewoods | _bilgus: more or less. i just mentioned the one compile issue that may arise. for unix ports they may need an implementation of modtime. easiest option is to wrap utime and set both fields to the mtime value provided. |
| 08:01:44 | _bilgus | k, guess we will see where it falls |
| 08:03:16 | _bilgus | oh you have a comment from amachronic? |
| 08:03:43 | braewoods | yea, stuff i can address in another commit. |
| 08:04:17 | braewoods | i was aliasing path and name so i could append to the proper position |
| 08:04:26 | braewoods | it was a small time optimization |
| 08:04:40 | braewoods | avoid recopying the same initial segment |
| 08:04:47 | braewoods | that doesn't change |
| 08:05:30 | _bilgus | ok so good then? |
| 08:05:33 | braewoods | as for the error codes? i don't see much value in documenting them because i was leaning towards using a unique one |
| 08:05:35 | braewoods | afaik |
| 08:05:50 | braewoods | for each one so i can know which one triggered the return |
| 08:06:02 | amachronic | ^^^ that's why I don't care so much about naming them |
| 08:06:21 | braewoods | it seemed a standard rockbox practice |
| 08:06:40 | braewoods | in any case, negative values have a special case in callbacks here |
| 08:06:54 | braewoods | they mean "skip to next file" or so. |
| 08:07:08 | braewoods | 0 means continue as normal |
| 08:07:18 | braewoods | positive are error codes for the callbacks |
| 08:07:29 | braewoods | negatives are error codes for the regular zip code |
| 08:07:55 | amachronic | okay, so that's why that one call to zip->cb ignores the negative case. makes sense now |
| 08:08:26 | braewoods | i was trying for a trinary system of sorts |
| 08:08:41 | braewoods | while still giving some kind of meaning to them |
| 08:09:12 | rb-bluebot | Build Server message: New build round started. Revision 8846e087c0, 297 builds, 8 clients. |
| 08:09:29 | _bilgus | got it I put your comment into the reply |
| 08:10:35 | braewoods | i plan to enlarge my data buffer for the data reading later to better support DEFLATE |
| 08:10:45 | braewoods | main issue is figuring out the ratio |
| 08:10:52 | braewoods | of the in/out buffer |
| 08:11:06 | braewoods | so worst case won't be too big for out buffer |
| 08:11:53 | braewoods | i'm already using ~65k for the first major read i do |
| 08:11:57 | braewoods | temporarily |
| 08:12:02 | _bilgus | wont processor speed be the biggest factor for ratio? |
| 08:12:28 | _bilgus | like a slower processor would o better with a larger ratio to the out buffer? |
| 08:12:30 | braewoods | _bilgus: no, as in, given X input how much space will the Y output consume |
| 08:12:56 | braewoods | i found one weakness of the tinflate option is |
| 08:13:15 | braewoods | if your output buffer isn't large enough, it'll just discrd the rest and finish processing the input |
| 08:13:40 | braewoods | so if i want to use it, i need to size the buffers so that doesn't happen |
| 08:14:09 | braewoods | thing is i never stopped to think about the best case ratio for deflate is |
| 08:14:27 | braewoods | i'd guess 90% is a bit high |
| 08:14:28 | _bilgus | ah so that would be rather deleterious to the whole thing |
| 08:14:51 | braewoods | indeed and there's some issues with inflate algorithms for embedded |
| 08:15:03 | braewoods | many of them require the whole thing to be in ram, not ideal... |
| 08:15:24 | braewoods | others have limits like this |
| 08:15:25 | _bilgus | so is it such a state where you could make due with a circular buffer |
| 08:16:01 | _bilgus | start in buffer fill it use the remain for out then roll over if needed |
| 08:16:01 | braewoods | eh, probably if i could trick it into flushing the buffer instead of cannibalizing it |
| 08:16:24 | braewoods | the trouble is finding a way to make the inflate algorithm resumeable |
| 08:16:30 | braewoods | or so |
| 08:16:47 | braewoods | i either need to use an in memory one i can force refill or flush with as needed or |
| 08:17:19 | braewoods | a resumeable one |
| 08:17:42 | braewoods | just tinflate as written only allows the input this luxury |
| 08:17:59 | braewoods | i realized i could reset the output position between calls so reuse the same buffer |
| 08:18:05 | braewoods | but it would still discard stuff |
| 08:18:22 | braewoods | unless i could size them such that overflow never happens |
| 08:18:26 | braewoods | or gets discarded |
| 08:18:29 | _bilgus | ha |
| 08:18:32 | _bilgus | :P |
| 08:18:37 | braewoods | yea, fat chance. |
| 08:18:43 | braewoods | i could handle the typical |
| 08:18:45 | braewoods | but |
| 08:18:49 | braewoods | it's still just guessing. |
| 08:19:12 | _bilgus | well given the crc you could at least know when it failed |
| 08:19:12 | braewoods | i would prefer same sized buffers and just flush when i run out |
| 08:19:33 | braewoods | well it returns the actual size is would have written |
| 08:19:39 | _bilgus | ah ok |
| 08:19:42 | braewoods | you can compare to know if it discarded |
| 08:20:10 | _bilgus | that would be decent enough |
| 08:20:26 | braewoods | i've been running out of options so this hack was looking like my only option |
| 08:20:40 | braewoods | i was going to test out zopfli and see the best ratio i can get on some basic datais |
| 08:20:42 | braewoods | is |
| 08:20:46 | _bilgus | its what makes embedded fun |
| 08:20:56 | _bilgus | or 'fun' |
| 08:21:14 | rb-bluebot | Build Server message: Build round completed after 723 seconds. |
| 08:21:19 | rb-bluebot | Build Server message: Revision 8846e087c0 result: 0 errors 180 warnings |
| 08:21:26 | braewoods | what's the warning |
| 08:21:42 | braewoods | i mean where's the log |
| 08:22:27 | amachronic | https://build.rockbox.org/dev.cgi |
| 08:23:45 | braewoods | app_modtime |
| 08:23:54 | braewoods | why is strlcpy not defined? |
| 08:24:05 | braewoods | huh |
| 08:24:10 | braewoods | anyway let me write app_modtime |
| 08:26:48 | _bilgus | sim_modtime too |
| 08:27:10 | _bilgus | oh what was it with strlcpy uh strncpy |
| 08:27:53 | braewoods | strlcpy. it's different. |
| 08:28:02 | braewoods | it's defined on native yet not these other? |
| 08:28:07 | amachronic | it's not quite standard afaik |
| 08:28:22 | _bilgus | idk I just rem thats what was in already |
| 08:28:52 | braewoods | it's available on BSD |
| 08:28:56 | braewoods | but not Linux |
| 08:29:12 | braewoods | i chose it because it's faster than snprintf |
| 08:29:27 | braewoods | for simple stuff |
| 08:29:50 | braewoods | well one problem at a time |
| 08:31:28 | _bilgus | i think strn is more common than strl |
| 08:31:50 | braewoods | it is... but it has some nasty gotchas |
| 08:32:07 | braewoods | i'll look into a solution in a bit. |
| 08:32:16 | braewoods | i just thought rockbox already has a solution to this issue |
| 08:32:52 | _bilgus | I think we just used n with some 'careful' handling |
| 08:33:16 | braewoods | it also has one major inefficiency |
| 08:33:30 | braewoods | unused parts of the string are zero padded beyond the null |
| 08:33:34 | braewoods | why is beynd me |
| 08:34:25 | _bilgus | we know why |
| 08:34:37 | braewoods | why? |
| 08:35:48 | _bilgus | to try and prevent unbounded strings |
| 08:40:57 | braewoods | g#3568 |
| 08:40:59 | rb-bluebot | Gerrit review #3568 at https://gerrit.rockbox.org/r/c/rockbox/+/3568 : filesystem: implement os_modtime for unix by James Buren |
| 08:41:02 | braewoods | this should fix some of those |
| 08:41:28 | braewoods | it may also need win32, i'm not sure yet how important that is |
| 08:41:43 | braewoods | since most dev work is unix based |
| 08:50:35 | rb-bluebot | Build Server message: New build round started. Revision fa743258ea, 297 builds, 8 clients. |
| 08:51:00 | braewoods | but i think i found my way to do that |
| 08:51:10 | braewoods | i'll see what this next round produces |
| 08:51:56 | braewoods | if i convert the times back to dostime i can use the win32 api to convert it to the modern times it uses |
| 08:52:13 | braewoods | i don't know what format it uses so this is probably the fastest solution |
| 08:52:54 | _bilgus | windows should have an api for unix time directly |
| 08:53:19 | braewoods | it does? where i wonder |
| 08:53:46 | braewoods | All I found was SetFileTime() |
| 08:54:32 | _bilgus | ah its just trivial, https://stackoverflow.com/questions/3585583/convert-unix-linux-time-to-windows-filetime |
| 08:55:47 | _bilgus | that windows 100 ns comes up alot |
| 08:56:13 | _bilgus | their audio API WASAPI uses that as the timing base |
| 09:00 |
| 09:00:25 | *** | Saving seen data "./dancer.seen" |
| 09:00:40 | spork | amachronic: i just wrote that i have had no sd card issues with the q1, but i have it too |
| 09:01:35 | spork | on a 32GB samsung evo card |
| 09:02:12 | spork | selecting 'start rockbox' from the bootmenu works fine afterwards |
| 09:02:34 | amachronic | lol |
| 09:02:37 | rb-bluebot | Build Server message: Build round completed after 723 seconds. |
| 09:02:40 | rb-bluebot | Build Server message: Revision fa743258ea result: 0 errors 145 warnings |
| 09:02:43 | amachronic | is it intermittent or does it happen every time? |
| 09:04:56 | spork | intermittent |
| 09:05:24 | spork | so far only after i have claimed not to have the problem |
| 09:07:14 | | Join tomato5 [0] (~tomato@user/tomato) |
| 09:07:38 | _bilgus | ah heisenbugs |
| 09:08:03 | spork | schrodingers sd csrd |
| 09:08:05 | amachronic | i wonder what is causing it... short of block-level trace and verifying each data transfer I have no idea how to debug it further |
| 09:08:25 | | Quit tomato (Ping timeout: 256 seconds) |
| 09:08:26 | | Nick tomato5 is now known as tomato (~tomato@user/tomato) |
| 09:08:30 | amachronic | it at least happens almost every time with my 256gb card. |
| 09:08:39 | braewoods | _bilgus: g#3569 |
| 09:08:41 | rb-bluebot | Gerrit review #3569 at https://gerrit.rockbox.org/r/c/rockbox/+/3569 : zip: include string-extra.h by James Buren |
| 09:09:00 | spork | maybe boost power during boot ? |
| 09:09:03 | braewoods | no wait... |
| 09:09:07 | spork | if there is such a thing |
| 09:09:29 | amachronic | weirdly, if I re-read the firmware twice, the problem goes away |
| 09:09:42 | amachronic | like the first read fails but the 2nd read will succeed |
| 09:09:55 | amachronic | but there's no low-level error from the 1st read... |
| 09:10:41 | braewoods | there we go |
| 09:10:43 | braewoods | that should do it |
| 09:10:49 | _bilgus | braewoods, what are you using from string-extra.h? |
| 09:10:56 | braewoods | _bilgus: strlcpy? |
| 09:11:04 | braewoods | the source for it is compiled |
| 09:11:09 | braewoods | i checked the build log |
| 09:11:18 | braewoods | so |
| 09:11:24 | braewoods | all i should need to do is include the header |
| 09:11:33 | _bilgus | strlcpy.h |
| 09:11:37 | _bilgus | ? |
| 09:11:47 | braewoods | yea but everything else includes string-extra.h |
| 09:11:53 | _bilgus | ah ok |
| 09:12:28 | braewoods | well i stand corrected, some include i some don't |
| 09:12:31 | braewoods | it's a bit weird |
| 09:12:36 | _bilgus | is anything in core doing that though? |
| 09:12:45 | braewoods | no |
| 09:12:55 | braewoods | only string-extra.h headr |
| 09:13:00 | _bilgus | in core I'd think you'd only want to tie the v. minimum |
| 09:13:39 | braewoods | in general though it makes no difference to runtime |
| 09:13:43 | _bilgus | let me look at the differences in implementation maybe we can bring in strlcpy to core and make it also strncpy |
| 09:14:03 | braewoods | erm, they work fundamentally differently |
| 09:14:11 | braewoods | different return types as well |
| 09:14:28 | _bilgus | depends on how much code.. |
| 09:14:34 | braewoods | strncpy will leave the buffer non-terminated if there's insufficient space |
| 09:14:50 | braewoods | and it zero-pads |
| 09:15:09 | braewoods | ok... this was just the quick fix i found |
| 09:15:42 | _bilgus | eh nm its not much code we can afford it |
| 09:16:31 | _bilgus | but just do strlcpy.h we don't want to encourage all that other in core, well its already there so I used it |
| 09:16:54 | braewoods | well i was just following what i saw. |
| 09:16:56 | * | braewoods shrugs. |
| 09:17:04 | braewoods | as you wish |
| 09:17:29 | _bilgus | just trying to save the next you :) |
| 09:18:22 | braewoods | there |
| 09:18:48 | braewoods | _bilgus: i'm considering adding fast versions of crc algorithms we have in core for ports that can afford to spend the space |
| 09:19:05 | braewoods | at least in the main firmware. bootloader probably should stick to the space optimized onee. |
| 09:19:06 | _bilgus | now that strlcpy is there I will be adding it to the damned plugin API :) |
| 09:19:25 | braewoods | you can also add modtime if you want |
| 09:19:35 | braewoods | i'm not ready for the zip api to be added yet |
| 09:19:37 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 09:19:52 | rb-bluebot | Build Server message: New build round started. Revision 1298e47134, 297 builds, 8 clients. |
| 09:20:31 | braewoods | i just try to optimize my string handling where i can do so; it's one of the most common recurring inefficiencies :D |
| 09:20:35 | _bilgus | probably not modtime not general enough |
| 09:21:32 | braewoods | one example, using information from previous string runs can save time |
| 09:21:50 | braewoods | one thing i always hated about fgets is it gives no clue where the index of the newline is |
| 09:22:05 | braewoods | so you need to scan it yourself to remove it if that matters |
| 09:22:19 | braewoods | that's about the only flaw of the function |
| 09:22:34 | braewoods | one reason to use getline. |
| 09:23:31 | braewoods | _bilgus: how does one fix the simulator? i was assuming it would be using the OS apis. |
| 09:23:56 | _bilgus | i think it uses stubs? |
| 09:24:46 | _bilgus | FS_PREFIX(modtime) |
| 09:25:03 | _bilgus | you need to use that macro |
| 09:25:27 | _bilgus | it adda app_ and sim_ |
| 09:25:32 | _bilgus | adds* |
| 09:26:46 | | Quit tomato (Read error: Connection reset by peer) |
| 09:26:57 | braewoods | _bilgus: that was added in the initial implementation |
| 09:28:15 | _bilgus | did you also use it in the function def? |
| 09:28:51 | braewoods | no, because that's only used in the header macro to change which one is used. |
| 09:29:08 | braewoods | the unix one is called os_modtime |
| 09:29:14 | braewoods | the native one is modtime |
| 09:29:19 | braewoods | etc |
| 09:29:48 | braewoods | i try to follow established usage because that's usually correct |
| 09:29:50 | _bilgus | eh give me a few |
| 09:31:21 | braewoods | just grep for FS_PREFIX |
| 09:31:36 | rb-bluebot | Build Server message: Build round completed after 704 seconds. |
| 09:31:38 | rb-bluebot | Build Server message: Revision 1298e47134 result: 0 errors 57 warnings |
| 09:31:39 | braewoods | it's not used in any source other than the plugin one so it the functions get mapped correctly |
| 09:33:28 | braewoods | ok looks like simulator is the last one to fix |
| 09:35:46 | _bilgus | https://github.com/Rockbox/rockbox/blob/master/uisimulator/common/filesystem-sim.h |
| 09:36:12 | braewoods | yea i see it |
| 09:37:16 | _bilgus | now do you need to map it in the c file too IDK yet |
| 09:37:59 | braewoods | i will unless i'm willing to reuse os_modtime |
| 09:38:28 | braewoods | ... this is the weirdest while loop conditional i've ever seen |
| 09:38:32 | braewoods | while (8675309) |
| 09:38:38 | braewoods | line 1147, dircache.c |
| 09:38:56 | braewoods | why 8675309? most use 1 or true for infinite loops |
| 09:39:28 | _bilgus | wtf |
| 09:39:46 | braewoods | it appears to be a reference to this |
| 09:39:52 | braewoods | https://en.wikipedia.org/wiki/867-5309/Jenny |
| 09:41:07 | _bilgus | ha probably a way to see who has copied it |
| 09:41:27 | _bilgus | found your number on a bathroom stall |
| 09:42:00 | _bilgus | 8675309inine |
| 09:42:19 | spork | codepilot is calling jenny right now |
| 09:43:17 | _bilgus | if that thing could actually integrate disparate codebases itd be something, rn its a copypasta machine |
| 09:43:34 | braewoods | _bilgus: i can't see anything in here that would require us to wrap the os version. |
| 09:43:48 | braewoods | since i don't open the file handle |
| 09:44:00 | braewoods | but i guess for convention we should |
| 09:44:03 | _bilgus | the sim has no need for space considerations |
| 09:44:23 | _bilgus | idk your choice |
| 09:44:43 | braewoods | working on it |
| 09:44:44 | _bilgus | probably more portable to lock in your own |
| 09:45:08 | | Join tomato [0] (~tomato@user/tomato) |
| 09:46:44 | braewoods | looks like it wraps it for mapping paths |
| 09:48:56 | braewoods | _bilgus: g#3570 |
| 09:48:58 | rb-bluebot | Gerrit review #3570 at https://gerrit.rockbox.org/r/c/rockbox/+/3570 : uisimulator: implement sim_modtime by James Buren |
| 09:50:22 | rb-bluebot | Build Server message: New build round started. Revision d6dcb99684, 297 builds, 8 clients. |
| 09:50:40 | braewoods | _bilgus: i noticed crc32 is also used during normal runtime by rockbox by buflib. so there's some benefit to speeding it up. |
| 09:51:10 | braewoods | depends how often it's called but dynamic allocations tend to be common |
| 09:51:16 | _bilgus | in normal rb sure but be careful of bootloaders |
| 09:51:38 | braewoods | indeed, i was planning to keep the slower version for a default and only enable a faster one where we know it's safe |
| 09:51:46 | _bilgus | have you compiled with test plugins yet? |
| 09:51:55 | braewoods | not yet |
| 09:52:16 | _bilgus | it'll allow you to quantify that |
| 09:52:25 | braewoods | i'll be benchmarking it to see how much of a difference it makes |
| 09:52:53 | braewoods | but if the full lookup table that takes ~900 more bytes adds a significant boost |
| 09:53:01 | braewoods | we should probably enable it for targets that can afford it |
| 09:53:01 | _bilgus | I do add stuff to those plugins when testing but rarely update them unless its warranted |
| 09:53:30 | braewoods | and for a fair comparison i'll also need to cpu boost |
| 09:53:31 | _bilgus | like shortcutting to specific tests |
| 09:53:58 | _bilgus | most of them have the option or do boosted/unboosted |
| 09:54:34 | braewoods | i noticed that some BLs have no effective limit on space |
| 09:54:39 | braewoods | notably PP since it resides on disk |
| 09:54:52 | braewoods | on the regular FS with rockbox |
| 09:55:03 | braewoods | so for those we could probably enable it under all circumstances |
| 09:55:35 | _bilgus | I try not to touch bootloaders without compelling reason |
| 09:55:38 | braewoods | but by default i plan to keep the SPACE optimized version unless we know otherwise |
| 09:56:05 | braewoods | i generally don't but all changes made to core have this potential to impact them |
| 09:56:23 | _bilgus | indeed :) |
| 09:56:41 | braewoods | hopefully LTO will mitigate that by being able to omit unused code |
| 09:56:49 | braewoods | removed at link time |
| 09:57:40 | braewoods | we still need a win32 modtime but it's pretty rare we build that |
| 09:58:02 | braewoods | i'll work on it later when i can actually test it properly |
| 09:58:08 | braewoods | i know unix well enough to know this is sufficient |
| 09:58:21 | _bilgus | its been so long that I have programmed in windows |
| 09:58:32 | braewoods | i can make it work. |
| 09:58:40 | _bilgus | even used it for that matter |
| 09:58:40 | braewoods | i'll just need to test in wine |
| 10:00 |
| 10:05:43 | rb-bluebot | Build Server message: Build round completed after 921 seconds. |
| 10:05:46 | rb-bluebot | Build Server message: Revision d6dcb99684 result: All green |
| 10:07:52 | _bilgus | woot |
| 10:08:39 | braewoods | now we can begin using it, for non-compressed ZIP files |
| 10:09:08 | braewoods | they say you can use zlib if you strip it... |
| 10:09:15 | braewoods | but is that really true? |
| 10:13:42 | braewoods | huh with -Os, normaly zlib takes up 80KB |
| 10:13:59 | braewoods | still pretty fat |
| 10:40:23 | rb-bluebot | Build Server message: New build round started. Revision 84362141a0, 297 builds, 9 clients. |
| 10:52:28 | rb-bluebot | Build Server message: Build round completed after 725 seconds. |
| 10:52:30 | rb-bluebot | Build Server message: Revision 84362141a0 result: All green |
| 11:00 |
| 11:00:28 | *** | Saving seen data "./dancer.seen" |
| 11:43:24 | dconrad | amachronic, I'm going to try out the bootloader, I think I should be able to use usbboot to try it out before writing it to nand, is that right? |
| 11:43:58 | amachronic | yeah try with USB boot and use the 'bootloader backup' first |
| 11:44:12 | amachronic | did you try doing a nanddump from OF linux yet? |
| 11:44:25 | dconrad | should be stage 1 spl.erosq, stage 2 bootloader.bin? |
| 11:44:29 | amachronic | yep |
| 11:44:30 | dconrad | no, I haven't tried that |
| 11:44:44 | dconrad | whats the process on that again? |
| 11:45:31 | dconrad | I've been completely avoiding anything to do with bootloaders haha |
| 11:45:35 | amachronic | you'd have to rig up a script to call nanddump |
| 11:45:38 | amachronic | https://www.rockbox.org/wiki/ShanlingQ1Port |
| 11:45:47 | amachronic | wiki page has an example of nanddump script |
| 11:45:49 | dconrad | oh I see |
| 11:46:40 | amachronic | idk can you run scripts from the "bootloader" on the Linux version of rockbox? like the m3k xvortex bootloader |
| 11:47:14 | dconrad | huh, it claims you can |
| 11:47:23 | dconrad | I suppose I'll try that |
| 11:47:42 | amachronic | it's a very good idea, just in case I screwed up the flash code yet again |
| 11:48:02 | dconrad | I mean at this point it seems like a low probability, but yeah safety first |
| 11:48:30 | dconrad | ... apparently it has adb as well? that's neat |
| 11:48:49 | amachronic | plus, you need to know the NAND layout to figure out where you can flash the Rockbox bootloader. |
| 11:49:27 | dconrad | oh, yeah there's no guarantee it's the same, is there |
| 11:50:28 | amachronic | given the eros q uses u-boot, I highly suspect the "empty space" that's normally used is occupied by u-boot. |
| 12:00 |
| 12:01:42 | dconrad | it looks like the bootloader can't run those scripts correctly for some reason - I might try the method you list for the Q1 |
| 12:02:16 | dconrad | what's that magic a35c2bg0suw= file? where on earth does that string come from? |
| 12:03:44 | amachronic | oh, that comes from the Q1's firmware |
| 12:04:04 | amachronic | it's their super secret magic word :P |
| 12:04:14 | dconrad | darn |
| 12:04:41 | dconrad | hmm, suppose I should try to figure out why the scripts aren't working in the bootloader then |
| 12:04:42 | amachronic | well are you able to run ANY scripts? it's possible you're missing the nanddump command |
| 12:04:58 | dconrad | they claim they run, but just return "2" immediately |
| 12:05:14 | dconrad | I wonder if I can echo stuff to the screen |
| 12:05:29 | amachronic | that won't work but you can echo foo > /path/to/file |
| 12:08:23 | dconrad | yeah, even that doesn't seem to work. I wonder if I have the wrong path to the sd card... |
| 12:14:33 | | Quit Natch (Remote host closed the connection) |
| 12:17:33 | dconrad | oh, is this a permissions thing I wonder |
| 12:18:24 | dconrad | I mean... it's a fat formatted card, and the rockbox binary obviously runs from it, so it shouldn't have any issue, right? |
| 12:19:24 | amachronic | it seems the firmwares tend to mount FAT with RWX permissions, but maybe yours is an exception |
| 12:20:50 | amachronic | using ext2/3/4 might work |
| 12:21:06 | dconrad | yeah, I might have to try that |
| 12:21:57 | dconrad | pull another card out of the pile haha |
| 12:32:56 | dconrad | hmm, it actually looks like it doesn't support ext3...? |
| 12:33:25 | dconrad | or, at least it can't read the files I put on there |
| 12:37:18 | dconrad | dconrad.neocities.org/assorted_files/helloworld.sh">https://dconrad.neocities.org/assorted_files/helloworld.sh, https://dconrad.neocities.org/assorted_files/kernelmessages.sh, and https://dconrad.neocities.org/assorted_files/nanddump.sh |
| 12:38:07 | dconrad | speachy, do you know anything about running scripts on the eros q bootloader? any gotchas? |
| 12:38:31 | dconrad | I'm not actually sure what the path to the card should be either |
| 12:40:51 | amachronic | if all else fails, you could build a custom rockbox and call system() to run each command |
| 12:42:38 | dconrad | does rockbox run as root? I think it would need to, right? |
| 12:43:05 | amachronic | it should |
| 12:44:31 | dconrad | hm, that might be the thing to do then |
| 12:47:09 | | Join Natch [0] (~natch@c-e070e255.014-297-73746f25.bbcust.telenor.se) |
| 13:00 |
| 13:00:29 | *** | Saving seen data "./dancer.seen" |
| 13:02:59 | dconrad | aha, it's located at /mnt/sd_0/ |
| 13:10:58 | dconrad | there we go, now we're makin progress |
| 13:11:10 | dconrad | got the rootfs and dmesg dumped |
| 13:15:52 | dconrad | amachronic, are there really 9 /dev/mtd*? this only seems to list mtd0 - mtd5 in my filesystem listing |
| 13:19:26 | dconrad | I would have figured for the same chip, it should have the same number of mtd* |
| 13:28:40 | dconrad | total size of 128 MiB |
| 13:32:43 | | Quit jschwart (Read error: Connection reset by peer) |
| 13:33:00 | | Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) |
| 13:50:16 | | Join mendel_munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 13:50:47 | amachronic | dconrad: the number of mtd partitions is all up to the OF |
| 13:51:09 | dconrad | ok, just seems weird it wouldn't match, given its the same hardware |
| 13:51:38 | dconrad | but that's all that's there, so I suppose it should be correct |
| 13:51:59 | amachronic | it's not much different to partitioning a hard disk, it's all software. As long as what you got adds up to 128MB it has to be correct. |
| 13:52:11 | dconrad | ok, cool |
| 13:53:23 | | Quit munkis (Ping timeout: 268 seconds) |
| 13:57:06 | dconrad | thanks for the review btw, I think I'll get that stuff changed since it's all small stuff, and then try to rebase/get a bootloader working |
| 14:00 |
| 14:22:17 | spork | amachronic: that yes/no thing works ok everywhere for me, except the prompt to create a bookmark |
| 14:22:25 | spork | where else does it not work for you ? |
| 14:24:17 | amachronic | at least the first 'create database' prompt, I had it a handful of other times. I think it may be due to some absolute pointing / 3x3 mode conflict. |
| 14:24:45 | amachronic | maybe your problem is different then, like a queued button or touch. |
| 14:24:52 | spork | the yes/no thing has its own logic |
| 14:25:06 | spork | bottom half of the screen and left/right half for yes and no |
| 14:25:28 | spork | pretty much like those pretty rectangles it draws |
| 14:25:31 | amachronic | yeah, and I had a very hard time pressing *either* of the buttons, which is a bit opposite to your issue. |
| 14:26:02 | spork | ok, i will poke it a bit. gui stuff at least i understand |
| 14:26:27 | amachronic | anyhow I uploaded an 'official' bootloader and I'm going to work on some other odds and ends so this can finally be merged |
| 14:27:31 | spork | uploaded to be used in install instructions later ? |
| 14:27:54 | amachronic | not a binary yet, just the source |
| 14:28:04 | spork | saw that commit yes |
| 14:29:02 | spork | jztool needs some help before that can be used |
| 14:29:25 | spork | but i got your point about non-official bootloaders |
| 14:30:43 | amachronic | that's also because I am trying to maintain a semblance of forward and backward compatibility. |
| 14:31:09 | amachronic | so daily builds don't suddenly break with an older bootloader, or vice versa |
| 14:32:22 | amachronic | still, the worst that would happen is you need to use jztool again to reinstall so it's mostly to avoid a nuisance to everyone. |
| 14:33:24 | spork | mine boots, usually well, so i am quite happy as it is |
| 14:35:26 | amachronic | glad to hear it |
| 14:36:02 | spork | been playing jewels way too much |
| 15:00 |
| 15:00:32 | *** | Saving seen data "./dancer.seen" |
| 15:19:13 | | Quit amachronic (Quit: amachronic) |
| 15:30:17 | | Join mendel_munkis_ [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 15:30:25 | | Nick mendel_munkis_ is now known as munkis (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
| 15:33:10 | | Quit mendel_munkis (Ping timeout: 252 seconds) |
| 15:35:53 | | Quit f1refly (Quit: see ya in hell) |
| 15:37:43 | | Join f1refly [0] (~f1refly@pd954c410.dip0.t-ipconnect.de) |
| 15:53:47 | | Quit dconrad (Remote host closed the connection) |
| 15:57:50 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 16:00 |
| 16:02:37 | | Quit dconrad (Ping timeout: 268 seconds) |
| 16:11:26 | braewoods | speachy: the front page says the HD300 is stable but the status page doesn't. |
| 16:11:28 | braewoods | what gives? |
| 16:30:58 | | Join GeekShadow [0] (~antoine@82-64-164-139.subs.proxad.net) |
| 16:43:25 | spork | that is not unique, zen mozaic is in the same boat |
| 16:44:56 | spork | HD200 too |
| 16:45:15 | spork | sorry, not the HD200 |
| 16:45:29 | braewoods | i managed to find an HD300 on ebay |
| 16:45:45 | braewoods | the mpio stuff is pretty rare |
| 16:48:02 | spork | crazy price ? |
| 16:49:00 | braewoods | no, like $60 |
| 16:49:10 | braewoods | the mpios aren't in high demand nor desired |
| 16:51:21 | spork | it looks pretty nice, but it is seriously old now |
| 16:51:36 | braewoods | i mainly bought it to test the port |
| 16:55:09 | spork | that is dedication |
| 17:00 |
| 17:00:35 | *** | Saving seen data "./dancer.seen" |
| 17:02:45 | speachy | braewoods: The HD300 has been marked as "stable" in the build system since 2012. |
| 17:03:09 | braewoods | speachy: i see. the wiki is weird then. |
| 17:03:19 | speachy | we're all only human. |
| 17:07:23 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 17:12:14 | | Quit dconrad (Ping timeout: 272 seconds) |
| 17:16:06 | | Join skipwich [0] (~skipwich@user/skipwich) |
| 17:41:31 | | Join jadzia [0] (~jadzia@2604:3d09:1b79:ca00::1e45) |
| 17:55:33 | | Quit lebellium (Read error: Connection reset by peer) |
| 18:00 |
| 18:02:54 | | Quit akaWolf (Ping timeout: 272 seconds) |
| 18:21:08 | | Join akaWolf [0] (~akaWolf@akawolf.org) |
| 18:53:43 | | Quit ZincAlloy (Quit: Leaving.) |
| 19:00 |
| 19:00:37 | *** | Saving seen data "./dancer.seen" |
| 19:17:31 | | Join dconrad [0] (~dconrad@208.38.228.17) |
| 19:25:10 | | Join cockroach [0] (~blattodea@user/cockroach) |
| 19:26:02 | | Join Solanacean [0] (~solanacea@95.78.202.240) |
| 19:32:35 | | Quit Solanacean () |
| 20:00 |
| 20:31:01 | | Join massiveH [0] (~massiveH@ool-18e4e82f.dyn.optonline.net) |
| 21:00 |
| 21:00:39 | *** | Saving seen data "./dancer.seen" |
| 21:55:53 | | Quit dconrad () |
| 22:00 |
| 22:21:57 | | Quit cockroach (Quit: leaving) |
| 23:00 |
| 23:00:41 | *** | Saving seen data "./dancer.seen" |
| 23:15:00 | | Join Retr0id9 [0] (~Retr0id@user/retr0id) |
| 23:15:54 | | Quit Retr0id (Ping timeout: 252 seconds) |
| 23:15:54 | | Nick Retr0id9 is now known as Retr0id (~Retr0id@user/retr0id) |
| 23:47:38 | | Quit massiveH (Quit: Leaving) |
icon identifies that the person is a core developer (has commit access).