00:30:37 | | Quit dconrad (Remote host closed the connection) |
00:31:28 | rb-bluebot | Build Server message: New build round started. Revision 30a23fdd6d, 303 builds, 11 clients. |
00:46:05 | rb-bluebot | Build Server message: Build round completed after 876 seconds. |
00:46:06 | rb-bluebot | Build Server message: Revision 30a23fdd6d result: All green |
00:59:30 | *** | Saving seen data "./dancer.seen" |
01:00 |
01:56:38 | | Join johnb5 [0] (~johnb2@p5b3afcfe.dip0.t-ipconnect.de) |
02:00 |
02:14:31 | | Quit johnb5 (Quit: Nettalk6 - www.ntalk.de) |
02:24:47 | | Join dconrad [0] (~dconrad@152.117.104.224) |
02:29:22 | | Quit dconrad (Ping timeout: 260 seconds) |
02:37:12 | | Quit asaba (Quit: Relay server offline) |
02:37:29 | | Join asaba [0] (~asabas@103.113.159.250) |
02:59:33 | *** | Saving seen data "./dancer.seen" |
04:00 |
04:19:57 | | Join lebellium [0] (~lebellium@2a01cb04012c0900d410c94625bc6c55.ipv6.abo.wanadoo.fr) |
04:25:27 | | Join dconrad [0] (~dconrad@152.117.104.224) |
04:29:59 | | Quit dconrad (Ping timeout: 256 seconds) |
04:59:34 | *** | Saving seen data "./dancer.seen" |
05:00 |
05:25:50 | munkis | bilgus: That sounds like a good idea, however the problem is that the panic is most reproducible at shutdown. |
06:00 |
06:17:47 | munkis | the backtrace does imply iit's somethinng in the button handdling though. |
06:25:59 | | Join dconrad [0] (~dconrad@152.117.104.224) |
06:30:41 | | Quit dconrad (Ping timeout: 256 seconds) |
06:59:35 | *** | Saving seen data "./dancer.seen" |
07:00 |
07:52:14 | | Quit munkis (Read error: Connection reset by peer) |
07:53:05 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
08:00 |
08:21:31 | | Join dconrad [0] (~dconrad@152.117.104.224) |
08:29:15 | | Quit munkis (Remote host closed the connection) |
08:31:05 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
08:33:49 | | Quit dconrad () |
08:41:01 | | Quit hook54321 (Ping timeout: 256 seconds) |
08:41:53 | | Quit zizzy (Ping timeout: 268 seconds) |
08:43:24 | | Join hook54321 [0] (sid149355@user/hook54321) |
08:43:27 | | Join zizzy [0] (sid385519@2a03:5180:f:2::5:e1ef) |
08:59:39 | *** | Saving seen data "./dancer.seen" |
09:00 |
09:01:20 | tertu | i'll try that later today! |
09:18:32 | | Quit hook54321 (Ping timeout: 240 seconds) |
09:18:59 | | Quit zizzy (Ping timeout: 264 seconds) |
09:22:18 | tertu | yay, another usb panic: "usb_dw_control_received: bad state=req" |
09:22:45 | tertu | i plugged it in, the usb "enter disk mode?" prompt popped up, and then it went into disk mode anyway, then paniced |
09:22:45 | | Join zizzy [0] (sid385519@lymington.irccloud.com) |
09:34:49 | | Join massiveH [0] (~massiveH@ool-18e4ebfe.dyn.optonline.net) |
09:36:31 | | Join hook54321 [0] (sid149355@user/hook54321) |
10:00 |
10:12:48 | tertu | that seems to be unreliable in general so i just turned it off |
10:36:34 | | Quit massiveH (Quit: Leaving) |
10:41:35 | tertu | what does dithering do exactly? |
10:53:28 | spork | adds a low level noise |
10:54:24 | tertu | does it only apply it if it has to resample? |
10:54:46 | spork | it reduces artifacts when playing something at a lower bit depth |
10:56:33 | tertu | also for future reference for dconrad the 50ms build works just fine |
10:57:40 | spork | i cannot explain it better than https://download.rockbox.org/daily/manual/rockbox-fiiom3k/rockbox-buildch6.html#x9-1100006.10 |
10:58:19 | tertu | it does seem to make timestretching artifacts a bit less irritating |
10:58:43 | spork | it does not mention if it is only applied on resampling though |
10:59:41 | *** | Saving seen data "./dancer.seen" |
11:00 |
11:00:11 | tertu | not that it really bothers me in that case anyway tbh |
11:01:02 | braewoods | dithering is mainly heard of in relation to GIFs since they cannot use more than 256 colors. |
11:01:49 | tertu | like i in principle know what audio dithering is for (as well as visual dithering) |
11:28:32 | | Quit tchan (Ping timeout: 240 seconds) |
11:32:01 | | Join tchan [0] (~tchan@c-98-206-141-238.hsd1.il.comcast.net) |
11:39:58 | | Join Genju [0] (Genju@user/genju) |
11:40:14 | Genju | ello! |
11:40:27 | Genju | I've figured out how to add album artist browing back to the database view :) |
11:42:36 | Genju | *browsing |
11:57:00 | | Quit Genju (Killed (NickServ (GHOST command used by `Genju!~Genju@p200300c477315031ed0277868e6ec58c.dip0.t-ipconnect.de))) |
11:57:20 | | Join Genju [0] (~Genju@user/genju) |
12:00 |
12:04:28 | | Join chris_s [0] (~chris_s@ip-95-223-74-166.hsi16.unitymediagroup.de) |
12:08:13 | chris_s | bilgus: g#3911 is "done" afaic, if you care to take another look at it at some point (no rush, obviously) |
12:08:16 | rb-bluebot | Gerrit review #3911 at https://gerrit.rockbox.org/r/c/rockbox/+/3911 : Add setting for disabling wrap-around lists by Christian Soffke |
12:09:00 | chris_s | _bilgus, I mean |
12:10:39 | | Quit chris_s (Quit: Connection closed) |
12:27:29 | spork | Genju: are you bragging or sharing how ? |
12:27:39 | Genju | maybe both? ;p |
12:27:48 | spork | both is good |
12:27:53 | Genju | %menu_start "main" "Database" |
12:27:53 | Genju | "Album Artist" -> albumartist -> album -> title = "fmt_title" |
12:28:01 | Genju | just put those two lines in a custom navi config file |
12:28:06 | Genju | between the header and footer lines |
12:28:20 | Genju | that did the trick for me, at least |
12:28:41 | spork | nice |
12:28:58 | Genju | still no idea why it was removed in the first place, but oh well |
12:30:59 | spork | removed from the standard (non-custom) you mean ? |
12:31:18 | Genju | yep |
12:32:31 | spork | might be able to find the commit that removed it |
12:33:17 | Genju | as long as it can be modded back in it's fine by me |
12:34:38 | spork | the commit might explain the 'why' |
12:37:12 | Genju | good point |
12:42:30 | spork | was it https://git.rockbox.org/cgit/rockbox.git/commit/?id=fb04b9b5ee4cc55900a3c93da16de7eeb99535e2 ? |
12:42:49 | Genju | looks like it |
12:43:10 | Genju | guess it replaced artist and albumartist with a unified "canonicalartist"? |
12:43:21 | spork | that is how it reads |
12:43:22 | Genju | if that was the idea, it doesn't seem to work for me, at least |
12:43:28 | Genju | picks artist over albumartist |
12:44:03 | Genju | which breaks albums with more than one artist (like various artists compilations that show an entry for every artist on the album instead of one entry named "Various Artists" |
12:44:05 | Genju | ) |
12:44:56 | Genju | maybe it's specific to the platform i'm using (surfans f20) |
12:45:47 | spork | it is generic |
12:46:09 | Genju | it should probably pick album artist if available an fall back to regular artist if not |
12:46:13 | Genju | *and |
12:46:37 | Genju | at least in the database view |
12:46:48 | tertu | okay so that is what it does |
12:47:00 | tertu | but it doesn't know that "Various artists" isn't an actual artist |
12:47:35 | tertu | if you take things where the artist tag is "Various Artists" and replace the artist tag with nothing or "" |
12:47:38 | | Join chris_s [0] (~chris_s@ip-95-223-74-166.hsi16.unitymediagroup.de) |
12:47:44 | tertu | rockbox will use the album artist instead |
12:47:55 | Genju | doesn't seem to work for me |
12:47:59 | tertu | huh. |
12:48:24 | Genju | all my albums with more than one artist have an ape tag %album artist% with the main artist of the album or "Various Artists" or "VA" set |
12:48:31 | Genju | foobar2000 conventions |
12:49:07 | tertu | for the main artist? |
12:49:32 | Genju | %album artist% has the main artist of the album for all tracks |
12:49:46 | Genju | the %artist% tags on the files contain the actual artists |
12:49:53 | Genju | like %album artist% = "VA" |
12:50:12 | Genju | track 1: same album artist, but %artist% = "Random Artist 1" etc. |
12:50:36 | tertu | oh sure |
12:50:47 | Genju | so the album should show up as album artist - album name |
12:50:55 | tertu | i misunderstood what you were trying to do |
12:51:01 | Genju | but shows up as N entries with artist 1 - album, artist 2 - same album, etc |
12:51:46 | tertu | hmm that seems reasonable |
12:52:01 | Genju | i think so, too |
12:52:10 | tertu | honestly the way canonical artist works seems a little backward? |
12:52:15 | Genju | my current workaround is to just browse by album artist, that way everything works fine |
12:52:36 | Genju | yeah, that's what i'm saying, it should pick album artist over artist, but it seems to be the other way around |
12:52:43 | tertu | well that said the old artist sort would have worked the same way right |
12:52:51 | chris_s | see here – you guys seem to be discussing the same thing: |
12:52:53 | chris_s | g#3947 |
12:52:56 | rb-bluebot | Gerrit review #3947 at https://gerrit.rockbox.org/r/c/rockbox/+/3947 : Revert "Database: Fix tag_albumartist; new tag_virt_canonicalartist." by Christian Soffke |
12:53:19 | Genju | indeed we seem to be :) |
12:53:41 | tertu | yeah |
12:54:04 | tertu | i don't really know what problem this change was trying to solve now that i think about it |
12:55:28 | Genju | so that change is still in the queue for reviewing? |
12:55:44 | tertu | that said is the other view you would want |
12:56:12 | tertu | albums and artists where the album artist is equal to the artist? |
12:56:14 | tertu | or something like that |
12:56:25 | Genju | that would be kind of pointless |
12:56:34 | Genju | or at least redundant? |
12:57:05 | spork | amachronic asked about comments last night i think |
12:57:14 | spork | on g#3947 |
12:57:15 | Genju | the logic should be: pick album artist tag if both artist and album artist are present, pick artist if only artist is present, pick album artist if only album artist is present |
12:57:17 | rb-bluebot | Gerrit review #3947 at https://gerrit.rockbox.org/r/c/rockbox/+/3947 : Revert "Database: Fix tag_albumartist; new tag_virt_canonicalartist." by Christian Soffke |
12:59:42 | *** | Saving seen data "./dancer.seen" |
12:59:47 | tertu | oh i see |
13:00 |
13:00:40 | tertu | so rather than being "artist with fallback" you want "album artist with fallback" so that VA/various artists show as that but albums with just the artist and no album artist set also show up |
13:00:48 | Genju | exactly |
13:00:52 | tertu | got it |
13:00:57 | tertu | that makes a lot of sense |
13:01:00 | Genju | like it was before in the "album artist" view |
13:01:14 | spork | good explanation, chris_s |
13:01:24 | spork | in that gerrit |
13:06:17 | tertu | yeah at least to me album artist with artist as fallback makes more sense |
13:06:21 | Genju | chris_s: so commit 3947 should revert it back to the way i just explained above, right? |
13:06:49 | Genju | i've been up since 4:25 AM, i might be getting it wrong |
13:07:01 | Genju | commuting is hell :) |
13:07:28 | tertu | because like, if i can think of an example song on my player you have stuff with the artist tag "towa tei feat. bebel gilberto" and the album artist "towa tei" |
13:07:49 | tertu | and functionally i think of the song as just a towa tei song |
13:07:53 | Genju | yeah, i have albums with that setup, too |
13:08:01 | Genju | along with compilation albums |
13:08:19 | tertu | i can think of use cases for "just artist" and "just album artist" also |
13:08:30 | tertu | but i can't really think of any for "artist with album artist as fallback" |
13:08:44 | Genju | yeah, me neither |
13:09:28 | tertu | james's comment on gerrit seems to be making the case that this is a "virtual artists tag" but i don't think it actually is |
13:10:00 | chris_s | Maybe James (the author) will chime in with more thoughts, because I do admittedly feel a bit bad suggesting to flat-out revert his changes, but I'm still not sure what the actual goal was |
13:10:17 | Genju | the current way doesn't make much sense for sure |
13:10:28 | Genju | or if it does, it's not apparent to me :) |
13:10:49 | tertu | album artist with artist as fallback seems to make the most sense to me for a virtual artists tag but then there's the issue of "VA" |
13:10:54 | Genju | in other news, the new pepe deluxe album is awesome |
13:13:37 | spork | that settled the debate |
13:13:53 | Genju | pepe deluxe trumps all? |
13:16:50 | spork | you played the pepe card |
13:18:33 | Genju | indeed, it's like the royal flush |
13:21:47 | Genju | the album is really, really good, though |
13:26:17 | | Quit chris_s (Quit: Connection closed) |
13:34:00 | spork | but what about the album artist ... |
13:50:43 | tertu | i tried figuring out what was going on in the database and it seems complicated |
13:53:10 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:5199:7526:5188:b8be) |
14:00 |
14:23:40 | | Quit Genju (Quit: Genju) |
14:52:27 | | Join dys [0] (~dys@user/dys) |
14:59:46 | *** | Saving seen data "./dancer.seen" |
15:00 |
15:01:57 | | Join davemeitner [0] (~davemeitn@bras-base-oshwon9562w-grc-105-70-24-108-227.dsl.bell.ca) |
15:02:06 | | Quit davemeitner (Client Quit) |
15:30:30 | | Quit jschwart (Read error: Connection reset by peer) |
15:30:43 | | Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) |
15:56:02 | | Quit jschwart (Ping timeout: 246 seconds) |
16:00 |
16:38:58 | | Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) |
16:59:48 | *** | Saving seen data "./dancer.seen" |
17:00 |
17:31:11 | rb-bluebot | Build Server message: New build round started. Revision fbf83dc4ce, 303 builds, 11 clients. |
17:44:16 | | Join mendel_munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
17:44:27 | | Quit munkis (Ping timeout: 256 seconds) |
17:45:07 | | Quit mendel_munkis (Remote host closed the connection) |
17:48:09 | rb-bluebot | Build Server message: Build round completed after 1019 seconds. |
17:48:12 | rb-bluebot | Build Server message: Revision fbf83dc4ce result: All green |
17:58:17 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |
18:00 |
18:51:41 | | Quit yosafbridge (Quit: Leaving) |
18:52:07 | | Quit jackie (Quit: No Ping reply in 180 seconds.) |
18:53:16 | | Join jackie [0] (~jackie@banana-new.kilobyte22.de) |
18:56:28 | | Join yosafbridge [0] (~yosafbrid@static.38.6.217.95.clients.your-server.de) |
18:59:52 | | Join dconrad [0] (~dconrad@152.117.104.224) |
18:59:53 | *** | Saving seen data "./dancer.seen" |
19:00 |
19:06:03 | | Quit lebellium (Quit: Leaving) |
19:18:49 | | Quit ZincAlloy (Quit: Leaving.) |
20:00 |
20:02:02 | | Quit dconrad (Remote host closed the connection) |
20:39:41 | | Join dconrad [0] (~dconrad@152.117.104.224) |
20:59:54 | *** | Saving seen data "./dancer.seen" |
21:00 |
21:18:46 | | Quit dconrad (Remote host closed the connection) |
21:50:59 | | Join jadzia [0] (~jadzia@2604:3d09:1b85:4200::b3d8) |
22:00 |
22:28:22 | | Join dconrad [0] (~dconrad@152.117.104.224) |
22:59:57 | *** | Saving seen data "./dancer.seen" |
23:00 |
23:28:33 | | Quit dconrad (Remote host closed the connection) |
23:44:49 | | Join dconrad [0] (~dconrad@152.117.104.224) |
23:57:55 | | Quit munkis (Remote host closed the connection) |
23:58:20 | | Join munkis [0] (~mendel_mu@ool-ae2cb218.dyn.optonline.net) |