| 00:09:31 | *** | Saving seen data "./dancer.seen" |
| 01:00 |
| 01:31:34 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:1466:1335:118f:9769) |
| 01:36:04 | | Quit ZincAlloy (Ping timeout: 268 seconds) |
| 01:41:46 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:1466:1335:118f:9769) |
| 01:46:32 | | Quit ZincAlloy (Ping timeout: 268 seconds) |
| 01:50:31 | | Join chris_s [0] (~chris_s@ip-95-223-74-166.hsi16.unitymediagroup.de) |
| 01:52:53 | chris_s | __builtin: thanks, that seems like a good idea, I'll upload a version using a mutex later |
| 01:54:29 | | Quit chris_s (Client Quit) |
| 01:54:31 | | Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de) |
| 01:58:39 | | Quit Solanacean_ (*.net *.split) |
| 01:58:51 | | Quit ZincAlloy (Ping timeout: 256 seconds) |
| 01:58:59 | | Join Solanacean [0] (solanacean@176.214.16.178) |
| 02:00 |
| 02:04:22 | | Quit rogeliodh (*.net *.split) |
| 02:04:56 | | Join rogeliodh [0] (~rogeliodh@rogeliodh.dev) |
| 02:09:32 | *** | Saving seen data "./dancer.seen" |
| 02:18:59 | | Quit rb-bluebot (Ping timeout: 264 seconds) |
| 02:19:10 | | Quit bluebrother (Ping timeout: 260 seconds) |
| 03:00 |
| 03:15:55 | | Join bluebrother [0] (~dom@user/bluebrother) |
| 03:24:41 | | Quit bluebrother (Ping timeout: 265 seconds) |
| 04:00 |
| 04:09:34 | *** | Saving seen data "./dancer.seen" |
| 05:00 |
| 05:26:25 | | Join bluebrother [0] (~dom@user/bluebrother) |
| 06:00 |
| 06:09:38 | *** | No seen item changed, no save performed. |
| 06:27:23 | | Quit dbohdan (Ping timeout: 264 seconds) |
| 06:29:16 | | Join dbohdan [0] (~dbohdan@user/dbohdan) |
| 06:42:59 | | Quit danwellby (Ping timeout: 264 seconds) |
| 07:00 |
| 07:03:39 | | Join danwellby [0] (~danwellby@88.97.8.245) |
| 08:00 |
| 08:09:41 | *** | Saving seen data "./dancer.seen" |
| 09:00 |
| 09:01:22 | | Join massiveH [0] (~massiveH@ool-18e4ebfe.dyn.optonline.net) |
| 10:00 |
| 10:09:45 | *** | No seen item changed, no save performed. |
| 10:20:19 | | Quit massiveH (Quit: Leaving) |
| 11:00 |
| 11:36:41 | | Quit j-r (Ping timeout: 264 seconds) |
| 11:36:54 | | Join j-r [0] (~j-r@p2003000623cebf31404207fffefd0a65.dip0.t-ipconnect.de) |
| 12:00 |
| 12:09:48 | *** | Saving seen data "./dancer.seen" |
| 12:28:10 | | Nick tertu2 is now known as tertu (~tertu@user/tertu) |
| 12:51:56 | | Join mm00 [0] (~mm00@93-42-44-16.ip85.fastwebnet.it) |
| 13:00 |
| 13:07:09 | tertu | so i assume unsigned long is 32 bit on all targets? |
| 13:11:57 | tertu | also would people be open to the idea of replacing the mersenne twister with a smaller state rng |
| 13:15:27 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:895d:9e8f:b40b:9f9f) |
| 13:41:14 | | Join lebellium [0] (~lebellium@2a01cb04012c0900710c495e4ff83f37.ipv6.abo.wanadoo.fr) |
| 13:52:02 | | Quit advcomp2019__ (Read error: Connection reset by peer) |
| 13:52:28 | | Join advcomp2019__ [0] (~advcomp20@user/advcomp2019) |
| 14:00 |
| 14:09:50 | *** | Saving seen data "./dancer.seen" |
| 14:26:53 | | Quit tertu (Remote host closed the connection) |
| 14:27:11 | | Join tertu [0] (~tertu@user/tertu) |
| 14:35:14 | munkis | _bilgus: am i remembering correctly that you dddid something with the shortcut handler ~6mos ago? |
| 16:00 |
| 16:09:52 | *** | Saving seen data "./dancer.seen" |
| 16:09:52 | _bilgus | Its been ongoing but yeah what the problem? |
| 16:12:19 | _bilgus | tertu pretty safe assumption @32bits |
| 16:18:02 | _bilgus | munkis if its plugin related or menu related its probably me |
| 16:19:08 | _bilgus | the shortcuts menu got a way to exit using the same action that entered (i think I noted it as being possibly problematic in the commit) |
| 16:27:12 | | Join rb-bluebot [0] (~rb-bluebo@rockbox/bot/utility) |
| 17:00 |
| 17:37:20 | | Quit lebellium (Quit: Leaving) |
| 18:00 |
| 18:06:15 | | Quit mm00 (Quit: Connection closed) |
| 18:09:55 | *** | Saving seen data "./dancer.seen" |
| 19:00 |
| 19:14:56 | munkis | for some reason trying to open any file in a viewer from the shortcuts menu causes splashf(cant open) andd a return to the shortcut menu (inlcuding when I move from the shortcut location to a file in a different folder of a different type as a test) |
| 19:23:35 | | Quit ZincAlloy (Quit: Leaving.) |
| 20:00 |
| 20:09:59 | *** | Saving seen data "./dancer.seen" |
| 20:12:33 | | Quit jschwart (Read error: Connection reset by peer) |
| 20:13:58 | | Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) |
| 20:59:39 | _bilgus | likely your lang file is out of sync try deleting plugin.dat |
| 21:00 |
| 21:05:30 | _bilgus | wait anyfile? |
| 21:05:54 | _bilgus | most files should just take you to the file browser |
| 21:51:49 | _bilgus | oh ok I see you said in a viewer how do you do that with the shortcut menu? |
| 21:52:15 | _bilgus | or do you mena you browse to the file from shortcut_menu and then run a viewer? |
| 21:52:21 | _bilgus | mean* |
| 21:59:52 | _bilgus | https://gerrit.rockbox.org/r/c/rockbox/+/3943 |
| 22:00 |
| 22:10:00 | *** | Saving seen data "./dancer.seen" |
| 23:00 |
| 23:04:38 | munkis | from an end user perspective it appears that selecting a shortcut opens the file browser in that location (possibly with some settings set) which doesn't remember location on close. |
| 23:05:03 | munkis | however since my last update said file viewer instance can't handle viewers |
| 23:05:35 | munkis | (my guess is it's not properly passing the to open string) |
| 23:06:48 | _bilgus | weird could you try with a clean install? for me it opens the sc browser instance then I select open with viewer |
| 23:07:11 | _bilgus | munkis is that how you are doing it? |
| 23:08:45 | _bilgus | oh I guess i can select the file STD_OK same deal |
| 23:09:26 | _bilgus | are you activating the sc menu from the main menu (ROOT?) |
| 23:10:25 | munkis | thiss was the first update since before opening plugins ddirectly fromshortcuts was a thing |
| 23:11:15 | _bilgus | so you are not at head? |
| 23:13:36 | munkis | yeah issed all those shortcut fixes |
| 23:13:42 | munkis | s/issed/missed |
| 23:14:24 | _bilgus | that wasn't actually from changes to the sc menu |
| 23:14:32 | munkis | it's a month oldd build |
| 23:14:41 | _bilgus | I made all the browsers exit before running plugins |
| 23:15:04 | munkis | let me rebase and retry |
| 23:15:17 | _bilgus | except for short lived things like the properties |
| 23:15:45 | _bilgus | I had a similar deal the other day after chris_s updated the lang ids |
| 23:16:07 | _bilgus | I fear i'll have to ADD VERSIONING |
| 23:16:36 | _bilgus | anyway the lang ids were off by one since I hashed on them |
| 23:16:44 | _bilgus | yeah that kinda sucks |
| 23:16:52 | munkis | why should lang mattr? |
| 23:17:36 | _bilgus | well instead of passing around ID2P(LANG_ID) i guess I need to pass around fixed strings |
| 23:17:52 | _bilgus | or add versioning |
| 23:18:30 | _bilgus | or just erase the plugin.dat file every update but that kinda sucks I really like the parameters I have set up for my plugins |
| 23:21:56 | _bilgus | I guess what I should do is have the ID2P expanded if it is being saved |
| 23:22:20 | _bilgus | then it becomes independent of lang_id changes |
| 23:23:54 | _bilgus | thats not a big deal everything saved is user initiated hot keys etc except the start-up plugin |
| 23:26:29 | _bilgus | basically open_plugin is a big database of hashed plugin paths those paths key to the parameters you save |
| 23:26:56 | _bilgus | then when you run the plugin later it gets the parameters added automatically |
| 23:27:28 | munkis | rebuilding and upgradeing fixed it |
| 23:27:41 | _bilgus | since the buffer is already there for plugin_name, path and parameter I also reused them for core for temporary use |
| 23:28:35 | _bilgus | I basically am trying to centralize plugins and give a way to run them from other plugins, with parameters |
| 23:28:54 | | Join chris_s [0] (~chris_s@ip-95-223-74-201.hsi16.unitymediagroup.de) |
| 23:31:22 | _bilgus | munkis you should try previous screen it now works with plugins |
| 23:31:57 | chris_s | By the way, the only thing I'm a little ambivalent about is is that when you're navigating to a folder using the Shortcuts menu, you can't then easily open one file after the other (unless I'm missing something) since it always ejects you back to the main menu. + |
| 23:32:20 | _bilgus | I think stuff that can save on shutdown and resume state would be neat |
| 23:32:36 | _bilgus | it doesn't dump you back to the shortcuts menu? |
| 23:33:28 | chris_s | Oh yeah, Shortuts Menu, you're right |
| 23:33:33 | _bilgus | ah its just yet another corner case on the sc menu |
| 23:34:43 | _bilgus | we can save state for damn near anything I just need to know where or what |
| 23:36:09 | chris_s | I'm a little surprised it works when you're using "Open With" instead, but I guess that doesn't use plugin_open? |
| 23:36:32 | _bilgus | eh pretty sure it still does |
| 23:36:58 | chris_s | hm, ok |
| 23:37:12 | chris_s | :) |
| 23:37:25 | munkis | how do you even get open with? |
| 23:37:42 | chris_s | using the context menu (long press select) |
| 23:38:00 | munkis | oh from bthe browser not the sc menu |
| 23:38:09 | chris_s | right |
| 23:38:25 | munkis | I haave it mapped to a key there |
| 23:40:10 | _bilgus | https://gerrit.rockbox.org/r/c/rockbox/+/3914 |
| 23:40:20 | _bilgus | yeah open with uses op |
| 23:40:45 | _bilgus | yeah the sc menu only has delete |
| 23:40:55 | _bilgus | I plan to eventually make it a folder |
| 23:41:18 | _bilgus | even if some of the folder needs mapped to ram |
| 23:41:47 | _bilgus | but I want to run it through the already defined interfaces instead of it being a special hell |
| 23:45:26 | _bilgus | We have so many static buffers laying around the code base but I bet fully 10% are in the shortcuts code |
| 23:48:38 | _bilgus | chris_s I see what you are saying about running the plugin from the sc browser |
| 23:48:59 | _bilgus | it exits back to the sc menu instead of returning to the folder |
| 23:49:24 | _bilgus | I think instead if I made it use the inbuilt browser it solves that issue |
| 23:49:55 | _bilgus | but atm I'm trying to hit another target but I'll get to it |
| 23:50:01 | chris_s | "inbuilt browser"? |
| 23:50:25 | _bilgus | ath the sc menu makes its own browser instance |
| 23:50:45 | _bilgus | it doesn't use the onre in the root menu |
| 23:51:06 | chris_s | ah ok, sounds good |
| 23:51:08 | _bilgus | now why the openwith keeps the state properly IDK thats odd |
| 23:51:58 | chris_s | I was actually considering adding basic “change title” / “move item” / “add separator” submenu to the Shortcuts menu at some point – I guess that shouldn’t be too difficult – but sounds like the menu is not long for this world? :D (maybe I wouldn't have gotten to it anyway) |
| 23:52:52 | chris_s | (in terms of its current structure) |
| 23:53:20 | _bilgus | it might be that the .rock file doesn't save state but the open_with one does |
| 23:53:45 | _bilgus | well I have the do_menu stuff where you have folder nodes |
| 23:54:40 | _bilgus | it offers more configuration but I figured we could use the file browser on a (mostly?) in memory folder |
icon identifies that the person is a core developer (has commit access).