00:11:17 | _bilgus | and I was correct in my first code making the root redirect static, I thought it just opened the file entry but it does indeed store a pointer to the name |
00:32:04 | _bilgus | well in practice I guess not since its redirected the name never gets used |
00:55:16 | *** | No seen item changed, no save performed. |
02:00 |
02:55:20 | *** | No seen item changed, no save performed. |
03:00 |
03:18:24 | rb-bluebot | Build Server message: New build round started. Revision 68d0175172, 303 builds, 9 clients. |
04:00 |
04:55:24 | *** | No seen item changed, no save performed. |
06:00 |
06:55:27 | *** | No seen item changed, no save performed. |
07:00 |
07:40:30 | | Join massiveH [0] (~massiveH@ool-4a5862ee.dyn.optonline.net) |
08:00 |
08:47:41 | | Quit massiveH (Quit: Leaving) |
08:55:31 | *** | Saving seen data "./dancer.seen" |
09:00 |
09:40:32 | rb-bluebot | Build Server message: New build round started. Revision 355553baf4, 303 builds, 9 clients. |
09:42:37 | _bilgus | dconrad (logs) try these builds today when you get a chance, at least 2/3 of them deal directly with playlist issues, there is still an issue stalling at initial playback start but I haven't found it yet |
09:53:06 | rb-bluebot | Build Server message: Build round completed after 753 seconds. |
09:53:08 | rb-bluebot | Build Server message: Revision 355553baf4 result: All green |
10:00 |
10:14:09 | _bilgus | there is still a root redirect issue, it stops finding root entries at some point still trying to narrow it down |
10:30:30 | | Join amachronic [0] (~amachroni@user/amachronic) |
10:31:26 | amachronic | _bilgus: it seems resume is broken because dircache is now reporting fully qualified paths like /<microSD0>/foo/bar |
10:32:54 | amachronic | problem is that when volume 0 is root (the non-redirect case) then playlist.c uses non qualified paths "/foo/bar" |
10:33:10 | amachronic | hence the resume crc appears not to match |
10:33:23 | amachronic | since it's just the crc of the file path |
10:34:07 | amachronic | it works when root is redirected because the only way to get at the SD card root is thru /<microSD0> |
10:35:22 | amachronic | for the same reason it won't happen if you have a >=2 drive target and your files aren't on volume 0 (redirect or no) |
10:42:21 | rb-bluebot | Build Server message: New build round started. Revision eae9f6f5b7, 303 builds, 9 clients. |
10:42:33 | _bilgus | that goes in hand witht the issue I see where its looking for <MicroSd1> and failing, but I haven't figured out why it loses state |
10:43:25 | _bilgus | sounds like we will be using relative paths for the playlists soon |
10:44:21 | amachronic | I think the root problem (pardon the pun) is that the code assumes every file has a unique absolute path |
10:45:17 | amachronic | root redirect broke that by accident |
10:46:02 | _bilgus | unintended consequences FTW? |
10:46:46 | _bilgus | I'm confident we will get it worked out, but i've found a lot of buggy iffy code in the process of testing this |
10:47:54 | _bilgus | funny thing is that I use root redirect in my debug builds I just never used it long enough for this to come out of the wood work |
10:49:18 | amachronic | me too, I was testing with redirect enabled so I never noticed the bug until dconrad reported it |
10:50:44 | amachronic | those leaked fd and ARM div bugs were some good bugs you squashed |
10:54:25 | rb-bluebot | Build Server message: Build round completed after 723 seconds. |
10:54:28 | rb-bluebot | Build Server message: Revision eae9f6f5b7 result: All green |
10:55:35 | *** | No seen item changed, no save performed. |
10:58:21 | rb-bluebot | Build Server message: New build round started. Revision 7fa48faeb5, 303 builds, 9 clients. |
11:00 |
11:12:02 | rb-bluebot | Build Server message: Build round completed after 821 seconds. |
11:12:08 | rb-bluebot | Build Server message: Revision 7fa48faeb5 result: All green |
11:15:59 | rb-bluebot | Build Server message: New build round started. Revision 603412f447, 303 builds, 9 clients. |
11:37:29 | rb-bluebot | Build Server message: Build round completed after 1290 seconds. |
11:37:31 | rb-bluebot | Build Server message: Revision 603412f447 result: All green |
11:44:19 | | Quit amachronic (Quit: amachronic) |
12:00 |
12:06:24 | | Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de) |
12:10:56 | | Quit ZincAlloy (Ping timeout: 256 seconds) |
12:29:14 | | Join lebellium [0] (~lebellium@2a01cb04012c0900343c8ba515a2df7f.ipv6.abo.wanadoo.fr) |
12:42:31 | | Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:d099:2ed0:6f66:401a) |
12:55:36 | *** | Saving seen data "./dancer.seen" |
13:00 |
13:14:05 | | Quit JanC (Read error: Connection reset by peer) |
13:14:26 | | Join JanC [0] (~janc@user/janc) |
14:00 |
14:13:56 | | Join bilgus_ph [0] (~bilgus_ph@172.58.219.142) |
14:21:19 | bilgus_ph | Amachronic re g#4349 the original idea for blocking a redirect from vol0 was in case it went readonly you wouldn't be stuck but *I think* its okay since we start at the highest vol first but the finished bootloaders do ignore it for those devices till we update |
14:21:22 | rb-bluebot | Gerrit review #4349 at https://gerrit.rockbox.org/r/c/rockbox/+/4349 : multiboot: Search in volume 0 for redirect file by Aidan MacDonald |
14:23:24 | bilgus_ph | Maybe you could do I> |
14:25:38 | bilgus_ph | I >= 0 + IF_MV(1) so its consistent |
14:31:18 | | Quit bilgus_ph (Quit: Connection closed) |
14:55:40 | *** | Saving seen data "./dancer.seen" |
16:00 |
16:08:46 | | Quit amk (Remote host closed the connection) |
16:08:55 | | Join amk [0] (~amk@109.255.169.126) |
16:55:43 | *** | Saving seen data "./dancer.seen" |
17:00 |
17:20:04 | | Quit rogeliodh9 (Quit: The Lounge - https://thelounge.chat) |
17:20:27 | | Join rogeliodh9 [0] (~rogeliodh@rogeliodh.dev) |
17:27:13 | speachy | btw, everyone; I changed the server so that gerrit will auto-restart after a crash. |
17:27:36 | speachy | since it kept crashing (with internal JVM errors) |
17:28:21 | speachy | fwiw I went through a _lot_ of hair-pulling trying to fix up absolute/relative paths on the hosted targets. |
17:31:46 | | Join amiconn_ [0] (jens@p200300ea87020000305e95fffec66ff3.dip0.t-ipconnect.de) |
17:31:47 | | Quit amiconn (Killed (calcium.libera.chat (Nickname regained by services))) |
17:31:47 | | Nick amiconn_ is now known as amiconn (jens@p200300ea87020000305e95fffec66ff3.dip0.t-ipconnect.de) |
17:33:03 | | Join Bobathan_ [0] (~admin@cpe-65-29-248-157.wi.res.rr.com) |
17:34:42 | | Join markun [0] (~markun@178-84-113-30.dynamic.upc.nl) |
17:35:12 | | Join yang_ [0] (~yang@fsf/member/yang) |
17:39:45 | | Quit Bobathan (*.net *.split) |
17:39:45 | | Quit markun_ (*.net *.split) |
17:39:45 | | Quit yang (*.net *.split) |
17:39:45 | | Quit hombrelaser_1 (*.net *.split) |
17:39:45 | | Quit berber (*.net *.split) |
17:39:46 | | Quit spork (*.net *.split) |
17:45:26 | | Join hombrelaser_1 [0] (~my@user/hombrelaser) |
17:45:26 | | Join berber [0] (~berber@v2202101107577140883.nicesrv.de) |
17:47:19 | | Join spork [0] (topic@31-151-2-135.dynamic.upc.nl) |
18:00 |
18:18:33 | _bilgus | speachy THANKS |
18:55:46 | *** | Saving seen data "./dancer.seen" |
19:00 |
19:10:37 | | Join dconrad [0] (~dconrad@152.117.104.208) |
19:15:12 | dconrad | _bilgus, I just grabbed the latest build, 603412f447-220311, and the resume bug doesn't appear to have changed any |
19:15:45 | _bilgus | give me a few I'm testing that build now before I push it |
19:37:43 | | Join massiveH [0] (~massiveH@ool-4a5862ee.dyn.optonline.net) |
19:45:27 | | Quit lebellium (Quit: Leaving) |
19:46:01 | rb-bluebot | Build Server message: New build round started. Revision eb32238b22, 303 builds, 8 clients. |
19:46:33 | _bilgus | dconrad i'm not sure how fast the build will be up but thats it ^ |
19:46:45 | dconrad | sounds good, I'll test it when it finishes |
19:58:22 | rb-bluebot | Build Server message: Build round completed after 741 seconds. |
19:58:26 | rb-bluebot | Build Server message: Revision eb32238b22 result: 433 errors 86 warnings |
19:59:03 | _bilgus | maybe not |
20:00 |
20:06:44 | rb-bluebot | Build Server message: New build round started. Revision 95af36d0dd, 303 builds, 8 clients. |
20:07:31 | | Join smithjd [0] (~enderw@node-1w7jra28yypteo4nnhbacezk9.ipv6.telus.net) |
20:08:13 | | Quit smithjd (Client Quit) |
20:19:45 | rb-bluebot | Build Server message: Build round completed after 780 seconds. |
20:19:51 | rb-bluebot | Build Server message: Revision 95af36d0dd result: All green |
20:32:47 | rb-bluebot | Build Server message: New build round started. Revision 97ec0a7e73, 303 builds, 8 clients. |
20:47:49 | rb-bluebot | Build Server message: Build round completed after 902 seconds. |
20:47:50 | rb-bluebot | Build Server message: Revision 97ec0a7e73 result: All green |
20:51:49 | | Quit dconrad (Remote host closed the connection) |
20:55:48 | *** | Saving seen data "./dancer.seen" |
21:00 |
21:07:19 | | Quit ZincAlloy (Quit: Leaving.) |
21:08:25 | | Join dconrad [0] (~dconrad@152.117.104.208) |
21:13:29 | | Quit dconrad (Ping timeout: 268 seconds) |
22:00 |
22:23:22 | | Join dconrad [0] (~dconrad@152.117.104.208) |
22:27:43 | _bilgus | FOUND IT |
22:29:25 | dconrad | _bilgus, looks like your fix corrected the resume issue here, I just got back to be able to download a build, 97ec0a7e73-220312 seems to work well so far |
22:29:38 | dconrad | also, you found the root of your issue? |
22:29:56 | _bilgus | yes resume on start was taking 3 minutes o start a song |
22:30:00 | _bilgus | fix incoming |
22:30:10 | dconrad | wow, that's a long time |
22:30:29 | dconrad | must be sansa specific? I haven't seen that |
22:33:50 | rb-bluebot | Build Server message: New build round started. Revision a59b3c5d11, 303 builds, 8 clients. |
22:34:02 | _bilgus | just got lucky |
22:34:45 | _bilgus | I have a lot of files on my player so since root redirect uses dircache, playlist_resume eats up all ram and they race each other |
22:35:20 | dconrad | oh that's tricky |
22:35:29 | dconrad | leading to a crash or just taking forever? |
22:35:53 | _bilgus | like it says hey dir cache where is mysong.mp3 dir cache is like Uh IDK i never finished scanning hold on, oh wait no ram, hey playlist hold on I need ram |
22:36:08 | _bilgus | and like that for potentially forever |
22:38:01 | dconrad | oof, well good job finding it, that's pretty subtle |
22:38:18 | _bilgus | uh been trying things for like 2 days now |
22:38:34 | _bilgus | ugh rather |
22:38:37 | dconrad | lol |
22:46:43 | rb-bluebot | Build Server message: Build round completed after 773 seconds. |
22:46:44 | rb-bluebot | Build Server message: Revision a59b3c5d11 result: 408 errors 82 warnings |
22:48:43 | _bilgus | damnit I hate ifdefs :\ |
22:53:09 | rb-bluebot | Build Server message: New build round started. Revision eecf840989, 303 builds, 8 clients. |
22:54:47 | dconrad | well with all these changes amachronic has lined up ready to go I don't have any more excuses not to get dualboot working on the eros haha |
22:55:16 | dconrad | that might be this weekend's goal |
22:55:51 | *** | Saving seen data "./dancer.seen" |
23:00 |
23:09:06 | rb-bluebot | Build Server message: Build round completed after 957 seconds. |
23:09:13 | rb-bluebot | Build Server message: Revision eecf840989 result: All green |
23:55:47 | | Quit massiveH (Quit: Leaving) |