Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2022-03-14

01:00
01:56:45***No seen item changed, no save performed.
02:00
02:43:10rb-bluebotBuild Server message: New build round started. Revision 6dcbf7ff77, 303 builds, 8 clients.
02:57:14rb-bluebotBuild Server message: Build round completed after 844 seconds.
02:57:17rb-bluebotBuild Server message: Revision 6dcbf7ff77 result: All green
03:00
03:00:17 Quit pixelma (Quit: .)
03:00:18 Quit amiconn (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
03:02:44 Join amiconn [0] (jens@p200300ea87020000305e95fffec66ff3.dip0.t-ipconnect.de)
03:02:44 Join pixelma [0] (marianne@p200300ea87020000305e95fffec66ff3.dip0.t-ipconnect.de)
03:30:41 Join jadzia [0] (~jadzia@2604:3d09:1b85:4200::a14b)
03:37:46 Quit Natch (Remote host closed the connection)
03:43:10 Join Natch [0] (~natch@c-67bae255.014-297-73746f25.bbcust.telenor.se)
03:56:48***Saving seen data "./dancer.seen"
05:00
05:56:50***No seen item changed, no save performed.
06:00
06:56:39 Join chris_s [0] (~chris_s@dslb-084-058-026-110.084.058.pools.vodafone-ip.de)
07:00
07:02:49chris_s_bilgus: thanks, I'll wait for speachy to chime in. Only additional thought I had that maybe checkwps discard the themes automatically for some reason due to the recent skin_parser changes? idk
07:05:01chris_sHuh. Some of the themes can still be found by searching but aren't listed otherwise, and the site now claims that the theme doesn't work with the current build
07:05:04chris_shttps://themes.rockbox.org/index.php?themeid=3224
07:06:58 Quit chris_s (Quit: Connection closed)
07:56:54***Saving seen data "./dancer.seen"
08:00
08:28:58sporkthe tooltip over 'current build' says it failed to open the theme
08:29:14sporki think
08:49:22 Join massiveH [0] (~massiveH@ool-4a5862ee.dyn.optonline.net)
08:50:56_bilguschris_s entirely likely I'll look at is in 8 hrs
08:51:10_bilgusit in*
09:00
09:26:07_bilgushmm I tried builds before my recent changes but still fails on that nightpod theme i'll have to dig\
09:56:57***No seen item changed, no save performed.
10:00
10:21:19_bilguschris_s it fails here => if(skin_vp->vp.width + skin_vp->vp.x > display->lcdheight)
10:21:19_bilgus(320 + 0 > 240)
10:23:24_bilgussorry its the width not h if(skin_vp->vp.width + skin_vp->vp.x > display->lcdwidth)
10:28:48 Quit munkis (Ping timeout: 272 seconds)
10:34:34 Quit massiveH (Quit: Leaving)
10:36:57_bilgusall the errors seem to be due to the screen size being wrong maybe its gotten flipped width for height?
11:00
11:23:44sporkm3k is 240x320 (wxh)
11:42:13 Quit ddevault (Write error: Broken pipe)
11:42:14 Quit cnx (Remote host closed the connection)
11:42:34 Join cnx [0] (c364d5be87@2604:bf00:561:2000::3f)
11:42:53 Join ddevault [0] (e7b4bb6755@sourcehut/staff/ddevault)
11:56:51 Join bilgus_ph [0] (~bilgus_ph@172.58.219.88)
11:57:02***Saving seen data "./dancer.seen"
11:58:13bilgus_phSport yes the m3k will pass with WxH flipped the proper way for the skin so that's okay but the iPod video fails for the volume vp being too large and the math is right
12:00
12:01:29bilgus_phIts something like %pv (58, n, 204) and vp_x >240
12:02:05bilgus_phSorry vp_x + vp_w > 240
12:02:45bilgus_phLikely that theme was always wrong we just got more selective
12:04:15bilgus_phBut I'll try and find when we broke it just to be sure the skin engine isn't going nuts
12:04:42 Quit bilgus_ph (Quit: Connection closed)
12:17:11 Join bilgus_ph [0] (~bilgus_ph@172.58.219.231)
12:17:22bilgus_phProbably this https://github.com/Rockbox/rockbox/commit/278e7457ea88ea7dd8765d586d4f45315c3f546d
12:18:09 Quit bilgus_ph (Client Quit)
13:00
13:08:19 Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:56e:a494:fd43:fb59)
13:13:02 Quit ZincAlloy (Ping timeout: 268 seconds)
13:16:59 Join lebellium [0] (~lebellium@2a01cb04012c09003c1feaccc9c735b4.ipv6.abo.wanadoo.fr)
13:19:02 Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:b02b:180c:640a:7716)
13:24:08 Quit ZincAlloy (Ping timeout: 268 seconds)
13:24:25 Join speachy [0] (~speachy@c-69-242-159-139.hsd1.mo.comcast.net)
13:24:25 Quit speachy (Changing host)
13:24:25 Join speachy [0] (~speachy@rockbox/developer/speachy)
13:24:25Mode"#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat)
13:26:12speachychris_s: nothing was removed purposefully, but themes that fail to pass both historical and nightly checkwps are hidden IIRC.
13:27:38speachy"hidden" meaning not showing up in general "themes for player X" searches.
13:27:59speachy(sorry about my tardiness. I'm writing this from an RV park in Grain Valley, Missouri, with truly craptastic wifi)
13:28:49speachy(it's been a very tumultous few months...)
13:29:54 Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de)
13:33:35speachyand given the number of subtle bugs with respect to themes, it's hard to argue about against being as strict as possible.
13:34:38 Quit ZincAlloy (Ping timeout: 260 seconds)
13:40:31 Join bilgus_ph [0] (~bilgus_ph@172.58.219.163)
13:41:37bilgus_phLooking at my recent commits I messed up the noborder case in string matching I'll check this eve
13:43:39bilgus_phhttps://gerrit.rockbox.org/r/c/rockbox/+/4358/2/apps/gui/skin_engine/skin_parser.c#1059
13:44:35 Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:bd0e:dd9b:cc72:64a3)
13:48:55 Quit jadzia (Quit: jadzia)
13:57:06***Saving seen data "./dancer.seen"
13:59:14 Quit bilgus_ph (Quit: Connection closed)
15:00
15:07:52 Quit emacsomancer (Quit: WeeChat 3.4)
15:08:31 Join emacsomancer [0] (~emacsoman@136.60.128.68)
15:18:08 Join chris_s [0] (~chris_s@dslb-084-058-026-110.084.058.pools.vodafone-ip.de)
15:18:57chris_sthanks! Yeah, if there’s an issue with the themes that got removed, I’
15:20:11chris_sll be happy to try and upload new versions at some point
15:22:12 Quit chris_s (Client Quit)
15:44:16_bilguschrish give me a few I found some bugs on my end it still doesn't fix the math (or pass the checkwps) but I can't have you going through work till I check my own
15:44:29_bilguschris_s*
15:45:51 Join chris_s [0] (~chris_s@dslb-084-058-026-110.084.058.pools.vodafone-ip.de)
15:45:53chris_sok, cool!
15:46:53 Quit chris_s (Client Quit)
15:57:07***Saving seen data "./dancer.seen"
16:00
16:06:18 Quit speachy (Ping timeout: 260 seconds)
16:09:23 Join speachy [0] (~speachy@c-69-242-159-139.hsd1.mo.comcast.net)
16:09:24 Quit speachy (Changing host)
16:09:24 Join speachy [0] (~speachy@rockbox/developer/speachy)
16:09:24Mode"#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat)
16:18:26 Quit speachy (Ping timeout: 250 seconds)
16:21:55 Join speachy [0] (~speachy@c-69-242-159-139.hsd1.mo.comcast.net)
16:21:55 Quit speachy (Changing host)
16:21:55 Join speachy [0] (~speachy@rockbox/developer/speachy)
16:21:55Mode"#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat)
17:00
17:24:45rb-bluebotBuild Server message: New build round started. Revision 9b4e784560, 303 builds, 8 clients.
17:26:55_bilguschris_s I *think* thats all the bugs I just introduced, maybe it might help the others but nightpod still fails at the volume vp %pv(58,19,204,2,noborder) the check is 204_58 > 240
17:27:03_bilgus204 + 58
17:33:37_bilgusfrankenpod via the forums informs that the ipod video has a width of 320 and indeed https://github.com/Rockbox/rockbox/blob/master/firmware/export/config/ipodvideo.h#L55
17:34:28rb-bluebotBuild Server message: Build round completed after 583 seconds.
17:34:31rb-bluebotBuild Server message: Revision 9b4e784560 result: 875 errors 373 warnings
17:34:48_bilgussigh
17:40:00rb-bluebotBuild Server message: New build round started. Revision 542609bb31, 303 builds, 8 clients.
17:40:42_bilgusanyway I have to leave but I'll look into it further this eve @chris_s
17:43:09speachy...that's a lot of red. :D
17:44:19speachybtw, one of my beefy builders is offline after that home server meltdown, but the other builder ended up going to 20c/40t (from 16/32) which offset it a bit.
17:45:19_bilgusif it doesn't fix it I'll get it in 3 hrs
17:55:21rb-bluebotBuild Server message: Build round completed after 922 seconds.
17:55:22rb-bluebotBuild Server message: Revision 542609bb31 result: All green
17:57:11***Saving seen data "./dancer.seen"
18:00
18:29:56 Join chris_s [0] (~chris_s@dslb-084-058-026-110.084.058.pools.vodafone-ip.de)
18:30:20chris_slooks like that did it - awesome! :)
18:31:26 Quit chris_s (Client Quit)
19:00
19:00:23 Quit lebellium (Quit: Leaving)
19:02:32 Quit ZincAlloy (Quit: Leaving.)
19:05:13 Join munkis [0] (~mendel_mu@ool-ae2cb229.dyn.optonline.net)
19:10:53 Quit munkis (Remote host closed the connection)
19:13:45 Join munkis [0] (~mendel_mu@ool-ae2cb229.dyn.optonline.net)
19:16:26_bilguschris_s did it for nightpod? I still can't get it to pass
19:17:46_bilgusoh nevermind It did :) good
19:37:02_bilgusspeachy I noticed the build speed thats awesome :) I still remember doing the build farm script on my personal PC taking at least a day back in the day
19:57:13***Saving seen data "./dancer.seen"
20:00
20:37:02 Quit blbro[m] (Ping timeout: 240 seconds)
20:38:10 Join blbro[m] [0] (~blbrostra@2001:470:69fc:105::8f7)
20:55:09rb-bluebotBuild Server message: New build round started. Revision 20b9ce5497, 303 builds, 7 clients.
20:56:17_bilgusthe automatic scrolling in the OS threads menu had to go it was not so great, manual scrolling FTW
21:00
21:12:04rb-bluebotBuild Server message: Build round completed after 1014 seconds.
21:12:14rb-bluebotBuild Server message: Revision 20b9ce5497 result: All green
21:57:17***Saving seen data "./dancer.seen"
22:00
22:02:27 Quit prg (Quit: ZNC 1.8.2 - https://znc.in)
22:06:14 Join prg [0] (~prg@xannode.com)
23:00
23:57:18***Saving seen data "./dancer.seen"

Previous day | Next day