Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2022-10-24

00:01:01 Quit chris_s (Quit: Connection closed)
00:18:28 Quit massiveH (Read error: Connection reset by peer)
00:18:54_bilguswell we could always up the limit but there is like 65 -80 bytes per entry
00:19:24_bilgusbased on my back of envelope calcs
00:23:29***Saving seen data "./dancer.seen"
00:37:10 Quit m01 (Quit: Konversation terminated.)
00:39:17 Join m01 [0] (
01:19:23 Quit amiconn (Quit: - Chat comfortably. Anywhere.)
01:19:23 Quit pixelma (Quit: .)
01:21:47 Join amiconn [0] (
01:21:50 Join pixelma [0] (
02:04:39 Join chris_s [0] (
02:06:22chris_sI was a bit surprised that the fds would even stay open, but looking at font_load() that appears to be by design
02:06:37chris_s"cached font: pf->fd stays open until the font is unloaded "
02:20:58spork7 fonts sounds like a lot for a theme
02:23:32***Saving seen data "./dancer.seen"
02:23:33sporkbtw, it is not easy to find a theme by name or resolution unless i am searching wrong
02:24:26spork'all themes' is the only way i found
02:25:16spork1 typeface in 7 sizes/weights then
02:25:21_bilgusspork, at the bottom of 'You can also directly search for specific themes here: '?
02:26:29sporksure, but like chris_s mentions a resolution that is not an index as such
02:26:49sporksorry, it is
02:26:57_bilgusfont scaling would probably be a good add
02:27:07sporki would bump that search to the top of the page
02:28:18sporkhmm, i have a 320x240 device, i must try that theme
02:28:31_bilguseh most people aren't searching for a specific theme persay they probably scroll through the pics first
02:28:49sporkmost people are not most people
02:29:09sporkespecially with rockbox, everybody has their own usage
02:29:41_bilgusmy point being just as many never need the search fuction as do
02:30:06sporkof course
02:30:27sporkbut it is 2 lines and now it is 'buried' at the bottom
02:31:05sporki found it, i will be good bow
02:31:51chris_sMaybe there should be a warning when loading a theme that could result in unexpected behavior due to all fds being used up
02:33:22_bilgusmsybe a splash about no file handles left
02:33:29_bilgusif there isn't one
02:34:08chris_smaybe not when loading the theme
02:34:11sporkmake the number of fd's dependent on the available memory
02:34:20sporkif memory usage is the concern
02:34:41sporkthat specific theme is going to run on the less constrained devices
02:35:31_bilgusits probably not being that the screen size is pretty big
02:35:37chris_salthough if you're just showing a splash when/that there are no fd's left, the user may not realize it has anything to do with the theme used
02:36:39_bilgusno probably not but it seems a lot of code to do it just based on the theme font number rather than just having a splash that covers all cases
02:37:14_bilgusbut i'd go for increasing the fds for the bigger memory devices
02:37:18_bilgusper spork
02:37:40_bilgusalthough whats to stop the next theme from using most of those
02:38:15_bilgusbetter would probably be to force unloading some of the cache as well
02:39:13_bilgusmake an event EV_FD_DEPLETED or something
02:39:40_bilgushave the cache register to listen and kick out the oldest
02:39:48sporkipod video has 32MB so a couple of extra 80 bytes would not hurt
02:46:18 Quit paulk (Ping timeout: 264 seconds)
02:46:40 Join paulk [0] (
02:47:10 Quit chris_s (Quit: Connection closed)
02:55:04_bilgus g#4738
02:55:07rb-bluebotGerrit review #4738 at : increase the number of file and directory handles for devices with more ram by William Wilgus
02:56:55_bilgusI *think* thats proper
02:56:59sporki would argue <32 and >=32 as on 32 it would be fine
02:58:34sporkand there are no devices with 33 or so, the next step probably is 64
02:59:36_bilgusi upped all except the < 8 mb
03:00:49_bilgusi just put in a little less for 16mb or less
03:00:52sporkyes, i get that
03:01:42sporkjust do not think the <=32 is needed and <32 would do too
03:02:07sporkipodvideo had 32 i think
03:02:42_bilgusi'd rather be a little conservative on devices I can't test
03:02:56sporkfair enough
03:16:01_bilguswell the one peoblem I see with having a splash when you run out of descriptors is it'd probably make the device wholy unusable with the splashes
03:16:25_bilgusso I think maybe limiting the number of times it gets displayed prudent
03:25:02 Join chris_s [0] (
03:31:14chris_snice – one possible edge case is that grayscale devices may crash when the grayscale overlay (lib/grey.h) is running at the time that the splash is displayed. But that's probably a negligible concern that applies to other scenarios where an error splash is displayed as well.
03:32:37chris_ssorry, apps/plugins/lib/grey.h
03:33:53chris_snumber of fonts used is probably not an issue there
03:42:03_bilgusmmm that is a good point I could see running out of handles in a plugin
04:23:35***Saving seen data "./dancer.seen"
05:05:24 Quit chris_s (Quit: Connection closed)
06:23:39***Saving seen data "./dancer.seen"
08:23:40***No seen item changed, no save performed.
10:23:44***No seen item changed, no save performed.
11:38:35 Join othello7 [0] (
12:23:49***No seen item changed, no save performed.
12:44:02 Quit paulcarroty (Quit: Bridge terminating on SIGTERM)
12:44:02 Quit MayeulC (Quit: Bridge terminating on SIGTERM)
12:44:03 Quit e-user[m] (Quit: Bridge terminating on SIGTERM)
12:44:03 Quit popcorn9499[m] (Quit: Bridge terminating on SIGTERM)
12:44:03 Quit blbro[m] (Quit: Bridge terminating on SIGTERM)
12:44:13 Quit underpantsgnome[ (Quit: Bridge terminating on SIGTERM)
12:48:26 Join MayeulC [0] (~mayeulc@2001:470:69fc:105::35e)
12:54:47 Join paulcarroty [0] (~paulcarro@2001:470:69fc:105::216)
12:54:48 Join underpantsgnome[ [0] (~tinybronc@2001:470:69fc:105::2:1af6)
12:54:54 Join popcorn9499[m] [0] (~popcorn94@2001:470:69fc:105::2:11cc)
12:55:00 Join e-user[m] [0] (~e-usermat@2001:470:69fc:105::1:2763)
12:55:21 Join blbro[m] [0] (~blbrostra@2001:470:69fc:105::8f7)
14:23:52***Saving seen data "./dancer.seen"
15:47:41 Join lebellium [0] (
16:19:30 Quit kirvesAxe (*.net *.split)
16:19:30 Quit gevaerts (*.net *.split)
16:19:30 Quit Xeha (*.net *.split)
16:19:31 Quit user890104 (*.net *.split)
16:19:40 Join user890104 [0] (~Venci@freemyipod/user890104)
16:20:06 Join kirvesAxe [0] (kirvesaxe@user/kirvesaxe)
16:22:07 Join Xeha [0] (~Xeha@user/Xeha)
16:23:54***Saving seen data "./dancer.seen"
16:24:48 Join gevaerts [0] (~fg@user/gevaerts)
17:11:01 Quit mixfix41 (Ping timeout: 272 seconds)
18:23:55***Saving seen data "./dancer.seen"
18:34:07 Quit lebellium (Quit: Leaving)
19:27:25 Quit rb-bluebot (Ping timeout: 252 seconds)
19:27:25 Quit bluebrother (Ping timeout: 252 seconds)
19:29:05 Join bluebrother [0] (~dom@user/bluebrother)
19:42:01 Join rb-bluebot [0] (~rb-bluebo@rockbox/bot/utility)
20:23:58***Saving seen data "./dancer.seen"
21:10:43 Quit yosafbridge (K-Lined)
21:25:27 Join yosafbridge [0] (
21:37:12 Quit kakaszsz (Ping timeout: 260 seconds)
21:51:10 Join kakaszsz [0] (
22:00:36 Quit tomato (Quit: The Lounge -
22:01:22 Join tomato [0] (~tomato@user/tomato)
22:24:01***Saving seen data "./dancer.seen"
22:34:37 Quit othello7 (Quit: othello7)
22:47:25 Join othello7 [0] (

Previous day | Next day