00:43:15 | | Quit massiveH (Quit: Leaving) |
01:00 |
01:50:32 | *** | Saving seen data "./dancer.seen" |
02:00 |
02:03:56 | | Join advcomp2019__ [0] (~advcomp20@user/advcomp2019) |
02:07:34 | | Quit advcomp2019_ (Ping timeout: 268 seconds) |
02:57:31 | | Quit advcomp2019__ (Read error: Connection reset by peer) |
02:57:54 | | Join advcomp2019__ [0] (~advcomp20@user/advcomp2019) |
02:58:47 | | Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) |
03:00 |
03:02:24 | | Quit advcomp2019__ (Ping timeout: 260 seconds) |
03:50:33 | *** | Saving seen data "./dancer.seen" |
04:00 |
04:21:10 | | Join advcomp2019 [0] (~advcomp20@user/advcomp2019) |
04:23:39 | | Quit advcomp2019 (Client Quit) |
04:24:39 | | Quit advcomp2019_ (Ping timeout: 260 seconds) |
04:31:51 | | Join advcomp2019 [0] (~advcomp20@user/advcomp2019) |
04:33:15 | _bilgus | amachronic (logs) I'm having an issue reloading the tagtree on the fly my tagnav.lua plugin makes use of a reload menu item but I get a data abort when I try to use it now |
04:35:20 | _bilgus | it happens here https://github.com/Rockbox/rockbox/blob/master/apps/tagtree.c#L1817= |
04:36:32 | _bilgus | it won't even enter the tagtree_init call without crashing but if I just paste the contents of tagtree_init it works fine, I'm guessing its because it no longer holds the lock once the handle if free |
04:36:57 | _bilgus | *once the handle is free |
04:47:20 | | Join lebellium [0] (~lebellium@2a01cb040109a6004d11307f38fd773b.ipv6.abo.wanadoo.fr) |
05:00 |
05:07:46 | _bilgus | huh somethings weird I just made the init function static and its fine too |
05:12:29 | _bilgus | g#4879 |
05:12:32 | rb-bluebot | Gerrit review #4879 at https://gerrit.rockbox.org/r/c/rockbox/+/4879 : RFC BugFix tagtree.c reload data abort by William Wilgus |
05:14:33 | _bilgus | Ive no clue maybe it has something to do with it being a public function?? |
05:30:12 | | Join amachronic [0] (~amachroni@user/amachronic) |
05:34:07 | amachronic | _bilgus tagtree_init() is marked INIT_ATTR so the code gets overwritten at some point |
05:37:14 | amachronic | looks like most targets copy init code to the codec buffer. |
05:38:10 | amachronic | I think there's something we can put in the linker scripts to make it spit errors if there are references between certain sections |
05:40:26 | amachronic | something like NOCROSSREFS_TO(.init .text) |
05:42:27 | amachronic | marking more things INIT_ATTR might be a good way to save code size, actually. |
05:50:35 | *** | Saving seen data "./dancer.seen" |
06:00 |
06:06:53 | rb-bluebot | Build Server message: New build round started. Revision 90dc64da32, 303 builds, 8 clients. |
06:25:09 | _bilgus | ahh I figured it might be something like that |
06:27:05 | _bilgus | odd that it worked before though |
06:27:32 | _bilgus | or was that something recently added because I generally see it in the .c file not the .h I think |
06:32:04 | amachronic | that particular INIT_ATTR has been there a long time |
06:33:12 | amachronic | i'm not sure what the rules are with gcc attributes but usually it's safest to put them on the function prototype |
06:34:10 | rb-bluebot | Build Server message: Build round completed after 1636 seconds. |
06:34:21 | rb-bluebot | Build Server message: Revision 90dc64da32 result: All green |
06:34:54 | rb-bluebot | Build Server message: New build round started. Revision 03c225fe54, 303 builds, 8 clients. |
06:39:56 | _bilgus | ah crap thats going to break |
06:40:19 | _bilgus | I added a changed header file to the no functional changes |
06:43:37 | rb-bluebot | Build Server message: Build round completed after 523 seconds. |
06:43:43 | rb-bluebot | Build Server message: Revision 03c225fe54 result: 2762 errors 0 warnings |
06:43:47 | rb-bluebot | Build Server message: New build round started. Revision 98c7505c60, 303 builds, 8 clients. |
06:45:18 | | Quit CH23_M (Read error: Connection reset by peer) |
06:46:10 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
06:50:06 | _bilgus | lol just in time to get the other red off the board |
06:50:27 | _bilgus | I just don't like the table compact clearly |
06:52:38 | rb-bluebot | Build Server message: Build round completed after 532 seconds. |
06:52:40 | rb-bluebot | Build Server message: Revision 98c7505c60 result: 2762 errors 0 warnings |
06:52:44 | rb-bluebot | Build Server message: New build round started. Revision f033fd390e, 303 builds, 8 clients. |
07:00 |
07:26:51 | rb-bluebot | Build Server message: Build round completed after 2047 seconds. |
07:26:53 | rb-bluebot | Build Server message: Revision f033fd390e result: All green |
07:30:16 | rb-bluebot | Build Server message: New build round started. Revision 8f582c90de, 303 builds, 8 clients. |
07:50:37 | *** | Saving seen data "./dancer.seen" |
08:00 |
08:01:51 | rb-bluebot | Build Server message: Build round completed after 1896 seconds. |
08:01:53 | rb-bluebot | Build Server message: Revision 8f582c90de result: 8 errors 0 warnings |
08:02:00 | rb-bluebot | Build Server message: New build round started. Revision 3957aa8720, 303 builds, 7 clients. |
08:03:51 | amachronic | ok so that broke the database tool |
08:17:28 | _bilgus | that gets me a lot that and CheckWps |
08:17:47 | _bilgus | I never think to test them |
08:23:29 | _bilgus | so before I decided to go all rearranging the playlist files my mutex adventures seem pretty solid I need to try and free some of the binsize though its something like an extra 700 bytes probably a few places its not actually needed and some code cleanup to get it down a bit |
08:29:55 | rb-bluebot | Build Server message: Build round completed after 1674 seconds. |
08:29:57 | rb-bluebot | Build Server message: Revision 3957aa8720 result: 8 errors 0 warnings |
08:30:02 | rb-bluebot | Build Server message: New build round started. Revision 879b5dae39, 303 builds, 7 clients. |
09:00 |
09:03:18 | | Join mink [0] (~mink@2a02:aa12:b106:1b80:156f:dbfc:442d:dbaa) |
09:07:55 | rb-bluebot | Build Server message: Build round completed after 2273 seconds. |
09:07:57 | rb-bluebot | Build Server message: Revision 879b5dae39 result: All green |
09:13:12 | | Quit amachronic (Quit: amachronic) |
09:19:17 | | Quit mink (Remote host closed the connection) |
09:46:04 | | Quit CH23_M (Ping timeout: 260 seconds) |
09:47:19 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
09:50:38 | *** | Saving seen data "./dancer.seen" |
11:00 |
11:01:56 | | Quit CH23_M (Read error: Connection reset by peer) |
11:02:43 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
11:03:24 | | Join mink [0] (~mink@2a02:aa12:b106:1b80:156f:dbfc:442d:dbaa) |
11:50:39 | *** | Saving seen data "./dancer.seen" |
13:00 |
13:22:58 | | Quit reductum (Quit: WeeChat 2.8) |
13:50:43 | *** | Saving seen data "./dancer.seen" |
14:00 |
14:27:59 | | Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) |
14:31:04 | | Quit advcomp2019 (Ping timeout: 252 seconds) |
15:00 |
15:20:24 | | Quit CH23 (Quit: Leaving) |
15:22:03 | | Join CH23 [0] (~CH23@revspace/participant/ch23) |
15:38:53 | | Quit mink (Remote host closed the connection) |
15:43:35 | | Join mink [0] (~mink@2a02:aa12:b106:1b80:156f:dbfc:442d:dbaa) |
15:50:45 | *** | Saving seen data "./dancer.seen" |
17:00 |
17:50:49 | *** | No seen item changed, no save performed. |
18:00 |
18:22:54 | | Join massiveH [0] (~massiveH@2600:4040:a993:4900:758e:ceda:a21d:63b5) |
18:32:55 | | Quit lebellium (Quit: Leaving) |
18:57:00 | | Quit mink (Remote host closed the connection) |
19:00 |
19:03:53 | | Quit CH23 (Quit: Leaving) |
19:04:10 | | Join othello8 [0] (~Thunderbi@pool-100-36-133-223.washdc.fios.verizon.net) |
19:50:53 | *** | Saving seen data "./dancer.seen" |
20:00 |
20:09:04 | | Quit othello8 (Ping timeout: 260 seconds) |
20:37:26 | speachy | _bilgus: the forum thread about RTL stuff reminded me of of an oversight in our translation approach |
20:37:43 | speachy | namely how we handle incomplete translations. |
20:38:19 | speachy | instead of an entire language being marked as RTL, it needs to be marked on a per-string basis. |
20:38:58 | speachy | so untranslated strings (or ones that should be written in english or whatever) are rendered properly. |
20:39:42 | speachy | the same problem afflicts voice prompts; untranslated strings will be voiced using the "native" language rather than English, which is probably pretty wrong. |
20:43:30 | speachy | (and then there are the strings that mix RTL+LTR words in them. Some of the Arabic and Hebrew strings use english acronyms or words, that's gotta be wonky too) |
20:47:47 | speachy | the translate site doesn't get ltr correct in all places either. hah. |
20:49:14 | speachy | I think know how to deal with the voice generation so that incomplete translations get a two pass strategy, but I wonder if that's the correct way to deal with it. |
20:50:08 | speachy | but with respect to the UI strings, other than changing things so that each string is explicitly marked LTR/RTL (instead of global for the language) I'm open to suggestions. |
20:50:18 | | Join paulk [0] (~paulk@vpn-0-22.aquilenet.fr) |
20:50:40 | | Quit paulk-bis (Read error: Connection reset by peer) |
20:51:29 | | Join CH23 [0] (~CH23@revspace/participant/ch23) |
20:51:30 | speachy | (I was thinking that I could prepend each string with a one-byte flag to connote order...) |
20:55:58 | speachy | I wonder how complicated it would be to add locale-aware sorting/collating/capitalization, hmm.... |
21:00 |
21:32:39 | | Quit CH23 (Quit: Leaving) |
21:48:35 | | Join CH23 [0] (~CH23@revspace/participant/ch23) |
21:50:57 | *** | Saving seen data "./dancer.seen" |
23:00 |
23:02:54 | | Quit CH23_M (Read error: Connection reset by peer) |
23:03:06 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
23:37:15 | | Quit m01 (Quit: Konversation terminated.) |
23:39:23 | | Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net) |
23:51:01 | *** | Saving seen data "./dancer.seen" |
23:54:18 | rb-bluebot | Build Server message: New build round started. Revision 0550c64226, 303 builds, 7 clients. |