Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2022-12-14

00:23:16 Quit chris_s (Ping timeout: 272 seconds)
01:26:02 Quit CH23_M (Read error: Connection reset by peer)
01:26:38 Join CH23_M [0] (~CH23@revspace/participant/ch23)
01:27:59 Quit cb (Ping timeout: 252 seconds)
01:48:56 Quit pixelma (Quit: .)
01:48:56 Quit amiconn (Quit: - Chat comfortably. Anywhere.)
01:49:56 Join amiconn [0] (
01:49:56 Join pixelma [0] (
01:56:07***Saving seen data "./dancer.seen"
03:23:58 Join mink__ [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae)
03:56:10***No seen item changed, no save performed.
04:00:04 Quit mink__ (Remote host closed the connection)
04:15:01 Quit tchan (Read error: Connection reset by peer)
04:53:45 Quit _bilgus_ (Remote host closed the connection)
04:55:38 Join _bilgus_ [0] (~bilgus@
05:56:14***Saving seen data "./dancer.seen"
06:01:59 Join mink [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae)
07:15:01 Quit mink (Remote host closed the connection)
07:15:58 Join mink [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae)
07:56:16***Saving seen data "./dancer.seen"
07:58:31 Join tchan [0] (
09:51:55 Quit mink (Ping timeout: 265 seconds)
09:56:19***Saving seen data "./dancer.seen"
10:44:27 Join mink [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae)
10:44:41 Join massiveH [0] (~massiveH@2600:4040:a992:a300:f46a:a683:1be8:e918)
11:56:20***No seen item changed, no save performed.
12:05:22 Quit mink (Ping timeout: 252 seconds)
12:30:54 Quit massiveH (Quit: Leaving)
12:37:56 Quit CH23_M (Ping timeout: 272 seconds)
12:39:34 Join CH23_M [0] (~CH23@revspace/participant/ch23)
12:49:11 Join cb [0] (~calvin@
12:59:21 Join lebellium [0] (
13:24:50 Quit Malinux (Ping timeout: 256 seconds)
13:27:27 Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7)
13:34:51 Quit Malinux (Ping timeout: 256 seconds)
13:56:23***Saving seen data "./dancer.seen"
14:13:31 Quit jacobk (Ping timeout: 252 seconds)
14:19:24 Quit CH23_M (Read error: Connection reset by peer)
14:20:59 Join CH23_M [0] (~CH23@revspace/participant/ch23)
14:23:31 Join jacobk [0] (
14:39:24 Join Crash91 [0] (
14:42:22 Quit Crash91 (Client Quit)
15:56:24***Saving seen data "./dancer.seen"
16:39:06 Quit lebellium (Quit: Leaving)
17:39:04 Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7)
17:56:26***Saving seen data "./dancer.seen"
18:01:04 Quit Acou_Bass (Quit: ZNC 1.8.2 -
18:03:13 Join Piece_Maker [0] (
18:19:28 Quit kakaszsz (Read error: Connection reset by peer)
18:32:49 Join kakaszsz [0] (
19:29:01 Quit buZz (Ping timeout: 265 seconds)
19:30:49 Join buZz [0] (
19:31:13 Nick buZz is now known as Guest5990 (
19:56:29***Saving seen data "./dancer.seen"
20:31:08 Nick Guest5990 is now known as buZz (
21:56:31***No seen item changed, no save performed.
22:21:16 Join chris_s [0] (
22:25:43_bilgus_chris_s thats why I asked you to look :p ill update here once I process em
22:28:56_bilgus_missed that one on the shortcuts menu
22:29:15chris_sI figured you might not have been pleased after seeing the size increases due to my patch... :)
22:32:14_bilgus_I knocked more out rearranging the functions than I did your stuff
22:33:04_bilgus_AB Repeat will be getting some dummy functions next ifdef hell and all
22:38:07_bilgus_ok theme_enable should be sorted along with enter_shortcuts
22:38:48_bilgus_scroll stop is the only redundant part in calling theme_restore()
22:45:31_bilgus_Idk that its hot enough to warrant a conditional on it
22:47:54chris_sMakes sense to me the way you changed it if it improves readability and/or alleviates size concerns
22:48:08_bilgus_on the first iteration I actually made it do a goto restore; and it worked and saved like 100 bytes somehow but it didn't make the code flow all that great
22:48:59_bilgus_try to weigh code readablility higher than just size
22:50:46_bilgus_found a few parts that just didn't get used anymore too like the time delay on restore/update on vol change
22:52:02_bilgus_so is the playlist supposed to show the sbs then?
22:52:10chris_sthat volume function alway returning false was amusing...
22:52:37chris_sthe playlist - yes, otherwise there's still an issue
22:54:05_bilgus_ok I compared it to the original and got the same behavior
23:00:10_bilgus_I think thats everything if anything else let me know and I'll fix it (unless you want to) but I wouldn't expect you to..
23:01:01chris_ssounds good, I don't see anything atm
23:01:26_bilgus_I'm going to push this and move on to AB_REPEAT
23:04:57rb-bluebotBuild Server message: New build round started. Revision 6b87bfadff, 303 builds, 7 clients.
23:29:13chris_sHere's a weird one: When you set the WPS hotkey as a QuickScreen item and shuffle through the options, it eventually gets to the "Open Plugin" option and will show the File Browser, clashing with the Viewports of the QuickScreen
23:29:20chris_s(nothing to do with the latest commit)
23:29:49rb-bluebotBuild Server message: Build round completed after 1491 seconds.
23:29:53rb-bluebotBuild Server message: Revision 6b87bfadff result: All green
23:30:27chris_sI guess it's still sort of usable
23:33:21_bilgus_probably it needs something to lock to the browser vp
23:34:34_bilgus_yeah thats annoying
23:35:28_bilgus_either that or set as not quickscreenable
23:35:37_bilgus_but that seems like it might be handy
23:35:49chris_sor disable the callback in that context?
23:36:27_bilgus_yeah just have it use whatever is already ste
23:37:17 Quit m01 (Quit: Konversation terminated.)
23:39:27rb-bluebotBuild Server message: New build round started. Revision 99839960a2, 303 builds, 7 clients.
23:39:28 Join m01 [0] (
23:41:52 Quit Piece_Maker (Quit: ZNC 1.8.2 -
23:43:03 Join Piece_Maker [0] (
23:47:41_bilgus_chris_s g#4926
23:47:44rb-bluebotGerrit review #4926 at : [Bug Fix] quickscreen clashed with WPS Hotkey browser by William Wilgus
23:50:20_bilgus_I actually did move the flag_select for softlock/backlight exemption to banned from QS after a user complained about the same issue but its not nearly that simple
23:50:57_bilgus_oh and the haas_surround thing its been broken for YEARS
23:50:58chris_sthis looks good to me!
23:51:14_bilgus_it wasn't even switching modes
23:51:55_bilgus_like it turned on to 30ms if you selected 5ms then it never changed them except off or 30ms
23:54:22_bilgus_its actually set up in that commit to be capable of anything between 5ms and 30ms but I opted to leave it at the discreet intervals
23:55:55_bilgus_ive also gotten in the sim a few times now a race on the mutex between audio & buffer I thought that was caused by enabling haas but I ran into it today at head
23:56:31_bilgus_can't repro on device but its probably just not fast enough there
23:56:32***Saving seen data "./dancer.seen"
23:58:17rb-bluebotBuild Server message: Build round completed after 1129 seconds.
23:58:18rb-bluebotBuild Server message: Revision 99839960a2 result: All green

Previous day | Next day