00:06:14 | *** | Saving seen data "./dancer.seen" |
01:00 |
01:19:59 | | Quit massiveH (Quit: Leaving) |
01:31:08 | | Quit l0x0l (Read error: Connection reset by peer) |
02:00 |
02:01:37 | | Quit Bobathan_ (Quit: ZNC 1.8.2+deb2+b1 - https://znc.in) |
02:06:15 | *** | Saving seen data "./dancer.seen" |
02:08:37 | | Join Bobathan [0] (~admin@cpe-65-29-248-157.wi.res.rr.com) |
03:00 |
03:45:55 | | Quit CH23_M (Read error: Connection reset by peer) |
03:46:40 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
04:00 |
04:06:16 | *** | Saving seen data "./dancer.seen" |
05:00 |
05:08:03 | | Quit hexadecagram (Quit: ZNC 1.8.2 - https://znc.in) |
05:20:09 | | Join hexadecagram [0] (~acc@user/hexadecagram) |
05:22:35 | | Join lebellium [0] (~lebellium@2a01cb040109a600f4e8b604b5288743.ipv6.abo.wanadoo.fr) |
05:26:34 | | Quit CH23_M (Ping timeout: 252 seconds) |
05:28:04 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
06:00 |
06:06:21 | *** | Saving seen data "./dancer.seen" |
06:10:18 | | Quit CH23_M (Read error: Connection reset by peer) |
06:10:37 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
06:13:52 | | Quit jacobk (Ping timeout: 252 seconds) |
07:00 |
07:03:06 | | Join amachronic [0] (~amachroni@user/amachronic) |
07:04:19 | rb-bluebot | Build Server message: New build round started. Revision 855540e1f5, 303 builds, 6 clients. |
07:26:00 | _bilgus | <l0x0l> (logs?) its left over cruft fro svn I believe basically a tag that would be autofilled |
07:35:29 | rb-bluebot | Build Server message: Build round completed after 1870 seconds. |
07:35:31 | rb-bluebot | Build Server message: Revision 855540e1f5 result: All green |
07:37:42 | rb-bluebot | Build Server message: New build round started. Revision ea7b80dab0, 303 builds, 6 clients. |
07:39:23 | amachronic | _bilgus won't this commit prevent you from remapping things differently in locked context? |
07:43:29 | amachronic | I think the guy on the form wants rockbox to behave like the original m3k firmware |
07:43:59 | amachronic | it changes volume when unlocked but skips tracks when locked |
07:51:40 | _bilgus | well you can still by specifying them in the regular keymaps |
07:52:31 | _bilgus | problem is if I allow the LOCKED_CONTEXT flag you then need to specify it it in the remmap as well and that kinda sucks |
07:53:35 | _bilgus | nd I read tht as once locked it reverts to volume change rather than the remap they set |
07:55:12 | _bilgus | I'm kinda leaning towards if you want that kind of control then compile from source |
07:56:07 | _bilgus | keyremap is already on the cusp of exploding most end users brains as it is |
07:57:24 | amachronic | yeah the revert happens because the remap isn't covering LOCKED when it should be |
07:57:37 | amachronic | ie. the remap should really be in the LOCKED context only |
07:59:25 | _bilgus | but then you force everyone to have to specify it |
08:00 |
08:00:07 | amachronic | yep the whole point is to make the buttons do different things when locked |
08:00:11 | _bilgus | not that its hard to add another field but I question the add in complexity |
08:00:34 | _bilgus | i'd rather push those people to editing source |
08:06:20 | rb-bluebot | Build Server message: Build round completed after 1719 seconds. |
08:06:22 | rb-bluebot | Build Server message: Revision ea7b80dab0 result: All green |
08:06:23 | _bilgus | re previous commit I didn't see any more missing browse_context roots is there a way to warn at compile time if there is a mandatory field missing |
08:06:25 | *** | Saving seen data "./dancer.seen" |
08:06:46 | _bilgus | I suppose the crash is a runtime warning |
08:08:36 | amachronic | I don't think it's possible to warn about stuff like that but we could add a NULL check in rockbox_browse() |
08:08:42 | _bilgus | oddly I din't notice it outright on device just hung the player |
08:09:41 | _bilgus | it still browsed just fine though weird |
08:10:42 | rb-bluebot | Build Server message: New build round started. Revision 484a79fcc0, 303 builds, 6 clients. |
08:13:30 | _bilgus | I was already in the middle of adding in context flags I think it might be better to just add them outright in the list though ie. CONTEXT_STD_LOCKED CONTEXT_STD_REMOTE CONTEXT_STD_PLUGIN rather than having a flag |
08:15:58 | _bilgus | I'm still unsure though it seems to be bordering on being kafkaesque |
08:35:24 | amachronic | CONTEXT_LOCKED is or'd with a normal context so it kind of has to be a flag |
08:36:55 | _bilgus | not to the user though |
08:37:19 | rb-bluebot | Build Server message: Build round completed after 1597 seconds. |
08:37:21 | rb-bluebot | Build Server message: Revision 484a79fcc0 result: All green |
08:37:34 | amachronic | yeah you could put locked versions of the contexts in the list i just thought it'd be a bit unsightly :) |
08:43:21 | | Quit amachronic (Quit: amachronic) |
08:44:34 | _bilgus | I think itll be less confusing in the end its easier to add flags but then you have to select it and its not at all intuitive |
08:50:25 | | Quit kugel_ (Quit: Lost terminal) |
08:59:21 | | Join speachy [0] (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) |
08:59:22 | | Quit speachy (Changing host) |
08:59:22 | | Join speachy [0] (~speachy@rockbox/developer/speachy) |
08:59:22 | Mode | "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) |
09:00 |
09:00:42 | speachy | chris_s: Nice catch on those plugin hangs. We can change the optimization levels for those two games on the ipods but that's just papering over a bug. I wonder if it breaks on other targets too? |
09:01:08 | | Join kugel [0] (~kugel@ip4d164699.dynamic.kabel-deutschland.de) |
09:03:12 | speachy | I wonder if the TLSF stuff itself is the problem |
09:09:01 | speachy | huh, there's upstream tlsf updates. |
09:13:02 | speachy | apparently we've had problems with this on arm before. |
09:14:02 | _bilgus | yes |
09:14:26 | _bilgus | was going to say that the last time moving to 0x8 alignment fixed it |
09:14:34 | speachy | upstream definitely has some relevant changes vs what we have. |
09:14:40 | speachy | thre are other implementations though fwiw. |
09:15:31 | _bilgus | i'm going to say there wern't upstream updates the last time but it might have been that it didn't fix the issue |
09:16:27 | speachy | we have 2.4.4 plus our own changes, upstream I think is 2.4.6 −− 2.4.5 is some fixes for BSDs, and making printf optional (ie much of our local changes) |
09:16:51 | speachy | 2.4.6 consists of "fixed a bug in the realloc func (discovered by the rockbox project)" :D |
09:17:14 | _bilgus | :D |
09:17:33 | speachy | but here's another implementation that's a bit more recent: https://github.com/mattconte/tlsf |
09:20:16 | _bilgus | eh the 2.4.6 version was committed in 2012 |
09:20:29 | _bilgus | so probably a previous bug we uncovered |
09:21:36 | speachy | upstream uses -O2 |
09:22:21 | speachy | just changing our tlsf CFLAGS might suffice to fix those crashes chris_s found. |
09:22:37 | speachy | (and possibly others, heh) |
09:24:20 | _bilgus | memset isn't there some undefined behavior when using memset in a particular way on casted objects? |
09:28:10 | _bilgus | I bet if we align down to a multiple of 0x4 or 0x8 it'd work |
09:29:22 | _bilgus | or just do a memset the naive way |
09:30:11 | _bilgus | not that we shouldn't go to the latest TLSF but I bet it still crashes |
09:32:26 | speachy | if nothing else I want to reduce the delta between us and them |
09:36:30 | _bilgus | laudable goal :p |
09:39:01 | speachy | it's tiny, how much work can it be? :D |
09:43:42 | _bilgus | heh |
10:00 |
10:02:47 | | Quit CH23_M (Ping timeout: 246 seconds) |
10:04:47 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
10:06:29 | *** | Saving seen data "./dancer.seen" |
10:24:32 | | Quit CH23_M (Ping timeout: 272 seconds) |
10:27:08 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
10:40:12 | | Quit CH23_M (Read error: Connection reset by peer) |
10:40:57 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
11:00 |
11:01:48 | rb-bluebot | Build Server message: New build round started. Revision 85410589d1, 303 builds, 6 clients. |
11:26:45 | rb-bluebot | Build Server message: Build round completed after 1497 seconds. |
11:26:46 | rb-bluebot | Build Server message: Revision 85410589d1 result: All green |
11:40:30 | speachy | hmm, we can't call panicf() from within a codec. |
11:41:41 | speachy | or any plugin. |
11:46:24 | speachy | g#4978 |
11:46:28 | rb-bluebot | Gerrit review #4978 at https://gerrit.rockbox.org/r/c/rockbox/+/4978 : tlsf: Update to upstream 2.4.6 release by Solomon Peachy |
11:46:55 | speachy | I'm waiting for my mini2g to charge up sufficiently to test this out |
11:49:34 | | Join Schimon [0] (a2fe4b5ecb@irc.cheogram.com) |
11:58:27 | speachy | boomshine still seems b0rked on the mini2g with those changes. problem might not be tlsf though −− maybe it's unique to ipods due to them having more than one core? |
12:00 |
12:01:18 | speachy | ok, it's not crashing; music keeps playing but no input. |
12:02:04 | speachy | which means the updated tlsf would appear to be good. |
12:02:13 | speachy | (also works fine on the x3) |
12:06:30 | *** | Saving seen data "./dancer.seen" |
14:00 |
14:06:33 | *** | No seen item changed, no save performed. |
14:06:36 | _bilgus | boomshine is lua so proib something I missed |
14:24:38 | | Join fourHZ [0] (~fourHZ@92-52-40-121.dynamic.orange.sk) |
14:36:33 | speachy | I'll hold off on merging that until chris_s tests things out on his device. |
14:37:17 | speachy | but otherwise it's apparently a win-win. One thing this newer version gets us is panics if it detects internal corruption. so that'll eat a little mroe code space. |
14:49:59 | | Quit hexadecagram (Ping timeout: 260 seconds) |
14:59:25 | | Join chris_s [0] (~chris_s@ip-095-223-074-219.um35.pools.vodafone-ip.de) |
14:59:30 | chris_s | I was able to launch both Puzzles and Boomshine on the iPod video. |
14:59:45 | chris_s | Like you said, boomshine not reacting to input must have another cause, |
14:59:46 | chris_s | so maybe it's fixed on device, although both still crash in the Simulator for me. |
15:00 |
15:03:27 | | Quit chris_s (Client Quit) |
15:04:05 | | Quit Nezumi-sama (Ping timeout: 268 seconds) |
15:07:26 | speachy | whoops, didn't check sim build; had to fix a few things in the new tlsf. |
15:07:56 | speachy | still building... |
15:08:02 | speachy | (I miss my beefy workstation...) |
15:08:43 | speachy | boomshine runs in the sim for me, at least with the newer tlsf |
15:09:56 | speachy | that said, there's this: ERROR: path is not absolute: "$/rb_defines.lua" |
15:10:41 | | Join chris_s [0] (~chris_s@ip-095-223-074-219.um35.pools.vodafone-ip.de) |
15:10:50 | chris_s | probably because I'm on aarch64 |
15:11:49 | chris_s | or doing something wrong |
15:14:46 | | Quit chris_s (Client Quit) |
15:15:26 | speachy | hmm, that's a definite maybe. :D |
15:16:03 | | Join Nezumi-sama [0] (~narf@rrcs-67-53-148-69.west.biz.rr.com) |
15:16:14 | speachy | there's probably plenty of places where ARM is hardcoded as 32-bit |
15:18:37 | speachy | just for giggles, let's see how well this RPi3 does with compiling (and running) the simulator. :D |
15:21:13 | speachy | I'm gonna merge it |
15:22:05 | rb-bluebot | Build Server message: New build round started. Revision 485e96d6be, 303 builds, 6 clients. |
15:27:33 | speachy | ....let's see how long this rpi3 takes to build an ipodvideo simulator. |
15:49:09 | rb-bluebot | Build Server message: Build round completed after 1624 seconds. |
15:49:11 | rb-bluebot | Build Server message: Revision 485e96d6be result: All green |
16:00 |
16:03:43 | speachy | A bit over 25 minutes to do a from-scratch sim build on an aarch64 rpi3. |
16:06:35 | *** | Saving seen data "./dancer.seen" |
16:12:19 | rb-bluebot | Build Server message: New build round started. Revision 6ebec601f9, 303 builds, 6 clients. |
16:12:51 | speachy | and it just segfaults on me. :D |
16:13:05 | speachy | (granted I'm trying to use it over an SSH connection...) |
16:16:23 | _bilgus | chris_s I always get that absolute path message in the sims |
16:22:43 | _bilgus | I still get a seg fault in the 4g sim too |
16:23:01 | _bilgus | with boomshine |
16:26:15 | speachy | I wonder if it's a threading thing. |
16:31:10 | _bilgus | Its all of lua |
16:31:37 | _bilgus | I guess thats worse |
16:35:51 | speachy | Ugh, really wish we used pthread natively. |
16:36:36 | speachy | the ipods are our only SMP targets... |
16:46:51 | _bilgus | well at least the sim reproduces it |
16:46:59 | _bilgus | the clipZipSim crashes as well |
16:47:08 | _bilgus | i'll try on device |
16:47:56 | rb-bluebot | Build Server message: Build round completed after 2138 seconds. |
16:47:58 | rb-bluebot | Build Server message: Revision 6ebec601f9 result: 5 errors 1 warnings |
16:49:31 | _bilgus | asan on the clip zip sim gives a few warnings /home/bilgus/Desktop/RockboxDev/rockbox/firmware/pcm_sw_volume.c:369:32: runtime error: left shift of negative value -340 |
16:49:53 | _bilgus | sorry |
16:49:54 | _bilgus | tlsf.c:345:24: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' |
16:50:06 | _bilgus | tlsf.c:328:26: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself |
16:50:22 | _bilgus | and tlsf.c:350:26: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' |
16:52:21 | _bilgus | hmm the clipv2 doesn't have a hold button wonder whats up with that |
16:58:07 | _bilgus | re. TLSF it works on the device still but thats also an older compiler |
17:00 |
17:02:29 | _bilgus | on the clipV2 thats a weird error maybe a linker problem?? |
17:02:45 | _bilgus | action.o: In function `get_action_worker.constprop.7 |
17:08:13 | | Join amachronic [0] (~amachroni@user/amachronic) |
17:11:55 | _bilgus | huh maybe the clipV2 does have a hold button |
17:14:16 | amachronic | speachy: you're forgetting the multi-core ipods don't have cache coherency between cores. major footgun there! |
17:15:24 | rb-bluebot | Build Server message: New build round started. Revision 3def8fee8c, 303 builds, 6 clients. |
17:16:46 | _bilgus | amachronic I found a few naggles adding HAVE_LOCKED_ACTIONS but I think I have them worked out now −− we could probably add it to all device with softlock at this point and just make it fallthrough to the std actions as I did with the clips |
17:17:18 | _bilgus | well sand clipv1/v2 |
17:17:23 | amachronic | sounds good to me! |
17:17:23 | _bilgus | sans* |
17:35:11 | amachronic | does anyone have an opinion about killing off named buflib allocs entirely? |
17:35:46 | amachronic | _bilgus i know you were concerned about making debugging harder |
17:36:22 | amachronic | i'm of the opinion it's rarely useful, memory errors are better caught in the sim, and it reduces buflib complexity greatly. |
17:36:33 | amachronic | also it saves a good chunk of binsize |
17:38:07 | amachronic | gating the name support behind a debug flag works but would uglify the code with IF_BUFLIB_NAME("foo",) stuff like we have IF_MV(x) for multivolume, which I'd rather not do. |
17:43:08 | _bilgus | amachronic I've had to track down buffers before it'd suck to have to write in a bunch of splashses or logfs to do it |
17:44:24 | _bilgus | but I can't argue with reduced complexity since it is strictly a debugging concern |
17:44:49 | rb-bluebot | Build Server message: Build round completed after 1765 seconds. |
17:44:50 | rb-bluebot | Build Server message: Revision 3def8fee8c result: All green |
17:45:38 | amachronic | i always thought the only place you can see the names is in the debug menu which isn't that useful |
17:48:25 | _bilgus | that is the only place so it'll still allow you to see what chunk of ram an error is reffing but no clue what code unit to start in |
17:49:14 | _bilgus | I suppose they are in order so that might be enough context idk |
17:50:51 | _bilgus | luckily its been a long while since I've had any buflib issues so eh toss up |
17:51:45 | amachronic | I guess there'd be some use for bugs that only repro on device |
17:52:19 | _bilgus | somewhere around this time g#2006 |
17:52:23 | rb-bluebot | Gerrit review #2006 at https://gerrit.rockbox.org/r/c/rockbox/+/2006 : Buflib add range checks blocks and crc_slot raise panic if out of range by William Wilgus |
17:53:18 | _bilgus | ah the commit just before that I tracked down |
17:54:21 | _bilgus | not that it was strictly needed it allowed me to see what was before and after the buffer to go looking |
17:54:28 | amachronic | yeah I see how it'd be useful |
17:56:03 | amachronic | wouldn't malloc-backed buflib + ASAN achieve pretty much the same thing though? |
17:56:48 | amachronic | if I'm reading right g#2005 was a buffer overflow into some other buffer |
17:56:50 | rb-bluebot | Gerrit review #2005 at https://gerrit.rockbox.org/r/c/rockbox/+/2005 : Fix tree.c->tree_get_entry_at() buffer overflow by William Wilgus |
17:57:52 | _bilgus | yeah it probably would |
17:58:10 | _bilgus | one way to find out |
17:59:25 | amachronic | guess I'll implement a malloc version of buflib then :) |
18:00 |
18:01:37 | amachronic | by the way g#4982 might fix lua woes on ipod |
18:01:39 | rb-bluebot | Gerrit review #4982 at https://gerrit.rockbox.org/r/c/rockbox/+/4982 : lua: rocklib_events fix by Aidan MacDonald |
18:03:11 | amachronic | i remembered coming across the odd COP thread there when you were doing the playlist mutex patches |
18:03:23 | _bilgus | yeah probably the issue of no actions but its crashing in the sims atm |
18:04:28 | _bilgus | I probably should get an ipod but i've been so anti apple for so long its hard to justify |
18:06:39 | *** | No seen item changed, no save performed. |
18:08:49 | _bilgus | amachronic running the sim with that patch lua now works do simulators get COP even when the device doesn't? |
18:09:04 | _bilgus | or its just another alignment thing |
18:09:07 | amachronic | i just built a 4g sim myself and it worked |
18:09:26 | amachronic | no idea why |
18:09:39 | _bilgus | i'll try adding some junk at the end of the plugin |
18:12:47 | amachronic | well no COP emulation on the sim it's only single core |
18:13:11 | amachronic | is this an ARM only bug? |
18:18:59 | | Quit CH23_M (Ping timeout: 255 seconds) |
18:19:35 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
18:20:03 | _bilgus | was the last time |
18:23:59 | _bilgus | ah bringing your patch up to HEAD the crash returns |
18:34:36 | amachronic | yeah that was my mistake |
18:35:57 | _bilgus | well messing with alignment doesn't seem to fix it this time |
18:36:41 | _bilgus | its probably just conflated with speachys tlsf update but IDK for sure |
18:36:56 | _bilgus | i'll have to try the build just before that |
18:38:20 | _bilgus | probably the issue was the COP on the ipod though |
18:38:59 | _bilgus | yeah going to review -d I056ca2c0ee27e6cc7946166cf52461efda0ee1fb |
18:39:12 | _bilgus | fixes the issue with the clipzip sim |
18:40:09 | _bilgus | odd that it doesn't carry over to the device so might just be (un) lucky but I'm asan is probably right |
18:40:22 | _bilgus | I'm sure* |
18:42:08 | amachronic | I stubbed out tlsf in the sim with system malloc and still got a crash so it's a lua bug, not a tlsf bug. |
18:44:11 | amachronic | er sorry i forgot stdlib.h and it did something stupid |
18:44:30 | amachronic | it works now that i stubbed out tlsf so it IS a tlsf bug. |
18:45:25 | | Join massiveH [0] (~massiveH@2600:4040:a992:a300:acdf:c010:6d16:f5a8) |
18:46:55 | _bilgus | yeah I don't see anything that jumps right out and bytes me heh |
18:47:13 | _bilgus | but I guess we will eventually track it down |
18:47:44 | _bilgus | lua is a good test for tlsf it is very heavy in the memory churn |
18:54:00 | speachy | _bilgus: just realized/remembered that my local toolchains are all GCC 8.5 |
18:56:00 | speachy | amachronic: and yeah, I know about the lack of coherency. tlsf has locking support but we've never had them turned on... |
18:56:30 | speachy | if lua is threaded it might trigger tlsf more. |
18:59:36 | _bilgus | its only pseudo threaded |
18:59:44 | _bilgus | well except on ipod |
19:00 |
19:00:08 | _bilgus | essentially it locks the state and jumps into c |
19:01:38 | _bilgus | but it does churn the ram I did some tests a while ago and it is all over the place allocating and freeing like crazy |
19:02:01 | _bilgus | just start up along boggled my mind when I was logging it |
19:02:05 | _bilgus | alone* |
19:04:54 | | Quit CH23_M (Read error: Connection reset by peer) |
19:05:12 | | Join CH23_M [0] (~CH23@revspace/participant/ch23) |
19:19:23 | | Quit amachronic (Quit: amachronic) |
20:00 |
20:06:43 | *** | Saving seen data "./dancer.seen" |
20:12:34 | | Quit Nezumi-sama (Ping timeout: 260 seconds) |
20:14:05 | | Join Nezumi-sama [0] (~narf@rrcs-67-53-148-69.west.biz.rr.com) |
20:22:15 | munkis | git bisect becomes less useful when debugging an intermittent fault which only appears on hardware |
21:00 |
21:41:02 | __builtin | speachy: apologies if I'm out of the loop, but why does flyspray inject a bunch of "Warning: Undefined array key..." errors into the HTML output? https://www.rockbox.org/tracker/task/13376 for example |
22:00 |
22:06:45 | *** | Saving seen data "./dancer.seen" |
23:00 |
23:17:23 | | Quit Schimon (Ping timeout: 256 seconds) |
23:37:10 | | Quit m01 (Quit: Konversation terminated.) |
23:39:25 | | Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net) |
23:40:48 | | Quit Piece_Maker (Quit: ZNC 1.8.2 - https://znc.in) |
23:41:21 | | Join Piece_Maker [0] (~eddie@cpc95736-bolt17-2-0-cust330.10-3.cable.virginm.net) |