Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2023-01-02

00:01:34_bilgusmaybe we can store it in the top of ->size
00:02:49_bilgusthat would limit an alloc to ~1gb
00:05:14_bilgusah but since it uses null pointrs that wouldn't work
00:05:51_bilgusyeah I'm going to say we are going to have to remove the sanity checks to get this kosher
00:07:19***Saving seen data "./dancer.seen"
00:15:30_bilgus g#5005
00:15:32rb-bluebotGerrit review #5005 at https://gerrit.rockbox.org/r/c/rockbox/+/5005 : tlsf remove corruption checks by William Wilgus
00:51:11 Quit massiveH (Quit: Leaving)
01:00
01:05:56_bilgusoh I just got it to work by using &~STATE_MASK instead of & BLOCK_SIZE
01:15:45_bilgusand ~PTR_MASK WEIRD
01:16:42_bilgusconsidering ~PTR_MASK == BLOCK_SIZE I'm not getting why
01:58:51 Quit kugel (Ping timeout: 248 seconds)
01:59:18 Join kugel [0] (~kugel@ip4d164699.dynamic.kabel-deutschland.de)
02:00
02:07:20***Saving seen data "./dancer.seen"
04:00
04:07:21***No seen item changed, no save performed.
05:00
05:23:35 Quit Romster (Ping timeout: 246 seconds)
05:23:47 Join hexadecagram [0] (~acc@user/hexadecagram)
05:24:47 Join Romster [0] (~romster@158.140.215.184)
05:38:00 Quit speachy (Quit: WeeChat 3.6)
06:00
06:07:25***Saving seen data "./dancer.seen"
08:00
08:07:28***No seen item changed, no save performed.
08:40:47 Quit CH23_M (Read error: Connection reset by peer)
08:41:00 Join CH23_M [0] (~CH23@revspace/participant/ch23)
08:57:59 Join speachy [0] (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net)
08:57:59 Quit speachy (Changing host)
08:57:59 Join speachy [0] (~speachy@rockbox/developer/speachy)
08:57:59Mode"#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat)
08:58:34speachy_bilgus: given that this problem supposedly goes away when -O2 (vs -Os) is used, it's presumably something pretty subtle that is confusing the optimizer.
08:58:52speachy(upstream uses -O2)
09:00
09:04:22speachycould also be a signed/unsigned issue.
09:04:42speachysizeof(x) is unsigned, and 0xffffffff is signed
09:05:51speachyIMO makes more sense to #define BLOCKSIZE (~PTR_MASK)
09:06:14speachyyay for C int promotion. :D
09:14:48_bilgusthat makes some sense i'll try adding u to that define
09:17:09_bilgusnah no dice would have been great had it worked
09:20:02speachybut does changing BLOCK_SIZE to ~PTR_MASK work?
09:20:09speachy(well, probably will)
09:21:05speachyand heh 0xffffffff isn't correct for 64-bit platforms either.
09:23:53_bilgushttps://godbolt.org/z/TWjeE3nde
09:24:11_bilgusgodbolt sez you are exactly correct
09:25:41 Quit CH23_M (Read error: Connection reset by peer)
09:26:08 Join CH23_M [0] (~CH23@revspace/participant/ch23)
09:27:10_bilgusIdk the implications of changing BLOCK_SIZE to ~PTR_MAASK though as in the rest of the cases its not being used on a memory address
09:27:56_bilgusI'd assume there is a reason where as the latter author was just being 'clever'
09:28:14speachynah, just hardware-centric
09:28:41speachydon't appreciate what it takes to be "portable"
09:29:40_bilguswell ~STATE_MASK works and imo mkes more sense looking at the code
09:30:09_bilgusnot like the bits of that change between devices
09:32:15_bilgusand the bits beyond that shouldn't change anyway so & BLOCK_SIZE just msking already 0'd bits
10:00
10:07:30***Saving seen data "./dancer.seen"
10:13:58rb-bluebotBuild Server message: New build round started. Revision 6cbf2160e5, 303 builds, 7 clients.
10:14:07_bilgusok fix is pushed
10:15:45_bilgusspeachy was that ndantam 's branch on github that you grabbed as upstream? I found that one matched and filed an issue
10:35:31rb-bluebotBuild Server message: Build round completed after 1293 seconds.
10:35:33rb-bluebotBuild Server message: Revision 6cbf2160e5 result: All green
10:39:05speachyyep, that was it
10:39:22speachyand I was going to report an issue too then I saw yours :)
10:41:00 Quit speachy (Quit: WeeChat 3.6)
11:00
11:09:02rb-bluebotBuild Server message: New build round started. Revision a00bd421ac, 303 builds, 7 clients.
11:15:29 Quit CH23_M (Ping timeout: 260 seconds)
11:15:51 Join CH23_M [0] (~CH23@revspace/participant/ch23)
11:17:37 Quit CH23_M (Read error: Connection reset by peer)
11:18:03 Join CH23_M [0] (~CH23@revspace/participant/ch23)
11:28:00rb-bluebotBuild Server message: Build round completed after 1139 seconds.
11:28:03rb-bluebotBuild Server message: Revision a00bd421ac result: All green
12:00
12:00:12 Join CH23- [0] (~CH23@84-107-29-234.cable.dynamic.v4.ziggo.nl)
12:01:29 Quit CH23_M (Quit: Quit)
12:04:14 Quit CH23 (Quit: Leaving)
12:07:32***Saving seen data "./dancer.seen"
12:18:13 Nick CH23- is now known as CH23 (~CH23@84-107-29-234.cable.dynamic.v4.ziggo.nl)
12:18:41 Quit CH23 (Changing host)
12:18:41 Join CH23 [0] (~CH23@revspace/participant/ch23)
13:00
13:20:39rb-bluebotBuild Server message: New build round started. Revision 84fe501f53, 303 builds, 7 clients.
13:31:58 Join amachronic [0] (~amachroni@user/amachronic)
13:37:07rb-bluebotBuild Server message: Build round completed after 988 seconds.
13:37:08rb-bluebotBuild Server message: Revision 84fe501f53 result: All green
13:38:09rb-bluebotBuild Server message: New build round started. Revision e8e781b006, 303 builds, 7 clients.
13:43:57 Join lebellium [0] (~lebellium@2a01cb040109a600310db308b1986304.ipv6.abo.wanadoo.fr)
13:55:31rb-bluebotBuild Server message: Build round completed after 1043 seconds.
13:55:33rb-bluebotBuild Server message: Revision e8e781b006 result: All green
13:58:26 Join l0x0l [0] (~l0x0l@097-093-024-013.res.spectrum.com)
13:59:24 Quit Schimon (Ping timeout: 260 seconds)
14:00
14:07:35***Saving seen data "./dancer.seen"
14:08:11 Join Schimon [0] (a2fe4b5ecb@irc.cheogram.com)
15:00
15:32:44 Quit l0x0l (Ping timeout: 272 seconds)
15:33:06 Join l0x0l [0] (~l0x0l@097-093-024-013.res.spectrum.com)
16:00
16:00:10rb-bluebotBuild Server message: New build round started. Revision a23ae63a31, 303 builds, 7 clients.
16:07:17 Quit CH23 (Quit: CH23 was blown up by NO CONNECTION)
16:07:39***Saving seen data "./dancer.seen"
16:18:02rb-bluebotBuild Server message: Build round completed after 1071 seconds.
16:18:03rb-bluebotBuild Server message: Revision a23ae63a31 result: All green
16:22:23 Quit l0x0l (Ping timeout: 264 seconds)
17:00
17:36:17 Quit lebellium (Quit: Leaving)
18:00
18:07:43***Saving seen data "./dancer.seen"
18:12:51 Quit amachronic (Quit: amachronic)
18:18:11 Join CH23 [0] (~CH23@revspace/participant/ch23)
18:36:37 Join jacobk [0] (~quassel@47-186-81-17.dlls.tx.frontiernet.net)
20:00
20:07:47***Saving seen data "./dancer.seen"
22:00
22:07:49***No seen item changed, no save performed.
23:00
23:37:15 Quit m01 (Quit: Konversation terminated.)
23:39:29 Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net)

Previous day | Next day