Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2023-01-12

00:12:33***Saving seen data "./dancer.seen"
02:12:34***No seen item changed, no save performed.
04:12:36***No seen item changed, no save performed.
04:16:05 Join mendel_munkis [0] (~mendel_mu@2600:4041:5ad1:6800:b225:aaff:fe48:a92c)
04:16:35 Quit munkis (Ping timeout: 255 seconds)
04:56:08rb-bluebotBuild Server message: New build round started. Revision 541960a110, 303 builds, 8 clients.
04:56:09rb-bluebotrbcodec/dsp: restore configure loop in dsp_init() (FS #13386) by Aidan MacDonald
04:56:12 Join amachronic [0] (~amachroni@user/amachronic)
05:21:32rb-bluebotBuild Server message: Build round completed after 1524 seconds.
05:21:35rb-bluebotBuild Server message: Revision 541960a110 result: All green
05:29:06 Quit advcomp2019 (Read error: Connection reset by peer)
06:05:57rb-bluebotBuild Server message: New build round started. Revision 39439f6909, 303 builds, 8 clients.
06:05:57rb-bluebotAdd INIT_ATTR to system_init() by Aidan MacDonald
06:06:39_bilgusamachronic, judging by ifdef HAVE_EXTENDED_MESSAGING_AND_NAME guarding queue_send I don't think every device has it
06:06:46amachronicit's there everywhere
06:06:54amachronicexcept bootloaders
06:07:09amachronicit's used by codec & audio thread
06:07:14_bilgusah ok
06:07:43amachronicplaylist.c is a horrible mess :)
06:08:08_bilgusyes I'm well aware after that slast mutex adventure
06:12:39***Saving seen data "./dancer.seen"
06:32:44rb-bluebotBuild Server message: Build round completed after 1609 seconds.
06:32:45rb-bluebotBuild Server message: Revision 39439f6909 result: All green
06:33:52rb-bluebotBuild Server message: New build round started. Revision 7e5fc4076a, 303 builds, 8 clients.
06:33:53rb-bluebotAdd INIT_ATTR to i2c_init() by Aidan MacDonald
06:54:15rb-bluebotBuild Server message: Build round completed after 1224 seconds.
06:54:17rb-bluebotBuild Server message: Revision 7e5fc4076a result: 130 errors 4 warnings
06:57:26rb-bluebotBuild Server message: New build round started. Revision 16a32c576c, 303 builds, 8 clients.
06:57:26rb-bluebotFix red in 7e5fc4076a by Aidan MacDonald
07:16:46rb-bluebotBuild Server message: Build round completed after 1162 seconds.
07:16:48rb-bluebotBuild Server message: Revision 16a32c576c result: All green
07:25:18_bilgusok I think I have the dc_thread_playlist thing worked out with g#5041
07:25:20rb-bluebotGerrit review #5041 at : [BugFix] playlist.c DIRCACHE stop scanning when changing indices by William Wilgus
07:27:57_bilgusthe only really dicey spot is playlist_insert_track() as it has a sync switch
07:29:25_bilgusotherwise I think everything else shouldn't be affected much since I kept it out of loops or at least I didn't observe anywhere else that was noticeably slower
07:31:39_bilgusesentially everything that calls dc_load_playlist_pointers gets a matching call to dc_discard prior or the functions further up the call stack do at least
07:36:15amachronic_bilgus the thread needs to do a queue_reply() in the switch to unblock the sender
07:36:57_bilgusah crap thanks!
07:37:30amachronicnp :D
07:42:20amachronicI think recreate_control_unlocked() needs to stop the thread too since it's modifying playlist->indices
07:43:47amachronicalso missing dc_discard_playlist_pointers() in add_indices_to_playlist()
07:45:43amachronicthe static bool discard in playlist_insert_track() makes me suspicious
08:00:26_bilgusall callers to add_indices call discard first
08:01:06_bilguseither in empty_playlist or other places
08:02:14_bilgusplaylist_insert_track gets called in a loop with a switch to indicate sync if caller doesn't call sync it might get funky but hence the dicey comment
08:03:21_bilgusthe caller of recreate_control discards first
08:04:42amachronicah sorry I missed that for recreate_control
08:05:11_bilguseh its messy I appreciate the extr eyes
08:05:47_bilgusi'm not sure what else to do with pl_insert_track though
08:06:27amachronicadd_indices I don't like since it reloads the pointer but doesn't discard it
08:07:15amachronicprobably better to keep the discard & the reload in the same function
08:09:06_bilgusmmm good point since it gets clled in loops thats probably better anyway
08:10:40amachronicwith insert_track() it looks like sync=false means the caller is responsible for calling playlist_sync() afterwards
08:11:18amachronicif so then doing an unconditional discard upon entry would work
08:11:52amachronicthen the problem is you don't want the delays from queue send <-> reply
08:12:34amachronicperhaps you could add a boolean flag controlled by load/discard pointers
08:12:40***No seen item changed, no save performed.
08:13:31amachroniceg: if (dc_thread_running) { queue_send(...); dc_thread_running = false; }
08:17:24_bilgusthats essentially what the dirty pointers flag does maybe just hoist it out of the thread
08:23:25_bilgussounds like some kind of insult dc_has_dirty_pointers
08:23:38_bilgusprobably british slang or something
08:27:54_bilgusi'm amazed it let me rebase in gerrit after those changes I don't have great luck with that there
08:28:19 Quit amachronic (Ping timeout: 260 seconds)
08:39:29_bilgusamachronic i'll run around with these two patches the next day or two and see what pops out thanks for looking it over plus suggestions
08:41:25_bilgusit seems to be faster too probably add_indices losing dc_load_playlist_pointers() I'd guess
08:52:29 Join massiveH [0] (~massiveH@2600:4040:a992:a300:fd9b:f0e5:bbbd:9004)
09:07:42 Quit massiveH (Ping timeout: 252 seconds)
09:20:26 Join amachronic [0] (~amachroni@user/amachronic)
09:46:58 Quit desowin (Changing host)
09:46:58 Join desowin [0] (~linux@rockbox/developer/desowin)
10:12:41***Saving seen data "./dancer.seen"
10:12:45 Join paulk [0] (
10:24:54 Quit amachronic (Quit: amachronic)
11:42:16 Join othello7 [0] (
11:43:12 Quit othello7 (Client Quit)
11:43:30 Join othello7 [0] (
12:00:55 Join advcomp2019 [0] (~advcomp20@user/advcomp2019)
12:12:43***Saving seen data "./dancer.seen"
13:00:24 Join l0x0l [0] (
13:23:33 Join lebellium [0] (
13:41:01 Join amachronic [0] (~amachroni@user/amachronic)
14:09:28 Quit l0x0l (Changing host)
14:09:28 Join l0x0l [0] (~l0x0l@user/l0x0l)
14:12:47***Saving seen data "./dancer.seen"
14:20:24 Quit l0x0l (Quit: Leaving)
14:24:55 Quit amachronic (Quit: amachronic)
15:01:03 Join amachronic [0] (~amachroni@user/amachronic)
15:10:33amachronichas anyone used the pdbox plugin successfully on an ipod 1g to 4g or sansa e200?
15:11:21amachronicI ask because it uses a COP thread, but doesn't look remotely set up for it and I can find no evidence it was ever tested on those targets.
15:11:47amachronicI suspect it's broken, but I don't want to disable it if it does actually work.
15:40:35speachyI can fire it up.
15:42:54speachy... no, I can't, as what I have handy is a mini2g. d'oh.
15:53:29speachyhuh, it's installed as a viewer plugin, no wonder I iddn't see it.
15:53:40speachyit runs but doesn't seem to "work"
15:57:23amachronicadmittedly I don't know what "works" is supposed to look like :-)
15:57:37speachyme neither; it's the first time I've ever fired it up
15:57:59speachyif it's a "beatbox" then I'd surmise the different buttons trigger different sounds.
15:58:13speachythe display seems to indicate that the buttons are registered but that's it.
15:59:07amachronicseems you need to load a .pd file?
16:00:31amachronicbut, given it's lacking IBSS or SHAREDBSS attributes basically everywhere, I'd imagine it doesn't work on PP.
16:12:48***Saving seen data "./dancer.seen"
16:15:49 Quit amachronic (Quit: amachronic)
16:29:50 Quit jacobk (Ping timeout: 272 seconds)
18:12:50***Saving seen data "./dancer.seen"
18:22:05 Quit lebellium (Quit: Leaving)
19:36:41rb-bluebotBuild Server message: New build round started. Revision 2d9cb673e5, 303 builds, 8 clients.
19:36:41rb-bluebotadd chunk_alloc to playlist.c #2 by William Wilgus
19:36:55_bilguslets see how try #2 goes
20:00:54rb-bluebotBuild Server message: Build round completed after 1453 seconds.
20:00:56rb-bluebotBuild Server message: Revision 2d9cb673e5 result: All green
20:12:53***Saving seen data "./dancer.seen"
20:51:40 Join jacobk [0] (
22:06:49 Quit JanC (Remote host closed the connection)
22:07:08 Join JanC [0] (~janc@user/janc)
22:12:56***Saving seen data "./dancer.seen"
22:54:09 Join l0x0l [0] (
23:09:12 Quit hactar|ant (Ping timeout: 252 seconds)
23:16:10 Join hactar|ant [0] (
23:37:16 Quit m01 (Quit: Konversation terminated.)
23:38:58 Quit l0x0l (Quit: Leaving)
23:39:28 Join m01 [0] (

Previous day | Next day