Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2023-08-27

00:01:08 Quit Trzyzet (Read error: Connection reset by peer)
00:04:23 Join Trzyzet [0] (
00:37:12 Quit m01 (Quit: Konversation terminated.)
00:38:44 Join _bilgus [0] (~bilgus@
00:39:53rb-bluebotBuild Server message: New build round started. Revision 8a22660770, 304 builds, 9 clients.
00:39:54rb-bluebotFix #13369: shuffle setting not working from shortcut. by JJ Style
00:39:54 Join m01 [0] (
01:01:46rb-bluebotBuild Server message: Build round completed after 1313 seconds.
01:01:47rb-bluebotBuild Server message: Revision 8a22660770 result: All green
01:14:10 Join _bilgus__ [0] (~bilgus@
01:15:55 Quit _bilgus (Ping timeout: 255 seconds)
01:46:52 Quit massiveH (Quit: Leaving)
01:59:17***Saving seen data "./dancer.seen"
02:43:43 Quit foolsh (Read error: Connection reset by peer)
02:44:04 Join foolsh [0] (
03:59:20***Saving seen data "./dancer.seen"
04:03:01 Join lebellium [0] (
04:35:44 Quit LjL (Read error: Connection reset by peer)
04:36:18 Join LjL [0] (~ljl@user/ljl)
05:59:21***Saving seen data "./dancer.seen"
06:11:00 Quit spork (Quit: leaving)
06:37:40 Quit CH23_M (Read error: Connection reset by peer)
06:38:39 Join CH23_M [0] (~CH23@revspace/participant/ch23)
06:58:10 Join sark [0] (
07:12:53 Join chris_s [0] (
07:32:55 Nick sark is now known as spork (
07:34:30chris_sBilgus: re the just-merged g#13369 - I'm not sure you can attach a callback to the Shuffle setting
07:34:41chris_s E.g. it will be executed when reading in the settings during bootup and will
07:34:42chris_s cause to a crash if Shuffle is enabled then
07:36:06chris_sugh g#5288 I meant, of course
07:36:09rb-bluebotGerrit review #5288 at : Fix #13369: shuffle setting not working from shortcut. by JJ Style
07:39:38 Quit JanC (Remote host closed the connection)
07:39:52 Join JanC [0] (~janc@user/janc)
07:43:00 Quit chris_s (Quit: Connection closed)
07:59:24***Saving seen data "./dancer.seen"
08:54:17_bilgus__chris_s are you speculating or have you observed this? or SWAG?
09:33:45 Join chris_s [0] (
09:39:59chris_sthe crash I've observed in the simulator ( settings_load is run before playlist_init in the init function).
09:43:59chris_sthe callback function is called in settings_load_config (l435 of settings.c)
09:54:28_bilgus__good enough
09:55:33_bilgus__let me look at it a few, I understand the intended functionality JJ was going for
09:59:28***No seen item changed, no save performed.
10:05:26chris_seven if it didn't crash, my understanding is that you wouldn't want to reshuffle the playlist when that settings is read. The callback also seems to lead to redundant shuffling when the option is enabled from Settings. Not that I necessarily have a better implementation idea, except for naively treating the Shortcuts menu as a special case the way
10:05:27chris_sit is done for the Sleep Timer, for example (l686 in shortcuts.c), which doesn't seem like great design
10:15:12chris_slooks like the QuickScreen is already treated it as a special case already (L451 quick screen.c)
10:17:48_bilgus__if we guard it on pl->started = true that would solve the first issue
10:18:41_bilgus__but that wouldn't help with the others though
10:32:50chris_sThere's probably a few other settings that have the same issue. Frequency adjustments, for example don't have an (immediate) effect when set from Shortcuts or QuickScreen (in the latter case that may be fallout from 362f7a
10:35:31chris_snot exactly the same...
10:44:47_bilgus__ugh the main issue is that the callback and setting are changed immediately
10:51:43_bilgus__F_CB_ON_SELECT_ONLY should fix the rest
11:00:23_bilgus__chris_s g#5292
11:00:34rb-bluebotGerrit review #5292 at : [Bugfix] shuffle shenanigans from g5288 Fix #13369 by William Wilgus
11:01:49 Quit CH23_M (Ping timeout: 255 seconds)
11:02:00 Join CH23_M [0] (~CH23@revspace/participant/ch23)
11:02:10_bilgus__likely that will work on the others too unless there are other sideeffects :p
11:59:32***Saving seen data "./dancer.seen"
12:09:14 Quit CH23_M (Read error: Connection reset by peer)
12:09:33 Join CH23_M [0] (~CH23@revspace/participant/ch23)
12:46:17 Join michaelni_ [0] (~michael@
12:46:22 Quit michaelni (Quit: Leaving)
12:47:08 Quit michaelni_ (Remote host closed the connection)
12:47:26 Join michaelni [0] (~michael@
13:27:37chris_sSeems to behave better now. The callback  in playback_menu(L276) has to be removed as well to prevent redundant shuffling when the option is selected from the Settings menu.  Also, when a .cfg file is loaded in that contains a "shuffle: on" line, Rockbox (except when booting) will *re*shuffle a playlist even if the shuffle option is turned on and
13:27:37chris_sthe playlist already shuffled. Maybe that is acceptable though, or even expected behavior, since at least a non-shuffled playlist will get shuffled now whereas it wouldn't have before?
13:36:29chris_sand the special case for the QuickScreen is also redundant (l447 quick screen.c)
13:44:32 Quit chris_s (Quit: Connection closed)
13:51:12 Join chris_s [0] (
13:52:07 Quit chris_s (Client Quit)
13:59:33***Saving seen data "./dancer.seen"
14:16:34 Quit jacobk (Quit: No Ping reply in 180 seconds.)
14:19:00 Join jacobk [0] (~quassel@
14:21:30 Join Unruly247 [0] (Unruly247@gateway/vpn/protonvpn/unruly247)
14:55:54 Quit Unruly247 (Read error: Connection reset by peer)
14:56:44 Join Unruly247 [0] (Unruly247@gateway/vpn/protonvpn/unruly247)
15:22:21 Quit advcomp2019 (Ping timeout: 248 seconds)
15:48:34 Join advcomp2019 [0] (~advcomp20@user/advcomp2019)
15:59:37***Saving seen data "./dancer.seen"
16:56:27 Join vup2 [0] (~~~~@
16:57:49 Join GeekShad1w [0] (
16:57:49 Join gevaerts_ [0] (~fg@user/gevaerts)
17:02:07 Quit gevaerts (*.net *.split)
17:02:08 Quit vup (*.net *.split)
17:02:08 Quit GeekShadow (*.net *.split)
17:49:27 Quit lebellium (Quit: Leaving)
17:59:41***Saving seen data "./dancer.seen"
18:37:13 Quit jacobk (Ping timeout: 255 seconds)
18:43:24 Join massiveH [0] (~massiveH@2600:4040:a982:c800:9dd:2f4b:e26f:a08b)
18:47:42 Join jacobk [0] (
19:59:42***Saving seen data "./dancer.seen"
21:34:59 Quit Unruly247 (Remote host closed the connection)
21:59:43***Saving seen data "./dancer.seen"
22:01:44 Quit massiveH (Quit: Leaving)
22:02:26_bilgus__I think in the case of loading a setting .cfg reshuffling is acceptable
22:22:07_bilgus__chris_s the updated patch should do most of what you want
22:23:42_bilgus__I think about the only downside maybe if the playlist was stopped and you wanted to reshuffle immediately but isn't there a setting for that already?
22:24:11_bilgus__if this works ok I think repeat should get the same treatment
22:52:49 Quit jacobk (Ping timeout: 255 seconds)
23:02:47_bilgus__hmm downsides to not checking for changed state apply to shuffle and repeat items
23:52:52_bilgus__Ok i think g#5292 should check all the boxes now
23:52:56rb-bluebotGerrit review #5292 at : [Bugfix] shuffle shenanigans from g5288 Fix #13369 by William Wilgus
23:55:25_bilgus__I used F_TEMPVAR to allow only running a callback when the setting was actually changed might come in handy for some others too
23:57:27 Join jacobk [0] (~quassel@

Previous day | Next day