Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2023-10-06

00:02:22 Join Piece_Maker [0] (
00:04:08***Saving seen data "./dancer.seen"
00:04:59 Join jacobk [0] (~quassel@
00:23:58 Quit othello7 (Ping timeout: 252 seconds)
00:26:12 Quit jacobk (Ping timeout: 272 seconds)
00:37:17 Quit m01 (Quit: Konversation terminated.)
00:40:06 Join m01 [0] (
00:42:53 Join jacobk [0] (~quassel@
01:13:34 Quit pixelma (Quit: .)
01:13:34 Quit amiconn (Quit: - Chat comfortably. Anywhere.)
01:14:33 Join pixelma [0] (
01:14:33 Join amiconn [0] (
01:16:03 Join advcomp2019__ [0] (~advcomp20@user/advcomp2019)
01:17:43 Quit advcomp2019_ (Read error: Connection reset by peer)
01:25:40 Quit CH23_M (Read error: Connection reset by peer)
01:25:58 Join CH23_M [0] (~CH23@revspace/participant/ch23)
02:04:11***Saving seen data "./dancer.seen"
02:29:43 Quit jacobk (Ping timeout: 255 seconds)
03:05:02 Join PheralSparky [0] (~Shawn@user/shawn/x-4432647)
04:04:14***Saving seen data "./dancer.seen"
04:55:44 Join jjs00798 [0] (jjs007@gateway/vpn/protonvpn/jjs007)
04:56:57 Quit jjs0079 (Read error: Connection reset by peer)
04:56:58 Nick jjs00798 is now known as jjs0079 (jjs007@gateway/vpn/protonvpn/jjs007)
05:34:42 Quit PheralSparky (Read error: Connection reset by peer)
06:04:16***Saving seen data "./dancer.seen"
08:02:13 Quit rogeliodh (Quit: The Lounge -
08:02:35 Join rogeliodh [0] (
08:03:51 Join chris_s [0] (
08:04:18***Saving seen data "./dancer.seen"
08:10:53chris_sbilgus: Removing the static buffer from get_next in tagcache.c (commit 6634a60, L1854 in previous file) causes issues with Load to RAM enabled. Entries in DB tables get unexpectedly shortened to some fixed length
08:18:07 Quit CH23_ (Quit: Leaving)
08:41:31 Join othello7 [0] (
08:47:34 Quit chris_s (Ping timeout: 255 seconds)
09:06:02_bilgushmm it just puts the buffer at the caller might be the weird stuff I was observing though
09:09:03_bilgusoh I see it
09:09:17 Quit JanC (Remote host closed the connection)
09:09:22_bilgusL1920 sizeof (buf));
09:10:26_bilgusi think I called it 'hopefully it wasn't a harbinger of something stupid on my part'
09:10:37 Join JanC [0] (~janc@user/janc)
09:12:47_bilguschris_s I assume it wrote 7 chars or so
09:16:52 Join chris_s [0] (
09:19:14chris_sAh, ok, that explains it then. Thought it might have had something to do with the comment/warning. In the simulator it was 7, on the M3k 3 I think. Looks like L1938 there's another one
09:19:43rb-bluebotBuild Server message: New build round started. Revision 17a8a54780, 304 builds, 9 clients.
09:19:43rb-bluebot[BugFix] tagcache/tagtree remove static buffer from tagcache_get_next by William Wilgus
09:20:47_bilgusI was actually more worried about Pictureflow
09:22:09_bilgusI made a couple of the stack allocated 'tag bufs' static if they were going to be stacking allocs
09:22:33_bilgusbut it really needs a bit of refactoring I suspect
09:22:52chris_sNot sure I've tried PictureFlow yet – i did run into a stack overflow with the commit plugin, unfortunately, on the m3k ... :o
09:23:12_bilgusIOW it leans a bit heavily on that buffer being static in the callee
09:23:45_bilguschris_s is that the current HEAD then?
09:24:25_bilgusI'm slightly surprised its still having issues but I suspect its blowing the stack while the core stuff runs as well
09:25:01_bilgusI may pull it apart a bit more but I was really trying to keep the code unified
09:26:02chris_sI think so, I'll check again to make sure. One other thing I've noticed: The 5s commit countdown (only) in the simulator seems to get interrupted by some ( non-button?) action, so you have to be very quick to be able to react to it
09:27:46_bilgusugh yeah the sim has the battery running down and that throws a SYS event
09:28:09_bilguswell actually theres like 5
09:28:28_bilgusup down charger on off and one other I think
09:31:24_bilguscommitting on device through the plugin is for sure slow but my hope is that it can be expanded to allow rules
09:31:26chris_swith regard to the stkov: i was surprised that you're running the commit stuff in the main plugin thread instead of the seperately crated thread which just displays the log file, unless I'm missing something?
09:31:59rb-bluebotBuild Server message: Build round completed after 736 seconds.
09:32:01rb-bluebotBuild Server message: Revision 17a8a54780 result: All green
09:32:04_bilgusIt was not stable for me
09:32:24 Join braewoods_ [0] (~braewoods@user/braewoods)
09:32:33_bilgusbut that was before I started removing the stack allocs
09:32:47_bilgusso it prob was just hiding it
09:33:30 Quit braewoods (Read error: Connection reset by peer)
09:33:48_bilgusI prob should have saved that version to test as it was a bit cleaner feeling
09:37:38_bilguschris_s I'm testing this on a 6.5MB .tmp file how big is yours?
09:52:17chris_s8.8 MB – I just checked again – stkov on latest build 17a8a54780 using M3k– commit using core, or using the plugin from the simulator with the same set of files, works fine
09:53:46_bilgusI'll try moving the thread around
09:54:25_bilgusI'm not sure about the stack in the plugin I suppose the main thread has a size defined somewhere
09:55:12_bilgusI'll try flipping the action stuff back to the main thread
10:04:21***Saving seen data "./dancer.seen"
10:04:40 Join munkis [0] (~mendel_mu@2600:1017:b43d:2d95:96e2:3cff:fe9d:7ba0)
10:06:06 Join jacobk [0] (~quassel@
10:22:17 Quit CH23_M (Ping timeout: 255 seconds)
10:28:11chris_sbtw, I think the main problem with errant events in the sim is that they immediately *cancel* a pending commit and that the sim forces you into rebooting, so you always run into the countdown
10:29:21chris_sThe Playing time screen has the same issue  though, in terms of closing itself without button input
10:40:47 Join mendel_munkis [0] (
10:42:31 Quit munkis (Ping timeout: 260 seconds)
10:48:28 Quit Nyaa (Remote host closed the connection)
10:50:04_bilgusI made a filter for that somewhere
10:50:27_bilgusshould probably just make a macro sys wide
10:52:13_bilgusprobably several forms maybe like IS_SYS_EV, IGNORE_SYS_EV, ONLY_SYS_EV
10:52:30speachythat seems quite useful
10:55:17 Join Nyaa [0] (
10:58:29_bilguschris_s g#5404 swaps the threads and adds the ability to cancel
10:58:31rb-bluebotGerrit review #5404 at : db_commit swap threads, add ability to cancel by William Wilgus
11:19:50chris_sthat seems to work very well! :)
11:23:07_bilgusthere is still an issue I'm running out of buffer with a 12mb file
11:23:55_bilgusI mean thats like 60-70k files but I'd like it to be less dependent on buffer sizes if possible
11:24:59chris_syeah, 12 MB doesn't seem out of this world
11:25:39_bilgusI'll keep working on it hopefully the solution leads to a more stable version in core
11:28:49_bilguseh it still has buffer left something else I think but I'll have to look later'
11:32:14rb-bluebotBuild Server message: New build round started. Revision 57713f6308, 304 builds, 10 clients.
11:32:14rb-bluebotipod: Support IAP remote MENU/SELECT/UP/DOWN keys in MODE2 by Solomon Peachy
11:35:50speachygiven that the wiki wedged things _again_ when its' not even on the hot path I think the only real option here is to stand it down completely.
11:37:46speachyin favor of a static markdown-based site I think, unless there's a better idea. There are _some_ dynamic features of the old engine that are nice to have (eg creating topic index pages autoatically)
11:43:34rb-bluebotBuild Server message: Build round completed after 680 seconds.
11:43:35rb-bluebotBuild Server message: Revision 57713f6308 result: All green
12:03:42 Quit mendel_munkis (Read error: Connection reset by peer)
12:04:24***Saving seen data "./dancer.seen"
12:44:41 Quit jacobk (Ping timeout: 272 seconds)
12:55:25 Join jacobk [0] (
13:04:35 Quit chris_s (Ping timeout: 240 seconds)
13:16:03 Join chris_s [0] (
13:30:55 Quit jacobk (Ping timeout: 272 seconds)
13:33:55 Join jacobk [0] (~quassel@
13:51:27 Join CH23_M [0] (~CH23@revspace/participant/ch23)
14:04:28***Saving seen data "./dancer.seen"
14:05:06 Quit chris_s (Ping timeout: 272 seconds)
14:39:01 Join othello8 [0] (
14:40:17 Quit othello8 (Client Quit)
14:51:18 Join lebellium [0] (
15:29:53_bilgusthat feature is slightly annoying sometimes too though
15:44:39_bilgusre the OOM error on that 12mb file wasn't actually a OOM it was an out of index issue due to the remnants of the previous canceled commit, So I guess I should delete all of them if the user cancels
15:46:08_bilgushmm that could get you in trouble too though
15:46:55_bilgusmaybe it should back up existing db files and do a restore in case of a failed/canceled update
15:47:55speachyHmm, there's also the case if the exsting db is b0rked
16:03:48_bilgusyeah wouldn't do much good to auto restore it in that case
16:04:08_bilgusso it should ask before it restores the backup
16:04:31***Saving seen data "./dancer.seen"
16:04:58_bilgusbeing that its a plugin I suppose just ask for both
16:05:04_bilgussave a backup?
16:39:31_bilgusugh can of worms now I want to add the onplay file and directory copy routines to misc.c and the plugin api
16:42:05_bilguseh I'll just leave it extensible and sitting in the plugin I'm not sure how many other users there'd be since it took me quite qa while to find a copy routine that already existed
16:56:52 Quit jacobk (Ping timeout: 255 seconds)
17:05:13 Join jacobk [0] (
18:04:35***Saving seen data "./dancer.seen"
18:05:16 Quit jacobk (Ping timeout: 255 seconds)
18:11:18 Join jacobk [0] (
18:19:12dookI've been thinking about the wiki situation during the week, threw together a quick proof of concept for generation it with markdown files via hugo
18:21:24dookI'd be open to working on this as a complete solution, but I'd probably start from scratch with the html and css.
18:22:18dookThe table layout the site currently uses isn't great for screenreaders
18:24:39 Quit lebellium (Quit: Leaving)
18:45:45 Join Moriar [0] (
18:48:34 Join massiveH [0] (~massiveH@2600:4040:a982:c800:7c8d:6a07:9451:c5d3)
20:04:36***Saving seen data "./dancer.seen"
20:10:32 Quit CH23_M (Ping timeout: 272 seconds)
20:11:16 Join CH23_M [0] (~CH23@revspace/participant/ch23)
21:24:06 Quit CH23_M (Read error: Connection reset by peer)
21:24:19 Join CH23_M [0] (~CH23@revspace/participant/ch23)
21:45:56 Quit Maxdamantus (Ping timeout: 255 seconds)
21:47:35 Join Maxdamantus [0] (~Maxdamant@user/maxdamantus)
21:58:55 Join othello8 [0] (
22:00:20 Quit othello7 (Ping timeout: 255 seconds)
22:00:20 Nick othello8 is now known as othello7 (
22:04:37***Saving seen data "./dancer.seen"
22:12:57 Join PheralSparky [0] (~Shawn@user/shawn/x-4432647)
23:57:01 Quit jacobk (Ping timeout: 248 seconds)

Previous day | Next day