Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-03-14

00:02:06 Join smbgaiden [0] (~androirc@076-082-155-071.res.spectrum.com)
00:03:14smbgaidenhi all, have a question about a fix for plugin button handling on my device (an erosq by hifi walker)
00:04:07smbgaidenthe plugins seem to handle keys in two different ways of which one works and one doesn't.
00:04:25smbgaidenExample, snake 2 works. no more need to discuss this way
00:05:05smbgaidenbubbles, brickmania and others don't seem to work with the scroll wheel, so i dug in
00:06:40smbgaidenin apps/plugins/lib/pluginlib_actions.c there's a structure of pla_remote_ctx that maps out the buttons for plugins
00:10:30smbgaidenwithin that there's the sections related with the erosq: 1) scrolling assigned to pla_left/ right, 2) ifdef guard on HAVE_SCROLLWHEEL which assigns scrolling buttons to pla_scroll_fwd / back, and 3) the other buttons
00:11:54smbgaidensince 1 and 2 are concerned with the same scroll buttons and likely the key check function bails out after first match, the plugins will only see left/ right actions and not scroll_fwd / back
00:12:47smbgaidenhowever, in bubbles.c there's the same guard on HAVE_SCROLLWHEEL to assign BUBBLES_LEFT/RIGHT to the scroll actions
00:13:14smbgaidenthese actions will never be sent so the turret won't move
00:16:52smbgaideni added the PLA_LEFT/RIGHT under their respective PLA scroll actions AKA BUBBLES_LEFT/RIGHT in bubbles.c bubbles_handlebuttons and after building then running the turret was moving with the scroll wheel movements
00:18:48smbgaidenseems the fix should be to remove the assignment of erosq scroll to the pla_left/right in the pluginlib_actions.c and check the plugins that use the structure whether they need modifications from left/right to scroll fwd/back
00:19:58 Join AndroUser2 [0] (~androirc@2607:fb90:bd9f:e35:4b7:ec1e:dad0:de32)
00:24:11 Quit smbgaiden (Ping timeout: 252 seconds)
00:24:29 Nick AndroUser2 is now known as smbgaiden (~androirc@2607:fb90:bd9f:e35:4b7:ec1e:dad0:de32)
00:29:03smbgaidenguess i failed to ask a question, given the above where to go from here to mainline fixes?
00:42:36_bilgus_smbgaiden, gerrit is where we do patches https://gerrit.rockbox.org/r/
00:44:16smbgaidenthanks, will have a look
00:44:22_bilgus_or if you want to post a patch file on the forum I can add it later
00:44:44_bilgus_seeing as its not v. much code
00:46:39_bilgus_https://www.rockbox.org/wiki/UsingGit.html, https://www.rockbox.org/wiki/WorkingWithPatches.html
00:46:40smbgaidenthank you, very much appreciate your kindness. was just looking thru all the steps on how to get a log in
00:46:59smbgaideni have a forum login, but not oauth
00:47:12 Quit Piece_Maker (Quit: ZNC 1.8.2 - https://znc.in)
00:48:51 Join Piece_Maker [0] (~eddie@bolt-17-b2-v4wan-168143-cust4.vm18.cable.virginm.net)
00:53:39smbgaidenread them
00:54:53smbgaidenwill do the scan thru the plugins and test out any variations on button handling logic for those that i can run before posting the patch into the forum
01:00
01:00:48_bilgus_ok i'm busy af if I dont respond within a day or so to have you test it on the forum say something to me in here
01:13:28smbgaidenthank you, will comply
01:17:52smbgaidensleep time, be back another time with news
01:18:00 Quit smbgaiden (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
01:31:46***Saving seen data "./dancer.seen"
01:40:43 Quit advcomp2019 (Read error: Connection reset by peer)
01:42:10 Join advcomp2019 [0] (~advcomp20@user/advcomp2019)
01:50:33 Quit othello7 (Ping timeout: 255 seconds)
02:00
02:11:38 Quit JanC (Ping timeout: 268 seconds)
02:14:12 Join JanC [0] (~janc@user/janc)
02:48:39 Join munkis [0] (~mendel_mu@pool-71-105-57-155.nycmny.fios.verizon.net)
03:00
03:02:33 Quit Galois (Remote host closed the connection)
03:30:15 Join Galois [0] (djao@efnet.math.uwaterloo.ca)
03:31:48***Saving seen data "./dancer.seen"
04:00
04:57:18 Quit PheralSparky (Quit: Leaving)
05:00
05:06:09 Quit the_sea_peoples (Ping timeout: 272 seconds)
05:08:39 Join the_sea_peoples [0] (~the_sea_p@2601:600:8d01:14a3:dea6:32ff:fe16:a622)
05:31:49***Saving seen data "./dancer.seen"
06:00
06:21:41 Quit CH23_M (Ping timeout: 268 seconds)
06:23:26 Join CH23_M [0] (~CH23@revspace/participant/ch23)
06:33:04 Quit CH23_M (Read error: Connection reset by peer)
06:33:39 Join CH23_M [0] (~CH23@revspace/participant/ch23)
06:38:06 Quit CH23_M (Ping timeout: 255 seconds)
06:39:52 Join CH23_M [0] (~CH23@revspace/participant/ch23)
07:00
07:08:11 Quit CH23_M (Read error: Connection reset by peer)
07:08:32 Join CH23_M [0] (~CH23@revspace/participant/ch23)
07:11:39 Join CH23 [0] (~CH23@revspace/participant/ch23)
07:31:53***Saving seen data "./dancer.seen"
08:00
08:34:42 Quit lane (Write error: Connection reset by peer)
08:34:43 Quit dook (Remote host closed the connection)
08:34:46 Quit ursa-major (Write error: Connection reset by peer)
08:34:46 Quit voltagex (Remote host closed the connection)
08:34:56 Join lane [0] (809450f172@2a03:6000:1812:100::1300)
08:34:58 Join voltagex [0] (bb9d16d177@user/voltagex)
08:35:03 Join ursa-major [0] (114efe6c39@2a03:6000:1812:100::11f3)
08:35:04 Join dook [0] (c9db4a6425@2a03:6000:1812:100::1222)
09:00
09:26:28 Quit decky (Read error: Connection reset by peer)
09:26:54 Join decky [0] (~decky_@69.9.129.108)
09:31:56***Saving seen data "./dancer.seen"
09:47:33 Quit munkis (Ping timeout: 255 seconds)
10:00
10:53:13 Quit bleb (Ping timeout: 264 seconds)
10:54:14 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
10:57:58 Join bleb [0] (~cm@user/bleb)
10:58:49 Join bleb_ [0] (~cm@user/bleb)
11:00
11:02:47 Quit enok (Remote host closed the connection)
11:03:34 Join enok_ [0] (c8b9e6acb0@2a01:4f8:1c1e:e9de::6)
11:22:00 Quit jacobk (Ping timeout: 268 seconds)
11:23:22 Join davisr [0] (~davisr@fsf/emeritus/davisr)
11:29:39 Join jacobk [0] (~quassel@64.189.201.150)
11:31:57***Saving seen data "./dancer.seen"
13:00
13:31:58***No seen item changed, no save performed.
13:33:50 Quit f_ (Read error: Connection reset by peer)
13:50:56 Join f_ [0] (~AUGESOUND@fases/developer/funderscore)
14:00
14:10:08 Join cb_ [0] (~calvin@138.197.175.25)
14:11:18 Join f__ [0] (~AUGESOUND@fases/developer/funderscore)
14:12:34 Quit Nezumi-sama (Ping timeout: 260 seconds)
14:12:34 Quit cb (Read error: Connection reset by peer)
14:12:34 Quit the_sea_peoples (Ping timeout: 264 seconds)
14:12:35 Quit q3k (Ping timeout: 264 seconds)
14:12:40 Join q3k [0] (q3k@boston-packets.hackerspace.pl)
14:12:47 Quit f_ (Ping timeout: 260 seconds)
14:12:47 Quit jacobk (Ping timeout: 260 seconds)
14:12:47 Quit TorC (Ping timeout: 260 seconds)
14:12:48 Quit spork (Ping timeout: 260 seconds)
14:13:03 Quit q3k (Changing host)
14:13:03 Join q3k [0] (q3k@hswaw/infra/q3k)
14:13:28 Join jacobk [0] (~quassel@64.189.201.150)
14:13:30 Join the_sea_peoples [0] (~the_sea_p@2601:600:8d01:14a3:dea6:32ff:fe16:a622)
14:14:10 Nick f__ is now known as f_ (~AUGESOUND@fases/developer/funderscore)
14:14:32 Join spork [0] (topic@213-234-20-31.ftth.glasoperator.nl)
14:14:52 Quit JanC (Ping timeout: 255 seconds)
14:15:33 Join TorC [0] (~Tor@fsf/member/TorC)
14:16:01 Join Nezumi-sama [0] (~narf@067-053-148-069.biz.spectrum.com)
14:17:40 Join JanC [0] (~janc@user/janc)
14:25:41 Join lebellium [0] (~lebellium@2a01cb040610e000966d497ab8f1a749.ipv6.abo.wanadoo.fr)
14:30:05 Quit jacobk (Ping timeout: 268 seconds)
15:00
15:31:59***Saving seen data "./dancer.seen"
16:00
16:55:06 Join jacobk [0] (~quassel@utdpat242017.utdallas.edu)
17:00
17:23:31 Join Trzyzet_ [0] (~Trzyzet@live-34-b2-v4wan-169259-cust832.vm29.cable.virginm.net)
17:24:37 Quit Trzyzet (Ping timeout: 272 seconds)
17:24:37 Nick Trzyzet_ is now known as Trzyzet (~Trzyzet@live-34-b2-v4wan-169259-cust832.vm29.cable.virginm.net)
17:32:03***Saving seen data "./dancer.seen"
17:54:00 Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net)
17:56:25 Join jjs0077018310196 [0] (jjs007@gateway/vpn/protonvpn/jjs007)
18:00
18:07:54 Join munkis [0] (~mendel_mu@pool-71-105-57-155.nycmny.fios.verizon.net)
18:44:23 Quit jjs0077018310196 (Ping timeout: 260 seconds)
18:49:24 Join jjs0077018310196 [0] (jjs007@gateway/vpn/protonvpn/jjs007)
18:54:47 Quit CH23 (Quit: Leaving)
19:00
19:07:17 Quit CH23_M (Ping timeout: 268 seconds)
19:07:58 Join CH23_M [0] (~CH23@revspace/participant/ch23)
19:08:12 Quit lebellium (Quit: Leaving)
19:16:34 Join massiveH [0] (~massiveH@2600:4040:a982:c800:c036:7942:54ab:a86c)
19:20:12 Quit davisr (Quit: yeehaw)
19:21:29 Join PheralSparky [0] (~Shawn@user/shawn/x-4432647)
19:29:12 Quit CH23_M (Read error: Connection reset by peer)
19:29:31 Join CH23_M [0] (~CH23@revspace/participant/ch23)
19:32:07***Saving seen data "./dancer.seen"
20:00
20:39:04 Nick cb_ is now known as cb (~calvin@138.197.175.25)
21:00
21:05:32 Quit jjs0077018310196 (Ping timeout: 252 seconds)
21:06:25 Join jjs0077018310196 [0] (jjs007@gateway/vpn/protonvpn/jjs007)
21:12:37 Quit paulk (Ping timeout: 272 seconds)
21:14:26 Join paulk [0] (~paulk@12.234.24.109.rev.sfr.net)
21:14:26 Quit paulk (Changing host)
21:14:26 Join paulk [0] (~paulk@about/aquilenet/user/paulk)
21:19:52 Quit paulk (Ping timeout: 268 seconds)
21:20:12 Join paulk [0] (~paulk@about/aquilenet/user/paulk)
21:24:21 Quit jacobk (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
21:32:10***Saving seen data "./dancer.seen"
21:44:17 Quit Moriar (Ping timeout: 272 seconds)
22:00
22:05:31 Join jacobk [0] (~quassel@utdpat242017.utdallas.edu)
22:11:21 Quit jacobk (Ping timeout: 268 seconds)
22:49:09 Quit massiveH (Quit: Leaving)
23:00
23:02:04 Quit skipwich (Quit: DISCONNECT)
23:03:25 Join skipwich [0] (~skipwich@user/skipwich)
23:23:55 Quit jjs0077018310196 (Ping timeout: 260 seconds)
23:32:13***Saving seen data "./dancer.seen"

Previous day | Next day