Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-07-06

00:05:25 Quit bakedbacon42066 (Remote host closed the connection)
00:17:19speachythat 306gb sounds like it wrapped over
00:18:03speachydon't know if it's a rockbox bug or the iflash adapter's problem.
00:39:16 Quit Moriar (Quit: Leaving.)
01:18:41 Join bakedbacon42066 [0] (~bakedbaco@2600:381:cb60:232d:54f8:9ce5:9849:7352)
01:19:18bakedbacon42066Just double checked my collection i think i mightve sent the .bin for my 60gb not my 80gb
01:20:39 Quit bakedbacon42066 (Remote host closed the connection)
01:29:58_bilgus_hmm one downside to reading the files is that voice would have to do it again I think I'm going to leave that be
01:31:18_bilgus_well I guess it wouldn't be terrible to do it by caching the selected index as it goes by
01:32:13 Quit othello7 (Remote host closed the connection)
01:35:23***Saving seen data "./dancer.seen"
01:41:48_bilgus_ugh nope leaving it be
01:57:19 Quit massiveH (Quit: Leaving)
02:49:59 Quit melmothX (Quit: reboot)
02:54:25 Join melmothX [0] (~marco@amusewiki/marco)
03:35:24***Saving seen data "./dancer.seen"
04:03:31 Quit Bobathan (Quit: ZNC 1.8.2+deb2+b1 -
04:03:49 Join Bobathan [0] (
04:13:21 Join lebellium [0] (
04:59:53 Quit hactar|ant (Ping timeout: 252 seconds)
05:21:57 Quit wLLm (Quit: ZNC -
05:35:25***Saving seen data "./dancer.seen"
06:59:26speachy is this in the apple firmware /disk mode or within rockbox's usb mode?
07:18:13speachyok, pushed updated 64bit storage api patch; notably fixes USB mass storage size reporting.
07:21:31speachybakedbacon420: yeah, the identify_info.bin you sent was for an ipod with an iflash adapter in it
07:35:29***No seen item changed, no save performed.
09:35:32***No seen item changed, no save performed.
10:06:06 Join Moriar [0] (
10:58:56 Quit armin (Ping timeout: 268 seconds)
11:13:37user890104speachy: does it make sense to move all ata identify info parsing into a separate source file, and add API for retrieving the fields from it?
11:14:25user890104or better make a struct and load it into that
11:26:59 Quit Moriar (Ping timeout: 264 seconds)
11:35:34***Saving seen data "./dancer.seen"
11:36:49speachythere's not a lot of actual parsing going on outside of the lowlevel ata driver
11:37:03speachyand I think it's already contained within ata_() API function calls
11:37:21speachy(debuginfo is a notable exception)
11:38:02speachythere is some duplication in platform ATA drivers though
11:38:24speachybut there's not a lot to be done about; most of the "parsing" would end up being inlined anyway.
11:38:44speachythe SD code, on the other hand, has massive amounts of functional duplication
11:42:27speachyyeah, outside of the ata subsystem, the identify info is only used in the debug (the menu and a couple of bootloaders) and usb mass storage driver.
11:42:52speachyand even then only to get serial numbers and model names to report up.
11:45:11 Quit mendel_munkis (Ping timeout: 268 seconds)
11:56:07 Join othello7 [0] (
11:56:58 Quit othello7 (Client Quit)
12:01:24 Join hactar|ant [0] (
12:31:54 Join othello7 [0] (
12:54:26 Join armin [0] (
13:08:07 Quit armin (Ping timeout: 272 seconds)
13:23:36user890104speachy: yes, that's what i meant by adding an API - to get those three strings with the whitespace trimmed, the rest can be read from the struct as-is
13:23:44 Join armin [0] (
13:35:36***Saving seen data "./dancer.seen"
13:50:35_bilgus_Re: g#5807 I think I have a decently performant way forward by using the name buffer to fill in title data on buffer load it should decrease the disk hits to a manageable level
13:50:38rb-bluebotGerrit review #5807 at : [Feature] playlist_viewer id3 title display by William Wilgus
13:51:05_bilgus_this also allows the titles to be voiced with no extra overhead
13:52:45_bilgus_I was going to make the playlist search function follow the same formatting but it only searches filenames and I don't intend to start parsing tags in every file in the playlist so it makes sense to only show filename there still
13:58:20 Join munkis [0] (~mendel_mu@2600:4041:5ac9:a100:b225:aaff:fe5e:10eb)
13:59:04 Quit armin (Remote host closed the connection)
13:59:14 Join armin [0] (
14:56:01 Quit LjL (Quit: Scappò via con la paura di arrugginire. Il giornale di ieri lo dà morto arrugginito. I becchini ne raccolgono spesso fra la gente che si lascia piovere addosso.)
14:57:25 Join LjL [0] (~ljl@user/ljl)
15:35:40***Saving seen data "./dancer.seen"
17:35:43***No seen item changed, no save performed.
17:43:36speachyuser890104: Not sure that any one of thos strings is used more than one place, but feel free to submit a patch. :D
17:44:22user890104well, after my patches, there is one that's used :)
17:45:51user890104maybe a struct would be enough, and the other pieces of code can use its members directly, without having typecasts all over the code. I am only worried about endianess, because at one place there was host2be conversion taking place
17:46:03 Join Moriar [0] (
17:58:43 Join wLLm [0] (~wLLm@
18:05:07 Join wLLm_ [0] (~wLLm@
18:06:36 Quit wLLm (Ping timeout: 268 seconds)
18:06:36 Nick wLLm_ is now known as wLLm (~wLLm@
18:11:29 Quit wLLm (Ping timeout: 272 seconds)
18:11:56 Join wLLm [0] (~wLLm@
19:24:49 Join massiveH [0] (
19:35:45***Saving seen data "./dancer.seen"
19:46:02speachyuser890104: the identify info is defined as big endian, but when we query it we automatically swap everything to host order.
19:47:25speachyhmm. I suppose having a generic "copy the string at position X (max len )" helper wouldn't be a bad thing; it's used in at least three places.
21:11:54 Quit Malinux (Ping timeout: 268 seconds)
21:26:59 Quit Maxdamantus (Ping timeout: 264 seconds)
21:31:25 Join Maxdamantus [0] (~Maxdamant@user/maxdamantus)
21:35:46***Saving seen data "./dancer.seen"
21:47:52 Join massive_H [0] (
21:47:56 Join decky_e_ [0] (~decky_@
21:49:03 Join othello8 [0] (
21:49:47 Join ursa-major_ [0] (114efe6c39@2a03:6000:1812:100::11f3)
21:49:55 Quit yosafbridge (Quit: Leaving)
21:50:20 Quit ursa-major (Read error: Connection reset by peer)
21:50:45 Quit othello7 (Ping timeout: 268 seconds)
21:50:46 Quit Nezumi-sama (Ping timeout: 268 seconds)
21:50:46 Nick othello8 is now known as othello7 (
21:51:22 Quit massiveH (Ping timeout: 268 seconds)
21:51:22 Quit decky (Ping timeout: 268 seconds)
21:51:23 Quit user890104 (Ping timeout: 268 seconds)
21:51:23 Quit kugel (Ping timeout: 268 seconds)
21:51:31 Join kugel [0] (
21:51:38 Join user890104 [0] (~Venci@freemyipod/user890104)
21:53:47 Join yosafbridge [0] (
21:54:04 Nick ursa-major_ is now known as ursa-major (114efe6c39@2a03:6000:1812:100::11f3)
21:55:46 Join Nezumi-sama [0] (
23:19:15 Quit Moriar (Ping timeout: 268 seconds)
23:35:51***Saving seen data "./dancer.seen"

Previous day | Next day