Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-07-23

00:04:02_bilgushmm well maybe you could watch the watermark in the pcm buffer instead
00:05:07_bilguslike you know as you end a track it'll start winding down maybe you could look for that?
00:11:24_bilguspcmbuf_unplayed_bytes()
00:24:23 Quit dconrad (Remote host closed the connection)
00:25:23 Join dconrad [0] (~dconrad@152.117.104.217)
00:30:36 Quit dconrad (Ping timeout: 276 seconds)
00:51:50_bilgus g#5828
00:51:53rb-bluebotGerrit review #5828 at https://gerrit.rockbox.org/r/c/rockbox/+/5828 : [Feature] Allow hiding drive names by William Wilgus
00:54:39 Quit jacobk (Ping timeout: 276 seconds)
01:00
01:22:41 Join davisr [0] (~davisr@fsf/emeritus/davisr)
01:35:55 Quit davisr (Quit: yeehaw)
01:41:49 Join davisr [0] (~davisr@fsf/emeritus/davisr)
01:55:52***Saving seen data "./dancer.seen"
02:00
02:03:33 Quit davisr (Quit: yeehaw)
02:24:40 Quit othello7 (Ping timeout: 260 seconds)
02:39:00 Join dconrad [0] (~dconrad@152.117.104.217)
02:43:42 Quit dconrad (Ping timeout: 272 seconds)
03:00
03:55:53***Saving seen data "./dancer.seen"
05:00
05:02:24 Join dconrad [0] (~dconrad@152.117.104.217)
05:06:37 Quit dconrad (Ping timeout: 252 seconds)
05:53:42 Quit sebagala (Read error: Connection reset by peer)
05:54:07 Join sebagala [0] (~Burak@185.25.123.34)
05:55:54***Saving seen data "./dancer.seen"
06:00
06:06:33rb-bluebotBuild Server message: New build round started. Revision 62b0456a4b, 337 builds, 9 clients.
06:06:34rb-bluebotpuzzles: resync with upstream (adds new Palisade cursor interface). by Franklin Wei
06:18:15rb-bluebotBuild Server message: Build round completed after 702 seconds.
06:18:16rb-bluebotBuild Server message: Revision 62b0456a4b result: All green
07:00
07:38:24 Join dconrad [0] (~dconrad@152.117.104.217)
07:43:30 Quit dconrad (Ping timeout: 276 seconds)
07:55:55***Saving seen data "./dancer.seen"
07:58:57 Join dconrad [0] (~dconrad@152.117.104.217)
08:00
08:00:30 Quit dconrad (Remote host closed the connection)
08:29:44speachy__builtin: could you also update README.rockbox to reference the latest update and upstream commit it's based off of?
09:00
09:01:35 Quit ursa-major (Remote host closed the connection)
09:01:40 Quit dook (Remote host closed the connection)
09:01:53 Quit lane (Remote host closed the connection)
09:02:08 Join lane [0] (809450f172@2a03:6000:1812:100::1300)
09:02:09 Join dook [0] (c9db4a6425@2a03:6000:1812:100::1222)
09:02:14 Join ursa-major [0] (114efe6c39@2a03:6000:1812:100::11f3)
09:21:21 Join IPG [0] (~InvoxiPla@2.122.6.66)
09:23:13 Quit speachy (Quit: WeeChat 4.3.4)
09:38:25 Join jacobk [0] (~quassel@2603:3013:103:ef00:1113:1c75:8d3b:2220)
09:42:24 Join speachy [0] (~speachy@hurricane.shaftnet.org)
09:42:25 Quit speachy (Changing host)
09:42:25 Join speachy [0] (~speachy@rockbox/developer/speachy)
09:42:25Mode"#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat)
09:44:19speachy_bilgus: I think we should not bother making that "hide names" thing configurable. on non-multidrive targets, it's never relevant. On multi-drive targets with only one drive used/present, it's also not relevant. It only comes into play when there is more than one drive in active use.
09:46:11speachyand we still need to fix the path voice function so that does the right thing with VOL_START/STOP_TOK :D
09:55:24 Quit jacobk (Ping timeout: 260 seconds)
09:55:56***Saving seen data "./dancer.seen"
11:00
11:14:34 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
11:14:46 Quit othello7 (Client Quit)
11:19:28_bilguswell either way I did get something out of that it turns out building those string every call makes a noticeable difference in the disk test plugin and generating them at boot shouldn't be terrible they are pretty small 12 bytes each I think
11:27:59speachyew, yeah, let's do it only once
11:30:05speachythat will also make it simpler to reverse-lookup to the logical volume so we can voice it properly.
11:49:10_bilgusits still not going to be fun figuring out which storage type it is each time maybe it should store the drive type too and let you query that directly
11:52:17_bilgusat init store the proper ID in vollang[v] later volumename_voice(volume) {talk(vollang[volume]) talknum(volume)}
11:55:59***Saving seen data "./dancer.seen"
11:57:39speachypretty sure we already have that info −− volume id maps to drive id, and from there storage_driver_type(driveid)
11:57:41 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
11:58:46speachyotoh, drive 0 is always "internal" (the exact string varies by target) and drive 1 is in a similar situation.
11:59:46user890104i've updated the Bulgarian translation in g#5830
11:59:49rb-bluebotGerrit review #5830 at https://gerrit.rockbox.org/r/c/rockbox/+/5830 : Update Bulgarian translation by Vencislav Atanasov
11:59:54speachysweet
12:00
12:00:18user890104it's a mix of two or three styles, so it needs a general rework in order to be pleasing to read/hear
12:01:25user890104i wouldn't use it personally, but check if the most annoying things can be fixed, there are genders on adjectives in Bulgarian, and some strings are reused regardless of it, so it sounds strange
12:03:18speachyhmm, that sort of thing is going to bite other languages too
12:03:40 Quit mrkrisprolls (Killed (NickServ (GHOST command used by mrkrispr`!~user@h-85-24-169-71.A192.priv.bahnhof.se)))
12:05:34speachywant to get added to the notification list should this translation need updates later?
12:06:14rb-bluebotBuild Server message: New build round started. Revision ba4a6f2adc, 337 builds, 6 clients.
12:06:14rb-bluebotUpdate Bulgarian translation by Vencislav Atanasov
12:06:40speachyI'll add it to the nightly voice list as well. just espeak, since there's no piper model.
12:16:47speachyok, that's also committed, along with a couple of mechanical corrections to the lang file. 31 issues remain, nearly all of which are of the "identical to English" variety. One in particular (VOICE_LANG_INVALID_VOICE_FILE) definitely needs to corrected.
12:17:46 Join mskrisprolls [0] (mrkrisprol@2605:6400:20:5cc:e8af:da1c:ee53:f678)
12:23:07speachy__builtin: oh, do we need an updated puzzles font to go with that resync?
12:29:10rb-bluebotBuild Server message: Build round completed after 1377 seconds.
12:29:11rb-bluebotBuild Server message: Revision ba4a6f2adc result: All green
12:29:14rb-bluebotBuild Server message: New build round started. Revision a153f6c266, 337 builds, 7 clients.
12:29:15rb-bluebotvoice: Add defaults for Bulgarian voicing, and add it to the nightly builds. by Solomon Peachy
12:32:13user890104speachy: feel free to add me to the list
12:37:59user890104also, which email address does this list use? i haven't been subscribed to the rockbox mailing list for a couple of years
12:47:16rb-bluebotBuild Server message: Build round completed after 1083 seconds.
12:47:17rb-bluebotBuild Server message: Revision a153f6c266 result: All green
13:00
13:00:56user890104speachy: is this message on the translation site still relevant?
13:01:03user890104Note: This is updated at most every 15 minutes, but only if the build farm is idle.
13:01:20user890104my changes are still not shown there
13:03:48speachyuser890104: it'll be whatever you want it to be. I could just use the address in your gerrit commits?
13:04:57speachyand yes, that message is still relevant. the site updates on the quarter-hour after the build farm goes idle.
13:05:06user890104that should also be fine, but I'll PM you my preferred address
13:08:56user890104also, there was some problem with the POST max size of https://translate.rockbox.org/submit.php, because the last few translated strings were lost when I submitted the page
13:13:06speachyoh, interesting, thanks for that.
13:14:00speachy...ran into the max_input_vars limit (defaults to 1000)
13:14:15user890104i was close :)
13:14:35speachychanged that to 5000, ought to do the trick.
13:15:05speachyone of those little gotchas..
13:15:15user890104also, there's no easy way to save the progress midway, or load a partially translated patch. but that would bring additional complications
13:15:49user890104i trusted my laptop not to crash between sleep/wakeup a couple of times, and it worked in the end
13:17:01speachythere's no good way to download/supply a work-in-process. I guess the original intnt was that translators wouldn't let things get so far out of date. :(
13:17:27speachyat least with the infrastructure currently partial translations are still worth committing as the "same as english" stuff properly flags these as needing to be looked at.
13:18:18speachyMAybe I could add a checkbox at the top that would tell it to supply the full .lang file instead of just the diff?
13:18:23user890104i see, there also isn't an obvious way to run a non-commited translation file through the website checks
13:18:54speachyyeah, and the mechanism that does exist isn't as strict as what the main tooling uses.
13:19:28speachy...all that is on the todo (eventually) list.
13:19:32user890104I would do it as two separate buttons at the bottom, Download patch for submission, and Download complete file
13:19:44speachygood call.
13:20:19user890104well, as a PHP developer, I can easily make a bunch of improvements
13:22:41user890104I would make the input file selectable between the master branch, a specific commit and a user-provided file, so that manual or partial translations can be checked and improved
13:23:25speachyfeel free to make any improvements you see fit
13:23:58speachyit's not fair to say that I loathe PHP, but I'm usually very non-motivated to work on it. :D
13:26:40speachyHmm. Master or user-provided file only, I think.
13:29:40user890104fair enough
13:33:20user890104 g#5831 has the changes beyond input variable 1000
13:33:24rb-bluebotGerrit review #5831 at https://gerrit.rockbox.org/r/c/rockbox/+/5831 : Update Bulgarian translation, part 2 by Vencislav Atanasov
13:34:00user890104also the Italian is missing just a single voice file in order to be at 100%
13:35:03speachyyep, it's something that needs someone that knows the right way to correct it.
13:41:18speachyI hacked together a full/patch submit thing.
13:43:53rb-bluebotBuild Server message: New build round started. Revision dd58b05f61, 337 builds, 7 clients.
13:43:53rb-bluebotUpdate Bulgarian translation, part 2 by Vencislav Atanasov
13:45:52user890104how do I generate the voice files locally? is is a configure/make option?
13:49:53speachyyeah, advanced/voice
13:50:01speachyor you can use rbutil
13:50:26speachycould do it completely manually if you wanted, but this is far simpler. :D
13:51:46user890104I found tools/voice.pl but I'm unsure how to use it
13:52:20user890104also there seems to be a typo in gtts_lang_map
13:52:37user890104 'bulgarian' => 'l bg',
13:52:37user890104it looks like this needs a dash before l
13:53:06speachyoops. clearly that's untested. :D
13:53:37speachyit's a little convoluted, set up a voice build using configure, then run make V=1 voice and it will show you the various command line invocations
13:53:50user890104i see, thanks
13:54:06user890104pushing to prod like CrowdStrike last week
13:54:43speachyI'm not sure if anyone other than me (and the build infra) has run this stuff with anything other than the default settings.
13:56:00***Saving seen data "./dancer.seen"
13:56:33user890104well, the fact that the script is in Perl speaks for itself
13:58:07speachyI think it's more a reflection of the user/developer base than choice of implementation language. non-technical users either use rbutil or download a pre-built voice.
13:58:52rb-bluebotBuild Server message: Build round completed after 899 seconds.
13:58:53rb-bluebotBuild Server message: Revision dd58b05f61 result: All green
13:58:57rb-bluebotBuild Server message: New build round started. Revision 6dd9b9786c, 337 builds, 7 clients.
13:58:57rb-bluebotvoice: Fix typo in Bulgarian gtts default cmdline by Solomon Peachy
13:59:08user890104yes, but when making a translation, you need to be able to hear if it sounds well before submitting
13:59:12speachy...and even then hardly any feedback about how well this stuff works. Before I started hacking on it so heavily it was clear that it was barely working even for just english. :D
13:59:28user890104ouch
14:00
14:01:24speachyyeah. now we're up to... 16 voice sets being generated nightly, and the overall translation (and localization) state has never been better.
14:02:24speachygranted nobody knows how widely any of this stuff is used...
14:03:05user890104at some point during the weekend I was wondering how good of an idea would be to have a container image with the toolchains prebuilt, and running CI in GitHub
14:05:03speachyvarious folks have created containers/VMs with the toolchains present, but they're never kept maintained.
14:06:24user890104also there's 2k minutes per month per account of free CPU time for CI
14:07:03speachythat would be exhausted in days.
14:08:29speachy337 separate build targets (that will be upped by another 30-ish once I add the rest of the manuals)
14:10:01user890104ah, rbutil needs a player connected in order to generate the voice files (or do anything whatsoever)
14:10:31speachyGitHub CI won't give us any _new_ capabilities and make it any easier for random other folks to meaningfully contribute
14:10:53user890104well, it can save the old artifacts
14:12:47speachyjust the ones we keep amount to ... ~4.6GB/day
14:13:26speachyand ~80GB for our current ~3wk retention.
14:15:23speachy(with the additional voices added recently that's going to be nearly 100GB...)
14:15:33rb-bluebotBuild Server message: Build round completed after 997 seconds.
14:15:34rb-bluebotBuild Server message: Revision 6dd9b9786c result: All green
14:35:28user890104speachy: can you please fix the last two errors on the Bulgarian voice strings manually, by prefixing them with a ~? I wonder how I missed these...
14:56:53speachywill do
15:00
15:48:16rb-bluebotBuild Server message: New build round started. Revision 8d436561e2, 337 builds, 7 clients.
15:48:16rb-bluebotplugins: playing time: use cpu_boost + simplify a bit by Christian Soffke
15:56:01***No seen item changed, no save performed.
16:00
16:03:28rb-bluebotBuild Server message: Build round completed after 912 seconds.
16:03:29rb-bluebotBuild Server message: Revision 8d436561e2 result: All green
16:03:33rb-bluebotBuild Server message: New build round started. Revision 254eaf509e, 337 builds, 7 clients.
16:03:33rb-bluebotFix the final two Bulgarian translation same-as-English issues by Solomon Peachy
16:05:03speachyouch, the bulgarian translation bumped our language table size up by over 2KB. gotta love multi-byte encodings.
16:16:56rb-bluebotBuild Server message: Build round completed after 804 seconds.
16:16:57rb-bluebotBuild Server message: Revision 254eaf509e result: All green
16:45:55 Join lebellium [0] (~lebellium@2a01cb0405d07f00d33a0da62bfc2206.ipv6.abo.wanadoo.fr)
17:00
17:56:02***No seen item changed, no save performed.
18:00
18:11:39 Quit lebellium (Quit: Leaving)
18:19:59 Quit IPG (Ping timeout: 260 seconds)
18:35:53rb-bluebotBuild Server message: New build round started. Revision c0ac043c6d, 337 builds, 6 clients.
18:35:54rb-bluebotget_volume_name generate volume names once then reuse by William Wilgus
18:49:20_bilgusSo far so good on data aborts on USB unplug I hope thats the last of them, I think I made them more likely by exiting the file browser since there was no longer something to fallback to to take its place when the redraw event loop ran again
18:50:16_bilgusnot that it was guaranteed anyway..
18:55:38speachy_bilgus: I have a feeling this is going to generate a pile of red.
18:56:13_bilgusshouldn't
18:56:15 Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net)
18:56:24speachyno wait, MULTIDRIVE ==> MULTIVOLUME These days
18:56:39speachy(after that last massive sea of red debacle of mine)
18:56:52_bilgusbut I do always worry when this stuff runs way long
18:57:18speachyour build cycles are roughly 2x longer due to losing b0h00n's beefy builders
18:57:53_bilgusoh wasn't aware
18:58:02speachybut changing headers that half the world depends on means ccache isn't as effective
18:58:49rb-bluebotBuild Server message: Build round completed after 1376 seconds.
18:58:50rb-bluebotBuild Server message: Revision c0ac043c6d result: All green
18:58:54rb-bluebotBuild Server message: New build round started. Revision 96f564fe64, 337 builds, 6 clients.
18:58:54_bilguswoot
18:58:54rb-bluebotmanual: update single mode by Christian Soffke
18:59:23speachyglad to be wrong!
19:00
19:00:14speachywould be nice to have other builders capable of manual builds
19:00:39speachythose don't parallelize to additional cores, unlike everything else.
19:01:42_bilgusso dir create is ~3% faster diropen 33% dirscan 12% dirscan w/ info 6% and delete 11%
19:03:49_bilgusI didn't see anything on the file create but its probably in the wash
19:03:49speachynice.
19:03:49speachygonna look into making the volume string voiced finally too.
19:03:49_bilgusI should try a few tag cache builds the two changes I've made (not copying file path, and this) should equate to a few minutes off the nearly hour build time
19:04:42_bilgusI won't argue, lmk if you need anything
19:18:28rb-bluebotBuild Server message: Build round completed after 1175 seconds.
19:18:29rb-bluebotBuild Server message: Revision 96f564fe64 result: All green
19:19:47speachyanimal-petur also dropped (along with the b0hoon's three)
19:20:02speachyso there are some cold ccaches in there
19:36:08 Join massiveH [0] (~massiveH@2600:4040:a982:dc00:5d20:47ea:b433:b34e)
19:56:03***Saving seen data "./dancer.seen"
20:00
20:43:55__builtinspeachy: no, I don't believe the font pack needs updating
20:56:07rb-bluebotBuild Server message: New build round started. Revision cd1922fe74, 337 builds, 6 clients.
20:56:07rb-bluebotpuzzles: update documentation and copyright year. by Franklin Wei
21:00
21:13:16rb-bluebotBuild Server message: Build round completed after 1030 seconds.
21:13:17rb-bluebotBuild Server message: Revision cd1922fe74 result: All green
21:37:53 Join dconrad [0] (~dconrad@152.117.104.217)
21:38:54dconrad_bilgus: thanks for the lead, I'll look into that
21:39:44dconradnot quite sure where to run it, perhaps from the button checking code
21:40:14 Quit Bobathan_ (Quit: ZNC 1.8.2+deb2+b1 - https://znc.in)
21:47:54 Join Bobathan_ [0] (~admin@syn-065-029-248-157.res.spectrum.com)
21:55:42_bilgusidk thats probably fine there are a few always running queue/threads you cn pick
21:56:05***Saving seen data "./dancer.seen"
21:57:05 Quit Bobathan_ (Quit: ZNC 1.8.2+deb2+b1 - https://znc.in)
21:57:20_bilgusyou could also hook the track skip stuff and grab the time remaining and set up a timer to hit in x seconds to check again i'm not sure how perfect thatd'd be though
21:58:10_bilgusin theory it'd probably be the least hairy with edge cases
22:00
22:03:44 Quit acidsys (Ping timeout: 264 seconds)
22:10:34 Join Bobathan_ [0] (~admin@syn-065-029-248-157.res.spectrum.com)
22:16:37rb-bluebotBuild Server message: New build round started. Revision 89b4cd59ef, 337 builds, 6 clients.
22:16:37rb-bluebot[BugFix] extra slashes in recording directory by William Wilgus
22:21:54 Join acidsys [0] (~crameleon@openSUSE/member/crameleon)
22:25:29 Quit Moriar (Ping timeout: 255 seconds)
22:33:00rb-bluebotBuild Server message: Build round completed after 984 seconds.
22:33:01rb-bluebotBuild Server message: Revision 89b4cd59ef result: All green
22:47:17 Quit bluebrother (Ping timeout: 248 seconds)
22:47:39 Quit rb-bluebot (Ping timeout: 276 seconds)
22:48:58 Join bluebrother [0] (~dom@user/bluebrother)
23:00
23:00:06 Join rb-bluebot [0] (~rb-bluebo@rockbox/bot/utility)
23:02:03 Quit massiveH (Quit: Leaving)
23:47:13dconrad_bilgus: for the time being I chose to hook into the playback.c start/stop/pause functions, that gets rid of my ~4 second delay
23:48:02dconradso that's cool, though now it actually works too fast haha, in some circumstances it doesn't wait for the fade out to finish.... I'm sure it's an easy oversight on my part but I'm happy with some progress for the night
23:49:20dconradand it still feels like a pretty hacky solution but I'm sure I can clean it up
23:56:06***Saving seen data "./dancer.seen"
23:58:24 Quit dconrad ()

Previous day | Next day