| 00:31:29 | | Quit dconrad (Remote host closed the connection) |
| 00:32:02 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 00:36:14 | | Quit dconrad (Ping timeout: 244 seconds) |
| 01:00 |
| 01:17:38 | | Quit Malinux- (Ping timeout: 248 seconds) |
| 01:20:04 | | Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7) |
| 01:23:19 | *** | Saving seen data "./dancer.seen" |
| 02:00 |
| 02:38:34 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 02:42:57 | | Quit dconrad (Ping timeout: 246 seconds) |
| 03:00 |
| 03:19:27 | | Join rogeliodh91 [0] (~rogeliodh@rogeliodh.dev) |
| 03:19:45 | | Join cstine7 [0] (~cstine@150.136.136.191) |
| 03:20:08 | | Join cnx_ [0] (~cnx@tem.loang.net) |
| 03:20:46 | | Join Tonux_ [0] (~Tonux@193.32.127.216) |
| 03:21:38 | | Quit cnx (Ping timeout: 246 seconds) |
| 03:21:38 | | Quit Tonux (Remote host closed the connection) |
| 03:21:38 | | Quit cstine (Read error: Connection reset by peer) |
| 03:21:38 | | Quit rogeliodh9 (Ping timeout: 246 seconds) |
| 03:21:39 | | Quit zou (Ping timeout: 246 seconds) |
| 03:21:39 | | Nick cnx_ is now known as cnx (~cnx@tem.loang.net) |
| 03:21:39 | | Nick cstine7 is now known as cstine (~cstine@150.136.136.191) |
| 03:21:42 | | Nick Tonux_ is now known as Tonux (~Tonux@193.32.127.216) |
| 03:21:47 | | Join zou [0] (~quassel@user/zou) |
| 03:23:23 | *** | Saving seen data "./dancer.seen" |
| 04:00 |
| 04:14:48 | | Quit chamlis (Remote host closed the connection) |
| 04:15:02 | | Join chamlis [0] (~chamlis@user/chamlis) |
| 04:40:17 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 04:45:11 | | Quit dconrad (Ping timeout: 265 seconds) |
| 05:00 |
| 05:04:49 | | Join jacobk_ [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net) |
| 05:05:00 | | Quit jacobk (Ping timeout: 276 seconds) |
| 05:23:25 | *** | Saving seen data "./dancer.seen" |
| 07:00 |
| 07:04:34 | | Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net) |
| 07:23:28 | *** | No seen item changed, no save performed. |
| 07:42:45 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 07:47:06 | | Quit dconrad (Ping timeout: 246 seconds) |
| 08:00 |
| 08:49:00 | | Quit bbbccc (Ping timeout: 252 seconds) |
| 09:00 |
| 09:00:18 | | Quit lane (Remote host closed the connection) |
| 09:00:26 | | Quit dook (Remote host closed the connection) |
| 09:00:26 | | Quit ursa-major (Remote host closed the connection) |
| 09:01:10 | | Join lane [0] (809450f172@2a03:6000:1812:100::1300) |
| 09:01:28 | | Join ursa-major [0] (114efe6c39@2a03:6000:1812:100::11f3) |
| 09:01:28 | | Join dook [0] (c9db4a6425@2a03:6000:1812:100::1222) |
| 09:23:31 | *** | Saving seen data "./dancer.seen" |
| 10:00 |
| 10:10:20 | | Nick jacobk_ is now known as jacobk (~quassel@47-186-105-237.dlls.tx.frontiernet.net) |
| 10:33:04 | | Join thanosengine [0] (~thanos@user/thanosengine) |
| 10:41:52 | | Quit decky_e_ (Read error: Connection reset by peer) |
| 10:42:17 | | Join decky_e_ [0] (~decky_@69.9.139.14) |
| 10:51:49 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 10:56:18 | | Quit dconrad (Ping timeout: 248 seconds) |
| 11:00 |
| 11:23:32 | *** | Saving seen data "./dancer.seen" |
| 11:49:50 | | Join halloy6399 [0] (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 11:51:09 | halloy6399 | Hello all ; I hope you are all doing well. I submitted now my first 2 patches to start contributing to the Rockbox project : https://gerrit.rockbox.org/r/c/rockbox/+/5898 and here https://gerrit.rockbox.org/r/c/rockbox/+/5897 |
| 11:51:27 | | Nick halloy6399 is now known as OlsroFR (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 11:51:39 | OlsroFR | Ok now I should have my username haha |
| 11:58:58 | | Quit thanosengine (Quit: WeeChat 4.3.1) |
| 12:00 |
| 12:04:18 | | Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net) |
| 12:08:05 | _bilgus | looks ok so far don't have time to look at it closely for a day or two unless someone beats me to it :) |
| 12:09:28 | _bilgus | rather than it being a user setting would it be better to just make a lockscreen automatically stop scrolling? |
| 12:10:41 | speachy | I'm imagine it depends on the contents of the lock screen |
| 12:30:44 | OlsroFR | https://gerrit.rockbox.org/r/c/rockbox/+/5899 a 3rd patch now in review to improve ATA power management with sharing of some of my recent findings. I was working on it since a lot of time and did tests. |
| 12:31:37 | OlsroFR | _bilgus: Rockbox currently has no idea about what is a lockscreen. Theme makers are just clearing completely the view port to draw custom things on screen while being in the homescreen |
| 12:32:19 | | Join thanosengine [0] (~thanos@user/thanosengine) |
| 12:33:00 | OlsroFR | My solution is maybe a bit ugly though, I recognize. I did it as my first Rockbox developement ever, so I wanted to do something simple to fix this problem on my specific theme |
| 12:33:42 | OlsroFR | I just got the idea that we could maybe create a tag that would be a toggle and that themes makers could call to stop texts scrolling temporarily in this context. What do you think about that ? |
| 12:35:15 | | Join bbbccc [0] (~aaabbb@5.254.86.4) |
| 12:35:50 | OlsroFR | But the idea also of having an option is that it would allow to get the fix for everyone on themes that have not received any updates since years. If anyone want to use those themes or any themes that are not getting updates, with the option they can fix the bug by themselves directly on device. |
| 12:38:24 | | Quit prg (Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in) |
| 12:41:37 | speachy | there's no real point to more finegrained ATA power management, and in the case of the iflash drives it causes more problems than it solves. because ven when they claim to implement PM (which is rarely) they don't actually _work_ properly −− symptoms include requiring an unconditional power cycle after issuing a STANDBY. |
| 12:44:06 | speachy | most savings come from (1) spindown of non-SSDs, and (2) removing power altogether. more than that just adds a ton of complexity without any real benefit, at least on these 20-year-old iPods. |
| 12:45:12 | OlsroFR | yeah those adapters just ignores any ATA related commands. Even the IDLE command which should be the first power management state is completely ignored |
| 12:45:22 | speachy | and given the huge variation in "quality" of SD cards (on top of the variation in the ATA<->SD adapters) |
| 12:45:38 | OlsroFR | Even if the patch is not accepted for good reasons, at least I submitted it so maybe a future researcher could learn from it in some way so it is archived |
| 12:46:07 | OlsroFR | I tried to go more far but I just don't have the low-level programming knowledge to search any deeper |
| 12:46:32 | speachy | ...it's not so much knowledge as trial-and-error. a lot of it. |
| 12:46:47 | OlsroFR | That's frustrating because for some reason, the Stock OS power management just works with all of this. My Mini could last 17 hours with iFlash on Stock OS |
| 12:47:11 | speachy | I suspect that's because the classic OS doesn't try to be as clever. |
| 12:47:20 | OlsroFR | speachy: Ok so I should maybe continue trial and error but well, I already spend so much hours trying without any good result on my iFlash modded Mini so I ended up giving up |
| 12:47:35 | speachy | stuff is hardcoded for the specific drives they shipped with |
| 12:48:23 | OlsroFR | On the Mini, cutting the power to the drive ends up to never being able to do any I/O when it's woken up again. I tried to guess if it was some timing issues, but after so many tests, I could not get any positive result |
| 12:48:38 | speachy | and I think their PM strategy was similarly blunt −− the stock OS performed nearly no writes, so it was nearly always safe to kill power |
| 12:49:19 | OlsroFR | that was also my theory. So I disabled all kind of writes on Rockbox to do only reads after waking up again the power |
| 12:49:27 | OlsroFR | But it did nothing; it's completely frozen |
| 12:49:28 | speachy | whereas with these adapters, they (1) don't respect the data flushing commands, and (2) the SD cards don't either. :D |
| 12:50:26 | speachy | I have a classic iflash SD adapter in the mini2g on my desk right now. |
| 12:50:32 | OlsroFR | it would have been an acceptable compromise for me to get an option to disable any kind of writes just to get power management working as excepted, but well, it's more complex than that especially on the Mini it seems |
| 12:51:48 | | Quit thanosengine (Quit: WeeChat 4.3.1) |
| 12:52:24 | speachy | the root cause of the data corruption issues was "optimized" PIO timings that worked great for ATA-compliant stuff (ie the original drives, plus native CF cards) but the iFlash adapters couldn't take it, despite being perfectly "legal". |
| 12:53:03 | | Join prg [0] (~prg@xannode.com) |
| 12:53:05 | speachy | that wasn't an ATA issue per se, but rather the low level timings used by the chipset's ATA controller. |
| 12:53:41 | OlsroFR | Okay. For the Mini it's more complex than that, you just can't get any IO working after waking up again the drive |
| 12:54:06 | OlsroFR | Never encountered any kind of corruption during my tests, it was just completely dead after trying to wake up the iFlash device |
| 12:54:13 | speachy | 1st gen mini or 2nd gen? |
| 12:54:25 | OlsroFR | I only have 2 second gen minis |
| 12:55:17 | OlsroFR | One of mine has a 128GB real compact flash so everything works perfect. And the second one has 1TB of memory with an iFlash adapter |
| 12:56:29 | speachy | most of that patch is superfluous with the current code, fwiw. |
| 12:56:36 | OlsroFR | But well, the most important from the 3rd patch I submitted in terms of impact is clearly the patch imo to get the ability to do full mixes of your whole library while respecting the limit of songs configured in the options. It's game changer in terms of performance. |
| 12:57:04 | OlsroFR | Now my mini can shuffle my library of more than 20 000 songs in just around 8 seconds to create a full random play list of 2000 songs picked from the 20000 songs |
| 12:57:26 | OlsroFR | https://www.reddit.com/r/rockbox/comments/1ez0mq4/i_developped_true_full_library_shuffle_for/ I did a benchmark here and it is 16,4x faster |
| 12:57:26 | speachy | (eg DMA is used for all writes if the device claims to support it) |
| 12:57:29 | | Join thanosengine [0] (~thanos@user/thanosengine) |
| 12:57:52 | OlsroFR | speachy: Okay, I was not aware of this. I took that from the msata patch |
| 12:59:03 | speachy | that original msata patch was written against 3.14 (I think) and a _lot_ has changed since then. |
| 13:00 |
| 13:01:15 | speachy | we'll let chris_s have the word on the shuffle stuff, he's done extensive work on this in recent months. |
| 13:01:36 | speachy | also tehre's a lot of style changes in there that make discerning the actual functional changes more difficult. |
| 13:02:34 | OlsroFR | If that's too difficult to read, I can separate style changes to functional changes in different commits |
| 13:03:25 | speachy | please do. |
| 13:03:56 | OlsroFR | Ok I noted it on my todolist |
| 13:06:08 | OlsroFR | thank you for all the feedback, I am now going to afk a bit. Later one another objective from my todolist is to upload all the themes I've done using the official form |
| 13:09:09 | | Join dconrad [0] (~dconrad@152.117.104.217) |
| 13:13:00 | | Quit OlsroFR (Ping timeout: 260 seconds) |
| 13:13:38 | | Quit dconrad (Ping timeout: 252 seconds) |
| 13:23:34 | *** | Saving seen data "./dancer.seen" |
| 14:00 |
| 14:52:32 | | Quit Strife89 (Quit: Connection closed for inactivity) |
| 15:00 |
| 15:11:37 | | Join bertrik [0] (~bertrik@revspace/participant/bertrik) |
| 15:23:38 | *** | Saving seen data "./dancer.seen" |
| 15:42:28 | | Quit thanosengine (Quit: WeeChat 4.3.1) |
| 16:00 |
| 16:02:58 | | Quit jacobk (Ping timeout: 248 seconds) |
| 16:19:45 | | Quit Natch (Read error: Connection reset by peer) |
| 16:20:10 | | Join Natch [0] (~natch@c-9e07225c.038-60-73746f7.bbcust.telenor.se) |
| 16:44:46 | | Join halloy6399 [0] (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 16:45:12 | halloy6399 | https://gerrit.rockbox.org/r/c/rockbox/+/5901 New patch in review; just finished it, it was also in my todo list |
| 16:45:19 | | Nick halloy6399 is now known as OlsroFR (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 16:45:34 | OlsroFR | pseudo changed again lol, I am new to IRC |
| 16:46:17 | OlsroFR | The iPod Mini has a so tiny screen that the cheat sheet for Morse could not show all characters. I improved the display to show all characters :) |
| 16:46:34 | OlsroFR | This time I separated the feature with the code style so it will be easier to review |
| 17:00 |
| 17:01:03 | OlsroFR | https://gerrit.rockbox.org/r/c/rockbox/+/5903 merge request for the shuffle system revamp without the code style changes |
| 17:01:23 | OlsroFR | Code styles changes are all here https://gerrit.rockbox.org/r/c/rockbox/+/5902 and here https://gerrit.rockbox.org/r/c/rockbox/+/5900 |
| 17:04:12 | chamlis | I'm having an issue with my ipod video where it won't stay powered off. I found some old posts saying this was caused by a fault in the usb charging circuitry, but I'm not seeing the associated voltage being put across the usb output. are there any other things I could investigate? |
| 17:07:12 | | Quit ajk (Quit: and it's always been the same / it's just a complicated game) |
| 17:07:34 | | Join ant|hactar [0] (~zem@97-115-91-140.ptld.qwest.net) |
| 17:07:48 | ant|hactar | as a mini user it's nice to see it get some love |
| 17:23:41 | *** | Saving seen data "./dancer.seen" |
| 17:32:31 | OlsroFR | lol I cannot upload my themes because of the option "Disable main menu scrolling is not a allowed theme setting" that does not exist yet haha |
| 17:33:14 | OlsroFR | I have all the zips and the screenshots ready for my 2 ipods minis themes + 2 ipods grayscale classics themes |
| 17:42:13 | OlsroFR | If my new option is gonna be merged, I am going to wait before upload my themes that set it |
| 17:44:25 | | Quit OlsroFR (Remote host closed the connection) |
| 18:00 |
| 18:07:39 | _bilgus | g# 5903 looking thru this I have a few things that bother me no enough to stop it but uh the 256k static table |
| 18:09:41 | _bilgus | you already have the uniqbuf at 64k just above it |
| 18:42:07 | _bilgus | couple things with that one checking every entry that goes thru dirbrowse for 'Shuffle Songs' is not going to fly thats terrible for performance in every other context |
| 18:42:22 | _bilgus | g#2167 should help you with that |
| 18:42:25 | rb-bluebot | Gerrit review #2167 at https://gerrit.rockbox.org/r/c/rockbox/+/2167 : tagtree add %reload to allow hot reloading of tagnavi config by William Wilgus |
| 19:00 |
| 19:02:56 | | Quit sam_d_ (Ping timeout: 244 seconds) |
| 19:05:41 | | Join sam_d [0] (~sam@user/sam-d/x-8933526) |
| 19:10:41 | _bilgus | OlsroFR (logs?) couple thing on the Disable scrolling one and we can push it the others gonna need a bit of work |
| 19:19:45 | | Join halloy6399 [0] (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 19:19:51 | | Nick halloy6399 is now known as OlsroFR (~halloy639@aaubervilliers-198-1-21-253.w92-159.abo.wanadoo.fr) |
| 19:21:18 | OlsroFR | _bilgus: Thank you very much for your code reviews. I was aware during coding that doing what I do would not work in any other context than the DB, especially when the DB is cached on RAM, it gives an incredible user experience. During my developement I choosed on purpose to not extend this to any other context |
| 19:22:40 | OlsroFR | About the 256k buffer, well, I choosed to do this because 64k is too limited and I was afraid that it was user in another context that would cause memory issues/corruptions. I will investigate on this and maybe increase the size of that buffer, because 64k is a bit too low, there is probably people on the community that have music libraries that are higher than this |
| 19:23:45 | *** | Saving seen data "./dancer.seen" |
| 19:23:57 | | Join massiveH [0] (~massiveH@2600:4040:a982:dc00:3cd5:6d27:6e4f:11ae) |
| 19:27:41 | | Quit advcomp2019__ (Read error: Connection reset by peer) |
| 19:36:30 | | Join advcomp2019 [0] (~advcomp20@user/advcomp2019) |
| 19:39:10 | | Quit advcomp2019 (Read error: Connection reset by peer) |
| 19:42:51 | | Join advcomp2019 [0] (~advcomp20@user/advcomp2019) |
| 19:43:48 | _bilgus | there are only users in that file so you should be fine to use it and increase it a bit if needed but keep in mind not all targets have memory like a device that has a harddrive |
| 19:48:35 | _bilgus | speachy, apparently 'contributing' on the wiki linked to the cgit instance with a URL parameters 'https://git.rockbox.org/?p=rockbox.git;a=blob;f=docs/CONTRIBUTING' that doesn't work apparently so I changed this to 'https://git.rockbox.org/cgit/rockbox.git/tree/docs/CONTRIBUTING' assuming this won't cause more issues |
| 19:49:00 | speachy | oh wow, that's truly ancient. :D |
| 19:49:58 | _bilgus | I was trying to get it to let me access stuff like that but I guess its blocked or deprecated |
| 19:50:15 | _bilgus | well other pages |
| 19:51:13 | speachy | I think that's the gitweb syntax.. |
| 19:53:05 | speachy | might not be a bad idea to to a global search/replace on the current pages |
| 19:57:06 | OlsroFR | just finished processing most of reviews, morse code cheat sheet improvements + the new option should now be mergeable. Now I am going to sleep, it's late here :) |
| 19:57:31 | OlsroFR | I will work tomorrow on the shuffle system, it requires much more attention |
| 19:57:35 | OlsroFR | (and tests) |
| 19:58:47 | OlsroFR | I will also probably define a new compilation parameter to use the new shuffle system and allocate memory for it so potato mp3 players will not suffer regression to this addition |
| 20:00 |
| 20:01:16 | _bilgus | OlsroFR, you don't need to submit a whole ned patch for each upload |
| 20:02:03 | _bilgus | when you do tou commit do git commit −−amend and you should be able to keep it in the same patchset |
| 20:02:35 | OlsroFR | How can I do it better ? I used to work with GitLab in the past which supported just creating new commits automatically in the same merge request |
| 20:02:51 | OlsroFR | OK I will do it that way |
| 20:03:28 | OlsroFR | I just did it with amend to fix the title of one commit, there was a type "cheat sheet" was wrote "cheat sheel" |
| 20:04:49 | _bilgus | I don't think gerrit does that I'll try to merge them but it might not let me |
| 20:05:43 | OlsroFR | Yeah Gerrit is so much different. But I am not fearing of it, it's a new opportunity to learn new things. It's funny how a similar tool can be so different at usage, I felt lost and had to read many documentation to get started |
| 20:06:48 | _bilgus | Ok I see whats going on |
| 20:06:53 | OlsroFR | If Gerrit is bothering you, tell me, and I will amend my work that way |
| 20:06:56 | OlsroFR | OK |
| 20:07:07 | _bilgus | when you push to us you arent actually changing the code |
| 20:07:38 | _bilgus | so your second patchset removing the stuff isn't needed yet |
| 20:07:53 | OlsroFR | It looks like I am just pushing some kind of tag. On GitLab it's different, you are pushing whole branches then you push to this merge request branch |
| 20:07:56 | _bilgus | now will it let me merge it nd do it without committing first maybe |
| 20:08:08 | _bilgus | I'm going to try |
| 20:09:30 | OlsroFR | After the push of the option in the main repo, how much time I will had to wait before being able to upload the themes that set this new option ? |
| 20:09:34 | OlsroFR | have* |
| 20:11:18 | _bilgus | IDK a whole lot about the theme system but it should work after the commit round is complete assuming its automagic |
| 20:13:43 | OlsroFR | OK I need another patch for this |
| 20:13:55 | OlsroFR | utils/themeditors/resources/configkeys needs to be updated |
| 20:14:42 | OlsroFR | also, I am going to add a new entry in the manual for this |
| 20:23:25 | OlsroFR | done : https://gerrit.rockbox.org/r/c/rockbox/+/5908 |
| 20:27:00 | rb-bluebot | Build Server message: New build round started. Revision fbc8b2156f, 337 builds, 9 clients. |
| 20:27:00 | rb-bluebot | Credits: Adding me to the credits of the project by Paul Sauro |
| 20:27:43 | _bilgus | ok I got that fixed you'll need to hit abandon on 5906 it won't let me discard it |
| 20:28:42 | _bilgus | the codestyle and rever codestyles ones can be abandoned too speachy do we have a way to just nuke em from orbit or are they stuck there forever? |
| 20:30:10 | _bilgus | OlsroFR, when that one completed successfully I'll push your other |
| 20:30:12 | OlsroFR | abandon done https://gerrit.rockbox.org/r/c/rockbox/+/5906 |
| 20:42:39 | rb-bluebot | Build Server message: Build round completed after 940 seconds. |
| 20:42:40 | rb-bluebot | Build Server message: Revision fbc8b2156f result: 243 errors 0 warnings |
| 20:56:50 | | Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net) |
| 20:58:14 | | Quit OlsroFR (Remote host closed the connection) |
| 21:00 |
| 21:15:33 | | Quit baltazar (Ping timeout: 248 seconds) |
| 21:17:34 | | Join baltazar [0] (~baltazar@user/baltazar) |
| 21:23:48 | *** | Saving seen data "./dancer.seen" |
| 21:26:52 | rb-bluebot | Build Server message: New build round started. Revision 49bbfe7505, 337 builds, 9 clients. |
| 21:26:52 | rb-bluebot | Fix red fbc8b2156f by William Wilgus |
| 21:30:26 | _bilgus | that one took me a minute |
| 21:41:33 | rb-bluebot | Build Server message: Build round completed after 881 seconds. |
| 21:41:34 | rb-bluebot | Build Server message: Revision 49bbfe7505 result: All green |
| 21:41:40 | rb-bluebot | Build Server message: New build round started. Revision 14a8f9a863, 337 builds, 9 clients. |
| 21:41:41 | rb-bluebot | Integrate the new option to the theme engine and to the manual by Paul Sauro |
| 21:53:56 | rb-bluebot | Build Server message: Build round completed after 736 seconds. |
| 21:53:57 | rb-bluebot | Build Server message: Revision 14a8f9a863 result: All green |
| 23:00 |
| 23:08:02 | | Join JanC_ [0] (~janc@user/janc) |
| 23:08:02 | | Quit JanC (Killed (zirconium.libera.chat (Nickname regained by services))) |
| 23:08:02 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
| 23:13:24 | | Quit massiveH (Quit: Leaving) |
| 23:23:49 | *** | Saving seen data "./dancer.seen" |
icon identifies that the person is a core developer (has commit access).