Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-09-12

00:48:16 Quit dconrad (Remote host closed the connection)
01:00
01:05:09 Join dconrad [0] (~dconrad@152.117.104.217)
01:09:24 Quit dconrad (Ping timeout: 246 seconds)
01:30:53***Saving seen data "./dancer.seen"
02:00
02:33:04 Quit kugel_ (Remote host closed the connection)
02:37:14 Quit jacobk (Ping timeout: 260 seconds)
02:38:05 Join kugel_ [0] (~kugel@ip4d146a3a.dynamic.kabel-deutschland.de)
02:40:31 Quit kugel_ (Client Quit)
02:40:50 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
02:43:15 Join kugel [0] (~kugel@ip4d146a3a.dynamic.kabel-deutschland.de)
03:00
03:10:16 Join dconrad [0] (~dconrad@152.117.104.217)
03:14:29 Quit dconrad (Ping timeout: 248 seconds)
03:30:54***Saving seen data "./dancer.seen"
05:00
05:03:46 Quit jacobk (Ping timeout: 248 seconds)
05:04:34 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
05:30:57***Saving seen data "./dancer.seen"
05:48:43 Join OlsroFR [0] (~OlsroFR@user/OlsroFR)
05:50:30OlsroFR_bilgus I was not aware of this option. It seems slightly faster. I set it to the maximum possible on my ipod video
05:50:34 Quit OlsroFR (Client Quit)
06:00
06:16:22 Join dconrad [0] (~dconrad@152.117.104.217)
06:20:43 Quit dconrad (Ping timeout: 252 seconds)
06:38:23 Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net)
07:00
07:12:53 Quit Moriar (Ping timeout: 255 seconds)
07:31:01***Saving seen data "./dancer.seen"
08:00
08:00:04 Join thanosengine [0] (~thanos@user/thanosengine)
08:33:22 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
09:00
09:04:10speachy_bilgus: looks sane to me.
09:12:01 Quit rogeliodh9101 (Quit: The Lounge - https://thelounge.chat)
09:12:23 Join rogeliodh9101 [0] (~rogeliodh@rogeliodh.dev)
09:16:29 Quit thanosengine (Read error: Connection reset by peer)
09:22:04 Join thanosengine [0] (~thanos@user/thanosengine)
09:25:10 Join dconrad [0] (~dconrad@152.117.104.217)
09:30:07 Quit dconrad (Ping timeout: 264 seconds)
09:31:05***Saving seen data "./dancer.seen"
09:48:34 Join macaronus [0] (~macaronus@user/MaCaRoNus)
09:48:40 Quit macaronus (Remote host closed the connection)
09:52:57 Quit thanosengine (Quit: WeeChat 4.3.1)
10:00
10:02:52_bilgusthanks, this one i'll push i'm working on another to get rid of lastdir in tree.c my issue there is that I don't want to have to read the whole string if the currdir and lastdir don't match
10:05:01_bilgushad a crc function first worked well but It makes it where you have to traverse the whole sting to see if it is the same or changed where as storing and checking a string you get to potentially exit on the first letter and only have to traverse the whole string to tell the are the same
10:06:43 Join dconrad_phone [0] (~dconrad_p@205.237.113.8)
10:07:04 Quit dconrad_phone (Client Quit)
10:07:20_bilgusso crc is 'resumable' so I think I can just chunk the input tc.currdir / 10 and store 10 crcs - 32 characters each
10:07:43 Join dconrad_phone [0] (~dconrad_p@205.237.113.8)
10:08:27_bilgusfunny part is it still ends up saving quite a bit of ram
10:08:44speachyat the expense of CPU and complexity
10:09:15 Join ac_laptop [0] (~ac_laptop@78.243.130.4)
10:09:59_bilgusindeed although i'm not sure that its anyworse than traversing two strings when the haven't changed
10:15:52 Quit dconrad_phone (Quit: Connection closed)
10:16:04_bilguskinda makes me want to do both crc and save the string won't save space but could speed up the check
10:17:04 Join thanosengine [0] (~thanos@user/thanosengine)
10:17:49speachypretty sure CRC is always more expensive than a string comparison
10:20:23_bilgusIdk there isn't a whole lot going on in there rest assured not going to put anything in the hot path thats slower
10:21:13speachyheh far be it for me to tell someone what to spend their spare time obsessing over
10:23:08_bilgusI did notice with thatprevious patch that get_mp3entry_from_offset() is called a metric f ton of times
10:23:16speachyjust feels like a pretty minor thing
10:23:37_bilgusnot a result of the patch just in general course
10:24:30_bilguskuckily it usually hits offset 0 and 1 and just grabs a pointer to the id3 from the skin engine
10:24:42_bilgusluckily too
10:30:06_bilgusthey're all minor things but add up to better (hopefully)
10:32:31_bilguseh its in the wash it doesn't feel faster or slower and I can't get enough runs to get the time to vary enough between them to choose
10:35:57speachylacking an unambiguous "this is clearly more perforamnt I always err on the side of a simpler implementation"
10:36:17speachyuh.. quote placement fail
10:39:18 Quit thanosengine (Quit: WeeChat 4.3.1)
10:39:43_bilgusoh you know you say the whole thing out loud the quotes are probably right :p
10:41:22speachywe have a lot of really clever code in rockbox. some of it is utterly necessary, but when it's not, do a favor to future you and keep it simple...
10:41:26 Quit ac_laptop (Ping timeout: 252 seconds)
10:41:52speachy"if you always write code as cleverly as possible then by definition you're not smart enough to debug it."
10:42:36speachyokay, okay, I'll get off my soapbox. :D
10:47:02rb-bluebotBuild Server message: New build round started. Revision 85652e6bd1, 337 builds, 9 clients.
10:47:02rb-bluebotFS #13486 - Updated Korean Voice translation (Hoseok Seo) by Solomon Peachy
10:49:24 Join thanosengine [0] (~thanos@user/thanosengine)
10:55:01 Join ac_laptop [0] (~ac_laptop@2a0c:e303:0:7300:e29d:31ff:fe2d:a258)
10:55:46 Quit thanosengine (Quit: WeeChat 4.3.1)
10:58:11_bilgusso if you write shit code it'll be easier to debug?
10:58:31_bilgusexplains a lot about my process :p
11:00
11:01:11rb-bluebotBuild Server message: Build round completed after 850 seconds.
11:01:12rb-bluebotBuild Server message: Revision 85652e6bd1 result: All green
11:02:01speachyI was fortunate to have the folly of premature optimization demonstrated very early in my professional career.
11:03:11_bilgusgot a mention back to the project on this one https://saagarjha.com/blog/2020/04/12/designing-a-better-strcpy/
11:04:35_bilgusback when I did the strmemccpy stuff I went looking for other implementations and found this immediately noticed their bug, this thing was all over HN and no one noticed it in the comments just bitched about codestyle
11:05:22_bilgustook the guyt 6months to update the post, wonder how many bad implementations that has led to
11:05:35speachyyeah
11:06:26_bilguswas starting to wonder if it was purposeful
11:12:02speachyI've done that before, heh.
11:13:06_bilgusintroduced a zero day? :p
11:14:30_bilgusthat is one thing I must say about our code context at least when we screw up it usually doesn't expose your bank account and PII
11:17:28_bilgusSoftware Engineer, Android Security @ Google too
11:18:52_bilguslooking at their resume..
11:20:40speachydefinitely the latter, but also purposefully leaving a bug in to see if anyone spots it
11:23:30 Join dconrad [0] (~dconrad@152.117.104.217)
11:24:54_bilgusah probably generally disappointed in that then but an occasionally good response would slightly buoy faith in humanity :)
11:27:51 Quit dconrad (Ping timeout: 246 seconds)
11:31:09***Saving seen data "./dancer.seen"
11:54:51 Join cstine6 [0] (~cstine@150.136.136.191)
11:55:26 Join npmania_ [0] (~npmania@210.123.73.190)
11:55:28 Join retr0id3 [0] (~Retr0id@user/retr0id)
11:55:45 Join bbbccc [0] (~aaabbb@5.254.86.4)
11:58:26 Join baltazaar [0] (~baltazar@user/baltazar)
11:58:44 Join bertrik_ [0] (~bertrik@revspace/participant/bertrik)
11:58:59 Join Maxdaman1us [0] (~Maxdamant@user/maxdamantus)
12:00
12:03:32 Quit mendel_munkis (*.net *.split)
12:03:32 Quit baltazar (*.net *.split)
12:03:32 Quit npmania (*.net *.split)
12:03:32 Quit cstine (*.net *.split)
12:03:32 Quit retr0id (*.net *.split)
12:03:32 Quit aaabbb- (*.net *.split)
12:03:32 Quit Maxdamantus (*.net *.split)
12:03:32 Quit bertrik (*.net *.split)
12:03:32 Nick cstine6 is now known as cstine (~cstine@150.136.136.191)
12:03:35 Nick baltazaar is now known as baltazar (~baltazar@user/baltazar)
12:03:35 Nick npmania_ is now known as npmania (~npmania@210.123.73.190)
12:03:36 Nick retr0id3 is now known as retr0id (~Retr0id@user/retr0id)
13:00
13:01:29 Join mendel_munkis [0] (~mendel_mu@2600:4041:5ac9:a100:b225:aaff:fe5e:10eb)
13:31:12***Saving seen data "./dancer.seen"
14:00
14:42:41 Join dconrad [0] (~dconrad@152.117.104.217)
14:47:10 Quit dconrad (Ping timeout: 260 seconds)
15:00
15:31:15***Saving seen data "./dancer.seen"
16:00
16:39:21 Quit jacobk (Ping timeout: 276 seconds)
17:00
17:09:55rb-bluebotBuild Server message: New build round started. Revision 2a0f3c8276, 337 builds, 10 clients.
17:09:55rb-bluebothibyos_nativepatcher: rewrite for either fresh install or uninstall by Dana Conrad
17:21:13rb-bluebotBuild Server message: Build round completed after 680 seconds.
17:21:15rb-bluebotBuild Server message: Revision 2a0f3c8276 result: All green
17:26:14 Quit ac_laptop (Quit: WeeChat 3.8)
17:31:18***Saving seen data "./dancer.seen"
17:46:24 Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net)
18:00
18:02:12 Join dconrad [0] (~dconrad@152.117.104.217)
18:06:43 Quit dconrad (Ping timeout: 265 seconds)
18:45:03 Join dconrad [0] (~dconrad@152.117.104.217)
18:45:52dconradThanks for merging that speachy - would you mind putting the files from https://drive.google.com/file/d/1VPINutwydC69Prctd-TLjlFVPOeAVqxa/view?usp=share_link on the download server next to the bootloader files as well?
18:46:24dconradI'll add to the wiki about it too
19:00
19:16:05rb-bluebotBuild Server message: New build round started. Revision 79bed1f422, 337 builds, 9 clients.
19:16:05rb-bluebotRFC skin_tokens remove a static buffer by William Wilgus
19:27:42rb-bluebotBuild Server message: Build round completed after 698 seconds.
19:27:43rb-bluebotBuild Server message: Revision 79bed1f422 result: All green
19:31:19***Saving seen data "./dancer.seen"
19:43:41 Join jacobk [0] (~quassel@2603:8080:b200:7b02:77cb:6304:f9db:dda1)
19:49:52 Join massiveH [0] (~massiveH@2600:4040:a982:dc00:9501:d03e:834d:a794)
19:53:49 Quit jacobk (Ping timeout: 260 seconds)
20:00
20:54:04 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
21:00
21:24:37 Quit TorC (Ping timeout: 248 seconds)
21:31:23***Saving seen data "./dancer.seen"
21:50:29 Quit Moriar (Ping timeout: 260 seconds)
22:00
22:08:50 Quit XDjackieXD (Ping timeout: 248 seconds)
22:09:38 Join jackie [0] (~jackie@banana-new.kilobyte22.de)
22:18:17 Quit dconrad (Remote host closed the connection)
22:41:54 Join TorC [0] (~Tor@fsf/member/TorC)
22:55:50 Join dconrad [0] (~dconrad@152.117.104.217)
23:00
23:10:03 Quit massiveH (Quit: Leaving)
23:31:27***Saving seen data "./dancer.seen"

Previous day | Next day