Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-11-21

00:04:45 Quit dconrad (Remote host closed the connection)
00:08:54 Join dconrad [0] (~dconrad@152.117.104.232)
00:13:48 Quit dconrad (Ping timeout: 276 seconds)
00:33:42***Saving seen data "./dancer.seen"
02:00
02:10:35 Join dconrad [0] (~dconrad@152.117.104.232)
02:15:01 Quit dconrad (Ping timeout: 248 seconds)
02:33:44***Saving seen data "./dancer.seen"
04:00
04:04:18 Quit jacobk (Ping timeout: 248 seconds)
04:05:01 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
04:33:47***Saving seen data "./dancer.seen"
05:00
05:00:49 Quit vup (Quit: vup)
05:13:00 Join dconrad [0] (~dconrad@152.117.104.232)
05:18:00 Quit dconrad (Ping timeout: 276 seconds)
06:00
06:00:14 Join vup [0] (~~~~@46.101.193.235)
06:06:45 Quit Tonux (Read error: Connection reset by peer)
06:07:04 Join Tonux [0] (~Tonux@193.32.127.240)
06:08:40user890104speachy: should I submit any of these commits as a change to be merged into master? https://gitlab.com/user890104/rockbox/-/compare/master...ipodnano3g4g
06:29:01 Join martylake_ [0] (~martylake@82.66.174.242)
06:30:15 Quit martylake (Ping timeout: 260 seconds)
06:30:44 Nick martylake_ is now known as martylake (~martylake@82.66.174.242)
06:33:51***Saving seen data "./dancer.seen"
06:43:11 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:4066:3768:98f7:4656)
06:59:30 Quit rnkn (Quit: Client closed)
07:00
07:33:18rb-bluebotBuild Server message: New build round started. Revision 587cf2fca0, 345 builds, 9 clients.
07:33:19rb-bluebotlang: Add VOICE_LANG_NAME for espanol by Solomon Peachy
07:47:39rb-bluebotBuild Server message: Build round completed after 862 seconds.
07:47:41rb-bluebotBuild Server message: Revision 587cf2fca0 result: All green
07:47:51rb-bluebotBuild Server message: New build round started. Revision 505bbcaff5, 345 builds, 9 clients.
07:47:51rb-bluebotvoice: Correct piper voice name for es_MX by Solomon Peachy
07:59:04 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:4066:3768:98f7:4656)
08:00
08:02:24rb-bluebotBuild Server message: Build round completed after 875 seconds.
08:02:26rb-bluebotBuild Server message: Revision 505bbcaff5 result: All green
08:09:57 Join dconrad [0] (~dconrad@152.117.104.232)
08:14:44 Quit dconrad (Ping timeout: 265 seconds)
08:33:52***Saving seen data "./dancer.seen"
08:34:53 Quit rnkn (Quit: Client closed)
08:37:58speachyuser890104: on the surface they seem much the same as what you already submitted. Don't see the harm..
08:38:37speachyhad to fix up a few things that broke, but now the spanish voices are being generated properly.
08:40:07speachyalso back-filled another month of the wiki's changelog page.
08:40:34 Quit kugel (Ping timeout: 248 seconds)
08:49:21rb-bluebotBuild Server message: New build round started. Revision 35a913473e, 345 builds, 9 clients.
08:49:21rb-bluebotlist.c small cleanup, add simplelist_setline() by William Wilgus
08:53:18_bilgus__With this simplelist should be applicable in more places, I've run into the issue prior, too much data to display statically in the provided buffer, by setting the line pointer directly to a buffer (or string literal) we can display more data without going dynamic
09:00
09:06:56rb-bluebotBuild Server message: Build round completed after 1056 seconds.
09:06:58rb-bluebotBuild Server message: Revision 35a913473e result: All green
09:08:28 Join kugel [0] (~kugel@77.20.106.58)
09:10:02_bilgus__ofc I immediately find a bug, FM Radio does a constant refresh and setline doesn't play nice in that case
09:16:32_bilgus__ah it uses the current text position to reset the buffer so i need to add a check to that
09:43:01 Quit kugel (Ping timeout: 248 seconds)
10:00
10:00:14 Join kugel_ [0] (~kugel@77.20.106.58)
10:11:32 Join dconrad [0] (~dconrad@152.117.104.232)
10:15:52 Quit dconrad (Ping timeout: 252 seconds)
10:27:09 Join martylake_ [0] (~martylake@82.66.174.242)
10:30:04 Quit martylake (Ping timeout: 265 seconds)
10:30:04 Nick martylake_ is now known as martylake (~martylake@82.66.174.242)
10:33:56***Saving seen data "./dancer.seen"
10:37:35 Quit kugel_ (Remote host closed the connection)
10:41:58_bilgus__i'm going to push a patch that fixes that but there is literally one place using it and only one line being saved with it so what I'm actually going to do is remove the option and make simplelist_set_line_count(n) instead simplelist_reset_lines(void)
10:57:19speachyas we drunkenly stumble towards perfection...eventually
11:00
11:08:50 Quit jacobk (Ping timeout: 248 seconds)
11:09:41 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
11:12:02_bilgus__jeez I wish that were my excuse :p
11:24:22_bilgus__I was also admiring the way they used the action callback to update the text and then I though my patch broke scrolling in them
11:24:45_bilgus__looking back at older versions it doesn't work there either
11:25:45_bilgus__guess thats a pretty big downside of hooking the redraw message to update the text
11:25:54 Quit martylake (Ping timeout: 248 seconds)
11:36:15 Quit _bilgus__ (Remote host closed the connection)
11:38:03 Join _bilgus__ [0] (~bilgus@2601:4c3:8100:a010:5d13:6233:2e27:ccf5)
12:00
12:17:43rb-bluebotBuild Server message: New build round started. Revision 00906647b4, 345 builds, 9 clients.
12:17:43rb-bluebotSimplelist remove simplelist_set_line_count(n) by William Wilgus
12:19:01_bilgus__turns out scrolling in the simplelist works fine in the action callback as long as you don't constantly feed ACTION_REDRAW in place of ACTION_NONE (which most of these callbacks seem to so)
12:19:20_bilgus__seem to do*
12:33:58***Saving seen data "./dancer.seen"
12:35:44rb-bluebotBuild Server message: Build round completed after 1082 seconds.
12:35:46rb-bluebotBuild Server message: Revision 00906647b4 result: All green
12:59:11speachyThis has teh potential to introduce random regressions though?
13:00
13:04:46_bilgus__you mean the removal of redraw? won't be a regression since it was added with the rewrite but it appears to work fine on device
13:05:54_bilgus__I think the onlt downside would be slightly slower update as to when scanning is done since it waits HZ/10 to redraw normally
13:05:56speachyyeah, that.
13:06:44speachynice to see an all-green board again
13:07:30speachy...I still haven't put rockbox on the DX50, and I snagged a Philips HDD1630 that I have yet to plug in.
13:08:26_bilgus__I really need to start looking at thrift stores, pawnshops, etc for devices we support
13:08:47speachythe replacement replacement ipod5g motherboard should be here on monday
13:13:53 Join dconrad [0] (~dconrad@152.117.104.232)
13:18:35 Quit dconrad (Ping timeout: 260 seconds)
13:39:09 Quit jacobk (Ping timeout: 276 seconds)
13:39:19 Join jacobk_ [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
13:41:02 Join davisr [0] (~davisr@fsf/emeritus/davisr)
13:45:38 Quit jacobk_ (Ping timeout: 248 seconds)
13:46:00 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
13:58:00 Join drew [0] (~drew@user/drew)
14:00
14:01:03 Join dconrad [0] (~dconrad@152.117.104.232)
14:05:48 Quit dconrad (Ping timeout: 276 seconds)
14:26:36 Quit jacobk (Ping timeout: 276 seconds)
14:27:00 Join jacobk [0] (~quassel@47-186-105-237.dlls.tx.frontiernet.net)
14:34:02***Saving seen data "./dancer.seen"
14:46:03 Join Natch [0] (~natch@c-92-34-7-158.bbcust.telenor.se)
15:00
15:01:40 Quit _bilgus__ (Remote host closed the connection)
15:23:37 Join dconrad [0] (~dconrad@152.117.104.232)
15:26:08 Join _bilgus [0] (~bilgus@2601:4c3:8100:a010:5d56:37ca:754a:7352)
15:28:00 Quit dconrad (Ping timeout: 252 seconds)
15:45:59 Join yang2 [0] (uid23779@id-23779.lymington.irccloud.com)
15:46:06 Nick yang2 is now known as yang4 (uid23779@id-23779.lymington.irccloud.com)
16:00
16:29:10_bilgus g#6054 appears to work in testing on device I'll try in the sim with asan and ubsan before I call it a success
16:29:13rb-bluebotGerrit review #6054 at https://gerrit.rockbox.org/r/c/rockbox/+/6054 : menu.c remove the check for valid menu_callback by William Wilgus
16:34:03***Saving seen data "./dancer.seen"
16:35:16_bilgusthinking about it for a bit huh the very part I'm concerned about would have had the potential to get uninitialized memory with the prior code, I guess that means its still going to be fine?
16:37:22 Quit jacobk (Ping timeout: 248 seconds)
16:43:52_bilgusgot a crash in the printcell function so still needs work (might be existing too) will check later
16:51:02 Join Everything [0] (~Everythin@46-133-186-175.mobile.vf-ua.net)
18:00
18:05:38 Quit yang4 (Quit: Connection closed for inactivity)
18:14:32 Join dconrad [0] (~dconrad@152.117.104.232)
18:19:26 Quit dconrad (Ping timeout: 272 seconds)
18:21:07 Quit edhelas_ (Ping timeout: 264 seconds)
18:27:54 Quit davisr (Quit: yeehaw)
18:34:05***Saving seen data "./dancer.seen"
19:00
19:28:44 Quit Everything (Quit: Lost terminal)
19:47:43_bilgusnope was an existing bug
19:51:44 Join massiveH [0] (~massiveH@2600:4040:a982:5400:19d6:787:3812:de9)
19:56:54rb-bluebotBuild Server message: New build round started. Revision e6f49e47e3, 345 builds, 9 clients.
19:56:54rb-bluebotmenu.c remove the check for valid menu_callback by William Wilgus
20:00
20:11:16rb-bluebotBuild Server message: Build round completed after 863 seconds.
20:11:18rb-bluebotBuild Server message: Revision e6f49e47e3 result: All green
20:11:25rb-bluebotBuild Server message: New build round started. Revision 1c7fddad5b, 345 builds, 9 clients.
20:11:26rb-bluebotAdd the remaining iPod Nano SoCs to config by Vencislav Atanasov
20:30:20rb-bluebotBuild Server message: Build round completed after 1135 seconds.
20:30:21rb-bluebotBuild Server message: Revision 1c7fddad5b result: All green
20:30:27rb-bluebotBuild Server message: New build round started. Revision 39f8101d60, 345 builds, 9 clients.
20:30:28rb-bluebotEnable UC870x "auto baud" and "fine tune" features based on the SoC capabilities by Vencislav Atanasov
20:34:06***Saving seen data "./dancer.seen"
20:47:21rb-bluebotBuild Server message: Build round completed after 1014 seconds.
20:47:23rb-bluebotBuild Server message: Revision 39f8101d60 result: All green
20:47:28rb-bluebotBuild Server message: New build round started. Revision fb134c9533, 345 builds, 9 clients.
20:47:29rb-bluebotRename UC870x to UC87xx by Vencislav Atanasov
21:00
21:01:30rb-bluebotBuild Server message: Build round completed after 842 seconds.
21:01:31rb-bluebotBuild Server message: Revision fb134c9533 result: All green
21:05:33 Quit amiconn (Ping timeout: 246 seconds)
21:05:35 Quit pixelma (Ping timeout: 252 seconds)
21:07:02 Join OriginCode [0] (~compl.exe@aosc/dev/origincode)
21:18:41 Join amiconn [0] (jens@p200300ea8711db00305e95fffec66ff3.dip0.t-ipconnect.de)
21:19:01 Join pixelma [0] (marianne@p200300ea8711db00305e95fffec66ff3.dip0.t-ipconnect.de)
21:34:44 Join dconrad [0] (~dconrad@152.117.104.232)
21:39:26 Quit dconrad (Ping timeout: 255 seconds)
22:00
22:34:09***Saving seen data "./dancer.seen"
23:00
23:09:45 Join dconrad [0] (~dconrad@152.117.104.232)
23:09:56 Quit dconrad (Client Quit)
23:19:39 Quit massiveH (Quit: Leaving)

Previous day | Next day