Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2024-11-24

00:00:53rb-bluebotBuild Server message: New build round started. Revision dcec6828a3, 345 builds, 9 clients.
00:00:54rb-bluebotstorage: Disk Cache buffer size may need to be larger than SECTOR_SIZE by Solomon Peachy
00:01:01speachyok, here goes.
00:01:40_bilgusso speaking of enums > 16-bits... https://github.com/Rockbox/rockbox/blob/master/lib/rbcodec/codecs/libwmavoice/avcodec.h#L245
00:02:21speachythis is going to (re-)boost the RAM usage of the 6G by ~220K
00:02:43speachyand the 5G by ~98K
00:04:38speachyzenxfi3, zenxfistyle, fuzeplus, and two sonys are also going to get boosted by that 98K.
00:04:51_bilgushttps://github.com/Rockbox/rockbox/blob/master/lib/rbcodec/codecs/libspc/spc_codec.h#L281
00:05:02_bilgusthose can all handle that bump
00:05:48speachythose (plus those two ipods) are the only ones that use that virtual/filesystem sector size > storage logical sector size.
00:05:59_bilguswonder if there is a way to just force all enums to int
00:06:15_bilgusgcc manual sucks
00:07:02speachyC23 allows for it in a standard manner, hah
00:08:40speachythere's a way to force them to be smaller, but not the opposite. It's platform ABI dependent apparently..
00:08:43_bilgussheesh we are bare c((
00:08:48_bilgusc99
00:09:14_bilgusyeah thats got to be the source of some of those codec bugs
00:09:19_bilgusabuse of enum
00:09:49speachy"On some targets, ‘-fshort-enums’ is the default; this is determined by the ABI"
00:11:03_bilguswell so we could ensure it doesn't work in the sim like that
00:11:33_bilgusthat might at least make them pop out of the woodwork
00:11:44speachyenums that aren't actually enums are ... bad.
00:11:45_bilgushate to see that first run
00:12:13_bilgusso far only codecs
00:12:27_bilgushaven't made it thru all of them yet
00:12:45 Quit rnkn (Quit: Client closed)
00:13:48rb-bluebotBuild Server message: Build round completed after 775 seconds.
00:13:49rb-bluebotBuild Server message: Revision dcec6828a3 result: All green
00:14:23speachyaaand it's as predicted. :)
00:14:41speachysorry to completly obliterate the bytes you're clawing back. :(
00:21:43_bilgusphew again they have plenty of ram
00:22:18_bilgusbetter to be right and fat than lean and wrong
00:22:20 Join akaWolf [0] (~akaWolf@akawolf.org)
00:23:07speachyyeah, if I'm right (and I'm pretty sure I am) this has been broken a _long_ time. ipod6g only worked accidentally, because of the 4K SECTOR_SIZE and the hackery in its ATA driver.
00:23:19speachy(actually that may hav ebeen put in ther eintentionally, due to this poblem?)
00:23:39_bilgusthe iPods have always been an issue too
00:24:03speachyI broke the 6g when I ripped out those hacks to do things the RightWay(tm)
00:24:19speachythe disk cache really could stand to be smarter, but eh.
00:24:49_bilgusI've been debating if we need a audio_state changed event, wonder if it would be more performant than pooling
00:24:52speachybut this could easily explain a lot of the historical wonkiness on the 5g.
00:24:58_bilguspolling**
00:25:33speachycaching 2K I/O into a 512B buffer. :(
00:27:43_bilgusmakes for a rather slow time
00:28:03speachymakes for a rather buffer trashy time
00:31:10speachyno.. I introduced this.
00:31:34speachywhen I added support for variable logical sector sizing.
00:31:51_bilgusI think I can just make the problematic enums defines instead
00:35:07***Saving seen data "./dancer.seen"
00:37:09_bilguswon't fix the underlying type issue though thats gonna take more thought
00:40:48speachyI need to revisit that last patch. I expect it to _work_ but it's actually not the right fix.
00:41:40speachy(Srictly speaking I think it is _correct_ but not necessarily optimal)
00:43:54speachyI changed the fileI/O code to use the FAT "sector size" rather than the device's notion of "sector size"
00:44:56speachywhen what it _should_ have been was changing it to alwas use the device's logical sector size (which could be smaller than the FAT's notion of sector sizes)
00:45:43speachyon the ipod6g the hard drive needs to do do I/O in terms of the physicla block size rather than the logical block size
00:45:46 Quit akaWolf (Ping timeout: 252 seconds)
00:46:11speachyso the current behavior is what we actually want there. bah
00:48:05speachyI disabled the variable logical size stuff until we had a need for it (which would bump the buffer sizes up)
00:48:30speachybut the file I/O code was still using the larger filesystem sector for operations
00:49:05speachy(rather than backing the operation size back down to the storage's logical sector size)
00:57:24speachynevermind, I did it right, and it didn't fix the issue.
00:57:45 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:d70:d11:8629:e9b5)
00:59:03rb-bluebotBuild Server message: New build round started. Revision 7ea64a315b, 345 builds, 9 clients.
00:59:03rb-bluebotRevert "storage: Disk Cache buffer size may need to be larger than SECTOR_SIZE" by Solomon Peachy
01:00
01:01:05 Quit rnkn (Client Quit)
01:02:24 Join akaWolf [0] (~akaWolf@akawolf.org)
01:12:13 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:d70:d11:8629:e9b5)
01:12:31rb-bluebotBuild Server message: Build round completed after 810 seconds.
01:12:33rb-bluebotBuild Server message: Revision 7ea64a315b result: All green
01:24:16 Quit akaWolf (Ping timeout: 252 seconds)
01:25:05rnknusing keyremap plugin, it seems that `BUTTON_MENU|BUTTON_REPEAT` does not work with `CONTEXT_SETTINGS`
01:25:15rnknhttps://gist.githubusercontent.com/rnkn/665b23def7c2c7ec04c6e0442601c261/raw/0ed3a5b5b0c9156df5954f7f17c1352b3ff0d285/ipod_keymap.txt
01:26:12 Join akaWolf [0] (~akaWolf@akawolf.org)
01:26:13rnknI guess I could have shrunk that url...
01:27:06_bilgusits probably just a different action you'd prob need to drop the repeat at least
01:28:12rnkn_bilgus ah but the single menu button press is mapped to go up one level
01:30:36rnkn(trying it anyway)
01:33:21rnknnegative, no effect
01:37:44 Join rnkn66 [0] (~rnkn@120.22.149.67)
01:38:22 Quit rnkn (Quit: Client closed)
01:38:58 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:f91c:cc33:762c:ffb6)
01:39:11 Quit rnkn66 (Client Quit)
01:39:31rnknsorry d/c
01:52:09 Quit rnkn (Quit: Client closed)
01:55:50 Join rnkn [0] (~rnkn@2001:8004:4441:7b53:4893:f4b2:4204:f226)
01:57:05 Quit rnkn (Client Quit)
01:57:50 Join rnkn [0] (~rnkn@starbeastie.blip.town)
02:00
02:04:09 Quit massiveH (Quit: Leaving)
02:06:21 Quit othello7 (Ping timeout: 252 seconds)
02:35:10***Saving seen data "./dancer.seen"
03:00
03:24:38user890104speachy: how do you set -Werror for the builds?
03:57:37 Quit mrkrisprolls (Remote host closed the connection)
03:59:12rnknaw no sort by albumartist_sort tag
04:00
04:04:27 Quit jacobk (Ping timeout: 276 seconds)
04:04:45 Join jacobk [0] (~quassel@47-186-65-73.dlls.tx.frontiernet.net)
04:09:37 Quit martylake (Ping timeout: 252 seconds)
04:35:12***Saving seen data "./dancer.seen"
04:37:02 Join lebellium [0] (~lebellium@2a01cb0405d07f00d33a0da62bfc2206.ipv6.abo.wanadoo.fr)
05:00
05:17:53 Join martylake [0] (~martylake@82.66.174.242)
05:28:35 Quit martylake (Ping timeout: 260 seconds)
06:00
06:28:54 Join ourannos [0] (~ourannos@2a04:cec0:f069:8526:0:c:ea14:3301)
06:28:57 Quit ourannos (Client Quit)
06:29:13 Join ouranos [0] (~ouranos@2a04:cec0:f069:8526:0:c:ea14:3301)
06:30:55ouranosmsg NickServ REGISTER winamax82 menelaas82@gmail.com
06:35:14***Saving seen data "./dancer.seen"
06:37:47 Quit ouranos (Ping timeout: 256 seconds)
06:46:36 Join ouranos [0] (uid678393@user/ouranos)
06:56:12 Quit ouranos ()
07:00
07:02:21Trzyzetoopsie daisy
07:17:05 Join guest91 [0] (~guest@2a04:cec0:f069:8526:0:c:ea14:3301)
07:17:33 Quit guest91 (Client Quit)
07:17:52 Join Aigo [0] (~Aigo@2a04:cec0:f069:8526:0:c:ea14:3301)
07:18:58 Quit Aigo (Changing host)
07:18:58 Join Aigo [0] (~Aigo@user/Aigo)
07:20:10 Join aigo_ [0] (uid678396@user/Aigo)
07:23:41 Quit Aigo (Ping timeout: 256 seconds)
07:23:41 Nick aigo_ is now known as aigo (uid678396@user/Aigo)
07:37:17speachyuser890104: Advanced/Error
07:37:52user890104speachy: thanks, i've figured it out for normal builds, but not for bootloader builds
07:42:55speachyhmm, will have to address that.
07:43:23speachyyou can always just add -Werror to GCCOPTS in the Makefile
08:00
08:25:21rb-bluebotBuild Server message: New build round started. Revision 200529532b, 345 builds, 9 clients.
08:25:21rb-bluebotconfigure: Allow bootloader to be specified under advanced options by Solomon Peachy
08:35:18***Saving seen data "./dancer.seen"
08:42:35rb-bluebotBuild Server message: Build round completed after 1034 seconds.
08:42:36rb-bluebotBuild Server message: Revision 200529532b result: All green
08:42:44rb-bluebotBuild Server message: New build round started. Revision bdf1690cb2, 345 builds, 9 clients.
08:42:45rb-bluebotbuild: Allow LTO to work globally, not just codecs/plugins by Solomon Peachy
08:48:12speachyin other news, the replacement replacement motherboard for my ipod5.5g is missing the power connector.
08:48:44speachywhich I only discovered at the very final assembly step.
08:50:20user890104is it a ZIF, or a ribbon cable socket like on ipod6g?
08:53:39speachythe latter
08:54:16user890104that should be possible to solder, if you remove the plastic bit first
08:54:18speachyI have a hot air gun but the last time I tried to swap out something like that I badly melted the connector without getting the solder hot enough to reflow
08:54:37Trzyzetipod 5 to last gen has almost the same motherboard, they are even interchangable, I had my 5.5g in an iPod 7 chassis
08:55:05Trzyzetand about the soldering, for ipod is the best to have a solder plate and use that plate to solder anything
08:55:31Trzyzetmy first attempt resulted in badly bent motherboard
08:55:35speachyyep, not set up for that. and my hands/eyesight really isn't up for that task anyway
08:57:10speachyso I have my original board with a broken hard drive zif connector, the first replacement which was a 5g (not 5.5g) board that didn't work with the original hard drive, and now this 5.5g board that is missing the power connector.
08:57:29rb-bluebotBuild Server message: Build round completed after 886 seconds.
08:57:31rb-bluebotBuild Server message: Revision bdf1690cb2 result: All green
08:57:37rb-bluebotBuild Server message: New build round started. Revision 0624e265ab, 345 builds, 9 clients.
08:57:37rb-bluebotbuild: Various LTO fixes by Solomon Peachy
08:57:38speachy(oh, the original board also has no audio output either)
08:59:21Trzyzetoof
09:00
09:00:10Trzyzetits time to ask some magician to fix at least one
09:01:25user890104speachy: I've confirmed that after applying G#6065 and G#6071, the binaries for ipodnano2g and ipod6g are identical
09:01:31rb-bluebotGerrit review #6065 at https://gerrit.rockbox.org/r/c/rockbox/+/6065 : Unify S5L87xx register definitions by Vencislav Atanasov
09:01:31rb-bluebotGerrit review #6071 at https://gerrit.rockbox.org/r/c/rockbox/+/6071 : Merge s5l8700.h and s5l8702.h into s5l87xx.h by Vencislav Atanasov
09:02:26user890104I've done an even detailed cleanup/optimisation of the registers, but the binaries differ, so i'm trying to bisect it
09:02:32speachyTrzyzet: alas, my contacts for such tihngs are years out of date.
09:03:58user890104so basically doing diff -r on the *.bin and then on the *.o files, to find the cause
09:04:17speachyat $dayjob-1 and #dayjob-3 there were folks I could bribe with some booze
09:05:49TrzyzetIf you are from US, I would try to speak with Lois Rossman, tell him about rockbox and I think the guy would help you for free (well, still some shipping costs but for more than one board it will spread out)
09:07:48user890104and as a bonus, he might make a video
09:12:39 Join Everything [0] (~Everythin@46.211.66.25)
09:14:06speachycome to think about it, I'm surprised that Rossman hasn't mentioned rockbox before, at least not that I can recall
09:15:14rb-bluebotBuild Server message: Build round completed after 1057 seconds.
09:15:16rb-bluebotBuild Server message: Revision 0624e265ab result: All green
09:15:42speachyuser890104: one approach that is probably far too much of a PITA to implement is to take the approach that ARM uses for their CMSIS header standard
09:16:34speachyie each peripheral is defined by a C struct, and only the base address has to change for different instances/devices.
09:20:59user890104well, in the most recent (unsubmitted) patch, there are only base addresses and offsets in the header file
09:21:20 Quit Trzyzet (Ping timeout: 260 seconds)
09:25:06user890104some s5l87xx drivers already accept a struct with base address and some basic config, e.g. UART
09:28:30 Join Trzyzet [0] (~Trzyzet@88.97.248.229)
09:29:37rb-bluebotBuild Server message: New build round started. Revision 9e2c85e076, 345 builds, 9 clients.
09:29:37rb-bluebotMerge s5l8700.h and s5l8702.h into s5l87xx.h by Vencislav Atanasov
09:30:52speachy_bilgus: keep in mind that -fshort-enums doesn't mean the enums are "short" ie 16-bit, it just means they can be smaller than "int" (or the native integer size)
09:31:27speachyit just allows smaller sizes if the range of represented values allows for it.
09:32:06speachyso if your enum has values that use up all 32-bits (eg those FOURCC definiions) then it has to be a 32-bit fundamental storage type under the hood.
09:33:09_bilgusbesides the codecs the only place I found enums > 0xFFFF were in core for mips (so should be ok)
09:33:11speachythe problem with "enum abuse" in this context is that if the code uses the enum field for values other than the ones explicitly enumerated
09:33:33_bilgus^that too, harder to find
09:33:47speachythough I _think_ we actually have a warning for that already turne don?
09:36:23speachy-Wconversion, apparently
09:38:27speachyI shudder to hink how much noise that will add
09:38:37speachy... a _LOT_ apparently. :D
09:44:41rb-bluebotBuild Server message: Build round completed after 906 seconds.
09:44:43rb-bluebotBuild Server message: Revision 9e2c85e076 result: All green
10:00
10:23:56rb-bluebotBuild Server message: New build round started. Revision 4ec34f6986, 345 builds, 8 clients.
10:23:56rb-bluebot[BugFix] Enums are only 2 bytes on some Devices by William Wilgus
10:24:33_bilgusI'm sure there is more but I think thats the worst of it
10:27:55_bilgus3 offenders were chip tune nes, C64, gb
10:30:25 Join martylake [0] (~martylake@82.66.174.242)
10:35:21***Saving seen data "./dancer.seen"
10:37:04_bilgusthe ones in codec.h seem to be fine they aren't used anywhere
10:55:26 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
11:00
11:01:49rb-bluebotBuild Server message: Build round completed after 2274 seconds.
11:01:50rb-bluebotBuild Server message: Revision 4ec34f6986 result: All green
11:05:40speachyHeh.. take out my beefy builder and we double our build times. :D
11:05:46speachyit's back up now though
11:10:08_bilgusIt appears to me that the size of the enum can change looking at file internal when I remove the big things sizeof goes to 2 down from 4
11:10:24speachyyeah, that's what I was saying
11:10:36_bilgusso really I think its not an issue (except in a few isolated cases)
11:10:54speachy-fshort-enums makes them smaller if the explicitrly enumerated values will fit in a smaller type
11:11:28_bilgusI guess its just not guaranteed that it will or wont
11:15:52speachyyep. i guess arm EABI uses -fshort-enums by default, but m68k and mips don't.
11:32:23 Quit Everything (Quit: leaving)
11:37:35_bilgusin that case i'm going to revert that, its more likely to cause an issue rather than solve one
11:38:34rb-bluebotBuild Server message: New build round started. Revision 1fddea5e8e, 345 builds, 9 clients.
11:38:34rb-bluebotRevert "[BugFix] Enums are only 2 bytes on some Devices" by William Wilgus
11:47:51speachyI suspect that if this was going to be an issue it owuld have barfed well before now
12:00
12:04:15rb-bluebotBuild Server message: Build round completed after 1542 seconds.
12:04:17rb-bluebotBuild Server message: Revision 1fddea5e8e result: All green
12:28:35 Quit othello7 (Quit: othello7)
12:35:23***Saving seen data "./dancer.seen"
12:40:34 Join Okpod [0] (~Okpod@213.219.160.172.adsl.dyn.edpnet.net)
12:42:29OkpodUsing 20241124 daily build on a ipod 6G (the one with 120gb flash limit . I am using a generic iflash) , I notice a lot of CRC errors/disk corruption/file read and write errors when Rockbox OS is running while syncing with freefilesync .
12:42:30OkpodTo get a stable sync I need to boot into Rockbox disk mode before starting the sync .
12:43:53Okpodwhen Rockbox OS is running and doing the sync it constantly goes back and forth between writing and reading . It spends as much reading if not more , than actual writing . in Rockbox disk mode , it sticks to simply writing the files which is much more stable and faster .
12:45:03OkpodIs this "to be expected" with the latest changes that have been made to the OS ?
13:00
13:33:36OkpodAlso , the average response time in windows during disk mode is much much lower compared to when Rockbox OS is running during a sync . 200ms vs 1500ms or so
14:00
14:35:25***No seen item changed, no save performed.
14:45:02user890104there have been some changes related to the ATA storage driver recently, so it's quite possible they could be the cause
14:45:33user890104the bootloader uses an older version of the disk code, so it's not affected
15:00
15:06:14user890104speachy: G#6072 produces byte-for-byte identical binary for both ipodnano2g and ipod6g (normal and bootloader builds)
15:06:17rb-bluebotGerrit review #6072 at https://gerrit.rockbox.org/r/c/rockbox/+/6072 : s5l87xx: Use pointer arithmetic in register address calculation by Vencislav Atanasov
15:24:47 Quit Okpod (Ping timeout: 256 seconds)
15:34:45 Quit jacobk (Ping timeout: 276 seconds)
15:35:17 Join jacobk [0] (~quassel@47-186-65-73.dlls.tx.frontiernet.net)
16:00
16:20:54 Join Everything [0] (~Everythin@94.153.10.212)
16:35:26***Saving seen data "./dancer.seen"
16:41:46 Nick rasher_ is now known as rasher (~rasher@diti.rasher.dk)
16:42:06 Quit rasher (Changing host)
16:42:06 Join rasher [0] (~rasher@user/rasher)
16:51:06speachyreally hoping to avoid rolling the dice on a used ipod6g to aid wth debugging.
16:54:39 Quit Everything (Ping timeout: 246 seconds)
16:56:49 Join Everything [0] (~Everythin@46-133-77-57.mobile.vf-ua.net)
17:00
17:07:46 Quit jacobk (Ping timeout: 248 seconds)
17:09:04 Join jacobk [0] (~quassel@47-186-65-73.dlls.tx.frontiernet.net)
17:23:05 Quit _bilgus (Quit: Leaving)
17:48:02 Join jjs0077018310196 [0] (~jjs007@host86-172-82-147.range86-172.btcentralplus.com)
18:00
18:00:48rb-bluebotBuild Server message: New build round started. Revision 18fdb41b2c, 345 builds, 9 clients.
18:00:48rb-bluebotplugins: simple viewer: prevent audio dropouts when scrolling by Christian Soffke
18:12:43 Quit lebellium (Quit: Leaving)
18:28:03rb-bluebotBuild Server message: Build round completed after 1635 seconds.
18:28:04rb-bluebotBuild Server message: Revision 18fdb41b2c result: All green
18:35:29***Saving seen data "./dancer.seen"
19:00
19:48:51 Join massiveH [0] (~massiveH@2600:4040:a982:5400:b4e1:c896:19df:b2f5)
19:48:58speachyso to really dig into this ipod6g I/O wonkiness, we need to add some instrumentation/logging to the file I/O code. now that we have a reproducible test case (ie load a non-default language off disk) that shrinks the scope to sometihng manageable.
19:52:30 Quit Everything (Quit: leaving)
19:52:34speachyclearly the failure mode is sometihng other than what I'm expecting, but it's not immediately clear _why_.
20:00
20:02:29 Quit jacobk (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
20:02:46rb-bluebotBuild Server message: New build round started. Revision 375a6bc9b1, 345 builds, 9 clients.
20:02:46rb-bluebots5l87xx: Use pointer arithmetic in register address calculation by Vencislav Atanasov
20:28:08rb-bluebotBuild Server message: Build round completed after 1522 seconds.
20:28:10rb-bluebotBuild Server message: Revision 375a6bc9b1 result: All green
20:34:38 Quit OriginCode (Ping timeout: 255 seconds)
20:35:32***Saving seen data "./dancer.seen"
21:00
21:21:19 Quit bpye (Quit: Ping timeout (120 seconds))
21:21:56 Join bpye [0] (~bpye@user/bpye)
21:34:23speachyw
22:00
22:35:03 Join OriginCode [0] (~compl.exe@aosc/dev/origincode)
22:35:25 Nick OriginCode is now known as COMPL_EXE (~compl.exe@aosc/dev/origincode)
22:35:30 Nick COMPL_EXE is now known as OriginCode (~compl.exe@aosc/dev/origincode)
22:35:34***Saving seen data "./dancer.seen"
23:00
23:10:16 Quit massiveH (Quit: Leaving)
23:26:18rb-bluebotBuild Server message: New build round started. Revision 87e55baaad, 345 builds, 9 clients.
23:26:19rb-bluebotata: Use a better default for SET_MULTIPLE_MODE by Solomon Peachy
23:40:35rb-bluebotBuild Server message: Build round completed after 858 seconds.
23:40:37rb-bluebotBuild Server message: Revision 87e55baaad result: All green

Previous day | Next day