00:03:42 | | Quit jn (Ping timeout: 265 seconds) |
00:03:51 | | Join jn [0] (~quassel@user/jn/x-3390946) |
00:16:02 | | Quit jn (Ping timeout: 248 seconds) |
00:16:30 | | Join jn [0] (~quassel@2a0a-a549-fa2a-0-20d-b9ff-fe49-15fc.ipv6dyn.netcologne.de) |
00:16:31 | | Quit jn (Changing host) |
00:16:31 | | Join jn [0] (~quassel@user/jn/x-3390946) |
00:56:32 | _bilgus | uh as far as I know I was just saying fixing up the casts on libmad current |
00:57:40 | _bilgus | any objections to removing the next track displaying the track filename before the next 1d3 is ready? |
00:58:24 | _bilgus | the flashing I was seeing is actually the track name getting displayed for a moment before it puts the id3 info up |
00:59:32 | | Quit chris_s (Quit: Client closed) |
01:00 |
01:01:02 | | Join chris_s [0] (~chris_s@140.248.36.54) |
01:09:38 | | Quit chris_s (Quit: Client closed) |
01:10:00 | _bilgus | g#6187 |
01:10:03 | rb-bluebot | Gerrit review #6187 at https://gerrit.rockbox.org/r/c/rockbox/+/6187 : WPS don't display next track till ID3 data is ready by William Wilgus |
01:13:47 | | Quit jn (Ping timeout: 265 seconds) |
01:14:07 | | Join jn [0] (~quassel@2a0a-a549-fbef-0-20d-b9ff-fe49-15fc.ipv6dyn.netcologne.de) |
01:14:08 | | Quit jn (Changing host) |
01:14:08 | | Join jn [0] (~quassel@user/jn/x-3390946) |
01:21:14 | | Join JanC_ [0] (~janc@user/janc) |
01:21:14 | | Quit JanC (Killed (zirconium.libera.chat (Nickname regained by services))) |
01:21:14 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
01:54:48 | *** | Saving seen data "./dancer.seen" |
02:00 |
02:17:06 | | Quit othello7 (Ping timeout: 265 seconds) |
02:17:57 | rb-bluebot | Build Server message: New build round started. Revision 5650007399, 345 builds, 9 clients. |
02:17:57 | rb-bluebot | libmad synth.c silence warnings try #2 by William Wilgus |
02:33:00 | rb-bluebot | Build Server message: Build round completed after 904 seconds. |
02:33:02 | rb-bluebot | Build Server message: Revision 5650007399 result: 0 errors 2032 warnings |
02:33:47 | | Join jn_ [0] (~quassel@2a0a-a549-fe5e-0-20d-b9ff-fe49-15fc.ipv6dyn.netcologne.de) |
02:33:48 | | Quit jn_ (Changing host) |
02:33:48 | | Join jn_ [0] (~quassel@user/jn/x-3390946) |
02:33:52 | | Quit jn (Ping timeout: 272 seconds) |
02:46:05 | | Quit npmania (Remote host closed the connection) |
02:49:32 | | Join JanC_ [0] (~janc@user/janc) |
02:49:32 | | Nick JanC is now known as Guest4670 (~janc@user/janc) |
02:49:32 | | Quit Guest4670 (Killed (tantalum.libera.chat (Nickname regained by services))) |
02:49:32 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
03:00 |
03:08:03 | | Join kugel_ [0] (~kugel@77.20.106.58) |
03:54:52 | *** | Saving seen data "./dancer.seen" |
04:00 |
04:04:19 | | Quit jacobk (Ping timeout: 260 seconds) |
04:04:55 | | Join jacobk [0] (~quassel@47-186-65-73.dlls.tx.frontiernet.net) |
05:00 |
05:31:44 | | Join sebagala [0] (~Burak@185.25.123.34) |
05:34:33 | | Quit Burak__ (Ping timeout: 244 seconds) |
05:36:36 | | Join JanC_ [0] (~janc@user/janc) |
05:36:36 | | Nick JanC is now known as Guest1329 (~janc@user/janc) |
05:36:36 | | Quit Guest1329 (Killed (tungsten.libera.chat (Nickname regained by services))) |
05:36:36 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
05:54:53 | *** | Saving seen data "./dancer.seen" |
07:00 |
07:26:24 | | Quit JanC (Ping timeout: 246 seconds) |
07:26:27 | | Join JanC_ [0] (~janc@user/janc) |
07:26:27 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
07:33:36 | speachy | _bilgus: so... looks like you introduced warnings on every non-sim build. |
07:36:09 | speachy | ...I confess I still don't understand what this was intended to accomplish. |
07:48:37 | | Nick jn_ is now known as jn (~quassel@user/jn/x-3390946) |
07:53:46 | speachy | sbsample and fe being refined as const is what's producing the warnings. whereas the D0ptr/D1ptr seems to be what actually matters. |
07:54:57 | *** | Saving seen data "./dancer.seen" |
08:00 |
08:57:34 | | Join JanC_ [0] (~janc@user/janc) |
08:57:34 | | Quit JanC (Killed (zirconium.libera.chat (Nickname regained by services))) |
08:57:34 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
08:59:23 | rb-bluebot | Build Server message: New build round started. Revision 95681c3959, 345 builds, 9 clients. |
08:59:23 | rb-bluebot | Revert "libmad synth.c silence warnings try #2" by Solomon Peachy |
09:00 |
09:00:50 | speachy | I could have backed out about 50% of that commit but I don't know if it would retintroduce the original issue. safer to just revert the whole thing for another, more targeted attempt. |
09:11:23 | rb-bluebot | Build Server message: Build round completed after 720 seconds. |
09:11:24 | rb-bluebot | Build Server message: Revision 95681c3959 result: All green |
09:11:32 | rb-bluebot | Build Server message: New build round started. Revision 29e909c25d, 345 builds, 9 clients. |
09:11:33 | rb-bluebot | SDL: Log the version detected by Solomon Peachy |
09:23:20 | | Join JanC_ [0] (~janc@user/janc) |
09:23:20 | | Quit JanC (Killed (mercury.libera.chat (Nickname regained by services))) |
09:23:20 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
09:23:33 | rb-bluebot | Build Server message: Build round completed after 722 seconds. |
09:23:35 | rb-bluebot | Build Server message: Revision 29e909c25d result: All green |
09:27:42 | | Join JanC_ [0] (~janc@user/janc) |
09:27:42 | | Nick JanC is now known as Guest9590 (~janc@user/janc) |
09:27:42 | | Quit Guest9590 (Killed (tantalum.libera.chat (Nickname regained by services))) |
09:27:42 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
09:29:55 | | Quit speachy (Quit: WeeChat 4.4.3) |
09:32:45 | | Join speachy [0] (~speachy@rockbox/developer/speachy) |
09:32:45 | Mode | "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) |
09:41:58 | user890104 | rbbclient@freemyipod:~$ sdl2-config −−version |
09:41:58 | user890104 | 2.0.8 |
09:42:14 | user890104 | speachy: is 2.0.8 too old to build the simulators? |
09:42:58 | speachy | it lacks a symbol we want but the work around is easy enough |
09:44:56 | user890104 | it's an Ubuntu 18.04.6 LTS, so that's the SDL2 version it was released with |
09:47:42 | speachy | It's old enough that support ceased over 1.5 years ago |
09:54:59 | *** | Saving seen data "./dancer.seen" |
09:59:51 | | Join JanC_ [0] (~janc@user/janc) |
09:59:51 | | Nick JanC is now known as Guest9046 (~janc@user/janc) |
09:59:51 | | Quit Guest9046 (Killed (copper.libera.chat (Nickname regained by services))) |
09:59:51 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
10:00 |
10:07:39 | _bilgus | looking through the code those are all const * so wtf does it have a differing type for the sim or is it just the newer compiler throwing a fit? |
10:08:44 | speachy | the warnings are nearly all "non-const ptr = const ptr" |
10:09:27 | speachy | there are at least three separate code paths in that file, one (or two) for accelerated arm, one for accel m68k, and one straight path |
10:09:41 | | Join JanC_ [0] (~janc@user/janc) |
10:09:41 | | Nick JanC is now known as Guest3297 (~janc@user/janc) |
10:09:41 | | Quit Guest3297 (Killed (calcium.libera.chat (Nickname regained by services))) |
10:09:41 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
10:10:00 | speachy | thing is I don't see any compiler warnings just building it (fairly bleeding edge too) but asan does shit a brick. |
10:10:44 | speachy | hmm, using the default -Os still or are you applying your -O1 patch? (otoh the codecs generally override that) |
10:27:48 | rb-bluebot | Build Server message: New build round started. Revision c19b50cdd8, 345 builds, 9 clients. |
10:27:48 | rb-bluebot | FS #13532: Updated Chinese translation ( 王吉) by Solomon Peachy |
10:28:47 | _bilgus | no i'm compiling it as it is @head ok I see the two macros that have a copy so thats the non sims warnings |
10:29:17 | _bilgus | but I'm not sure where the sim is losing it |
10:30:12 | speachy | ok, specifics −− compiler version, cpu arch (and no asan/ubsan?) |
10:31:04 | speachy | all of my recent work has been with gcc version 14.2.1 20240912 |
10:31:09 | _bilgus | have asan ubsan gcc version 13.2.0 (Ubuntu 13.2.0-23ubuntu4) |
10:31:55 | speachy | so it would appear that asan is the culprit |
10:32:49 | _bilgus | strangely what prompted me to add const is that when I put the file in godbolt I got those warnings from the latest clang |
10:33:25 | speachy | done a recent covertity round? |
10:33:46 | _bilgus | no I need to though |
10:34:04 | speachy | I dont' trust clang −− not that there's anything inherently wrong with it, but we have a _lot_ of GNU toolchain-isms lurking. |
10:34:31 | speachy | ...still need to figure out why ipod6g goes boom with GCC9.5 |
10:35:25 | _bilgus | pretty sure coverity doesn't like that file already |
10:36:05 | speachy | reading the comments in synth.c it seems that there are a lot of changes in there trading speed over accuracy |
10:36:27 | speachy | (or at least in the arm/m68k paths) |
10:38:00 | MarcAndersen | I' getting along. sims.pl is working after I changed sdl-config to sdl2-config so new sims should be up in a few hours. |
10:39:14 | MarcAndersen | Maybe we should have an option in sims.pl to decide if a voice should be built? Right now I hard coded it into the script. |
10:39:30 | rb-bluebot | Build Server message: Build round completed after 701 seconds. |
10:39:31 | rb-bluebot | Build Server message: Revision c19b50cdd8 result: All green |
10:39:54 | _bilgus | OH COVERITY JUST HAS TWO ISSUES https://scan3.scan.coverity.com/#/project-view/55211/14259?selectedIssue=353336 UNUSED VALUE SO ITS WRONG TOO i THINK |
10:40:05 | _bilgus | sorry caps |
10:40:15 | speachy | d'oh I forgot to commit the sims.pl fix as part of my last round. |
10:42:55 | speachy | _bilgus: I can't seem to log in to look at that? |
10:43:39 | MarcAndersen | speachy, Can you add an option if voice should be built? |
10:43:53 | speachy | the "Rockbox" project hasn't seen a new scan since June 2024 |
10:47:01 | speachy | MarcAndersen: Hmm... that's a bit more involved. |
10:48:13 | _bilgus | yeah I was pulling the existing issues |
10:49:33 | MarcAndersen | I just added `v\n\n` to the configure command and then make voice under make. |
10:49:55 | speachy | needs to have the language and voice specified too |
10:51:39 | MarcAndersen | I just let it choose the default, but you're right that if it should be in yours it could be nice, but for me it's fine. I just renamed sims.pl to sims1.pl and use that |
10:52:17 | MarcAndersen | The 2 \n is to choose the default at the prompt btw |
10:54:50 | MarcAndersen | $simstring = 'a\nw\ns\nv\n\n\n\n'; |
10:55:31 | MarcAndersen | I even think I have a \n too much in there |
10:57:26 | MarcAndersen | Oh maybe not. The first \n is to send the v through so it's right |
11:00 |
11:20:33 | rb-bluebot | Build Server message: New build round started. Revision e9b14b3986, 345 builds, 9 clients. |
11:20:34 | rb-bluebot | libmad synth.c silence warnings try #3 by William Wilgus |
11:21:10 | | Join JanC_ [0] (~janc@user/janc) |
11:21:10 | | Quit JanC (Killed (tantalum.libera.chat (Nickname regained by services))) |
11:21:10 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
11:21:41 | speachy | ok, that's just the D0/D1ptr changes. |
11:22:07 | _bilgus | ok just the trouble spot then its not like the const changes the code |
11:22:44 | _bilgus | I followed it into asm and it looks like its written to |
11:28:53 | | Join JanC_ [0] (~janc@user/janc) |
11:28:53 | | Nick JanC is now known as Guest7654 (~janc@user/janc) |
11:28:53 | | Quit Guest7654 (Killed (erbium.libera.chat (Nickname regained by services))) |
11:28:53 | | Nick JanC_ is now known as JanC (~janc@user/janc) |
11:31:19 | speachy | I just did an x3 sim build (not including your latest commit) and submitted that to coverity; let's see how that goes. |
11:32:25 | _bilgus | I think I have sent a few of the sims through it'll be interesting to see wha falls out |
11:32:45 | rb-bluebot | Build Server message: Build round completed after 733 seconds. |
11:32:47 | rb-bluebot | Build Server message: Revision e9b14b3986 result: All green |
11:34:22 | speachy | tiny monochrome screen means a bunch of plugins are excluded. |
11:37:59 | _bilgus | the thing that sucks is coverity doesn't really have a concept of differing builds you kinda have to keep running the same ones for the graph to make sense |
11:38:35 | _bilgus | otherwise your defect density swings wildly |
11:39:24 | speachy | +163 -452 (not sure how many of the latter are purely due to target differences) |
11:42:59 | speachy | Ugh I forgot how awful the UI is |
11:55:01 | *** | Saving seen data "./dancer.seen" |
11:57:27 | _bilgus | I don't see anything untoward looks like a bunch of false positives, might be a gem in there.. |
12:00 |
12:00:01 | speachy | Yeah a ton of clearly false positives |
12:01:18 | _bilgus | oh you check for null here therefore it could be NULL and thats an error!! |
12:02:09 | _bilgus | hey hey this number could be negative you have an int but thts an underflow! |
12:34:33 | rb-bluebot | Build Server message: New build round started. Revision ca5f12ae58, 345 builds, 9 clients. |
12:34:33 | rb-bluebot | S5L8702, S5L8720: Merge syscon_preinit() and miu_preinit() between SoC models by Vencislav Atanasov |
12:48:24 | rb-bluebot | Build Server message: Build round completed after 832 seconds. |
12:48:26 | rb-bluebot | Build Server message: Revision ca5f12ae58 result: All green |
13:00 |
13:21:08 | speachy | also like how it tells us to not use rand() because that's insecure. |
13:32:22 | | Join lebellium [0] (~lebellium@2a01cb0405d07f00d33a0da62bfc2206.ipv6.abo.wanadoo.fr) |
13:55:04 | *** | No seen item changed, no save performed. |
14:00 |
14:39:19 | user890104 | speachy: do you think it's a good idea to provide a generic get_serial_number()? There are implementations here and there, e.g. for the USB s/n string descriptor, but there is no common function |
14:40:13 | speachy | sure, can't hurt. and it'll be a stub ("12345678" ?) for everything else. |
14:42:15 | user890104 | yes, but the more devices we can find some unique piece of data, the better |
14:42:46 | user890104 | I think for the HDD-based players, the ATA serial number field is one of the fallbacks |
14:43:36 | user890104 | for the PP-ipods, it's at a fixed memory location, for the S5L ipods it's either in the NOR flash, or in the NAND flash (nano 4g+) |
14:43:37 | speachy | only on real HDDs. Or do the iflashes pass over the SD card serial number? (and is that reliably valid?) |
14:44:17 | user890104 | no idea, I only have an iFlash mSATA, and the drive is not around (used it in my old laptop) |
14:44:39 | speachy | I'm 0 for 3 on replacement ipod5g motherboards now |
14:44:47 | user890104 | I was struggling to get it to work, but that was ~8 years ago |
14:45:02 | user890104 | ouch |
14:46:33 | user890104 | I ran a fsck on my ipod6g's HDD yesterday, took forever and found about 30 bad sectors, so there's still some life in it |
14:47:19 | user890104 | with the latest git commit, I get 20 MB/s read and 2-5 MB/s write, not sure if the low write speed is because the drive, or because of Rockbox |
14:48:10 | user890104 | It starts writing at 5, then at some point slows down, could be the bad sectors but I expect it to remap them once it gives up on writing |
14:48:22 | speachy | random writes or bulk transfers? |
14:48:39 | user890104 | large files (FLAC) |
14:49:26 | user890104 | I transferred about 20 GB in hour and a couple minutes |
14:50:14 | user890104 | I can compare it with disk mode, and also update my second ipod6g and test there |
14:50:55 | user890104 | did you find yourself one? |
14:51:23 | speachy | I'd not expect meanigful differences with USB transfers (as they operate with 4K blocks) |
15:00 |
15:24:05 | | Quit JanC (Ping timeout: 260 seconds) |
15:28:43 | | Join JanC [0] (~janc@user/janc) |
15:46:16 | MarcAndersen | New simulators are up. |
15:55:05 | *** | Saving seen data "./dancer.seen" |
16:00 |
16:35:24 | | Quit JanC (Ping timeout: 245 seconds) |
16:37:26 | | Join JanC [0] (~janc@user/janc) |
16:41:29 | | Quit jacobk (Ping timeout: 260 seconds) |
17:00 |
17:01:19 | | Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net) |
17:50:52 | | Join Llamab6t [0] (~lamest@85-218-172-116.norlyscustomer.net) |
17:52:09 | | Quit Llamab6t (Client Quit) |
17:54:00 | | Join winsim-buildbot [0] (~lamest@85-218-172-116.norlyscustomer.net) |
17:55:09 | *** | Saving seen data "./dancer.seen" |
18:00 |
18:05:44 | winsim-buildbot | MarcAndersen hej |
18:06:01 | MarcAndersen | Sorry |
18:10:31 | | Quit lebellium (Quit: Leaving) |
19:00 |
19:04:37 | | Join Kasia [0] (~Kasia@89-73-189-9.dynamic.chello.pl) |
19:05:21 | Kasia | hi, i just found out that progressive jpg support got added, that is such a lifesaver, thank you all |
19:05:38 | | Quit Kasia (Client Quit) |
19:24:33 | | Quit spork (Ping timeout: 245 seconds) |
19:35:17 | _bilgus | g#6187 anyone not like this? |
19:35:20 | rb-bluebot | Gerrit review #6187 at https://gerrit.rockbox.org/r/c/rockbox/+/6187 : WPS don't display next track till ID3 data is ready by William Wilgus |
19:39:50 | | Join massiveH [0] (~massiveH@2600:4040:a982:5400:5c3c:b0ec:1861:8069) |
19:54:04 | | Join jacobk [0] (~quassel@47-186-65-73.dlls.tx.frontiernet.net) |
19:55:12 | *** | Saving seen data "./dancer.seen" |
20:00 |
20:08:06 | speachy | I think that's good |
20:27:47 | | Join Nyaa7 [0] (Nyaaori@cyberia.club/meow/nyaaori) |
20:27:50 | | Quit Nyaa (Quit: Ping timeout (120 seconds)) |
20:27:50 | | Nick Nyaa7 is now known as Nyaa (Nyaaori@cyberia.club/meow/nyaaori) |
20:45:55 | | Join zem [0] (~zem@97.115.157.49) |
20:47:04 | | Quit hactar|ant (Ping timeout: 260 seconds) |
21:00 |
21:06:16 | rb-bluebot | Build Server message: New build round started. Revision 4d632a1774, 345 builds, 9 clients. |
21:06:16 | rb-bluebot | S5L8702: Move IM3 sign/crypt functions from norboot to crypto by Vencislav Atanasov |
21:19:24 | rb-bluebot | Build Server message: Build round completed after 788 seconds. |
21:19:26 | rb-bluebot | Build Server message: Revision 4d632a1774 result: 5 errors 0 warnings |
21:31:25 | | Quit rb-bluebot (Ping timeout: 244 seconds) |
21:33:09 | | Quit bluebrother (Ping timeout: 260 seconds) |
21:34:39 | | Join bluebrother [0] (~dom@user/bluebrother) |
21:46:12 | | Join rb-bluebot [0] (~rb-bluebo@rockbox/bot/utility) |
21:55:15 | *** | Saving seen data "./dancer.seen" |
22:00 |
22:42:48 | | Quit massiveH (Quit: Leaving) |
23:00 |
23:04:48 | rb-bluebot | Build Server message: New build round started. Revision b752f3f964, 345 builds, 9 clients. |
23:04:48 | rb-bluebot | ipod6g: fix sim build by Solomon Peachy |
23:18:02 | rb-bluebot | Build Server message: Build round completed after 795 seconds. |
23:18:04 | rb-bluebot | Build Server message: Revision b752f3f964 result: All green |
23:18:13 | rb-bluebot | Build Server message: New build round started. Revision d6e57e6e8e, 345 builds, 9 clients. |
23:18:13 | rb-bluebot | Update simulator build release script by Solomon Peachy |
23:29:47 | rb-bluebot | Build Server message: Build round completed after 694 seconds. |
23:29:48 | rb-bluebot | Build Server message: Revision d6e57e6e8e result: All green |
23:52:19 | | Quit Tonux (Ping timeout: 264 seconds) |
23:55:16 | *** | Saving seen data "./dancer.seen" |