| 00:01:36 | | Quit advcomp2019 (Read error: Connection reset by peer) |
| 00:01:39 | | Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) |
| 01:00 |
| 01:15:41 | | Quit pixelma (Quit: .) |
| 01:15:41 | | Quit amiconn (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) |
| 01:16:37 | | Join pixelma [0] (marianne@p4fe7605c.dip0.t-ipconnect.de) |
| 01:16:37 | | Join amiconn [0] (jens@p4fe7605c.dip0.t-ipconnect.de) |
| 01:41:11 | *** | Saving seen data "./dancer.seen" |
| 02:00 |
| 02:09:52 | | Quit WebGuest45 (Quit: Client closed) |
| 03:00 |
| 03:31:57 | | Quit braewoods_ (Remote host closed the connection) |
| 03:32:10 | | Join braewoods_ [0] (~braewoods@user/braewoods) |
| 03:41:13 | *** | Saving seen data "./dancer.seen" |
| 03:42:45 | | Quit othello7 (Ping timeout: 260 seconds) |
| 03:49:05 | | Join PSparky|Ryzen7 [0] (~S|h|a|w|n@user/shawn/x-4432647) |
| 03:50:04 | | Join PSparky|AB350M [0] (~S|h|a|w|n@user/shawn/x-4432647) |
| 03:51:06 | | Quit PheralSparky (Ping timeout: 276 seconds) |
| 03:54:21 | | Quit PSparky|Ryzen7 (Ping timeout: 276 seconds) |
| 04:00 |
| 04:44:34 | | Quit PSparky|AB350M (Quit: Leaving) |
| 05:00 |
| 05:25:19 | | Join olspookishmagus [0] (~pookie@snf-137798.vm.okeanos.grnet.gr) |
| 05:41:14 | *** | Saving seen data "./dancer.seen" |
| 06:00 |
| 06:49:42 | | Quit JanC (Ping timeout: 268 seconds) |
| 07:00 |
| 07:00:52 | | Join JanC [0] (~janc@user/janc) |
| 07:22:43 | | Join Everything [0] (~Everythin@77.120.244.38) |
| 07:23:36 | Everything | Hi all. Latest firmware. fiio m3k. Sometimes the 'Rockbox!' strings appears instead of the title of next track. This irritates. How to disable this behaviour? |
| 07:41:18 | *** | Saving seen data "./dancer.seen" |
| 07:48:31 | | Join bahusoid [0] (~bahusoid@91.215.146.97) |
| 07:51:19 | bahusoid | It's showing content of .rockbox/playername.txt. Make it empty or completely remove it. Not sure why it was added in the first place. Not very useful indeed. |
| 07:51:38 | | Quit bahusoid (Client Quit) |
| 07:56:04 | | Join bahusoid [0] (~bahusoid@91.215.146.97) |
| 07:57:15 | bahusoid | Not sure actually - it may be recreated if missing. Just make it empty to be sure. |
| 07:57:20 | | Quit bahusoid (Client Quit) |
| 07:58:13 | Everything | Thanks for the hint |
| 08:00 |
| 08:54:55 | speachy | heh I argued against that being part of the default theme. |
| 08:55:19 | speachy | it's a demonstration of two features; the ability to pull text from a file and timers. |
| 08:56:04 | speachy | WebGuest45: There's nothing we can do about the window mask being smaller that (or misaligned) from the display |
| 08:56:58 | speachy | any "solution" from our end would be to effectively shrink the display size from 320x240 to (eg) 320x220. Or whatever is necessary. |
| 08:57:24 | speachy | that will have the unfortunate side effect of rendering all themes incompatible. |
| 09:00 |
| 09:07:08 | | Quit Everything (Quit: leaving) |
| 09:41:19 | *** | Saving seen data "./dancer.seen" |
| 09:59:59 | | Quit paulk (Ping timeout: 245 seconds) |
| 11:00 |
| 11:20:47 | | Join paulk [0] (~paulk@vpn-0-22.aquilenet.fr) |
| 11:20:47 | | Quit paulk (Changing host) |
| 11:20:47 | | Join paulk [0] (~paulk@about/aquilenet/user/paulk) |
| 11:41:21 | *** | Saving seen data "./dancer.seen" |
| 12:00 |
| 12:27:18 | user890104 | speachy: I consider purposely putting a demonstration of theme tags in the default theme, with no real user value as annoying |
| 12:27:53 | user890104 | a very small fraction of the rockbox users are theme developers who can appreciate this, for the rest it's "how do I turn this off" thing |
| 12:28:23 | user890104 | and deleting the file doesn't turn it off either, which is also confusing |
| 12:54:29 | | Join lebellium [0] (~lebellium@2a01cb0405d03a0028c69a080f59cd21.ipv6.abo.wanadoo.fr) |
| 13:00 |
| 13:11:17 | user890104 | submitted as G#6553 |
| 13:11:20 | rb-bluebot | Gerrit review #6553 at https://gerrit.rockbox.org/r/c/rockbox/+/6553 : Remove automatic creation of playername.txt on boot by Vencislav Atanasov |
| 13:12:48 | speachy | no, that's a good thing and doesn't cause issues. |
| 13:13:11 | speachy | the contention was adding that little splash to the default theme. |
| 13:17:20 | user890104 | the user can make use of the playername feature, if they wish. creating a file even if the user clearly doesn't want it there is what's concerning me |
| 13:20:03 | speachy | unless the theme uses it, it's irrelevant. |
| 13:20:20 | speachy | (there's a ton of other stuff under .rockbox that most users won't ever touch) |
| 13:24:03 | speachy | _bilgus: this was your baby, thoughts? |
| 13:30:46 | user890104 | I remember there was an idea to let the user put a custom name for a specific DAP (e.g. Mom's player) so if they have multiple devices connected, Rockbox utility shows the name so they can tell them apart |
| 13:31:15 | user890104 | it was a setting first, but then was changed to a txt file, which is fine |
| 13:33:46 | user890104 | but the default value doesn't bring any useful information, and having the file being created over and over automatically if it's deleted manually contradicts the purpose of being user customizable. disabling a feature is also a valid customization, and having to just delete the file contents and not the whole file is unintuitive |
| 13:34:36 | user890104 | if there was a splash at boot saying (Playername.txt not found - creating) at least the user won't be wondering why it came back after deleting |
| 13:35:17 | user890104 | but it sounds like a solution to a problem that doesn't need to exist in the first place |
| 13:36:08 | speachy | the problem of a per-device name thing is real enough. Independently asked for by multiple theme authors who were abusing existing settings to get it. |
| 13:37:02 | speachy | at this point there are themes that rely on this being always available, so it's not going away. |
| 13:37:31 | speachy | the annoyance comes from that once-every-5-minutes (I think) splash of the player name on the cabbiev2 theme. |
| 13:38:58 | user890104 | isn't the theme engine able to handle the file's absence, and return an empty string instead? I read about it being a conditional, which returns false if the file is not found |
| 13:40:12 | user890104 | from the tag's manual entry: Checking if a file exists can be done with %?ft(filename)<Found|NotFound> |
| 13:41:09 | speachy | for general use, sure −− but this was explicitly intended to be something that is guaranteed to be present. |
| 13:41:15 | speachy | (ie analogous to a setting) |
| 13:41:22 | | Join bahusoid [0] (~bahusoid@91.215.146.97) |
| 13:41:24 | *** | No seen item changed, no save performed. |
| 13:41:43 | user890104 | I see, looks like I missed this part |
| 13:42:03 | speachy | (referring to playername.txt specifically) |
| 13:42:20 | user890104 | how about changing the default contents to the player's model? e.g. "iPod Color" |
| 13:42:43 | | Quit bahusoid (Client Quit) |
| 13:43:41 | speachy | believe it or not, the marketing name of the device isn't actually known at build time. we have our own internal model string but that's not quite so nice, which is why "Rockbox" was chosen instead |
| 13:44:18 | speachy | (or rather "Rockbox!") |
| 13:44:23 | | Join bahusoid [0] (~bahusoid@91.215.146.97) |
| 13:44:46 | speachy | (fwiw I was outvoted on that exclamation and the inclusion in the cabbie theme) |
| 13:45:14 | bahusoid | I don't understand. If it's missing - it's treated by theme engine as empty value. So what do you mean by themes rely on this file? |
| 13:45:29 | user890104 | it is known, defined as MODEL_NAME by firmware/export/config/*.h |
| 13:46:06 | speachy | huh, so it is. |
| 13:46:22 | speachy | (I must be getting more senile in my middle age..) |
| 13:47:17 | speachy | what I mean is that playername.txt is documented as always being present, and to disable its use, the file should be empty rather than removed. |
| 13:47:31 | speachy | (so sayeth the manual) |
| 13:48:39 | speachy | much like deleting settings.cfg (or any individual line in it) doesn't blank a setting, it just means defaults are chosen instead. |
| 13:49:18 | speachy | and the default is documented to be "Rockbox!" |
| 13:49:32 | speachy | (which I agree is probably better changed to MODEL_NAME) |
| 13:49:36 | user890104 | as a rockbox user, I was surprised the first time it popped on the screen while waiting for the track to change, and wondering which is the next track. then I grepped into the source code for "Rockbox!", found only the manual entry since the file creation uses a translation, and then found the related commits |
| 13:50:48 | user890104 | speachy: using the default if the file does not exist is fine. creating the file with a default value if the file doesn't exist is not expected |
| 13:51:30 | user890104 | but this will introduce a dependency on a hardcoded path in the skin engine, which is worse |
| 13:51:55 | user890104 | e.g. if you %ft(playername.txt) and it's empty, return "Rockbox!" |
| 13:51:59 | speachy | unexpected how? I mean it's documented as being auto-created, and deleted config files have always been created at startup |
| 13:52:17 | speachy | that means special-casing %ft |
| 13:52:26 | user890104 | aren't the configs created on the first user-initiated change to them? |
| 13:52:48 | speachy | because all other uses of %ft are by definition custom |
| 13:53:26 | speachy | You're effectively arguing that the playername.txt convention should be moved into a setting |
| 13:54:46 | speachy | (another problem with auto-creating playername.txt (or even a "setting") with "Rockbox!" is that on first boot it won't be in the user's desired language |
| 13:54:56 | speachy | using MODEL_NAME is better IMO. |
| 13:55:50 | speachy | wrt config files, I'm not sure, but I can't think of a single device I've used (even in throaway contexts) that I use with all-default settings. |
| 13:56:26 | speachy | but I can promise you that after first boot there are more files in .rockbox than were unzipped from the installation archive. |
| 13:56:30 | user890104 | on the ipods the first thing I do is set maximum volume to 0db and not the default maximum (12db IIRC) |
| 13:59:03 | * | user890104 prepares an alternative patch |
| 13:59:27 | | Quit bahusoid (Quit: Client closed) |
| 14:00 |
| 14:42:10 | | Quit __builtin (Read error: Connection reset by peer) |
| 15:00 |
| 15:19:38 | user890104 | G#6555 for the default value, G#6556 for the theme |
| 15:19:45 | rb-bluebot | Gerrit review #6555 at https://gerrit.rockbox.org/r/c/rockbox/+/6555 : Change playername.txt default value by Vencislav Atanasov |
| 15:19:45 | rb-bluebot | Gerrit review #6556 at https://gerrit.rockbox.org/r/c/rockbox/+/6556 : Remove flashing text with the player name from the Next track label in WPS by Vencislav Atanasov |
| 15:29:44 | speachy | thank you |
| 15:29:55 | * | speachy pokes _bilgus |
| 15:30:17 | speachy | I am personally in favor of these. |
| 15:41:25 | *** | Saving seen data "./dancer.seen" |
| 16:00 |
| 16:12:30 | | Join amachronic [0] (~amachroni@user/amachronic) |
| 16:55:19 | _bilgus | as you wish? |
| 17:00 |
| 17:11:14 | | Quit amachronic (Ping timeout: 248 seconds) |
| 17:13:13 | | Join amachronic [0] (~amachroni@user/amachronic) |
| 17:18:08 | edhelas_ | user890104 why ? |
| 17:37:22 | | Quit lebellium (Quit: Leaving) |
| 17:41:28 | *** | Saving seen data "./dancer.seen" |
| 18:00 |
| 18:01:15 | | Quit paulk (Ping timeout: 268 seconds) |
| 18:13:32 | | Nick thanosengine is now known as eden (~eden@user/thanosengine) |
| 18:14:12 | | Nick eden is now known as thanosengine (~eden@user/thanosengine) |
| 18:29:32 | | Nick thanosengine is now known as eden (~eden@user/thanosengine) |
| 18:30:29 | user890104 | edhelas_: why what? |
| 18:38:20 | | Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net) |
| 19:00 |
| 19:02:41 | | Quit amachronic (Quit: amachronic) |
| 19:08:07 | | Join paulk [0] (~paulk@2a02-8428-1d63-2401-0081-87ff-fed5-e402.rev.sfr.net) |
| 19:08:07 | | Quit paulk (Changing host) |
| 19:08:07 | | Join paulk [0] (~paulk@about/aquilenet/user/paulk) |
| 19:41:31 | *** | Saving seen data "./dancer.seen" |
| 19:58:25 | | Join massiveH [0] (~massiveH@108.50.181.86) |
| 20:00 |
| 20:04:06 | | Join PheralSparky [0] (~S|h|a|w|n@user/shawn/x-4432647) |
| 21:00 |
| 21:00:59 | | Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net) |
| 21:41:34 | *** | No seen item changed, no save performed. |
| 22:00 |
| 22:21:35 | | Quit Moriar (Quit: Leaving.) |
| 23:00 |
| 23:41:36 | *** | Saving seen data "./dancer.seen" |
| 23:44:25 | | Quit massiveH (Quit: Leaving) |
icon identifies that the person is a core developer (has commit access).