Previous day | Jump to hour: 01 02 03 04 05 06 07 08 09 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | Next day

Seconds: Show Hide | Joins: Show Hide | View raw
Font: Serif Sans-Serif Monospace | Size: Small Medium Large

Click in the nick column to highlight everything a person has said.
The Logo icon identifies that the person is a core developer (has commit access).

#rockbox log for 2025-06-03

01:00
01:32:18_bilguschris_s g#6585
01:32:22rb-bluebotGerrit review #6585 at https://gerrit.rockbox.org/r/c/rockbox/+/6585 : [Bugfix] make theme menu reset browse context by William Wilgus
01:33:27_bilgusI noticed lua is failing in some scripts with splash did we remove that?
01:47:00***No seen item changed, no save performed.
02:00
02:14:41 Quit othello7 (Ping timeout: 252 seconds)
03:00
03:47:01***Saving seen data "./dancer.seen"
05:00
05:47:04***No seen item changed, no save performed.
06:00
06:27:30 Join chris_s [0] (~chris_s@2a09:bac3:28d6:246e::3a1:1a)
06:29:33chris_s_bilgus: ah great :) tree_init needs the INIT_ATTR removed
06:51:32 Quit chris_s (Quit: Client closed)
07:00
07:10:36speachy_bilgus: when you get a chance, could you have a look at the lua portion of g#6229?
07:10:39rb-bluebotGerrit review #6229 at https://gerrit.rockbox.org/r/c/rockbox/+/6229 : internals: Support characters beyond the first unicode plane (WIP) by Solomon Peachy
07:14:19 Quit baltazar (Quit: Lost terminal)
07:47:06***Saving seen data "./dancer.seen"
09:00
09:47:08***No seen item changed, no save performed.
09:57:56_bilguschris_s odd wonder why its init_attr there is no savings from it
10:00
10:06:38 Quit Bobathan- (Quit: ZNC 1.8.2+deb2+b1 - https://znc.in)
10:11:34 Join Bobathan_ [0] (~admin@syn-065-029-248-157.res.spectrum.com)
10:12:54_bilgusspeachy, not sure where to start with that, looks like it should just work?
10:13:44speachythe question is what lua uses for internal string representation; changing the type it interfaces with externally probably isn't sufficient?
10:14:00speachy(widening from uint16 to uint32 basically)
10:14:38speachyI still need to put that current patch through tests on native targets; last time I tried (a few weeks ago) it didnt' even boot. : D
10:15:12speachybut it's apparently stable on simulator builds with both 16-bit and 32-bit char sizes
10:15:46speachyother stuff that definitely needs kicking hard is the fat (and win32sim) code that switches to utf16 instead of ucs2
10:21:40_bilguslua is unicode tolerant but unaware otherwise, its currently looking for a byte marker in that very code but I'm unsure of the cast once we get into the kbd input function
10:23:26_bilgusmmm LUAL_BUFFERSIZE otoh I think we'd need to adjust based on the new cast?
10:25:21_bilgusluas buffer is char sized so I guess itd be something like LUAL_BUFFERSIZE / sizeof(ucschar_t)
10:28:13_bilgushmmm I'll have to look at this later, once it returns the string what do we do with it, I guess the underlying functions are still rockbox but the lua string functions now need to be aware right?
10:29:36_bilgusas in any calls into rb string functions should be covered by this work you are doing but what of the lua text functions, Haven't a clue.
10:40:57_bilgusIdk short of some conversion I see this breaking lots of text matching things and byte counting / conversion things this is probably going to be ugly
10:42:22speachyif internally lua uses utf8 (or otherwise a series of bytes) it's probably fine, but if it stores stuff interally as wchars that's when things get messy
10:43:25speachymy intent is to land that patch with uschar_t set to 16-bit (ie should be no runtime difference other than UCS2->UTF16 in the fat&win32 code.
10:44:10 Quit SammysHP (Quit: *wuff*)
10:44:30 Join SammysHP [0] (~SammysHP@faol.sammyshp.de)
10:45:01speachybut then enable 32-bit for my daily builds for a while. it's a prerequisite for the utf8 normalization work.
10:48:20_bilguslua uses counted strings but I think once you try and do text matching is when it will fail
10:50:14_bilguslike I said its tolerant just unaware so I think it'll generally work but there is a lot of assumptions implicitly or otherwise in there about the size of those chars
11:00
11:11:18 Quit npmania (Ping timeout: 272 seconds)
11:12:37 Quit TorC (Ping timeout: 276 seconds)
11:12:41 Join npmania [0] (~npmania@210.123.73.190)
11:13:12 Quit eden_ (Ping timeout: 272 seconds)
11:13:53_bilguschris_s rather than screw around with moving the init stuff I just cleared the current browse context, shouldn't be an issue since we directly supply our own *browse
11:14:41 Join thanosen1 [0] (~eden@user/thanosengine)
11:16:37 Quit vup (Ping timeout: 252 seconds)
11:16:52 Join vup [0] (~~~~@46.101.193.235)
11:17:38 Quit thanosengine (Ping timeout: 272 seconds)
11:18:16 Quit Xeha (Ping timeout: 272 seconds)
11:19:23 Join thanosengine [0] (~eden@user/thanosengine)
11:20:09 Join TorC [0] (~Tor@fsf/member/TorC)
11:21:53 Join Xeha [0] (~Xeha@user/Xeha)
11:41:18 Quit Mir (Ping timeout: 276 seconds)
11:43:47 Join mirppc [0] (~mirppc@openSUSE/member/mir-ppc)
11:47:12***Saving seen data "./dancer.seen"
11:58:30 Join baltazar [0] (~baltazar@user/baltazar)
12:00
12:03:14 Quit mirppc (Ping timeout: 272 seconds)
12:05:52 Join mirppc [0] (~mirppc@openSUSE/member/mir-ppc)
12:15:16 Quit mirppc (Ping timeout: 272 seconds)
12:26:24 Join mirppc [0] (~mirppc@openSUSE/member/mir-ppc)
12:30:37speachyc
12:33:00 Quit mirppc (Ping timeout: 272 seconds)
12:55:48 Join lebellium [0] (~lebellium@2a01cb0405d03a0078601d026a5245b1.ipv6.abo.wanadoo.fr)
13:00
13:43:57 Join mirppc [0] (~mirppc@openSUSE/member/mir-ppc)
13:47:15***Saving seen data "./dancer.seen"
14:00
14:58:23 Quit akaWolf (Quit: Lost terminal)
15:00
15:43:48 Join ac_laptop [0] (~ac_laptop@2a0c:e303:0:7300:e29d:31ff:fe2d:a258)
15:47:18***Saving seen data "./dancer.seen"
16:00
16:17:16 Quit ac_laptop (Read error: Connection reset by peer)
16:17:38 Join ac_laptop [0] (~ac_laptop@2a0c:e303:0:7300:e29d:31ff:fe2d:a258)
16:22:47 Quit ac_laptop (Ping timeout: 252 seconds)
16:48:42 Join PheralSparky [0] (~S|h|a|w|n@user/shawn/x-4432647)
16:50:23 Join ac_laptop [0] (~ac_laptop@2a0c:e303:0:7300:e29d:31ff:fe2d:a258)
17:00
17:10:56 Join Moriar [0] (~moriar@107-200-193-159.lightspeed.stlsmo.sbcglobal.net)
17:23:39 Quit ac_laptop (Ping timeout: 252 seconds)
17:32:08 Quit lebellium (Quit: Leaving)
17:36:52 Join ac_laptop [0] (~ac_laptop@2a0c:e303:0:7300:56ee:75ff:fe00:97ac)
17:42:37 Join ac_laptop2 [0] (~ac_laptop@2a0c:e303:0:7300:56ee:75ff:fe00:97ac)
17:43:01 Quit ac_laptop (Read error: Connection reset by peer)
17:47:21***Saving seen data "./dancer.seen"
18:00
18:34:38 Quit ac_laptop2 (Ping timeout: 272 seconds)
19:00
19:47:24***Saving seen data "./dancer.seen"
19:53:44 Join massiveH [0] (~massiveH@108.50.181.86)
20:00
20:58:52 Join othello7 [0] (~Thunderbi@pool-100-36-176-164.washdc.fios.verizon.net)
21:00
21:46:25 Quit Moriar (Quit: Leaving.)
21:47:28***Saving seen data "./dancer.seen"
22:00
22:57:15 Quit thanosen1 (Quit: WeeChat 4.6.3)
23:00
23:33:05 Quit massiveH (Quit: Leaving)
23:45:51 Join chris_s [0] (~chris_s@2a09:bac3:2d14:1282::1d8:193)
23:47:07chris_s_bilgus (logs): thanks! seems sensible
23:47:29***Saving seen data "./dancer.seen"

Previous day | Next day