--- Log for 31.05.118 Server: hitchcock.freenode.net Channel: #rockbox --- Nick: logbot Version: Dancer V4.16 Started: 23 days and 9 hours ago 00.17.59 Quit prg318 (Quit: ZNC 1.7.0 - https://znc.in) 00.19.17 Join prg318 [0] (~prg@deadcodersociety/prg318) 00.23.23 Quit prg318 (Client Quit) 00.24.26 Join prg318 [0] (~prg@deadcodersociety/prg318) 00.24.33 Quit sanchaez (Ping timeout: 240 seconds) 00.26.45 Join sanchaez [0] (~sanchaez@reactos/developer/sanchaez) 00.33.06 Quit pamaury (Ping timeout: 244 seconds) 00.53.10 Quit ender` (Quit: It's amazing how the the human mind does not process the the fact I used the the word "the" twice each time.) 01.06.56 Quit gevaerts (Ping timeout: 264 seconds) 01.06.56 Quit evilnick_ (Ping timeout: 264 seconds) 01.15.30 Join noobineer [0] (~noobineer@2601:401:8000:bc5f:74a2:c9b6:afd2:d45) 01.28.56 *** Saving seen data "./dancer.seen" 01.43.51 Quit pR0Ps (Read error: Connection reset by peer) 01.44.46 Join pR0Ps [0] (~pR0Ps@45.72.240.102) 01.48.46 Quit this_is_a_nick (Remote host closed the connection) 01.57.58 Quit MrZeus (Ping timeout: 256 seconds) 02.24.30 Quit jhMikeS (Ping timeout: 260 seconds) 02.30.19 Join jhMikeS [0] (~jethead71@24.192.177.173) 02.34.31 Quit jhMikeS (Ping timeout: 244 seconds) 02.45.39 Join this_is_a_nick [0] (~amofiuhr_@ip217-132-50-179.ct.co.cr) 02.45.45 Join mmint [0] (~mmint@unaffiliated/mmint) 02.52.15 Quit prof_wolfff (Ping timeout: 245 seconds) 03.04.49 Quit noobineer (Ping timeout: 240 seconds) 03.07.31 Join prof_wolfff [0] (~castor@95.211.89.180) 03.12.14 Quit prof_wolfff (Ping timeout: 244 seconds) 03.18.12 Join evilnick_ [0] (~evilnick@d54C073C1.access.telenet.be) 03.19.18 Join gevaerts [0] (~fg@rockbox/developer/gevaerts) 03.27.42 Join prof_wolfff [0] (~castor@85.203.15.42) 03.29.00 *** Saving seen data "./dancer.seen" 03.39.42 Join noobineer [0] (~noobineer@c-68-55-184-193.hsd1.mi.comcast.net) 04.28.58 Quit noobineer (Ping timeout: 256 seconds) 04.36.11 Quit mc2739 (Ping timeout: 276 seconds) 04.41.45 Join mc2739 [0] (~mc2739@rockbox/developer/mc2739) 05.29.01 *** Saving seen data "./dancer.seen" 06.06.50 Quit [7] (Ping timeout: 240 seconds) 06.14.24 Quit dys (Ping timeout: 245 seconds) 06.17.18 Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) 06.22.31 Quit TheSeven (Ping timeout: 260 seconds) 06.23.46 Join TheSeven [0] (~quassel@rockbox/developer/TheSeven) 06.57.09 Nick pookie is now known as olspookishmagus (~pookie@snf-137798.vm.okeanos.grnet.gr) 06.58.39 Join dys [0] (~dys@2a01:598:8983:a2f8:226:5eff:fee9:68d2) 07.29.03 *** Saving seen data "./dancer.seen" 08.14.59 Join ender` [0] (krneki@foo.eternallybored.org) 08.21.37 Quit dys (Ping timeout: 256 seconds) 09.06.27 Join ernestask [0] (~ernestask@78-56-62-157.static.zebra.lt) 09.29.06 *** Saving seen data "./dancer.seen" 11.06.04 Join ulmutul [0] (~ulmutul@rockbox/developer/ulmutul) 11.29.07 *** No seen item changed, no save performed. 11.31.54 Join xorly [0] (~xorly@houf-ntb.feld.cvut.cz) 11.38.54 Join petur [0] (~petur@91.183.48.77) 11.38.54 Quit petur (Changing host) 11.38.54 Join petur [0] (~petur@rockbox/developer/petur) 11.44.12 Join pamaury [0] (~pamaury@rockbox/developer/pamaury) 12.51.01 Join jhMikeS [0] (~jethead71@24.192.177.173) 13.14.54 Quit Moarc (Quit: i znowu NADMUCHAŁ BALONA) 13.18.34 Join Moarc [0] (~chujko@a105.net128.okay.pl) 13.29.11 *** Saving seen data "./dancer.seen" 13.29.21 Join massiveH [0] (~massiveH@ool-18e4e27c.dyn.optonline.net) 13.37.12 # _Bilgus: I'm not sure I like your last patch (https://git.rockbox.org/?p=rockbox.git;a=commit;h=37a20df and https://git.rockbox.org/?p=rockbox.git;a=commit;h=0565f67). See our coding guideline, line 26 (https://git.rockbox.org/?p=rockbox.git;a=blob;f=docs/CONTRIBUTING) 13.38.09 # You may also want to read this discussion concerning typedefs: https://www.rockbox.org/mail/archive/rockbox-dev-archive-2013-11/0005.shtml 13.45.58 # <_Bilgus> @ulmutul It doesn't really matter to me either way I wanted to convey it as an opaque type + is only limited to that file but I can switch it back if you prefer 13.55.28 # I don't think hiding the struct is very useful in this case. But you may want to hear a second opinion before reverting :) 13.59.39 # <_Bilgus> No I take it back I need it to be typedefd http://gerrit.rockbox.org/r/#/c/1847/6/apps/plugins/lua/rocklib.c@78 14.01.09 # <_Bilgus> I'd call this is safer than a void pointer although the iter struct doesn't need typedef'd 14.08.05 Quit Strife1989 (Ping timeout: 260 seconds) 14.11.20 Join Strife89 [0] (~quassel@adsl-98-80-191-50.mcn.bellsouth.net) 14.11.27 # You could use "struct rocklua_image *img;" inside the iter struct. 14.12.07 # <_Bilgus> Nm at first glance I was thinking I couldn't pass it as a pointer to the struct but after I actually tried it it works as expected 14.12.50 # <_Bilgus> I'll just revert it, I'd rather it just work than worrying about the style, thanks for the heads up 14.15.33 # Build Server message: 3New build round started. Revision 4508ee9, 273 builds, 13 clients. 14.21.24 Join amayer [0] (~amayer@107-1-97-172-ip-static.hfc.comcastbusiness.net) 14.29.36 # Build Server message: 3Build round completed after 845 seconds. 14.29.37 # Build Server message: 3Revision 4508ee9 result: 0 errors 114 warnings 14.31.43 # Build Server message: 3New build round started. Revision 641e033, 273 builds, 13 clients. 14.47.49 # Build Server message: 3Build round completed after 966 seconds. 14.47.50 # Build Server message: 3Revision 641e033 result: All green 14.48.27 Quit massiveH (Quit: Leaving) 14.54.56 Quit prof_wolfff (Ping timeout: 248 seconds) 15.01.35 Join JdGordon [0] (~jonno@rockbox/developer/JdGordon) 15.10.36 Join prof_wolfff [0] (~castor@82.102.26.204) 15.29.13 *** Saving seen data "./dancer.seen" 16.56.13 Quit aevin (Remote host closed the connection) 16.59.48 Quit this_is_a_nick (Ping timeout: 276 seconds) 17.01.24 Quit deevious (Quit: deevious) 17.04.11 Quit ernestask (Quit: ernestask) 17.15.15 Quit TheSeven (Ping timeout: 260 seconds) 17.15.27 Join [7] [0] (~quassel@rockbox/developer/TheSeven) 17.24.45 Quit petur (Quit: Connection reset by beer) 17.25.20 Quit ulmutul (Quit: Leaving) 17.29.16 *** Saving seen data "./dancer.seen" 17.29.23 Join this_is_a_nick [0] (~amofiuhr_@ip217-132-50-179.ct.co.cr) 17.35.05 Quit xorly (Ping timeout: 244 seconds) 18.08.19 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:bd00:b02b:b276:a402) 18.24.17 Quit amayer (Quit: Leaving) 18.26.17 Join amayer [0] (~amayer@107-1-97-172-ip-static.hfc.comcastbusiness.net) 18.29.10 Join MrZeus [0] (~MrZeus@2a02:c7f:7066:fb00:dd18:163a:a3f7:1c95) 18.55.40 Quit jhMikeS () 19.01.22 Quit ZincAlloy (Ping timeout: 256 seconds) 19.13.08 Join Strife1989 [0] (~quassel@adsl-98-80-187-129.mcn.bellsouth.net) 19.13.16 Quit Jinx (Ping timeout: 260 seconds) 19.15.56 Quit Strife89 (Ping timeout: 240 seconds) 19.19.13 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:bd00:b02b:b276:a402) 19.25.06 Join Strife89 [0] (~quassel@adsl-98-67-57-229.mcn.bellsouth.net) 19.25.58 Join Jinx [0] (Dojo@unaffiliated/jinx) 19.27.03 Quit Strife1989 (Ping timeout: 240 seconds) 19.29.17 *** Saving seen data "./dancer.seen" 19.36.00 Quit ZincAlloy (Ping timeout: 245 seconds) 19.41.20 Quit pamaury (Ping timeout: 248 seconds) 19.49.45 Join alucryd [0] (~quassel@archlinux/developer/alucryd) 19.50.51 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:bd00:b02b:b276:a402) 20.32.21 Quit this_is_a_nick (Ping timeout: 276 seconds) 20.37.03 Quit saratoga (Ping timeout: 260 seconds) 20.46.00 Join this_is_a_nick [0] (~amofiuhr_@201.196.87.164) 20.53.19 Quit jonathant (Ping timeout: 240 seconds) 20.55.39 Join Strife1989 [0] (~quassel@adsl-98-80-190-249.mcn.bellsouth.net) 20.56.31 Join jonathant [0] (~quassel@c-73-144-157-250.hsd1.mi.comcast.net) 20.56.33 Quit Strife89 (Ping timeout: 240 seconds) 21.23.11 Join krabador [0] (~krabador@unaffiliated/krabador) 21.29.18 *** Saving seen data "./dancer.seen" 22.05.03 Join lebellium [0] (~hexchat@89-93-177-206.hfc.dyn.abo.bbox.fr) 22.30.21 Quit amayer (Quit: Leaving) 22.40.45 Quit ZincAlloy (Ping timeout: 260 seconds) 22.53.06 Join dhugas [0] (5f3f7336@gateway/web/freenode/ip.95.63.115.54) 22.53.42 Quit dhugas (Client Quit) 22.55.11 Join ZincAlloy [0] (~Adium@2a02:8108:8b80:1700:bd00:b02b:b276:a402) 23.18.25 Quit lebellium (Quit: Leaving) 23.20.18 Quit ender` (Quit: If Java had true garbage collection, most programs would delete themselves upon execution. — Robert Sewell) 23.22.11 Quit Acou_Bass (Quit: byeeeeeeeeeeeeeee) 23.23.03 Join Acou_Bass [0] (~Acou_Bass@cpc97736-bolt17-2-0-cust152.10-3.cable.virginm.net) 23.29.20 *** Saving seen data "./dancer.seen"