--- Log for 03.12.118 Server: orwell.freenode.net Channel: #rockbox --- Nick: logbot Version: Dancer V4.16 Started: 5 days and 14 hours ago 00.04.27 Quit pixelma (Quit: .) 00.04.28 Quit amiconn (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.) 00.04.41 Join pixelma [0] (marianne@rockbox/staff/pixelma) 00.04.41 Join amiconn [0] (jens@rockbox/developer/amiconn) 00.53.35 Join dandels [0] (~dandels@unaffiliated/dandels) 01.08.17 *** Saving seen data "./dancer.seen" 01.13.22 Quit michaelni (Ping timeout: 250 seconds) 01.26.31 Join michaelni [0] (~michael@213-47-41-20.cable.dynamic.surfer.at) 01.55.34 Quit dandels (Ping timeout: 244 seconds) 02.10.15 Quit Boltermor (Quit: Leaving) 02.12.30 Join foolsh_ [0] (~quassel@c-73-110-87-188.hsd1.mi.comcast.net) 02.15.46 Quit foolsh (Ping timeout: 250 seconds) 02.23.32 Quit krabador (Remote host closed the connection) 02.52.29 Quit ChristW (Ping timeout: 272 seconds) 03.05.06 Join ChristW [0] (~christ@179.43.189.218) 03.08.19 *** Saving seen data "./dancer.seen" 04.13.14 Quit Jinx (Ping timeout: 250 seconds) 04.17.52 Quit foolsh_ (Remote host closed the connection) 04.19.06 Join foolsh [0] (~quassel@c-73-110-87-188.hsd1.mi.comcast.net) 04.24.38 Join Jinx [0] (Dojo@unaffiliated/jinx) 04.54.40 Join reductum [0] (~weechat@cpe-104-32-77-28.socal.res.rr.com) 05.08.21 *** Saving seen data "./dancer.seen" 05.20.18 Quit this_is_a_nick (Remote host closed the connection) 05.21.12 Join this_is_a_nick [0] (~amofiuhr_@ip32-132-50-179.ct.co.cr) 05.47.17 Quit reductum (Quit: WeeChat 2.3) 06.52.09 Join Senji [0] (~Senji@87.118.138.79) 06.56.40 Join xCatx [0] (c5ede83c@gateway/web/freenode/ip.197.237.232.60) 07.08.23 *** Saving seen data "./dancer.seen" 07.12.35 Quit xCatx (Quit: Page closed) 07.34.00 Join reductum [0] (~weechat@cpe-104-32-77-28.socal.res.rr.com) 07.42.10 Join ZincAlloy [0] (~Adium@2a02:8108:9440:dfc:457f:ab42:fcfb:3549) 07.42.50 Quit ZincAlloy (Client Quit) 08.14.08 Quit dys (Ping timeout: 246 seconds) 08.58.02 Join petur [0] (~petur@80.169.83.226) 08.58.02 Quit petur (Changing host) 08.58.02 Join petur [0] (~petur@rockbox/developer/petur) 09.03.17 Quit TheSphinX^ (Quit: ZNC - http://znc.in) 09.04.41 Join TheSphinX^ [0] (~briehl@srv001.nosupamu.de) 09.08.25 *** Saving seen data "./dancer.seen" 10.41.56 Join xorly [0] (~xorly@ip-86-49-24-93.net.upcbroadband.cz) 10.45.40 Quit ChristW (Ping timeout: 246 seconds) 10.52.32 Join dandels [0] (~dandels@unaffiliated/dandels) 11.00.40 Join ChristW [0] (~christ@179.43.166.123) 11.08.29 *** Saving seen data "./dancer.seen" 11.20.00 Join vmx [0] (~vmx@2a02:810d:300:1ce8:4685:ff:fe9b:6630) 11.24.57 Quit dandels (Ping timeout: 244 seconds) 11.56.41 Quit reductum (Quit: WeeChat 2.3) 11.58.59 Join ulmutul [0] (~ulmutul@rockbox/developer/ulmutul) 12.00.59 # foolsh: I've found the culprit. I'll push a fix when I find some time. 12.03.01 Join dandels [0] (~dandels@unaffiliated/dandels) 12.27.39 Quit dandels (Ping timeout: 246 seconds) 13.00.47 Quit ulmutul (Quit: Leaving) 13.06.38 Join krabador [0] (~krabador@unaffiliated/krabador) 13.06.56 Join pamaury [0] (~pamaury@rockbox/developer/pamaury) 13.07.14 Join pamaury_ [0] (~pamaury@rockbox/developer/pamaury) 13.08.31 *** Saving seen data "./dancer.seen" 13.16.41 Quit pamaury (Ping timeout: 268 seconds) 13.17.06 Join pamaury [0] (~pamaury@rockbox/developer/pamaury) 13.17.28 Join pamaury__ [0] (~pamaury@rockbox/developer/pamaury) 13.17.35 Quit pamaury_ (Ping timeout: 272 seconds) 13.26.12 Quit namedpipe (Ping timeout: 250 seconds) 13.28.30 Join namedpipe [0] (~namedpipe@2002:c3b5:f6dc::1) 13.58.47 Quit pamaury (Read error: Connection reset by peer) 13.58.55 Join pamaury_ [0] (~pamaury@rockbox/developer/pamaury) 13.59.10 Quit pamaury__ (Read error: Connection reset by peer) 14.00.54 Join pamaury [0] (~pamaury@rockbox/developer/pamaury) 14.26.00 Join dandels [0] (~dandels@unaffiliated/dandels) 14.49.42 Part pixelma ("-") 14.49.58 Join pixelma [0] (marianne@rockbox/staff/pixelma) 14.59.12 Quit xorly (Ping timeout: 246 seconds) 15.00.26 Quit dandels (Ping timeout: 240 seconds) 15.00.47 Join dandels [0] (~dandels@unaffiliated/dandels) 15.02.30 Quit dandels (Client Quit) 15.03.46 Quit jhMikeS (Ping timeout: 240 seconds) 15.08.33 *** Saving seen data "./dancer.seen" 15.08.48 Quit krabador (Remote host closed the connection) 15.09.56 Join massiveH [0] (~massiveH@ool-18e4e27c.dyn.optonline.net) 15.10.18 Join jhMikeS [0] (~jethead71@d192-24-173-177.try.wideopenwest.com) 15.14.37 Quit jhMikeS (Ping timeout: 245 seconds) 15.59.33 Quit ChristW (Ping timeout: 250 seconds) 16.08.50 Quit this_is_a_nick (Remote host closed the connection) 16.15.06 Join ChristW [0] (~christ@179.43.189.218) 16.39.21 Join xorly [0] (~xorly@ip-86-49-24-93.net.upcbroadband.cz) 16.46.25 Quit massiveH (Quit: Leaving) 17.00.02 Quit petur (Quit: Connection reset by beer) 17.08.36 *** Saving seen data "./dancer.seen" 18.08.10 Join speachy [0] (a2116e25@gateway/web/freenode/ip.162.17.110.37) 18.10.41 Join ZincAlloy [0] (~Adium@2a02:8108:9440:dfc:457f:ab42:fcfb:3549) 18.38.03 Quit ChristW (Ping timeout: 268 seconds) 18.53.31 Join ChristW [0] (~christ@179.43.166.125) 19.06.16 Quit pamaury_ (Ping timeout: 245 seconds) 19.06.25 Quit pamaury (Ping timeout: 268 seconds) 19.08.37 *** Saving seen data "./dancer.seen" 19.10.41 # wodz (logs) Have you verified if the volume up keys work on the rocker? I saw your keymap patch and noted that the other person that submitted a patch in gerrit [http://gerrit.rockbox.org/r/#/c/1900/5/apps/keymaps/keymap-agptekrocker.c@102] had to switch to using BUTTON_VOLUP instead of BUTTON_VOL_UP 19.14.02 # I also don't see BUTTON_VOL_UP defined here: https://github.com/Rockbox/rockbox/blob/d64ff86fb6be22875cfae054f8a878dbd8b1472b/firmware/target/hosted/agptek/button-target.h 19.26.04 # rocker seems to work with the latest commit, at least in the WPS. 19.30.16 Join lebellium [0] (~lebellium@89-92-253-36.hfc.dyn.abo.bbox.fr) 19.47.58 Join otyugh [0] (~oty___@gateway/tor-sasl/otyugh) 19.54.11 Join this_is_a_nick [0] (~amofiuhr_@201.206.191.79) 19.57.23 Join dys [0] (~dys@tmo-107-88.customers.d1-online.com) 19.57.58 Join krabador [0] (~krabador@unaffiliated/krabador) 19.59.54 Quit otyugh (Ping timeout: 256 seconds) 20.05.00 Join thomasjfox [0] (~thomasjfo@rockbox/developer/thomasjfox) 20.09.32 Join petur [0] (~petur@rockbox/developer/petur) 20.10.35 # speach it'd be the volume control within a menu I believe 20.10.43 # speachy * 20.17.32 # vol up/dn don't work in the menus, from what I can tell. 20.18.38 # for instance if from the WPS you go to the Context Menu you should be able to change the volume while the menu is up 20.19.38 # If not I'd say BUTTON_VOL_UP/DN is indeed undefined 20.22.00 # nope, not in the normal or context menus. 20.28.09 Join otyugh [0] (~oty___@gateway/tor-sasl/otyugh) 20.29.50 # Hey there. Great project. I was wondering on a "accessibilité standpoint", what would be the cheapest hardware available and still sold that can carry rockbox ? I'm mainly looking at a way to read mp3/ogg without selling a kidney. 20.31.10 # for sure the AGPtek ROCKER if we are talking about buying it new 20.31.29 # yeah, the rocker is probably the best bet right now. 20.31.36 # even versus used in some cases 20.32.03 # (*MOST) 20.32.32 # I should really install rockbox on my rocker 20.32.51 # I thought I'd try the native UI for a bit. 20.32.56 # except for lacking bluetooth, rockbox is far, far nicer than the Agptek firmware.. 20.33.18 # no bluetooth is fine, just the install process looked a bit involved 20.33.36 # is it installable from "official" images yet? 20.35.20 # nope, the bootloader is still special 20.35.30 # no you'd still need to compile a bootloader or use a supplied one 20.35.37 # right. 20.39.13 # Thanks for the answers. I must say I was more looking for the "ipodnano" kind of design, I must have a weird taste ^^' 20.39.16 # anyone care to comment on #1961? 20.40.24 # s/nano/shuffle, my bad. 20.40.54 # I have a small pile of accessibility patches but they all start on top of that. 20.47.14 # the only thing I'd question is taking a LANG_ID back from depreciated I ASSUME it'd work but haven't enough insight to say 20.47.50 Quit otyugh (Remote host closed the connection) 20.48.50 # well, the alternative seems to be creating a new LANG_ID, so.. 20.51.02 # wait, I misread that -- the patch deprecates one LANG_ID and creates two new ones. 20.57.14 # oh sorry I meant depreciating it but it seems to be ok reading the notes at the top 20.57.19 # http://gerrit.rockbox.org/r/#/c/1961/1/apps/settings_list.c@1235 20.57.51 # ^what are the implications here of adding the new enum I'd look very closely 20.58.25 # the menu is going to need to conform to the enum values 0-5 21.00.20 # that enum ordering is a bit wonky 21.03.06 # agreed but what i'm getting at is bookmark_autobookmark() in bookmark.c is dependent on the ordering as well 21.04.25 # you have two functions(+?) that depend on that enum one is 0-4 the 0-5 but that won't work if they each expect a different item at #3 21.04.57 # one or the other need to translate between the ordering 21.05.56 # or just make the two items share the same number ( I think thats ok in enums) 21.06.01 Quit JanC (Remote host closed the connection) 21.06.02 Join reductum [0] (~weechat@cpe-104-32-77-28.socal.res.rr.com) 21.06.16 # assuming they are unique to each function 21.06.23 Join JanC [0] (~janc@lugwv/member/JanC) 21.08.41 *** Saving seen data "./dancer.seen" 21.09.28 # either I'm missing something or autobookmark doesn't care about those other values or their order 21.10.46 Quit ChristW (Ping timeout: 246 seconds) 21.10.59 # but yeah, the number will probably shift. 21.11.01 # They don't look to be mapped @1235 in settings_list 21.12.14 # does choice_setting require values to be sequential? 21.12.20 # no doubt about it that the number will shift but CHOICE_SETTING(0, autocreatebookmark ... 5 means the range is 0-5 and therefore they no longer correspond 21.12.59 # wait, I get what you're saying. 21.13.12 Quit michaelni (Quit: Leaving) 21.13.40 Join michaelni [0] (~michael@213-47-41-20.cable.dynamic.surfer.at) 21.13.42 # choice setting should be sequential but let me find the definition to be sure 21.13.44 # so, moral of story, two sorta related things are sharing subsets of the same enum. 21.13.52 # yes 21.13.58 # and they shouldn't. 21.14.05 # strictly speaking anyway 21.18.43 # the definitions are at the top of settings_list.c I think TABLE_SETTING would allow you arbitrary numbering 21.19.30 # but the better bet is probably just to play with the enum to get them jiving 21.20.25 # assuming nothing else depends on both being unique (read -> in the the same function) elsewhere 21.20.46 # I don't think so 21.23.30 # then assuming I have the numbering right (ha) BOOKMARK_ASK = 3, BOOKMARK_ONE_PER_TRACK = 3, should do it 21.24.43 Join ChristW [0] (~christ@179.43.166.126) 21.25.26 # new version pushed 21.26.24 # I'm using the same ordering in settings_list.c 21.26.40 # with each element explicit. 21.28.09 # looks funky 21.28.17 # could reorder them? 21.28.56 # the definitions, I mean 21.32.48 # gotta scoot for a couple hours. FWIW I've using the original version of the patch on my rocker, no issues. 21.33.14 # I might be wrong you should look very closely at the two functions 21.33.42 # explicit numbering is definitely a good idea either way 21.34.46 # at this point the main thing I'd change is splitting the enum into two, one for each setting. But with every value explicitly set, I don't see how there's any _new_ problem created. 21.39.52 # huh, the bookmark code doesn't seem to care about the BOOKMARK_ASK setting 21.40.09 # otherwise the functions appear sane. 21.40.43 # nothing seems to care about BOOKMARK_ASK. 22.11.58 Join 77FAA7K7O [0] (~pamaury@rockbox/developer/pamaury) 22.11.58 Join 7YUAAED95 [0] (~pamaury@rockbox/developer/pamaury) 22.44.03 Quit reductum (Quit: WeeChat 2.3) 22.57.55 Quit thomasjfox (Quit: Konversation terminated!) 23.08.43 *** Saving seen data "./dancer.seen" 23.21.26 Quit krabador (Remote host closed the connection) 23.21.59 Join krabador [0] (~krabador@unaffiliated/krabador) 23.24.16 # speachy, if that is the case and for doubly sure the case maybe it should be removed I would look for code faux pas like magic numbers or even offsets from another enum just to be sure 23.29.38 Join jhMikeS [0] (~jethead71@d192-24-173-177.try.wideopenwest.com) 23.37.16 Quit ZincAlloy (Quit: Leaving.) 23.46.23 Quit this_is_a_nick (Remote host closed the connection) 23.56.50 Quit lebellium (Quit: Leaving)