--- Log for 03.11.121 Server: sodium.libera.chat Channel: #rockbox --- Nick: rb-logbot Version: Dancer V4.16 Started: 1 day and 23 hours ago 01.10.35 # <_bilgus> depends on how fast you refresh and how much area you are still drawing to a buffer 01.11.02 # <_bilgus> like if you can store some stuff and not redraw it then yes faster 01.12.10 # <_bilgus> the display device copies the main framebuffer or one of several for double buffering 01.55.06 *** No seen item changed, no save performed. 03.55.08 *** No seen item changed, no save performed. 04.33.23 Quit S|h|a|w|n (Quit: Leaving) 05.55.09 *** Saving seen data "./dancer.seen" 06.07.50 Quit unmanbearpig (Ping timeout: 260 seconds) 06.09.54 Join unmanbearpig [0] (~unmanbear@user/unmanbearpig) 06.37.49 Quit jschwart (Read error: Connection reset by peer) 06.42.16 Join jschwart [0] (~quassel@2001:985:2c6e:0:b00b:32ff:fe28:5567) 07.55.13 *** Saving seen data "./dancer.seen" 08.57.47 Join massiveH [0] (~massiveH@ool-18e4ebfe.dyn.optonline.net) 09.55.15 *** No seen item changed, no save performed. 10.18.19 Nick mendel_munkis is now known as munkis (~mendel_mu@ool-ae2cb218.dyn.optonline.net) 10.22.20 Quit massiveH (Quit: Leaving) 11.37.41 Join salty-horse [0] (~salty-hor@user/salty-horse) 11.39.40 # can I get some eyeballs on this bug? https://www.rockbox.org/tracker/task/13305 -- I don't think playback should change from "paused" to "resumed" when removing headphones 11.40.29 # I also want to file a feature request to allow headphone button input even when the device is locked. Does it make sense to anyone but me? 11.55.18 *** Saving seen data "./dancer.seen" 12.37.17 Join bilgus_ph [0] (~bilgus_ph@172.58.190.229) 12.39.22 # Salty_horse, I think there is an auto resume setting for that but it probably doesn't check if there was anything to resume if it even has scope to.. 12.39.33 # salty-horse: I don't have one in front of me, but what is the state of the setting settings->playback settings->pause on headphone unplug? 12.40.17 # As far as the buttons it can be added to selective backlight and softlock assuming events come through the normal action system 12.41.32 # Id have to look later when I have source in front of me 12.42.03 # Sounds about right p 12.43.56 # hah I as looking for that commit, forgot you're the one who wrote it. 12.46.36 # munkis, sorry, confused by the UI. When I go to the "pause on headphones unplug" setting, the current highlight is on "off" - does that mean it's off, or does the item selector always default to the top item? 12.47.19 # it should default to current item. 12.47.38 # so it's "off", oddly. Because when I unplug the headphones it does pause (if I'm not paused ATM) 12.48.05 # strange, what happens if you change the setting? 12.48.32 # what happens if you turn it on? 12.48.46 # (I mean, maybe the logic is inverted accidentally...) 12.48.48 # Try enabling it might be backwards or it is skipping the setting 12.49.49 # sec. there are two non-off options: "pause" and "pause and resume". I think it behaves like "pause and resume" atm. Will test "pause" 12.50.55 # "pause" behaves as expected! So it's probably just a confusion between "off" and "off and resume" 12.51.10 # Did you upgrade this install? 12.51.24 # can you test "pause and resume" just to be sure? 12.51.50 # what does "upgrade" mean? I always compile and unzip the files into the device 12.51.51 # munkis, sec 12.51.52 # It might be a wonky settings file.. 12.52.07 # bilgus_ph: yes, they do 12.52.19 # That would be an upgrade if you left the settings file.. 12.52.29 # bilgus_ph: I mean yes, the remote events come through the input/button driver 12.53.15 # Yeah I can filter them in the selective bl and then 12.54.08 # well turning off crossfade during a crossfade sounds weird. 12.54.17 # when selecting "pause and resume", then if it's playing and I unplug, it pauses. But if it's paused and I unplug, it resumes then immediately pauses again 12.55.00 # so "pause and resume" and "pause" both behave like pause and "off" behaves like pause and resume. 12.55.45 # I will try setting it to off explicitly. haven't yet. 12.55.55 # but the "resume then immediately pause" thing is weird 12.56.19 # yes it is. 12.56.25 # Can you also try renaming your current .rockbox folder and copy a fresh install 12.56.55 # and rename fixed.conf if it exists. 12.56.59 # Just to rule out a bad settings file.. 12.57.23 # IIRC thats in / not /.rockbox 12.57.52 # I'll have a look this evening wouldn't be the first time I got math wrong 12.57.54 # looks like "off" acts like "pause and resume" 12.58.08 # should I look at my settings file? 12.58.15 # bilgus_ph, I can try that later 12.58.55 # Probably just flipped the settings maybe or we broke it with another commit I have been messing in the menus which would cover settings as well 12.59.51 # Just rename your current .rockbox and copy a clean one to it then you can always switch back if it acts the same 12.59.53 # I'm having two other issues with xduoo: The bootloader sometimes says "cannot boot rockbox" and I have to restart. happens 3 startups a day or so 13.00.29 # No clue on that one bad sd card? 13.00.29 # can someone take a look at g#3938 apps/playback.c#2399 and tell me if there are any obvious settings I missed? 13.00.32 # 3Gerrit review #3938 at https://gerrit.rockbox.org/r/c/rockbox/+/3938 : 3Add single playback mode by Moshe Piekarski 13.01.20 # speachy, I disagree with your xduoo binding of the "back" button to be context menu in the OSD, since the same context menu is reached by "long play" in the file view. I think it should be consistent. 13.01.43 # ok, on my x3ii with whatever binary I last put on it seems to work as expected with hp insert/removal 13.01.50 # I can this eve munkis 13.02.06 # but.. heh, removing the hp causes it to pause and skip to the next track. which is.. odd. 13.02.16 # (missing break in a switch?) 13.02.45 # salty-horse: x3 or x3ii? 13.03.11 # speachy, sorry, x3ii 13.03.39 # grabbing the latest nightly now 13.03.39 # speachy, I also noticed the skipping. my guess is it thinks it's a double click from the headphones button? 13.04.23 # one feature I wish rockbox had was "go back to where I was before I accidentally track-skipped or track-reset". But I'm not sure how it should operate. 13.04.26 # hmm, might be a good idea to filter the remote control stuff out when the hp isn't plugged in. 13.06.26 # salty-horse: yeah, I think the skip is from a false read from the "remote" when things are unplugged 13.07.21 # that probably also explains your resume and immediately pause behaviour 13.07.38 # right! 13.07.46 # thanks bilgus 13.07.51 # ...and exactly, was about to suggest that 13.13.03 # I updated my bug suggesting it's a misread headphones button signal 13.13.21 # I have a workaround, I think. 13.13.35 # speachy, have you experienced my "could not load rockbox" bootloader issue? 13.13.48 # the slowest part of testing this is unzipping the new .zip 13.13.57 # salty-horse: nope 13.14.52 Quit bilgus_ph (Quit: Connection closed) 13.15.17 # any idea how I could diagnose it? 13.15.57 # ok, that's fixed. 13.16.22 # I don't always get a successful playback resume but at least there are no more false remote triggerss 13.17.01 # yay 13.17.30 # please close my bug. I don't think I have permissions. https://www.rockbox.org/tracker/task/13305 13.18.05 # Build Server message: 3New build round started. Revision 5e663f0420, 303 builds, 11 clients. 13.18.13 # salty-horse: this build will include that fix. 13.18.29 # or if you don't want to wait 10 minutes I can upload my binary somewhere 13.19.48 Quit JanC (Remote host closed the connection) 13.20.00 # I compile my own :D 13.20.00 Join JanC [0] (~janc@user/janc) 13.23.33 # as far as the buttonmap is concerned, it's mostly a cut-n-paste from the original X3. Suggestions (or better yet, patches!) welcome. 13.25.19 # I'm not familiar with the X3, but I think both devices should use the same button in "open context menu", whether in file view or OSD. I think "long play" makes the most sense. That's how it is in the file view, and how it was in was on sansa e200 in both the file view and OSD (and in xduoo before your commit that changed it :) ) 13.25.47 # I will try to tweak it for my tastes and submit a patch 13.26.59 # my daily driver is a (really beat up) original X3. 13.27.28 # which remainds me, I have to port the USB driver still. Grr. 13.28.37 # Build Server message: 3Build round completed after 633 seconds. 13.28.40 # Build Server message: 3Revision 5e663f0420 result: All green 13.28.56 # Build Server message: 3New build round started. Revision 22c2e0a7c2, 303 builds, 10 clients. 13.29.45 Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:dac:6577:f9d6:270b) 13.30.37 # speachy, this commit is the one I don't understand, changing WPS_CONTEXT from PLAY to HOME. It should be the same as ACTION_STD_CONTEXT. 914114fd21a126be36435e7b0bc3a9f2685149c6 13.32.53 # I think them being out of sync was an oversight. IIRC I was trying to emulate the OF behaivor 13.33.36 # I'm switching ACTION_WPS_STOP and ACTION_WPS_CONTEXT back to their old values. Will test tomorrow 13.33.56 # keep in mind that WPS_STOP is longplay already 13.34.27 # I had to pull WPS_STOP from the long power press in order to emulate softlock 13.35.45 # longpress on play/pause == stop is what a lot of other targets do 13.36.00 # that's why I switched them both. WPS_STOP is now BUTTON_POWER 13.36.20 # POWER with no REPEAT ? 13.36.38 # POWER|REL I guess 13.36.49 # -{ ACTION_WPS_STOP, BUTTON_PLAY|BUTTON_REPEAT, BUTTON_PLAY }, 13.36.49 # +{ ACTION_WPS_STOP, BUTTON_POWER|BUTTON_REL, BUTTON_POWER }, 13.36.50 # -{ ACTION_WPS_CONTEXT, BUTTON_HOME|BUTTON_REPEAT, BUTTON_HOME }, 13.36.50 DBUG Enqueued KICK salty-horse 13.36.50 # +{ ACTION_WPS_CONTEXT, BUTTON_PLAY|BUTTON_REPEAT, BUTTON_PLAY }, 13.36.58 # + is my change 13.37.47 # ok, that's going to conflict with softlock 13.38.01 # (we can't do long-power, as that'll power down the device) 13.38.28 # ah. I don't use softlock atm. I don't like it's "short-power" binding. It feels wrong to me 13.38.52 # it's what the OF does IIRC 13.39.09 Quit Piece_Maker (Quit: ZNC 1.8.2 - https://znc.in) 13.39.28 # I do hate how the xduoo buttons are "outies". it keeps getting pressed in my pocket. never happened on sansa e200 where the buttons were flush with the device 13.40.12 # Build Server message: 3Build round completed after 675 seconds. 13.40.13 # Build Server message: 3Revision 22c2e0a7c2 result: All green 13.40.25 # so I do need the lock. Can I just delete the STOP entry (locally for me) or will it break anything? 13.41.13 Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) 13.41.30 # nope, it won't break anything other than perhaps expectations 13.49.00 # (and make baby otters cry) 13.49.29 # I always wondered what it sounds like 13.50.34 # so I have no suggestion on how to fix the inconsistency in button mapping, unless STOP is ok to be removed. I originally added it as part of my own patch, but maybe it's not worth it 13.55.22 *** Saving seen data "./dancer.seen" 14.06.58 Join lebellium [0] (~lebellium@2a01cb04012c09002cbbef5cf5b73502.ipv6.abo.wanadoo.fr) 15.50.54 Join petur [0] (~petur@78-21-55-218.access.telenet.be) 15.55.25 *** No seen item changed, no save performed. 16.15.46 Quit Piece_Maker (Quit: ZNC 1.8.2 - https://znc.in) 16.17.25 Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) 16.55.14 Quit salty-horse (Quit: Leaving) 17.20.10 # <_bilgus> Salty so is the reversed selection fixed then too? 17.23.02 # _bilgus: I think so; it wasn't reversed but the plug/unplug caused spurious "remote" reads. 17.23.32 # <_bilgus> odd that they bypassed the setting though 17.23.59 # well, the spurious read was a play/pause trigger, so... 17.25.09 # <_bilgus> IDK I also noticed an extra keyclick in the settings>database>folder_select menu that I don't remember being there in the sim I might have broken something 17.26.38 # <_bilgus> munkis your code looks fine I'll compile it later, I see you decided to just block on the back end with explanation in the manual sounds good to me but its an odd combo in my mind 17.26.57 # <_bilgus> single mode versus crossfade 17.29.28 # <_bilgus> I'd almost make it just disable crossfade when active I think 17.29.45 # yeah, I think I'd agree with that. 17.30.05 # I mean, in single-shot mode there shouldn't be anything to crossfade with, logically 17.30.16 # <_bilgus> yeah 17.30.33 # <_bilgus> so id say make single mode the precedent 17.31.49 # <_bilgus> an aside, only the database file selector uses folder_select and it already uses the plugin buffer I think it might be the first plugin that takes arguments 17.34.52 # <_bilgus> global_settings is available in the plugin so I just need to think of another user that might want to use it on their own buffer 17.38.14 Quit ZincAlloy (Quit: Leaving.) 17.40.54 # I did it this way because I only have to change one thing :) 17.41.40 # but you agree party should precede single 17.55.28 *** Saving seen data "./dancer.seen" 18.24.27 Quit lebellium (Quit: Leaving) 18.31.47 # I uploaded a new patchset which as far as I cann tell works as expected on fuze+ 19.55.29 *** Saving seen data "./dancer.seen" 20.09.49 Quit petur (Quit: Leaving) 20.32.08 # <_bilgus> I think party mode trumps all atm 21.55.31 *** Saving seen data "./dancer.seen" 23.12.45 # ok... not quite how I should respond to this 23.12.47 # https://notify.cispa.de/reports/rockbox.org/report-rzSYgVYI 23.14.42 # I mean, it's technically correct, we do have git repos, but I question the general usefulness of the test. 23.55.32 *** No seen item changed, no save performed.