--- Log for 16.03.122 Server: molybdenum.libera.chat Channel: #rockbox --- Nick: rb-logbot Version: Dancer V4.16 Started: 1 month and 7 days ago 00.49.15 Quit _bilgus (Ping timeout: 256 seconds) 00.53.56 Join _bilgus [0] (~bilgus@162.154.213.134) 01.57.50 *** Saving seen data "./dancer.seen" 03.57.51 *** No seen item changed, no save performed. 05.57.53 *** No seen item changed, no save performed. 07.08.09 Join shawn196 [0] (~shawn156@c-76-25-73-212.hsd1.co.comcast.net) 07.09.43 Quit S|h|a|w|n (Ping timeout: 256 seconds) 07.57.57 *** Saving seen data "./dancer.seen" 08.03.32 Quit shawn196 (Quit: Leaving) 08.47.34 Join massiveH [0] (~massiveH@ool-4a5862ee.dyn.optonline.net) 09.57.58 *** Saving seen data "./dancer.seen" 10.08.46 Quit braewoods (Quit: WeeChat 2.8) 10.12.33 Join braewoods [0] (~braewoods@user/braewoods) 10.43.59 Quit massiveH (Quit: Leaving) 10.47.34 # <_bilgus> I'm experimenting with moving all the file paths out of the settings struct and into their own file, the majority do not get used often and when they are most appear to be used for building a path in a separate buffer anyway so I think it makes sense to move them out and instead cache them into buflib rather than keeping them around for the duration 10.49.05 # <_bilgus> I'm just fleshing out the API if anyone has suggestions.. So far I think the new settings will just be appended to the file till a threshold (max size) is reached to condense it 10.50.00 # <_bilgus> next paths will be retrieved by an enum linked to string options that way we can keep it plain text 10.50.40 # <_bilgus> format filetag = pathstring\n 10.53.03 # <_bilgus> as strings are loaded I might cache them and erase upon shrink/move cb, might be overkill depending on the frequency (might just give a fn to cache it) 11.54.03 Join amachronic [0] (~amachroni@user/amachronic) 11.54.28 # Build Server message: 3New build round started. Revision 0df71c952c, 303 builds, 6 clients. 11.57.59 *** Saving seen data "./dancer.seen" 12.03.08 Quit amachronic (Ping timeout: 250 seconds) 12.05.10 Join amachronic [0] (~amachroni@user/amachronic) 12.06.52 # _bilgus my only suggestion is that as things currently stand, that would be unlikely to be a code size win 12.07.49 # the max filename length is 32 chars and max path 80 chars 12.08.15 # by my count it adds up to 981 bytes in user_settings (plus a little more for alignment I guess) 12.09.20 Join bilgus_ph [0] (~bilgus_ph@172.58.222.153) 12.12.48 # Amachronic, I concur the bookkeeping structure will end up being larger than the, worst case size of 1k so probably pointless then again I'll have to look at all the support code before I call it dead, might get some back in consolidating it 12.13.48 # I really want it to be plaintext so that removes some of the book keeping tricks like making every entry maxpath or something 12.15.32 # Maybe better would be to just move to a separate settings structure that can be unloaded 12.16.03 Quit bilgus_ph (Quit: Connection closed) 12.18.17 Quit amachronic (Quit: amachronic) 12.32.03 # Build Server message: 3Build round completed after 2254 seconds. 12.32.06 # Build Server message: 3Revision 0df71c952c result: All green 12.32.33 # Build Server message: 3New build round started. Revision c676736792, 303 builds, 6 clients. 12.39.26 # 'improve correctness' is a nice description 12.53.51 # Build Server message: 3Build round completed after 1277 seconds. 12.53.51 # Build Server message: 3Revision c676736792 result: All green 13.35.17 # amachronic: do the buttons on the quickscreen still work for you on the q1 in 'absolute point' mode ? 13.36.07 # i have reset my settings, then turned on 'absolute point'. the quickscreen shows 'shuffle' and 'repeat' but no matter what i 'click' the screen closes 13.36.18 # with the settings unchanged 13.37.26 # the 'ok' buttons on the pitch screen also do not work 13.38.22 Join bilgus_ph [0] (~bilgus_ph@172.58.222.249) 13.39.26 Quit Piece_Maker (Read error: Connection reset by peer) 13.40.28 Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) 13.41.52 # i must be doing something wrong but i cannot figure out what 13.50.39 # Spork likely I broke something with the skin parser but I don't think either of those are skinned 13.50.48 Quit bilgus_ph (Quit: Connection closed) 13.52.39 # they look quite basic indeed 13.52.50 # it might have been broken for a while 13.55.54 # same build works fine on m3k, but that is not a touchscreen device 13.58.02 *** Saving seen data "./dancer.seen" 13.58.40 # it is build b3e0d18f7d now which is the skin engine cleanup 13.59.00 # but i am fairly sure it was not working before i upgraded to that 13.59.58 Join bilgus_ph [0] (~bilgus_ph@172.58.222.248) 14.00.35 # I'll try to repor in the simple this evening hopefully it fails there as well 14.01.09 # Reproduce* simulator* 14.02.31 Quit bilgus_ph (Client Quit) 14.05.10 # i do not think you can simulate 'absolute point' mode 14.05.15 # only 3x3 14.07.23 Join ZincAlloy [0] (~Adium@ip5f5abcae.dynamic.kabel-deutschland.de) 14.11.32 Quit ZincAlloy (Ping timeout: 240 seconds) 14.13.30 Join ZincAlloy [0] (~Adium@2a02:8108:943f:d824:cf6:65fc:5cd7:439d) 14.54.36 Join lebellium [0] (~lebellium@2a01cb04012c0900897cc0b083e1abd0.ipv6.abo.wanadoo.fr) 15.58.03 *** Saving seen data "./dancer.seen" 16.14.25 # <_bilgus> spork can you try this build on your Q1? https://www.mediafire.com/file/bruvd1h53ecbjzx/shanlingQ1_bba0564ec_rockbox.zip/file 16.55.44 # <_bilgus> I think the skin parser is it, judging by the region lookup code but damned if I can find any typo 17.25.07 Quit JanC (Remote host closed the connection) 17.52.02 Join JanC [0] (~janc@user/janc) 17.58.07 *** Saving seen data "./dancer.seen" 18.15.48 Quit Piece_Maker (Ping timeout: 250 seconds) 18.16.09 Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) 18.34.15 Quit ZincAlloy (Quit: Leaving.) 18.36.17 Quit Piece_Maker (Read error: Connection reset by peer) 18.36.46 Join Piece_Maker [0] (~Piece_Mak@cpc95746-bolt17-2-0-cust360.10-3.cable.virginm.net) 18.37.34 Quit lebellium (Quit: Leaving) 18.38.54 Join smithjd [0] (~enderw@node-1w7jra28yypteo4nnhbacezk9.ipv6.telus.net) 18.51.01 Quit smithjd (Ping timeout: 256 seconds) 19.23.24 # Build Server message: 3New build round started. Revision 67f7d399e5, 303 builds, 7 clients. 19.28.56 Join amachronic [0] (~amachroni@user/amachronic) 19.31.07 # spork the quickscreen is indeed broken, it's also reproducible on the sim 19.31.52 # <_bilgus> I wonder trying to read a text param without it existing is bad juju in the skin engine 19.32.10 # i'm bisecting it now so we'll see... 19.36.48 # <_bilgus> is the quick screen a button combo on the Q1? 19.37.24 # in abs. point mode it's only accessible from the WPS - you press the bottom left corner 19.37.35 # (of the touchscreen) 19.37.44 # <_bilgus> got it thats helpful :p 19.38.49 # <_bilgus> hmm amazingly its not me, hope your bisect proves as much :p 19.39.22 # yep, the bad commit is mine -- 3f966b2aa "touchscreen: make quickscreen easier to use" 19.39.44 # which is odd because I tested this... 19.40.24 # partly to solve this exact problem, lol. 19.43.47 # <_bilgus> (x < LCD_WIDTH/3 ? left : (x > 2*LCD_WIDTH/3 ? 2 : right)) | (y < LCD_WIDTH/3 ? top : (y > 2*LCD_WIDTH/3 ? 8 : bottom)); 19.44.06 # <_bilgus> since the case is in order isn't that going to always choose the top item? 19.45.18 # that's it, I can only assume I broke it during some funky rebase... or I didn't actually test properly :P 19.45.40 # more likely the latter 19.46.01 # <_bilgus> no judgement here Ive plenty of that :p 19.48.49 # Build Server message: 3Build round completed after 1524 seconds. 19.48.52 # Build Server message: 3Revision 67f7d399e5 result: All green 19.57.29 # Build Server message: 3New build round started. Revision b309fae2bc, 303 builds, 6 clients. 19.58.11 *** Saving seen data "./dancer.seen" 20.06.25 # <_bilgus> doe sthe pitch screen show the wrong text 'Pictureflow?) on the device too or just the sim? 20.17.38 # Build Server message: 3Build round completed after 1209 seconds. 20.17.40 # Build Server message: 3Revision b309fae2bc result: All green 20.20.30 # i see nothing wrong with the pitchscreen on the q1 20.32.09 Quit amachronic (Quit: amachronic) 20.32.29 # <_bilgus> weird probably lang files need remade 20.34.12 # <_bilgus> yep that was it 21.49.01 Quit akaWolf (Ping timeout: 268 seconds) 21.49.52 Join LambdaCalculus37 [0] (~LambdaCal@pool-108-5-121-34.nwrknj.fios.verizon.net) 21.50.29 Join akaWolf [0] (~akaWolf@akawolf.org) 21.58.05 Join ufdm_ [0] (~ufdm@c-68-46-16-107.hsd1.mn.comcast.net) 21.58.14 *** Saving seen data "./dancer.seen" 21.58.30 Quit ufdm (Read error: Connection reset by peer) 21.59.05 Quit LambdaCalculus37 (Quit: Leaving) 22.02.09 # <_bilgus> amachronic, spork being touch screen users would it be helpful to have a plugin that plays an action when run? to use as a qs item perhaps 23.58.18 *** Saving seen data "./dancer.seen"