--- Log for 27.11.122 Server: lithium.libera.chat Channel: #rockbox --- Nick: rb-logbot Version: Dancer V4.16 Started: 1 day and 12 hours ago 00.28.51 # always encouraging to see even you make mistakes ;) 00.33.45 # string handling in C generally seems pretty insane to me 00.37.27 Quit massiveH (Quit: Leaving) 00.37.28 # what's really fun is that some CPU arches have "native" C stringhandling instrctions. 00.38.21 # <_bilgus> I make tons of mistakes 00.38.59 # <_bilgus> could you test g#4846 and see if it fixes the issue 00.39.02 # 3Gerrit review #4846 at https://gerrit.rockbox.org/r/c/rockbox/+/4846 : 3bookmark.c fix off by one error in filename generator by William Wilgus 00.42.17 # <_bilgus> I've found it quite challenging to get rid of those static buffers its hard building strings piecemeal 00.42.58 # I think I've identified a few more fields we can use to guess at SSD support, if the adapter passes through the identify info unmolested. 00.43.34 # <_bilgus> talk about some happy iPod users 00.44.37 # probably should just buy some hardware myself. :/ 00.45.12 # huh, my toolchain build succeeded this time. wonder if it works. 00.46.13 # _bilgus: still happening... 00.49.42 # i see no rhyme or reason to when it works and when it doesn't though 00.50.49 # <_bilgus> could you give me the string it created in the bmark file? 00.51.13 # <_bilgus> I'm generating the name based on that so it might give me a clue 00.51.49 # >3;7;846577;0;3900;0;0;10000;10000;/Playlists/God is in the House.m3u;//Music/Art Tatum/God is in the House/08 Knockin' Myself Out.m4a 00.52.14 # filename for the bookmark is God is in the House.m3u.bmark 00.53.20 # <_bilgus> so still knocing off the 8? then 00.53.44 # <_bilgus> oh but it did it in the bmark file too 00.57.33 # sometimes more.. 01.02.59 # <_bilgus> hmm it gets the string from playlist_get_name() 01.04.00 # anyone have an arm target handy to run a smoke test build for me? 01.04.28 # (all of mine are a ~3h drive away) 01.04.42 # i have an ipod handy 01.04.54 # which one? 01.05.16 # I just built a mini2g image with only one new warning. :) 01.05.16 # oh yeah.. the iPod video 01.05.56 # ok, comipling. 01.10.25 # chris_s: https://www.shaftnet.org/~pizza/ipodviode-test.zip 01.10.32 # (typo is "correct") 01.15.25 # it's about an 8.5KB smaller main binary than the last dev build with 4.9.4, apparently. 01.16.05 # er, 6.5KB 01.16.11 # ditto on RAM usage. 01.18.12 # <_bilgus> ok the only other thing I see is I might be screwing up strlcat by feeding it the current buffer position rather than letting it traverse the string 01.18.24 # speachy: sounds good – all seems well so far. Boots up and plays music... anything specific I should be testing? 01.18.43 # <_bilgus> chris_s when you get a chance could you try 4846 again 01.18.54 # nothing in particular; the fact that it runs at all is a massive step. 01.19.39 # this means that this toolchain bump is ready for wider testing. 01.19.44 # <_bilgus> sorry 4848 01.20.05 # Build Server message: 3New build round started. Revision 65db4acabe, 303 builds, 7 clients. 01.21.24 # chris_s: The GCC 4.9.4 (and -Os) migration was pretty rocky for the ipods. several major issues were uncovered. 01.22.53 # <_bilgus> I'm sure there is more of that hiding waiting for discovery but ASAN and UBSAN have helped uncover a bunch of stuff 01.25.25 # 7.1K shrink on the clipplus, huh. 01.25.57 # _bilgus: same thing.... 01.27.31 # g4850 has my latest attempts to make mSATA SSDs happy. total guesswork. 01.27.34 # <_bilgus> hmm still the same thing in the .bmark file too? 01.28.05 # <_bilgus> at this point might be chasing a bug elsewhere 01.28.24 # >3;4;122499;0;4598;0;0;10000;10000;/Playlists/The Tallest Man On Eart;//LQ/The Tallest Man On Earth/Shallow Grave/05 Where Do My Bluebird Fly.mp3 01.28.27 # yeah 01.28.57 # reverting 88ecaf2 seems to fix it thoigh 01.31.08 # <_bilgus> then my math is off or something 01.31.58 # gonna crash finally. 01.32.48 # <_bilgus> nn speachy 01.37.41 # Build Server message: 3Build round completed after 1056 seconds. 01.37.42 # Build Server message: 3Revision 65db4acabe result: All green 01.43.24 # <_bilgus> chris_s well sure enough when I passed back the strings you posted it did the same thing WTH 01.44.56 # <_bilgus> well with the added 'h' ofc 01.45.52 # glad you're able to reproduce it at least 01.47.14 # <_bilgus> ffs I see what it is 01.47.46 *** Saving seen data "./dancer.seen" 01.47.52 # <_bilgus> using bmsz instead of bufsz to playlist_get_name 01.48.22 # <_bilgus> IDIOT in stimpy voice 01.49.37 # :o 01.52.17 # <_bilgus> ok can you try that one it should be good now 01.56.53 # sure enough... looks good :D 01.57.56 # <_bilgus> lol 01.58.10 # <_bilgus> im renameing bmsz to something longer 01.58.18 # ha 01.58.53 # <_bilgus> anyway thanks for your testing 01.59.08 # no problem, thanks for keeping at it 02.05.34 # Build Server message: 3New build round started. Revision 3f4e55a872, 303 builds, 7 clients. 02.23.59 # Build Server message: 3Build round completed after 1104 seconds. 02.24.15 # Build Server message: 3Revision 3f4e55a872 result: All green 02.37.48 # <_bilgus> hmm I do see another bug though sometimes playlist_get_resume_info() doesn't return the proper index 02.38.30 # <_bilgus> I noticed it first on a playlist with only 1 item the bookmark recorded 3 for the index but it was index 0 02.39.09 # <_bilgus> then I tried a playlist with 2 items and sometimes it returns 0 even though i'm playing song at index 1 03.47.48 *** No seen item changed, no save performed. 04.05.43 Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) 04.08.56 Quit advcomp2019 (Ping timeout: 256 seconds) 04.13.56 Join fourHZ [0] (~fourHZ@92-52-40-121.dynamic.orange.sk) 04.17.21 Join lebellium [0] (~lebellium@2a01cb040109a60001a53c527cc10874.ipv6.abo.wanadoo.fr) 05.35.44 Quit CH23_M (Ping timeout: 260 seconds) 05.38.39 Join Pokey [0] (~pokey@spikeyCactus/hoosky) 05.39.02 Quit Pokey (Client Quit) 05.40.00 Join CH23_M [0] (~CH23@revspace/participant/ch23) 05.43.06 Join Pokey [0] (~pokey@spikeyCactus/hoosky) 05.47.49 *** Saving seen data "./dancer.seen" 06.08.23 Quit fourHZ (Ping timeout: 260 seconds) 07.01.10 Join fourHZ [0] (~fourHZ@92-52-40-121.dynamic.orange.sk) 07.28.04 Quit hactar|ant (Ping timeout: 260 seconds) 07.28.30 Quit chris_s (Ping timeout: 265 seconds) 07.35.34 Join hactar|ant [0] (~zem@c-24-21-103-100.hsd1.or.comcast.net) 07.47.52 *** Saving seen data "./dancer.seen" 09.41.16 Quit Pokey (Quit: Hecc! My server must have died!) 09.45.21 Join Pokey [0] (~pokey@spikeyCactus/hoosky) 09.47.53 *** Saving seen data "./dancer.seen" 10.13.27 # <_bilgus> well scratch that after adding debugging and recompiling I can't repro 10.13.44 # <_bilgus> and going back I can't repro either 10.14.01 # so... swamp gas reflecting off a weather baloon? 10.14.17 # <_bilgus> exactly 10.15.10 # <_bilgus> I do get weird stuff like that on ocassion just replacing the binary only in an install even though nothing else has changed 10.15.29 # <_bilgus> seg faults and whatnot 10.15.46 # <_bilgus> voodoo or something 10.17.13 # I guess one of us "core" devleopers should get one of these ipod ssd thingeys. 10.17.47 # and/or kick out another release so we can stop getting bug reports about stuff fixed two years ago 10.18.59 # <_bilgus> we have one I don't remember who has it 10.19.29 # <_bilgus> no thats the sd adapter 10.19.39 # <_bilgus> theres a ssd now? 10.19.50 # zif->mSATA 10.19.59 # so you can plug in a generic mSATA ssd. 10.20.08 # <_bilgus> nice 10.20.23 # vast overkill for performance (and likda power hungry but still better than the stock spinning rust) 10.20.42 # <_bilgus> so same issue as the iflash then just new weird behavior? 10.20.52 # but $/GB it's still the cheapest way to go for large sizes. 10.21.12 # it's similar-ish. By appearances writs are really unreliable 10.21.30 # I suspect it's the same underlying problem (ie power being turned off before things are ready for it) 10.21.52 # I don't know if mSATA is truly meant to have the power completely turned off in the same way FWIW. 10.22.17 # <_bilgus> It probably isn't seems like it'd want to keep state 10.22.59 # dunno. I need to see what the ATA IDENTIFY info comes up with and I can go from there 10.23.27 # ...something similar showing up on the iHP-3xx too. 10.23.32 # same ATa driver 10.24.36 Join steelbas [0] (~steelbas@185.65.134.179) 10.24.38 # but with an unknown chinesium SSD that I think is also a mSATA adapter 10.24.40 # <_bilgus> well being that iPods seem to be our core users at this point.. guess there are a bunch secondhand still alive 10.25.25 # ipods will be aroun long after everything else has bitrotten, alas. 10.28.17 # ipods are the best choice for easy storage and battery upgrade 10.29.38 # well, the "classic" ipods are. the newer flash-based ons have mostly already failed. 10.29.50 Quit steelbas (Quit: Leaving) 10.31.34 # I'm going to reach out to some of those "reburbished ipod" sellers in china and see if they'll tell me what type of SSD they're putting inside. 10.32.38 # sansa/iriver updrade is painful, sadly, at least without 3D printer for custom case. 10.35.59 # it's gonna cost about $120 just for a working ipod and the msata adapter, and more for the ssd; might as well buy one that already has the work done. 10.36.14 # I _might_ have an old mSATA SSD or two lying around 10.37.17 # LOL, the response is "Hello, dear. SSD type." 10.39.03 # tell them "I wanna buy a lot, 100+, and need a free sample" :D 10.41.34 # some of the sellers list it as "SD mod" but most don't. 10.41.51 # to get exactly what we want I'll probably have to do the work myself, joy. 10.48.03 # looks like about $150 all-in, including a noname 256GB mSATA SSD. for a 5th gen 30gb. 10.52.45 # and I still need to fix the X3's USB stuff. :D 10.53.06 # (...speaking of a mostly irrelevant player that nobody van get any more...) 11.03.11 Quit speachy (Quit: WeeChat 3.6) 11.04.44 Quit Pokey (Ping timeout: 260 seconds) 11.07.28 Join Pokey [0] (~pokey@spikeyCactus/hoosky) 11.28.44 # <_bilgus> might post to the forum about someone donating one or money for one 11.28.58 # <_bilgus> if not I have $20 towards the cause 11.29.40 # <_bilgus> I can't see me ever using one but I can't see you paying out of pocket to do the work too 11.33.22 # msata is basically dead right? in favour of m.2 sata/pcie 11.35.11 # <_bilgus> chris_s (logs) your recent Return to opened playlists -- how does reopen_last_playlist do with the two paths into display_playlists() (catalog_view_playlists & catalog_add_to_a_playlist) wouldn't it cause it to pull you into the current playlist rather than to the menu for selecting a new one? 11.40.02 # <_bilgus> another issue id that it pulls you directly to the WPS when you try to go back to the playlist catalog after its already playing 11.41.09 # <_bilgus> that is probably existing 11.44.20 # <_bilgus> ah nevermind I see its done on the view conditional 11.47.55 *** Saving seen data "./dancer.seen" 11.56.14 Join mink [0] (~mink@125.215.164.109.static.wline.lns.sme.cust.swisscom.ch) 11.56.33 Quit CH23_M (Read error: Connection reset by peer) 11.57.24 Join CH23_M [0] (~CH23@revspace/participant/ch23) 11.58.27 Quit mink (Remote host closed the connection) 12.01.59 Quit CH23_M (Ping timeout: 264 seconds) 12.05.52 Join CH23_M [0] (~CH23@revspace/participant/ch23) 12.21.06 Quit CH23_M (Read error: Connection reset by peer) 12.22.02 Join CH23_M [0] (~CH23@revspace/participant/ch23) 12.26.28 # Build Server message: 3New build round started. Revision 0c7394e39a, 303 builds, 7 clients. 12.36.39 # <_bilgus> the only thing thats a little off about the patch in the end is that if you were in a playlist lets call it 'A' and added to playlist 'B' then backed out to the catalog screen it would now have 'B' selected and take you to the selected item index you were using in 'A" 12.37.29 # <_bilgus> I did check if that index was out of range for B then it selects index 0 so meh quirky but not bad 12.40.51 Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7) 12.43.57 Quit Pokey (Quit: Hecc! My server must have died!) 12.45.09 Join Pokey [0] (~pokey@spikeyCactus/hoosky) 12.55.54 # Build Server message: 3Build round completed after 1765 seconds. 12.55.58 # Build Server message: 3Revision 0c7394e39a result: 2 errors 0 warnings 13.00.16 # <_bilgus> well just got a case of it selecting the wrong index again so far its always one off either -1 or +1 but this time it was in invalid index so it corrupted the resume state 13.01.31 # <_bilgus> it then had playlist control invalid error it makes me wonder if its that infamous bug rearing its ugly head or something I or we've brought upon ourselves :) 13.02.52 # <_bilgus> oh no scratch that it wasn't an invalid index hmm so might be the whole current_playlist state getting corrupted 13.21.26 Join mink [0] (~mink@178.197.232.222) 13.22.13 Quit mink (Read error: Connection reset by peer) 13.35.38 # <_bilgus> wow went back to a build from 10-2020 and the lag is striking versus the lack thereof from today 13.47.58 *** Saving seen data "./dancer.seen" 14.01.36 # <_bilgus> well it happens before 88ecaf2b8c so I guess I need to go on a bisect adventure 14.13.14 # <_bilgus> I'll try to get to that this eve or this week if anyone wants to play along just set the bookmark options to [Yes][Bookmark on stop, update on stop, Maintain a lict of recent] and using Playlist Catalog create an /all playlist then choose a song and stop it [Bookmark Created] finally go to Recent Bookmarks and choose the latest bookmark then rinse repeat I usually get it to fail with Playlist buffer Full by the 5th time of choosing the 14.13.14 # <_bilgus> latest/stopping/choosing the latest 14.14.08 # <_bilgus> might have to do with the number of songs (I have 11000 in there and a max playlist size of 32000) 14.38.17 Join speachy [0] (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) 14.38.17 Quit speachy (Changing host) 14.38.17 Join speachy [0] (~speachy@rockbox/developer/speachy) 14.38.17 Mode "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) 14.38.42 # _bilgus: there's money in the slush fund, just don't like spending that much unliaterally. 14.39.40 # hactar|ant: it's obsolete but there's still a huge deployed base of non-mvme-capable systems. 14.41.06 # sweet! USB on the X3 is still not working but at least it's enumerating now. 14.41.31 # finally rewrote the ctrl stuff for the new API 14.47.17 # huh, usb hid works but not mass storage. 14.48.02 # i meant both pcie and sata 14.48.08 # both can use the m.2 connector 14.48.39 # msata uses the m.2 connector 14.48.58 # keyed differently, naturally. 14.49.59 # OK, it's DMA causing the problems. 15.06.00 Quit speachy (Quit: WeeChat 3.6) 15.25.23 Join chris_s [0] (~chris_s@ip-095-223-073-220.um35.pools.vodafone-ip.de) 15.25.57 # _bilgus: re the "Return to opened playlists" patch: 15.26.05 # 1) Trying to figure out what you meant by this. Could you explain a bit more? 15.26.12 # "it pulls you directly to the WPS when you try to go back to the playlist catalog after its already playing" ? 15.26.20 # 2) By selecting a playlist different from the one previously selected in the "Add to Playlist" dialog, in theory, it should reset the selected playlist *and* the selected index in that playlist (to 0), but please let me know if you're seeing something else. 15.26.32 # This side effect is a bit quirky, but it's basically existing behavior. 15.26.39 # I guess it has the advantage that after you've added something to a playlist, you can go the Playlist Catalogue and immediately see *that* playlist selected. 15.26.46 # It may be worth it to change it so that a selection in the dialog doesn't affect the regular menu. 15.46.49 # I still want to add a way (which the other patch is for that's still a WIP – in terms of the manual needing to be updated) to be able to return from the WPS to the Playlist Catalogue directly, i.e. basically (at least optionally) treat it, like Files and the database, as just another "browser". 15.47.25 # g4627 15.48.02 *** Saving seen data "./dancer.seen" 15.50.42 # in a way, this is just a prerequisite for that, so that you can return from the WPS to the playlist you had selected 15.59.33 Join speachy [0] (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) 15.59.33 Quit speachy (Changing host) 15.59.33 Join speachy [0] (~speachy@rockbox/developer/speachy) 15.59.33 Mode "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) 17.04.46 Quit Serke_ (Remote host closed the connection) 17.09.50 Join Serke [0] (Serke@176.212.168.111) 17.12.32 Quit reductum (Quit: WeeChat 2.8) 17.13.16 Join reductum [0] (~reductum@2603-8000-b400-8764-dea6-32ff-fe16-a622.res6.spectrum.com) 17.21.56 Join tomato [0] (~tomato@user/tomato) 17.32.00 Quit speachy (Quit: WeeChat 3.6) 17.48.05 *** Saving seen data "./dancer.seen" 18.08.37 Quit Serke (Remote host closed the connection) 18.47.43 Quit lebellium (Quit: Leaving) 19.37.33 Quit chris_s (Quit: Connection closed) 19.48.09 *** Saving seen data "./dancer.seen" 21.01.04 Quit tomato (Quit: The Lounge - https://thelounge.chat) 21.12.13 Join speachy [0] (~speachy@gw-tf.shaftnet.org) 21.12.14 Quit speachy (Changing host) 21.12.14 Join speachy [0] (~speachy@rockbox/developer/speachy) 21.12.14 Mode "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) 21.12.53 # Ok, just spent $145.27 of the rockbox slush fund on a 30GB ipod 5.5g, an iflash msata v10, and a 256GB m.2 mSATA SSD. Should get everything by this coming weekend. 21.18.14 # <_bilgus> chris_s I was referring to how it pulls you back into the WPS when you visited the playlist catalog but that appears to be connected to autoplay bookmarks and was the previous behavior 21.18.50 # <_bilgus> speachy nice! 21.20.18 # speachy msata is bigger than m.2 21.20.23 # https://www.titancomputers.com/v/vspfiles/assets/images/M.2_and_mSATA_SSDs_comparison.jpg 21.20.41 # both sata and nvme use the m.2 form factor 21.32.54 # <_bilgus> ok so the bug behavior I observed is there 03 2022 further back I haven't reprod it yet but its painfully slow to do so 21.33.10 Join tomato [0] (~tomato@user/tomato) 21.48.12 *** Saving seen data "./dancer.seen" 22.07.27 # I was careful to pick up the m.2 variant for this, as that's what the latest bug report is about. 22.08.05 # the old mSATA drives I have lying around are the older form factor (iirc shared with mini-pci-express) 22.10.39 # <_bilgus> repro with 05-2021 22.11.44 # <_bilgus> I think i'll try 3.15 next if that still shows I won't bother with a bisect 22.28.25 # there's no shortage of old bugs 22.28.40 # so there's no need to keep introducing new ones, eh? 22.33.41 # <_bilgus> oh? missed the memo :p 22.34.54 # <_bilgus> ah crap I don't think 3.15 is multiboot aware 22.35.30 # <_bilgus> ah just not with a custom folder 23.15.41 # <_bilgus> god that was painful yes I can confirm it loses the index in 3.15 as well 23.16.13 # <_bilgus> it is amazing how slow 3.15 is compared to now 23.20.23 # @!$#@!$ now I'm getting an apparently unrelated panic. I really should revert to the old toolchain just to be sure it's due to my code changes. 23.23.37 # <_bilgus> now time to go searching for this bug wish I could get it in the sim in a more consistent manner 23.31.21 # time for me to give up for the day. 23.31.26 # g'nite 23.31.28 Quit speachy (Quit: WeeChat 3.6) 23.32.53 # <_bilgus> nn 23.37.16 Quit m01 (Quit: Konversation terminated.) 23.39.30 Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net) 23.42.28 Join othello7 [0] (~Thunderbi@pool-100-36-133-223.washdc.fios.verizon.net) 23.48.15 *** Saving seen data "./dancer.seen"