--- Log for 10.12.122 Server: lithium.libera.chat Channel: #rockbox --- Nick: rb-logbot Version: Dancer V4.16 Started: 14 days and 12 hours ago 00.16.12 Join S|h|a|w|n [0] (~shawn156@user/shawn/x-4432647) 01.08.18 Join fourHZ [0] (~fourHZ@92-52-40-121.dynamic.orange.sk) 01.20.45 Quit massiveH (Quit: Leaving) 01.54.14 *** Saving seen data "./dancer.seen" 02.00.27 Join toruvinn [0] (~toruvinn@KD119106000050.ppp-bb.dion.ne.jp) 03.54.18 *** No seen item changed, no save performed. 04.15.36 Join lebellium [0] (~lebellium@2a01cb040109a6001d29f6c4d30b6294.ipv6.abo.wanadoo.fr) 04.36.00 Quit S|h|a|w|n (Read error: Connection reset by peer) 05.54.19 *** Saving seen data "./dancer.seen" 06.56.30 Quit CH23_M (Ping timeout: 256 seconds) 06.57.37 Join CH23_M [0] (~CH23@revspace/participant/ch23) 07.54.23 *** Saving seen data "./dancer.seen" 09.18.19 Join amachronic [0] (~amachroni@user/amachronic) 09.29.35 # Build Server message: 3New build round started. Revision 90d1ac0448, 303 builds, 6 clients. 09.54.24 *** No seen item changed, no save performed. 10.41.07 # Build Server message: 3Build round completed after 4292 seconds. 10.41.11 # Build Server message: 3Revision 90d1ac0448 result: All green 11.04.14 Quit amachronic (Ping timeout: 260 seconds) 11.21.13 Quit paulk-bis (Ping timeout: 252 seconds) 11.23.20 Join paulk-bis [0] (~paulk@12.234.24.109.rev.sfr.net) 11.28.59 Quit paulk-bis (Ping timeout: 264 seconds) 11.29.18 Join paulk-bis [0] (~paulk@vpn-0-22.aquilenet.fr) 11.41.06 Quit Richard42 (Ping timeout: 268 seconds) 11.42.47 Join Richard42 [0] (~pyro@107-203-176-170.lightspeed.irvnca.sbcglobal.net) 11.54.27 *** Saving seen data "./dancer.seen" 12.04.46 Join chris_s [0] (~chris_s@ip-095-223-073-220.um35.pools.vodafone-ip.de) 12.10.09 Quit chris_s (Quit: Connection closed) 13.40.07 Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) 13.42.48 Quit advcomp2019 (Ping timeout: 256 seconds) 13.50.28 Join zeth [0] (~zeth@cpc110919-live30-2-0-cust650.17-2.cable.virginm.net) 13.51.09 Part zeth 13.54.28 *** Saving seen data "./dancer.seen" 13.56.01 # <_bilgus_> Hmm looking at INIT_ATTR stuff I found some potential UHOHs in the tree code https://github.com/Rockbox/rockbox/blob/master/apps/tree.c#L1180= https://github.com/Rockbox/rockbox/blob/master/apps/filetypes.h#L59= 13.56.19 # <_bilgus_> pretty sure that is called lomg after init 14.14.28 Join zeth [0] (~zeth@cpc110919-live30-2-0-cust650.17-2.cable.virginm.net) 14.17.38 Quit zeth (Client Quit) 14.24.29 Join Trzyzet [0] (~Trzyzet@cpc110919-live30-2-0-cust650.17-2.cable.virginm.net) 14.25.43 Quit LjL (Quit: Scappò via con la paura di arrugginire. Il giornale di ieri lo dà morto arrugginito. I becchini ne raccolgono spesso fra la gente che si lascia piovere addosso.) 14.27.01 Join LjL [0] (~ljl@user/ljl) 14.35.44 # <_bilgus_> amachronic (logs) what were you saying about having a warning if those INIT_ATTR functions were called after init 14.44.00 # <_bilgus_> anyway g#4904 if someone wants to take a look make sure i'm/its sane 14.44.03 # 3Gerrit review #4904 at https://gerrit.rockbox.org/r/c/rockbox/+/4904 : 3[Bug Fix] filetypes.c move voice data out of INIT_ATTR by William Wilgus 14.44.25 # <_bilgus_> or even Mr.Someone :p 14.58.17 Join chris_s [0] (~chris_s@ip-095-223-073-220.um35.pools.vodafone-ip.de) 14.59.43 Quit chris_s (Client Quit) 15.30.00 Join chris_s [0] (~chris_s@ip-095-223-073-220.um35.pools.vodafone-ip.de) 15.30.40 # I guess it's safe to annotate inbuilt_filetypes with INITDATA_ATTR, since the string constants are stored in rodata regardless? 15.33.46 # ...or string literal 15.54.32 *** Saving seen data "./dancer.seen" 15.58.36 Join bilgus_ph [0] (~bilgus_ph@172.58.203.111) 16.01.03 # Chris_s from what I can tell the ATTR stuff moves it to the audo buffer where it can be overwritten at anytime as far as I know it doesn't do any degisgating as readonly and even if it did its still not truly 16.01.41 # Not that we have anything in flash so its all truly a suggestion 16.02.51 # Designating 16.12.21 # That only applies to the struct itself though, correct? Whereas the string literals, which are assigned to the filetypes extension in line 471, would stick around. Just wanted to make sure the annotation doesn't have any effect on that. Maybe a stupid question... 16.14.06 # I think it does when I checked the map I had 200+ bytes in attr_data or do you mean am I referencing the char* later? 16.18.00 # No you are right it does copy the string ref so need to remove that 16.18.34 # Like I said if I'm its sane :p 16.21.01 # :D 16.29.08 Quit bilgus_ph (Ping timeout: 246 seconds) 16.29.52 Quit chris_s (Quit: Connection closed) 16.43.26 Join chris_s [0] (~chris_s@ip-095-223-073-220.um35.pools.vodafone-ip.de) 16.46.13 Quit chris_s (Client Quit) 16.59.00 Quit Acou_Bass (Quit: ZNC 1.8.2 - https://znc.in) 17.04.26 Join Acou_Bass [0] (~eddie@cpc95736-bolt17-2-0-cust330.10-3.cable.virginm.net) 17.34.00 Quit CH23_M (Read error: Connection reset by peer) 17.34.47 Join CH23_M [0] (~CH23@revspace/participant/ch23) 17.40.48 Quit paulk-bis (Ping timeout: 256 seconds) 17.42.28 Join paulk-bis [0] (~paulk@vpn-0-22.aquilenet.fr) 17.54.36 *** Saving seen data "./dancer.seen" 18.01.36 Quit lebellium (Quit: Leaving) 18.23.56 Join massiveH [0] (~massiveH@2600:4040:a992:a300:9493:7286:3b7e:6166) 18.28.31 Join dconrad [0] (~dconrad@152.117.104.235) 18.50.57 # I think I found another regression - are we already aware of this one? FS#13382 18.50.59 # https://www.rockbox.org/tracker/task/13382 3Regression: Cannot add "Haas Surround" to quickscreen (bugs, new) 18.51.36 # I suspect it's a similar settings file issue, but I don't know why it's still present 19.05.29 # for that matter, I've never been sure what "TLB refill" errors are... Top Level Buffer? What does that refer to? 19.05.52 # ^^that's a guess at what it stands for 19.30.24 # <_bilgus_> dconrad they should probably delete their config file and try again I had some weird stuff going on after that patch, I think TLB is the lookaside buffer maybe Translation Lookaside Buffer its basically a cache 19.30.51 # <_bilgus_> at least on mips not sure if thats the only thing it could be though 19.31.14 # Ok, I can try with a fresh config file and see what happens 19.47.29 # _bilgus_ it did let me successfully add it with a fresh config file on the latest commit, but if I reboot and try to change the setting, I still get a TLB refill error 19.49.42 # no, wait, I tried it again and got the error same as always 19.50.36 # <_bilgus_> might not be related but i could be i'd say its a new bug 19.51.00 # to try with a fresh file, I deleted the file over USB, rebooted, shut it down again, and then booted up and went through my little procedure 19.51.47 # I think I found an old commit where it doesn't occur (somewhere between 10-28 and 11-17), so I'm going to see if I can narrow it down 19.52.28 # it seems to go much farther back than I expected 19.54.37 *** Saving seen data "./dancer.seen" 20.46.02 # the culprit seems to be... g#4691? Currently double checking to try to confirm 20.46.05 # 3Gerrit review #4691 at https://gerrit.rockbox.org/r/c/rockbox/+/4691 : 3playlist: reduce memory usage for loading playlists by Aidan MacDonald 20.46.16 # I don't see how that could cause that though 20.49.24 # yeah, after double checking it really does seem to be the culprit, but I have zero idea how 20.52.37 # time to make some supper though, talk about getting side tracked... I discovered that while walking home with a couple groceries for supper 20.52.41 # lol 21.54.38 *** No seen item changed, no save performed. 22.53.38 Quit dconrad (Remote host closed the connection) 23.13.32 Join dconrad [0] (~dconrad@152.117.104.235) 23.15.48 Quit dconrad (Client Quit) 23.37.11 Quit m01 (Quit: Konversation terminated.) 23.39.18 Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net) 23.54.39 *** Saving seen data "./dancer.seen"