--- Log for 13.12.122 Server: lithium.libera.chat Channel: #rockbox --- Nick: rb-logbot Version: Dancer V4.16 Started: 17 days and 12 hours ago 00.14.56 Join jacobk [0] (~quassel@utdpat242093.utdallas.edu) 01.01.05 Quit hexadecagram (Quit: ZNC 1.8.2 - https://znc.in) 01.07.36 Quit jacobk (Ping timeout: 255 seconds) 01.15.34 Join hexadecagram [0] (~acc@user/hexadecagram) 01.44.05 Join jacobk [0] (~quassel@64.189.201.150) 01.54.23 Quit hexadecagram (Quit: ZNC 1.8.2 - https://znc.in) 01.55.42 *** Saving seen data "./dancer.seen" 02.07.47 Join hexadecagram [0] (~acc@user/hexadecagram) 02.18.00 Join mink [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae) 02.42.49 Quit S|h|a|w|n (Read error: Connection reset by peer) 03.04.38 Quit advcomp2019__ (Read error: Connection reset by peer) 03.13.53 Join advcomp2019 [0] (~advcomp20@user/advcomp2019) 03.51.26 # <_bilgus_> g#4921 should fix all the Table settings stuff 03.51.28 # 3Gerrit review #4921 at https://gerrit.rockbox.org/r/c/rockbox/+/4921 : 3[Bug Fix] option_select.c table settings without arbitrary values by William Wilgus 03.52.51 # <_bilgus_> judging by the index method haas surround is using I think this was the original intention but hell IDK its all got a bunch of history but nonetheless its now set up the way haas surround expects it 03.54.36 # <_bilgus_> F_TABLE_SETTING uses an index to select values, adding F_ARBRITRARY_VALUES allos it to use the values supplied (same with settings file) like if it has 30 seconds you can write in 31 instead of dealing with the table 03.55.44 *** Saving seen data "./dancer.seen" 03.56.30 # <_bilgus_> it might be easier to just rewrite haas surround to convert the values back to an index but I think its a valid use case https://github.com/Rockbox/rockbox/blob/master/lib/rbcodec/dsp/surround.c#L123= 03.57.17 # <_bilgus_> I also think this is the reason we were getting crashes when enabling the dsp since it didn't have a valid setting most of the time 03.57.44 # <_bilgus_> and note ^^ NO default: 03.58.15 # <_bilgus_> anyways that was entirely a headache I'm out. 04.05.23 Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) 04.08.51 Quit advcomp2019 (Ping timeout: 256 seconds) 05.55.46 *** Saving seen data "./dancer.seen" 06.04.59 Quit advcomp2019_ (Read error: Connection reset by peer) 06.05.22 Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) 07.04.41 Quit Maxdamantus (Ping timeout: 246 seconds) 07.06.04 Join lebellium [0] (~lebellium@2a01cb040109a600d8638b5730d3f2db.ipv6.abo.wanadoo.fr) 07.08.51 Join Maxdamantus [0] (~Maxdamant@user/maxdamantus) 07.37.40 Quit Malinux (Ping timeout: 260 seconds) 07.51.06 Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7) 07.55.47 *** Saving seen data "./dancer.seen" 07.59.06 Quit lebellium (Ping timeout: 256 seconds) 08.02.19 Quit paulk-bis (Ping timeout: 256 seconds) 08.45.47 Join zugu [0] (~zugu@86.121.56.231) 08.46.38 Quit zugu (Client Quit) 08.54.55 Join lebellium [0] (~lebellium@2a01cb040109a600d8638b5730d3f2db.ipv6.abo.wanadoo.fr) 08.59.05 Quit lebellium (Ping timeout: 246 seconds) 09.55.50 *** Saving seen data "./dancer.seen" 10.04.50 Quit mink (Remote host closed the connection) 10.17.10 Join mink [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae) 10.36.52 Join paulk-bis [0] (~paulk@vpn-0-22.aquilenet.fr) 10.37.55 # <_bilgus_> rockbox.org is down 10.47.22 Join _mink [0] (~mink@193.134.219.71) 10.50.04 Quit mink (Ping timeout: 265 seconds) 10.52.12 Join massiveH [0] (~massiveH@2600:4040:a992:a300:383f:8f76:863d:25d3) 11.25.26 Quit munkis (Ping timeout: 246 seconds) 11.33.28 Join chris_s [0] (~chris_s@ip-095-223-073-240.um35.pools.vodafone-ip.de) 11.47.59 Quit chris_s (Quit: Connection closed) 11.48.04 Join munkis [0] (~mendel_mu@ool-ae2cb229.dyn.optonline.net) 11.55.54 *** Saving seen data "./dancer.seen" 11.57.21 Join bilgus_ph [0] (~bilgus_ph@rrcs-147-0-163-34.central.biz.rr.com) 11.57.33 Quit bilgus_ph (Client Quit) 11.58.28 Quit jacobk (Ping timeout: 272 seconds) 12.02.17 Join paulk [0] (~paulk@vpn-0-22.aquilenet.fr) 12.02.30 Quit paulk-bis (Read error: Connection reset by peer) 12.03.15 Quit massiveH (Quit: Leaving) 12.10.11 Quit CH23_M (Ping timeout: 246 seconds) 12.11.50 Join CH23_M [0] (~CH23@revspace/participant/ch23) 12.19.16 Join lebellium [0] (~lebellium@2a01cb040109a600d8638b5730d3f2db.ipv6.abo.wanadoo.fr) 12.27.31 Quit lebellium (Quit: Leaving) 12.47.51 Join mink__ [0] (~mink@2a07:3e00:81:0:7b6:4663:f93b:9fae) 12.52.23 Join rasher_ [0] (~rasher@diti.rasher.dk) 12.53.03 Join MayeulC1 [0] (~mayeulc@2001:470:69fc:105::35e) 12.55.11 Join launchd [0] (launchd@bitbot/launchd) 12.55.28 Quit MayeulC (Ping timeout: 252 seconds) 12.55.28 Quit _mink (Ping timeout: 252 seconds) 12.55.28 Quit prg (Ping timeout: 252 seconds) 12.55.28 Quit rasher (Ping timeout: 252 seconds) 12.55.29 Quit BuddyTheElf (Ping timeout: 252 seconds) 12.55.38 Join prg [0] (~prg@2001:19f0:5:9c1:1d2f:7937:5cb0:da6f) 12.58.22 Join speachy [0] (~speachy@tunnel658658-pt.tunnel.tserv12.mia1.ipv6.he.net) 12.58.22 Quit speachy (Changing host) 12.58.22 Join speachy [0] (~speachy@rockbox/developer/speachy) 12.58.22 Mode "#rockbox +v speachy" by ChanServ (ChanServ@services.libera.chat) 12.58.43 # _bilgus_: that's impressive, the www server must have died just after I visited it. 12.58.52 # I was doing more data syncing 12.59.01 # bit it's back up now. 12.59.46 # on the new host we'll have enough RAM to scale up the web server a bit. 13.00.23 Quit Malinux (Ping timeout: 256 seconds) 13.00.41 Join Malinux [0] (~malin@2001:4641:4dfa::12c:c4a7) 13.11.35 Quit mink__ (Ping timeout: 264 seconds) 13.26.10 Quit CH23_M (Read error: Connection reset by peer) 13.26.29 Join CH23_M [0] (~CH23@revspace/participant/ch23) 13.37.21 Join jacobk [0] (~quassel@47-186-81-17.dlls.tx.frontiernet.net) 13.55.55 *** Saving seen data "./dancer.seen" 14.41.45 Quit Nezumi-sama (Ping timeout: 260 seconds) 14.48.22 Join Nezumi-sama [0] (~narf@rrcs-67-53-148-69.west.biz.rr.com) 15.48.47 Quit tchan (Ping timeout: 264 seconds) 15.49.14 Join tchan [0] (~tchan@c-98-206-141-238.hsd1.il.comcast.net) 15.55.57 *** Saving seen data "./dancer.seen" 16.07.19 Quit othello7 (Quit: othello7) 16.54.41 Quit advcomp2019_ (Read error: Connection reset by peer) 17.02.02 Join advcomp2019 [0] (~advcomp20@user/advcomp2019) 17.06.16 Nick rasher_ is now known as rasher (~rasher@diti.rasher.dk) 17.06.38 Quit rasher (Changing host) 17.06.38 Join rasher [0] (~rasher@user/rasher) 17.17.05 Quit CH23 (Quit: Leaving) 17.51.08 # <_bilgus_> so new patch g#4921 still had proble,s with F_TABLE_SETTINGS not checkong table->values I think that is new the other bug we discussed in gerrit surround_enable 17.51.10 # 3Gerrit review #4921 at https://gerrit.rockbox.org/r/c/rockbox/+/4921 : 3[Bug Fix] setting.c fail to check F_TABLE_SETTING w/o arbitrary values / haas surround by William Wilgus 17.52.49 # <_bilgus_> now with surround_enable actually working I get mutex_unlock->wrong thread (buffering != audio) if I do it in quick succession, granted I did make it so the changing of delay wasn't locked (as it was previously) but it does this moving the conditional back 17.53.33 # <_bilgus_> https://gerrit.rockbox.org/r/c/rockbox/+/4921/8/lib/rbcodec/dsp/surround.c#150 17.56.01 *** Saving seen data "./dancer.seen" 18.06.54 Join CH23 [0] (~CH23@revspace/participant/ch23) 18.18.01 # <_bilgus_> make that https://gerrit.rockbox.org/r/c/rockbox/+/4922/1/lib/rbcodec/dsp/surround.c#150 18.45.31 # <_bilgus_> well it appears to only happen in the sim I can't repro on device 19.56.03 *** No seen item changed, no save performed. 20.24.39 # Build Server message: 3New build round started. Revision d520dcbfbb, 303 builds, 7 clients. 20.41.54 # Build Server message: 3Build round completed after 1035 seconds. 20.41.56 # Build Server message: 3Revision d520dcbfbb result: All green 20.52.10 # Build Server message: 3New build round started. Revision 0e2e9df991, 303 builds, 7 clients. 21.09.19 # Build Server message: 3Build round completed after 1029 seconds. 21.09.21 # Build Server message: 3Revision 0e2e9df991 result: All green 21.10.17 # Build Server message: 3New build round started. Revision 8ff2c81bde, 303 builds, 7 clients. 21.10.47 Join othello7 [0] (~Thunderbi@pool-100-36-133-223.washdc.fios.verizon.net) 21.26.02 Join advcomp2019_ [0] (~advcomp20@user/advcomp2019) 21.30.22 Quit advcomp2019 (Ping timeout: 272 seconds) 21.35.04 # Build Server message: 3Build round completed after 1486 seconds. 21.35.06 # Build Server message: 3Revision 8ff2c81bde result: All green 21.49.29 Join chris_s [0] (~chris_s@ip-095-223-073-240.um35.pools.vodafone-ip.de) 21.50.36 Quit chris_s (Client Quit) 21.56.04 *** Saving seen data "./dancer.seen" 22.00.42 # <_bilgus_> chris_s I still don't like that patch removing the splash but meh not the end of the world 22.03.19 Join chris_s [0] (~chris_s@ip-095-223-073-240.um35.pools.vodafone-ip.de) 22.05.05 # _bilgus_: Maybe I missed the use case for the splash – is there a particular plugin that takes a long time to launch.  I figured that even on old iPods , plugins seem to load pretty much immediately? 22.05.39 # <_bilgus_> my clipzip is slower but esp on lua 22.06.36 # <_bilgus_> but if anything its probably slightly faster now and the main reason is to know about crashes 22.06.48 # Is there any way to show the splash only *if* it takes longer than 0.5s to load? 22.07.42 # <_bilgus_> I debated that but thats just going to add complexity i'd almost say a heartbeat might be an idea 22.08.20 # <_bilgus_> like a few pixels on the disk activity icon or something 22.10.17 # Certainly feel free to make further changes or even put the splash back if you find it necessary. 22.10.30 # By the way, I think there's currently an issue (don't know since when) with setting the WPS hotkey plugin. 22.10.34 # It seems to revert back to the previous entry after using it once. The "open plugin" plugin then shows multiple entries for the WPS hotkey 22.14.41 # <_bilgus_> assum on a disk based device? 22.16.07 # <_bilgus_> I added some logic for disk based since they append a file and likely there is something messed up in the checksum code might try deleting the .dat file as lang changes are the driving force on that 22.16.30 # I think regardless 22.16.38 # noticed it both on the iPod and M3K 22.16.44 # <_bilgus_> since I use lang_id for that stuff every time someone moves lang_ids around it would screw it up 22.17.13 # <_bilgus_> hmm if its on a non spinning disk then IDK but i'll look at it 22.17.25 # I can see if i find the commit that caused it 22.17.49 # <_bilgus_> I've a pretty good idea 22.18.11 # <_bilgus_> as long as I can repro it then it'll be pretty easy 22.19.39 # <_bilgus_> yeah it works fine for me 22.21.32 # <_bilgus_> tried like 5 times even worked after reboot 22.22.22 # <_bilgus_> if its the spinning disk then I know what it is but if its a card based storage then idk because they do a copy each time and discard bad entries 22.24.14 # <_bilgus_> chris_s likely https://gerrit.rockbox.org/r/c/rockbox/+/4793 22.25.46 # It seems reproducible in the (iPod video) simulator at least, with a clean simdisk dir. Set the WPS context plugin, which resulted in a single entry in the "Open plugin" plugin. The context menu option worked correctly on the WPS. Then I went back to settings and set it to "Oscilloscope". Now "Open plugin" shows two entries for "WPS Context Plugin" 22.26.16 # (seems to apply to both WPS context plugin and WPS hotkey) 22.27.18 # you're right, maybe it's not actually an issue on the M3K, I may have misremembered that 22.33.44 # <_bilgus_> I probably messed up the append function i'll try the ipod sim 22.35.26 # Build Server message: 3New build round started. Revision c6c1d62489, 303 builds, 7 clients. 22.59.33 # Build Server message: 3Build round completed after 1447 seconds. 22.59.35 # Build Server message: 3Revision c6c1d62489 result: All green 23.20.19 Quit bluebrother (Ping timeout: 256 seconds) 23.20.27 Join bluebrother [0] (~dom@user/bluebrother) 23.27.57 # <_bilgus_> chris_s I found it I forgot to update the checksum code in the update fn for spinning disks 23.30.49 # awesome :) 23.36.18 # <_bilgus_> ty for the report 23.37.16 Quit m01 (Quit: Konversation terminated.) 23.37.27 # Build Server message: 3New build round started. Revision eaf717744d, 303 builds, 7 clients. 23.38.40 # sure 23.39.25 Join m01 [0] (~quassel@vps-b172b88b.vps.ovh.net) 23.41.27 # <_bilgus_> it would affect anything using a lang_id so pretty much everything in the menus and even running plugins from plugins 23.56.06 *** Saving seen data "./dancer.seen" 23.57.27 # Build Server message: 3Build round completed after 1200 seconds. 23.57.29 # Build Server message: 3Revision eaf717744d result: All green