Rockbox mail archiveSubject: Re: WPS implementation
Re: WPS implementation
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 25 Jun 2002 00:17:05 +0200 (MET DST)
On Mon, 24 Jun 2002 jerome_at_geekrox.com wrote:
> 1) playlists force back to the directory browse after the first track
> loads. I have yet to find which part of the code causes this.
Heh, yeah it looks a bit silly! ;-)
> 2) I still need to hook into the "on" button or something to allow use
> toggle of WPS.
On the Recorder, one of the functions might be a good choice.
> 3) Despite the "QUICK hack" comment, I still used peek_next_track to
> determine display time. Thus the screen gets modified before the actual mp3
We can't use peek_next_track() for that information. It is used for mp3
buffering, not for actual playback info.
> The first two are easy enough, but the third brings up questions of the
> future for WPS. A couple things I've been thinking....
> 1) Improve the interface between mpeg & peek_next_track. Since it is a
> "QUICK hack," a "fix" is required anyway.
The interface here is that the mpeg thread is supposed to read the id3 info
from the song it plays. The WPS code could then read the information freely.
That's the plan at least. I haven't yet tried to add this myself.
> 2) Insitute WPS into it's own thread to take events when to display or give
> way to the another mode (like dirbrowse). Possibly this fits into number
> 1, but is a bit more involved.
I'm not sure this needs to be a separate thread. In fact, having it as a
separate thread from the UI thread might cause more problems that it solves.
> So any help is appreciated. I haven't submitted any code, but would be
> willing to tar ball anyone on the list who requests.
I prefer a diff -u output! ;-)
Uh, btw, *great* work!
-- Daniel Stenberg -- Rocking the box => http://bjorn.haxx.se/rockbox/Received on 2002-06-25