dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: [PATCH] WPS tweak

Re: [PATCH] WPS tweak

From: Daniel Stenberg <>
Date: Tue, 6 Aug 2002 08:24:28 +0200 (MET DST)

On Mon, 5 Aug 2002, Brian King wrote:

> Here is a small WPS patch. It takes the excellent patch Magnus submitted
> and adds a couple tweaks.

I haven't tested your patch yet myself to see how it works in real life, but
I have some minor nits regarding the code:

strrtok_r() - this is a very "official looking" function that might very
well be useful to others, so this should go into the firmware/common/
directory imho.

Possibly we could do the same with the strfmt() function you use. I'd suggest
a better name in that case though.

The firmware/API file is also lagging behind terribly and should be updated
to contain the full actual firmware API available. Any taker?

  Daniel "Bagder" Stenberg --
Received on 2002-08-06

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy