Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: [PATCH] WPS tweak

Re: [PATCH] WPS tweak

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 6 Aug 2002 08:24:28 +0200 (MET DST)

On Mon, 5 Aug 2002, Brian King wrote:

> Here is a small WPS patch. It takes the excellent patch Magnus submitted
> and adds a couple tweaks.

I haven't tested your patch yet myself to see how it works in real life, but
I have some minor nits regarding the code:

strrtok_r() - this is a very "official looking" function that might very
well be useful to others, so this should go into the firmware/common/
directory imho.

Possibly we could do the same with the strfmt() function you use. I'd suggest
a better name in that case though.

The firmware/API file is also lagging behind terribly and should be updated
to contain the full actual firmware API available. Any taker?

-- 
  Daniel "Bagder" Stenberg -- http://bjorn.haxx.se/rockbox/
Received on 2002-08-06

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew