Rockbox mail archive
Subject: Re: cvs: firmware/drivers lcd.c,1.76,1.77 lcd.h,1.21,1.22Re: cvs: firmware/drivers lcd.c,1.76,1.77 lcd.h,1.21,1.22
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Björn Stenberg <bjorn_at_haxx.se>
Date: Fri, 9 Aug 2002 14:31:59 +0200
Markus Braun wrote:
> + if (x>LCD_WIDTH) return;
> + if (y>LCD_HEIGHT) return;
> +
> + if (x+nx>LCD_WIDTH) nx=LCD_WIDTH-x;
> + if (y+ny>LCD_HEIGHT) ny=LCD_HEIGHT-y;
Please dont "save lines" by putting condition and action on the same line like this. It may look simpler, but it actually makes the code harder to scan.
/The Code Police
Date: Fri, 9 Aug 2002 14:31:59 +0200
Markus Braun wrote:
> + if (x>LCD_WIDTH) return;
> + if (y>LCD_HEIGHT) return;
> +
> + if (x+nx>LCD_WIDTH) nx=LCD_WIDTH-x;
> + if (y+ny>LCD_HEIGHT) ny=LCD_HEIGHT-y;
Please dont "save lines" by putting condition and action on the same line like this. It may look simpler, but it actually makes the code harder to scan.
/The Code Police
-- BjörnReceived on 2002-08-09
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy