Rockbox mail archiveSubject: Re: Tracknum
From: Magnus Holmgren <lear_at_algonet.se>
Date: Sun, 18 Aug 2002 12:30:34 +0200 (CEST)
Den 16 Aug 2002 skrev Daniel Stenberg:
> > An easy fix (that seems to work) is to remove the size check in id3.c at
> > line 605, that is, the "entry->id3v2len <= sizeof( entry->id3v2buf )" part.
> > The ID3V2 loader will only read up to the size of the buffer anyway.
> The buffer it stores the data in is only sizeof(entry->id3v2buf) bytes large,
> if you remove the check it means it'll do a buffer overflow. Won't it?
The ID3V2 code will not read more than fits in the buffer (check the read statement). Thus, there should be no buffer overflow. But there might be problems during parse... (I do have problems with a few files, but I don't know why yet; will take a look at it later today.)
Received on 2002-08-18