Rockbox mail archiveSubject: [PATCH] mp2 filenames
[PATCH] mp2 filenames
From: Dave Chapman <dave_at_dchapman.com>
Date: Wed, 28 Aug 2002 12:40:16 +0100
I finally bought an Archos JBR20 and my first patch is to allow me to call
my Layer 2 files ".mp2".
In fact, the included patch allows all filenames ending with ".mp?". If the
maintainers don't like that, then I would suggest that ".mp3", ".mp2" and
".mpa" all be recognised as legal MPEG audio files.
I have left the TREE_ATTR_MP3 constant as it is. However, IMHO a better name
would be TREE_ATTR_MPA - for "MPeg Audio".
I have CVS write access (from my early contributions to the uisimulator), so
if no-one complains about this patch, I'll commit it. Should I make the
"MPA" change as well?
diff -r1.102 tree.c
< /* mark mp3 and m3u files as such */
--- > /* mark mp? and m3u files as such */ 218c218 < if (!strcasecmp(&entry->d_name[len-4], ".mp3")) --- > if (!strncasecmp(&entry->d_name[len-4], ".mp",3))Received on 2002-08-28