Rockbox mail archiveSubject: Re: [PATCH] ff/rewind acceleration
Re: [PATCH] ff/rewind acceleration
From: Nate Nystrom <nystrom_at_cs.cornell.edu>
Date: Wed, 28 Aug 2002 11:36:26 -0400
On Wed Aug 28 09:27:13 -0400 2002, M. OReilly wrote:
> Might I suggest that a cap be put on the doubling feature? Holding down ff
> in a very long song could potentially be disastrous by the time one reaches
> even 21 seconds (which will then be skipping by 128-second increments, if it
> starts at 1 second). Perhaps a max value of ~30 seconds per second of ff?
> Oh, wait, I think I see it. I'm not really good at reading C code, but does
> the FF_REWIND_MAX_STEP does exactly what I've asked above? (1000
> milliseconds * 30)
> If so, sorry for being redundant. :-)
Oops, sorry I didn't put that constant somewhere more obvious. I just
added that temporarily to try it out and then forgot to clean it up.
I'm note sure if it should be a compile time option or not. I'll clean
it up, unless someone else beats me to it.
Received on 2002-08-28